18
18
"""Tests for the formatting and construction of errors."""
20
import bzrlib.bzrdir as bzrdir
21
import bzrlib.errors as errors
22
from bzrlib.tests import TestCaseWithTransport
24
from bzrlib.tests import TestCase, TestCaseWithTransport
27
# TODO: Make sure builtin exception class formats are consistent - e.g. should
28
# or shouldn't end with a full stop, etc.
25
31
class TestErrors(TestCaseWithTransport):
33
def test_duplicate_file_id(self):
34
error = errors.DuplicateFileId('a_file_id', 'foo')
35
self.assertEqualDiff('File id {a_file_id} already exists in inventory'
36
' as foo', str(error))
38
def test_inventory_modified(self):
39
error = errors.InventoryModified("a tree to be repred")
40
self.assertEqualDiff("The current inventory for the tree 'a tree to "
41
"be repred' has been modified, so a clean inventory cannot be "
42
"read without data loss.",
45
def test_install_failed(self):
46
error = errors.InstallFailed(['rev-one'])
47
self.assertEqual("Could not install revisions:\nrev-one", str(error))
48
error = errors.InstallFailed(['rev-one', 'rev-two'])
49
self.assertEqual("Could not install revisions:\nrev-one, rev-two",
51
error = errors.InstallFailed([None])
52
self.assertEqual("Could not install revisions:\nNone", str(error))
54
def test_lock_active(self):
55
error = errors.LockActive("lock description")
56
self.assertEqualDiff("The lock for 'lock description' is in use and "
60
def test_knit_header_error(self):
61
error = errors.KnitHeaderError('line foo\n', 'path/to/file')
62
self.assertEqual("Knit header error: 'line foo\\n' unexpected"
63
" for file path/to/file", str(error))
65
def test_knit_index_unknown_method(self):
66
error = errors.KnitIndexUnknownMethod('http://host/foo.kndx',
68
self.assertEqual("Knit index http://host/foo.kndx does not have a"
69
" known method in options: ['bad', 'no-eol']",
72
def test_medium_not_connected(self):
73
error = errors.MediumNotConnected("a medium")
75
"The medium 'a medium' is not connected.", str(error))
27
77
def test_no_repo(self):
28
78
dir = bzrdir.BzrDir.create(self.get_url())
29
79
error = errors.NoRepositoryPresent(dir)
30
self.assertNotEqual(-1, str(error).find(repr(dir.transport.clone('..').base)))
31
self.assertEqual(-1, str(error).find(repr(dir.transport.base)))
80
self.assertNotEqual(-1, str(error).find((dir.transport.clone('..').base)))
81
self.assertEqual(-1, str(error).find((dir.transport.base)))
83
def test_no_smart_medium(self):
84
error = errors.NoSmartMedium("a transport")
85
self.assertEqualDiff("The transport 'a transport' cannot tunnel the "
89
def test_no_such_id(self):
90
error = errors.NoSuchId("atree", "anid")
91
self.assertEqualDiff("The file id anid is not present in the tree "
95
def test_no_such_revision_in_tree(self):
96
error = errors.NoSuchRevisionInTree("atree", "anid")
97
self.assertEqualDiff("The revision id anid is not present in the tree "
100
self.assertIsInstance(error, errors.NoSuchRevision)
102
def test_not_write_locked(self):
103
error = errors.NotWriteLocked('a thing to repr')
104
self.assertEqualDiff("'a thing to repr' is not write locked but needs "
108
def test_too_many_concurrent_requests(self):
109
error = errors.TooManyConcurrentRequests("a medium")
110
self.assertEqualDiff("The medium 'a medium' has reached its concurrent "
111
"request limit. Be sure to finish_writing and finish_reading on "
112
"the current request that is open.",
115
def test_unknown_hook(self):
116
error = errors.UnknownHook("branch", "foo")
117
self.assertEqualDiff("The branch hook 'foo' is unknown in this version"
120
error = errors.UnknownHook("tree", "bar")
121
self.assertEqualDiff("The tree hook 'bar' is unknown in this version"
33
125
def test_up_to_date(self):
34
126
error = errors.UpToDateFormat(bzrdir.BzrDirFormat4())
44
136
"Please run bzr reconcile on this repository." %
45
137
repo.bzrdir.root_transport.base,
140
def test_bzrnewerror_is_deprecated(self):
141
class DeprecatedError(errors.BzrNewError):
143
self.callDeprecated(['BzrNewError was deprecated in bzr 0.13; '
144
'please convert DeprecatedError to use BzrError instead'],
147
def test_bzrerror_from_literal_string(self):
148
# Some code constructs BzrError from a literal string, in which case
149
# no further formatting is done. (I'm not sure raising the base class
150
# is a great idea, but if the exception is not intended to be caught
151
# perhaps no more is needed.)
153
raise errors.BzrError('this is my errors; %d is not expanded')
154
except errors.BzrError, e:
155
self.assertEqual('this is my errors; %d is not expanded', str(e))
157
def test_reading_completed(self):
158
error = errors.ReadingCompleted("a request")
159
self.assertEqualDiff("The MediumRequest 'a request' has already had "
160
"finish_reading called upon it - the request has been completed and"
161
" no more data may be read.",
164
def test_writing_completed(self):
165
error = errors.WritingCompleted("a request")
166
self.assertEqualDiff("The MediumRequest 'a request' has already had "
167
"finish_writing called upon it - accept bytes may not be called "
171
def test_writing_not_completed(self):
172
error = errors.WritingNotComplete("a request")
173
self.assertEqualDiff("The MediumRequest 'a request' has not has "
174
"finish_writing called upon it - until the write phase is complete"
175
" no data may be read.",
178
def test_transport_not_possible(self):
179
e = errors.TransportNotPossible('readonly', 'original error')
180
self.assertEqual('Transport operation not possible:'
181
' readonly original error', str(e))
183
def assertSocketConnectionError(self, expected, *args, **kwargs):
184
"""Check the formatting of a SocketConnectionError exception"""
185
e = errors.SocketConnectionError(*args, **kwargs)
186
self.assertEqual(expected, str(e))
188
def test_socket_connection_error(self):
189
"""Test the formatting of SocketConnectionError"""
191
# There should be a default msg about failing to connect
192
# we only require a host name.
193
self.assertSocketConnectionError(
194
'Failed to connect to ahost',
197
# If port is None, we don't put :None
198
self.assertSocketConnectionError(
199
'Failed to connect to ahost',
201
# But if port is supplied we include it
202
self.assertSocketConnectionError(
203
'Failed to connect to ahost:22',
206
# We can also supply extra information about the error
207
# with or without a port
208
self.assertSocketConnectionError(
209
'Failed to connect to ahost:22; bogus error',
210
'ahost', port=22, orig_error='bogus error')
211
self.assertSocketConnectionError(
212
'Failed to connect to ahost; bogus error',
213
'ahost', orig_error='bogus error')
214
# An exception object can be passed rather than a string
215
orig_error = ValueError('bad value')
216
self.assertSocketConnectionError(
217
'Failed to connect to ahost; %s' % (str(orig_error),),
218
host='ahost', orig_error=orig_error)
220
# And we can supply a custom failure message
221
self.assertSocketConnectionError(
222
'Unable to connect to ssh host ahost:444; my_error',
223
host='ahost', port=444, msg='Unable to connect to ssh host',
224
orig_error='my_error')
228
class PassThroughError(errors.BzrError):
230
_fmt = """Pass through %(foo)s and %(bar)s"""
232
def __init__(self, foo, bar):
233
errors.BzrError.__init__(self, foo=foo, bar=bar)
236
class ErrorWithBadFormat(errors.BzrError):
238
_fmt = """One format specifier: %(thing)s"""
241
class ErrorWithNoFormat(errors.BzrError):
242
"""This class has a docstring but no format string."""
245
class TestErrorFormatting(TestCase):
247
def test_always_str(self):
248
e = PassThroughError(u'\xb5', 'bar')
249
self.assertIsInstance(e.__str__(), str)
250
# In Python str(foo) *must* return a real byte string
251
# not a Unicode string. The following line would raise a
252
# Unicode error, because it tries to call str() on the string
253
# returned from e.__str__(), and it has non ascii characters
255
self.assertEqual('Pass through \xc2\xb5 and bar', s)
257
def test_missing_format_string(self):
258
e = ErrorWithNoFormat(param='randomvalue')
259
s = self.callDeprecated(
260
['ErrorWithNoFormat uses its docstring as a format, it should use _fmt instead'],
264
"This class has a docstring but no format string.")
266
def test_mismatched_format_args(self):
267
# Even though ErrorWithBadFormat's format string does not match the
268
# arguments we constructing it with, we can still stringify an instance
269
# of this exception. The resulting string will say its unprintable.
270
e = ErrorWithBadFormat(not_thing='x')
271
self.assertStartsWith(
272
str(e), 'Unprintable exception ErrorWithBadFormat')
added
removed
bzrlib/tests/test_errors.py
