« back to all changes in this revision
Viewing changes to bzrlib/smart/repository.py
- Committer: John Arbash Meinel
- Date: 2012-09-06 11:19:35 UTC
- mto: (6437.63.7 2.5)
- mto: This revision was merged to the branch mainline in revision 6563.
- Revision ID: john@arbash-meinel.com-20120906111935-m4p8prgxohkg9ywy
record_stream wasn't being iterated to completion.
This meant that we didn't always finalize a nested_progress_bar.
Which meant that our test suite thought we were at a depth >1.
Which meant that ProgressRecordingUIFactory was discarding
the update messages.
So wrap the progress bar in a try/finally. That way when the
generator exits, we get a proper cleanup.
Note that record_stream is generally driven by iterating the
stream and stepping it, so it isn't too surprising that
we weren't stepping that one final time to trigger generator
teardown.
This meant that we didn't always finalize a nested_progress_bar.
Which meant that our test suite thought we were at a depth >1.
Which meant that ProgressRecordingUIFactory was discarding
the update messages.
So wrap the progress bar in a try/finally. That way when the
generator exits, we get a proper cleanup.
Note that record_stream is generally driven by iterating the
stream and stepping it, so it isn't too surprising that
we weren't stepping that one final time to trigger generator
teardown.
- files modified:
- bzrlib/smart/repository.py
added
removed
bzrlib/smart/repository.py
