« back to all changes in this revision
Viewing changes to bzrlib/tests/test_smart_transport.py
- Committer: John Arbash Meinel
- Date: 2011-09-23 16:40:32 UTC
- mto: This revision was merged to the branch mainline in revision 6170.
- Revision ID: john@arbash-meinel.com-20110923164032-15duj1g3hj49ww53
Now we've implemented the basic structure.
I tested it manually, and it works as we wanted, the server waits for the current
request to stop, but keeps running until it does so. Once the current request
has finished, it closes the connection to the client.
There are now a couple of race conditions in the test suite. I caught a couple
of them, like the connection thread was being started before we added it to
the list of active connections.
The next race that I know of, is the test suite expects that a request&response
finish is enough for us to have run _poll_active_connections.
However, there is no actual interlocking there.
So we actually need to do a new connection, which may give us 1-or-2 active
connections, but then we can check if the old handler is still around.
I tested it manually, and it works as we wanted, the server waits for the current
request to stop, but keeps running until it does so. Once the current request
has finished, it closes the connection to the client.
There are now a couple of race conditions in the test suite. I caught a couple
of them, like the connection thread was being started before we added it to
the list of active connections.
The next race that I know of, is the test suite expects that a request&response
finish is enough for us to have run _poll_active_connections.
However, there is no actual interlocking there.
So we actually need to do a new connection, which may give us 1-or-2 active
connections, but then we can check if the old handler is still around.
added
removed
bzrlib/tests/test_smart_transport.py
