← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_fifo_cache.py

  • Committer: Canonical.com Patch Queue Manager
  • Date: 2011-06-29 17:19:58 UTC
  • mfrom: (5967.8.4 rm-del-methods)
  • Revision ID: pqm@pqm.ubuntu.com-20110629171958-u8a6lkpw5kdnfm55
(mbp) remove most __del__ methods (Martin Pool)

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_fifo_cache.py
229
229
        c = fifo_cache.FIFOCache()
230
230
        c.add(1, 2, cleanup=logging_cleanup)
231
231
        del c
232
 
        # TODO: We currently don't support calling the cleanup() funcs during
233
 
        #       __del__. We might want to consider implementing this.
234
 
        self.expectFailure("we don't call cleanups during __del__",
235
 
                           self.assertEqual, [(1, 2)], log)
236
 
        self.assertEqual([(1, 2)], log)
 
232
        # As a matter of design, bzr does not (can not) count on anything
 
233
        # being run from Python __del__ methods, because they may not run for
 
234
        # a long time, and because in cPython merely having them defined
 
235
        # interferes with garbage collection.
 
236
        self.assertEqual([], log)
237
237
 
238
238
 
239
239
class TestFIFOSizeCache(tests.TestCase):