~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to doc/developers/HACKING.txt

  • Committer: John Arbash Meinel
  • Date: 2010-02-10 17:52:08 UTC
  • mfrom: (5021 +trunk)
  • mto: This revision was merged to the branch mainline in revision 5023.
  • Revision ID: john@arbash-meinel.com-20100210175208-bubuwav4uqigu291
Merge bzr.dev 5021 to resolve NEWS

Show diffs side-by-side

added added

removed removed

Lines of Context:
120
120
`your_lp_username`.  You can push your branch to Launchpad directly from
121
121
Bazaar::
122
122
 
123
 
  $ bzr push lp:~your_lp_username/bzr/giveback
 
123
  $ bzr push lp:~your_lp_username/bzr/meaningful_name_here
124
124
 
125
125
After you have pushed your branch, you will need to propose it for merging to
126
 
the Bazaar trunk.  Go to <https://launchpad.net/your_lp_username/bzr/giveback>
127
 
and choose "Propose for merging into another branch".  Select "~bzr/bzr/trunk"
128
 
to hand your changes off to the Bazaar developers for review and merging.
 
126
the Bazaar trunk.  Go to
 
127
<https://launchpad.net/your_lp_username/bzr/meaningful_name_here> and choose
 
128
"Propose for merging into another branch".  Select "~bzr/bzr/trunk" to hand
 
129
your changes off to the Bazaar developers for review and merging.
 
130
 
 
131
Using a meaningful name for your branch will help you and the reviewer(s)
 
132
better track the submission. Use a very succint description of your submission
 
133
and prefix it with bug number if needed (lp:~mbp/bzr/484558-merge-directory
 
134
for example). Alternatively, you can suffix with the bug number
 
135
(lp:~jameinel/bzr/export-file-511987).
 
136
 
129
137
 
130
138
Why make a local copy of bzr.dev?
131
139
---------------------------------
689
697
 
690
698
In some places we have variables which point to callables that construct
691
699
new instances.  That is to say, they can be used a lot like class objects,
692
 
but they shouldn't be *named* like classes:
 
700
but they shouldn't be *named* like classes::
693
701
 
694
702
> I think that things named FooBar should create instances of FooBar when
695
703
> called. Its plain confusing for them to do otherwise. When we have
723
731
those parameters, and this instance then has methods for operations
724
732
between the objects.
725
733
 
 
734
::
 
735
 
726
736
  inter = InterRepository.get(source_repo, target_repo)
727
737
  inter.fetch(revision_id)
728
738