← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/per_workingtree/test_readonly.py

  • Committer: Vincent Ladeuil
  • Date: 2010-01-25 15:55:48 UTC
  • mto: (4985.1.4 add-attr-cleanup)
  • mto: This revision was merged to the branch mainline in revision 4988.
  • Revision ID: v.ladeuil+lp@free.fr-20100125155548-0l352pujvt5bzl5e
Deploy addAttrCleanup on the whole test suite.

Several use case worth mentioning:

- setting a module or any other object attribute is the majority
by far. In some cases the setting itself is deferred but most of
the time we want to set at the same time we add the cleanup.

- there multiple occurrences of protecting hooks or ui factory
which are now useless (the test framework takes care of that now),

- there was some lambda uses that can now be avoided.

That first cleanup already simplifies things a lot.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/per_workingtree/test_readonly.py
60
60
 
61
61
    def set_dirs_readonly(self, basedir):
62
62
        """Set all directories readonly, and have it cleanup on test exit."""
 
63
        self.addCleanup(self._set_all_dirs, basedir, readonly=False)
63
64
        self._set_all_dirs(basedir, readonly=True)
64
65
 
65
 
        def cleanup():
66
 
            self._set_all_dirs(basedir, readonly=False)
67
 
 
68
 
        self.addCleanup(cleanup)
69
 
 
70
66
    def create_basic_tree(self):
71
67
        tree = self.make_branch_and_tree('tree')
72
68
        self.build_tree(['tree/a', 'tree/b/', 'tree/b/c'])