~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/per_pack_repository.py

  • Committer: Vincent Ladeuil
  • Date: 2010-01-25 15:55:48 UTC
  • mto: (4985.1.4 add-attr-cleanup)
  • mto: This revision was merged to the branch mainline in revision 4988.
  • Revision ID: v.ladeuil+lp@free.fr-20100125155548-0l352pujvt5bzl5e
Deploy addAttrCleanup on the whole test suite.

Several use case worth mentioning:

- setting a module or any other object attribute is the majority
by far. In some cases the setting itself is deferred but most of
the time we want to set at the same time we add the cleanup.

- there multiple occurrences of protecting hooks or ui factory
which are now useless (the test framework takes care of that now),

- there was some lambda uses that can now be avoided.

That first cleanup already simplifies things a lot.

Show diffs side-by-side

added added

removed removed

Lines of Context:
588
588
        self.assertFalse(repo.get_physical_lock_status())
589
589
 
590
590
    def prepare_for_break_lock(self):
 
591
        self.addAttrCleanup(ui, 'ui_factory')
591
592
        # Setup the global ui factory state so that a break-lock method call
592
593
        # will find usable input in the input stream.
593
 
        old_factory = ui.ui_factory
594
 
        def restoreFactory():
595
 
            ui.ui_factory = old_factory
596
 
        self.addCleanup(restoreFactory)
597
594
        ui.ui_factory = ui.CannedInputUIFactory([True])
598
595
 
599
596
    def test_break_lock_breaks_physical_lock(self):