~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/benchmarks/bench_knit.py

  • Committer: Vincent Ladeuil
  • Date: 2010-01-25 15:55:48 UTC
  • mto: (4985.1.4 add-attr-cleanup)
  • mto: This revision was merged to the branch mainline in revision 4988.
  • Revision ID: v.ladeuil+lp@free.fr-20100125155548-0l352pujvt5bzl5e
Deploy addAttrCleanup on the whole test suite.

Several use case worth mentioning:

- setting a module or any other object attribute is the majority
by far. In some cases the setting itself is deferred but most of
the time we want to set at the same time we add the cleanup.

- there multiple occurrences of protecting hooks or ui factory
which are now useless (the test framework takes care of that now),

- there was some lambda uses that can now be avoided.

That first cleanup already simplifies things a lot.

Show diffs side-by-side

added added

removed removed

Lines of Context:
61
61
 
62
62
    def setup_load_data_c(self):
63
63
        self.requireFeature(CompiledKnitFeature)
64
 
        orig = knit._load_data
65
 
        def reset():
66
 
            knit._load_data = orig
67
 
        self.addCleanup(reset)
 
64
        self.addAttrCleanup(knit, '_load_data')
68
65
        from bzrlib._knit_load_data_pyx import _load_data_c
69
66
        knit._load_data = _load_data_c
70
67
 
71
68
    def setup_load_data_py(self):
72
 
        orig = knit._load_data
73
 
        def reset():
74
 
            knit._load_data = orig
75
 
        self.addCleanup(reset)
 
69
        self.addAttrCleanup(knit, '_load_data')
76
70
        from bzrlib._knit_load_data_py import _load_data_py
77
71
        knit._load_data = _load_data_py
78
72