~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/xml_serializer.py

  • Committer: Canonical.com Patch Queue Manager
  • Date: 2009-12-10 17:35:37 UTC
  • mfrom: (4849.4.3 2.1.0b4-xml8)
  • Revision ID: pqm@pqm.ubuntu.com-20091210173537-7gui2z64ki7nioit
(jam) Faster conversions by enabling re-use of cached
        InventoryEntries.

Show diffs side-by-side

added added

removed removed

Lines of Context:
55
55
    squashes_xml_invalid_characters = True
56
56
 
57
57
    def read_inventory_from_string(self, xml_string, revision_id=None,
58
 
                                   entry_cache=None):
 
58
                                   entry_cache=None, return_from_cache=False):
59
59
        """Read xml_string into an inventory object.
60
60
 
61
61
        :param xml_string: The xml to read.
69
69
        :param entry_cache: An optional cache of InventoryEntry objects. If
70
70
            supplied we will look up entries via (file_id, revision_id) which
71
71
            should map to a valid InventoryEntry (File/Directory/etc) object.
 
72
        :param return_from_cache: Return entries directly from the cache,
 
73
            rather than copying them first. This is only safe if the caller
 
74
            promises not to mutate the returned inventory entries, but it can
 
75
            make some operations significantly faster.
72
76
        """
73
77
        try:
74
78
            return self._unpack_inventory(fromstring(xml_string), revision_id,
75
 
                                          entry_cache=entry_cache)
 
79
                                          entry_cache=entry_cache,
 
80
                                          return_from_cache=return_from_cache)
76
81
        except ParseError, e:
77
82
            raise errors.UnexpectedInventoryFormat(e)
78
83