← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/msgeditor.py

  • Committer: John Arbash Meinel
  • Date: 2009-11-17 23:05:04 UTC
  • mto: This revision was merged to the branch mainline in revision 4806.
  • Revision ID: john@arbash-meinel.com-20091117230504-p05mbkihim789aq7
Document a bit more what 193 means, and why we are testing it.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/msgeditor.py
64
64
            x = call(edargs + [filename])
65
65
        except OSError, e:
66
66
            # We're searching for an editor, so catch safe errors and continue
 
67
            # errno 193 is ERROR_BAD_EXE_FORMAT on Windows. Python2.4 uses the
 
68
            # winerror for errno. Python2.5+ use errno ENOEXEC and set winerror
 
69
            # to 193. However, catching 193 here should be fine. Other
 
70
            # platforms aren't likely to have that high of an error. And even
 
71
            # if they do, it is still reasonable to fall back to the next
 
72
            # editor.
67
73
            if e.errno in (errno.ENOENT, errno.EACCES, errno.ENOEXEC, 193):
68
74
                if candidate_source is not None:
69
75
                    # We tried this editor because some user configuration (an