← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/plugins/launchpad/lp_api.py

  • Committer: Jonathan Lange
  • Date: 2009-12-16 04:56:39 UTC
  • mto: This revision was merged to the branch mainline in revision 4907.
  • Revision ID: jml@canonical.com-20091216045639-2o0clmagxxv3nqfo
Add some XXX comments based on the review.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/plugins/launchpad/lp_api.py
36
36
from lazr.uri import URI
37
37
 
38
38
 
 
39
# XXX: Not the right value for Windows
39
40
CACHE_DIRECTORY = os.path.expanduser('~/.launchpadlib/cache')
40
41
 
41
42
 
104
105
    launchpad = _login_from_cache(
105
106
        'bzr', _get_api_url(service), CACHE_DIRECTORY, credential_path,
106
107
        timeout, proxy_info)
 
108
    # XXX: Why does this set the private member of a class?
107
109
    launchpad._service = service
108
110
    return launchpad
109
111
 
117
119
        `branch`.
118
120
    :return: A launchpadlib Branch object.
119
121
    """
 
122
    # XXX: Why does this need service and _guess_branch_path?
120
123
    service = launchpad._service
121
124
    for url in branch.get_public_branch(), branch.get_push_location():
122
125
        if url is None: