← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/uncommit.py

  • Committer: John Arbash Meinel
  • Date: 2008-05-30 21:44:30 UTC
  • mfrom: (3462 +trunk)
  • mto: This revision was merged to the branch mainline in revision 3463.
  • Revision ID: john@arbash-meinel.com-20080530214430-nbo0wxzbid6z22ml
merge bzr.dev, resolve NEWS

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/uncommit.py
35
35
    :param dry_run: Don't actually change anything
36
36
    :param verbose: Print each step as you do it
37
37
    :param revno: Remove back to this revision
 
38
    :param local: If this branch is bound, only remove the revisions from the
 
39
        local branch. If this branch is not bound, it is an error to pass
 
40
        local=True.
38
41
    """
39
42
    unlockable = []
40
43
    try:
58
61
            if master is not None:
59
62
                master.lock_write()
60
63
                unlockable.append(master)
61
 
        rh = branch.revision_history()
62
 
        if master is not None and rh[-1] != master.last_revision():
 
64
        old_revno, old_tip = branch.last_revision_info()
 
65
        if master is not None and old_tip != master.last_revision():
63
66
            raise BoundBranchOutOfDate(branch, master)
64
67
        if revno is None:
65
 
            revno = len(rh)
66
 
        old_revno, old_tip = branch.last_revision_info()
67
 
        new_revno = revno -1
 
68
            revno = old_revno
 
69
        new_revno = revno - 1
68
70
 
69
 
        files_to_remove = []
70
 
        for r in range(revno-1, len(rh)):
71
 
            rev_id = rh.pop()
72
 
            # NB: performance would be better using the revision graph rather
73
 
            # than the whole revision.
74
 
            rev = branch.repository.get_revision(rev_id)
 
71
        revid_iterator = branch.repository.iter_reverse_revision_history(
 
72
                            old_tip)
 
73
        cur_revno = old_revno
 
74
        new_revision_id = old_tip
 
75
        graph = branch.repository.get_graph()
 
76
        for rev_id in revid_iterator:
 
77
            if cur_revno == new_revno:
 
78
                new_revision_id = rev_id
 
79
                break
 
80
            if verbose:
 
81
                print 'Removing revno %d: %s' % (cur_revno, rev_id)
 
82
            cur_revno -= 1
 
83
            parents = graph.get_parent_map([rev_id]).get(rev_id, None)
 
84
            if not parents:
 
85
                continue
75
86
            # When we finish popping off the pending merges, we want
76
87
            # them to stay in the order that they used to be.
77
88
            # but we pop from the end, so reverse the order, and
78
89
            # then get the order right at the end
79
 
            pending_merges.extend(reversed(rev.parent_ids[1:]))
80
 
            if verbose:
81
 
                print 'Removing revno %d: %s' % (len(rh)+1, rev_id)
 
90
            pending_merges.extend(reversed(parents[1:]))
 
91
        else:
 
92
            # We ran off the end of revisions, which means we should be trying
 
93
            # to get to NULL_REVISION
 
94
            new_revision_id = _mod_revision.NULL_REVISION
82
95
 
83
 
        # Committing before we start removing files, because
84
 
        # once we have removed at least one, all the rest are invalid.
85
96
        if not dry_run:
86
97
            if master is not None:
87
 
                master.set_revision_history(rh)
88
 
            branch.set_revision_history(rh)
89
 
            new_tip = _mod_revision.ensure_null(branch.last_revision())
 
98
                master.set_last_revision_info(new_revno, new_revision_id)
 
99
            branch.set_last_revision_info(new_revno, new_revision_id)
90
100
            if master is None:
91
101
                hook_local = None
92
102
                hook_master = branch
94
104
                hook_local = branch
95
105
                hook_master = master
96
106
            for hook in Branch.hooks['post_uncommit']:
97
 
                hook_new_tip = new_tip
 
107
                hook_new_tip = new_revision_id
98
108
                if hook_new_tip == _mod_revision.NULL_REVISION:
99
109
                    hook_new_tip = None
100
110
                hook(hook_local, hook_master, old_revno, old_tip, new_revno,
101
111
                     hook_new_tip)
102
112
            if tree is not None:
103
 
                if not _mod_revision.is_null(new_tip):
104
 
                    parents = [new_tip]
 
113
                if not _mod_revision.is_null(new_revision_id):
 
114
                    parents = [new_revision_id]
105
115
                else:
106
116
                    parents = []
107
117
                parents.extend(reversed(pending_merges))