← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/versionedfile.py

  • Committer: Martin Pool
  • Date: 2008-04-24 07:22:53 UTC
  • mto: This revision was merged to the branch mainline in revision 3415.
  • Revision ID: mbp@sourcefrog.net-20080424072253-opmjij7xfy38w27f
Remove every assert statement from bzrlib!

Depending on the context they are:

 * turned into an explicit if/raise of either AssertionError 
   or something more specific -- particularly where they protect
   programming interfaces, complex invariants, or data file integrity
 * removed, if they're redundant with a later check, not protecting
   a meaningful invariant
 * turned into a selftest method on tests

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/versionedfile.py
712
712
                ch_b = ch_a = True
713
713
                lines_b.append(line)
714
714
            else:
715
 
                assert state in ('irrelevant', 'ghost-a', 'ghost-b', 
716
 
                                 'killed-base', 'killed-both'), state
 
715
                if state not in ('irrelevant', 'ghost-a', 'ghost-b',
 
716
                        'killed-base', 'killed-both'):
 
717
                    raise AssertionError(state)
717
718
        for struct in outstanding_struct():
718
719
            yield struct
719
720