← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/revisionspec.py

  • Committer: Martin Pool
  • Date: 2008-04-24 07:22:53 UTC
  • mto: This revision was merged to the branch mainline in revision 3415.
  • Revision ID: mbp@sourcefrog.net-20080424072253-opmjij7xfy38w27f
Remove every assert statement from bzrlib!

Depending on the context they are:

 * turned into an explicit if/raise of either AssertionError 
   or something more specific -- particularly where they protect
   programming interfaces, complex invariants, or data file integrity
 * removed, if they're redundant with a later check, not protecting
   a meaningful invariant
 * turned into a selftest method on tests

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/revisionspec.py
160
160
 
161
161
        if spec is None:
162
162
            return RevisionSpec(None, _internal=True)
163
 
 
164
 
        assert isinstance(spec, basestring), \
165
 
            "You should only supply strings not %s" % (type(spec),)
166
 
 
167
163
        for spectype in SPEC_TYPES:
168
164
            if spec.startswith(spectype.prefix):
169
165
                trace.mutter('Returning RevisionSpec %s for %s',