~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/fetch.py

  • Committer: Andrew Bennetts
  • Date: 2007-08-08 06:23:16 UTC
  • mto: (2535.3.37 repo-refactor)
  • mto: This revision was merged to the branch mainline in revision 2713.
  • Revision ID: andrew.bennetts@canonical.com-20070808062316-1baiqpdwfzvznju1
Rename get_data_to_fetch_for_revision_ids as item_keys_introduced_by.

Show diffs side-by-side

added added

removed removed

Lines of Context:
142
142
        if revs is None:
143
143
            return
144
144
        # The first phase is "file".  We pass the progress bar for it directly
145
 
        # into get_data_to_fetch_for_revision_ids, which has more information
146
 
        # about how that phase is progressing than we do.  Progress updates for
147
 
        # the other phases are taken care of in this function.
 
145
        # into item_keys_introduced_by, which has more information about how
 
146
        # that phase is progressing than we do.  Progress updates for the other
 
147
        # phases are taken care of in this function.
148
148
        # XXX: there should be a clear owner of the progress reporting.  Perhaps
149
 
        # get_data_to_fetch_for_revision_ids should have a richer API than it
150
 
        # does at the moment, so that it can feed the progress information back
151
 
        # to this function?
 
149
        # item_keys_introduced_by should have a richer API than it does at the
 
150
        # moment, so that it can feed the progress information back to this
 
151
        # function?
152
152
        phase = 'file'
153
153
        pb = bzrlib.ui.ui_factory.nested_progress_bar()
154
154
        try:
155
 
            data_to_fetch = self.from_repository.get_data_to_fetch_for_revision_ids(revs, pb)
 
155
            data_to_fetch = self.from_repository.item_keys_introduced_by(revs, pb)
156
156
            for knit_kind, file_id, revisions in data_to_fetch:
157
157
                if knit_kind != phase:
158
158
                    phase = knit_kind