← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/lockdir.py

  • Committer: Martin Pool
  • Date: 2007-06-27 08:13:53 UTC
  • mto: This revision was merged to the branch mainline in revision 2584.
  • Revision ID: mbp@sourcefrog.net-20070627081353-f3402usvh4zlcs7q
Remove unnecessary confirmation after acquiring LockDir

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/lockdir.py
223
223
 
224
224
            self.transport.rename(tmpname, self._held_dir)
225
225
            self._lock_held = True
226
 
            self.confirm()
 
226
            # we used to do self.confirm() at this point, but it's really
 
227
            # unnecessary, we have no substantial chance of having it broken
 
228
            # just as it's acquired, and we believe that this lock design is
 
229
            # safe on all platforms.
227
230
            # FIXME: we should remove the pending lock if we fail, 
228
231
            # https://bugs.launchpad.net/bzr/+bug/109169
229
232
        except errors.PermissionDenied: