← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_identitymap.py

  • Committer: Andrew Bennetts
  • Date: 2007-03-26 06:24:01 UTC
  • mto: This revision was merged to the branch mainline in revision 2376.
  • Revision ID: andrew.bennetts@canonical.com-20070326062401-k3nbefzje5332jaf
Deal with review comments from Robert:

  * Add my name to the NEWS file
  * Move the test case to a new module in branch_implementations
  * Remove revision_history cruft from identitymap and test_identitymap
  * Improve some docstrings

Also, this fixes a bug where revision_history was not returning a copy of the
cached data, allowing the cache to be corrupted.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_identitymap.py
52
52
        map.add_weave("id", weave)
53
53
        map.remove_object(weave)
54
54
        map.add_weave("id", weave)
55
 
        rev_history = [1]
56
 
        map.add_revision_history(rev_history)
57
 
        map.remove_object(rev_history)
58
 
 
59
 
    def test_add_revision_history(self):
60
 
        map = identitymap.IdentityMap()
61
 
        rev_history = [1,2,3]
62
 
        map.add_revision_history(rev_history)
63
 
        self.assertEqual(rev_history, map.find_revision_history())
64
 
 
65
 
    def test_double_add_revision_history(self):
66
 
        map = identitymap.IdentityMap()
67
 
        revision_history = [1]
68
 
        map.add_revision_history(revision_history)
69
 
        self.assertRaises(errors.BzrError,
70
 
                          map.add_revision_history,
71
 
                          revision_history)
72
 
        self.assertEqual(revision_history, map.find_revision_history())
73
55
 
74
56
 
75
57
class TestNullIdentityMap(TestCase):
97
79
        map = identitymap.NullIdentityMap()
98
80
        self.assertEqual(None, getattr(map, 'remove_object', None))
99
81
 
100
 
    def test_add_revision_history(self):
101
 
        map = identitymap.NullIdentityMap()
102
 
        rev_history = [1,2,3]
103
 
        map.add_revision_history(rev_history)
104
 
        self.assertEqual(None, map.find_revision_history())
105
 
 
106
 
    def test_double_add_revision_history(self):
107
 
        map = identitymap.NullIdentityMap()
108
 
        revision_history = [1]
109
 
        map.add_revision_history(revision_history)
110
 
        map.add_revision_history(revision_history)
111
 
        self.assertEqual(None, map.find_revision_history())