← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/xml5.py

  • Committer: John Arbash Meinel
  • Date: 2006-08-17 14:00:59 UTC
  • mto: This revision was merged to the branch mainline in revision 1942.
  • Revision ID: john@arbash-meinel.com-20060817140059-9ac765cafd871dcd
Document why we aren't caching file ids at the moment

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/xml5.py
238
238
        parent_id = elt.get('parent_id')
239
239
        if parent_id == None:
240
240
            parent_id = ROOT_ID
 
241
        # TODO: jam 20060817 At present, caching file ids costs us too 
 
242
        #       much time. It slows down overall read performances from
 
243
        #       approx 500ms to 700ms. And doesn't improve future reads.
 
244
        #       it might be because revision ids and file ids are mixing.
 
245
        #       Consider caching *just* the file ids, for a limited period
 
246
        #       of time.
241
247
        #parent_id = get_cached(parent_id)
242
248
        #file_id = get_cached(elt.get('file_id'))
243
249
        file_id = elt.get('file_id')