1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
|
# Copyright (C) 2006 Canonical Ltd
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
"""Test locks across all branch implemenations"""
from bzrlib import errors
from bzrlib.branch import BzrBranchFormat4
from bzrlib.tests import TestSkipped
from bzrlib.tests.branch_implementations.test_branch import TestCaseWithBranch
from bzrlib.tests.lock_helpers import TestPreventLocking, LockWrapper
class TestBranchLocking(TestCaseWithBranch):
def setUp(self):
TestCaseWithBranch.setUp(self)
self.reduceLockdirTimeout()
def get_instrumented_branch(self):
"""Get a Branch object which has been instrumented"""
# TODO: jam 20060630 It may be that not all formats have a
# 'control_files' member. So we should fail gracefully if
# not there. But assuming it has them lets us test the exact
# lock/unlock order.
self.locks = []
b = LockWrapper(self.locks, self.get_branch(), 'b')
b.repository = LockWrapper(self.locks, b.repository, 'r')
bcf = b.control_files
rcf = b.repository.control_files
# Look out for branch types that reuse their control files
self.combined_control = bcf is rcf
b.control_files = LockWrapper(self.locks, b.control_files, 'bc')
b.repository.control_files = \
LockWrapper(self.locks, b.repository.control_files, 'rc')
return b
def test_01_lock_read(self):
# Test that locking occurs in the correct order
b = self.get_instrumented_branch()
self.assertFalse(b.is_locked())
self.assertFalse(b.repository.is_locked())
b.lock_read()
try:
self.assertTrue(b.is_locked())
self.assertTrue(b.repository.is_locked())
finally:
b.unlock()
self.assertFalse(b.is_locked())
self.assertFalse(b.repository.is_locked())
self.assertEqual([('b', 'lr', True),
('r', 'lr', True),
('rc', 'lr', True),
('bc', 'lr', True),
('b', 'ul', True),
('bc', 'ul', True),
('r', 'ul', True),
('rc', 'ul', True),
], self.locks)
def test_02_lock_write(self):
# Test that locking occurs in the correct order
b = self.get_instrumented_branch()
self.assertFalse(b.is_locked())
self.assertFalse(b.repository.is_locked())
b.lock_write()
try:
self.assertTrue(b.is_locked())
self.assertTrue(b.repository.is_locked())
finally:
b.unlock()
self.assertFalse(b.is_locked())
self.assertFalse(b.repository.is_locked())
self.assertEqual([('b', 'lw', True),
('r', 'lw', True),
('rc', 'lw', True),
('bc', 'lw', True),
('b', 'ul', True),
('bc', 'ul', True),
('r', 'ul', True),
('rc', 'ul', True),
], self.locks)
def test_03_lock_fail_unlock_repo(self):
# Make sure branch.unlock() is called, even if there is a
# failure while unlocking the repository.
b = self.get_instrumented_branch()
b.repository.disable_unlock()
self.assertFalse(b.is_locked())
self.assertFalse(b.repository.is_locked())
b.lock_write()
try:
self.assertTrue(b.is_locked())
self.assertTrue(b.repository.is_locked())
self.assertRaises(TestPreventLocking, b.unlock)
if self.combined_control:
self.assertTrue(b.is_locked())
else:
self.assertFalse(b.is_locked())
self.assertTrue(b.repository.is_locked())
# We unlock the branch control files, even if
# we fail to unlock the repository
self.assertEqual([('b', 'lw', True),
('r', 'lw', True),
('rc', 'lw', True),
('bc', 'lw', True),
('b', 'ul', True),
('bc', 'ul', True),
('r', 'ul', False),
], self.locks)
finally:
# For cleanup purposes, make sure we are unlocked
b.repository._other.unlock()
def test_04_lock_fail_unlock_control(self):
# Make sure repository.unlock() is called, if we fail to unlock self
b = self.get_instrumented_branch()
b.control_files.disable_unlock()
self.assertFalse(b.is_locked())
self.assertFalse(b.repository.is_locked())
b.lock_write()
try:
self.assertTrue(b.is_locked())
self.assertTrue(b.repository.is_locked())
self.assertRaises(TestPreventLocking, b.unlock)
self.assertTrue(b.is_locked())
if self.combined_control:
self.assertTrue(b.repository.is_locked())
else:
self.assertFalse(b.repository.is_locked())
# We unlock the repository even if
# we fail to unlock the control files
self.assertEqual([('b', 'lw', True),
('r', 'lw', True),
('rc', 'lw', True),
('bc', 'lw', True),
('b', 'ul', True),
('bc', 'ul', False),
('r', 'ul', True),
('rc', 'ul', True),
], self.locks)
finally:
# For cleanup purposes, make sure we are unlocked
b.control_files._other.unlock()
def test_05_lock_read_fail_repo(self):
# Test that the branch is not locked if it cannot lock the repository
b = self.get_instrumented_branch()
b.repository.disable_lock_read()
self.assertRaises(TestPreventLocking, b.lock_read)
self.assertFalse(b.is_locked())
self.assertFalse(b.repository.is_locked())
self.assertEqual([('b', 'lr', True),
('r', 'lr', False),
], self.locks)
def test_06_lock_write_fail_repo(self):
# Test that the branch is not locked if it cannot lock the repository
b = self.get_instrumented_branch()
b.repository.disable_lock_write()
self.assertRaises(TestPreventLocking, b.lock_write)
self.assertFalse(b.is_locked())
self.assertFalse(b.repository.is_locked())
self.assertEqual([('b', 'lw', True),
('r', 'lw', False),
], self.locks)
def test_07_lock_read_fail_control(self):
# Test the repository is unlocked if we can't lock self
b = self.get_instrumented_branch()
b.control_files.disable_lock_read()
self.assertRaises(TestPreventLocking, b.lock_read)
self.assertFalse(b.is_locked())
self.assertFalse(b.repository.is_locked())
self.assertEqual([('b', 'lr', True),
('r', 'lr', True),
('rc', 'lr', True),
('bc', 'lr', False),
('r', 'ul', True),
('rc', 'ul', True),
], self.locks)
def test_08_lock_write_fail_control(self):
# Test the repository is unlocked if we can't lock self
b = self.get_instrumented_branch()
b.control_files.disable_lock_write()
self.assertRaises(TestPreventLocking, b.lock_write)
self.assertFalse(b.is_locked())
self.assertFalse(b.repository.is_locked())
self.assertEqual([('b', 'lw', True),
('r', 'lw', True),
('rc', 'lw', True),
('bc', 'lw', False),
('r', 'ul', True),
('rc', 'ul', True),
], self.locks)
def test_lock_read_then_unlock(self):
# Calling lock_read then unlocking should work without errors.
branch = self.make_branch('b')
branch.lock_read()
branch.unlock()
def test_lock_write_locks_repo_too(self):
if isinstance(self.branch_format, BzrBranchFormat4):
# Branch format 4 is combined with the repository, so this test
# doesn't apply.
return
branch = self.make_branch('b')
branch = branch.bzrdir.open_branch()
branch.lock_write()
try:
# Now the branch.repository is locked, so we can't lock it with a new
# repository without a token.
new_repo = branch.bzrdir.open_repository()
self.assertRaises(errors.LockContention, new_repo.lock_write)
# We can call lock_write on the original repository object though,
# because it is already locked.
branch.repository.lock_write()
branch.repository.unlock()
finally:
branch.unlock()
|