~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/diff.py

  • Committer: Tarmac
  • Author(s): Vincent Ladeuil
  • Date: 2017-01-30 14:42:05 UTC
  • mfrom: (6620.1.1 trunk)
  • Revision ID: tarmac-20170130144205-r8fh2xpmiuxyozpv
Merge  2.7 into trunk including fix for bug #1657238 [r=vila]

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2004, 2005, 2006 Canonical Ltd.
 
1
# Copyright (C) 2005-2014 Canonical Ltd.
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
 
17
from __future__ import absolute_import
 
18
 
17
19
import difflib
18
20
import os
19
21
import re
20
 
import shutil
 
22
import string
21
23
import sys
22
24
 
23
25
from bzrlib.lazy_import import lazy_import
25
27
import errno
26
28
import subprocess
27
29
import tempfile
28
 
import time
29
30
 
30
31
from bzrlib import (
31
 
    branch as _mod_branch,
32
 
    bzrdir,
33
 
    commands,
 
32
    cleanup,
 
33
    cmdline,
 
34
    controldir,
34
35
    errors,
35
36
    osutils,
36
37
    patiencediff,
38
39
    timestamp,
39
40
    views,
40
41
    )
 
42
 
 
43
from bzrlib.workingtree import WorkingTree
 
44
from bzrlib.i18n import gettext
41
45
""")
42
46
 
43
 
from bzrlib.symbol_versioning import (
44
 
    deprecated_function,
 
47
from bzrlib.registry import (
 
48
    Registry,
45
49
    )
46
50
from bzrlib.trace import mutter, note, warning
47
51
 
 
52
DEFAULT_CONTEXT_AMOUNT = 3
 
53
 
 
54
class AtTemplate(string.Template):
 
55
    """Templating class that uses @ instead of $."""
 
56
 
 
57
    delimiter = '@'
 
58
 
48
59
 
49
60
# TODO: Rather than building a changeset object, we should probably
50
61
# invoke callbacks on an object.  That object can either accumulate a
62
73
 
63
74
def internal_diff(old_filename, oldlines, new_filename, newlines, to_file,
64
75
                  allow_binary=False, sequence_matcher=None,
65
 
                  path_encoding='utf8'):
 
76
                  path_encoding='utf8', context_lines=DEFAULT_CONTEXT_AMOUNT):
66
77
    # FIXME: difflib is wrong if there is no trailing newline.
67
78
    # The syntax used by patch seems to be "\ No newline at
68
79
    # end of file" following the last diff line from that
86
97
    if sequence_matcher is None:
87
98
        sequence_matcher = patiencediff.PatienceSequenceMatcher
88
99
    ud = patiencediff.unified_diff(oldlines, newlines,
89
 
                      fromfile=old_filename.encode(path_encoding),
90
 
                      tofile=new_filename.encode(path_encoding),
91
 
                      sequencematcher=sequence_matcher)
 
100
                      fromfile=old_filename.encode(path_encoding, 'replace'),
 
101
                      tofile=new_filename.encode(path_encoding, 'replace'),
 
102
                      n=context_lines, sequencematcher=sequence_matcher)
92
103
 
93
104
    ud = list(ud)
94
105
    if len(ud) == 0: # Identical contents, nothing to do
108
119
 
109
120
 
110
121
def _spawn_external_diff(diffcmd, capture_errors=True):
111
 
    """Spawn the externall diff process, and return the child handle.
 
122
    """Spawn the external diff process, and return the child handle.
112
123
 
113
124
    :param diffcmd: The command list to spawn
114
125
    :param capture_errors: Capture stderr as well as setting LANG=C
143
154
 
144
155
    return pipe
145
156
 
 
157
# diff style options as of GNU diff v3.2
 
158
style_option_list = ['-c', '-C', '--context',
 
159
                     '-e', '--ed',
 
160
                     '-f', '--forward-ed',
 
161
                     '-q', '--brief',
 
162
                     '--normal',
 
163
                     '-n', '--rcs',
 
164
                     '-u', '-U', '--unified',
 
165
                     '-y', '--side-by-side',
 
166
                     '-D', '--ifdef']
 
167
 
 
168
def default_style_unified(diff_opts):
 
169
    """Default to unified diff style if alternative not specified in diff_opts.
 
170
 
 
171
        diff only allows one style to be specified; they don't override.
 
172
        Note that some of these take optargs, and the optargs can be
 
173
        directly appended to the options.
 
174
        This is only an approximate parser; it doesn't properly understand
 
175
        the grammar.
 
176
 
 
177
    :param diff_opts: List of options for external (GNU) diff.
 
178
    :return: List of options with default style=='unified'.
 
179
    """
 
180
    for s in style_option_list:
 
181
        for j in diff_opts:
 
182
            if j.startswith(s):
 
183
                break
 
184
        else:
 
185
            continue
 
186
        break
 
187
    else:
 
188
        diff_opts.append('-u')
 
189
    return diff_opts
 
190
 
146
191
 
147
192
def external_diff(old_filename, oldlines, new_filename, newlines, to_file,
148
193
                  diff_opts):
184
229
                   '--binary',
185
230
                  ]
186
231
 
187
 
        # diff only allows one style to be specified; they don't override.
188
 
        # note that some of these take optargs, and the optargs can be
189
 
        # directly appended to the options.
190
 
        # this is only an approximate parser; it doesn't properly understand
191
 
        # the grammar.
192
 
        for s in ['-c', '-u', '-C', '-U',
193
 
                  '-e', '--ed',
194
 
                  '-q', '--brief',
195
 
                  '--normal',
196
 
                  '-n', '--rcs',
197
 
                  '-y', '--side-by-side',
198
 
                  '-D', '--ifdef']:
199
 
            for j in diff_opts:
200
 
                if j.startswith(s):
201
 
                    break
202
 
            else:
203
 
                continue
204
 
            break
205
 
        else:
206
 
            diffcmd.append('-u')
 
232
        diff_opts = default_style_unified(diff_opts)
207
233
 
208
234
        if diff_opts:
209
235
            diffcmd.extend(diff_opts)
254
280
                msg = 'exit code %d' % rc
255
281
 
256
282
            raise errors.BzrError('external diff failed with %s; command: %r'
257
 
                                  % (rc, diffcmd))
 
283
                                  % (msg, diffcmd))
258
284
 
259
285
 
260
286
    finally:
261
287
        oldtmpf.close()                 # and delete
262
288
        newtmpf.close()
263
 
        # Clean up. Warn in case the files couldn't be deleted
264
 
        # (in case windows still holds the file open, but not
265
 
        # if the files have already been deleted)
266
 
        try:
267
 
            os.remove(old_abspath)
268
 
        except OSError, e:
269
 
            if e.errno not in (errno.ENOENT,):
270
 
                warning('Failed to delete temporary file: %s %s',
271
 
                        old_abspath, e)
272
 
        try:
273
 
            os.remove(new_abspath)
274
 
        except OSError:
275
 
            if e.errno not in (errno.ENOENT,):
276
 
                warning('Failed to delete temporary file: %s %s',
277
 
                        new_abspath, e)
278
 
 
279
 
 
280
 
def _get_trees_to_diff(path_list, revision_specs, old_url, new_url,
281
 
    apply_view=True):
 
289
 
 
290
        def cleanup(path):
 
291
            # Warn in case the file couldn't be deleted (in case windows still
 
292
            # holds the file open, but not if the files have already been
 
293
            # deleted)
 
294
            try:
 
295
                os.remove(path)
 
296
            except OSError, e:
 
297
                if e.errno not in (errno.ENOENT,):
 
298
                    warning('Failed to delete temporary file: %s %s', path, e)
 
299
 
 
300
        cleanup(old_abspath)
 
301
        cleanup(new_abspath)
 
302
 
 
303
 
 
304
def get_trees_and_branches_to_diff_locked(
 
305
    path_list, revision_specs, old_url, new_url, add_cleanup, apply_view=True):
282
306
    """Get the trees and specific files to diff given a list of paths.
283
307
 
284
308
    This method works out the trees to be diff'ed and the files of
295
319
    :param new_url:
296
320
        The url of the new branch or tree. If None, the tree to use is
297
321
        taken from the first path, if any, or the current working tree.
 
322
    :param add_cleanup:
 
323
        a callable like Command.add_cleanup.  get_trees_and_branches_to_diff
 
324
        will register cleanups that must be run to unlock the trees, etc.
298
325
    :param apply_view:
299
326
        if True and a view is set, apply the view or check that the paths
300
327
        are within it
301
328
    :returns:
302
 
        a tuple of (old_tree, new_tree, specific_files, extra_trees) where
303
 
        extra_trees is a sequence of additional trees to search in for
304
 
        file-ids.
 
329
        a tuple of (old_tree, new_tree, old_branch, new_branch,
 
330
        specific_files, extra_trees) where extra_trees is a sequence of
 
331
        additional trees to search in for file-ids.  The trees and branches
 
332
        will be read-locked until the cleanups registered via the add_cleanup
 
333
        param are run.
305
334
    """
306
335
    # Get the old and new revision specs
307
336
    old_revision_spec = None
330
359
        default_location = path_list[0]
331
360
        other_paths = path_list[1:]
332
361
 
 
362
    def lock_tree_or_branch(wt, br):
 
363
        if wt is not None:
 
364
            wt.lock_read()
 
365
            add_cleanup(wt.unlock)
 
366
        elif br is not None:
 
367
            br.lock_read()
 
368
            add_cleanup(br.unlock)
 
369
 
333
370
    # Get the old location
334
371
    specific_files = []
335
372
    if old_url is None:
336
373
        old_url = default_location
337
374
    working_tree, branch, relpath = \
338
 
        bzrdir.BzrDir.open_containing_tree_or_branch(old_url)
 
375
        controldir.ControlDir.open_containing_tree_or_branch(old_url)
 
376
    lock_tree_or_branch(working_tree, branch)
339
377
    if consider_relpath and relpath != '':
340
378
        if working_tree is not None and apply_view:
341
379
            views.check_path_in_view(working_tree, relpath)
342
380
        specific_files.append(relpath)
343
381
    old_tree = _get_tree_to_diff(old_revision_spec, working_tree, branch)
 
382
    old_branch = branch
344
383
 
345
384
    # Get the new location
346
385
    if new_url is None:
347
386
        new_url = default_location
348
387
    if new_url != old_url:
349
388
        working_tree, branch, relpath = \
350
 
            bzrdir.BzrDir.open_containing_tree_or_branch(new_url)
 
389
            controldir.ControlDir.open_containing_tree_or_branch(new_url)
 
390
        lock_tree_or_branch(working_tree, branch)
351
391
        if consider_relpath and relpath != '':
352
392
            if working_tree is not None and apply_view:
353
393
                views.check_path_in_view(working_tree, relpath)
354
394
            specific_files.append(relpath)
355
395
    new_tree = _get_tree_to_diff(new_revision_spec, working_tree, branch,
356
396
        basis_is_default=working_tree is None)
 
397
    new_branch = branch
357
398
 
358
399
    # Get the specific files (all files is None, no files is [])
359
400
    if make_paths_wt_relative and working_tree is not None:
360
 
        try:
361
 
            from bzrlib.builtins import safe_relpath_files
362
 
            other_paths = safe_relpath_files(working_tree, other_paths,
 
401
        other_paths = working_tree.safe_relpath_files(
 
402
            other_paths,
363
403
            apply_view=apply_view)
364
 
        except errors.FileInWrongBranch:
365
 
            raise errors.BzrCommandError("Files are in different branches")
366
404
    specific_files.extend(other_paths)
367
405
    if len(specific_files) == 0:
368
406
        specific_files = None
372
410
            if view_files:
373
411
                specific_files = view_files
374
412
                view_str = views.view_display_str(view_files)
375
 
                note("*** Ignoring files outside view. View is %s" % view_str)
 
413
                note(gettext("*** Ignoring files outside view. View is %s") % view_str)
376
414
 
377
415
    # Get extra trees that ought to be searched for file-ids
378
416
    extra_trees = None
379
417
    if working_tree is not None and working_tree not in (old_tree, new_tree):
380
418
        extra_trees = (working_tree,)
381
 
    return old_tree, new_tree, specific_files, extra_trees
 
419
    return (old_tree, new_tree, old_branch, new_branch,
 
420
            specific_files, extra_trees)
 
421
 
382
422
 
383
423
def _get_tree_to_diff(spec, tree=None, branch=None, basis_is_default=True):
384
424
    if branch is None and tree is not None:
399
439
                    old_label='a/', new_label='b/',
400
440
                    extra_trees=None,
401
441
                    path_encoding='utf8',
402
 
                    using=None):
 
442
                    using=None,
 
443
                    format_cls=None,
 
444
                    context=DEFAULT_CONTEXT_AMOUNT):
403
445
    """Show in text form the changes from one tree to another.
404
446
 
405
 
    to_file
406
 
        The output stream.
407
 
 
408
 
    specific_files
409
 
        Include only changes to these files - None for all changes.
410
 
 
411
 
    external_diff_options
412
 
        If set, use an external GNU diff and pass these options.
413
 
 
414
 
    extra_trees
415
 
        If set, more Trees to use for looking up file ids
416
 
 
417
 
    path_encoding
418
 
        If set, the path will be encoded as specified, otherwise is supposed
419
 
        to be utf8
 
447
    :param to_file: The output stream.
 
448
    :param specific_files: Include only changes to these files - None for all
 
449
        changes.
 
450
    :param external_diff_options: If set, use an external GNU diff and pass 
 
451
        these options.
 
452
    :param extra_trees: If set, more Trees to use for looking up file ids
 
453
    :param path_encoding: If set, the path will be encoded as specified, 
 
454
        otherwise is supposed to be utf8
 
455
    :param format_cls: Formatter class (DiffTree subclass)
420
456
    """
 
457
    if context is None:
 
458
        context = DEFAULT_CONTEXT_AMOUNT
 
459
    if format_cls is None:
 
460
        format_cls = DiffTree
421
461
    old_tree.lock_read()
422
462
    try:
423
463
        if extra_trees is not None:
425
465
                tree.lock_read()
426
466
        new_tree.lock_read()
427
467
        try:
428
 
            differ = DiffTree.from_trees_options(old_tree, new_tree, to_file,
429
 
                                                 path_encoding,
430
 
                                                 external_diff_options,
431
 
                                                 old_label, new_label, using)
 
468
            differ = format_cls.from_trees_options(old_tree, new_tree, to_file,
 
469
                                                   path_encoding,
 
470
                                                   external_diff_options,
 
471
                                                   old_label, new_label, using,
 
472
                                                   context_lines=context)
432
473
            return differ.show_diff(specific_files, extra_trees)
433
474
        finally:
434
475
            new_tree.unlock()
441
482
 
442
483
def _patch_header_date(tree, file_id, path):
443
484
    """Returns a timestamp suitable for use in a patch header."""
444
 
    mtime = tree.get_file_mtime(file_id, path)
 
485
    try:
 
486
        mtime = tree.get_file_mtime(file_id, path)
 
487
    except errors.FileTimestampUnavailable:
 
488
        mtime = 0
445
489
    return timestamp.format_patch_date(mtime)
446
490
 
447
491
 
589
633
    # or removed in a diff.
590
634
    EPOCH_DATE = '1970-01-01 00:00:00 +0000'
591
635
 
592
 
    def __init__(self, old_tree, new_tree, to_file, path_encoding='utf-8',
593
 
                 old_label='', new_label='', text_differ=internal_diff):
 
636
    def __init__(self, old_tree, new_tree, to_file, path_encoding='utf-8', 
 
637
                 old_label='', new_label='', text_differ=internal_diff, 
 
638
                 context_lines=DEFAULT_CONTEXT_AMOUNT):
594
639
        DiffPath.__init__(self, old_tree, new_tree, to_file, path_encoding)
595
640
        self.text_differ = text_differ
596
641
        self.old_label = old_label
597
642
        self.new_label = new_label
598
643
        self.path_encoding = path_encoding
 
644
        self.context_lines = context_lines
599
645
 
600
646
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
601
647
        """Compare two files in unified diff format
642
688
        """
643
689
        def _get_text(tree, file_id, path):
644
690
            if file_id is not None:
645
 
                return tree.get_file(file_id, path).readlines()
 
691
                return tree.get_file_lines(file_id, path)
646
692
            else:
647
693
                return []
648
694
        try:
649
695
            from_text = _get_text(self.old_tree, from_file_id, from_path)
650
696
            to_text = _get_text(self.new_tree, to_file_id, to_path)
651
697
            self.text_differ(from_label, from_text, to_label, to_text,
652
 
                             self.to_file)
 
698
                             self.to_file, path_encoding=self.path_encoding,
 
699
                             context_lines=self.context_lines)
653
700
        except errors.BinaryFile:
654
701
            self.to_file.write(
655
702
                  ("Binary files %s and %s differ\n" %
656
 
                  (from_label, to_label)).encode(self.path_encoding))
 
703
                  (from_label, to_label)).encode(self.path_encoding,'replace'))
657
704
        return self.CHANGED
658
705
 
659
706
 
668
715
    @classmethod
669
716
    def from_string(klass, command_string, old_tree, new_tree, to_file,
670
717
                    path_encoding='utf-8'):
671
 
        command_template = commands.shlex_split_unicode(command_string)
672
 
        command_template.extend(['%(old_path)s', '%(new_path)s'])
 
718
        command_template = cmdline.split(command_string)
 
719
        if '@' not in command_string:
 
720
            command_template.extend(['@old_path', '@new_path'])
673
721
        return klass(command_template, old_tree, new_tree, to_file,
674
722
                     path_encoding)
675
723
 
676
724
    @classmethod
677
 
    def make_from_diff_tree(klass, command_string):
 
725
    def make_from_diff_tree(klass, command_string, external_diff_options=None):
678
726
        def from_diff_tree(diff_tree):
679
 
            return klass.from_string(command_string, diff_tree.old_tree,
 
727
            full_command_string = [command_string]
 
728
            if external_diff_options is not None:
 
729
                full_command_string += ' ' + external_diff_options
 
730
            return klass.from_string(full_command_string, diff_tree.old_tree,
680
731
                                     diff_tree.new_tree, diff_tree.to_file)
681
732
        return from_diff_tree
682
733
 
683
734
    def _get_command(self, old_path, new_path):
684
735
        my_map = {'old_path': old_path, 'new_path': new_path}
685
 
        return [t % my_map for t in self.command_template]
 
736
        command = [AtTemplate(t).substitute(my_map) for t in
 
737
                   self.command_template]
 
738
        if sys.platform == 'win32': # Popen doesn't accept unicode on win32
 
739
            command_encoded = []
 
740
            for c in command:
 
741
                if isinstance(c, unicode):
 
742
                    command_encoded.append(c.encode('mbcs'))
 
743
                else:
 
744
                    command_encoded.append(c)
 
745
            return command_encoded
 
746
        else:
 
747
            return command
686
748
 
687
749
    def _execute(self, old_path, new_path):
688
750
        command = self._get_command(old_path, new_path)
708
770
                raise
709
771
        return True
710
772
 
711
 
    def _write_file(self, file_id, tree, prefix, relpath):
712
 
        full_path = osutils.pathjoin(self._root, prefix, relpath)
713
 
        if self._try_symlink_root(tree, prefix):
 
773
    @staticmethod
 
774
    def _fenc():
 
775
        """Returns safe encoding for passing file path to diff tool"""
 
776
        if sys.platform == 'win32':
 
777
            return 'mbcs'
 
778
        else:
 
779
            # Don't fallback to 'utf-8' because subprocess may not be able to
 
780
            # handle utf-8 correctly when locale is not utf-8.
 
781
            return sys.getfilesystemencoding() or 'ascii'
 
782
 
 
783
    def _is_safepath(self, path):
 
784
        """Return true if `path` may be able to pass to subprocess."""
 
785
        fenc = self._fenc()
 
786
        try:
 
787
            return path == path.encode(fenc).decode(fenc)
 
788
        except UnicodeError:
 
789
            return False
 
790
 
 
791
    def _safe_filename(self, prefix, relpath):
 
792
        """Replace unsafe character in `relpath` then join `self._root`,
 
793
        `prefix` and `relpath`."""
 
794
        fenc = self._fenc()
 
795
        # encoded_str.replace('?', '_') may break multibyte char.
 
796
        # So we should encode, decode, then replace(u'?', u'_')
 
797
        relpath_tmp = relpath.encode(fenc, 'replace').decode(fenc, 'replace')
 
798
        relpath_tmp = relpath_tmp.replace(u'?', u'_')
 
799
        return osutils.pathjoin(self._root, prefix, relpath_tmp)
 
800
 
 
801
    def _write_file(self, file_id, tree, prefix, relpath, force_temp=False,
 
802
                    allow_write=False):
 
803
        if not force_temp and isinstance(tree, WorkingTree):
 
804
            full_path = tree.abspath(tree.id2path(file_id))
 
805
            if self._is_safepath(full_path):
 
806
                return full_path
 
807
 
 
808
        full_path = self._safe_filename(prefix, relpath)
 
809
        if not force_temp and self._try_symlink_root(tree, prefix):
714
810
            return full_path
715
811
        parent_dir = osutils.dirname(full_path)
716
812
        try:
727
823
                target.close()
728
824
        finally:
729
825
            source.close()
730
 
        osutils.make_readonly(full_path)
731
 
        mtime = tree.get_file_mtime(file_id)
732
 
        os.utime(full_path, (mtime, mtime))
 
826
        try:
 
827
            mtime = tree.get_file_mtime(file_id)
 
828
        except errors.FileTimestampUnavailable:
 
829
            pass
 
830
        else:
 
831
            os.utime(full_path, (mtime, mtime))
 
832
        if not allow_write:
 
833
            osutils.make_readonly(full_path)
733
834
        return full_path
734
835
 
735
 
    def _prepare_files(self, file_id, old_path, new_path):
 
836
    def _prepare_files(self, file_id, old_path, new_path, force_temp=False,
 
837
                       allow_write_new=False):
736
838
        old_disk_path = self._write_file(file_id, self.old_tree, 'old',
737
 
                                         old_path)
 
839
                                         old_path, force_temp)
738
840
        new_disk_path = self._write_file(file_id, self.new_tree, 'new',
739
 
                                         new_path)
 
841
                                         new_path, force_temp,
 
842
                                         allow_write=allow_write_new)
740
843
        return old_disk_path, new_disk_path
741
844
 
742
845
    def finish(self):
750
853
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
751
854
        if (old_kind, new_kind) != ('file', 'file'):
752
855
            return DiffPath.CANNOT_DIFF
753
 
        self._prepare_files(file_id, old_path, new_path)
754
 
        self._execute(osutils.pathjoin('old', old_path),
755
 
                      osutils.pathjoin('new', new_path))
 
856
        (old_disk_path, new_disk_path) = self._prepare_files(
 
857
                                                file_id, old_path, new_path)
 
858
        self._execute(old_disk_path, new_disk_path)
 
859
 
 
860
    def edit_file(self, file_id):
 
861
        """Use this tool to edit a file.
 
862
 
 
863
        A temporary copy will be edited, and the new contents will be
 
864
        returned.
 
865
 
 
866
        :param file_id: The id of the file to edit.
 
867
        :return: The new contents of the file.
 
868
        """
 
869
        old_path = self.old_tree.id2path(file_id)
 
870
        new_path = self.new_tree.id2path(file_id)
 
871
        old_abs_path, new_abs_path = self._prepare_files(
 
872
                                            file_id, old_path, new_path,
 
873
                                            allow_write_new=True,
 
874
                                            force_temp=True)
 
875
        command = self._get_command(old_abs_path, new_abs_path)
 
876
        subprocess.call(command, cwd=self._root)
 
877
        new_file = open(new_abs_path, 'rb')
 
878
        try:
 
879
            return new_file.read()
 
880
        finally:
 
881
            new_file.close()
756
882
 
757
883
 
758
884
class DiffTree(object):
800
926
    @classmethod
801
927
    def from_trees_options(klass, old_tree, new_tree, to_file,
802
928
                           path_encoding, external_diff_options, old_label,
803
 
                           new_label, using):
 
929
                           new_label, using, context_lines):
804
930
        """Factory for producing a DiffTree.
805
931
 
806
932
        Designed to accept options used by show_diff_trees.
 
933
 
807
934
        :param old_tree: The tree to show as old in the comparison
808
935
        :param new_tree: The tree to show as new in the comparison
809
936
        :param to_file: File to write comparisons to
815
942
        :param using: Commandline to use to invoke an external diff tool
816
943
        """
817
944
        if using is not None:
818
 
            extra_factories = [DiffFromTool.make_from_diff_tree(using)]
 
945
            extra_factories = [DiffFromTool.make_from_diff_tree(using, external_diff_options)]
819
946
        else:
820
947
            extra_factories = []
821
948
        if external_diff_options:
822
949
            opts = external_diff_options.split()
823
 
            def diff_file(olab, olines, nlab, nlines, to_file):
 
950
            def diff_file(olab, olines, nlab, nlines, to_file, path_encoding=None, context_lines=None):
 
951
                """:param path_encoding: not used but required
 
952
                        to match the signature of internal_diff.
 
953
                """
824
954
                external_diff(olab, olines, nlab, nlines, to_file, opts)
825
955
        else:
826
956
            diff_file = internal_diff
827
957
        diff_text = DiffText(old_tree, new_tree, to_file, path_encoding,
828
 
                             old_label, new_label, diff_file)
 
958
                             old_label, new_label, diff_file, context_lines=context_lines)
829
959
        return klass(old_tree, new_tree, to_file, path_encoding, diff_text,
830
960
                     extra_factories)
831
961
 
832
962
    def show_diff(self, specific_files, extra_trees=None):
833
963
        """Write tree diff to self.to_file
834
964
 
835
 
        :param sepecific_files: the specific files to compare (recursive)
 
965
        :param specific_files: the specific files to compare (recursive)
836
966
        :param extra_trees: extra trees to use for mapping paths to file_ids
837
967
        """
838
968
        try:
928
1058
            if error_path is None:
929
1059
                error_path = old_path
930
1060
            raise errors.NoDiffFound(error_path)
 
1061
 
 
1062
 
 
1063
format_registry = Registry()
 
1064
format_registry.register('default', DiffTree)