← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/diff.py

  • Committer: Vincent Ladeuil
  • Date: 2017-01-30 14:30:10 UTC
  • mfrom: (6615.3.7 merges)
  • mto: This revision was merged to the branch mainline in revision 6621.
  • Revision ID: v.ladeuil+lp@free.fr-20170130143010-p31t1ranfeqbaeki
Merge  2.7 into trunk including fix for bug #1657238

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/diff.py
1
 
# Copyright (C) 2005-2011 Canonical Ltd.
 
1
# Copyright (C) 2005-2014 Canonical Ltd.
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
49
49
    )
50
50
from bzrlib.trace import mutter, note, warning
51
51
 
 
52
DEFAULT_CONTEXT_AMOUNT = 3
52
53
 
53
54
class AtTemplate(string.Template):
54
55
    """Templating class that uses @ instead of $."""
72
73
 
73
74
def internal_diff(old_filename, oldlines, new_filename, newlines, to_file,
74
75
                  allow_binary=False, sequence_matcher=None,
75
 
                  path_encoding='utf8'):
 
76
                  path_encoding='utf8', context_lines=DEFAULT_CONTEXT_AMOUNT):
76
77
    # FIXME: difflib is wrong if there is no trailing newline.
77
78
    # The syntax used by patch seems to be "\ No newline at
78
79
    # end of file" following the last diff line from that
98
99
    ud = patiencediff.unified_diff(oldlines, newlines,
99
100
                      fromfile=old_filename.encode(path_encoding, 'replace'),
100
101
                      tofile=new_filename.encode(path_encoding, 'replace'),
101
 
                      sequencematcher=sequence_matcher)
 
102
                      n=context_lines, sequencematcher=sequence_matcher)
102
103
 
103
104
    ud = list(ud)
104
105
    if len(ud) == 0: # Identical contents, nothing to do
118
119
 
119
120
 
120
121
def _spawn_external_diff(diffcmd, capture_errors=True):
121
 
    """Spawn the externall diff process, and return the child handle.
 
122
    """Spawn the external diff process, and return the child handle.
122
123
 
123
124
    :param diffcmd: The command list to spawn
124
125
    :param capture_errors: Capture stderr as well as setting LANG=C
153
154
 
154
155
    return pipe
155
156
 
 
157
# diff style options as of GNU diff v3.2
 
158
style_option_list = ['-c', '-C', '--context',
 
159
                     '-e', '--ed',
 
160
                     '-f', '--forward-ed',
 
161
                     '-q', '--brief',
 
162
                     '--normal',
 
163
                     '-n', '--rcs',
 
164
                     '-u', '-U', '--unified',
 
165
                     '-y', '--side-by-side',
 
166
                     '-D', '--ifdef']
 
167
 
 
168
def default_style_unified(diff_opts):
 
169
    """Default to unified diff style if alternative not specified in diff_opts.
 
170
 
 
171
        diff only allows one style to be specified; they don't override.
 
172
        Note that some of these take optargs, and the optargs can be
 
173
        directly appended to the options.
 
174
        This is only an approximate parser; it doesn't properly understand
 
175
        the grammar.
 
176
 
 
177
    :param diff_opts: List of options for external (GNU) diff.
 
178
    :return: List of options with default style=='unified'.
 
179
    """
 
180
    for s in style_option_list:
 
181
        for j in diff_opts:
 
182
            if j.startswith(s):
 
183
                break
 
184
        else:
 
185
            continue
 
186
        break
 
187
    else:
 
188
        diff_opts.append('-u')
 
189
    return diff_opts
 
190
 
156
191
 
157
192
def external_diff(old_filename, oldlines, new_filename, newlines, to_file,
158
193
                  diff_opts):
194
229
                   '--binary',
195
230
                  ]
196
231
 
197
 
        # diff only allows one style to be specified; they don't override.
198
 
        # note that some of these take optargs, and the optargs can be
199
 
        # directly appended to the options.
200
 
        # this is only an approximate parser; it doesn't properly understand
201
 
        # the grammar.
202
 
        for s in ['-c', '-u', '-C', '-U',
203
 
                  '-e', '--ed',
204
 
                  '-q', '--brief',
205
 
                  '--normal',
206
 
                  '-n', '--rcs',
207
 
                  '-y', '--side-by-side',
208
 
                  '-D', '--ifdef']:
209
 
            for j in diff_opts:
210
 
                if j.startswith(s):
211
 
                    break
212
 
            else:
213
 
                continue
214
 
            break
215
 
        else:
216
 
            diffcmd.append('-u')
 
232
        diff_opts = default_style_unified(diff_opts)
217
233
 
218
234
        if diff_opts:
219
235
            diffcmd.extend(diff_opts)
264
280
                msg = 'exit code %d' % rc
265
281
 
266
282
            raise errors.BzrError('external diff failed with %s; command: %r'
267
 
                                  % (rc, diffcmd))
 
283
                                  % (msg, diffcmd))
268
284
 
269
285
 
270
286
    finally:
271
287
        oldtmpf.close()                 # and delete
272
288
        newtmpf.close()
273
 
        # Clean up. Warn in case the files couldn't be deleted
274
 
        # (in case windows still holds the file open, but not
275
 
        # if the files have already been deleted)
276
 
        try:
277
 
            os.remove(old_abspath)
278
 
        except OSError, e:
279
 
            if e.errno not in (errno.ENOENT,):
280
 
                warning('Failed to delete temporary file: %s %s',
281
 
                        old_abspath, e)
282
 
        try:
283
 
            os.remove(new_abspath)
284
 
        except OSError:
285
 
            if e.errno not in (errno.ENOENT,):
286
 
                warning('Failed to delete temporary file: %s %s',
287
 
                        new_abspath, e)
 
289
 
 
290
        def cleanup(path):
 
291
            # Warn in case the file couldn't be deleted (in case windows still
 
292
            # holds the file open, but not if the files have already been
 
293
            # deleted)
 
294
            try:
 
295
                os.remove(path)
 
296
            except OSError, e:
 
297
                if e.errno not in (errno.ENOENT,):
 
298
                    warning('Failed to delete temporary file: %s %s', path, e)
 
299
 
 
300
        cleanup(old_abspath)
 
301
        cleanup(new_abspath)
288
302
 
289
303
 
290
304
def get_trees_and_branches_to_diff_locked(
426
440
                    extra_trees=None,
427
441
                    path_encoding='utf8',
428
442
                    using=None,
429
 
                    format_cls=None):
 
443
                    format_cls=None,
 
444
                    context=DEFAULT_CONTEXT_AMOUNT):
430
445
    """Show in text form the changes from one tree to another.
431
446
 
432
447
    :param to_file: The output stream.
439
454
        otherwise is supposed to be utf8
440
455
    :param format_cls: Formatter class (DiffTree subclass)
441
456
    """
 
457
    if context is None:
 
458
        context = DEFAULT_CONTEXT_AMOUNT
442
459
    if format_cls is None:
443
460
        format_cls = DiffTree
444
461
    old_tree.lock_read()
451
468
            differ = format_cls.from_trees_options(old_tree, new_tree, to_file,
452
469
                                                   path_encoding,
453
470
                                                   external_diff_options,
454
 
                                                   old_label, new_label, using)
 
471
                                                   old_label, new_label, using,
 
472
                                                   context_lines=context)
455
473
            return differ.show_diff(specific_files, extra_trees)
456
474
        finally:
457
475
            new_tree.unlock()
615
633
    # or removed in a diff.
616
634
    EPOCH_DATE = '1970-01-01 00:00:00 +0000'
617
635
 
618
 
    def __init__(self, old_tree, new_tree, to_file, path_encoding='utf-8',
619
 
                 old_label='', new_label='', text_differ=internal_diff):
 
636
    def __init__(self, old_tree, new_tree, to_file, path_encoding='utf-8', 
 
637
                 old_label='', new_label='', text_differ=internal_diff, 
 
638
                 context_lines=DEFAULT_CONTEXT_AMOUNT):
620
639
        DiffPath.__init__(self, old_tree, new_tree, to_file, path_encoding)
621
640
        self.text_differ = text_differ
622
641
        self.old_label = old_label
623
642
        self.new_label = new_label
624
643
        self.path_encoding = path_encoding
 
644
        self.context_lines = context_lines
625
645
 
626
646
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
627
647
        """Compare two files in unified diff format
675
695
            from_text = _get_text(self.old_tree, from_file_id, from_path)
676
696
            to_text = _get_text(self.new_tree, to_file_id, to_path)
677
697
            self.text_differ(from_label, from_text, to_label, to_text,
678
 
                             self.to_file, path_encoding=self.path_encoding)
 
698
                             self.to_file, path_encoding=self.path_encoding,
 
699
                             context_lines=self.context_lines)
679
700
        except errors.BinaryFile:
680
701
            self.to_file.write(
681
702
                  ("Binary files %s and %s differ\n" %
905
926
    @classmethod
906
927
    def from_trees_options(klass, old_tree, new_tree, to_file,
907
928
                           path_encoding, external_diff_options, old_label,
908
 
                           new_label, using):
 
929
                           new_label, using, context_lines):
909
930
        """Factory for producing a DiffTree.
910
931
 
911
932
        Designed to accept options used by show_diff_trees.
926
947
            extra_factories = []
927
948
        if external_diff_options:
928
949
            opts = external_diff_options.split()
929
 
            def diff_file(olab, olines, nlab, nlines, to_file, path_encoding=None):
 
950
            def diff_file(olab, olines, nlab, nlines, to_file, path_encoding=None, context_lines=None):
930
951
                """:param path_encoding: not used but required
931
952
                        to match the signature of internal_diff.
932
953
                """
934
955
        else:
935
956
            diff_file = internal_diff
936
957
        diff_text = DiffText(old_tree, new_tree, to_file, path_encoding,
937
 
                             old_label, new_label, diff_file)
 
958
                             old_label, new_label, diff_file, context_lines=context_lines)
938
959
        return klass(old_tree, new_tree, to_file, path_encoding, diff_text,
939
960
                     extra_factories)
940
961