~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_http.py

  • Committer: Patch Queue Manager
  • Date: 2016-02-01 19:56:05 UTC
  • mfrom: (6615.1.1 trunk)
  • Revision ID: pqm@pqm.ubuntu.com-20160201195605-o7rl92wf6uyum3fk
(vila) Open trunk again as 2.8b1 (Vincent Ladeuil)

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2012, 2015, 2016 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
23
23
# TODO: Should be renamed to bzrlib.transport.http.tests?
24
24
# TODO: What about renaming to bzrlib.tests.transport.http ?
25
25
 
26
 
from cStringIO import StringIO
27
26
import httplib
28
 
import os
29
 
import select
30
27
import SimpleHTTPServer
31
28
import socket
32
29
import sys
34
31
 
35
32
import bzrlib
36
33
from bzrlib import (
37
 
    bzrdir,
38
34
    config,
 
35
    controldir,
 
36
    debug,
39
37
    errors,
40
38
    osutils,
41
39
    remote as _mod_remote,
42
40
    tests,
 
41
    trace,
43
42
    transport,
44
43
    ui,
45
 
    urlutils,
46
 
    )
47
 
from bzrlib.symbol_versioning import (
48
 
    deprecated_in,
49
44
    )
50
45
from bzrlib.tests import (
51
46
    features,
52
47
    http_server,
53
48
    http_utils,
 
49
    test_server,
 
50
    )
 
51
from bzrlib.tests.scenarios import (
 
52
    load_tests_apply_scenarios,
 
53
    multiply_scenarios,
54
54
    )
55
55
from bzrlib.transport import (
56
56
    http,
66
66
    from bzrlib.transport.http._pycurl import PyCurlTransport
67
67
 
68
68
 
69
 
def load_tests(standard_tests, module, loader):
70
 
    """Multiply tests for http clients and protocol versions."""
71
 
    result = loader.suiteClass()
72
 
 
73
 
    # one for each transport implementation
74
 
    t_tests, remaining_tests = tests.split_suite_by_condition(
75
 
        standard_tests, tests.condition_isinstance((
76
 
                TestHttpTransportRegistration,
77
 
                TestHttpTransportUrls,
78
 
                Test_redirected_to,
79
 
                )))
 
69
load_tests = load_tests_apply_scenarios
 
70
 
 
71
 
 
72
def vary_by_http_client_implementation():
 
73
    """Test the two libraries we can use, pycurl and urllib."""
80
74
    transport_scenarios = [
81
75
        ('urllib', dict(_transport=_urllib.HttpTransport_urllib,
82
76
                        _server=http_server.HttpServer_urllib,
83
 
                        _qualified_prefix='http+urllib',)),
 
77
                        _url_protocol='http+urllib',)),
84
78
        ]
85
79
    if features.pycurl.available():
86
80
        transport_scenarios.append(
87
81
            ('pycurl', dict(_transport=PyCurlTransport,
88
82
                            _server=http_server.HttpServer_PyCurl,
89
 
                            _qualified_prefix='http+pycurl',)))
90
 
    tests.multiply_tests(t_tests, transport_scenarios, result)
91
 
 
92
 
    # each implementation tested with each HTTP version
93
 
    tp_tests, remaining_tests = tests.split_suite_by_condition(
94
 
        remaining_tests, tests.condition_isinstance((
95
 
                SmartHTTPTunnellingTest,
96
 
                TestDoCatchRedirections,
97
 
                TestHTTPConnections,
98
 
                TestHTTPRedirections,
99
 
                TestHTTPSilentRedirections,
100
 
                TestLimitedRangeRequestServer,
101
 
                TestPost,
102
 
                TestProxyHttpServer,
103
 
                TestRanges,
104
 
                TestSpecificRequestHandler,
105
 
                )))
106
 
    protocol_scenarios = [
107
 
            ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
108
 
            ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
109
 
            ]
110
 
    tp_scenarios = tests.multiply_scenarios(transport_scenarios,
111
 
                                            protocol_scenarios)
112
 
    tests.multiply_tests(tp_tests, tp_scenarios, result)
113
 
 
114
 
    # proxy auth: each auth scheme on all http versions on all implementations.
115
 
    tppa_tests, remaining_tests = tests.split_suite_by_condition(
116
 
        remaining_tests, tests.condition_isinstance((
117
 
                TestProxyAuth,
118
 
                )))
119
 
    proxy_auth_scheme_scenarios = [
120
 
        ('basic', dict(_auth_server=http_utils.ProxyBasicAuthServer)),
121
 
        ('digest', dict(_auth_server=http_utils.ProxyDigestAuthServer)),
122
 
        ('basicdigest',
123
 
         dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
 
83
                            _url_protocol='http+pycurl',)))
 
84
    return transport_scenarios
 
85
 
 
86
 
 
87
def vary_by_http_protocol_version():
 
88
    """Test on http/1.0 and 1.1"""
 
89
    return [
 
90
        ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
 
91
        ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
124
92
        ]
125
 
    tppa_scenarios = tests.multiply_scenarios(tp_scenarios,
126
 
                                              proxy_auth_scheme_scenarios)
127
 
    tests.multiply_tests(tppa_tests, tppa_scenarios, result)
128
 
 
129
 
    # auth: each auth scheme on all http versions on all implementations.
130
 
    tpa_tests, remaining_tests = tests.split_suite_by_condition(
131
 
        remaining_tests, tests.condition_isinstance((
132
 
                TestAuth,
133
 
                )))
134
 
    auth_scheme_scenarios = [
 
93
 
 
94
 
 
95
def vary_by_http_auth_scheme():
 
96
    scenarios = [
135
97
        ('basic', dict(_auth_server=http_utils.HTTPBasicAuthServer)),
136
98
        ('digest', dict(_auth_server=http_utils.HTTPDigestAuthServer)),
137
99
        ('basicdigest',
138
 
         dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
139
 
        ]
140
 
    tpa_scenarios = tests.multiply_scenarios(tp_scenarios,
141
 
                                             auth_scheme_scenarios)
142
 
    tests.multiply_tests(tpa_tests, tpa_scenarios, result)
143
 
 
144
 
    # activity: on all http[s] versions on all implementations
145
 
    tpact_tests, remaining_tests = tests.split_suite_by_condition(
146
 
        remaining_tests, tests.condition_isinstance((
147
 
                TestActivity,
148
 
                )))
 
100
            dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
 
101
        ]
 
102
    # Add some attributes common to all scenarios
 
103
    for scenario_id, scenario_dict in scenarios:
 
104
        scenario_dict.update(_auth_header='Authorization',
 
105
                             _username_prompt_prefix='',
 
106
                             _password_prompt_prefix='')
 
107
    return scenarios
 
108
 
 
109
 
 
110
def vary_by_http_proxy_auth_scheme():
 
111
    scenarios = [
 
112
        ('proxy-basic', dict(_auth_server=http_utils.ProxyBasicAuthServer)),
 
113
        ('proxy-digest', dict(_auth_server=http_utils.ProxyDigestAuthServer)),
 
114
        ('proxy-basicdigest',
 
115
            dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
 
116
        ]
 
117
    # Add some attributes common to all scenarios
 
118
    for scenario_id, scenario_dict in scenarios:
 
119
        scenario_dict.update(_auth_header='Proxy-Authorization',
 
120
                             _username_prompt_prefix='Proxy ',
 
121
                             _password_prompt_prefix='Proxy ')
 
122
    return scenarios
 
123
 
 
124
 
 
125
def vary_by_http_activity():
149
126
    activity_scenarios = [
150
127
        ('urllib,http', dict(_activity_server=ActivityHTTPServer,
151
 
                             _transport=_urllib.HttpTransport_urllib,)),
 
128
                            _transport=_urllib.HttpTransport_urllib,)),
152
129
        ]
153
 
    if tests.HTTPSServerFeature.available():
 
130
    if features.pycurl.available():
 
131
        activity_scenarios.append(
 
132
            ('pycurl,http', dict(_activity_server=ActivityHTTPServer,
 
133
                                _transport=PyCurlTransport,)),)
 
134
    if features.HTTPSServerFeature.available():
 
135
        # FIXME: Until we have a better way to handle self-signed certificates
 
136
        # (like allowing them in a test specific authentication.conf for
 
137
        # example), we need some specialized pycurl/urllib transport for tests.
 
138
        # -- vila 2012-01-20
 
139
        from bzrlib.tests import (
 
140
            ssl_certs,
 
141
            )
 
142
        class HTTPS_urllib_transport(_urllib.HttpTransport_urllib):
 
143
 
 
144
            def __init__(self, base, _from_transport=None):
 
145
                super(HTTPS_urllib_transport, self).__init__(
 
146
                    base, _from_transport=_from_transport,
 
147
                    ca_certs=ssl_certs.build_path('ca.crt'))
 
148
 
154
149
        activity_scenarios.append(
155
150
            ('urllib,https', dict(_activity_server=ActivityHTTPSServer,
156
 
                                  _transport=_urllib.HttpTransport_urllib,)),)
157
 
    if features.pycurl.available():
158
 
        activity_scenarios.append(
159
 
            ('pycurl,http', dict(_activity_server=ActivityHTTPServer,
160
 
                                 _transport=PyCurlTransport,)),)
161
 
        if tests.HTTPSServerFeature.available():
162
 
            from bzrlib.tests import (
163
 
                ssl_certs,
164
 
                )
165
 
            # FIXME: Until we have a better way to handle self-signed
166
 
            # certificates (like allowing them in a test specific
167
 
            # authentication.conf for example), we need some specialized pycurl
168
 
            # transport for tests.
 
151
                                  _transport=HTTPS_urllib_transport,)),)
 
152
        if features.pycurl.available():
169
153
            class HTTPS_pycurl_transport(PyCurlTransport):
170
154
 
171
155
                def __init__(self, base, _from_transport=None):
175
159
 
176
160
            activity_scenarios.append(
177
161
                ('pycurl,https', dict(_activity_server=ActivityHTTPSServer,
178
 
                                      _transport=HTTPS_pycurl_transport,)),)
179
 
 
180
 
    tpact_scenarios = tests.multiply_scenarios(activity_scenarios,
181
 
                                               protocol_scenarios)
182
 
    tests.multiply_tests(tpact_tests, tpact_scenarios, result)
183
 
 
184
 
    # No parametrization for the remaining tests
185
 
    result.addTests(remaining_tests)
186
 
 
187
 
    return result
 
162
                                    _transport=HTTPS_pycurl_transport,)),)
 
163
    return activity_scenarios
188
164
 
189
165
 
190
166
class FakeManager(object):
223
199
        self._sock.bind(('127.0.0.1', 0))
224
200
        self.host, self.port = self._sock.getsockname()
225
201
        self._ready = threading.Event()
226
 
        self._thread = threading.Thread(target=self._accept_read_and_reply)
227
 
        self._thread.setDaemon(True)
 
202
        self._thread = test_server.TestThread(
 
203
            sync_event=self._ready, target=self._accept_read_and_reply)
228
204
        self._thread.start()
229
 
        self._ready.wait(5)
 
205
        if 'threads' in tests.selftest_debug_flags:
 
206
            sys.stderr.write('Thread started: %s\n' % (self._thread.ident,))
 
207
        self._ready.wait()
230
208
 
231
209
    def _accept_read_and_reply(self):
232
210
        self._sock.listen(1)
233
211
        self._ready.set()
234
 
        self._sock.settimeout(5)
235
 
        try:
236
 
            conn, address = self._sock.accept()
237
 
            # On win32, the accepted connection will be non-blocking to start
238
 
            # with because we're using settimeout.
239
 
            conn.setblocking(True)
 
212
        conn, address = self._sock.accept()
 
213
        if self._expect_body_tail is not None:
240
214
            while not self.received_bytes.endswith(self._expect_body_tail):
241
215
                self.received_bytes += conn.recv(4096)
242
216
            conn.sendall('HTTP/1.1 200 OK\r\n')
243
 
        except socket.timeout:
244
 
            # Make sure the client isn't stuck waiting for us to e.g. accept.
 
217
        try:
245
218
            self._sock.close()
246
219
        except socket.error:
247
220
            # The client may have already closed the socket.
249
222
 
250
223
    def stop_server(self):
251
224
        try:
252
 
            self._sock.close()
 
225
            # Issue a fake connection to wake up the server and allow it to
 
226
            # finish quickly
 
227
            fake_conn = osutils.connect_socket((self.host, self.port))
 
228
            fake_conn.close()
253
229
        except socket.error:
254
230
            # We might have already closed it.  We don't care.
255
231
            pass
256
232
        self.host = None
257
233
        self.port = None
 
234
        self._thread.join()
 
235
        if 'threads' in tests.selftest_debug_flags:
 
236
            sys.stderr.write('Thread  joined: %s\n' % (self._thread.ident,))
258
237
 
259
238
 
260
239
class TestAuthHeader(tests.TestCase):
296
275
        self.assertEqual('realm="Thou should not pass"', remainder)
297
276
 
298
277
 
 
278
class TestHTTPRangeParsing(tests.TestCase):
 
279
 
 
280
    def setUp(self):
 
281
        super(TestHTTPRangeParsing, self).setUp()
 
282
        # We focus on range  parsing here and ignore everything else
 
283
        class RequestHandler(http_server.TestingHTTPRequestHandler):
 
284
            def setup(self): pass
 
285
            def handle(self): pass
 
286
            def finish(self): pass
 
287
 
 
288
        self.req_handler = RequestHandler(None, None, None)
 
289
 
 
290
    def assertRanges(self, ranges, header, file_size):
 
291
        self.assertEqual(ranges,
 
292
                          self.req_handler._parse_ranges(header, file_size))
 
293
 
 
294
    def test_simple_range(self):
 
295
        self.assertRanges([(0,2)], 'bytes=0-2', 12)
 
296
 
 
297
    def test_tail(self):
 
298
        self.assertRanges([(8, 11)], 'bytes=-4', 12)
 
299
 
 
300
    def test_tail_bigger_than_file(self):
 
301
        self.assertRanges([(0, 11)], 'bytes=-99', 12)
 
302
 
 
303
    def test_range_without_end(self):
 
304
        self.assertRanges([(4, 11)], 'bytes=4-', 12)
 
305
 
 
306
    def test_invalid_ranges(self):
 
307
        self.assertRanges(None, 'bytes=12-22', 12)
 
308
        self.assertRanges(None, 'bytes=1-3,12-22', 12)
 
309
        self.assertRanges(None, 'bytes=-', 12)
 
310
 
 
311
 
299
312
class TestHTTPServer(tests.TestCase):
300
313
    """Test the HTTP servers implementations."""
301
314
 
304
317
 
305
318
            protocol_version = 'HTTP/0.1'
306
319
 
307
 
        server = http_server.HttpServer(BogusRequestHandler)
308
 
        try:
309
 
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
310
 
        except:
311
 
            server.stop_server()
312
 
            self.fail('HTTP Server creation did not raise UnknownProtocol')
 
320
        self.assertRaises(httplib.UnknownProtocol,
 
321
                          http_server.HttpServer, BogusRequestHandler)
313
322
 
314
323
    def test_force_invalid_protocol(self):
315
 
        server = http_server.HttpServer(protocol_version='HTTP/0.1')
316
 
        try:
317
 
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
318
 
        except:
319
 
            server.stop_server()
320
 
            self.fail('HTTP Server creation did not raise UnknownProtocol')
 
324
        self.assertRaises(httplib.UnknownProtocol,
 
325
                          http_server.HttpServer, protocol_version='HTTP/0.1')
321
326
 
322
327
    def test_server_start_and_stop(self):
323
328
        server = http_server.HttpServer()
 
329
        self.addCleanup(server.stop_server)
324
330
        server.start_server()
325
 
        try:
326
 
            self.assertTrue(server._http_running)
327
 
        finally:
328
 
            server.stop_server()
329
 
        self.assertFalse(server._http_running)
 
331
        self.assertTrue(server.server is not None)
 
332
        self.assertTrue(server.server.serving is not None)
 
333
        self.assertTrue(server.server.serving)
330
334
 
331
335
    def test_create_http_server_one_zero(self):
332
336
        class RequestHandlerOneZero(http_server.TestingHTTPRequestHandler):
335
339
 
336
340
        server = http_server.HttpServer(RequestHandlerOneZero)
337
341
        self.start_server(server)
338
 
        self.assertIsInstance(server._httpd, http_server.TestingHTTPServer)
 
342
        self.assertIsInstance(server.server, http_server.TestingHTTPServer)
339
343
 
340
344
    def test_create_http_server_one_one(self):
341
345
        class RequestHandlerOneOne(http_server.TestingHTTPRequestHandler):
344
348
 
345
349
        server = http_server.HttpServer(RequestHandlerOneOne)
346
350
        self.start_server(server)
347
 
        self.assertIsInstance(server._httpd,
 
351
        self.assertIsInstance(server.server,
348
352
                              http_server.TestingThreadingHTTPServer)
349
353
 
350
354
    def test_create_http_server_force_one_one(self):
355
359
        server = http_server.HttpServer(RequestHandlerOneZero,
356
360
                                        protocol_version='HTTP/1.1')
357
361
        self.start_server(server)
358
 
        self.assertIsInstance(server._httpd,
 
362
        self.assertIsInstance(server.server,
359
363
                              http_server.TestingThreadingHTTPServer)
360
364
 
361
365
    def test_create_http_server_force_one_zero(self):
366
370
        server = http_server.HttpServer(RequestHandlerOneOne,
367
371
                                        protocol_version='HTTP/1.0')
368
372
        self.start_server(server)
369
 
        self.assertIsInstance(server._httpd,
 
373
        self.assertIsInstance(server.server,
370
374
                              http_server.TestingHTTPServer)
371
375
 
372
376
 
380
384
    _transport = property(_get_pycurl_maybe)
381
385
 
382
386
 
383
 
class TestHttpUrls(tests.TestCase):
384
 
 
385
 
    # TODO: This should be moved to authorization tests once they
386
 
    # are written.
387
 
 
388
 
    def test_url_parsing(self):
389
 
        f = FakeManager()
390
 
        url = http.extract_auth('http://example.com', f)
391
 
        self.assertEqual('http://example.com', url)
392
 
        self.assertEqual(0, len(f.credentials))
393
 
        url = http.extract_auth(
394
 
            'http://user:pass@example.com/bzr/bzr.dev', f)
395
 
        self.assertEqual('http://example.com/bzr/bzr.dev', url)
396
 
        self.assertEqual(1, len(f.credentials))
397
 
        self.assertEqual([None, 'example.com', 'user', 'pass'],
398
 
                         f.credentials[0])
399
 
 
400
 
 
401
387
class TestHttpTransportUrls(tests.TestCase):
402
388
    """Test the http urls."""
403
389
 
 
390
    scenarios = vary_by_http_client_implementation()
 
391
 
404
392
    def test_abs_url(self):
405
393
        """Construction of absolute http URLs"""
406
 
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
 
394
        t = self._transport('http://example.com/bzr/bzr.dev/')
407
395
        eq = self.assertEqualDiff
408
 
        eq(t.abspath('.'), 'http://bazaar-vcs.org/bzr/bzr.dev')
409
 
        eq(t.abspath('foo/bar'), 'http://bazaar-vcs.org/bzr/bzr.dev/foo/bar')
410
 
        eq(t.abspath('.bzr'), 'http://bazaar-vcs.org/bzr/bzr.dev/.bzr')
 
396
        eq(t.abspath('.'), 'http://example.com/bzr/bzr.dev')
 
397
        eq(t.abspath('foo/bar'), 'http://example.com/bzr/bzr.dev/foo/bar')
 
398
        eq(t.abspath('.bzr'), 'http://example.com/bzr/bzr.dev/.bzr')
411
399
        eq(t.abspath('.bzr/1//2/./3'),
412
 
           'http://bazaar-vcs.org/bzr/bzr.dev/.bzr/1/2/3')
 
400
           'http://example.com/bzr/bzr.dev/.bzr/1/2/3')
413
401
 
414
402
    def test_invalid_http_urls(self):
415
403
        """Trap invalid construction of urls"""
416
 
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
 
404
        self._transport('http://example.com/bzr/bzr.dev/')
417
405
        self.assertRaises(errors.InvalidURL,
418
406
                          self._transport,
419
 
                          'http://http://bazaar-vcs.org/bzr/bzr.dev/')
 
407
                          'http://http://example.com/bzr/bzr.dev/')
420
408
 
421
409
    def test_http_root_urls(self):
422
410
        """Construction of URLs from server root"""
423
 
        t = self._transport('http://bzr.ozlabs.org/')
 
411
        t = self._transport('http://example.com/')
424
412
        eq = self.assertEqualDiff
425
413
        eq(t.abspath('.bzr/tree-version'),
426
 
           'http://bzr.ozlabs.org/.bzr/tree-version')
 
414
           'http://example.com/.bzr/tree-version')
427
415
 
428
416
    def test_http_impl_urls(self):
429
417
        """There are servers which ask for particular clients to connect"""
431
419
        server.start_server()
432
420
        try:
433
421
            url = server.get_url()
434
 
            self.assertTrue(url.startswith('%s://' % self._qualified_prefix))
 
422
            self.assertTrue(url.startswith('%s://' % self._url_protocol))
435
423
        finally:
436
424
            server.stop_server()
437
425
 
475
463
class TestHTTPConnections(http_utils.TestCaseWithWebserver):
476
464
    """Test the http connections."""
477
465
 
 
466
    scenarios = multiply_scenarios(
 
467
        vary_by_http_client_implementation(),
 
468
        vary_by_http_protocol_version(),
 
469
        )
 
470
 
478
471
    def setUp(self):
479
 
        http_utils.TestCaseWithWebserver.setUp(self)
 
472
        super(TestHTTPConnections, self).setUp()
480
473
        self.build_tree(['foo/', 'foo/bar'], line_endings='binary',
481
474
                        transport=self.get_transport())
482
475
 
483
476
    def test_http_has(self):
484
477
        server = self.get_readonly_server()
485
 
        t = self._transport(server.get_url())
 
478
        t = self.get_readonly_transport()
486
479
        self.assertEqual(t.has('foo/bar'), True)
487
480
        self.assertEqual(len(server.logs), 1)
488
481
        self.assertContainsRe(server.logs[0],
490
483
 
491
484
    def test_http_has_not_found(self):
492
485
        server = self.get_readonly_server()
493
 
        t = self._transport(server.get_url())
 
486
        t = self.get_readonly_transport()
494
487
        self.assertEqual(t.has('not-found'), False)
495
488
        self.assertContainsRe(server.logs[1],
496
489
            r'"HEAD /not-found HTTP/1.." 404 - "-" "bzr/')
497
490
 
498
491
    def test_http_get(self):
499
492
        server = self.get_readonly_server()
500
 
        t = self._transport(server.get_url())
 
493
        t = self.get_readonly_transport()
501
494
        fp = t.get('foo/bar')
502
495
        self.assertEqualDiff(
503
496
            fp.read(),
525
518
class TestHttpTransportRegistration(tests.TestCase):
526
519
    """Test registrations of various http implementations"""
527
520
 
 
521
    scenarios = vary_by_http_client_implementation()
 
522
 
528
523
    def test_http_registered(self):
529
 
        t = transport.get_transport('%s://foo.com/' % self._qualified_prefix)
 
524
        t = transport.get_transport_from_url(
 
525
            '%s://foo.com/' % self._url_protocol)
530
526
        self.assertIsInstance(t, transport.Transport)
531
527
        self.assertIsInstance(t, self._transport)
532
528
 
533
529
 
534
530
class TestPost(tests.TestCase):
535
531
 
 
532
    scenarios = multiply_scenarios(
 
533
        vary_by_http_client_implementation(),
 
534
        vary_by_http_protocol_version(),
 
535
        )
 
536
 
536
537
    def test_post_body_is_received(self):
537
538
        server = RecordingServer(expect_body_tail='end-of-body',
538
 
            scheme=self._qualified_prefix)
 
539
                                 scheme=self._url_protocol)
539
540
        self.start_server(server)
540
541
        url = server.get_url()
541
 
        http_transport = self._transport(url)
 
542
        # FIXME: needs a cleanup -- vila 20100611
 
543
        http_transport = transport.get_transport_from_url(url)
542
544
        code, response = http_transport._post('abc def end-of-body')
543
545
        self.assertTrue(
544
546
            server.received_bytes.startswith('POST /.bzr/smart HTTP/1.'))
545
547
        self.assertTrue('content-length: 19\r' in server.received_bytes.lower())
 
548
        self.assertTrue('content-type: application/octet-stream\r'
 
549
                        in server.received_bytes.lower())
546
550
        # The transport should not be assuming that the server can accept
547
551
        # chunked encoding the first time it connects, because HTTP/1.1, so we
548
552
        # check for the literal string.
584
588
    Daughter classes are expected to override _req_handler_class
585
589
    """
586
590
 
 
591
    scenarios = multiply_scenarios(
 
592
        vary_by_http_client_implementation(),
 
593
        vary_by_http_protocol_version(),
 
594
        )
 
595
 
587
596
    # Provide a useful default
588
597
    _req_handler_class = http_server.TestingHTTPRequestHandler
589
598
 
590
599
    def create_transport_readonly_server(self):
591
 
        return http_server.HttpServer(self._req_handler_class,
592
 
                                      protocol_version=self._protocol_version)
 
600
        server = http_server.HttpServer(self._req_handler_class,
 
601
                                        protocol_version=self._protocol_version)
 
602
        server._url_protocol = self._url_protocol
 
603
        return server
593
604
 
594
605
    def _testing_pycurl(self):
595
606
        # TODO: This is duplicated for lots of the classes in this file
600
611
class WallRequestHandler(http_server.TestingHTTPRequestHandler):
601
612
    """Whatever request comes in, close the connection"""
602
613
 
603
 
    def handle_one_request(self):
 
614
    def _handle_one_request(self):
604
615
        """Handle a single HTTP request, by abruptly closing the connection"""
605
616
        self.close_connection = 1
606
617
 
611
622
    _req_handler_class = WallRequestHandler
612
623
 
613
624
    def test_http_has(self):
614
 
        server = self.get_readonly_server()
615
 
        t = self._transport(server.get_url())
 
625
        t = self.get_readonly_transport()
616
626
        # Unfortunately httplib (see HTTPResponse._read_status
617
627
        # for details) make no distinction between a closed
618
628
        # socket and badly formatted status line, so we can't
624
634
                          t.has, 'foo/bar')
625
635
 
626
636
    def test_http_get(self):
627
 
        server = self.get_readonly_server()
628
 
        t = self._transport(server.get_url())
 
637
        t = self.get_readonly_transport()
629
638
        self.assertRaises((errors.ConnectionError, errors.ConnectionReset,
630
639
                           errors.InvalidHttpResponse),
631
640
                          t.get, 'foo/bar')
647
656
 
648
657
    _req_handler_class = BadStatusRequestHandler
649
658
 
 
659
    def setUp(self):
 
660
        super(TestBadStatusServer, self).setUp()
 
661
        # See https://bugs.launchpad.net/bzr/+bug/1451448 for details.
 
662
        # TD;LR: Running both a TCP client and server in the same process and
 
663
        # thread uncovers a race in python. The fix is to run the server in a
 
664
        # different process. Trying to fix yet another race here is not worth
 
665
        # the effort. -- vila 2015-09-06
 
666
        if 'HTTP/1.0' in self.id():
 
667
            raise tests.TestSkipped(
 
668
                'Client/Server in the same process and thread can hang')
 
669
 
650
670
    def test_http_has(self):
651
 
        server = self.get_readonly_server()
652
 
        t = self._transport(server.get_url())
653
 
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
 
671
        t = self.get_readonly_transport()
 
672
        self.assertRaises((errors.ConnectionError, errors.ConnectionReset,
 
673
                           errors.InvalidHttpResponse),
 
674
                          t.has, 'foo/bar')
654
675
 
655
676
    def test_http_get(self):
656
 
        server = self.get_readonly_server()
657
 
        t = self._transport(server.get_url())
658
 
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
 
677
        t = self.get_readonly_transport()
 
678
        self.assertRaises((errors.ConnectionError, errors.ConnectionReset,
 
679
                           errors.InvalidHttpResponse),
 
680
                          t.get, 'foo/bar')
659
681
 
660
682
 
661
683
class InvalidStatusRequestHandler(http_server.TestingHTTPRequestHandler):
665
687
        """Fakes handling a single HTTP request, returns a bad status"""
666
688
        ignored = http_server.TestingHTTPRequestHandler.parse_request(self)
667
689
        self.wfile.write("Invalid status line\r\n")
 
690
        # If we don't close the connection pycurl will hang. Since this is a
 
691
        # stress test we don't *have* to respect the protocol, but we don't
 
692
        # have to sabotage it too much either.
 
693
        self.close_connection = True
668
694
        return False
669
695
 
670
696
 
676
702
 
677
703
    _req_handler_class = InvalidStatusRequestHandler
678
704
 
679
 
    def test_http_has(self):
680
 
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
681
 
            raise tests.KnownFailure(
682
 
                'pycurl hangs if the server send back garbage')
683
 
        super(TestInvalidStatusServer, self).test_http_has()
684
 
 
685
 
    def test_http_get(self):
686
 
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
687
 
            raise tests.KnownFailure(
688
 
                'pycurl hangs if the server send back garbage')
689
 
        super(TestInvalidStatusServer, self).test_http_get()
690
 
 
691
705
 
692
706
class BadProtocolRequestHandler(http_server.TestingHTTPRequestHandler):
693
707
    """Whatever request comes in, returns a bad protocol version"""
715
729
        super(TestBadProtocolServer, self).setUp()
716
730
 
717
731
    def test_http_has(self):
718
 
        server = self.get_readonly_server()
719
 
        t = self._transport(server.get_url())
 
732
        t = self.get_readonly_transport()
720
733
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
721
734
 
722
735
    def test_http_get(self):
723
 
        server = self.get_readonly_server()
724
 
        t = self._transport(server.get_url())
 
736
        t = self.get_readonly_transport()
725
737
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
726
738
 
727
739
 
741
753
    _req_handler_class = ForbiddenRequestHandler
742
754
 
743
755
    def test_http_has(self):
744
 
        server = self.get_readonly_server()
745
 
        t = self._transport(server.get_url())
 
756
        t = self.get_readonly_transport()
746
757
        self.assertRaises(errors.TransportError, t.has, 'foo/bar')
747
758
 
748
759
    def test_http_get(self):
749
 
        server = self.get_readonly_server()
750
 
        t = self._transport(server.get_url())
 
760
        t = self.get_readonly_transport()
751
761
        self.assertRaises(errors.TransportError, t.get, 'foo/bar')
752
762
 
753
763
 
792
802
        self.build_tree_contents([('a', '0123456789')],)
793
803
 
794
804
    def test_readv(self):
795
 
        server = self.get_readonly_server()
796
 
        t = self._transport(server.get_url())
 
805
        t = self.get_readonly_transport()
797
806
        l = list(t.readv('a', ((0, 1), (1, 1), (3, 2), (9, 1))))
798
807
        self.assertEqual(l[0], (0, '0'))
799
808
        self.assertEqual(l[1], (1, '1'))
801
810
        self.assertEqual(l[3], (9, '9'))
802
811
 
803
812
    def test_readv_out_of_order(self):
804
 
        server = self.get_readonly_server()
805
 
        t = self._transport(server.get_url())
 
813
        t = self.get_readonly_transport()
806
814
        l = list(t.readv('a', ((1, 1), (9, 1), (0, 1), (3, 2))))
807
815
        self.assertEqual(l[0], (1, '1'))
808
816
        self.assertEqual(l[1], (9, '9'))
810
818
        self.assertEqual(l[3], (3, '34'))
811
819
 
812
820
    def test_readv_invalid_ranges(self):
813
 
        server = self.get_readonly_server()
814
 
        t = self._transport(server.get_url())
 
821
        t = self.get_readonly_transport()
815
822
 
816
823
        # This is intentionally reading off the end of the file
817
824
        # since we are sure that it cannot get there
825
832
 
826
833
    def test_readv_multiple_get_requests(self):
827
834
        server = self.get_readonly_server()
828
 
        t = self._transport(server.get_url())
 
835
        t = self.get_readonly_transport()
829
836
        # force transport to issue multiple requests
830
837
        t._max_readv_combine = 1
831
838
        t._max_get_ranges = 1
839
846
 
840
847
    def test_readv_get_max_size(self):
841
848
        server = self.get_readonly_server()
842
 
        t = self._transport(server.get_url())
 
849
        t = self.get_readonly_transport()
843
850
        # force transport to issue multiple requests by limiting the number of
844
851
        # bytes by request. Note that this apply to coalesced offsets only, a
845
852
        # single range will keep its size even if bigger than the limit.
854
861
 
855
862
    def test_complete_readv_leave_pipe_clean(self):
856
863
        server = self.get_readonly_server()
857
 
        t = self._transport(server.get_url())
 
864
        t = self.get_readonly_transport()
858
865
        # force transport to issue multiple requests
859
866
        t._get_max_size = 2
860
 
        l = list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
 
867
        list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
861
868
        # The server should have issued 3 requests
862
869
        self.assertEqual(3, server.GET_request_nb)
863
870
        self.assertEqual('0123456789', t.get_bytes('a'))
865
872
 
866
873
    def test_incomplete_readv_leave_pipe_clean(self):
867
874
        server = self.get_readonly_server()
868
 
        t = self._transport(server.get_url())
 
875
        t = self.get_readonly_transport()
869
876
        # force transport to issue multiple requests
870
877
        t._get_max_size = 2
871
878
        # Don't collapse readv results into a list so that we leave unread
940
947
    def get_multiple_ranges(self, file, file_size, ranges):
941
948
        self.send_response(206)
942
949
        self.send_header('Accept-Ranges', 'bytes')
 
950
        # XXX: this is strange; the 'random' name below seems undefined and
 
951
        # yet the tests pass -- mbp 2010-10-11 bug 658773
943
952
        boundary = "%d" % random.randint(0,0x7FFFFFFF)
944
953
        self.send_header("Content-Type",
945
954
                         "multipart/byteranges; boundary=%s" % boundary)
1007
1016
                return
1008
1017
            self.send_range_content(file, start, end - start + 1)
1009
1018
            cur += 1
1010
 
        # No final boundary
 
1019
        # Final boundary
1011
1020
        self.wfile.write(boundary_line)
1012
1021
 
1013
1022
 
1021
1030
 
1022
1031
    def test_readv_with_short_reads(self):
1023
1032
        server = self.get_readonly_server()
1024
 
        t = self._transport(server.get_url())
 
1033
        t = self.get_readonly_transport()
1025
1034
        # Force separate ranges for each offset
1026
1035
        t._bytes_to_read_before_seek = 0
1027
1036
        ireadv = iter(t.readv('a', ((0, 1), (2, 1), (4, 2), (9, 1))))
1042
1051
        # that mode
1043
1052
        self.assertEqual('single', t._range_hint)
1044
1053
 
 
1054
 
 
1055
class TruncatedBeforeBoundaryRequestHandler(
 
1056
    http_server.TestingHTTPRequestHandler):
 
1057
    """Truncation before a boundary, like in bug 198646"""
 
1058
 
 
1059
    _truncated_ranges = 1
 
1060
 
 
1061
    def get_multiple_ranges(self, file, file_size, ranges):
 
1062
        self.send_response(206)
 
1063
        self.send_header('Accept-Ranges', 'bytes')
 
1064
        boundary = 'tagada'
 
1065
        self.send_header('Content-Type',
 
1066
                         'multipart/byteranges; boundary=%s' % boundary)
 
1067
        boundary_line = '--%s\r\n' % boundary
 
1068
        # Calculate the Content-Length
 
1069
        content_length = 0
 
1070
        for (start, end) in ranges:
 
1071
            content_length += len(boundary_line)
 
1072
            content_length += self._header_line_length(
 
1073
                'Content-type', 'application/octet-stream')
 
1074
            content_length += self._header_line_length(
 
1075
                'Content-Range', 'bytes %d-%d/%d' % (start, end, file_size))
 
1076
            content_length += len('\r\n') # end headers
 
1077
            content_length += end - start # + 1
 
1078
        content_length += len(boundary_line)
 
1079
        self.send_header('Content-length', content_length)
 
1080
        self.end_headers()
 
1081
 
 
1082
        # Send the multipart body
 
1083
        cur = 0
 
1084
        for (start, end) in ranges:
 
1085
            if cur + self._truncated_ranges >= len(ranges):
 
1086
                # Abruptly ends the response and close the connection
 
1087
                self.close_connection = 1
 
1088
                return
 
1089
            self.wfile.write(boundary_line)
 
1090
            self.send_header('Content-type', 'application/octet-stream')
 
1091
            self.send_header('Content-Range', 'bytes %d-%d/%d'
 
1092
                             % (start, end, file_size))
 
1093
            self.end_headers()
 
1094
            self.send_range_content(file, start, end - start + 1)
 
1095
            cur += 1
 
1096
        # Final boundary
 
1097
        self.wfile.write(boundary_line)
 
1098
 
 
1099
 
 
1100
class TestTruncatedBeforeBoundary(TestSpecificRequestHandler):
 
1101
    """Tests the case of bug 198646, disconnecting before a boundary."""
 
1102
 
 
1103
    _req_handler_class = TruncatedBeforeBoundaryRequestHandler
 
1104
 
 
1105
    def setUp(self):
 
1106
        super(TestTruncatedBeforeBoundary, self).setUp()
 
1107
        self.build_tree_contents([('a', '0123456789')],)
 
1108
 
 
1109
    def test_readv_with_short_reads(self):
 
1110
        server = self.get_readonly_server()
 
1111
        t = self.get_readonly_transport()
 
1112
        # Force separate ranges for each offset
 
1113
        t._bytes_to_read_before_seek = 0
 
1114
        ireadv = iter(t.readv('a', ((0, 1), (2, 1), (4, 2), (9, 1))))
 
1115
        self.assertEqual((0, '0'), ireadv.next())
 
1116
        self.assertEqual((2, '2'), ireadv.next())
 
1117
        self.assertEqual((4, '45'), ireadv.next())
 
1118
        self.assertEqual((9, '9'), ireadv.next())
 
1119
 
 
1120
 
1045
1121
class LimitedRangeRequestHandler(http_server.TestingHTTPRequestHandler):
1046
1122
    """Errors out when range specifiers exceed the limit"""
1047
1123
 
1071
1147
class TestLimitedRangeRequestServer(http_utils.TestCaseWithWebserver):
1072
1148
    """Tests readv requests against a server erroring out on too much ranges."""
1073
1149
 
 
1150
    scenarios = multiply_scenarios(
 
1151
        vary_by_http_client_implementation(),
 
1152
        vary_by_http_protocol_version(),
 
1153
        )
 
1154
 
1074
1155
    # Requests with more range specifiers will error out
1075
1156
    range_limit = 3
1076
1157
 
1078
1159
        return LimitedRangeHTTPServer(range_limit=self.range_limit,
1079
1160
                                      protocol_version=self._protocol_version)
1080
1161
 
1081
 
    def get_transport(self):
1082
 
        return self._transport(self.get_readonly_server().get_url())
1083
 
 
1084
1162
    def setUp(self):
1085
 
        http_utils.TestCaseWithWebserver.setUp(self)
 
1163
        super(TestLimitedRangeRequestServer, self).setUp()
1086
1164
        # We need to manipulate ranges that correspond to real chunks in the
1087
1165
        # response, so we build a content appropriately.
1088
1166
        filler = ''.join(['abcdefghij' for x in range(102)])
1090
1168
        self.build_tree_contents([('a', content)],)
1091
1169
 
1092
1170
    def test_few_ranges(self):
1093
 
        t = self.get_transport()
 
1171
        t = self.get_readonly_transport()
1094
1172
        l = list(t.readv('a', ((0, 4), (1024, 4), )))
1095
1173
        self.assertEqual(l[0], (0, '0000'))
1096
1174
        self.assertEqual(l[1], (1024, '0001'))
1097
1175
        self.assertEqual(1, self.get_readonly_server().GET_request_nb)
1098
1176
 
1099
1177
    def test_more_ranges(self):
1100
 
        t = self.get_transport()
 
1178
        t = self.get_readonly_transport()
1101
1179
        l = list(t.readv('a', ((0, 4), (1024, 4), (4096, 4), (8192, 4))))
1102
1180
        self.assertEqual(l[0], (0, '0000'))
1103
1181
        self.assertEqual(l[1], (1024, '0001'))
1114
1192
    Only the urllib implementation is tested here.
1115
1193
    """
1116
1194
 
1117
 
    def setUp(self):
1118
 
        tests.TestCase.setUp(self)
1119
 
        self._old_env = {}
1120
 
 
1121
 
    def tearDown(self):
1122
 
        self._restore_env()
1123
 
        tests.TestCase.tearDown(self)
1124
 
 
1125
 
    def _install_env(self, env):
1126
 
        for name, value in env.iteritems():
1127
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1128
 
 
1129
 
    def _restore_env(self):
1130
 
        for name, value in self._old_env.iteritems():
1131
 
            osutils.set_or_unset_env(name, value)
1132
 
 
1133
1195
    def _proxied_request(self):
1134
1196
        handler = _urllib2_wrappers.ProxyHandler()
1135
 
        request = _urllib2_wrappers.Request('GET','http://baz/buzzle')
 
1197
        request = _urllib2_wrappers.Request('GET', 'http://baz/buzzle')
1136
1198
        handler.set_proxy(request, 'http')
1137
1199
        return request
1138
1200
 
 
1201
    def assertEvaluateProxyBypass(self, expected, host, no_proxy):
 
1202
        handler = _urllib2_wrappers.ProxyHandler()
 
1203
        self.assertEqual(expected,
 
1204
                          handler.evaluate_proxy_bypass(host, no_proxy))
 
1205
 
1139
1206
    def test_empty_user(self):
1140
 
        self._install_env({'http_proxy': 'http://bar.com'})
 
1207
        self.overrideEnv('http_proxy', 'http://bar.com')
 
1208
        request = self._proxied_request()
 
1209
        self.assertFalse(request.headers.has_key('Proxy-authorization'))
 
1210
 
 
1211
    def test_user_with_at(self):
 
1212
        self.overrideEnv('http_proxy',
 
1213
                         'http://username@domain:password@proxy_host:1234')
1141
1214
        request = self._proxied_request()
1142
1215
        self.assertFalse(request.headers.has_key('Proxy-authorization'))
1143
1216
 
1144
1217
    def test_invalid_proxy(self):
1145
1218
        """A proxy env variable without scheme"""
1146
 
        self._install_env({'http_proxy': 'host:1234'})
 
1219
        self.overrideEnv('http_proxy', 'host:1234')
1147
1220
        self.assertRaises(errors.InvalidURL, self._proxied_request)
1148
1221
 
 
1222
    def test_evaluate_proxy_bypass_true(self):
 
1223
        """The host is not proxied"""
 
1224
        self.assertEvaluateProxyBypass(True, 'example.com', 'example.com')
 
1225
        self.assertEvaluateProxyBypass(True, 'bzr.example.com', '*example.com')
 
1226
 
 
1227
    def test_evaluate_proxy_bypass_false(self):
 
1228
        """The host is proxied"""
 
1229
        self.assertEvaluateProxyBypass(False, 'bzr.example.com', None)
 
1230
 
 
1231
    def test_evaluate_proxy_bypass_unknown(self):
 
1232
        """The host is not explicitly proxied"""
 
1233
        self.assertEvaluateProxyBypass(None, 'example.com', 'not.example.com')
 
1234
        self.assertEvaluateProxyBypass(None, 'bzr.example.com', 'example.com')
 
1235
 
 
1236
    def test_evaluate_proxy_bypass_empty_entries(self):
 
1237
        """Ignore empty entries"""
 
1238
        self.assertEvaluateProxyBypass(None, 'example.com', '')
 
1239
        self.assertEvaluateProxyBypass(None, 'example.com', ',')
 
1240
        self.assertEvaluateProxyBypass(None, 'example.com', 'foo,,bar')
 
1241
 
1149
1242
 
1150
1243
class TestProxyHttpServer(http_utils.TestCaseWithTwoWebservers):
1151
1244
    """Tests proxy server.
1156
1249
    to the file names).
1157
1250
    """
1158
1251
 
 
1252
    scenarios = multiply_scenarios(
 
1253
        vary_by_http_client_implementation(),
 
1254
        vary_by_http_protocol_version(),
 
1255
        )
 
1256
 
1159
1257
    # FIXME: We don't have an https server available, so we don't
1160
 
    # test https connections.
 
1258
    # test https connections. --vila toolongago
1161
1259
 
1162
1260
    def setUp(self):
1163
1261
        super(TestProxyHttpServer, self).setUp()
 
1262
        self.transport_secondary_server = http_utils.ProxyServer
1164
1263
        self.build_tree_contents([('foo', 'contents of foo\n'),
1165
1264
                                  ('foo-proxied', 'proxied contents of foo\n')])
1166
1265
        # Let's setup some attributes for tests
1167
 
        self.server = self.get_readonly_server()
1168
 
        self.proxy_address = '%s:%d' % (self.server.host, self.server.port)
 
1266
        server = self.get_readonly_server()
 
1267
        self.server_host_port = '%s:%d' % (server.host, server.port)
1169
1268
        if self._testing_pycurl():
1170
1269
            # Oh my ! pycurl does not check for the port as part of
1171
1270
            # no_proxy :-( So we just test the host part
1172
 
            self.no_proxy_host = self.server.host
 
1271
            self.no_proxy_host = server.host
1173
1272
        else:
1174
 
            self.no_proxy_host = self.proxy_address
 
1273
            self.no_proxy_host = self.server_host_port
1175
1274
        # The secondary server is the proxy
1176
 
        self.proxy = self.get_secondary_server()
1177
 
        self.proxy_url = self.proxy.get_url()
1178
 
        self._old_env = {}
 
1275
        self.proxy_url = self.get_secondary_url()
1179
1276
 
1180
1277
    def _testing_pycurl(self):
1181
1278
        # TODO: This is duplicated for lots of the classes in this file
1182
1279
        return (features.pycurl.available()
1183
1280
                and self._transport == PyCurlTransport)
1184
1281
 
1185
 
    def create_transport_secondary_server(self):
1186
 
        """Creates an http server that will serve files with
1187
 
        '-proxied' appended to their names.
1188
 
        """
1189
 
        return http_utils.ProxyServer(protocol_version=self._protocol_version)
1190
 
 
1191
 
    def _install_env(self, env):
1192
 
        for name, value in env.iteritems():
1193
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1194
 
 
1195
 
    def _restore_env(self):
1196
 
        for name, value in self._old_env.iteritems():
1197
 
            osutils.set_or_unset_env(name, value)
1198
 
 
1199
 
    def proxied_in_env(self, env):
1200
 
        self._install_env(env)
1201
 
        url = self.server.get_url()
1202
 
        t = self._transport(url)
1203
 
        try:
1204
 
            self.assertEqual('proxied contents of foo\n', t.get('foo').read())
1205
 
        finally:
1206
 
            self._restore_env()
1207
 
 
1208
 
    def not_proxied_in_env(self, env):
1209
 
        self._install_env(env)
1210
 
        url = self.server.get_url()
1211
 
        t = self._transport(url)
1212
 
        try:
1213
 
            self.assertEqual('contents of foo\n', t.get('foo').read())
1214
 
        finally:
1215
 
            self._restore_env()
 
1282
    def assertProxied(self):
 
1283
        t = self.get_readonly_transport()
 
1284
        self.assertEqual('proxied contents of foo\n', t.get('foo').read())
 
1285
 
 
1286
    def assertNotProxied(self):
 
1287
        t = self.get_readonly_transport()
 
1288
        self.assertEqual('contents of foo\n', t.get('foo').read())
1216
1289
 
1217
1290
    def test_http_proxy(self):
1218
 
        self.proxied_in_env({'http_proxy': self.proxy_url})
 
1291
        self.overrideEnv('http_proxy', self.proxy_url)
 
1292
        self.assertProxied()
1219
1293
 
1220
1294
    def test_HTTP_PROXY(self):
1221
1295
        if self._testing_pycurl():
1224
1298
            # about. Should we ?)
1225
1299
            raise tests.TestNotApplicable(
1226
1300
                'pycurl does not check HTTP_PROXY for security reasons')
1227
 
        self.proxied_in_env({'HTTP_PROXY': self.proxy_url})
 
1301
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
 
1302
        self.assertProxied()
1228
1303
 
1229
1304
    def test_all_proxy(self):
1230
 
        self.proxied_in_env({'all_proxy': self.proxy_url})
 
1305
        self.overrideEnv('all_proxy', self.proxy_url)
 
1306
        self.assertProxied()
1231
1307
 
1232
1308
    def test_ALL_PROXY(self):
1233
 
        self.proxied_in_env({'ALL_PROXY': self.proxy_url})
 
1309
        self.overrideEnv('ALL_PROXY', self.proxy_url)
 
1310
        self.assertProxied()
1234
1311
 
1235
1312
    def test_http_proxy_with_no_proxy(self):
1236
 
        self.not_proxied_in_env({'http_proxy': self.proxy_url,
1237
 
                                 'no_proxy': self.no_proxy_host})
 
1313
        self.overrideEnv('no_proxy', self.no_proxy_host)
 
1314
        self.overrideEnv('http_proxy', self.proxy_url)
 
1315
        self.assertNotProxied()
1238
1316
 
1239
1317
    def test_HTTP_PROXY_with_NO_PROXY(self):
1240
1318
        if self._testing_pycurl():
1241
1319
            raise tests.TestNotApplicable(
1242
1320
                'pycurl does not check HTTP_PROXY for security reasons')
1243
 
        self.not_proxied_in_env({'HTTP_PROXY': self.proxy_url,
1244
 
                                 'NO_PROXY': self.no_proxy_host})
 
1321
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
 
1322
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
 
1323
        self.assertNotProxied()
1245
1324
 
1246
1325
    def test_all_proxy_with_no_proxy(self):
1247
 
        self.not_proxied_in_env({'all_proxy': self.proxy_url,
1248
 
                                 'no_proxy': self.no_proxy_host})
 
1326
        self.overrideEnv('no_proxy', self.no_proxy_host)
 
1327
        self.overrideEnv('all_proxy', self.proxy_url)
 
1328
        self.assertNotProxied()
1249
1329
 
1250
1330
    def test_ALL_PROXY_with_NO_PROXY(self):
1251
 
        self.not_proxied_in_env({'ALL_PROXY': self.proxy_url,
1252
 
                                 'NO_PROXY': self.no_proxy_host})
 
1331
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
 
1332
        self.overrideEnv('ALL_PROXY', self.proxy_url)
 
1333
        self.assertNotProxied()
1253
1334
 
1254
1335
    def test_http_proxy_without_scheme(self):
 
1336
        self.overrideEnv('http_proxy', self.server_host_port)
1255
1337
        if self._testing_pycurl():
1256
1338
            # pycurl *ignores* invalid proxy env variables. If that ever change
1257
1339
            # in the future, this test will fail indicating that pycurl do not
1258
1340
            # ignore anymore such variables.
1259
 
            self.not_proxied_in_env({'http_proxy': self.proxy_address})
 
1341
            self.assertNotProxied()
1260
1342
        else:
1261
 
            self.assertRaises(errors.InvalidURL,
1262
 
                              self.proxied_in_env,
1263
 
                              {'http_proxy': self.proxy_address})
 
1343
            self.assertRaises(errors.InvalidURL, self.assertProxied)
1264
1344
 
1265
1345
 
1266
1346
class TestRanges(http_utils.TestCaseWithWebserver):
1267
1347
    """Test the Range header in GET methods."""
1268
1348
 
 
1349
    scenarios = multiply_scenarios(
 
1350
        vary_by_http_client_implementation(),
 
1351
        vary_by_http_protocol_version(),
 
1352
        )
 
1353
 
1269
1354
    def setUp(self):
1270
 
        http_utils.TestCaseWithWebserver.setUp(self)
 
1355
        super(TestRanges, self).setUp()
1271
1356
        self.build_tree_contents([('a', '0123456789')],)
1272
 
        server = self.get_readonly_server()
1273
 
        self.transport = self._transport(server.get_url())
1274
1357
 
1275
1358
    def create_transport_readonly_server(self):
1276
1359
        return http_server.HttpServer(protocol_version=self._protocol_version)
1277
1360
 
1278
1361
    def _file_contents(self, relpath, ranges):
 
1362
        t = self.get_readonly_transport()
1279
1363
        offsets = [ (start, end - start + 1) for start, end in ranges]
1280
 
        coalesce = self.transport._coalesce_offsets
 
1364
        coalesce = t._coalesce_offsets
1281
1365
        coalesced = list(coalesce(offsets, limit=0, fudge_factor=0))
1282
 
        code, data = self.transport._get(relpath, coalesced)
 
1366
        code, data = t._get(relpath, coalesced)
1283
1367
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1284
1368
        for start, end in ranges:
1285
1369
            data.seek(start)
1286
1370
            yield data.read(end - start + 1)
1287
1371
 
1288
1372
    def _file_tail(self, relpath, tail_amount):
1289
 
        code, data = self.transport._get(relpath, [], tail_amount)
 
1373
        t = self.get_readonly_transport()
 
1374
        code, data = t._get(relpath, [], tail_amount)
1290
1375
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1291
1376
        data.seek(-tail_amount, 2)
1292
1377
        return data.read(tail_amount)
1311
1396
class TestHTTPRedirections(http_utils.TestCaseWithRedirectedWebserver):
1312
1397
    """Test redirection between http servers."""
1313
1398
 
1314
 
    def create_transport_secondary_server(self):
1315
 
        """Create the secondary server redirecting to the primary server"""
1316
 
        new = self.get_readonly_server()
1317
 
 
1318
 
        redirecting = http_utils.HTTPServerRedirecting(
1319
 
            protocol_version=self._protocol_version)
1320
 
        redirecting.redirect_to(new.host, new.port)
1321
 
        return redirecting
 
1399
    scenarios = multiply_scenarios(
 
1400
        vary_by_http_client_implementation(),
 
1401
        vary_by_http_protocol_version(),
 
1402
        )
1322
1403
 
1323
1404
    def setUp(self):
1324
1405
        super(TestHTTPRedirections, self).setUp()
1326
1407
                                  ('bundle',
1327
1408
                                  '# Bazaar revision bundle v0.9\n#\n')
1328
1409
                                  ],)
1329
 
        # The requests to the old server will be redirected to the new server
1330
 
        self.old_transport = self._transport(self.old_server.get_url())
1331
1410
 
1332
1411
    def test_redirected(self):
1333
 
        self.assertRaises(errors.RedirectRequested, self.old_transport.get, 'a')
1334
 
        t = self._transport(self.new_server.get_url())
1335
 
        self.assertEqual('0123456789', t.get('a').read())
1336
 
 
1337
 
    def test_read_redirected_bundle_from_url(self):
1338
 
        from bzrlib.bundle import read_bundle_from_url
1339
 
        url = self.old_transport.abspath('bundle')
1340
 
        bundle = self.applyDeprecated(deprecated_in((1, 12, 0)),
1341
 
                read_bundle_from_url, url)
1342
 
        # If read_bundle_from_url was successful we get an empty bundle
1343
 
        self.assertEqual([], bundle.revisions)
 
1412
        self.assertRaises(errors.RedirectRequested,
 
1413
                          self.get_old_transport().get, 'a')
 
1414
        self.assertEqual('0123456789', self.get_new_transport().get('a').read())
1344
1415
 
1345
1416
 
1346
1417
class RedirectedRequest(_urllib2_wrappers.Request):
1363
1434
    test.overrideAttr(_urllib2_wrappers, 'Request', RedirectedRequest)
1364
1435
 
1365
1436
 
 
1437
def cleanup_http_redirection_connections(test):
 
1438
    # Some sockets are opened but never seen by _urllib, so we trap them at
 
1439
    # the _urllib2_wrappers level to be able to clean them up.
 
1440
    def socket_disconnect(sock):
 
1441
        try:
 
1442
            sock.shutdown(socket.SHUT_RDWR)
 
1443
            sock.close()
 
1444
        except socket.error:
 
1445
            pass
 
1446
    def connect(connection):
 
1447
        test.http_connect_orig(connection)
 
1448
        test.addCleanup(socket_disconnect, connection.sock)
 
1449
    test.http_connect_orig = test.overrideAttr(
 
1450
        _urllib2_wrappers.HTTPConnection, 'connect', connect)
 
1451
    def connect(connection):
 
1452
        test.https_connect_orig(connection)
 
1453
        test.addCleanup(socket_disconnect, connection.sock)
 
1454
    test.https_connect_orig = test.overrideAttr(
 
1455
        _urllib2_wrappers.HTTPSConnection, 'connect', connect)
 
1456
 
 
1457
 
1366
1458
class TestHTTPSilentRedirections(http_utils.TestCaseWithRedirectedWebserver):
1367
1459
    """Test redirections.
1368
1460
 
1377
1469
    -- vila 20070212
1378
1470
    """
1379
1471
 
 
1472
    scenarios = multiply_scenarios(
 
1473
        vary_by_http_client_implementation(),
 
1474
        vary_by_http_protocol_version(),
 
1475
        )
 
1476
 
1380
1477
    def setUp(self):
1381
1478
        if (features.pycurl.available()
1382
1479
            and self._transport == PyCurlTransport):
1383
1480
            raise tests.TestNotApplicable(
1384
 
                "pycurl doesn't redirect silently annymore")
 
1481
                "pycurl doesn't redirect silently anymore")
1385
1482
        super(TestHTTPSilentRedirections, self).setUp()
1386
1483
        install_redirected_request(self)
 
1484
        cleanup_http_redirection_connections(self)
1387
1485
        self.build_tree_contents([('a','a'),
1388
1486
                                  ('1/',),
1389
1487
                                  ('1/a', 'redirected once'),
1397
1495
                                  ('5/a', 'redirected 5 times'),
1398
1496
                                  ],)
1399
1497
 
1400
 
        self.old_transport = self._transport(self.old_server.get_url())
1401
 
 
1402
 
    def create_transport_secondary_server(self):
1403
 
        """Create the secondary server, redirections are defined in the tests"""
1404
 
        return http_utils.HTTPServerRedirecting(
1405
 
            protocol_version=self._protocol_version)
1406
 
 
1407
1498
    def test_one_redirection(self):
1408
 
        t = self.old_transport
1409
 
 
1410
 
        req = RedirectedRequest('GET', t.abspath('a'))
 
1499
        t = self.get_old_transport()
 
1500
        req = RedirectedRequest('GET', t._remote_path('a'))
1411
1501
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1412
1502
                                       self.new_server.port)
1413
1503
        self.old_server.redirections = \
1414
1504
            [('(.*)', r'%s/1\1' % (new_prefix), 301),]
1415
 
        self.assertEqual('redirected once',t._perform(req).read())
 
1505
        self.assertEqual('redirected once', t._perform(req).read())
1416
1506
 
1417
1507
    def test_five_redirections(self):
1418
 
        t = self.old_transport
1419
 
 
1420
 
        req = RedirectedRequest('GET', t.abspath('a'))
 
1508
        t = self.get_old_transport()
 
1509
        req = RedirectedRequest('GET', t._remote_path('a'))
1421
1510
        old_prefix = 'http://%s:%s' % (self.old_server.host,
1422
1511
                                       self.old_server.port)
1423
1512
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1429
1518
            ('/4(.*)', r'%s/5\1' % (new_prefix), 301),
1430
1519
            ('(/[^/]+)', r'%s/1\1' % (old_prefix), 301),
1431
1520
            ]
1432
 
        self.assertEqual('redirected 5 times',t._perform(req).read())
 
1521
        self.assertEqual('redirected 5 times', t._perform(req).read())
1433
1522
 
1434
1523
 
1435
1524
class TestDoCatchRedirections(http_utils.TestCaseWithRedirectedWebserver):
1436
1525
    """Test transport.do_catching_redirections."""
1437
1526
 
 
1527
    scenarios = multiply_scenarios(
 
1528
        vary_by_http_client_implementation(),
 
1529
        vary_by_http_protocol_version(),
 
1530
        )
 
1531
 
1438
1532
    def setUp(self):
1439
1533
        super(TestDoCatchRedirections, self).setUp()
1440
1534
        self.build_tree_contents([('a', '0123456789'),],)
1441
 
 
1442
 
        self.old_transport = self._transport(self.old_server.get_url())
1443
 
 
1444
 
    def get_a(self, transport):
1445
 
        return transport.get('a')
 
1535
        cleanup_http_redirection_connections(self)
 
1536
 
 
1537
        self.old_transport = self.get_old_transport()
 
1538
 
 
1539
    def get_a(self, t):
 
1540
        return t.get('a')
1446
1541
 
1447
1542
    def test_no_redirection(self):
1448
 
        t = self._transport(self.new_server.get_url())
 
1543
        t = self.get_new_transport()
1449
1544
 
1450
1545
        # We use None for redirected so that we fail if redirected
1451
1546
        self.assertEqual('0123456789',
1455
1550
    def test_one_redirection(self):
1456
1551
        self.redirections = 0
1457
1552
 
1458
 
        def redirected(transport, exception, redirection_notice):
 
1553
        def redirected(t, exception, redirection_notice):
1459
1554
            self.redirections += 1
1460
 
            dir, file = urlutils.split(exception.target)
1461
 
            return self._transport(dir)
 
1555
            redirected_t = t._redirected_to(exception.source, exception.target)
 
1556
            return redirected_t
1462
1557
 
1463
1558
        self.assertEqual('0123456789',
1464
1559
                         transport.do_catching_redirections(
1478
1573
                          self.get_a, self.old_transport, redirected)
1479
1574
 
1480
1575
 
 
1576
def _setup_authentication_config(**kwargs):
 
1577
    conf = config.AuthenticationConfig()
 
1578
    conf._get_config().update({'httptest': kwargs})
 
1579
    conf._save()
 
1580
 
 
1581
 
 
1582
class TestUrllib2AuthHandler(tests.TestCaseWithTransport):
 
1583
    """Unit tests for glue by which urllib2 asks us for authentication"""
 
1584
 
 
1585
    def test_get_user_password_without_port(self):
 
1586
        """We cope if urllib2 doesn't tell us the port.
 
1587
 
 
1588
        See https://bugs.launchpad.net/bzr/+bug/654684
 
1589
        """
 
1590
        user = 'joe'
 
1591
        password = 'foo'
 
1592
        _setup_authentication_config(scheme='http', host='localhost',
 
1593
                                     user=user, password=password)
 
1594
        handler = _urllib2_wrappers.HTTPAuthHandler()
 
1595
        got_pass = handler.get_user_password(dict(
 
1596
            user='joe',
 
1597
            protocol='http',
 
1598
            host='localhost',
 
1599
            path='/',
 
1600
            realm='Realm',
 
1601
            ))
 
1602
        self.assertEqual((user, password), got_pass)
 
1603
 
 
1604
 
1481
1605
class TestAuth(http_utils.TestCaseWithWebserver):
1482
1606
    """Test authentication scheme"""
1483
1607
 
1484
 
    _auth_header = 'Authorization'
1485
 
    _password_prompt_prefix = ''
1486
 
    _username_prompt_prefix = ''
1487
 
    # Set by load_tests
1488
 
    _auth_server = None
 
1608
    scenarios = multiply_scenarios(
 
1609
        vary_by_http_client_implementation(),
 
1610
        vary_by_http_protocol_version(),
 
1611
        vary_by_http_auth_scheme(),
 
1612
        )
1489
1613
 
1490
1614
    def setUp(self):
1491
1615
        super(TestAuth, self).setUp()
1494
1618
                                  ('b', 'contents of b\n'),])
1495
1619
 
1496
1620
    def create_transport_readonly_server(self):
1497
 
        return self._auth_server(protocol_version=self._protocol_version)
 
1621
        server = self._auth_server(protocol_version=self._protocol_version)
 
1622
        server._url_protocol = self._url_protocol
 
1623
        return server
1498
1624
 
1499
1625
    def _testing_pycurl(self):
1500
1626
        # TODO: This is duplicated for lots of the classes in this file
1513
1639
        return url
1514
1640
 
1515
1641
    def get_user_transport(self, user, password):
1516
 
        return self._transport(self.get_user_url(user, password))
 
1642
        t = transport.get_transport_from_url(
 
1643
            self.get_user_url(user, password))
 
1644
        return t
1517
1645
 
1518
1646
    def test_no_user(self):
1519
1647
        self.server.add_user('joe', 'foo')
1630
1758
        ui.ui_factory = tests.TestUIFactory(stdin=stdin_content,
1631
1759
                                            stderr=tests.StringIOWrapper())
1632
1760
        # Create a minimal config file with the right password
1633
 
        conf = config.AuthenticationConfig()
1634
 
        conf._get_config().update(
1635
 
            {'httptest': {'scheme': 'http', 'port': self.server.port,
1636
 
                          'user': user, 'password': password}})
1637
 
        conf._save()
 
1761
        _setup_authentication_config(scheme='http', port=self.server.port,
 
1762
                                     user=user, password=password)
1638
1763
        # Issue a request to the server to connect
1639
1764
        self.assertEqual('contents of a\n',t.get('a').read())
1640
1765
        # stdin should have  been left untouched
1642
1767
        # Only one 'Authentication Required' error should occur
1643
1768
        self.assertEqual(1, self.server.auth_required_errors)
1644
1769
 
1645
 
    def test_user_from_auth_conf(self):
1646
 
        if self._testing_pycurl():
1647
 
            raise tests.TestNotApplicable(
1648
 
                'pycurl does not support authentication.conf')
1649
 
        user = 'joe'
1650
 
        password = 'foo'
1651
 
        self.server.add_user(user, password)
1652
 
        # Create a minimal config file with the right password
1653
 
        conf = config.AuthenticationConfig()
1654
 
        conf._get_config().update(
1655
 
            {'httptest': {'scheme': 'http', 'port': self.server.port,
1656
 
                          'user': user, 'password': password}})
1657
 
        conf._save()
1658
 
        t = self.get_user_transport(None, None)
1659
 
        # Issue a request to the server to connect
1660
 
        self.assertEqual('contents of a\n', t.get('a').read())
1661
 
        # Only one 'Authentication Required' error should occur
1662
 
        self.assertEqual(1, self.server.auth_required_errors)
1663
 
 
1664
1770
    def test_changing_nonce(self):
1665
1771
        if self._auth_server not in (http_utils.HTTPDigestAuthServer,
1666
1772
                                     http_utils.ProxyDigestAuthServer):
1667
1773
            raise tests.TestNotApplicable('HTTP/proxy auth digest only test')
1668
1774
        if self._testing_pycurl():
1669
 
            raise tests.KnownFailure(
 
1775
            self.knownFailure(
1670
1776
                'pycurl does not handle a nonce change')
1671
1777
        self.server.add_user('joe', 'foo')
1672
1778
        t = self.get_user_transport('joe', 'foo')
1682
1788
        # initial 'who are you' and a second 'who are you' with the new nonce)
1683
1789
        self.assertEqual(2, self.server.auth_required_errors)
1684
1790
 
 
1791
    def test_user_from_auth_conf(self):
 
1792
        if self._testing_pycurl():
 
1793
            raise tests.TestNotApplicable(
 
1794
                'pycurl does not support authentication.conf')
 
1795
        user = 'joe'
 
1796
        password = 'foo'
 
1797
        self.server.add_user(user, password)
 
1798
        _setup_authentication_config(scheme='http', port=self.server.port,
 
1799
                                     user=user, password=password)
 
1800
        t = self.get_user_transport(None, None)
 
1801
        # Issue a request to the server to connect
 
1802
        self.assertEqual('contents of a\n', t.get('a').read())
 
1803
        # Only one 'Authentication Required' error should occur
 
1804
        self.assertEqual(1, self.server.auth_required_errors)
 
1805
 
 
1806
    def test_no_credential_leaks_in_log(self):
 
1807
        self.overrideAttr(debug, 'debug_flags', set(['http']))
 
1808
        user = 'joe'
 
1809
        password = 'very-sensitive-password'
 
1810
        self.server.add_user(user, password)
 
1811
        t = self.get_user_transport(user, password)
 
1812
        # Capture the debug calls to mutter
 
1813
        self.mutters = []
 
1814
        def mutter(*args):
 
1815
            lines = args[0] % args[1:]
 
1816
            # Some calls output multiple lines, just split them now since we
 
1817
            # care about a single one later.
 
1818
            self.mutters.extend(lines.splitlines())
 
1819
        self.overrideAttr(trace, 'mutter', mutter)
 
1820
        # Issue a request to the server to connect
 
1821
        self.assertEqual(True, t.has('a'))
 
1822
        # Only one 'Authentication Required' error should occur
 
1823
        self.assertEqual(1, self.server.auth_required_errors)
 
1824
        # Since the authentification succeeded, there should be a corresponding
 
1825
        # debug line
 
1826
        sent_auth_headers = [line for line in self.mutters
 
1827
                             if line.startswith('> %s' % (self._auth_header,))]
 
1828
        self.assertLength(1, sent_auth_headers)
 
1829
        self.assertStartsWith(sent_auth_headers[0],
 
1830
                              '> %s: <masked>' % (self._auth_header,))
1685
1831
 
1686
1832
 
1687
1833
class TestProxyAuth(TestAuth):
1688
 
    """Test proxy authentication schemes."""
1689
 
 
1690
 
    _auth_header = 'Proxy-authorization'
1691
 
    _password_prompt_prefix = 'Proxy '
1692
 
    _username_prompt_prefix = 'Proxy '
 
1834
    """Test proxy authentication schemes.
 
1835
 
 
1836
    This inherits from TestAuth to tweak the setUp and filter some failing
 
1837
    tests.
 
1838
    """
 
1839
 
 
1840
    scenarios = multiply_scenarios(
 
1841
        vary_by_http_client_implementation(),
 
1842
        vary_by_http_protocol_version(),
 
1843
        vary_by_http_proxy_auth_scheme(),
 
1844
        )
1693
1845
 
1694
1846
    def setUp(self):
1695
1847
        super(TestProxyAuth, self).setUp()
1696
 
        self._old_env = {}
1697
 
        self.addCleanup(self._restore_env)
1698
1848
        # Override the contents to avoid false positives
1699
1849
        self.build_tree_contents([('a', 'not proxied contents of a\n'),
1700
1850
                                  ('b', 'not proxied contents of b\n'),
1703
1853
                                  ])
1704
1854
 
1705
1855
    def get_user_transport(self, user, password):
1706
 
        self._install_env({'all_proxy': self.get_user_url(user, password)})
1707
 
        return self._transport(self.server.get_url())
1708
 
 
1709
 
    def _install_env(self, env):
1710
 
        for name, value in env.iteritems():
1711
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1712
 
 
1713
 
    def _restore_env(self):
1714
 
        for name, value in self._old_env.iteritems():
1715
 
            osutils.set_or_unset_env(name, value)
 
1856
        self.overrideEnv('all_proxy', self.get_user_url(user, password))
 
1857
        return TestAuth.get_user_transport(self, user, password)
1716
1858
 
1717
1859
    def test_empty_pass(self):
1718
1860
        if self._testing_pycurl():
1719
1861
            import pycurl
1720
1862
            if pycurl.version_info()[1] < '7.16.0':
1721
 
                raise tests.KnownFailure(
 
1863
                self.knownFailure(
1722
1864
                    'pycurl < 7.16.0 does not handle empty proxy passwords')
1723
1865
        super(TestProxyAuth, self).test_empty_pass()
1724
1866
 
1737
1879
        self.readfile = StringIO(socket_read_content)
1738
1880
        self.writefile = StringIO()
1739
1881
        self.writefile.close = lambda: None
 
1882
        self.close = lambda: None
1740
1883
 
1741
1884
    def makefile(self, mode='r', bufsize=None):
1742
1885
        if 'r' in mode:
1747
1890
 
1748
1891
class SmartHTTPTunnellingTest(tests.TestCaseWithTransport):
1749
1892
 
 
1893
    scenarios = multiply_scenarios(
 
1894
        vary_by_http_client_implementation(),
 
1895
        vary_by_http_protocol_version(),
 
1896
        )
 
1897
 
1750
1898
    def setUp(self):
1751
1899
        super(SmartHTTPTunnellingTest, self).setUp()
1752
1900
        # We use the VFS layer as part of HTTP tunnelling tests.
1753
 
        self._captureVar('BZR_NO_SMART_VFS', None)
 
1901
        self.overrideEnv('BZR_NO_SMART_VFS', None)
1754
1902
        self.transport_readonly_server = http_utils.HTTPServerWithSmarts
 
1903
        self.http_server = self.get_readonly_server()
1755
1904
 
1756
1905
    def create_transport_readonly_server(self):
1757
 
        return http_utils.HTTPServerWithSmarts(
 
1906
        server = http_utils.HTTPServerWithSmarts(
1758
1907
            protocol_version=self._protocol_version)
 
1908
        server._url_protocol = self._url_protocol
 
1909
        return server
1759
1910
 
1760
 
    def test_open_bzrdir(self):
 
1911
    def test_open_controldir(self):
1761
1912
        branch = self.make_branch('relpath')
1762
 
        http_server = self.get_readonly_server()
1763
 
        url = http_server.get_url() + 'relpath'
1764
 
        bd = bzrdir.BzrDir.open(url)
 
1913
        url = self.http_server.get_url() + 'relpath'
 
1914
        bd = controldir.ControlDir.open(url)
 
1915
        self.addCleanup(bd.transport.disconnect)
1765
1916
        self.assertIsInstance(bd, _mod_remote.RemoteBzrDir)
1766
1917
 
1767
1918
    def test_bulk_data(self):
1769
1920
        # The 'readv' command in the smart protocol both sends and receives
1770
1921
        # bulk data, so we use that.
1771
1922
        self.build_tree(['data-file'])
1772
 
        http_server = self.get_readonly_server()
1773
 
        http_transport = self._transport(http_server.get_url())
 
1923
        http_transport = transport.get_transport_from_url(
 
1924
            self.http_server.get_url())
1774
1925
        medium = http_transport.get_smart_medium()
1775
1926
        # Since we provide the medium, the url below will be mostly ignored
1776
1927
        # during the test, as long as the path is '/'.
1784
1935
        post_body = 'hello\n'
1785
1936
        expected_reply_body = 'ok\x012\n'
1786
1937
 
1787
 
        http_server = self.get_readonly_server()
1788
 
        http_transport = self._transport(http_server.get_url())
 
1938
        http_transport = transport.get_transport_from_url(
 
1939
            self.http_server.get_url())
1789
1940
        medium = http_transport.get_smart_medium()
1790
1941
        response = medium.send_http_smart_request(post_body)
1791
1942
        reply_body = response.read()
1792
1943
        self.assertEqual(expected_reply_body, reply_body)
1793
1944
 
1794
1945
    def test_smart_http_server_post_request_handler(self):
1795
 
        httpd = self.get_readonly_server()._get_httpd()
 
1946
        httpd = self.http_server.server
1796
1947
 
1797
1948
        socket = SampleSocket(
1798
1949
            'POST /.bzr/smart %s \r\n' % self._protocol_version
1830
1981
 
1831
1982
    def test_probe_smart_server(self):
1832
1983
        """Test error handling against server refusing smart requests."""
1833
 
        server = self.get_readonly_server()
1834
 
        t = self._transport(server.get_url())
 
1984
        t = self.get_readonly_transport()
1835
1985
        # No need to build a valid smart request here, the server will not even
1836
1986
        # try to interpret it.
1837
1987
        self.assertRaises(errors.SmartProtocolError,
1838
1988
                          t.get_smart_medium().send_http_smart_request,
1839
1989
                          'whatever')
1840
1990
 
 
1991
 
1841
1992
class Test_redirected_to(tests.TestCase):
1842
1993
 
 
1994
    scenarios = vary_by_http_client_implementation()
 
1995
 
1843
1996
    def test_redirected_to_subdir(self):
1844
1997
        t = self._transport('http://www.example.com/foo')
1845
1998
        r = t._redirected_to('http://www.example.com/foo',
1847
2000
        self.assertIsInstance(r, type(t))
1848
2001
        # Both transports share the some connection
1849
2002
        self.assertEqual(t._get_connection(), r._get_connection())
 
2003
        self.assertEqual('http://www.example.com/foo/subdir/', r.base)
1850
2004
 
1851
2005
    def test_redirected_to_self_with_slash(self):
1852
2006
        t = self._transport('http://www.example.com/foo')
1863
2017
        r = t._redirected_to('http://www.example.com/foo',
1864
2018
                             'http://foo.example.com/foo/subdir')
1865
2019
        self.assertIsInstance(r, type(t))
 
2020
        self.assertEqual('http://foo.example.com/foo/subdir/',
 
2021
            r.external_url())
1866
2022
 
1867
2023
    def test_redirected_to_same_host_sibling_protocol(self):
1868
2024
        t = self._transport('http://www.example.com/foo')
1869
2025
        r = t._redirected_to('http://www.example.com/foo',
1870
2026
                             'https://www.example.com/foo')
1871
2027
        self.assertIsInstance(r, type(t))
 
2028
        self.assertEqual('https://www.example.com/foo/',
 
2029
            r.external_url())
1872
2030
 
1873
2031
    def test_redirected_to_same_host_different_protocol(self):
1874
2032
        t = self._transport('http://www.example.com/foo')
1875
2033
        r = t._redirected_to('http://www.example.com/foo',
1876
2034
                             'ftp://www.example.com/foo')
1877
 
        self.assertNotEquals(type(r), type(t))
 
2035
        self.assertNotEqual(type(r), type(t))
 
2036
        self.assertEqual('ftp://www.example.com/foo/', r.external_url())
 
2037
 
 
2038
    def test_redirected_to_same_host_specific_implementation(self):
 
2039
        t = self._transport('http://www.example.com/foo')
 
2040
        r = t._redirected_to('http://www.example.com/foo',
 
2041
                             'https+urllib://www.example.com/foo')
 
2042
        self.assertEqual('https://www.example.com/foo/', r.external_url())
1878
2043
 
1879
2044
    def test_redirected_to_different_host_same_user(self):
1880
2045
        t = self._transport('http://joe@www.example.com/foo')
1881
2046
        r = t._redirected_to('http://www.example.com/foo',
1882
2047
                             'https://foo.example.com/foo')
1883
2048
        self.assertIsInstance(r, type(t))
1884
 
        self.assertEqual(t._user, r._user)
 
2049
        self.assertEqual(t._parsed_url.user, r._parsed_url.user)
 
2050
        self.assertEqual('https://joe@foo.example.com/foo/', r.external_url())
1885
2051
 
1886
2052
 
1887
2053
class PredefinedRequestHandler(http_server.TestingHTTPRequestHandler):
1896
2062
    line.
1897
2063
    """
1898
2064
 
1899
 
    def handle_one_request(self):
 
2065
    def _handle_one_request(self):
1900
2066
        tcs = self.server.test_case_server
1901
2067
        requestline = self.rfile.readline()
1902
2068
        headers = self.MessageClass(self.rfile, 0)
1940
2106
    pass
1941
2107
 
1942
2108
 
1943
 
if tests.HTTPSServerFeature.available():
 
2109
if features.HTTPSServerFeature.available():
1944
2110
    from bzrlib.tests import https_server
1945
2111
    class ActivityHTTPSServer(ActivityServerMixin, https_server.HTTPSServer):
1946
2112
        pass
1954
2120
    """
1955
2121
 
1956
2122
    def setUp(self):
1957
 
        tests.TestCase.setUp(self)
1958
2123
        self.server = self._activity_server(self._protocol_version)
1959
2124
        self.server.start_server()
1960
 
        self.activities = {}
 
2125
        self.addCleanup(self.server.stop_server)
 
2126
        _activities = {} # Don't close over self and create a cycle
1961
2127
        def report_activity(t, bytes, direction):
1962
 
            count = self.activities.get(direction, 0)
 
2128
            count = _activities.get(direction, 0)
1963
2129
            count += bytes
1964
 
            self.activities[direction] = count
1965
 
 
 
2130
            _activities[direction] = count
 
2131
        self.activities = _activities
1966
2132
        # We override at class level because constructors may propagate the
1967
2133
        # bound method and render instance overriding ineffective (an
1968
2134
        # alternative would be to define a specific ui factory instead...)
1969
 
        self.orig_report_activity = self._transport._report_activity
1970
 
        self._transport._report_activity = report_activity
1971
 
 
1972
 
    def tearDown(self):
1973
 
        self._transport._report_activity = self.orig_report_activity
1974
 
        self.server.stop_server()
1975
 
        tests.TestCase.tearDown(self)
 
2135
        self.overrideAttr(self._transport, '_report_activity', report_activity)
1976
2136
 
1977
2137
    def get_transport(self):
1978
 
        return self._transport(self.server.get_url())
 
2138
        t = self._transport(self.server.get_url())
 
2139
        # FIXME: Needs cleanup -- vila 20100611
 
2140
        return t
1979
2141
 
1980
2142
    def assertActivitiesMatch(self):
1981
2143
        self.assertEqual(self.server.bytes_read,
2086
2248
'''
2087
2249
        t = self.get_transport()
2088
2250
        # We must send a single line of body bytes, see
2089
 
        # PredefinedRequestHandler.handle_one_request
 
2251
        # PredefinedRequestHandler._handle_one_request
2090
2252
        code, f = t._post('abc def end-of-body\n')
2091
2253
        self.assertEqual('lalala whatever as long as itsssss\n', f.read())
2092
2254
        self.assertActivitiesMatch()
2094
2256
 
2095
2257
class TestActivity(tests.TestCase, TestActivityMixin):
2096
2258
 
 
2259
    scenarios = multiply_scenarios(
 
2260
        vary_by_http_activity(),
 
2261
        vary_by_http_protocol_version(),
 
2262
        )
 
2263
 
2097
2264
    def setUp(self):
2098
 
        tests.TestCase.setUp(self)
2099
 
        self.server = self._activity_server(self._protocol_version)
2100
 
        self.server.start_server()
2101
 
        self.activities = {}
2102
 
        def report_activity(t, bytes, direction):
2103
 
            count = self.activities.get(direction, 0)
2104
 
            count += bytes
2105
 
            self.activities[direction] = count
2106
 
 
2107
 
        # We override at class level because constructors may propagate the
2108
 
        # bound method and render instance overriding ineffective (an
2109
 
        # alternative would be to define a specific ui factory instead...)
2110
 
        self.orig_report_activity = self._transport._report_activity
2111
 
        self._transport._report_activity = report_activity
2112
 
 
2113
 
    def tearDown(self):
2114
 
        self._transport._report_activity = self.orig_report_activity
2115
 
        self.server.stop_server()
2116
 
        tests.TestCase.tearDown(self)
 
2265
        super(TestActivity, self).setUp()
 
2266
        TestActivityMixin.setUp(self)
2117
2267
 
2118
2268
 
2119
2269
class TestNoReportActivity(tests.TestCase, TestActivityMixin):
2120
2270
 
 
2271
    # Unlike TestActivity, we are really testing ReportingFileSocket and
 
2272
    # ReportingSocket, so we don't need all the parametrization. Since
 
2273
    # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
 
2274
    # test them through their use by the transport than directly (that's a
 
2275
    # bit less clean but far more simpler and effective).
 
2276
    _activity_server = ActivityHTTPServer
 
2277
    _protocol_version = 'HTTP/1.1'
 
2278
 
2121
2279
    def setUp(self):
2122
 
        tests.TestCase.setUp(self)
2123
 
        # Unlike TestActivity, we are really testing ReportingFileSocket and
2124
 
        # ReportingSocket, so we don't need all the parametrization. Since
2125
 
        # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
2126
 
        # test them through their use by the transport than directly (that's a
2127
 
        # bit less clean but far more simpler and effective).
2128
 
        self.server = ActivityHTTPServer('HTTP/1.1')
2129
 
        self._transport=_urllib.HttpTransport_urllib
2130
 
 
2131
 
        self.server.start_server()
2132
 
 
2133
 
        # We override at class level because constructors may propagate the
2134
 
        # bound method and render instance overriding ineffective (an
2135
 
        # alternative would be to define a specific ui factory instead...)
2136
 
        self.orig_report_activity = self._transport._report_activity
2137
 
        self._transport._report_activity = None
2138
 
 
2139
 
    def tearDown(self):
2140
 
        self._transport._report_activity = self.orig_report_activity
2141
 
        self.server.stop_server()
2142
 
        tests.TestCase.tearDown(self)
 
2280
        super(TestNoReportActivity, self).setUp()
 
2281
        self._transport =_urllib.HttpTransport_urllib
 
2282
        TestActivityMixin.setUp(self)
2143
2283
 
2144
2284
    def assertActivitiesMatch(self):
2145
2285
        # Nothing to check here
2149
2289
class TestAuthOnRedirected(http_utils.TestCaseWithRedirectedWebserver):
2150
2290
    """Test authentication on the redirected http server."""
2151
2291
 
 
2292
    scenarios = vary_by_http_protocol_version()
 
2293
 
2152
2294
    _auth_header = 'Authorization'
2153
2295
    _password_prompt_prefix = ''
2154
2296
    _username_prompt_prefix = ''
2155
2297
    _auth_server = http_utils.HTTPBasicAuthServer
2156
2298
    _transport = _urllib.HttpTransport_urllib
2157
2299
 
2158
 
    def create_transport_readonly_server(self):
2159
 
        return self._auth_server()
2160
 
 
2161
 
    def create_transport_secondary_server(self):
2162
 
        """Create the secondary server redirecting to the primary server"""
2163
 
        new = self.get_readonly_server()
2164
 
 
2165
 
        redirecting = http_utils.HTTPServerRedirecting()
2166
 
        redirecting.redirect_to(new.host, new.port)
2167
 
        return redirecting
2168
 
 
2169
2300
    def setUp(self):
2170
2301
        super(TestAuthOnRedirected, self).setUp()
2171
2302
        self.build_tree_contents([('a','a'),
2176
2307
                                       self.new_server.port)
2177
2308
        self.old_server.redirections = [
2178
2309
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2179
 
        self.old_transport = self._transport(self.old_server.get_url())
 
2310
        self.old_transport = self.get_old_transport()
2180
2311
        self.new_server.add_user('joe', 'foo')
2181
 
 
2182
 
    def get_a(self, transport):
2183
 
        return transport.get('a')
 
2312
        cleanup_http_redirection_connections(self)
 
2313
 
 
2314
    def create_transport_readonly_server(self):
 
2315
        server = self._auth_server(protocol_version=self._protocol_version)
 
2316
        server._url_protocol = self._url_protocol
 
2317
        return server
 
2318
 
 
2319
    def get_a(self, t):
 
2320
        return t.get('a')
2184
2321
 
2185
2322
    def test_auth_on_redirected_via_do_catching_redirections(self):
2186
2323
        self.redirections = 0
2187
2324
 
2188
 
        def redirected(transport, exception, redirection_notice):
 
2325
        def redirected(t, exception, redirection_notice):
2189
2326
            self.redirections += 1
2190
 
            dir, file = urlutils.split(exception.target)
2191
 
            return self._transport(dir)
 
2327
            redirected_t = t._redirected_to(exception.source, exception.target)
 
2328
            self.addCleanup(redirected_t.disconnect)
 
2329
            return redirected_t
2192
2330
 
2193
2331
        stdout = tests.StringIOWrapper()
2194
2332
        stderr = tests.StringIOWrapper()
2215
2353
                                       self.new_server.port)
2216
2354
        self.old_server.redirections = [
2217
2355
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2218
 
        self.assertEqual('redirected once',t._perform(req).read())
 
2356
        self.assertEqual('redirected once', t._perform(req).read())
2219
2357
        # stdin should be empty
2220
2358
        self.assertEqual('', ui.ui_factory.stdin.readline())
2221
2359
        # stdout should be empty, stderr will contains the prompts
2222
2360
        self.assertEqual('', stdout.getvalue())
2223
2361
 
2224