← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_https_urllib.py

  • Committer: Vincent Ladeuil
  • Date: 2016-01-27 13:36:17 UTC
  • mto: This revision was merged to the branch mainline in revision 6614.
  • Revision ID: v.ladeuil+lp@free.fr-20160127133617-gteit32e0nu3938n
https://launchpad.net/bugs/1538480
Use ssl module for the match_hostname function

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_https_urllib.py
 
1
# Copyright (C) 2011, 2012, 2013, 2016 Canonical Ltd
 
2
#
 
3
# This program is free software; you can redistribute it and/or modify
 
4
# it under the terms of the GNU General Public License as published by
 
5
# the Free Software Foundation; either version 2 of the License, or
 
6
# (at your option) any later version.
 
7
#
 
8
# This program is distributed in the hope that it will be useful,
 
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
 
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 
11
# GNU General Public License for more details.
 
12
#
 
13
# You should have received a copy of the GNU General Public License
 
14
# along with this program; if not, write to the Free Software
 
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
16
 
 
17
"""Tests for the SSL support in the urllib HTTP transport.
 
18
 
 
19
"""
 
20
 
 
21
import os
 
22
import ssl
 
23
 
 
24
from bzrlib import (
 
25
    config,
 
26
    trace,
 
27
)
 
28
from bzrlib.errors import (
 
29
    ConfigOptionValueError,
 
30
)
 
31
from bzrlib.tests import (
 
32
    TestCase,
 
33
    TestCaseInTempDir,
 
34
)
 
35
from bzrlib.transport.http import _urllib2_wrappers
 
36
 
 
37
 
 
38
class CaCertsConfigTests(TestCaseInTempDir):
 
39
 
 
40
    def get_stack(self, content):
 
41
        return config.MemoryStack(content.encode('utf-8'))
 
42
 
 
43
    def test_default_exists(self):
 
44
        """Check that the default we provide exists for the tested platform."""
 
45
        stack = self.get_stack("")
 
46
        self.assertPathExists(stack.get('ssl.ca_certs'))
 
47
 
 
48
    def test_specified(self):
 
49
        self.build_tree(['cacerts.pem'])
 
50
        path = os.path.join(self.test_dir, "cacerts.pem")
 
51
        stack = self.get_stack("ssl.ca_certs = %s\n" % path)
 
52
        self.assertEquals(path, stack.get('ssl.ca_certs'))
 
53
 
 
54
    def test_specified_doesnt_exist(self):
 
55
        stack = self.get_stack('')
 
56
        # Disable the default value mechanism to force the behavior we want
 
57
        self.overrideAttr(_urllib2_wrappers.opt_ssl_ca_certs, 'default',
 
58
                          os.path.join(self.test_dir, u"nonexisting.pem"))
 
59
        self.warnings = []
 
60
 
 
61
        def warning(*args):
 
62
            self.warnings.append(args[0] % args[1:])
 
63
        self.overrideAttr(trace, 'warning', warning)
 
64
        self.assertEquals(None, stack.get('ssl.ca_certs'))
 
65
        self.assertLength(1, self.warnings)
 
66
        self.assertContainsRe(self.warnings[0],
 
67
                              "is not valid for \"ssl.ca_certs\"")
 
68
 
 
69
 
 
70
class CertReqsConfigTests(TestCaseInTempDir):
 
71
 
 
72
    def test_default(self):
 
73
        stack = config.MemoryStack("")
 
74
        self.assertEquals(ssl.CERT_REQUIRED, stack.get("ssl.cert_reqs"))
 
75
 
 
76
    def test_from_string(self):
 
77
        stack = config.MemoryStack("ssl.cert_reqs = none\n")
 
78
        self.assertEquals(ssl.CERT_NONE, stack.get("ssl.cert_reqs"))
 
79
        stack = config.MemoryStack("ssl.cert_reqs = required\n")
 
80
        self.assertEquals(ssl.CERT_REQUIRED, stack.get("ssl.cert_reqs"))
 
81
        stack = config.MemoryStack("ssl.cert_reqs = invalid\n")
 
82
        self.assertRaises(ConfigOptionValueError, stack.get, "ssl.cert_reqs")
 
83
 
 
84
 
 
85
class MatchHostnameTests(TestCase):
 
86
 
 
87
    def test_no_certificate(self):
 
88
        self.assertRaises(ValueError,
 
89
                          ssl.match_hostname, {}, "example.com")
 
90
 
 
91
    def test_wildcards_in_cert(self):
 
92
        def ok(cert, hostname):
 
93
            ssl.match_hostname(cert, hostname)
 
94
 
 
95
        def not_ok(cert, hostname):
 
96
            self.assertRaises(
 
97
                ssl.CertificateError,
 
98
                ssl.match_hostname, cert, hostname)
 
99
 
 
100
        # Python Issue #17980: avoid denials of service by refusing more than
 
101
        # one wildcard per fragment.
 
102
        ok({'subject': ((('commonName', 'a*b.com'),),)}, 'axxb.com')
 
103
        not_ok({'subject': ((('commonName', 'a*b.co*'),),)}, 'axxb.com')
 
104
        not_ok({'subject': ((('commonName', 'a*b*.com'),),)}, 'axxbxxc.com')
 
105
 
 
106
    def test_no_valid_attributes(self):
 
107
        self.assertRaises(ssl.CertificateError, ssl.match_hostname,
 
108
                          {"Problem": "Solved"}, "example.com")
 
109
 
 
110
    def test_common_name(self):
 
111
        cert = {'subject': ((('commonName', 'example.com'),),)}
 
112
        self.assertIs(None,
 
113
                      ssl.match_hostname(cert, "example.com"))
 
114
        self.assertRaises(ssl.CertificateError, ssl.match_hostname,
 
115
                          cert, "example.org")