← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_symbol_versioning.py

(vila) Revise legal option names to be less drastic. (Vincent Ladeuil)

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_symbol_versioning.py
1
 
# Copyright (C) 2006, 2007 Canonical Ltd
2
 
#   Authors: Robert Collins <robert.collins@canonical.com>
 
1
# Copyright (C) 2006-2011 Canonical Ltd
3
2
#
4
3
# This program is free software; you can redistribute it and/or modify
5
4
# it under the terms of the GNU General Public License as published by
13
12
#
14
13
# You should have received a copy of the GNU General Public License
15
14
# along with this program; if not, write to the Free Software
16
 
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
17
16
 
18
17
"""Symbol versioning tests."""
19
18
 
20
 
import bzrlib.symbol_versioning as symbol_versioning
 
19
import warnings
 
20
 
 
21
from bzrlib import symbol_versioning
 
22
from bzrlib.symbol_versioning import (
 
23
    deprecated_function,
 
24
    deprecated_in,
 
25
    deprecated_method,
 
26
    )
21
27
from bzrlib.tests import TestCase
22
28
 
23
29
 
24
 
@symbol_versioning.deprecated_function(symbol_versioning.zero_seven)
25
 
def deprecated_function():
 
30
@deprecated_function(deprecated_in((0, 7, 0)))
 
31
def sample_deprecated_function():
26
32
    """Deprecated function docstring."""
27
33
    return 1
28
34
 
29
35
 
30
 
a_deprecated_list = symbol_versioning.deprecated_list(symbol_versioning.zero_nine,
 
36
a_deprecated_list = symbol_versioning.deprecated_list(deprecated_in((0, 9, 0)),
31
37
    'a_deprecated_list', ['one'], extra="Don't use me")
32
38
 
33
39
 
34
40
a_deprecated_dict = symbol_versioning.DeprecatedDict(
35
 
    symbol_versioning.zero_fourteen,
 
41
    deprecated_in((0, 14, 0)),
36
42
    'a_deprecated_dict',
37
43
    dict(a=42),
38
44
    advice='Pull the other one!',
48
54
        super(TestDeprecationWarnings, self).setUp()
49
55
        self._warnings = []
50
56
    
51
 
    @symbol_versioning.deprecated_method(symbol_versioning.zero_seven)
 
57
    @deprecated_method(deprecated_in((0, 7, 0)))
52
58
    def deprecated_method(self):
53
59
        """Deprecated method docstring.
54
 
        
 
60
 
55
61
        This might explain stuff.
56
62
        """
57
63
        return 1
58
64
 
 
65
    @staticmethod
 
66
    @deprecated_function(deprecated_in((0, 7, 0)))
 
67
    def deprecated_static():
 
68
        """Deprecated static."""
 
69
        return 1
 
70
 
 
71
    def test_deprecated_static(self):
 
72
        # XXX: The results are not quite right because the class name is not
 
73
        # shown - however it is enough to give people a good indication of
 
74
        # where the problem is.
 
75
        expected_warning = (
 
76
            "bzrlib.tests.test_symbol_versioning."
 
77
            "deprecated_static "
 
78
            "was deprecated in version 0.7.0.", DeprecationWarning, 2)
 
79
        expected_docstring = (
 
80
            'Deprecated static.\n'
 
81
            '\n'
 
82
            'This function was deprecated in version 0.7.0.\n'
 
83
            )
 
84
        self.check_deprecated_callable(
 
85
            expected_warning, expected_docstring,
 
86
            "deprecated_static",
 
87
            "bzrlib.tests.test_symbol_versioning",
 
88
            self.deprecated_static)
 
89
 
59
90
    def test_deprecated_method(self):
60
91
        expected_warning = (
61
92
            "bzrlib.tests.test_symbol_versioning."
62
93
            "TestDeprecationWarnings.deprecated_method "
63
 
            "was deprecated in version 0.7.", DeprecationWarning, 2)
64
 
        expected_docstring = ('Deprecated method docstring.\n'
65
 
                              '        \n'
66
 
                              '        This might explain stuff.\n'
67
 
                              '        \n'
68
 
                              '        This method was deprecated in version 0.7.\n'
69
 
                              '        ')
 
94
            "was deprecated in version 0.7.0.", DeprecationWarning, 2)
 
95
        expected_docstring = (
 
96
            'Deprecated method docstring.\n'
 
97
            '\n'
 
98
            '        This might explain stuff.\n'
 
99
            '        \n'
 
100
            '        This method was deprecated in version 0.7.0.\n'
 
101
            '        ')
70
102
        self.check_deprecated_callable(expected_warning, expected_docstring,
71
103
                                       "deprecated_method",
72
104
                                       "bzrlib.tests.test_symbol_versioning",
74
106
 
75
107
    def test_deprecated_function(self):
76
108
        expected_warning = (
77
 
            "bzrlib.tests.test_symbol_versioning.deprecated_function "
78
 
            "was deprecated in version 0.7.", DeprecationWarning, 2)
 
109
            "bzrlib.tests.test_symbol_versioning.sample_deprecated_function "
 
110
            "was deprecated in version 0.7.0.", DeprecationWarning, 2)
79
111
        expected_docstring = ('Deprecated function docstring.\n'
80
112
                              '\n'
81
 
                              'This function was deprecated in version 0.7.\n'
 
113
                              'This function was deprecated in version 0.7.0.\n'
82
114
                              )
83
115
        self.check_deprecated_callable(expected_warning, expected_docstring,
84
 
                                       "deprecated_function",
 
116
                                       "sample_deprecated_function",
85
117
                                       "bzrlib.tests.test_symbol_versioning",
86
 
                                       deprecated_function)
 
118
                                       sample_deprecated_function)
87
119
 
88
120
    def test_deprecated_list(self):
89
121
        expected_warning = (
90
 
            "Modifying a_deprecated_list was deprecated in version 0.9."
 
122
            "Modifying a_deprecated_list was deprecated in version 0.9.0."
91
123
            " Don't use me", DeprecationWarning, 3)
92
124
        old_warning_method = symbol_versioning.warn
93
125
        try:
125
157
 
126
158
    def test_deprecated_dict(self):
127
159
        expected_warning = (
128
 
            "access to a_deprecated_dict was deprecated in version 0.14."
 
160
            "access to a_deprecated_dict was deprecated in version 0.14.0."
129
161
            " Pull the other one!", DeprecationWarning, 2)
130
162
        old_warning_method = symbol_versioning.warn
131
163
        try:
146
178
    def check_deprecated_callable(self, expected_warning, expected_docstring,
147
179
                                  expected_name, expected_module,
148
180
                                  deprecated_callable):
 
181
        if __doc__ is None:
 
182
            # With -OO the docstring should just be the deprecated version
 
183
            expected_docstring = expected_docstring.split('\n')[-2].lstrip()
149
184
        old_warning_method = symbol_versioning.warn
150
185
        try:
151
186
            symbol_versioning.set_warning_method(self.capture_warning)
160
195
            self.assertTrue(deprecated_callable.is_deprecated)
161
196
        finally:
162
197
            symbol_versioning.set_warning_method(old_warning_method)
163
 
    
 
198
 
164
199
    def test_deprecated_passed(self):
165
200
        self.assertEqual(True, symbol_versioning.deprecated_passed(None))
166
201
        self.assertEqual(True, symbol_versioning.deprecated_passed(True))
173
208
        """We can get a deprecation string for a method or function."""
174
209
        self.assertEqual('bzrlib.tests.test_symbol_versioning.'
175
210
            'TestDeprecationWarnings.test_deprecation_string was deprecated in '
176
 
            'version 0.11.',
 
211
            'version 0.11.0.',
177
212
            symbol_versioning.deprecation_string(
178
 
            self.test_deprecation_string, symbol_versioning.zero_eleven))
 
213
            self.test_deprecation_string,
 
214
            deprecated_in((0, 11, 0))))
179
215
        self.assertEqual('bzrlib.symbol_versioning.deprecated_function was '
180
 
            'deprecated in version 0.11.',
 
216
            'deprecated in version 0.11.0.',
181
217
            symbol_versioning.deprecation_string(
182
218
                symbol_versioning.deprecated_function,
183
 
                symbol_versioning.zero_eleven))
 
219
                deprecated_in((0, 11, 0))))
 
220
 
 
221
 
 
222
class TestSuppressAndActivate(TestCase):
 
223
 
 
224
    def setUp(self):
 
225
        super(TestSuppressAndActivate, self).setUp()
 
226
        existing_filters = list(warnings.filters)
 
227
        def restore():
 
228
            warnings.filters[:] = existing_filters
 
229
        self.addCleanup(restore)
 
230
        # Clean out the filters so we have a clean slate.
 
231
        warnings.resetwarnings()
 
232
 
 
233
    def assertFirstWarning(self, action, category):
 
234
        """Test the first warning in the filters is correct"""
 
235
        first = warnings.filters[0]
 
236
        self.assertEqual((action, category), (first[0], first[2]))
 
237
 
 
238
    def test_suppress_deprecation_warnings(self):
 
239
        """suppress_deprecation_warnings sets DeprecationWarning to ignored."""
 
240
        symbol_versioning.suppress_deprecation_warnings()
 
241
        self.assertFirstWarning('ignore', DeprecationWarning)
 
242
 
 
243
    def test_set_restore_filters(self):
 
244
        original_filters = warnings.filters[:]
 
245
        symbol_versioning.suppress_deprecation_warnings()()
 
246
        self.assertEqual(original_filters, warnings.filters)
 
247
 
 
248
    def test_suppress_deprecation_with_warning_filter(self):
 
249
        """don't suppress if we already have a filter"""
 
250
        warnings.filterwarnings('error', category=Warning)
 
251
        self.assertFirstWarning('error', Warning)
 
252
        self.assertEqual(1, len(warnings.filters))
 
253
        symbol_versioning.suppress_deprecation_warnings(override=False)
 
254
        self.assertFirstWarning('error', Warning)
 
255
        self.assertEqual(1, len(warnings.filters))
 
256
 
 
257
    def test_suppress_deprecation_with_filter(self):
 
258
        """don't suppress if we already have a filter"""
 
259
        warnings.filterwarnings('error', category=DeprecationWarning)
 
260
        self.assertFirstWarning('error', DeprecationWarning)
 
261
        self.assertEqual(1, len(warnings.filters))
 
262
        symbol_versioning.suppress_deprecation_warnings(override=False)
 
263
        self.assertFirstWarning('error', DeprecationWarning)
 
264
        self.assertEqual(1, len(warnings.filters))
 
265
        symbol_versioning.suppress_deprecation_warnings(override=True)
 
266
        self.assertFirstWarning('ignore', DeprecationWarning)
 
267
        self.assertEqual(2, len(warnings.filters))
 
268
 
 
269
    def test_activate_deprecation_no_error(self):
 
270
        # First nuke the filters, so we know it is clean
 
271
        symbol_versioning.activate_deprecation_warnings()
 
272
        self.assertFirstWarning('default', DeprecationWarning)
 
273
 
 
274
    def test_activate_deprecation_with_error(self):
 
275
        # First nuke the filters, so we know it is clean
 
276
        # Add a warning == error rule
 
277
        warnings.filterwarnings('error', category=Warning)
 
278
        self.assertFirstWarning('error', Warning)
 
279
        self.assertEqual(1, len(warnings.filters))
 
280
        symbol_versioning.activate_deprecation_warnings(override=False)
 
281
        # There should not be a new warning
 
282
        self.assertFirstWarning('error', Warning)
 
283
        self.assertEqual(1, len(warnings.filters))
 
284
 
 
285
    def test_activate_deprecation_with_DW_error(self):
 
286
        # First nuke the filters, so we know it is clean
 
287
        # Add a warning == error rule
 
288
        warnings.filterwarnings('error', category=DeprecationWarning)
 
289
        self.assertFirstWarning('error', DeprecationWarning)
 
290
        self.assertEqual(1, len(warnings.filters))
 
291
        symbol_versioning.activate_deprecation_warnings(override=False)
 
292
        # There should not be a new warning
 
293
        self.assertFirstWarning('error', DeprecationWarning)
 
294
        self.assertEqual(1, len(warnings.filters))
 
295
        symbol_versioning.activate_deprecation_warnings(override=True)
 
296
        self.assertFirstWarning('default', DeprecationWarning)
 
297
        self.assertEqual(2, len(warnings.filters))