~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_config.py

  • Committer: Patch Queue Manager
  • Date: 2016-01-15 09:21:49 UTC
  • mfrom: (6606.2.1 autodoc-unicode)
  • Revision ID: pqm@pqm.ubuntu.com-20160115092149-z5f4sfq3jvaz0enb
(vila) Fix autodoc runner when LANG=C. (Jelmer Vernooij)

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2014, 2016 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
17
"""Tests for finding and reading the bzr config file[s]."""
18
 
# import system imports here
 
18
 
19
19
from cStringIO import StringIO
 
20
from textwrap import dedent
20
21
import os
21
22
import sys
22
23
import threading
23
24
 
24
 
#import bzrlib specific imports here
 
25
from testtools import matchers
 
26
 
25
27
from bzrlib import (
26
28
    branch,
27
 
    bzrdir,
28
29
    config,
 
30
    controldir,
29
31
    diff,
30
32
    errors,
31
33
    osutils,
32
34
    mail_client,
33
35
    ui,
34
36
    urlutils,
 
37
    registry as _mod_registry,
 
38
    remote,
35
39
    tests,
36
40
    trace,
37
 
    transport,
38
 
    )
39
 
from bzrlib.tests import features
 
41
    )
 
42
from bzrlib.symbol_versioning import (
 
43
    deprecated_in,
 
44
    )
 
45
from bzrlib.transport import remote as transport_remote
 
46
from bzrlib.tests import (
 
47
    features,
 
48
    scenarios,
 
49
    test_server,
 
50
    )
40
51
from bzrlib.util.configobj import configobj
41
52
 
42
53
 
52
63
          'config_section': '.'}),]
53
64
 
54
65
 
55
 
def load_tests(standard_tests, module, loader):
56
 
    suite = loader.suiteClass()
57
 
 
58
 
    lc_tests, remaining_tests = tests.split_suite_by_condition(
59
 
        standard_tests, tests.condition_isinstance((
60
 
                TestLockableConfig,
61
 
                )))
62
 
    tests.multiply_tests(lc_tests, lockable_config_scenarios(), suite)
63
 
    suite.addTest(remaining_tests)
64
 
    return suite
 
66
load_tests = scenarios.load_tests_apply_scenarios
 
67
 
 
68
# Register helpers to build stores
 
69
config.test_store_builder_registry.register(
 
70
    'configobj', lambda test: config.TransportIniFileStore(
 
71
        test.get_transport(), 'configobj.conf'))
 
72
config.test_store_builder_registry.register(
 
73
    'bazaar', lambda test: config.GlobalStore())
 
74
config.test_store_builder_registry.register(
 
75
    'location', lambda test: config.LocationStore())
 
76
 
 
77
 
 
78
def build_backing_branch(test, relpath,
 
79
                         transport_class=None, server_class=None):
 
80
    """Test helper to create a backing branch only once.
 
81
 
 
82
    Some tests needs multiple stores/stacks to check concurrent update
 
83
    behaviours. As such, they need to build different branch *objects* even if
 
84
    they share the branch on disk.
 
85
 
 
86
    :param relpath: The relative path to the branch. (Note that the helper
 
87
        should always specify the same relpath).
 
88
 
 
89
    :param transport_class: The Transport class the test needs to use.
 
90
 
 
91
    :param server_class: The server associated with the ``transport_class``
 
92
        above.
 
93
 
 
94
    Either both or neither of ``transport_class`` and ``server_class`` should
 
95
    be specified.
 
96
    """
 
97
    if transport_class is not None and server_class is not None:
 
98
        test.transport_class = transport_class
 
99
        test.transport_server = server_class
 
100
    elif not (transport_class is None and server_class is None):
 
101
        raise AssertionError('Specify both ``transport_class`` and '
 
102
                             '``server_class`` or neither of them')
 
103
    if getattr(test, 'backing_branch', None) is None:
 
104
        # First call, let's build the branch on disk
 
105
        test.backing_branch = test.make_branch(relpath)
 
106
 
 
107
 
 
108
def build_branch_store(test):
 
109
    build_backing_branch(test, 'branch')
 
110
    b = branch.Branch.open('branch')
 
111
    return config.BranchStore(b)
 
112
config.test_store_builder_registry.register('branch', build_branch_store)
 
113
 
 
114
 
 
115
def build_control_store(test):
 
116
    build_backing_branch(test, 'branch')
 
117
    b = controldir.ControlDir.open('branch')
 
118
    return config.ControlStore(b)
 
119
config.test_store_builder_registry.register('control', build_control_store)
 
120
 
 
121
 
 
122
def build_remote_branch_store(test):
 
123
    # There is only one permutation (but we won't be able to handle more with
 
124
    # this design anyway)
 
125
    (transport_class,
 
126
     server_class) = transport_remote.get_test_permutations()[0]
 
127
    build_backing_branch(test, 'branch', transport_class, server_class)
 
128
    b = branch.Branch.open(test.get_url('branch'))
 
129
    return config.BranchStore(b)
 
130
config.test_store_builder_registry.register('remote_branch',
 
131
                                            build_remote_branch_store)
 
132
 
 
133
 
 
134
config.test_stack_builder_registry.register(
 
135
    'bazaar', lambda test: config.GlobalStack())
 
136
config.test_stack_builder_registry.register(
 
137
    'location', lambda test: config.LocationStack('.'))
 
138
 
 
139
 
 
140
def build_branch_stack(test):
 
141
    build_backing_branch(test, 'branch')
 
142
    b = branch.Branch.open('branch')
 
143
    return config.BranchStack(b)
 
144
config.test_stack_builder_registry.register('branch', build_branch_stack)
 
145
 
 
146
 
 
147
def build_branch_only_stack(test):
 
148
    # There is only one permutation (but we won't be able to handle more with
 
149
    # this design anyway)
 
150
    (transport_class,
 
151
     server_class) = transport_remote.get_test_permutations()[0]
 
152
    build_backing_branch(test, 'branch', transport_class, server_class)
 
153
    b = branch.Branch.open(test.get_url('branch'))
 
154
    return config.BranchOnlyStack(b)
 
155
config.test_stack_builder_registry.register('branch_only',
 
156
                                            build_branch_only_stack)
 
157
 
 
158
def build_remote_control_stack(test):
 
159
    # There is only one permutation (but we won't be able to handle more with
 
160
    # this design anyway)
 
161
    (transport_class,
 
162
     server_class) = transport_remote.get_test_permutations()[0]
 
163
    # We need only a bzrdir for this, not a full branch, but it's not worth
 
164
    # creating a dedicated helper to create only the bzrdir
 
165
    build_backing_branch(test, 'branch', transport_class, server_class)
 
166
    b = branch.Branch.open(test.get_url('branch'))
 
167
    return config.RemoteControlStack(b.bzrdir)
 
168
config.test_stack_builder_registry.register('remote_control',
 
169
                                            build_remote_control_stack)
65
170
 
66
171
 
67
172
sample_long_alias="log -r-15..-1 --line"
71
176
editor=vim
72
177
change_editor=vimdiff -of @new_path @old_path
73
178
gpg_signing_command=gnome-gpg
 
179
gpg_signing_key=DD4D5088
74
180
log_format=short
 
181
validate_signatures_in_log=true
 
182
acceptable_keys=amy
75
183
user_global_option=something
 
184
bzr.mergetool.sometool=sometool {base} {this} {other} -o {result}
 
185
bzr.mergetool.funkytool=funkytool "arg with spaces" {this_temp}
 
186
bzr.mergetool.newtool='"newtool with spaces" {this_temp}'
 
187
bzr.default_mergetool=sometool
76
188
[ALIASES]
77
189
h=help
78
190
ll=""" + sample_long_alias + "\n"
120
232
[/a/]
121
233
check_signatures=check-available
122
234
gpg_signing_command=false
 
235
gpg_signing_key=default
123
236
user_local_option=local
124
237
# test trailing / matching
125
238
[/a/*]
131
244
"""
132
245
 
133
246
 
 
247
def create_configs(test):
 
248
    """Create configuration files for a given test.
 
249
 
 
250
    This requires creating a tree (and populate the ``test.tree`` attribute)
 
251
    and its associated branch and will populate the following attributes:
 
252
 
 
253
    - branch_config: A BranchConfig for the associated branch.
 
254
 
 
255
    - locations_config : A LocationConfig for the associated branch
 
256
 
 
257
    - bazaar_config: A GlobalConfig.
 
258
 
 
259
    The tree and branch are created in a 'tree' subdirectory so the tests can
 
260
    still use the test directory to stay outside of the branch.
 
261
    """
 
262
    tree = test.make_branch_and_tree('tree')
 
263
    test.tree = tree
 
264
    test.branch_config = config.BranchConfig(tree.branch)
 
265
    test.locations_config = config.LocationConfig(tree.basedir)
 
266
    test.bazaar_config = config.GlobalConfig()
 
267
 
 
268
 
 
269
def create_configs_with_file_option(test):
 
270
    """Create configuration files with a ``file`` option set in each.
 
271
 
 
272
    This builds on ``create_configs`` and add one ``file`` option in each
 
273
    configuration with a value which allows identifying the configuration file.
 
274
    """
 
275
    create_configs(test)
 
276
    test.bazaar_config.set_user_option('file', 'bazaar')
 
277
    test.locations_config.set_user_option('file', 'locations')
 
278
    test.branch_config.set_user_option('file', 'branch')
 
279
 
 
280
 
 
281
class TestOptionsMixin:
 
282
 
 
283
    def assertOptions(self, expected, conf):
 
284
        # We don't care about the parser (as it will make tests hard to write
 
285
        # and error-prone anyway)
 
286
        self.assertThat([opt[:4] for opt in conf._get_options()],
 
287
                        matchers.Equals(expected))
 
288
 
 
289
 
134
290
class InstrumentedConfigObj(object):
135
291
    """A config obj look-enough-alike to record calls made to it."""
136
292
 
172
328
 
173
329
class FakeBranch(object):
174
330
 
175
 
    def __init__(self, base=None, user_id=None):
 
331
    def __init__(self, base=None):
176
332
        if base is None:
177
333
            self.base = "http://example.com/branches/demo"
178
334
        else:
179
335
            self.base = base
180
336
        self._transport = self.control_files = \
181
 
            FakeControlFilesAndTransport(user_id=user_id)
 
337
            FakeControlFilesAndTransport()
182
338
 
183
339
    def _get_config(self):
184
340
        return config.TransportConfig(self._transport, 'branch.conf')
192
348
 
193
349
class FakeControlFilesAndTransport(object):
194
350
 
195
 
    def __init__(self, user_id=None):
 
351
    def __init__(self):
196
352
        self.files = {}
197
 
        if user_id:
198
 
            self.files['email'] = user_id
199
353
        self._transport = self
200
354
 
201
 
    def get_utf8(self, filename):
202
 
        # from LockableFiles
203
 
        raise AssertionError("get_utf8 should no longer be used")
204
 
 
205
355
    def get(self, filename):
206
356
        # from Transport
207
357
        try:
269
419
        """
270
420
        co = config.ConfigObj()
271
421
        co['test'] = 'foo#bar'
272
 
        lines = co.write()
 
422
        outfile = StringIO()
 
423
        co.write(outfile=outfile)
 
424
        lines = outfile.getvalue().splitlines()
273
425
        self.assertEqual(lines, ['test = "foo#bar"'])
274
426
        co2 = config.ConfigObj(lines)
275
427
        self.assertEqual(co2['test'], 'foo#bar')
276
428
 
 
429
    def test_triple_quotes(self):
 
430
        # Bug #710410: if the value string has triple quotes
 
431
        # then ConfigObj versions up to 4.7.2 will quote them wrong
 
432
        # and won't able to read them back
 
433
        triple_quotes_value = '''spam
 
434
""" that's my spam """
 
435
eggs'''
 
436
        co = config.ConfigObj()
 
437
        co['test'] = triple_quotes_value
 
438
        # While writing this test another bug in ConfigObj has been found:
 
439
        # method co.write() without arguments produces list of lines
 
440
        # one option per line, and multiline values are not split
 
441
        # across multiple lines,
 
442
        # and that breaks the parsing these lines back by ConfigObj.
 
443
        # This issue only affects test, but it's better to avoid
 
444
        # `co.write()` construct at all.
 
445
        # [bialix 20110222] bug report sent to ConfigObj's author
 
446
        outfile = StringIO()
 
447
        co.write(outfile=outfile)
 
448
        output = outfile.getvalue()
 
449
        # now we're trying to read it back
 
450
        co2 = config.ConfigObj(StringIO(output))
 
451
        self.assertEquals(triple_quotes_value, co2['test'])
 
452
 
277
453
 
278
454
erroneous_config = """[section] # line 1
279
455
good=good # line 2
299
475
    def test_constructs(self):
300
476
        config.Config()
301
477
 
302
 
    def test_no_default_editor(self):
303
 
        self.assertRaises(NotImplementedError, config.Config().get_editor)
304
 
 
305
478
    def test_user_email(self):
306
479
        my_config = InstrumentedConfig()
307
480
        self.assertEqual('robert.collins@example.org', my_config.user_email())
315
488
 
316
489
    def test_signatures_default(self):
317
490
        my_config = config.Config()
318
 
        self.assertFalse(my_config.signature_needed())
 
491
        self.assertFalse(
 
492
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
493
                my_config.signature_needed))
319
494
        self.assertEqual(config.CHECK_IF_POSSIBLE,
320
 
                         my_config.signature_checking())
 
495
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
496
                my_config.signature_checking))
321
497
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
322
 
                         my_config.signing_policy())
 
498
                self.applyDeprecated(deprecated_in((2, 5, 0)),
 
499
                    my_config.signing_policy))
323
500
 
324
501
    def test_signatures_template_method(self):
325
502
        my_config = InstrumentedConfig()
326
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
 
503
        self.assertEqual(config.CHECK_NEVER,
 
504
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
505
                my_config.signature_checking))
327
506
        self.assertEqual(['_get_signature_checking'], my_config._calls)
328
507
 
329
508
    def test_signatures_template_method_none(self):
330
509
        my_config = InstrumentedConfig()
331
510
        my_config._signatures = None
332
511
        self.assertEqual(config.CHECK_IF_POSSIBLE,
333
 
                         my_config.signature_checking())
 
512
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
513
                             my_config.signature_checking))
334
514
        self.assertEqual(['_get_signature_checking'], my_config._calls)
335
515
 
336
516
    def test_gpg_signing_command_default(self):
337
517
        my_config = config.Config()
338
 
        self.assertEqual('gpg', my_config.gpg_signing_command())
 
518
        self.assertEqual('gpg',
 
519
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
520
                my_config.gpg_signing_command))
339
521
 
340
522
    def test_get_user_option_default(self):
341
523
        my_config = config.Config()
343
525
 
344
526
    def test_post_commit_default(self):
345
527
        my_config = config.Config()
346
 
        self.assertEqual(None, my_config.post_commit())
 
528
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
529
                                                    my_config.post_commit))
 
530
 
347
531
 
348
532
    def test_log_format_default(self):
349
533
        my_config = config.Config()
350
 
        self.assertEqual('long', my_config.log_format())
 
534
        self.assertEqual('long',
 
535
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
536
                                              my_config.log_format))
 
537
 
 
538
    def test_acceptable_keys_default(self):
 
539
        my_config = config.Config()
 
540
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
541
            my_config.acceptable_keys))
 
542
 
 
543
    def test_validate_signatures_in_log_default(self):
 
544
        my_config = config.Config()
 
545
        self.assertEqual(False, my_config.validate_signatures_in_log())
351
546
 
352
547
    def test_get_change_editor(self):
353
548
        my_config = InstrumentedConfig()
362
557
 
363
558
    def setUp(self):
364
559
        super(TestConfigPath, self).setUp()
365
 
        os.environ['HOME'] = '/home/bogus'
366
 
        os.environ['XDG_CACHE_DIR'] = ''
 
560
        self.overrideEnv('HOME', '/home/bogus')
 
561
        self.overrideEnv('XDG_CACHE_HOME', '')
367
562
        if sys.platform == 'win32':
368
 
            os.environ['BZR_HOME'] = \
369
 
                r'C:\Documents and Settings\bogus\Application Data'
 
563
            self.overrideEnv(
 
564
                'BZR_HOME', r'C:\Documents and Settings\bogus\Application Data')
370
565
            self.bzr_home = \
371
566
                'C:/Documents and Settings/bogus/Application Data/bazaar/2.0'
372
567
        else:
375
570
    def test_config_dir(self):
376
571
        self.assertEqual(config.config_dir(), self.bzr_home)
377
572
 
 
573
    def test_config_dir_is_unicode(self):
 
574
        self.assertIsInstance(config.config_dir(), unicode)
 
575
 
378
576
    def test_config_filename(self):
379
577
        self.assertEqual(config.config_filename(),
380
578
                         self.bzr_home + '/bazaar.conf')
392
590
            '/home/bogus/.cache')
393
591
 
394
592
 
 
593
class TestXDGConfigDir(tests.TestCaseInTempDir):
 
594
    # must be in temp dir because config tests for the existence of the bazaar
 
595
    # subdirectory of $XDG_CONFIG_HOME
 
596
 
 
597
    def setUp(self):
 
598
        if sys.platform == 'win32':
 
599
            raise tests.TestNotApplicable(
 
600
                'XDG config dir not used on this platform')
 
601
        super(TestXDGConfigDir, self).setUp()
 
602
        self.overrideEnv('HOME', self.test_home_dir)
 
603
        # BZR_HOME overrides everything we want to test so unset it.
 
604
        self.overrideEnv('BZR_HOME', None)
 
605
 
 
606
    def test_xdg_config_dir_exists(self):
 
607
        """When ~/.config/bazaar exists, use it as the config dir."""
 
608
        newdir = osutils.pathjoin(self.test_home_dir, '.config', 'bazaar')
 
609
        os.makedirs(newdir)
 
610
        self.assertEqual(config.config_dir(), newdir)
 
611
 
 
612
    def test_xdg_config_home(self):
 
613
        """When XDG_CONFIG_HOME is set, use it."""
 
614
        xdgconfigdir = osutils.pathjoin(self.test_home_dir, 'xdgconfig')
 
615
        self.overrideEnv('XDG_CONFIG_HOME', xdgconfigdir)
 
616
        newdir = osutils.pathjoin(xdgconfigdir, 'bazaar')
 
617
        os.makedirs(newdir)
 
618
        self.assertEqual(config.config_dir(), newdir)
 
619
 
 
620
 
395
621
class TestIniConfig(tests.TestCaseInTempDir):
396
622
 
397
623
    def make_config_parser(self, s):
402
628
class TestIniConfigBuilding(TestIniConfig):
403
629
 
404
630
    def test_contructs(self):
405
 
        my_config = config.IniBasedConfig()
 
631
        config.IniBasedConfig()
406
632
 
407
633
    def test_from_fp(self):
408
634
        my_config = config.IniBasedConfig.from_string(sample_config_text)
411
637
    def test_cached(self):
412
638
        my_config = config.IniBasedConfig.from_string(sample_config_text)
413
639
        parser = my_config._get_parser()
414
 
        self.failUnless(my_config._get_parser() is parser)
 
640
        self.assertTrue(my_config._get_parser() is parser)
415
641
 
416
642
    def _dummy_chown(self, path, uid, gid):
417
643
        self.path, self.uid, self.gid = path, uid, gid
442
668
            ' Use IniBasedConfig(_content=xxx) instead.'],
443
669
            conf._get_parser, file=config_file)
444
670
 
 
671
 
445
672
class TestIniConfigSaving(tests.TestCaseInTempDir):
446
673
 
447
674
    def test_cant_save_without_a_file_name(self):
450
677
 
451
678
    def test_saved_with_content(self):
452
679
        content = 'foo = bar\n'
453
 
        conf = config.IniBasedConfig.from_string(
454
 
            content, file_name='./test.conf', save=True)
 
680
        config.IniBasedConfig.from_string(content, file_name='./test.conf',
 
681
                                          save=True)
455
682
        self.assertFileEqual(content, 'test.conf')
456
683
 
457
684
 
 
685
class TestIniConfigOptionExpansion(tests.TestCase):
 
686
    """Test option expansion from the IniConfig level.
 
687
 
 
688
    What we really want here is to test the Config level, but the class being
 
689
    abstract as far as storing values is concerned, this can't be done
 
690
    properly (yet).
 
691
    """
 
692
    # FIXME: This should be rewritten when all configs share a storage
 
693
    # implementation -- vila 2011-02-18
 
694
 
 
695
    def get_config(self, string=None):
 
696
        if string is None:
 
697
            string = ''
 
698
        c = config.IniBasedConfig.from_string(string)
 
699
        return c
 
700
 
 
701
    def assertExpansion(self, expected, conf, string, env=None):
 
702
        self.assertEquals(expected, conf.expand_options(string, env))
 
703
 
 
704
    def test_no_expansion(self):
 
705
        c = self.get_config('')
 
706
        self.assertExpansion('foo', c, 'foo')
 
707
 
 
708
    def test_env_adding_options(self):
 
709
        c = self.get_config('')
 
710
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
 
711
 
 
712
    def test_env_overriding_options(self):
 
713
        c = self.get_config('foo=baz')
 
714
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
 
715
 
 
716
    def test_simple_ref(self):
 
717
        c = self.get_config('foo=xxx')
 
718
        self.assertExpansion('xxx', c, '{foo}')
 
719
 
 
720
    def test_unknown_ref(self):
 
721
        c = self.get_config('')
 
722
        self.assertRaises(errors.ExpandingUnknownOption,
 
723
                          c.expand_options, '{foo}')
 
724
 
 
725
    def test_indirect_ref(self):
 
726
        c = self.get_config('''
 
727
foo=xxx
 
728
bar={foo}
 
729
''')
 
730
        self.assertExpansion('xxx', c, '{bar}')
 
731
 
 
732
    def test_embedded_ref(self):
 
733
        c = self.get_config('''
 
734
foo=xxx
 
735
bar=foo
 
736
''')
 
737
        self.assertExpansion('xxx', c, '{{bar}}')
 
738
 
 
739
    def test_simple_loop(self):
 
740
        c = self.get_config('foo={foo}')
 
741
        self.assertRaises(errors.OptionExpansionLoop, c.expand_options, '{foo}')
 
742
 
 
743
    def test_indirect_loop(self):
 
744
        c = self.get_config('''
 
745
foo={bar}
 
746
bar={baz}
 
747
baz={foo}''')
 
748
        e = self.assertRaises(errors.OptionExpansionLoop,
 
749
                              c.expand_options, '{foo}')
 
750
        self.assertEquals('foo->bar->baz', e.refs)
 
751
        self.assertEquals('{foo}', e.string)
 
752
 
 
753
    def test_list(self):
 
754
        conf = self.get_config('''
 
755
foo=start
 
756
bar=middle
 
757
baz=end
 
758
list={foo},{bar},{baz}
 
759
''')
 
760
        self.assertEquals(['start', 'middle', 'end'],
 
761
                           conf.get_user_option('list', expand=True))
 
762
 
 
763
    def test_cascading_list(self):
 
764
        conf = self.get_config('''
 
765
foo=start,{bar}
 
766
bar=middle,{baz}
 
767
baz=end
 
768
list={foo}
 
769
''')
 
770
        self.assertEquals(['start', 'middle', 'end'],
 
771
                           conf.get_user_option('list', expand=True))
 
772
 
 
773
    def test_pathological_hidden_list(self):
 
774
        conf = self.get_config('''
 
775
foo=bin
 
776
bar=go
 
777
start={foo
 
778
middle=},{
 
779
end=bar}
 
780
hidden={start}{middle}{end}
 
781
''')
 
782
        # Nope, it's either a string or a list, and the list wins as soon as a
 
783
        # ',' appears, so the string concatenation never occur.
 
784
        self.assertEquals(['{foo', '}', '{', 'bar}'],
 
785
                          conf.get_user_option('hidden', expand=True))
 
786
 
 
787
 
 
788
class TestLocationConfigOptionExpansion(tests.TestCaseInTempDir):
 
789
 
 
790
    def get_config(self, location, string=None):
 
791
        if string is None:
 
792
            string = ''
 
793
        # Since we don't save the config we won't strictly require to inherit
 
794
        # from TestCaseInTempDir, but an error occurs so quickly...
 
795
        c = config.LocationConfig.from_string(string, location)
 
796
        return c
 
797
 
 
798
    def test_dont_cross_unrelated_section(self):
 
799
        c = self.get_config('/another/branch/path','''
 
800
[/one/branch/path]
 
801
foo = hello
 
802
bar = {foo}/2
 
803
 
 
804
[/another/branch/path]
 
805
bar = {foo}/2
 
806
''')
 
807
        self.assertRaises(errors.ExpandingUnknownOption,
 
808
                          c.get_user_option, 'bar', expand=True)
 
809
 
 
810
    def test_cross_related_sections(self):
 
811
        c = self.get_config('/project/branch/path','''
 
812
[/project]
 
813
foo = qu
 
814
 
 
815
[/project/branch/path]
 
816
bar = {foo}ux
 
817
''')
 
818
        self.assertEquals('quux', c.get_user_option('bar', expand=True))
 
819
 
 
820
 
458
821
class TestIniBaseConfigOnDisk(tests.TestCaseInTempDir):
459
822
 
460
823
    def test_cannot_reload_without_name(self):
477
840
 
478
841
class TestLockableConfig(tests.TestCaseInTempDir):
479
842
 
 
843
    scenarios = lockable_config_scenarios()
 
844
 
480
845
    # Set by load_tests
481
846
    config_class = None
482
847
    config_args = None
538
903
        def c1_write_config_file():
539
904
            before_writing.set()
540
905
            c1_orig()
541
 
            # The lock is held we wait for the main thread to decide when to
 
906
            # The lock is held. We wait for the main thread to decide when to
542
907
            # continue
543
908
            after_writing.wait()
544
909
        c1._write_config_file = c1_write_config_file
571
936
       c1_orig = c1._write_config_file
572
937
       def c1_write_config_file():
573
938
           ready_to_write.set()
574
 
           # The lock is held we wait for the main thread to decide when to
 
939
           # The lock is held. We wait for the main thread to decide when to
575
940
           # continue
576
941
           do_writing.wait()
577
942
           c1_orig()
636
1001
        # automatically cast to list
637
1002
        self.assertEqual(['x'], get_list('one_item'))
638
1003
 
 
1004
    def test_get_user_option_as_int_from_SI(self):
 
1005
        conf, parser = self.make_config_parser("""
 
1006
plain = 100
 
1007
si_k = 5k,
 
1008
si_kb = 5kb,
 
1009
si_m = 5M,
 
1010
si_mb = 5MB,
 
1011
si_g = 5g,
 
1012
si_gb = 5gB,
 
1013
""")
 
1014
        def get_si(s, default=None):
 
1015
            return self.applyDeprecated(
 
1016
                deprecated_in((2, 5, 0)),
 
1017
                conf.get_user_option_as_int_from_SI, s, default)
 
1018
        self.assertEqual(100, get_si('plain'))
 
1019
        self.assertEqual(5000, get_si('si_k'))
 
1020
        self.assertEqual(5000, get_si('si_kb'))
 
1021
        self.assertEqual(5000000, get_si('si_m'))
 
1022
        self.assertEqual(5000000, get_si('si_mb'))
 
1023
        self.assertEqual(5000000000, get_si('si_g'))
 
1024
        self.assertEqual(5000000000, get_si('si_gb'))
 
1025
        self.assertEqual(None, get_si('non-exist'))
 
1026
        self.assertEqual(42, get_si('non-exist-with-default',  42))
 
1027
 
639
1028
 
640
1029
class TestSupressWarning(TestIniConfig):
641
1030
 
657
1046
class TestGetConfig(tests.TestCase):
658
1047
 
659
1048
    def test_constructs(self):
660
 
        my_config = config.GlobalConfig()
 
1049
        config.GlobalConfig()
661
1050
 
662
1051
    def test_calls_read_filenames(self):
663
1052
        # replace the class that is constructed, to check its parameters
668
1057
            parser = my_config._get_parser()
669
1058
        finally:
670
1059
            config.ConfigObj = oldparserclass
671
 
        self.failUnless(isinstance(parser, InstrumentedConfigObj))
 
1060
        self.assertIsInstance(parser, InstrumentedConfigObj)
672
1061
        self.assertEqual(parser._calls, [('__init__', config.config_filename(),
673
1062
                                          'utf-8')])
674
1063
 
675
1064
 
676
1065
class TestBranchConfig(tests.TestCaseWithTransport):
677
1066
 
678
 
    def test_constructs(self):
 
1067
    def test_constructs_valid(self):
679
1068
        branch = FakeBranch()
680
1069
        my_config = config.BranchConfig(branch)
 
1070
        self.assertIsNot(None, my_config)
 
1071
 
 
1072
    def test_constructs_error(self):
681
1073
        self.assertRaises(TypeError, config.BranchConfig)
682
1074
 
683
1075
    def test_get_location_config(self):
685
1077
        my_config = config.BranchConfig(branch)
686
1078
        location_config = my_config._get_location_config()
687
1079
        self.assertEqual(branch.base, location_config.location)
688
 
        self.failUnless(location_config is my_config._get_location_config())
 
1080
        self.assertIs(location_config, my_config._get_location_config())
689
1081
 
690
1082
    def test_get_config(self):
691
1083
        """The Branch.get_config method works properly"""
692
 
        b = bzrdir.BzrDir.create_standalone_workingtree('.').branch
 
1084
        b = controldir.ControlDir.create_standalone_workingtree('.').branch
693
1085
        my_config = b.get_config()
694
1086
        self.assertIs(my_config.get_user_option('wacky'), None)
695
1087
        my_config.set_user_option('wacky', 'unlikely')
715
1107
        conf = config.LocationConfig.from_string(
716
1108
            '[%s]\nnickname = foobar' % (local_url,),
717
1109
            local_url, save=True)
 
1110
        self.assertIsNot(None, conf)
718
1111
        self.assertEqual('foobar', branch.nick)
719
1112
 
720
1113
    def test_config_local_path(self):
723
1116
        self.assertEqual('branch', branch.nick)
724
1117
 
725
1118
        local_path = osutils.getcwd().encode('utf8')
726
 
        conf = config.LocationConfig.from_string(
 
1119
        config.LocationConfig.from_string(
727
1120
            '[%s/branch]\nnickname = barry' % (local_path,),
728
1121
            'branch',  save=True)
 
1122
        # Now the branch will find its nick via the location config
729
1123
        self.assertEqual('barry', branch.nick)
730
1124
 
731
1125
    def test_config_creates_local(self):
744
1138
        b = self.make_branch('!repo')
745
1139
        self.assertEqual('!repo', b.get_config().get_nickname())
746
1140
 
 
1141
    def test_autonick_uses_branch_name(self):
 
1142
        b = self.make_branch('foo', name='bar')
 
1143
        self.assertEqual('bar', b.get_config().get_nickname())
 
1144
 
747
1145
    def test_warn_if_masked(self):
748
1146
        warnings = []
749
1147
        def warning(*args):
778
1176
        assertWarning(None)
779
1177
 
780
1178
 
781
 
class TestGlobalConfigItems(tests.TestCase):
 
1179
class TestGlobalConfigItems(tests.TestCaseInTempDir):
782
1180
 
783
1181
    def test_user_id(self):
784
1182
        my_config = config.GlobalConfig.from_string(sample_config_text)
789
1187
        my_config = config.GlobalConfig()
790
1188
        self.assertEqual(None, my_config._get_user_id())
791
1189
 
792
 
    def test_configured_editor(self):
793
 
        my_config = config.GlobalConfig.from_string(sample_config_text)
794
 
        self.assertEqual("vim", my_config.get_editor())
795
 
 
796
1190
    def test_signatures_always(self):
797
1191
        my_config = config.GlobalConfig.from_string(sample_always_signatures)
798
1192
        self.assertEqual(config.CHECK_NEVER,
799
 
                         my_config.signature_checking())
 
1193
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1194
                             my_config.signature_checking))
800
1195
        self.assertEqual(config.SIGN_ALWAYS,
801
 
                         my_config.signing_policy())
802
 
        self.assertEqual(True, my_config.signature_needed())
 
1196
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1197
                             my_config.signing_policy))
 
1198
        self.assertEqual(True,
 
1199
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1200
                my_config.signature_needed))
803
1201
 
804
1202
    def test_signatures_if_possible(self):
805
1203
        my_config = config.GlobalConfig.from_string(sample_maybe_signatures)
806
1204
        self.assertEqual(config.CHECK_NEVER,
807
 
                         my_config.signature_checking())
 
1205
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1206
                             my_config.signature_checking))
808
1207
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
809
 
                         my_config.signing_policy())
810
 
        self.assertEqual(False, my_config.signature_needed())
 
1208
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1209
                             my_config.signing_policy))
 
1210
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1211
            my_config.signature_needed))
811
1212
 
812
1213
    def test_signatures_ignore(self):
813
1214
        my_config = config.GlobalConfig.from_string(sample_ignore_signatures)
814
1215
        self.assertEqual(config.CHECK_ALWAYS,
815
 
                         my_config.signature_checking())
 
1216
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1217
                             my_config.signature_checking))
816
1218
        self.assertEqual(config.SIGN_NEVER,
817
 
                         my_config.signing_policy())
818
 
        self.assertEqual(False, my_config.signature_needed())
 
1219
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1220
                             my_config.signing_policy))
 
1221
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1222
            my_config.signature_needed))
819
1223
 
820
1224
    def _get_sample_config(self):
821
1225
        my_config = config.GlobalConfig.from_string(sample_config_text)
823
1227
 
824
1228
    def test_gpg_signing_command(self):
825
1229
        my_config = self._get_sample_config()
826
 
        self.assertEqual("gnome-gpg", my_config.gpg_signing_command())
827
 
        self.assertEqual(False, my_config.signature_needed())
 
1230
        self.assertEqual("gnome-gpg",
 
1231
            self.applyDeprecated(
 
1232
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
 
1233
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1234
            my_config.signature_needed))
 
1235
 
 
1236
    def test_gpg_signing_key(self):
 
1237
        my_config = self._get_sample_config()
 
1238
        self.assertEqual("DD4D5088",
 
1239
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1240
                my_config.gpg_signing_key))
828
1241
 
829
1242
    def _get_empty_config(self):
830
1243
        my_config = config.GlobalConfig()
832
1245
 
833
1246
    def test_gpg_signing_command_unset(self):
834
1247
        my_config = self._get_empty_config()
835
 
        self.assertEqual("gpg", my_config.gpg_signing_command())
 
1248
        self.assertEqual("gpg",
 
1249
            self.applyDeprecated(
 
1250
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
836
1251
 
837
1252
    def test_get_user_option_default(self):
838
1253
        my_config = self._get_empty_config()
845
1260
 
846
1261
    def test_post_commit_default(self):
847
1262
        my_config = self._get_sample_config()
848
 
        self.assertEqual(None, my_config.post_commit())
 
1263
        self.assertEqual(None,
 
1264
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1265
                                              my_config.post_commit))
849
1266
 
850
1267
    def test_configured_logformat(self):
851
1268
        my_config = self._get_sample_config()
852
 
        self.assertEqual("short", my_config.log_format())
 
1269
        self.assertEqual("short",
 
1270
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1271
                                              my_config.log_format))
 
1272
 
 
1273
    def test_configured_acceptable_keys(self):
 
1274
        my_config = self._get_sample_config()
 
1275
        self.assertEqual("amy",
 
1276
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1277
                my_config.acceptable_keys))
 
1278
 
 
1279
    def test_configured_validate_signatures_in_log(self):
 
1280
        my_config = self._get_sample_config()
 
1281
        self.assertEqual(True, my_config.validate_signatures_in_log())
853
1282
 
854
1283
    def test_get_alias(self):
855
1284
        my_config = self._get_sample_config()
883
1312
        change_editor = my_config.get_change_editor('old', 'new')
884
1313
        self.assertIs(None, change_editor)
885
1314
 
 
1315
    def test_get_merge_tools(self):
 
1316
        conf = self._get_sample_config()
 
1317
        tools = conf.get_merge_tools()
 
1318
        self.log(repr(tools))
 
1319
        self.assertEqual(
 
1320
            {u'funkytool' : u'funkytool "arg with spaces" {this_temp}',
 
1321
            u'sometool' : u'sometool {base} {this} {other} -o {result}',
 
1322
            u'newtool' : u'"newtool with spaces" {this_temp}'},
 
1323
            tools)
 
1324
 
 
1325
    def test_get_merge_tools_empty(self):
 
1326
        conf = self._get_empty_config()
 
1327
        tools = conf.get_merge_tools()
 
1328
        self.assertEqual({}, tools)
 
1329
 
 
1330
    def test_find_merge_tool(self):
 
1331
        conf = self._get_sample_config()
 
1332
        cmdline = conf.find_merge_tool('sometool')
 
1333
        self.assertEqual('sometool {base} {this} {other} -o {result}', cmdline)
 
1334
 
 
1335
    def test_find_merge_tool_not_found(self):
 
1336
        conf = self._get_sample_config()
 
1337
        cmdline = conf.find_merge_tool('DOES NOT EXIST')
 
1338
        self.assertIs(cmdline, None)
 
1339
 
 
1340
    def test_find_merge_tool_known(self):
 
1341
        conf = self._get_empty_config()
 
1342
        cmdline = conf.find_merge_tool('kdiff3')
 
1343
        self.assertEquals('kdiff3 {base} {this} {other} -o {result}', cmdline)
 
1344
 
 
1345
    def test_find_merge_tool_override_known(self):
 
1346
        conf = self._get_empty_config()
 
1347
        conf.set_user_option('bzr.mergetool.kdiff3', 'kdiff3 blah')
 
1348
        cmdline = conf.find_merge_tool('kdiff3')
 
1349
        self.assertEqual('kdiff3 blah', cmdline)
 
1350
 
886
1351
 
887
1352
class TestGlobalConfigSavingOptions(tests.TestCaseInTempDir):
888
1353
 
906
1371
        self.assertIs(None, new_config.get_alias('commit'))
907
1372
 
908
1373
 
909
 
class TestLocationConfig(tests.TestCaseInTempDir):
910
 
 
911
 
    def test_constructs(self):
912
 
        my_config = config.LocationConfig('http://example.com')
 
1374
class TestLocationConfig(tests.TestCaseInTempDir, TestOptionsMixin):
 
1375
 
 
1376
    def test_constructs_valid(self):
 
1377
        config.LocationConfig('http://example.com')
 
1378
 
 
1379
    def test_constructs_error(self):
913
1380
        self.assertRaises(TypeError, config.LocationConfig)
914
1381
 
915
1382
    def test_branch_calls_read_filenames(self):
924
1391
            parser = my_config._get_parser()
925
1392
        finally:
926
1393
            config.ConfigObj = oldparserclass
927
 
        self.failUnless(isinstance(parser, InstrumentedConfigObj))
 
1394
        self.assertIsInstance(parser, InstrumentedConfigObj)
928
1395
        self.assertEqual(parser._calls,
929
1396
                         [('__init__', config.locations_config_filename(),
930
1397
                           'utf-8')])
932
1399
    def test_get_global_config(self):
933
1400
        my_config = config.BranchConfig(FakeBranch('http://example.com'))
934
1401
        global_config = my_config._get_global_config()
935
 
        self.failUnless(isinstance(global_config, config.GlobalConfig))
936
 
        self.failUnless(global_config is my_config._get_global_config())
 
1402
        self.assertIsInstance(global_config, config.GlobalConfig)
 
1403
        self.assertIs(global_config, my_config._get_global_config())
 
1404
 
 
1405
    def assertLocationMatching(self, expected):
 
1406
        self.assertEqual(expected,
 
1407
                         list(self.my_location_config._get_matching_sections()))
937
1408
 
938
1409
    def test__get_matching_sections_no_match(self):
939
1410
        self.get_branch_config('/')
940
 
        self.assertEqual([], self.my_location_config._get_matching_sections())
 
1411
        self.assertLocationMatching([])
941
1412
 
942
1413
    def test__get_matching_sections_exact(self):
943
1414
        self.get_branch_config('http://www.example.com')
944
 
        self.assertEqual([('http://www.example.com', '')],
945
 
                         self.my_location_config._get_matching_sections())
 
1415
        self.assertLocationMatching([('http://www.example.com', '')])
946
1416
 
947
1417
    def test__get_matching_sections_suffix_does_not(self):
948
1418
        self.get_branch_config('http://www.example.com-com')
949
 
        self.assertEqual([], self.my_location_config._get_matching_sections())
 
1419
        self.assertLocationMatching([])
950
1420
 
951
1421
    def test__get_matching_sections_subdir_recursive(self):
952
1422
        self.get_branch_config('http://www.example.com/com')
953
 
        self.assertEqual([('http://www.example.com', 'com')],
954
 
                         self.my_location_config._get_matching_sections())
 
1423
        self.assertLocationMatching([('http://www.example.com', 'com')])
955
1424
 
956
1425
    def test__get_matching_sections_ignoreparent(self):
957
1426
        self.get_branch_config('http://www.example.com/ignoreparent')
958
 
        self.assertEqual([('http://www.example.com/ignoreparent', '')],
959
 
                         self.my_location_config._get_matching_sections())
 
1427
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
 
1428
                                      '')])
960
1429
 
961
1430
    def test__get_matching_sections_ignoreparent_subdir(self):
962
1431
        self.get_branch_config(
963
1432
            'http://www.example.com/ignoreparent/childbranch')
964
 
        self.assertEqual([('http://www.example.com/ignoreparent',
965
 
                           'childbranch')],
966
 
                         self.my_location_config._get_matching_sections())
 
1433
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
 
1434
                                      'childbranch')])
967
1435
 
968
1436
    def test__get_matching_sections_subdir_trailing_slash(self):
969
1437
        self.get_branch_config('/b')
970
 
        self.assertEqual([('/b/', '')],
971
 
                         self.my_location_config._get_matching_sections())
 
1438
        self.assertLocationMatching([('/b/', '')])
972
1439
 
973
1440
    def test__get_matching_sections_subdir_child(self):
974
1441
        self.get_branch_config('/a/foo')
975
 
        self.assertEqual([('/a/*', ''), ('/a/', 'foo')],
976
 
                         self.my_location_config._get_matching_sections())
 
1442
        self.assertLocationMatching([('/a/*', ''), ('/a/', 'foo')])
977
1443
 
978
1444
    def test__get_matching_sections_subdir_child_child(self):
979
1445
        self.get_branch_config('/a/foo/bar')
980
 
        self.assertEqual([('/a/*', 'bar'), ('/a/', 'foo/bar')],
981
 
                         self.my_location_config._get_matching_sections())
 
1446
        self.assertLocationMatching([('/a/*', 'bar'), ('/a/', 'foo/bar')])
982
1447
 
983
1448
    def test__get_matching_sections_trailing_slash_with_children(self):
984
1449
        self.get_branch_config('/a/')
985
 
        self.assertEqual([('/a/', '')],
986
 
                         self.my_location_config._get_matching_sections())
 
1450
        self.assertLocationMatching([('/a/', '')])
987
1451
 
988
1452
    def test__get_matching_sections_explicit_over_glob(self):
989
1453
        # XXX: 2006-09-08 jamesh
991
1455
        # was a config section for '/a/?', it would get precedence
992
1456
        # over '/a/c'.
993
1457
        self.get_branch_config('/a/c')
994
 
        self.assertEqual([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')],
995
 
                         self.my_location_config._get_matching_sections())
 
1458
        self.assertLocationMatching([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')])
996
1459
 
997
1460
    def test__get_option_policy_normal(self):
998
1461
        self.get_branch_config('http://www.example.com')
1020
1483
            'http://www.example.com', 'appendpath_option'),
1021
1484
            config.POLICY_APPENDPATH)
1022
1485
 
 
1486
    def test__get_options_with_policy(self):
 
1487
        self.get_branch_config('/dir/subdir',
 
1488
                               location_config="""\
 
1489
[/dir]
 
1490
other_url = /other-dir
 
1491
other_url:policy = appendpath
 
1492
[/dir/subdir]
 
1493
other_url = /other-subdir
 
1494
""")
 
1495
        self.assertOptions(
 
1496
            [(u'other_url', u'/other-subdir', u'/dir/subdir', 'locations'),
 
1497
             (u'other_url', u'/other-dir', u'/dir', 'locations'),
 
1498
             (u'other_url:policy', u'appendpath', u'/dir', 'locations')],
 
1499
            self.my_location_config)
 
1500
 
1023
1501
    def test_location_without_username(self):
1024
1502
        self.get_branch_config('http://www.example.com/ignoreparent')
1025
1503
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
1040
1518
        self.get_branch_config('http://www.example.com',
1041
1519
                                 global_config=sample_ignore_signatures)
1042
1520
        self.assertEqual(config.CHECK_ALWAYS,
1043
 
                         self.my_config.signature_checking())
 
1521
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1522
                             self.my_config.signature_checking))
1044
1523
        self.assertEqual(config.SIGN_NEVER,
1045
 
                         self.my_config.signing_policy())
 
1524
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1525
                             self.my_config.signing_policy))
1046
1526
 
1047
1527
    def test_signatures_never(self):
1048
1528
        self.get_branch_config('/a/c')
1049
1529
        self.assertEqual(config.CHECK_NEVER,
1050
 
                         self.my_config.signature_checking())
 
1530
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1531
                             self.my_config.signature_checking))
1051
1532
 
1052
1533
    def test_signatures_when_available(self):
1053
1534
        self.get_branch_config('/a/', global_config=sample_ignore_signatures)
1054
1535
        self.assertEqual(config.CHECK_IF_POSSIBLE,
1055
 
                         self.my_config.signature_checking())
 
1536
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1537
                             self.my_config.signature_checking))
1056
1538
 
1057
1539
    def test_signatures_always(self):
1058
1540
        self.get_branch_config('/b')
1059
1541
        self.assertEqual(config.CHECK_ALWAYS,
1060
 
                         self.my_config.signature_checking())
 
1542
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1543
                         self.my_config.signature_checking))
1061
1544
 
1062
1545
    def test_gpg_signing_command(self):
1063
1546
        self.get_branch_config('/b')
1064
 
        self.assertEqual("gnome-gpg", self.my_config.gpg_signing_command())
 
1547
        self.assertEqual("gnome-gpg",
 
1548
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1549
                self.my_config.gpg_signing_command))
1065
1550
 
1066
1551
    def test_gpg_signing_command_missing(self):
1067
1552
        self.get_branch_config('/a')
1068
 
        self.assertEqual("false", self.my_config.gpg_signing_command())
 
1553
        self.assertEqual("false",
 
1554
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1555
                self.my_config.gpg_signing_command))
 
1556
 
 
1557
    def test_gpg_signing_key(self):
 
1558
        self.get_branch_config('/b')
 
1559
        self.assertEqual("DD4D5088", self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1560
            self.my_config.gpg_signing_key))
 
1561
 
 
1562
    def test_gpg_signing_key_default(self):
 
1563
        self.get_branch_config('/a')
 
1564
        self.assertEqual("erik@bagfors.nu",
 
1565
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1566
                self.my_config.gpg_signing_key))
1069
1567
 
1070
1568
    def test_get_user_option_global(self):
1071
1569
        self.get_branch_config('/a')
1159
1657
    def test_post_commit_default(self):
1160
1658
        self.get_branch_config('/a/c')
1161
1659
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1162
 
                         self.my_config.post_commit())
 
1660
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1661
                                              self.my_config.post_commit))
1163
1662
 
1164
 
    def get_branch_config(self, location, global_config=None):
 
1663
    def get_branch_config(self, location, global_config=None,
 
1664
                          location_config=None):
1165
1665
        my_branch = FakeBranch(location)
1166
1666
        if global_config is None:
1167
1667
            global_config = sample_config_text
 
1668
        if location_config is None:
 
1669
            location_config = sample_branches_text
1168
1670
 
1169
 
        my_global_config = config.GlobalConfig.from_string(global_config,
1170
 
                                                           save=True)
1171
 
        my_location_config = config.LocationConfig.from_string(
1172
 
            sample_branches_text, my_branch.base, save=True)
 
1671
        config.GlobalConfig.from_string(global_config, save=True)
 
1672
        config.LocationConfig.from_string(location_config, my_branch.base,
 
1673
                                          save=True)
1173
1674
        my_config = config.BranchConfig(my_branch)
1174
1675
        self.my_config = my_config
1175
1676
        self.my_location_config = my_config._get_location_config()
1220
1721
        self.assertEqual('bzr', my_config.get_bzr_remote_path())
1221
1722
        my_config.set_user_option('bzr_remote_path', '/path-bzr')
1222
1723
        self.assertEqual('/path-bzr', my_config.get_bzr_remote_path())
1223
 
        os.environ['BZR_REMOTE_PATH'] = '/environ-bzr'
 
1724
        self.overrideEnv('BZR_REMOTE_PATH', '/environ-bzr')
1224
1725
        self.assertEqual('/environ-bzr', my_config.get_bzr_remote_path())
1225
1726
 
1226
1727
 
1240
1741
                          location_config=None, branch_data_config=None):
1241
1742
        my_branch = FakeBranch(location)
1242
1743
        if global_config is not None:
1243
 
            my_global_config = config.GlobalConfig.from_string(global_config,
1244
 
                                                               save=True)
 
1744
            config.GlobalConfig.from_string(global_config, save=True)
1245
1745
        if location_config is not None:
1246
 
            my_location_config = config.LocationConfig.from_string(
1247
 
                location_config, my_branch.base, save=True)
 
1746
            config.LocationConfig.from_string(location_config, my_branch.base,
 
1747
                                              save=True)
1248
1748
        my_config = config.BranchConfig(my_branch)
1249
1749
        if branch_data_config is not None:
1250
1750
            my_config.branch.control_files.files['branch.conf'] = \
1252
1752
        return my_config
1253
1753
 
1254
1754
    def test_user_id(self):
1255
 
        branch = FakeBranch(user_id='Robert Collins <robertc@example.net>')
 
1755
        branch = FakeBranch()
1256
1756
        my_config = config.BranchConfig(branch)
1257
 
        self.assertEqual("Robert Collins <robertc@example.net>",
1258
 
                         my_config.username())
 
1757
        self.assertIsNot(None, my_config.username())
1259
1758
        my_config.branch.control_files.files['email'] = "John"
1260
1759
        my_config.set_user_option('email',
1261
1760
                                  "Robert Collins <robertc@example.org>")
1262
 
        self.assertEqual("John", my_config.username())
1263
 
        del my_config.branch.control_files.files['email']
1264
1761
        self.assertEqual("Robert Collins <robertc@example.org>",
1265
 
                         my_config.username())
1266
 
 
1267
 
    def test_not_set_in_branch(self):
1268
 
        my_config = self.get_branch_config(global_config=sample_config_text)
1269
 
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
1270
 
                         my_config._get_user_id())
1271
 
        my_config.branch.control_files.files['email'] = "John"
1272
 
        self.assertEqual("John", my_config._get_user_id())
 
1762
                        my_config.username())
1273
1763
 
1274
1764
    def test_BZR_EMAIL_OVERRIDES(self):
1275
 
        os.environ['BZR_EMAIL'] = "Robert Collins <robertc@example.org>"
 
1765
        self.overrideEnv('BZR_EMAIL', "Robert Collins <robertc@example.org>")
1276
1766
        branch = FakeBranch()
1277
1767
        my_config = config.BranchConfig(branch)
1278
1768
        self.assertEqual("Robert Collins <robertc@example.org>",
1281
1771
    def test_signatures_forced(self):
1282
1772
        my_config = self.get_branch_config(
1283
1773
            global_config=sample_always_signatures)
1284
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1285
 
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1286
 
        self.assertTrue(my_config.signature_needed())
 
1774
        self.assertEqual(config.CHECK_NEVER,
 
1775
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1776
                my_config.signature_checking))
 
1777
        self.assertEqual(config.SIGN_ALWAYS,
 
1778
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1779
                my_config.signing_policy))
 
1780
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1781
            my_config.signature_needed))
1287
1782
 
1288
1783
    def test_signatures_forced_branch(self):
1289
1784
        my_config = self.get_branch_config(
1290
1785
            global_config=sample_ignore_signatures,
1291
1786
            branch_data_config=sample_always_signatures)
1292
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1293
 
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1294
 
        self.assertTrue(my_config.signature_needed())
 
1787
        self.assertEqual(config.CHECK_NEVER,
 
1788
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1789
                my_config.signature_checking))
 
1790
        self.assertEqual(config.SIGN_ALWAYS,
 
1791
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1792
                my_config.signing_policy))
 
1793
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1794
            my_config.signature_needed))
1295
1795
 
1296
1796
    def test_gpg_signing_command(self):
1297
1797
        my_config = self.get_branch_config(
1298
1798
            global_config=sample_config_text,
1299
1799
            # branch data cannot set gpg_signing_command
1300
1800
            branch_data_config="gpg_signing_command=pgp")
1301
 
        self.assertEqual('gnome-gpg', my_config.gpg_signing_command())
 
1801
        self.assertEqual('gnome-gpg',
 
1802
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1803
                my_config.gpg_signing_command))
1302
1804
 
1303
1805
    def test_get_user_option_global(self):
1304
1806
        my_config = self.get_branch_config(global_config=sample_config_text)
1311
1813
                                      location_config=sample_branches_text)
1312
1814
        self.assertEqual(my_config.branch.base, '/a/c')
1313
1815
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1314
 
                         my_config.post_commit())
 
1816
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1817
                                              my_config.post_commit))
1315
1818
        my_config.set_user_option('post_commit', 'rmtree_root')
1316
1819
        # post-commit is ignored when present in branch data
1317
1820
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1318
 
                         my_config.post_commit())
 
1821
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1822
                                              my_config.post_commit))
1319
1823
        my_config.set_user_option('post_commit', 'rmtree_root',
1320
1824
                                  store=config.STORE_LOCATION)
1321
 
        self.assertEqual('rmtree_root', my_config.post_commit())
 
1825
        self.assertEqual('rmtree_root',
 
1826
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1827
                                              my_config.post_commit))
1322
1828
 
1323
1829
    def test_config_precedence(self):
1324
1830
        # FIXME: eager test, luckily no persitent config file makes it fail
1340
1846
            location='http://example.com/specific')
1341
1847
        self.assertEqual(my_config.get_user_option('option'), 'exact')
1342
1848
 
1343
 
    def test_get_mail_client(self):
1344
 
        config = self.get_branch_config()
1345
 
        client = config.get_mail_client()
1346
 
        self.assertIsInstance(client, mail_client.DefaultMail)
1347
 
 
1348
 
        # Specific clients
1349
 
        config.set_user_option('mail_client', 'evolution')
1350
 
        client = config.get_mail_client()
1351
 
        self.assertIsInstance(client, mail_client.Evolution)
1352
 
 
1353
 
        config.set_user_option('mail_client', 'kmail')
1354
 
        client = config.get_mail_client()
1355
 
        self.assertIsInstance(client, mail_client.KMail)
1356
 
 
1357
 
        config.set_user_option('mail_client', 'mutt')
1358
 
        client = config.get_mail_client()
1359
 
        self.assertIsInstance(client, mail_client.Mutt)
1360
 
 
1361
 
        config.set_user_option('mail_client', 'thunderbird')
1362
 
        client = config.get_mail_client()
1363
 
        self.assertIsInstance(client, mail_client.Thunderbird)
1364
 
 
1365
 
        # Generic options
1366
 
        config.set_user_option('mail_client', 'default')
1367
 
        client = config.get_mail_client()
1368
 
        self.assertIsInstance(client, mail_client.DefaultMail)
1369
 
 
1370
 
        config.set_user_option('mail_client', 'editor')
1371
 
        client = config.get_mail_client()
1372
 
        self.assertIsInstance(client, mail_client.Editor)
1373
 
 
1374
 
        config.set_user_option('mail_client', 'mapi')
1375
 
        client = config.get_mail_client()
1376
 
        self.assertIsInstance(client, mail_client.MAPIClient)
1377
 
 
1378
 
        config.set_user_option('mail_client', 'xdg-email')
1379
 
        client = config.get_mail_client()
1380
 
        self.assertIsInstance(client, mail_client.XDGEmail)
1381
 
 
1382
 
        config.set_user_option('mail_client', 'firebird')
1383
 
        self.assertRaises(errors.UnknownMailClient, config.get_mail_client)
1384
 
 
1385
1849
 
1386
1850
class TestMailAddressExtraction(tests.TestCase):
1387
1851
 
1433
1897
 
1434
1898
class TestTransportConfig(tests.TestCaseWithTransport):
1435
1899
 
 
1900
    def test_load_utf8(self):
 
1901
        """Ensure we can load an utf8-encoded file."""
 
1902
        t = self.get_transport()
 
1903
        unicode_user = u'b\N{Euro Sign}ar'
 
1904
        unicode_content = u'user=%s' % (unicode_user,)
 
1905
        utf8_content = unicode_content.encode('utf8')
 
1906
        # Store the raw content in the config file
 
1907
        t.put_bytes('foo.conf', utf8_content)
 
1908
        conf = config.TransportConfig(t, 'foo.conf')
 
1909
        self.assertEquals(unicode_user, conf.get_option('user'))
 
1910
 
 
1911
    def test_load_non_ascii(self):
 
1912
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
1913
        t = self.get_transport()
 
1914
        t.put_bytes('foo.conf', 'user=foo\n#\xff\n')
 
1915
        conf = config.TransportConfig(t, 'foo.conf')
 
1916
        self.assertRaises(errors.ConfigContentError, conf._get_configobj)
 
1917
 
 
1918
    def test_load_erroneous_content(self):
 
1919
        """Ensure we display a proper error on content that can't be parsed."""
 
1920
        t = self.get_transport()
 
1921
        t.put_bytes('foo.conf', '[open_section\n')
 
1922
        conf = config.TransportConfig(t, 'foo.conf')
 
1923
        self.assertRaises(errors.ParseConfigError, conf._get_configobj)
 
1924
 
 
1925
    def test_load_permission_denied(self):
 
1926
        """Ensure we get an empty config file if the file is inaccessible."""
 
1927
        warnings = []
 
1928
        def warning(*args):
 
1929
            warnings.append(args[0] % args[1:])
 
1930
        self.overrideAttr(trace, 'warning', warning)
 
1931
 
 
1932
        class DenyingTransport(object):
 
1933
 
 
1934
            def __init__(self, base):
 
1935
                self.base = base
 
1936
 
 
1937
            def get_bytes(self, relpath):
 
1938
                raise errors.PermissionDenied(relpath, "")
 
1939
 
 
1940
        cfg = config.TransportConfig(
 
1941
            DenyingTransport("nonexisting://"), 'control.conf')
 
1942
        self.assertIs(None, cfg.get_option('non-existant', 'SECTION'))
 
1943
        self.assertEquals(
 
1944
            warnings,
 
1945
            [u'Permission denied while trying to open configuration file '
 
1946
             u'nonexisting:///control.conf.'])
 
1947
 
1436
1948
    def test_get_value(self):
1437
1949
        """Test that retreiving a value from a section is possible"""
1438
 
        bzrdir_config = config.TransportConfig(transport.get_transport('.'),
 
1950
        bzrdir_config = config.TransportConfig(self.get_transport('.'),
1439
1951
                                               'control.conf')
1440
1952
        bzrdir_config.set_option('value', 'key', 'SECTION')
1441
1953
        bzrdir_config.set_option('value2', 'key2')
1471
1983
        self.assertIs(None, bzrdir_config.get_default_stack_on())
1472
1984
 
1473
1985
 
 
1986
class TestOldConfigHooks(tests.TestCaseWithTransport):
 
1987
 
 
1988
    def setUp(self):
 
1989
        super(TestOldConfigHooks, self).setUp()
 
1990
        create_configs_with_file_option(self)
 
1991
 
 
1992
    def assertGetHook(self, conf, name, value):
 
1993
        calls = []
 
1994
        def hook(*args):
 
1995
            calls.append(args)
 
1996
        config.OldConfigHooks.install_named_hook('get', hook, None)
 
1997
        self.addCleanup(
 
1998
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
 
1999
        self.assertLength(0, calls)
 
2000
        actual_value = conf.get_user_option(name)
 
2001
        self.assertEquals(value, actual_value)
 
2002
        self.assertLength(1, calls)
 
2003
        self.assertEquals((conf, name, value), calls[0])
 
2004
 
 
2005
    def test_get_hook_bazaar(self):
 
2006
        self.assertGetHook(self.bazaar_config, 'file', 'bazaar')
 
2007
 
 
2008
    def test_get_hook_locations(self):
 
2009
        self.assertGetHook(self.locations_config, 'file', 'locations')
 
2010
 
 
2011
    def test_get_hook_branch(self):
 
2012
        # Since locations masks branch, we define a different option
 
2013
        self.branch_config.set_user_option('file2', 'branch')
 
2014
        self.assertGetHook(self.branch_config, 'file2', 'branch')
 
2015
 
 
2016
    def assertSetHook(self, conf, name, value):
 
2017
        calls = []
 
2018
        def hook(*args):
 
2019
            calls.append(args)
 
2020
        config.OldConfigHooks.install_named_hook('set', hook, None)
 
2021
        self.addCleanup(
 
2022
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
 
2023
        self.assertLength(0, calls)
 
2024
        conf.set_user_option(name, value)
 
2025
        self.assertLength(1, calls)
 
2026
        # We can't assert the conf object below as different configs use
 
2027
        # different means to implement set_user_option and we care only about
 
2028
        # coverage here.
 
2029
        self.assertEquals((name, value), calls[0][1:])
 
2030
 
 
2031
    def test_set_hook_bazaar(self):
 
2032
        self.assertSetHook(self.bazaar_config, 'foo', 'bazaar')
 
2033
 
 
2034
    def test_set_hook_locations(self):
 
2035
        self.assertSetHook(self.locations_config, 'foo', 'locations')
 
2036
 
 
2037
    def test_set_hook_branch(self):
 
2038
        self.assertSetHook(self.branch_config, 'foo', 'branch')
 
2039
 
 
2040
    def assertRemoveHook(self, conf, name, section_name=None):
 
2041
        calls = []
 
2042
        def hook(*args):
 
2043
            calls.append(args)
 
2044
        config.OldConfigHooks.install_named_hook('remove', hook, None)
 
2045
        self.addCleanup(
 
2046
            config.OldConfigHooks.uninstall_named_hook, 'remove', None)
 
2047
        self.assertLength(0, calls)
 
2048
        conf.remove_user_option(name, section_name)
 
2049
        self.assertLength(1, calls)
 
2050
        # We can't assert the conf object below as different configs use
 
2051
        # different means to implement remove_user_option and we care only about
 
2052
        # coverage here.
 
2053
        self.assertEquals((name,), calls[0][1:])
 
2054
 
 
2055
    def test_remove_hook_bazaar(self):
 
2056
        self.assertRemoveHook(self.bazaar_config, 'file')
 
2057
 
 
2058
    def test_remove_hook_locations(self):
 
2059
        self.assertRemoveHook(self.locations_config, 'file',
 
2060
                              self.locations_config.location)
 
2061
 
 
2062
    def test_remove_hook_branch(self):
 
2063
        self.assertRemoveHook(self.branch_config, 'file')
 
2064
 
 
2065
    def assertLoadHook(self, name, conf_class, *conf_args):
 
2066
        calls = []
 
2067
        def hook(*args):
 
2068
            calls.append(args)
 
2069
        config.OldConfigHooks.install_named_hook('load', hook, None)
 
2070
        self.addCleanup(
 
2071
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
 
2072
        self.assertLength(0, calls)
 
2073
        # Build a config
 
2074
        conf = conf_class(*conf_args)
 
2075
        # Access an option to trigger a load
 
2076
        conf.get_user_option(name)
 
2077
        self.assertLength(1, calls)
 
2078
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2079
 
 
2080
    def test_load_hook_bazaar(self):
 
2081
        self.assertLoadHook('file', config.GlobalConfig)
 
2082
 
 
2083
    def test_load_hook_locations(self):
 
2084
        self.assertLoadHook('file', config.LocationConfig, self.tree.basedir)
 
2085
 
 
2086
    def test_load_hook_branch(self):
 
2087
        self.assertLoadHook('file', config.BranchConfig, self.tree.branch)
 
2088
 
 
2089
    def assertSaveHook(self, conf):
 
2090
        calls = []
 
2091
        def hook(*args):
 
2092
            calls.append(args)
 
2093
        config.OldConfigHooks.install_named_hook('save', hook, None)
 
2094
        self.addCleanup(
 
2095
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
 
2096
        self.assertLength(0, calls)
 
2097
        # Setting an option triggers a save
 
2098
        conf.set_user_option('foo', 'bar')
 
2099
        self.assertLength(1, calls)
 
2100
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2101
 
 
2102
    def test_save_hook_bazaar(self):
 
2103
        self.assertSaveHook(self.bazaar_config)
 
2104
 
 
2105
    def test_save_hook_locations(self):
 
2106
        self.assertSaveHook(self.locations_config)
 
2107
 
 
2108
    def test_save_hook_branch(self):
 
2109
        self.assertSaveHook(self.branch_config)
 
2110
 
 
2111
 
 
2112
class TestOldConfigHooksForRemote(tests.TestCaseWithTransport):
 
2113
    """Tests config hooks for remote configs.
 
2114
 
 
2115
    No tests for the remove hook as this is not implemented there.
 
2116
    """
 
2117
 
 
2118
    def setUp(self):
 
2119
        super(TestOldConfigHooksForRemote, self).setUp()
 
2120
        self.transport_server = test_server.SmartTCPServer_for_testing
 
2121
        create_configs_with_file_option(self)
 
2122
 
 
2123
    def assertGetHook(self, conf, name, value):
 
2124
        calls = []
 
2125
        def hook(*args):
 
2126
            calls.append(args)
 
2127
        config.OldConfigHooks.install_named_hook('get', hook, None)
 
2128
        self.addCleanup(
 
2129
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
 
2130
        self.assertLength(0, calls)
 
2131
        actual_value = conf.get_option(name)
 
2132
        self.assertEquals(value, actual_value)
 
2133
        self.assertLength(1, calls)
 
2134
        self.assertEquals((conf, name, value), calls[0])
 
2135
 
 
2136
    def test_get_hook_remote_branch(self):
 
2137
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2138
        self.assertGetHook(remote_branch._get_config(), 'file', 'branch')
 
2139
 
 
2140
    def test_get_hook_remote_bzrdir(self):
 
2141
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
 
2142
        conf = remote_bzrdir._get_config()
 
2143
        conf.set_option('remotedir', 'file')
 
2144
        self.assertGetHook(conf, 'file', 'remotedir')
 
2145
 
 
2146
    def assertSetHook(self, conf, name, value):
 
2147
        calls = []
 
2148
        def hook(*args):
 
2149
            calls.append(args)
 
2150
        config.OldConfigHooks.install_named_hook('set', hook, None)
 
2151
        self.addCleanup(
 
2152
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
 
2153
        self.assertLength(0, calls)
 
2154
        conf.set_option(value, name)
 
2155
        self.assertLength(1, calls)
 
2156
        # We can't assert the conf object below as different configs use
 
2157
        # different means to implement set_user_option and we care only about
 
2158
        # coverage here.
 
2159
        self.assertEquals((name, value), calls[0][1:])
 
2160
 
 
2161
    def test_set_hook_remote_branch(self):
 
2162
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2163
        self.addCleanup(remote_branch.lock_write().unlock)
 
2164
        self.assertSetHook(remote_branch._get_config(), 'file', 'remote')
 
2165
 
 
2166
    def test_set_hook_remote_bzrdir(self):
 
2167
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2168
        self.addCleanup(remote_branch.lock_write().unlock)
 
2169
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
 
2170
        self.assertSetHook(remote_bzrdir._get_config(), 'file', 'remotedir')
 
2171
 
 
2172
    def assertLoadHook(self, expected_nb_calls, name, conf_class, *conf_args):
 
2173
        calls = []
 
2174
        def hook(*args):
 
2175
            calls.append(args)
 
2176
        config.OldConfigHooks.install_named_hook('load', hook, None)
 
2177
        self.addCleanup(
 
2178
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
 
2179
        self.assertLength(0, calls)
 
2180
        # Build a config
 
2181
        conf = conf_class(*conf_args)
 
2182
        # Access an option to trigger a load
 
2183
        conf.get_option(name)
 
2184
        self.assertLength(expected_nb_calls, calls)
 
2185
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2186
 
 
2187
    def test_load_hook_remote_branch(self):
 
2188
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2189
        self.assertLoadHook(1, 'file', remote.RemoteBranchConfig, remote_branch)
 
2190
 
 
2191
    def test_load_hook_remote_bzrdir(self):
 
2192
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
 
2193
        # The config file doesn't exist, set an option to force its creation
 
2194
        conf = remote_bzrdir._get_config()
 
2195
        conf.set_option('remotedir', 'file')
 
2196
        # We get one call for the server and one call for the client, this is
 
2197
        # caused by the differences in implementations betwen
 
2198
        # SmartServerBzrDirRequestConfigFile (in smart/bzrdir.py) and
 
2199
        # SmartServerBranchGetConfigFile (in smart/branch.py)
 
2200
        self.assertLoadHook(2 ,'file', remote.RemoteBzrDirConfig, remote_bzrdir)
 
2201
 
 
2202
    def assertSaveHook(self, conf):
 
2203
        calls = []
 
2204
        def hook(*args):
 
2205
            calls.append(args)
 
2206
        config.OldConfigHooks.install_named_hook('save', hook, None)
 
2207
        self.addCleanup(
 
2208
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
 
2209
        self.assertLength(0, calls)
 
2210
        # Setting an option triggers a save
 
2211
        conf.set_option('foo', 'bar')
 
2212
        self.assertLength(1, calls)
 
2213
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2214
 
 
2215
    def test_save_hook_remote_branch(self):
 
2216
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2217
        self.addCleanup(remote_branch.lock_write().unlock)
 
2218
        self.assertSaveHook(remote_branch._get_config())
 
2219
 
 
2220
    def test_save_hook_remote_bzrdir(self):
 
2221
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2222
        self.addCleanup(remote_branch.lock_write().unlock)
 
2223
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
 
2224
        self.assertSaveHook(remote_bzrdir._get_config())
 
2225
 
 
2226
 
 
2227
class TestOptionNames(tests.TestCase):
 
2228
 
 
2229
    def is_valid(self, name):
 
2230
        return config._option_ref_re.match('{%s}' % name) is not None
 
2231
 
 
2232
    def test_valid_names(self):
 
2233
        self.assertTrue(self.is_valid('foo'))
 
2234
        self.assertTrue(self.is_valid('foo.bar'))
 
2235
        self.assertTrue(self.is_valid('f1'))
 
2236
        self.assertTrue(self.is_valid('_'))
 
2237
        self.assertTrue(self.is_valid('__bar__'))
 
2238
        self.assertTrue(self.is_valid('a_'))
 
2239
        self.assertTrue(self.is_valid('a1'))
 
2240
 
 
2241
    def test_invalid_names(self):
 
2242
        self.assertFalse(self.is_valid(' foo'))
 
2243
        self.assertFalse(self.is_valid('foo '))
 
2244
        self.assertFalse(self.is_valid('1'))
 
2245
        self.assertFalse(self.is_valid('1,2'))
 
2246
        self.assertFalse(self.is_valid('foo$'))
 
2247
        self.assertFalse(self.is_valid('!foo'))
 
2248
        self.assertFalse(self.is_valid('foo.'))
 
2249
        self.assertFalse(self.is_valid('foo..bar'))
 
2250
        self.assertFalse(self.is_valid('{}'))
 
2251
        self.assertFalse(self.is_valid('{a}'))
 
2252
        self.assertFalse(self.is_valid('a\n'))
 
2253
 
 
2254
    def assertSingleGroup(self, reference):
 
2255
        # the regexp is used with split and as such should match the reference
 
2256
        # *only*, if more groups needs to be defined, (?:...) should be used.
 
2257
        m = config._option_ref_re.match('{a}')
 
2258
        self.assertLength(1, m.groups())
 
2259
 
 
2260
    def test_valid_references(self):
 
2261
        self.assertSingleGroup('{a}')
 
2262
        self.assertSingleGroup('{{a}}')
 
2263
 
 
2264
 
 
2265
class TestOption(tests.TestCase):
 
2266
 
 
2267
    def test_default_value(self):
 
2268
        opt = config.Option('foo', default='bar')
 
2269
        self.assertEquals('bar', opt.get_default())
 
2270
 
 
2271
    def test_callable_default_value(self):
 
2272
        def bar_as_unicode():
 
2273
            return u'bar'
 
2274
        opt = config.Option('foo', default=bar_as_unicode)
 
2275
        self.assertEquals('bar', opt.get_default())
 
2276
 
 
2277
    def test_default_value_from_env(self):
 
2278
        opt = config.Option('foo', default='bar', default_from_env=['FOO'])
 
2279
        self.overrideEnv('FOO', 'quux')
 
2280
        # Env variable provides a default taking over the option one
 
2281
        self.assertEquals('quux', opt.get_default())
 
2282
 
 
2283
    def test_first_default_value_from_env_wins(self):
 
2284
        opt = config.Option('foo', default='bar',
 
2285
                            default_from_env=['NO_VALUE', 'FOO', 'BAZ'])
 
2286
        self.overrideEnv('FOO', 'foo')
 
2287
        self.overrideEnv('BAZ', 'baz')
 
2288
        # The first env var set wins
 
2289
        self.assertEquals('foo', opt.get_default())
 
2290
 
 
2291
    def test_not_supported_list_default_value(self):
 
2292
        self.assertRaises(AssertionError, config.Option, 'foo', default=[1])
 
2293
 
 
2294
    def test_not_supported_object_default_value(self):
 
2295
        self.assertRaises(AssertionError, config.Option, 'foo',
 
2296
                          default=object())
 
2297
 
 
2298
    def test_not_supported_callable_default_value_not_unicode(self):
 
2299
        def bar_not_unicode():
 
2300
            return 'bar'
 
2301
        opt = config.Option('foo', default=bar_not_unicode)
 
2302
        self.assertRaises(AssertionError, opt.get_default)
 
2303
 
 
2304
    def test_get_help_topic(self):
 
2305
        opt = config.Option('foo')
 
2306
        self.assertEquals('foo', opt.get_help_topic())
 
2307
 
 
2308
 
 
2309
class TestOptionConverter(tests.TestCase):
 
2310
 
 
2311
    def assertConverted(self, expected, opt, value):
 
2312
        self.assertEquals(expected, opt.convert_from_unicode(None, value))
 
2313
 
 
2314
    def assertCallsWarning(self, opt, value):
 
2315
        warnings = []
 
2316
 
 
2317
        def warning(*args):
 
2318
            warnings.append(args[0] % args[1:])
 
2319
        self.overrideAttr(trace, 'warning', warning)
 
2320
        self.assertEquals(None, opt.convert_from_unicode(None, value))
 
2321
        self.assertLength(1, warnings)
 
2322
        self.assertEquals(
 
2323
            'Value "%s" is not valid for "%s"' % (value, opt.name),
 
2324
            warnings[0])
 
2325
 
 
2326
    def assertCallsError(self, opt, value):
 
2327
        self.assertRaises(errors.ConfigOptionValueError,
 
2328
                          opt.convert_from_unicode, None, value)
 
2329
 
 
2330
    def assertConvertInvalid(self, opt, invalid_value):
 
2331
        opt.invalid = None
 
2332
        self.assertEquals(None, opt.convert_from_unicode(None, invalid_value))
 
2333
        opt.invalid = 'warning'
 
2334
        self.assertCallsWarning(opt, invalid_value)
 
2335
        opt.invalid = 'error'
 
2336
        self.assertCallsError(opt, invalid_value)
 
2337
 
 
2338
 
 
2339
class TestOptionWithBooleanConverter(TestOptionConverter):
 
2340
 
 
2341
    def get_option(self):
 
2342
        return config.Option('foo', help='A boolean.',
 
2343
                             from_unicode=config.bool_from_store)
 
2344
 
 
2345
    def test_convert_invalid(self):
 
2346
        opt = self.get_option()
 
2347
        # A string that is not recognized as a boolean
 
2348
        self.assertConvertInvalid(opt, u'invalid-boolean')
 
2349
        # A list of strings is never recognized as a boolean
 
2350
        self.assertConvertInvalid(opt, [u'not', u'a', u'boolean'])
 
2351
 
 
2352
    def test_convert_valid(self):
 
2353
        opt = self.get_option()
 
2354
        self.assertConverted(True, opt, u'True')
 
2355
        self.assertConverted(True, opt, u'1')
 
2356
        self.assertConverted(False, opt, u'False')
 
2357
 
 
2358
 
 
2359
class TestOptionWithIntegerConverter(TestOptionConverter):
 
2360
 
 
2361
    def get_option(self):
 
2362
        return config.Option('foo', help='An integer.',
 
2363
                             from_unicode=config.int_from_store)
 
2364
 
 
2365
    def test_convert_invalid(self):
 
2366
        opt = self.get_option()
 
2367
        # A string that is not recognized as an integer
 
2368
        self.assertConvertInvalid(opt, u'forty-two')
 
2369
        # A list of strings is never recognized as an integer
 
2370
        self.assertConvertInvalid(opt, [u'a', u'list'])
 
2371
 
 
2372
    def test_convert_valid(self):
 
2373
        opt = self.get_option()
 
2374
        self.assertConverted(16, opt, u'16')
 
2375
 
 
2376
 
 
2377
class TestOptionWithSIUnitConverter(TestOptionConverter):
 
2378
 
 
2379
    def get_option(self):
 
2380
        return config.Option('foo', help='An integer in SI units.',
 
2381
                             from_unicode=config.int_SI_from_store)
 
2382
 
 
2383
    def test_convert_invalid(self):
 
2384
        opt = self.get_option()
 
2385
        self.assertConvertInvalid(opt, u'not-a-unit')
 
2386
        self.assertConvertInvalid(opt, u'Gb')  # Forgot the value
 
2387
        self.assertConvertInvalid(opt, u'1b')  # Forgot the unit
 
2388
        self.assertConvertInvalid(opt, u'1GG')
 
2389
        self.assertConvertInvalid(opt, u'1Mbb')
 
2390
        self.assertConvertInvalid(opt, u'1MM')
 
2391
 
 
2392
    def test_convert_valid(self):
 
2393
        opt = self.get_option()
 
2394
        self.assertConverted(int(5e3), opt, u'5kb')
 
2395
        self.assertConverted(int(5e6), opt, u'5M')
 
2396
        self.assertConverted(int(5e6), opt, u'5MB')
 
2397
        self.assertConverted(int(5e9), opt, u'5g')
 
2398
        self.assertConverted(int(5e9), opt, u'5gB')
 
2399
        self.assertConverted(100, opt, u'100')
 
2400
 
 
2401
 
 
2402
class TestListOption(TestOptionConverter):
 
2403
 
 
2404
    def get_option(self):
 
2405
        return config.ListOption('foo', help='A list.')
 
2406
 
 
2407
    def test_convert_invalid(self):
 
2408
        opt = self.get_option()
 
2409
        # We don't even try to convert a list into a list, we only expect
 
2410
        # strings
 
2411
        self.assertConvertInvalid(opt, [1])
 
2412
        # No string is invalid as all forms can be converted to a list
 
2413
 
 
2414
    def test_convert_valid(self):
 
2415
        opt = self.get_option()
 
2416
        # An empty string is an empty list
 
2417
        self.assertConverted([], opt, '')  # Using a bare str() just in case
 
2418
        self.assertConverted([], opt, u'')
 
2419
        # A boolean
 
2420
        self.assertConverted([u'True'], opt, u'True')
 
2421
        # An integer
 
2422
        self.assertConverted([u'42'], opt, u'42')
 
2423
        # A single string
 
2424
        self.assertConverted([u'bar'], opt, u'bar')
 
2425
 
 
2426
 
 
2427
class TestRegistryOption(TestOptionConverter):
 
2428
 
 
2429
    def get_option(self, registry):
 
2430
        return config.RegistryOption('foo', registry,
 
2431
                                     help='A registry option.')
 
2432
 
 
2433
    def test_convert_invalid(self):
 
2434
        registry = _mod_registry.Registry()
 
2435
        opt = self.get_option(registry)
 
2436
        self.assertConvertInvalid(opt, [1])
 
2437
        self.assertConvertInvalid(opt, u"notregistered")
 
2438
 
 
2439
    def test_convert_valid(self):
 
2440
        registry = _mod_registry.Registry()
 
2441
        registry.register("someval", 1234)
 
2442
        opt = self.get_option(registry)
 
2443
        # Using a bare str() just in case
 
2444
        self.assertConverted(1234, opt, "someval")
 
2445
        self.assertConverted(1234, opt, u'someval')
 
2446
        self.assertConverted(None, opt, None)
 
2447
 
 
2448
    def test_help(self):
 
2449
        registry = _mod_registry.Registry()
 
2450
        registry.register("someval", 1234, help="some option")
 
2451
        registry.register("dunno", 1234, help="some other option")
 
2452
        opt = self.get_option(registry)
 
2453
        self.assertEquals(
 
2454
            'A registry option.\n'
 
2455
            '\n'
 
2456
            'The following values are supported:\n'
 
2457
            ' dunno - some other option\n'
 
2458
            ' someval - some option\n',
 
2459
            opt.help)
 
2460
 
 
2461
    def test_get_help_text(self):
 
2462
        registry = _mod_registry.Registry()
 
2463
        registry.register("someval", 1234, help="some option")
 
2464
        registry.register("dunno", 1234, help="some other option")
 
2465
        opt = self.get_option(registry)
 
2466
        self.assertEquals(
 
2467
            'A registry option.\n'
 
2468
            '\n'
 
2469
            'The following values are supported:\n'
 
2470
            ' dunno - some other option\n'
 
2471
            ' someval - some option\n',
 
2472
            opt.get_help_text())
 
2473
 
 
2474
 
 
2475
class TestOptionRegistry(tests.TestCase):
 
2476
 
 
2477
    def setUp(self):
 
2478
        super(TestOptionRegistry, self).setUp()
 
2479
        # Always start with an empty registry
 
2480
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
2481
        self.registry = config.option_registry
 
2482
 
 
2483
    def test_register(self):
 
2484
        opt = config.Option('foo')
 
2485
        self.registry.register(opt)
 
2486
        self.assertIs(opt, self.registry.get('foo'))
 
2487
 
 
2488
    def test_registered_help(self):
 
2489
        opt = config.Option('foo', help='A simple option')
 
2490
        self.registry.register(opt)
 
2491
        self.assertEquals('A simple option', self.registry.get_help('foo'))
 
2492
 
 
2493
    def test_dont_register_illegal_name(self):
 
2494
        self.assertRaises(errors.IllegalOptionName,
 
2495
                          self.registry.register, config.Option(' foo'))
 
2496
        self.assertRaises(errors.IllegalOptionName,
 
2497
                          self.registry.register, config.Option('bar,'))
 
2498
 
 
2499
    lazy_option = config.Option('lazy_foo', help='Lazy help')
 
2500
 
 
2501
    def test_register_lazy(self):
 
2502
        self.registry.register_lazy('lazy_foo', self.__module__,
 
2503
                                    'TestOptionRegistry.lazy_option')
 
2504
        self.assertIs(self.lazy_option, self.registry.get('lazy_foo'))
 
2505
 
 
2506
    def test_registered_lazy_help(self):
 
2507
        self.registry.register_lazy('lazy_foo', self.__module__,
 
2508
                                    'TestOptionRegistry.lazy_option')
 
2509
        self.assertEquals('Lazy help', self.registry.get_help('lazy_foo'))
 
2510
 
 
2511
    def test_dont_lazy_register_illegal_name(self):
 
2512
        # This is where the root cause of http://pad.lv/1235099 is better
 
2513
        # understood: 'register_lazy' doc string mentions that key should match
 
2514
        # the option name which indirectly requires that the option name is a
 
2515
        # valid python identifier. We violate that rule here (using a key that
 
2516
        # doesn't match the option name) to test the option name checking.
 
2517
        self.assertRaises(errors.IllegalOptionName,
 
2518
                          self.registry.register_lazy, ' foo', self.__module__,
 
2519
                          'TestOptionRegistry.lazy_option')
 
2520
        self.assertRaises(errors.IllegalOptionName,
 
2521
                          self.registry.register_lazy, '1,2', self.__module__,
 
2522
                          'TestOptionRegistry.lazy_option')
 
2523
 
 
2524
 
 
2525
class TestRegisteredOptions(tests.TestCase):
 
2526
    """All registered options should verify some constraints."""
 
2527
 
 
2528
    scenarios = [(key, {'option_name': key, 'option': option}) for key, option
 
2529
                 in config.option_registry.iteritems()]
 
2530
 
 
2531
    def setUp(self):
 
2532
        super(TestRegisteredOptions, self).setUp()
 
2533
        self.registry = config.option_registry
 
2534
 
 
2535
    def test_proper_name(self):
 
2536
        # An option should be registered under its own name, this can't be
 
2537
        # checked at registration time for the lazy ones.
 
2538
        self.assertEquals(self.option_name, self.option.name)
 
2539
 
 
2540
    def test_help_is_set(self):
 
2541
        option_help = self.registry.get_help(self.option_name)
 
2542
        # Come on, think about the user, he really wants to know what the
 
2543
        # option is about
 
2544
        self.assertIsNot(None, option_help)
 
2545
        self.assertNotEquals('', option_help)
 
2546
 
 
2547
 
 
2548
class TestSection(tests.TestCase):
 
2549
 
 
2550
    # FIXME: Parametrize so that all sections produced by Stores run these
 
2551
    # tests -- vila 2011-04-01
 
2552
 
 
2553
    def test_get_a_value(self):
 
2554
        a_dict = dict(foo='bar')
 
2555
        section = config.Section('myID', a_dict)
 
2556
        self.assertEquals('bar', section.get('foo'))
 
2557
 
 
2558
    def test_get_unknown_option(self):
 
2559
        a_dict = dict()
 
2560
        section = config.Section(None, a_dict)
 
2561
        self.assertEquals('out of thin air',
 
2562
                          section.get('foo', 'out of thin air'))
 
2563
 
 
2564
    def test_options_is_shared(self):
 
2565
        a_dict = dict()
 
2566
        section = config.Section(None, a_dict)
 
2567
        self.assertIs(a_dict, section.options)
 
2568
 
 
2569
 
 
2570
class TestMutableSection(tests.TestCase):
 
2571
 
 
2572
    scenarios = [('mutable',
 
2573
                  {'get_section':
 
2574
                       lambda opts: config.MutableSection('myID', opts)},),
 
2575
        ]
 
2576
 
 
2577
    def test_set(self):
 
2578
        a_dict = dict(foo='bar')
 
2579
        section = self.get_section(a_dict)
 
2580
        section.set('foo', 'new_value')
 
2581
        self.assertEquals('new_value', section.get('foo'))
 
2582
        # The change appears in the shared section
 
2583
        self.assertEquals('new_value', a_dict.get('foo'))
 
2584
        # We keep track of the change
 
2585
        self.assertTrue('foo' in section.orig)
 
2586
        self.assertEquals('bar', section.orig.get('foo'))
 
2587
 
 
2588
    def test_set_preserve_original_once(self):
 
2589
        a_dict = dict(foo='bar')
 
2590
        section = self.get_section(a_dict)
 
2591
        section.set('foo', 'first_value')
 
2592
        section.set('foo', 'second_value')
 
2593
        # We keep track of the original value
 
2594
        self.assertTrue('foo' in section.orig)
 
2595
        self.assertEquals('bar', section.orig.get('foo'))
 
2596
 
 
2597
    def test_remove(self):
 
2598
        a_dict = dict(foo='bar')
 
2599
        section = self.get_section(a_dict)
 
2600
        section.remove('foo')
 
2601
        # We get None for unknown options via the default value
 
2602
        self.assertEquals(None, section.get('foo'))
 
2603
        # Or we just get the default value
 
2604
        self.assertEquals('unknown', section.get('foo', 'unknown'))
 
2605
        self.assertFalse('foo' in section.options)
 
2606
        # We keep track of the deletion
 
2607
        self.assertTrue('foo' in section.orig)
 
2608
        self.assertEquals('bar', section.orig.get('foo'))
 
2609
 
 
2610
    def test_remove_new_option(self):
 
2611
        a_dict = dict()
 
2612
        section = self.get_section(a_dict)
 
2613
        section.set('foo', 'bar')
 
2614
        section.remove('foo')
 
2615
        self.assertFalse('foo' in section.options)
 
2616
        # The option didn't exist initially so it we need to keep track of it
 
2617
        # with a special value
 
2618
        self.assertTrue('foo' in section.orig)
 
2619
        self.assertEquals(config._NewlyCreatedOption, section.orig['foo'])
 
2620
 
 
2621
 
 
2622
class TestCommandLineStore(tests.TestCase):
 
2623
 
 
2624
    def setUp(self):
 
2625
        super(TestCommandLineStore, self).setUp()
 
2626
        self.store = config.CommandLineStore()
 
2627
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
2628
 
 
2629
    def get_section(self):
 
2630
        """Get the unique section for the command line overrides."""
 
2631
        sections = list(self.store.get_sections())
 
2632
        self.assertLength(1, sections)
 
2633
        store, section = sections[0]
 
2634
        self.assertEquals(self.store, store)
 
2635
        return section
 
2636
 
 
2637
    def test_no_override(self):
 
2638
        self.store._from_cmdline([])
 
2639
        section = self.get_section()
 
2640
        self.assertLength(0, list(section.iter_option_names()))
 
2641
 
 
2642
    def test_simple_override(self):
 
2643
        self.store._from_cmdline(['a=b'])
 
2644
        section = self.get_section()
 
2645
        self.assertEqual('b', section.get('a'))
 
2646
 
 
2647
    def test_list_override(self):
 
2648
        opt = config.ListOption('l')
 
2649
        config.option_registry.register(opt)
 
2650
        self.store._from_cmdline(['l=1,2,3'])
 
2651
        val = self.get_section().get('l')
 
2652
        self.assertEqual('1,2,3', val)
 
2653
        # Reminder: lists should be registered as such explicitely, otherwise
 
2654
        # the conversion needs to be done afterwards.
 
2655
        self.assertEqual(['1', '2', '3'],
 
2656
                         opt.convert_from_unicode(self.store, val))
 
2657
 
 
2658
    def test_multiple_overrides(self):
 
2659
        self.store._from_cmdline(['a=b', 'x=y'])
 
2660
        section = self.get_section()
 
2661
        self.assertEquals('b', section.get('a'))
 
2662
        self.assertEquals('y', section.get('x'))
 
2663
 
 
2664
    def test_wrong_syntax(self):
 
2665
        self.assertRaises(errors.BzrCommandError,
 
2666
                          self.store._from_cmdline, ['a=b', 'c'])
 
2667
 
 
2668
class TestStoreMinimalAPI(tests.TestCaseWithTransport):
 
2669
 
 
2670
    scenarios = [(key, {'get_store': builder}) for key, builder
 
2671
                 in config.test_store_builder_registry.iteritems()] + [
 
2672
        ('cmdline', {'get_store': lambda test: config.CommandLineStore()})]
 
2673
 
 
2674
    def test_id(self):
 
2675
        store = self.get_store(self)
 
2676
        if type(store) == config.TransportIniFileStore:
 
2677
            raise tests.TestNotApplicable(
 
2678
                "%s is not a concrete Store implementation"
 
2679
                " so it doesn't need an id" % (store.__class__.__name__,))
 
2680
        self.assertIsNot(None, store.id)
 
2681
 
 
2682
 
 
2683
class TestStore(tests.TestCaseWithTransport):
 
2684
 
 
2685
    def assertSectionContent(self, expected, (store, section)):
 
2686
        """Assert that some options have the proper values in a section."""
 
2687
        expected_name, expected_options = expected
 
2688
        self.assertEquals(expected_name, section.id)
 
2689
        self.assertEquals(
 
2690
            expected_options,
 
2691
            dict([(k, section.get(k)) for k in expected_options.keys()]))
 
2692
 
 
2693
 
 
2694
class TestReadonlyStore(TestStore):
 
2695
 
 
2696
    scenarios = [(key, {'get_store': builder}) for key, builder
 
2697
                 in config.test_store_builder_registry.iteritems()]
 
2698
 
 
2699
    def test_building_delays_load(self):
 
2700
        store = self.get_store(self)
 
2701
        self.assertEquals(False, store.is_loaded())
 
2702
        store._load_from_string('')
 
2703
        self.assertEquals(True, store.is_loaded())
 
2704
 
 
2705
    def test_get_no_sections_for_empty(self):
 
2706
        store = self.get_store(self)
 
2707
        store._load_from_string('')
 
2708
        self.assertEquals([], list(store.get_sections()))
 
2709
 
 
2710
    def test_get_default_section(self):
 
2711
        store = self.get_store(self)
 
2712
        store._load_from_string('foo=bar')
 
2713
        sections = list(store.get_sections())
 
2714
        self.assertLength(1, sections)
 
2715
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2716
 
 
2717
    def test_get_named_section(self):
 
2718
        store = self.get_store(self)
 
2719
        store._load_from_string('[baz]\nfoo=bar')
 
2720
        sections = list(store.get_sections())
 
2721
        self.assertLength(1, sections)
 
2722
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
 
2723
 
 
2724
    def test_load_from_string_fails_for_non_empty_store(self):
 
2725
        store = self.get_store(self)
 
2726
        store._load_from_string('foo=bar')
 
2727
        self.assertRaises(AssertionError, store._load_from_string, 'bar=baz')
 
2728
 
 
2729
 
 
2730
class TestStoreQuoting(TestStore):
 
2731
 
 
2732
    scenarios = [(key, {'get_store': builder}) for key, builder
 
2733
                 in config.test_store_builder_registry.iteritems()]
 
2734
 
 
2735
    def setUp(self):
 
2736
        super(TestStoreQuoting, self).setUp()
 
2737
        self.store = self.get_store(self)
 
2738
        # We need a loaded store but any content will do
 
2739
        self.store._load_from_string('')
 
2740
 
 
2741
    def assertIdempotent(self, s):
 
2742
        """Assert that quoting an unquoted string is a no-op and vice-versa.
 
2743
 
 
2744
        What matters here is that option values, as they appear in a store, can
 
2745
        be safely round-tripped out of the store and back.
 
2746
 
 
2747
        :param s: A string, quoted if required.
 
2748
        """
 
2749
        self.assertEquals(s, self.store.quote(self.store.unquote(s)))
 
2750
        self.assertEquals(s, self.store.unquote(self.store.quote(s)))
 
2751
 
 
2752
    def test_empty_string(self):
 
2753
        if isinstance(self.store, config.IniFileStore):
 
2754
            # configobj._quote doesn't handle empty values
 
2755
            self.assertRaises(AssertionError,
 
2756
                              self.assertIdempotent, '')
 
2757
        else:
 
2758
            self.assertIdempotent('')
 
2759
        # But quoted empty strings are ok
 
2760
        self.assertIdempotent('""')
 
2761
 
 
2762
    def test_embedded_spaces(self):
 
2763
        self.assertIdempotent('" a b c "')
 
2764
 
 
2765
    def test_embedded_commas(self):
 
2766
        self.assertIdempotent('" a , b c "')
 
2767
 
 
2768
    def test_simple_comma(self):
 
2769
        if isinstance(self.store, config.IniFileStore):
 
2770
            # configobj requires that lists are special-cased
 
2771
           self.assertRaises(AssertionError,
 
2772
                             self.assertIdempotent, ',')
 
2773
        else:
 
2774
            self.assertIdempotent(',')
 
2775
        # When a single comma is required, quoting is also required
 
2776
        self.assertIdempotent('","')
 
2777
 
 
2778
    def test_list(self):
 
2779
        if isinstance(self.store, config.IniFileStore):
 
2780
            # configobj requires that lists are special-cased
 
2781
            self.assertRaises(AssertionError,
 
2782
                              self.assertIdempotent, 'a,b')
 
2783
        else:
 
2784
            self.assertIdempotent('a,b')
 
2785
 
 
2786
 
 
2787
class TestDictFromStore(tests.TestCase):
 
2788
 
 
2789
    def test_unquote_not_string(self):
 
2790
        conf = config.MemoryStack('x=2\n[a_section]\na=1\n')
 
2791
        value = conf.get('a_section')
 
2792
        # Urgh, despite 'conf' asking for the no-name section, we get the
 
2793
        # content of another section as a dict o_O
 
2794
        self.assertEquals({'a': '1'}, value)
 
2795
        unquoted = conf.store.unquote(value)
 
2796
        # Which cannot be unquoted but shouldn't crash either (the use cases
 
2797
        # are getting the value or displaying it. In the later case, '%s' will
 
2798
        # do).
 
2799
        self.assertEquals({'a': '1'}, unquoted)
 
2800
        self.assertEquals("{u'a': u'1'}", '%s' % (unquoted,))
 
2801
 
 
2802
 
 
2803
class TestIniFileStoreContent(tests.TestCaseWithTransport):
 
2804
    """Simulate loading a config store with content of various encodings.
 
2805
 
 
2806
    All files produced by bzr are in utf8 content.
 
2807
 
 
2808
    Users may modify them manually and end up with a file that can't be
 
2809
    loaded. We need to issue proper error messages in this case.
 
2810
    """
 
2811
 
 
2812
    invalid_utf8_char = '\xff'
 
2813
 
 
2814
    def test_load_utf8(self):
 
2815
        """Ensure we can load an utf8-encoded file."""
 
2816
        t = self.get_transport()
 
2817
        # From http://pad.lv/799212
 
2818
        unicode_user = u'b\N{Euro Sign}ar'
 
2819
        unicode_content = u'user=%s' % (unicode_user,)
 
2820
        utf8_content = unicode_content.encode('utf8')
 
2821
        # Store the raw content in the config file
 
2822
        t.put_bytes('foo.conf', utf8_content)
 
2823
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2824
        store.load()
 
2825
        stack = config.Stack([store.get_sections], store)
 
2826
        self.assertEquals(unicode_user, stack.get('user'))
 
2827
 
 
2828
    def test_load_non_ascii(self):
 
2829
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2830
        t = self.get_transport()
 
2831
        t.put_bytes('foo.conf', 'user=foo\n#%s\n' % (self.invalid_utf8_char,))
 
2832
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2833
        self.assertRaises(errors.ConfigContentError, store.load)
 
2834
 
 
2835
    def test_load_erroneous_content(self):
 
2836
        """Ensure we display a proper error on content that can't be parsed."""
 
2837
        t = self.get_transport()
 
2838
        t.put_bytes('foo.conf', '[open_section\n')
 
2839
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2840
        self.assertRaises(errors.ParseConfigError, store.load)
 
2841
 
 
2842
    def test_load_permission_denied(self):
 
2843
        """Ensure we get warned when trying to load an inaccessible file."""
 
2844
        warnings = []
 
2845
        def warning(*args):
 
2846
            warnings.append(args[0] % args[1:])
 
2847
        self.overrideAttr(trace, 'warning', warning)
 
2848
 
 
2849
        t = self.get_transport()
 
2850
 
 
2851
        def get_bytes(relpath):
 
2852
            raise errors.PermissionDenied(relpath, "")
 
2853
        t.get_bytes = get_bytes
 
2854
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2855
        self.assertRaises(errors.PermissionDenied, store.load)
 
2856
        self.assertEquals(
 
2857
            warnings,
 
2858
            [u'Permission denied while trying to load configuration store %s.'
 
2859
             % store.external_url()])
 
2860
 
 
2861
 
 
2862
class TestIniConfigContent(tests.TestCaseWithTransport):
 
2863
    """Simulate loading a IniBasedConfig with content of various encodings.
 
2864
 
 
2865
    All files produced by bzr are in utf8 content.
 
2866
 
 
2867
    Users may modify them manually and end up with a file that can't be
 
2868
    loaded. We need to issue proper error messages in this case.
 
2869
    """
 
2870
 
 
2871
    invalid_utf8_char = '\xff'
 
2872
 
 
2873
    def test_load_utf8(self):
 
2874
        """Ensure we can load an utf8-encoded file."""
 
2875
        # From http://pad.lv/799212
 
2876
        unicode_user = u'b\N{Euro Sign}ar'
 
2877
        unicode_content = u'user=%s' % (unicode_user,)
 
2878
        utf8_content = unicode_content.encode('utf8')
 
2879
        # Store the raw content in the config file
 
2880
        with open('foo.conf', 'wb') as f:
 
2881
            f.write(utf8_content)
 
2882
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2883
        self.assertEquals(unicode_user, conf.get_user_option('user'))
 
2884
 
 
2885
    def test_load_badly_encoded_content(self):
 
2886
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2887
        with open('foo.conf', 'wb') as f:
 
2888
            f.write('user=foo\n#%s\n' % (self.invalid_utf8_char,))
 
2889
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2890
        self.assertRaises(errors.ConfigContentError, conf._get_parser)
 
2891
 
 
2892
    def test_load_erroneous_content(self):
 
2893
        """Ensure we display a proper error on content that can't be parsed."""
 
2894
        with open('foo.conf', 'wb') as f:
 
2895
            f.write('[open_section\n')
 
2896
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2897
        self.assertRaises(errors.ParseConfigError, conf._get_parser)
 
2898
 
 
2899
 
 
2900
class TestMutableStore(TestStore):
 
2901
 
 
2902
    scenarios = [(key, {'store_id': key, 'get_store': builder}) for key, builder
 
2903
                 in config.test_store_builder_registry.iteritems()]
 
2904
 
 
2905
    def setUp(self):
 
2906
        super(TestMutableStore, self).setUp()
 
2907
        self.transport = self.get_transport()
 
2908
 
 
2909
    def has_store(self, store):
 
2910
        store_basename = urlutils.relative_url(self.transport.external_url(),
 
2911
                                               store.external_url())
 
2912
        return self.transport.has(store_basename)
 
2913
 
 
2914
    def test_save_empty_creates_no_file(self):
 
2915
        # FIXME: There should be a better way than relying on the test
 
2916
        # parametrization to identify branch.conf -- vila 2011-0526
 
2917
        if self.store_id in ('branch', 'remote_branch'):
 
2918
            raise tests.TestNotApplicable(
 
2919
                'branch.conf is *always* created when a branch is initialized')
 
2920
        store = self.get_store(self)
 
2921
        store.save()
 
2922
        self.assertEquals(False, self.has_store(store))
 
2923
 
 
2924
    def test_mutable_section_shared(self):
 
2925
        store = self.get_store(self)
 
2926
        store._load_from_string('foo=bar\n')
 
2927
        # FIXME: There should be a better way than relying on the test
 
2928
        # parametrization to identify branch.conf -- vila 2011-0526
 
2929
        if self.store_id in ('branch', 'remote_branch'):
 
2930
            # branch stores requires write locked branches
 
2931
            self.addCleanup(store.branch.lock_write().unlock)
 
2932
        section1 = store.get_mutable_section(None)
 
2933
        section2 = store.get_mutable_section(None)
 
2934
        # If we get different sections, different callers won't share the
 
2935
        # modification
 
2936
        self.assertIs(section1, section2)
 
2937
 
 
2938
    def test_save_emptied_succeeds(self):
 
2939
        store = self.get_store(self)
 
2940
        store._load_from_string('foo=bar\n')
 
2941
        # FIXME: There should be a better way than relying on the test
 
2942
        # parametrization to identify branch.conf -- vila 2011-0526
 
2943
        if self.store_id in ('branch', 'remote_branch'):
 
2944
            # branch stores requires write locked branches
 
2945
            self.addCleanup(store.branch.lock_write().unlock)
 
2946
        section = store.get_mutable_section(None)
 
2947
        section.remove('foo')
 
2948
        store.save()
 
2949
        self.assertEquals(True, self.has_store(store))
 
2950
        modified_store = self.get_store(self)
 
2951
        sections = list(modified_store.get_sections())
 
2952
        self.assertLength(0, sections)
 
2953
 
 
2954
    def test_save_with_content_succeeds(self):
 
2955
        # FIXME: There should be a better way than relying on the test
 
2956
        # parametrization to identify branch.conf -- vila 2011-0526
 
2957
        if self.store_id in ('branch', 'remote_branch'):
 
2958
            raise tests.TestNotApplicable(
 
2959
                'branch.conf is *always* created when a branch is initialized')
 
2960
        store = self.get_store(self)
 
2961
        store._load_from_string('foo=bar\n')
 
2962
        self.assertEquals(False, self.has_store(store))
 
2963
        store.save()
 
2964
        self.assertEquals(True, self.has_store(store))
 
2965
        modified_store = self.get_store(self)
 
2966
        sections = list(modified_store.get_sections())
 
2967
        self.assertLength(1, sections)
 
2968
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2969
 
 
2970
    def test_set_option_in_empty_store(self):
 
2971
        store = self.get_store(self)
 
2972
        # FIXME: There should be a better way than relying on the test
 
2973
        # parametrization to identify branch.conf -- vila 2011-0526
 
2974
        if self.store_id in ('branch', 'remote_branch'):
 
2975
            # branch stores requires write locked branches
 
2976
            self.addCleanup(store.branch.lock_write().unlock)
 
2977
        section = store.get_mutable_section(None)
 
2978
        section.set('foo', 'bar')
 
2979
        store.save()
 
2980
        modified_store = self.get_store(self)
 
2981
        sections = list(modified_store.get_sections())
 
2982
        self.assertLength(1, sections)
 
2983
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2984
 
 
2985
    def test_set_option_in_default_section(self):
 
2986
        store = self.get_store(self)
 
2987
        store._load_from_string('')
 
2988
        # FIXME: There should be a better way than relying on the test
 
2989
        # parametrization to identify branch.conf -- vila 2011-0526
 
2990
        if self.store_id in ('branch', 'remote_branch'):
 
2991
            # branch stores requires write locked branches
 
2992
            self.addCleanup(store.branch.lock_write().unlock)
 
2993
        section = store.get_mutable_section(None)
 
2994
        section.set('foo', 'bar')
 
2995
        store.save()
 
2996
        modified_store = self.get_store(self)
 
2997
        sections = list(modified_store.get_sections())
 
2998
        self.assertLength(1, sections)
 
2999
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
3000
 
 
3001
    def test_set_option_in_named_section(self):
 
3002
        store = self.get_store(self)
 
3003
        store._load_from_string('')
 
3004
        # FIXME: There should be a better way than relying on the test
 
3005
        # parametrization to identify branch.conf -- vila 2011-0526
 
3006
        if self.store_id in ('branch', 'remote_branch'):
 
3007
            # branch stores requires write locked branches
 
3008
            self.addCleanup(store.branch.lock_write().unlock)
 
3009
        section = store.get_mutable_section('baz')
 
3010
        section.set('foo', 'bar')
 
3011
        store.save()
 
3012
        modified_store = self.get_store(self)
 
3013
        sections = list(modified_store.get_sections())
 
3014
        self.assertLength(1, sections)
 
3015
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
 
3016
 
 
3017
    def test_load_hook(self):
 
3018
        # First, we need to ensure that the store exists
 
3019
        store = self.get_store(self)
 
3020
        # FIXME: There should be a better way than relying on the test
 
3021
        # parametrization to identify branch.conf -- vila 2011-0526
 
3022
        if self.store_id in ('branch', 'remote_branch'):
 
3023
            # branch stores requires write locked branches
 
3024
            self.addCleanup(store.branch.lock_write().unlock)
 
3025
        section = store.get_mutable_section('baz')
 
3026
        section.set('foo', 'bar')
 
3027
        store.save()
 
3028
        # Now we can try to load it
 
3029
        store = self.get_store(self)
 
3030
        calls = []
 
3031
        def hook(*args):
 
3032
            calls.append(args)
 
3033
        config.ConfigHooks.install_named_hook('load', hook, None)
 
3034
        self.assertLength(0, calls)
 
3035
        store.load()
 
3036
        self.assertLength(1, calls)
 
3037
        self.assertEquals((store,), calls[0])
 
3038
 
 
3039
    def test_save_hook(self):
 
3040
        calls = []
 
3041
        def hook(*args):
 
3042
            calls.append(args)
 
3043
        config.ConfigHooks.install_named_hook('save', hook, None)
 
3044
        self.assertLength(0, calls)
 
3045
        store = self.get_store(self)
 
3046
        # FIXME: There should be a better way than relying on the test
 
3047
        # parametrization to identify branch.conf -- vila 2011-0526
 
3048
        if self.store_id in ('branch', 'remote_branch'):
 
3049
            # branch stores requires write locked branches
 
3050
            self.addCleanup(store.branch.lock_write().unlock)
 
3051
        section = store.get_mutable_section('baz')
 
3052
        section.set('foo', 'bar')
 
3053
        store.save()
 
3054
        self.assertLength(1, calls)
 
3055
        self.assertEquals((store,), calls[0])
 
3056
 
 
3057
    def test_set_mark_dirty(self):
 
3058
        stack = config.MemoryStack('')
 
3059
        self.assertLength(0, stack.store.dirty_sections)
 
3060
        stack.set('foo', 'baz')
 
3061
        self.assertLength(1, stack.store.dirty_sections)
 
3062
        self.assertTrue(stack.store._need_saving())
 
3063
 
 
3064
    def test_remove_mark_dirty(self):
 
3065
        stack = config.MemoryStack('foo=bar')
 
3066
        self.assertLength(0, stack.store.dirty_sections)
 
3067
        stack.remove('foo')
 
3068
        self.assertLength(1, stack.store.dirty_sections)
 
3069
        self.assertTrue(stack.store._need_saving())
 
3070
 
 
3071
 
 
3072
class TestStoreSaveChanges(tests.TestCaseWithTransport):
 
3073
    """Tests that config changes are kept in memory and saved on-demand."""
 
3074
 
 
3075
    def setUp(self):
 
3076
        super(TestStoreSaveChanges, self).setUp()
 
3077
        self.transport = self.get_transport()
 
3078
        # Most of the tests involve two stores pointing to the same persistent
 
3079
        # storage to observe the effects of concurrent changes
 
3080
        self.st1 = config.TransportIniFileStore(self.transport, 'foo.conf')
 
3081
        self.st2 = config.TransportIniFileStore(self.transport, 'foo.conf')
 
3082
        self.warnings = []
 
3083
        def warning(*args):
 
3084
            self.warnings.append(args[0] % args[1:])
 
3085
        self.overrideAttr(trace, 'warning', warning)
 
3086
 
 
3087
    def has_store(self, store):
 
3088
        store_basename = urlutils.relative_url(self.transport.external_url(),
 
3089
                                               store.external_url())
 
3090
        return self.transport.has(store_basename)
 
3091
 
 
3092
    def get_stack(self, store):
 
3093
        # Any stack will do as long as it uses the right store, just a single
 
3094
        # no-name section is enough
 
3095
        return config.Stack([store.get_sections], store)
 
3096
 
 
3097
    def test_no_changes_no_save(self):
 
3098
        s = self.get_stack(self.st1)
 
3099
        s.store.save_changes()
 
3100
        self.assertEquals(False, self.has_store(self.st1))
 
3101
 
 
3102
    def test_unrelated_concurrent_update(self):
 
3103
        s1 = self.get_stack(self.st1)
 
3104
        s2 = self.get_stack(self.st2)
 
3105
        s1.set('foo', 'bar')
 
3106
        s2.set('baz', 'quux')
 
3107
        s1.store.save()
 
3108
        # Changes don't propagate magically
 
3109
        self.assertEquals(None, s1.get('baz'))
 
3110
        s2.store.save_changes()
 
3111
        self.assertEquals('quux', s2.get('baz'))
 
3112
        # Changes are acquired when saving
 
3113
        self.assertEquals('bar', s2.get('foo'))
 
3114
        # Since there is no overlap, no warnings are emitted
 
3115
        self.assertLength(0, self.warnings)
 
3116
 
 
3117
    def test_concurrent_update_modified(self):
 
3118
        s1 = self.get_stack(self.st1)
 
3119
        s2 = self.get_stack(self.st2)
 
3120
        s1.set('foo', 'bar')
 
3121
        s2.set('foo', 'baz')
 
3122
        s1.store.save()
 
3123
        # Last speaker wins
 
3124
        s2.store.save_changes()
 
3125
        self.assertEquals('baz', s2.get('foo'))
 
3126
        # But the user get a warning
 
3127
        self.assertLength(1, self.warnings)
 
3128
        warning = self.warnings[0]
 
3129
        self.assertStartsWith(warning, 'Option foo in section None')
 
3130
        self.assertEndsWith(warning, 'was changed from <CREATED> to bar.'
 
3131
                            ' The baz value will be saved.')
 
3132
 
 
3133
    def test_concurrent_deletion(self):
 
3134
        self.st1._load_from_string('foo=bar')
 
3135
        self.st1.save()
 
3136
        s1 = self.get_stack(self.st1)
 
3137
        s2 = self.get_stack(self.st2)
 
3138
        s1.remove('foo')
 
3139
        s2.remove('foo')
 
3140
        s1.store.save_changes()
 
3141
        # No warning yet
 
3142
        self.assertLength(0, self.warnings)
 
3143
        s2.store.save_changes()
 
3144
        # Now we get one
 
3145
        self.assertLength(1, self.warnings)
 
3146
        warning = self.warnings[0]
 
3147
        self.assertStartsWith(warning, 'Option foo in section None')
 
3148
        self.assertEndsWith(warning, 'was changed from bar to <CREATED>.'
 
3149
                            ' The <DELETED> value will be saved.')
 
3150
 
 
3151
 
 
3152
class TestQuotingIniFileStore(tests.TestCaseWithTransport):
 
3153
 
 
3154
    def get_store(self):
 
3155
        return config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3156
 
 
3157
    def test_get_quoted_string(self):
 
3158
        store = self.get_store()
 
3159
        store._load_from_string('foo= " abc "')
 
3160
        stack = config.Stack([store.get_sections])
 
3161
        self.assertEquals(' abc ', stack.get('foo'))
 
3162
 
 
3163
    def test_set_quoted_string(self):
 
3164
        store = self.get_store()
 
3165
        stack = config.Stack([store.get_sections], store)
 
3166
        stack.set('foo', ' a b c ')
 
3167
        store.save()
 
3168
        self.assertFileEqual('foo = " a b c "' + os.linesep, 'foo.conf')
 
3169
 
 
3170
 
 
3171
class TestTransportIniFileStore(TestStore):
 
3172
 
 
3173
    def test_loading_unknown_file_fails(self):
 
3174
        store = config.TransportIniFileStore(self.get_transport(),
 
3175
            'I-do-not-exist')
 
3176
        self.assertRaises(errors.NoSuchFile, store.load)
 
3177
 
 
3178
    def test_invalid_content(self):
 
3179
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3180
        self.assertEquals(False, store.is_loaded())
 
3181
        exc = self.assertRaises(
 
3182
            errors.ParseConfigError, store._load_from_string,
 
3183
            'this is invalid !')
 
3184
        self.assertEndsWith(exc.filename, 'foo.conf')
 
3185
        # And the load failed
 
3186
        self.assertEquals(False, store.is_loaded())
 
3187
 
 
3188
    def test_get_embedded_sections(self):
 
3189
        # A more complicated example (which also shows that section names and
 
3190
        # option names share the same name space...)
 
3191
        # FIXME: This should be fixed by forbidding dicts as values ?
 
3192
        # -- vila 2011-04-05
 
3193
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3194
        store._load_from_string('''
 
3195
foo=bar
 
3196
l=1,2
 
3197
[DEFAULT]
 
3198
foo_in_DEFAULT=foo_DEFAULT
 
3199
[bar]
 
3200
foo_in_bar=barbar
 
3201
[baz]
 
3202
foo_in_baz=barbaz
 
3203
[[qux]]
 
3204
foo_in_qux=quux
 
3205
''')
 
3206
        sections = list(store.get_sections())
 
3207
        self.assertLength(4, sections)
 
3208
        # The default section has no name.
 
3209
        # List values are provided as strings and need to be explicitly
 
3210
        # converted by specifying from_unicode=list_from_store at option
 
3211
        # registration
 
3212
        self.assertSectionContent((None, {'foo': 'bar', 'l': u'1,2'}),
 
3213
                                  sections[0])
 
3214
        self.assertSectionContent(
 
3215
            ('DEFAULT', {'foo_in_DEFAULT': 'foo_DEFAULT'}), sections[1])
 
3216
        self.assertSectionContent(
 
3217
            ('bar', {'foo_in_bar': 'barbar'}), sections[2])
 
3218
        # sub sections are provided as embedded dicts.
 
3219
        self.assertSectionContent(
 
3220
            ('baz', {'foo_in_baz': 'barbaz', 'qux': {'foo_in_qux': 'quux'}}),
 
3221
            sections[3])
 
3222
 
 
3223
 
 
3224
class TestLockableIniFileStore(TestStore):
 
3225
 
 
3226
    def test_create_store_in_created_dir(self):
 
3227
        self.assertPathDoesNotExist('dir')
 
3228
        t = self.get_transport('dir/subdir')
 
3229
        store = config.LockableIniFileStore(t, 'foo.conf')
 
3230
        store.get_mutable_section(None).set('foo', 'bar')
 
3231
        store.save()
 
3232
        self.assertPathExists('dir/subdir')
 
3233
 
 
3234
 
 
3235
class TestConcurrentStoreUpdates(TestStore):
 
3236
    """Test that Stores properly handle conccurent updates.
 
3237
 
 
3238
    New Store implementation may fail some of these tests but until such
 
3239
    implementations exist it's hard to properly filter them from the scenarios
 
3240
    applied here. If you encounter such a case, contact the bzr devs.
 
3241
    """
 
3242
 
 
3243
    scenarios = [(key, {'get_stack': builder}) for key, builder
 
3244
                 in config.test_stack_builder_registry.iteritems()]
 
3245
 
 
3246
    def setUp(self):
 
3247
        super(TestConcurrentStoreUpdates, self).setUp()
 
3248
        self.stack = self.get_stack(self)
 
3249
        if not isinstance(self.stack, config._CompatibleStack):
 
3250
            raise tests.TestNotApplicable(
 
3251
                '%s is not meant to be compatible with the old config design'
 
3252
                % (self.stack,))
 
3253
        self.stack.set('one', '1')
 
3254
        self.stack.set('two', '2')
 
3255
        # Flush the store
 
3256
        self.stack.store.save()
 
3257
 
 
3258
    def test_simple_read_access(self):
 
3259
        self.assertEquals('1', self.stack.get('one'))
 
3260
 
 
3261
    def test_simple_write_access(self):
 
3262
        self.stack.set('one', 'one')
 
3263
        self.assertEquals('one', self.stack.get('one'))
 
3264
 
 
3265
    def test_listen_to_the_last_speaker(self):
 
3266
        c1 = self.stack
 
3267
        c2 = self.get_stack(self)
 
3268
        c1.set('one', 'ONE')
 
3269
        c2.set('two', 'TWO')
 
3270
        self.assertEquals('ONE', c1.get('one'))
 
3271
        self.assertEquals('TWO', c2.get('two'))
 
3272
        # The second update respect the first one
 
3273
        self.assertEquals('ONE', c2.get('one'))
 
3274
 
 
3275
    def test_last_speaker_wins(self):
 
3276
        # If the same config is not shared, the same variable modified twice
 
3277
        # can only see a single result.
 
3278
        c1 = self.stack
 
3279
        c2 = self.get_stack(self)
 
3280
        c1.set('one', 'c1')
 
3281
        c2.set('one', 'c2')
 
3282
        self.assertEquals('c2', c2.get('one'))
 
3283
        # The first modification is still available until another refresh
 
3284
        # occur
 
3285
        self.assertEquals('c1', c1.get('one'))
 
3286
        c1.set('two', 'done')
 
3287
        self.assertEquals('c2', c1.get('one'))
 
3288
 
 
3289
    def test_writes_are_serialized(self):
 
3290
        c1 = self.stack
 
3291
        c2 = self.get_stack(self)
 
3292
 
 
3293
        # We spawn a thread that will pause *during* the config saving.
 
3294
        before_writing = threading.Event()
 
3295
        after_writing = threading.Event()
 
3296
        writing_done = threading.Event()
 
3297
        c1_save_without_locking_orig = c1.store.save_without_locking
 
3298
        def c1_save_without_locking():
 
3299
            before_writing.set()
 
3300
            c1_save_without_locking_orig()
 
3301
            # The lock is held. We wait for the main thread to decide when to
 
3302
            # continue
 
3303
            after_writing.wait()
 
3304
        c1.store.save_without_locking = c1_save_without_locking
 
3305
        def c1_set():
 
3306
            c1.set('one', 'c1')
 
3307
            writing_done.set()
 
3308
        t1 = threading.Thread(target=c1_set)
 
3309
        # Collect the thread after the test
 
3310
        self.addCleanup(t1.join)
 
3311
        # Be ready to unblock the thread if the test goes wrong
 
3312
        self.addCleanup(after_writing.set)
 
3313
        t1.start()
 
3314
        before_writing.wait()
 
3315
        self.assertRaises(errors.LockContention,
 
3316
                          c2.set, 'one', 'c2')
 
3317
        self.assertEquals('c1', c1.get('one'))
 
3318
        # Let the lock be released
 
3319
        after_writing.set()
 
3320
        writing_done.wait()
 
3321
        c2.set('one', 'c2')
 
3322
        self.assertEquals('c2', c2.get('one'))
 
3323
 
 
3324
    def test_read_while_writing(self):
 
3325
       c1 = self.stack
 
3326
       # We spawn a thread that will pause *during* the write
 
3327
       ready_to_write = threading.Event()
 
3328
       do_writing = threading.Event()
 
3329
       writing_done = threading.Event()
 
3330
       # We override the _save implementation so we know the store is locked
 
3331
       c1_save_without_locking_orig = c1.store.save_without_locking
 
3332
       def c1_save_without_locking():
 
3333
           ready_to_write.set()
 
3334
           # The lock is held. We wait for the main thread to decide when to
 
3335
           # continue
 
3336
           do_writing.wait()
 
3337
           c1_save_without_locking_orig()
 
3338
           writing_done.set()
 
3339
       c1.store.save_without_locking = c1_save_without_locking
 
3340
       def c1_set():
 
3341
           c1.set('one', 'c1')
 
3342
       t1 = threading.Thread(target=c1_set)
 
3343
       # Collect the thread after the test
 
3344
       self.addCleanup(t1.join)
 
3345
       # Be ready to unblock the thread if the test goes wrong
 
3346
       self.addCleanup(do_writing.set)
 
3347
       t1.start()
 
3348
       # Ensure the thread is ready to write
 
3349
       ready_to_write.wait()
 
3350
       self.assertEquals('c1', c1.get('one'))
 
3351
       # If we read during the write, we get the old value
 
3352
       c2 = self.get_stack(self)
 
3353
       self.assertEquals('1', c2.get('one'))
 
3354
       # Let the writing occur and ensure it occurred
 
3355
       do_writing.set()
 
3356
       writing_done.wait()
 
3357
       # Now we get the updated value
 
3358
       c3 = self.get_stack(self)
 
3359
       self.assertEquals('c1', c3.get('one'))
 
3360
 
 
3361
    # FIXME: It may be worth looking into removing the lock dir when it's not
 
3362
    # needed anymore and look at possible fallouts for concurrent lockers. This
 
3363
    # will matter if/when we use config files outside of bazaar directories
 
3364
    # (.bazaar or .bzr) -- vila 20110-04-111
 
3365
 
 
3366
 
 
3367
class TestSectionMatcher(TestStore):
 
3368
 
 
3369
    scenarios = [('location', {'matcher': config.LocationMatcher}),
 
3370
                 ('id', {'matcher': config.NameMatcher}),]
 
3371
 
 
3372
    def setUp(self):
 
3373
        super(TestSectionMatcher, self).setUp()
 
3374
        # Any simple store is good enough
 
3375
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3376
 
 
3377
    def test_no_matches_for_empty_stores(self):
 
3378
        store = self.get_store(self)
 
3379
        store._load_from_string('')
 
3380
        matcher = self.matcher(store, '/bar')
 
3381
        self.assertEquals([], list(matcher.get_sections()))
 
3382
 
 
3383
    def test_build_doesnt_load_store(self):
 
3384
        store = self.get_store(self)
 
3385
        self.matcher(store, '/bar')
 
3386
        self.assertFalse(store.is_loaded())
 
3387
 
 
3388
 
 
3389
class TestLocationSection(tests.TestCase):
 
3390
 
 
3391
    def get_section(self, options, extra_path):
 
3392
        section = config.Section('foo', options)
 
3393
        return config.LocationSection(section, extra_path)
 
3394
 
 
3395
    def test_simple_option(self):
 
3396
        section = self.get_section({'foo': 'bar'}, '')
 
3397
        self.assertEquals('bar', section.get('foo'))
 
3398
 
 
3399
    def test_option_with_extra_path(self):
 
3400
        section = self.get_section({'foo': 'bar', 'foo:policy': 'appendpath'},
 
3401
                                   'baz')
 
3402
        self.assertEquals('bar/baz', section.get('foo'))
 
3403
 
 
3404
    def test_invalid_policy(self):
 
3405
        section = self.get_section({'foo': 'bar', 'foo:policy': 'die'},
 
3406
                                   'baz')
 
3407
        # invalid policies are ignored
 
3408
        self.assertEquals('bar', section.get('foo'))
 
3409
 
 
3410
 
 
3411
class TestLocationMatcher(TestStore):
 
3412
 
 
3413
    def setUp(self):
 
3414
        super(TestLocationMatcher, self).setUp()
 
3415
        # Any simple store is good enough
 
3416
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3417
 
 
3418
    def test_unrelated_section_excluded(self):
 
3419
        store = self.get_store(self)
 
3420
        store._load_from_string('''
 
3421
[/foo]
 
3422
section=/foo
 
3423
[/foo/baz]
 
3424
section=/foo/baz
 
3425
[/foo/bar]
 
3426
section=/foo/bar
 
3427
[/foo/bar/baz]
 
3428
section=/foo/bar/baz
 
3429
[/quux/quux]
 
3430
section=/quux/quux
 
3431
''')
 
3432
        self.assertEquals(['/foo', '/foo/baz', '/foo/bar', '/foo/bar/baz',
 
3433
                           '/quux/quux'],
 
3434
                          [section.id for _, section in store.get_sections()])
 
3435
        matcher = config.LocationMatcher(store, '/foo/bar/quux')
 
3436
        sections = [section for _, section in matcher.get_sections()]
 
3437
        self.assertEquals(['/foo/bar', '/foo'],
 
3438
                          [section.id for section in sections])
 
3439
        self.assertEquals(['quux', 'bar/quux'],
 
3440
                          [section.extra_path for section in sections])
 
3441
 
 
3442
    def test_more_specific_sections_first(self):
 
3443
        store = self.get_store(self)
 
3444
        store._load_from_string('''
 
3445
[/foo]
 
3446
section=/foo
 
3447
[/foo/bar]
 
3448
section=/foo/bar
 
3449
''')
 
3450
        self.assertEquals(['/foo', '/foo/bar'],
 
3451
                          [section.id for _, section in store.get_sections()])
 
3452
        matcher = config.LocationMatcher(store, '/foo/bar/baz')
 
3453
        sections = [section for _, section in matcher.get_sections()]
 
3454
        self.assertEquals(['/foo/bar', '/foo'],
 
3455
                          [section.id for section in sections])
 
3456
        self.assertEquals(['baz', 'bar/baz'],
 
3457
                          [section.extra_path for section in sections])
 
3458
 
 
3459
    def test_appendpath_in_no_name_section(self):
 
3460
        # It's a bit weird to allow appendpath in a no-name section, but
 
3461
        # someone may found a use for it
 
3462
        store = self.get_store(self)
 
3463
        store._load_from_string('''
 
3464
foo=bar
 
3465
foo:policy = appendpath
 
3466
''')
 
3467
        matcher = config.LocationMatcher(store, 'dir/subdir')
 
3468
        sections = list(matcher.get_sections())
 
3469
        self.assertLength(1, sections)
 
3470
        self.assertEquals('bar/dir/subdir', sections[0][1].get('foo'))
 
3471
 
 
3472
    def test_file_urls_are_normalized(self):
 
3473
        store = self.get_store(self)
 
3474
        if sys.platform == 'win32':
 
3475
            expected_url = 'file:///C:/dir/subdir'
 
3476
            expected_location = 'C:/dir/subdir'
 
3477
        else:
 
3478
            expected_url = 'file:///dir/subdir'
 
3479
            expected_location = '/dir/subdir'
 
3480
        matcher = config.LocationMatcher(store, expected_url)
 
3481
        self.assertEquals(expected_location, matcher.location)
 
3482
 
 
3483
    def test_branch_name_colo(self):
 
3484
        store = self.get_store(self)
 
3485
        store._load_from_string(dedent("""\
 
3486
            [/]
 
3487
            push_location=my{branchname}
 
3488
        """))
 
3489
        matcher = config.LocationMatcher(store, 'file:///,branch=example%3c')
 
3490
        self.assertEqual('example<', matcher.branch_name)
 
3491
        ((_, section),) = matcher.get_sections()
 
3492
        self.assertEqual('example<', section.locals['branchname'])
 
3493
 
 
3494
    def test_branch_name_basename(self):
 
3495
        store = self.get_store(self)
 
3496
        store._load_from_string(dedent("""\
 
3497
            [/]
 
3498
            push_location=my{branchname}
 
3499
        """))
 
3500
        matcher = config.LocationMatcher(store, 'file:///parent/example%3c')
 
3501
        self.assertEqual('example<', matcher.branch_name)
 
3502
        ((_, section),) = matcher.get_sections()
 
3503
        self.assertEqual('example<', section.locals['branchname'])
 
3504
 
 
3505
 
 
3506
class TestStartingPathMatcher(TestStore):
 
3507
 
 
3508
    def setUp(self):
 
3509
        super(TestStartingPathMatcher, self).setUp()
 
3510
        # Any simple store is good enough
 
3511
        self.store = config.IniFileStore()
 
3512
 
 
3513
    def assertSectionIDs(self, expected, location, content):
 
3514
        self.store._load_from_string(content)
 
3515
        matcher = config.StartingPathMatcher(self.store, location)
 
3516
        sections = list(matcher.get_sections())
 
3517
        self.assertLength(len(expected), sections)
 
3518
        self.assertEqual(expected, [section.id for _, section in sections])
 
3519
        return sections
 
3520
 
 
3521
    def test_empty(self):
 
3522
        self.assertSectionIDs([], self.get_url(), '')
 
3523
 
 
3524
    def test_url_vs_local_paths(self):
 
3525
        # The matcher location is an url and the section names are local paths
 
3526
        self.assertSectionIDs(['/foo/bar', '/foo'],
 
3527
                              'file:///foo/bar/baz', '''\
 
3528
[/foo]
 
3529
[/foo/bar]
 
3530
''')
 
3531
 
 
3532
    def test_local_path_vs_url(self):
 
3533
        # The matcher location is a local path and the section names are urls
 
3534
        self.assertSectionIDs(['file:///foo/bar', 'file:///foo'],
 
3535
                              '/foo/bar/baz', '''\
 
3536
[file:///foo]
 
3537
[file:///foo/bar]
 
3538
''')
 
3539
 
 
3540
 
 
3541
    def test_no_name_section_included_when_present(self):
 
3542
        # Note that other tests will cover the case where the no-name section
 
3543
        # is empty and as such, not included.
 
3544
        sections = self.assertSectionIDs(['/foo/bar', '/foo', None],
 
3545
                                         '/foo/bar/baz', '''\
 
3546
option = defined so the no-name section exists
 
3547
[/foo]
 
3548
[/foo/bar]
 
3549
''')
 
3550
        self.assertEquals(['baz', 'bar/baz', '/foo/bar/baz'],
 
3551
                          [s.locals['relpath'] for _, s in sections])
 
3552
 
 
3553
    def test_order_reversed(self):
 
3554
        self.assertSectionIDs(['/foo/bar', '/foo'], '/foo/bar/baz', '''\
 
3555
[/foo]
 
3556
[/foo/bar]
 
3557
''')
 
3558
 
 
3559
    def test_unrelated_section_excluded(self):
 
3560
        self.assertSectionIDs(['/foo/bar', '/foo'], '/foo/bar/baz', '''\
 
3561
[/foo]
 
3562
[/foo/qux]
 
3563
[/foo/bar]
 
3564
''')
 
3565
 
 
3566
    def test_glob_included(self):
 
3567
        sections = self.assertSectionIDs(['/foo/*/baz', '/foo/b*', '/foo'],
 
3568
                                         '/foo/bar/baz', '''\
 
3569
[/foo]
 
3570
[/foo/qux]
 
3571
[/foo/b*]
 
3572
[/foo/*/baz]
 
3573
''')
 
3574
        # Note that 'baz' as a relpath for /foo/b* is not fully correct, but
 
3575
        # nothing really is... as far using {relpath} to append it to something
 
3576
        # else, this seems good enough though.
 
3577
        self.assertEquals(['', 'baz', 'bar/baz'],
 
3578
                          [s.locals['relpath'] for _, s in sections])
 
3579
 
 
3580
    def test_respect_order(self):
 
3581
        self.assertSectionIDs(['/foo', '/foo/b*', '/foo/*/baz'],
 
3582
                              '/foo/bar/baz', '''\
 
3583
[/foo/*/baz]
 
3584
[/foo/qux]
 
3585
[/foo/b*]
 
3586
[/foo]
 
3587
''')
 
3588
 
 
3589
 
 
3590
class TestNameMatcher(TestStore):
 
3591
 
 
3592
    def setUp(self):
 
3593
        super(TestNameMatcher, self).setUp()
 
3594
        self.matcher = config.NameMatcher
 
3595
        # Any simple store is good enough
 
3596
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3597
 
 
3598
    def get_matching_sections(self, name):
 
3599
        store = self.get_store(self)
 
3600
        store._load_from_string('''
 
3601
[foo]
 
3602
option=foo
 
3603
[foo/baz]
 
3604
option=foo/baz
 
3605
[bar]
 
3606
option=bar
 
3607
''')
 
3608
        matcher = self.matcher(store, name)
 
3609
        return list(matcher.get_sections())
 
3610
 
 
3611
    def test_matching(self):
 
3612
        sections = self.get_matching_sections('foo')
 
3613
        self.assertLength(1, sections)
 
3614
        self.assertSectionContent(('foo', {'option': 'foo'}), sections[0])
 
3615
 
 
3616
    def test_not_matching(self):
 
3617
        sections = self.get_matching_sections('baz')
 
3618
        self.assertLength(0, sections)
 
3619
 
 
3620
 
 
3621
class TestBaseStackGet(tests.TestCase):
 
3622
 
 
3623
    def setUp(self):
 
3624
        super(TestBaseStackGet, self).setUp()
 
3625
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3626
 
 
3627
    def test_get_first_definition(self):
 
3628
        store1 = config.IniFileStore()
 
3629
        store1._load_from_string('foo=bar')
 
3630
        store2 = config.IniFileStore()
 
3631
        store2._load_from_string('foo=baz')
 
3632
        conf = config.Stack([store1.get_sections, store2.get_sections])
 
3633
        self.assertEquals('bar', conf.get('foo'))
 
3634
 
 
3635
    def test_get_with_registered_default_value(self):
 
3636
        config.option_registry.register(config.Option('foo', default='bar'))
 
3637
        conf_stack = config.Stack([])
 
3638
        self.assertEquals('bar', conf_stack.get('foo'))
 
3639
 
 
3640
    def test_get_without_registered_default_value(self):
 
3641
        config.option_registry.register(config.Option('foo'))
 
3642
        conf_stack = config.Stack([])
 
3643
        self.assertEquals(None, conf_stack.get('foo'))
 
3644
 
 
3645
    def test_get_without_default_value_for_not_registered(self):
 
3646
        conf_stack = config.Stack([])
 
3647
        self.assertEquals(None, conf_stack.get('foo'))
 
3648
 
 
3649
    def test_get_for_empty_section_callable(self):
 
3650
        conf_stack = config.Stack([lambda : []])
 
3651
        self.assertEquals(None, conf_stack.get('foo'))
 
3652
 
 
3653
    def test_get_for_broken_callable(self):
 
3654
        # Trying to use and invalid callable raises an exception on first use
 
3655
        conf_stack = config.Stack([object])
 
3656
        self.assertRaises(TypeError, conf_stack.get, 'foo')
 
3657
 
 
3658
 
 
3659
class TestStackWithSimpleStore(tests.TestCase):
 
3660
 
 
3661
    def setUp(self):
 
3662
        super(TestStackWithSimpleStore, self).setUp()
 
3663
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3664
        self.registry = config.option_registry
 
3665
 
 
3666
    def get_conf(self, content=None):
 
3667
        return config.MemoryStack(content)
 
3668
 
 
3669
    def test_override_value_from_env(self):
 
3670
        self.overrideEnv('FOO', None)
 
3671
        self.registry.register(
 
3672
            config.Option('foo', default='bar', override_from_env=['FOO']))
 
3673
        self.overrideEnv('FOO', 'quux')
 
3674
        # Env variable provides a default taking over the option one
 
3675
        conf = self.get_conf('foo=store')
 
3676
        self.assertEquals('quux', conf.get('foo'))
 
3677
 
 
3678
    def test_first_override_value_from_env_wins(self):
 
3679
        self.overrideEnv('NO_VALUE', None)
 
3680
        self.overrideEnv('FOO', None)
 
3681
        self.overrideEnv('BAZ', None)
 
3682
        self.registry.register(
 
3683
            config.Option('foo', default='bar',
 
3684
                          override_from_env=['NO_VALUE', 'FOO', 'BAZ']))
 
3685
        self.overrideEnv('FOO', 'foo')
 
3686
        self.overrideEnv('BAZ', 'baz')
 
3687
        # The first env var set wins
 
3688
        conf = self.get_conf('foo=store')
 
3689
        self.assertEquals('foo', conf.get('foo'))
 
3690
 
 
3691
 
 
3692
class TestMemoryStack(tests.TestCase):
 
3693
 
 
3694
    def test_get(self):
 
3695
        conf = config.MemoryStack('foo=bar')
 
3696
        self.assertEquals('bar', conf.get('foo'))
 
3697
 
 
3698
    def test_set(self):
 
3699
        conf = config.MemoryStack('foo=bar')
 
3700
        conf.set('foo', 'baz')
 
3701
        self.assertEquals('baz', conf.get('foo'))
 
3702
 
 
3703
    def test_no_content(self):
 
3704
        conf = config.MemoryStack()
 
3705
        # No content means no loading
 
3706
        self.assertFalse(conf.store.is_loaded())
 
3707
        self.assertRaises(NotImplementedError, conf.get, 'foo')
 
3708
        # But a content can still be provided
 
3709
        conf.store._load_from_string('foo=bar')
 
3710
        self.assertEquals('bar', conf.get('foo'))
 
3711
 
 
3712
 
 
3713
class TestStackIterSections(tests.TestCase):
 
3714
 
 
3715
    def test_empty_stack(self):
 
3716
        conf = config.Stack([])
 
3717
        sections = list(conf.iter_sections())
 
3718
        self.assertLength(0, sections)
 
3719
 
 
3720
    def test_empty_store(self):
 
3721
        store = config.IniFileStore()
 
3722
        store._load_from_string('')
 
3723
        conf = config.Stack([store.get_sections])
 
3724
        sections = list(conf.iter_sections())
 
3725
        self.assertLength(0, sections)
 
3726
 
 
3727
    def test_simple_store(self):
 
3728
        store = config.IniFileStore()
 
3729
        store._load_from_string('foo=bar')
 
3730
        conf = config.Stack([store.get_sections])
 
3731
        tuples = list(conf.iter_sections())
 
3732
        self.assertLength(1, tuples)
 
3733
        (found_store, found_section) = tuples[0]
 
3734
        self.assertIs(store, found_store)
 
3735
 
 
3736
    def test_two_stores(self):
 
3737
        store1 = config.IniFileStore()
 
3738
        store1._load_from_string('foo=bar')
 
3739
        store2 = config.IniFileStore()
 
3740
        store2._load_from_string('bar=qux')
 
3741
        conf = config.Stack([store1.get_sections, store2.get_sections])
 
3742
        tuples = list(conf.iter_sections())
 
3743
        self.assertLength(2, tuples)
 
3744
        self.assertIs(store1, tuples[0][0])
 
3745
        self.assertIs(store2, tuples[1][0])
 
3746
 
 
3747
 
 
3748
class TestStackWithTransport(tests.TestCaseWithTransport):
 
3749
 
 
3750
    scenarios = [(key, {'get_stack': builder}) for key, builder
 
3751
                 in config.test_stack_builder_registry.iteritems()]
 
3752
 
 
3753
 
 
3754
class TestConcreteStacks(TestStackWithTransport):
 
3755
 
 
3756
    def test_build_stack(self):
 
3757
        # Just a smoke test to help debug builders
 
3758
        self.get_stack(self)
 
3759
 
 
3760
 
 
3761
class TestStackGet(TestStackWithTransport):
 
3762
 
 
3763
    def setUp(self):
 
3764
        super(TestStackGet, self).setUp()
 
3765
        self.conf = self.get_stack(self)
 
3766
 
 
3767
    def test_get_for_empty_stack(self):
 
3768
        self.assertEquals(None, self.conf.get('foo'))
 
3769
 
 
3770
    def test_get_hook(self):
 
3771
        self.conf.set('foo', 'bar')
 
3772
        calls = []
 
3773
        def hook(*args):
 
3774
            calls.append(args)
 
3775
        config.ConfigHooks.install_named_hook('get', hook, None)
 
3776
        self.assertLength(0, calls)
 
3777
        value = self.conf.get('foo')
 
3778
        self.assertEquals('bar', value)
 
3779
        self.assertLength(1, calls)
 
3780
        self.assertEquals((self.conf, 'foo', 'bar'), calls[0])
 
3781
 
 
3782
 
 
3783
class TestStackGetWithConverter(tests.TestCase):
 
3784
 
 
3785
    def setUp(self):
 
3786
        super(TestStackGetWithConverter, self).setUp()
 
3787
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3788
        self.registry = config.option_registry
 
3789
 
 
3790
    def get_conf(self, content=None):
 
3791
        return config.MemoryStack(content)
 
3792
 
 
3793
    def register_bool_option(self, name, default=None, default_from_env=None):
 
3794
        b = config.Option(name, help='A boolean.',
 
3795
                          default=default, default_from_env=default_from_env,
 
3796
                          from_unicode=config.bool_from_store)
 
3797
        self.registry.register(b)
 
3798
 
 
3799
    def test_get_default_bool_None(self):
 
3800
        self.register_bool_option('foo')
 
3801
        conf = self.get_conf('')
 
3802
        self.assertEquals(None, conf.get('foo'))
 
3803
 
 
3804
    def test_get_default_bool_True(self):
 
3805
        self.register_bool_option('foo', u'True')
 
3806
        conf = self.get_conf('')
 
3807
        self.assertEquals(True, conf.get('foo'))
 
3808
 
 
3809
    def test_get_default_bool_False(self):
 
3810
        self.register_bool_option('foo', False)
 
3811
        conf = self.get_conf('')
 
3812
        self.assertEquals(False, conf.get('foo'))
 
3813
 
 
3814
    def test_get_default_bool_False_as_string(self):
 
3815
        self.register_bool_option('foo', u'False')
 
3816
        conf = self.get_conf('')
 
3817
        self.assertEquals(False, conf.get('foo'))
 
3818
 
 
3819
    def test_get_default_bool_from_env_converted(self):
 
3820
        self.register_bool_option('foo', u'True', default_from_env=['FOO'])
 
3821
        self.overrideEnv('FOO', 'False')
 
3822
        conf = self.get_conf('')
 
3823
        self.assertEquals(False, conf.get('foo'))
 
3824
 
 
3825
    def test_get_default_bool_when_conversion_fails(self):
 
3826
        self.register_bool_option('foo', default='True')
 
3827
        conf = self.get_conf('foo=invalid boolean')
 
3828
        self.assertEquals(True, conf.get('foo'))
 
3829
 
 
3830
    def register_integer_option(self, name,
 
3831
                                default=None, default_from_env=None):
 
3832
        i = config.Option(name, help='An integer.',
 
3833
                          default=default, default_from_env=default_from_env,
 
3834
                          from_unicode=config.int_from_store)
 
3835
        self.registry.register(i)
 
3836
 
 
3837
    def test_get_default_integer_None(self):
 
3838
        self.register_integer_option('foo')
 
3839
        conf = self.get_conf('')
 
3840
        self.assertEquals(None, conf.get('foo'))
 
3841
 
 
3842
    def test_get_default_integer(self):
 
3843
        self.register_integer_option('foo', 42)
 
3844
        conf = self.get_conf('')
 
3845
        self.assertEquals(42, conf.get('foo'))
 
3846
 
 
3847
    def test_get_default_integer_as_string(self):
 
3848
        self.register_integer_option('foo', u'42')
 
3849
        conf = self.get_conf('')
 
3850
        self.assertEquals(42, conf.get('foo'))
 
3851
 
 
3852
    def test_get_default_integer_from_env(self):
 
3853
        self.register_integer_option('foo', default_from_env=['FOO'])
 
3854
        self.overrideEnv('FOO', '18')
 
3855
        conf = self.get_conf('')
 
3856
        self.assertEquals(18, conf.get('foo'))
 
3857
 
 
3858
    def test_get_default_integer_when_conversion_fails(self):
 
3859
        self.register_integer_option('foo', default='12')
 
3860
        conf = self.get_conf('foo=invalid integer')
 
3861
        self.assertEquals(12, conf.get('foo'))
 
3862
 
 
3863
    def register_list_option(self, name, default=None, default_from_env=None):
 
3864
        l = config.ListOption(name, help='A list.', default=default,
 
3865
                              default_from_env=default_from_env)
 
3866
        self.registry.register(l)
 
3867
 
 
3868
    def test_get_default_list_None(self):
 
3869
        self.register_list_option('foo')
 
3870
        conf = self.get_conf('')
 
3871
        self.assertEquals(None, conf.get('foo'))
 
3872
 
 
3873
    def test_get_default_list_empty(self):
 
3874
        self.register_list_option('foo', '')
 
3875
        conf = self.get_conf('')
 
3876
        self.assertEquals([], conf.get('foo'))
 
3877
 
 
3878
    def test_get_default_list_from_env(self):
 
3879
        self.register_list_option('foo', default_from_env=['FOO'])
 
3880
        self.overrideEnv('FOO', '')
 
3881
        conf = self.get_conf('')
 
3882
        self.assertEquals([], conf.get('foo'))
 
3883
 
 
3884
    def test_get_with_list_converter_no_item(self):
 
3885
        self.register_list_option('foo', None)
 
3886
        conf = self.get_conf('foo=,')
 
3887
        self.assertEquals([], conf.get('foo'))
 
3888
 
 
3889
    def test_get_with_list_converter_many_items(self):
 
3890
        self.register_list_option('foo', None)
 
3891
        conf = self.get_conf('foo=m,o,r,e')
 
3892
        self.assertEquals(['m', 'o', 'r', 'e'], conf.get('foo'))
 
3893
 
 
3894
    def test_get_with_list_converter_embedded_spaces_many_items(self):
 
3895
        self.register_list_option('foo', None)
 
3896
        conf = self.get_conf('foo=" bar", "baz "')
 
3897
        self.assertEquals([' bar', 'baz '], conf.get('foo'))
 
3898
 
 
3899
    def test_get_with_list_converter_stripped_spaces_many_items(self):
 
3900
        self.register_list_option('foo', None)
 
3901
        conf = self.get_conf('foo= bar ,  baz ')
 
3902
        self.assertEquals(['bar', 'baz'], conf.get('foo'))
 
3903
 
 
3904
 
 
3905
class TestIterOptionRefs(tests.TestCase):
 
3906
    """iter_option_refs is a bit unusual, document some cases."""
 
3907
 
 
3908
    def assertRefs(self, expected, string):
 
3909
        self.assertEquals(expected, list(config.iter_option_refs(string)))
 
3910
 
 
3911
    def test_empty(self):
 
3912
        self.assertRefs([(False, '')], '')
 
3913
 
 
3914
    def test_no_refs(self):
 
3915
        self.assertRefs([(False, 'foo bar')], 'foo bar')
 
3916
 
 
3917
    def test_single_ref(self):
 
3918
        self.assertRefs([(False, ''), (True, '{foo}'), (False, '')], '{foo}')
 
3919
 
 
3920
    def test_broken_ref(self):
 
3921
        self.assertRefs([(False, '{foo')], '{foo')
 
3922
 
 
3923
    def test_embedded_ref(self):
 
3924
        self.assertRefs([(False, '{'), (True, '{foo}'), (False, '}')],
 
3925
                        '{{foo}}')
 
3926
 
 
3927
    def test_two_refs(self):
 
3928
        self.assertRefs([(False, ''), (True, '{foo}'),
 
3929
                         (False, ''), (True, '{bar}'),
 
3930
                         (False, ''),],
 
3931
                        '{foo}{bar}')
 
3932
 
 
3933
    def test_newline_in_refs_are_not_matched(self):
 
3934
        self.assertRefs([(False, '{\nxx}{xx\n}{{\n}}')], '{\nxx}{xx\n}{{\n}}')
 
3935
 
 
3936
 
 
3937
class TestStackExpandOptions(tests.TestCaseWithTransport):
 
3938
 
 
3939
    def setUp(self):
 
3940
        super(TestStackExpandOptions, self).setUp()
 
3941
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3942
        self.registry = config.option_registry
 
3943
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3944
        self.conf = config.Stack([store.get_sections], store)
 
3945
 
 
3946
    def assertExpansion(self, expected, string, env=None):
 
3947
        self.assertEquals(expected, self.conf.expand_options(string, env))
 
3948
 
 
3949
    def test_no_expansion(self):
 
3950
        self.assertExpansion('foo', 'foo')
 
3951
 
 
3952
    def test_expand_default_value(self):
 
3953
        self.conf.store._load_from_string('bar=baz')
 
3954
        self.registry.register(config.Option('foo', default=u'{bar}'))
 
3955
        self.assertEquals('baz', self.conf.get('foo', expand=True))
 
3956
 
 
3957
    def test_expand_default_from_env(self):
 
3958
        self.conf.store._load_from_string('bar=baz')
 
3959
        self.registry.register(config.Option('foo', default_from_env=['FOO']))
 
3960
        self.overrideEnv('FOO', '{bar}')
 
3961
        self.assertEquals('baz', self.conf.get('foo', expand=True))
 
3962
 
 
3963
    def test_expand_default_on_failed_conversion(self):
 
3964
        self.conf.store._load_from_string('baz=bogus\nbar=42\nfoo={baz}')
 
3965
        self.registry.register(
 
3966
            config.Option('foo', default=u'{bar}',
 
3967
                          from_unicode=config.int_from_store))
 
3968
        self.assertEquals(42, self.conf.get('foo', expand=True))
 
3969
 
 
3970
    def test_env_adding_options(self):
 
3971
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
 
3972
 
 
3973
    def test_env_overriding_options(self):
 
3974
        self.conf.store._load_from_string('foo=baz')
 
3975
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
 
3976
 
 
3977
    def test_simple_ref(self):
 
3978
        self.conf.store._load_from_string('foo=xxx')
 
3979
        self.assertExpansion('xxx', '{foo}')
 
3980
 
 
3981
    def test_unknown_ref(self):
 
3982
        self.assertRaises(errors.ExpandingUnknownOption,
 
3983
                          self.conf.expand_options, '{foo}')
 
3984
 
 
3985
    def test_illegal_def_is_ignored(self):
 
3986
        self.assertExpansion('{1,2}', '{1,2}')
 
3987
        self.assertExpansion('{ }', '{ }')
 
3988
        self.assertExpansion('${Foo,f}', '${Foo,f}')
 
3989
 
 
3990
    def test_indirect_ref(self):
 
3991
        self.conf.store._load_from_string('''
 
3992
foo=xxx
 
3993
bar={foo}
 
3994
''')
 
3995
        self.assertExpansion('xxx', '{bar}')
 
3996
 
 
3997
    def test_embedded_ref(self):
 
3998
        self.conf.store._load_from_string('''
 
3999
foo=xxx
 
4000
bar=foo
 
4001
''')
 
4002
        self.assertExpansion('xxx', '{{bar}}')
 
4003
 
 
4004
    def test_simple_loop(self):
 
4005
        self.conf.store._load_from_string('foo={foo}')
 
4006
        self.assertRaises(errors.OptionExpansionLoop,
 
4007
                          self.conf.expand_options, '{foo}')
 
4008
 
 
4009
    def test_indirect_loop(self):
 
4010
        self.conf.store._load_from_string('''
 
4011
foo={bar}
 
4012
bar={baz}
 
4013
baz={foo}''')
 
4014
        e = self.assertRaises(errors.OptionExpansionLoop,
 
4015
                              self.conf.expand_options, '{foo}')
 
4016
        self.assertEquals('foo->bar->baz', e.refs)
 
4017
        self.assertEquals('{foo}', e.string)
 
4018
 
 
4019
    def test_list(self):
 
4020
        self.conf.store._load_from_string('''
 
4021
foo=start
 
4022
bar=middle
 
4023
baz=end
 
4024
list={foo},{bar},{baz}
 
4025
''')
 
4026
        self.registry.register(
 
4027
            config.ListOption('list'))
 
4028
        self.assertEquals(['start', 'middle', 'end'],
 
4029
                           self.conf.get('list', expand=True))
 
4030
 
 
4031
    def test_cascading_list(self):
 
4032
        self.conf.store._load_from_string('''
 
4033
foo=start,{bar}
 
4034
bar=middle,{baz}
 
4035
baz=end
 
4036
list={foo}
 
4037
''')
 
4038
        self.registry.register(config.ListOption('list'))
 
4039
        # Register an intermediate option as a list to ensure no conversion
 
4040
        # happen while expanding. Conversion should only occur for the original
 
4041
        # option ('list' here).
 
4042
        self.registry.register(config.ListOption('baz'))
 
4043
        self.assertEquals(['start', 'middle', 'end'],
 
4044
                           self.conf.get('list', expand=True))
 
4045
 
 
4046
    def test_pathologically_hidden_list(self):
 
4047
        self.conf.store._load_from_string('''
 
4048
foo=bin
 
4049
bar=go
 
4050
start={foo
 
4051
middle=},{
 
4052
end=bar}
 
4053
hidden={start}{middle}{end}
 
4054
''')
 
4055
        # What matters is what the registration says, the conversion happens
 
4056
        # only after all expansions have been performed
 
4057
        self.registry.register(config.ListOption('hidden'))
 
4058
        self.assertEquals(['bin', 'go'],
 
4059
                          self.conf.get('hidden', expand=True))
 
4060
 
 
4061
 
 
4062
class TestStackCrossSectionsExpand(tests.TestCaseWithTransport):
 
4063
 
 
4064
    def setUp(self):
 
4065
        super(TestStackCrossSectionsExpand, self).setUp()
 
4066
 
 
4067
    def get_config(self, location, string):
 
4068
        if string is None:
 
4069
            string = ''
 
4070
        # Since we don't save the config we won't strictly require to inherit
 
4071
        # from TestCaseInTempDir, but an error occurs so quickly...
 
4072
        c = config.LocationStack(location)
 
4073
        c.store._load_from_string(string)
 
4074
        return c
 
4075
 
 
4076
    def test_dont_cross_unrelated_section(self):
 
4077
        c = self.get_config('/another/branch/path','''
 
4078
[/one/branch/path]
 
4079
foo = hello
 
4080
bar = {foo}/2
 
4081
 
 
4082
[/another/branch/path]
 
4083
bar = {foo}/2
 
4084
''')
 
4085
        self.assertRaises(errors.ExpandingUnknownOption,
 
4086
                          c.get, 'bar', expand=True)
 
4087
 
 
4088
    def test_cross_related_sections(self):
 
4089
        c = self.get_config('/project/branch/path','''
 
4090
[/project]
 
4091
foo = qu
 
4092
 
 
4093
[/project/branch/path]
 
4094
bar = {foo}ux
 
4095
''')
 
4096
        self.assertEquals('quux', c.get('bar', expand=True))
 
4097
 
 
4098
 
 
4099
class TestStackCrossStoresExpand(tests.TestCaseWithTransport):
 
4100
 
 
4101
    def test_cross_global_locations(self):
 
4102
        l_store = config.LocationStore()
 
4103
        l_store._load_from_string('''
 
4104
[/branch]
 
4105
lfoo = loc-foo
 
4106
lbar = {gbar}
 
4107
''')
 
4108
        l_store.save()
 
4109
        g_store = config.GlobalStore()
 
4110
        g_store._load_from_string('''
 
4111
[DEFAULT]
 
4112
gfoo = {lfoo}
 
4113
gbar = glob-bar
 
4114
''')
 
4115
        g_store.save()
 
4116
        stack = config.LocationStack('/branch')
 
4117
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
 
4118
        self.assertEquals('loc-foo', stack.get('gfoo', expand=True))
 
4119
 
 
4120
 
 
4121
class TestStackExpandSectionLocals(tests.TestCaseWithTransport):
 
4122
 
 
4123
    def test_expand_locals_empty(self):
 
4124
        l_store = config.LocationStore()
 
4125
        l_store._load_from_string('''
 
4126
[/home/user/project]
 
4127
base = {basename}
 
4128
rel = {relpath}
 
4129
''')
 
4130
        l_store.save()
 
4131
        stack = config.LocationStack('/home/user/project/')
 
4132
        self.assertEquals('', stack.get('base', expand=True))
 
4133
        self.assertEquals('', stack.get('rel', expand=True))
 
4134
 
 
4135
    def test_expand_basename_locally(self):
 
4136
        l_store = config.LocationStore()
 
4137
        l_store._load_from_string('''
 
4138
[/home/user/project]
 
4139
bfoo = {basename}
 
4140
''')
 
4141
        l_store.save()
 
4142
        stack = config.LocationStack('/home/user/project/branch')
 
4143
        self.assertEquals('branch', stack.get('bfoo', expand=True))
 
4144
 
 
4145
    def test_expand_basename_locally_longer_path(self):
 
4146
        l_store = config.LocationStore()
 
4147
        l_store._load_from_string('''
 
4148
[/home/user]
 
4149
bfoo = {basename}
 
4150
''')
 
4151
        l_store.save()
 
4152
        stack = config.LocationStack('/home/user/project/dir/branch')
 
4153
        self.assertEquals('branch', stack.get('bfoo', expand=True))
 
4154
 
 
4155
    def test_expand_relpath_locally(self):
 
4156
        l_store = config.LocationStore()
 
4157
        l_store._load_from_string('''
 
4158
[/home/user/project]
 
4159
lfoo = loc-foo/{relpath}
 
4160
''')
 
4161
        l_store.save()
 
4162
        stack = config.LocationStack('/home/user/project/branch')
 
4163
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
 
4164
 
 
4165
    def test_expand_relpath_unknonw_in_global(self):
 
4166
        g_store = config.GlobalStore()
 
4167
        g_store._load_from_string('''
 
4168
[DEFAULT]
 
4169
gfoo = {relpath}
 
4170
''')
 
4171
        g_store.save()
 
4172
        stack = config.LocationStack('/home/user/project/branch')
 
4173
        self.assertRaises(errors.ExpandingUnknownOption,
 
4174
                          stack.get, 'gfoo', expand=True)
 
4175
 
 
4176
    def test_expand_local_option_locally(self):
 
4177
        l_store = config.LocationStore()
 
4178
        l_store._load_from_string('''
 
4179
[/home/user/project]
 
4180
lfoo = loc-foo/{relpath}
 
4181
lbar = {gbar}
 
4182
''')
 
4183
        l_store.save()
 
4184
        g_store = config.GlobalStore()
 
4185
        g_store._load_from_string('''
 
4186
[DEFAULT]
 
4187
gfoo = {lfoo}
 
4188
gbar = glob-bar
 
4189
''')
 
4190
        g_store.save()
 
4191
        stack = config.LocationStack('/home/user/project/branch')
 
4192
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
 
4193
        self.assertEquals('loc-foo/branch', stack.get('gfoo', expand=True))
 
4194
 
 
4195
    def test_locals_dont_leak(self):
 
4196
        """Make sure we chose the right local in presence of several sections.
 
4197
        """
 
4198
        l_store = config.LocationStore()
 
4199
        l_store._load_from_string('''
 
4200
[/home/user]
 
4201
lfoo = loc-foo/{relpath}
 
4202
[/home/user/project]
 
4203
lfoo = loc-foo/{relpath}
 
4204
''')
 
4205
        l_store.save()
 
4206
        stack = config.LocationStack('/home/user/project/branch')
 
4207
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
 
4208
        stack = config.LocationStack('/home/user/bar/baz')
 
4209
        self.assertEquals('loc-foo/bar/baz', stack.get('lfoo', expand=True))
 
4210
 
 
4211
 
 
4212
 
 
4213
class TestStackSet(TestStackWithTransport):
 
4214
 
 
4215
    def test_simple_set(self):
 
4216
        conf = self.get_stack(self)
 
4217
        self.assertEquals(None, conf.get('foo'))
 
4218
        conf.set('foo', 'baz')
 
4219
        # Did we get it back ?
 
4220
        self.assertEquals('baz', conf.get('foo'))
 
4221
 
 
4222
    def test_set_creates_a_new_section(self):
 
4223
        conf = self.get_stack(self)
 
4224
        conf.set('foo', 'baz')
 
4225
        self.assertEquals, 'baz', conf.get('foo')
 
4226
 
 
4227
    def test_set_hook(self):
 
4228
        calls = []
 
4229
        def hook(*args):
 
4230
            calls.append(args)
 
4231
        config.ConfigHooks.install_named_hook('set', hook, None)
 
4232
        self.assertLength(0, calls)
 
4233
        conf = self.get_stack(self)
 
4234
        conf.set('foo', 'bar')
 
4235
        self.assertLength(1, calls)
 
4236
        self.assertEquals((conf, 'foo', 'bar'), calls[0])
 
4237
 
 
4238
 
 
4239
class TestStackRemove(TestStackWithTransport):
 
4240
 
 
4241
    def test_remove_existing(self):
 
4242
        conf = self.get_stack(self)
 
4243
        conf.set('foo', 'bar')
 
4244
        self.assertEquals('bar', conf.get('foo'))
 
4245
        conf.remove('foo')
 
4246
        # Did we get it back ?
 
4247
        self.assertEquals(None, conf.get('foo'))
 
4248
 
 
4249
    def test_remove_unknown(self):
 
4250
        conf = self.get_stack(self)
 
4251
        self.assertRaises(KeyError, conf.remove, 'I_do_not_exist')
 
4252
 
 
4253
    def test_remove_hook(self):
 
4254
        calls = []
 
4255
        def hook(*args):
 
4256
            calls.append(args)
 
4257
        config.ConfigHooks.install_named_hook('remove', hook, None)
 
4258
        self.assertLength(0, calls)
 
4259
        conf = self.get_stack(self)
 
4260
        conf.set('foo', 'bar')
 
4261
        conf.remove('foo')
 
4262
        self.assertLength(1, calls)
 
4263
        self.assertEquals((conf, 'foo'), calls[0])
 
4264
 
 
4265
 
 
4266
class TestConfigGetOptions(tests.TestCaseWithTransport, TestOptionsMixin):
 
4267
 
 
4268
    def setUp(self):
 
4269
        super(TestConfigGetOptions, self).setUp()
 
4270
        create_configs(self)
 
4271
 
 
4272
    def test_no_variable(self):
 
4273
        # Using branch should query branch, locations and bazaar
 
4274
        self.assertOptions([], self.branch_config)
 
4275
 
 
4276
    def test_option_in_bazaar(self):
 
4277
        self.bazaar_config.set_user_option('file', 'bazaar')
 
4278
        self.assertOptions([('file', 'bazaar', 'DEFAULT', 'bazaar')],
 
4279
                           self.bazaar_config)
 
4280
 
 
4281
    def test_option_in_locations(self):
 
4282
        self.locations_config.set_user_option('file', 'locations')
 
4283
        self.assertOptions(
 
4284
            [('file', 'locations', self.tree.basedir, 'locations')],
 
4285
            self.locations_config)
 
4286
 
 
4287
    def test_option_in_branch(self):
 
4288
        self.branch_config.set_user_option('file', 'branch')
 
4289
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch')],
 
4290
                           self.branch_config)
 
4291
 
 
4292
    def test_option_in_bazaar_and_branch(self):
 
4293
        self.bazaar_config.set_user_option('file', 'bazaar')
 
4294
        self.branch_config.set_user_option('file', 'branch')
 
4295
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch'),
 
4296
                            ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4297
                           self.branch_config)
 
4298
 
 
4299
    def test_option_in_branch_and_locations(self):
 
4300
        # Hmm, locations override branch :-/
 
4301
        self.locations_config.set_user_option('file', 'locations')
 
4302
        self.branch_config.set_user_option('file', 'branch')
 
4303
        self.assertOptions(
 
4304
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4305
             ('file', 'branch', 'DEFAULT', 'branch'),],
 
4306
            self.branch_config)
 
4307
 
 
4308
    def test_option_in_bazaar_locations_and_branch(self):
 
4309
        self.bazaar_config.set_user_option('file', 'bazaar')
 
4310
        self.locations_config.set_user_option('file', 'locations')
 
4311
        self.branch_config.set_user_option('file', 'branch')
 
4312
        self.assertOptions(
 
4313
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4314
             ('file', 'branch', 'DEFAULT', 'branch'),
 
4315
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4316
            self.branch_config)
 
4317
 
 
4318
 
 
4319
class TestConfigRemoveOption(tests.TestCaseWithTransport, TestOptionsMixin):
 
4320
 
 
4321
    def setUp(self):
 
4322
        super(TestConfigRemoveOption, self).setUp()
 
4323
        create_configs_with_file_option(self)
 
4324
 
 
4325
    def test_remove_in_locations(self):
 
4326
        self.locations_config.remove_user_option('file', self.tree.basedir)
 
4327
        self.assertOptions(
 
4328
            [('file', 'branch', 'DEFAULT', 'branch'),
 
4329
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4330
            self.branch_config)
 
4331
 
 
4332
    def test_remove_in_branch(self):
 
4333
        self.branch_config.remove_user_option('file')
 
4334
        self.assertOptions(
 
4335
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4336
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4337
            self.branch_config)
 
4338
 
 
4339
    def test_remove_in_bazaar(self):
 
4340
        self.bazaar_config.remove_user_option('file')
 
4341
        self.assertOptions(
 
4342
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4343
             ('file', 'branch', 'DEFAULT', 'branch'),],
 
4344
            self.branch_config)
 
4345
 
 
4346
 
 
4347
class TestConfigGetSections(tests.TestCaseWithTransport):
 
4348
 
 
4349
    def setUp(self):
 
4350
        super(TestConfigGetSections, self).setUp()
 
4351
        create_configs(self)
 
4352
 
 
4353
    def assertSectionNames(self, expected, conf, name=None):
 
4354
        """Check which sections are returned for a given config.
 
4355
 
 
4356
        If fallback configurations exist their sections can be included.
 
4357
 
 
4358
        :param expected: A list of section names.
 
4359
 
 
4360
        :param conf: The configuration that will be queried.
 
4361
 
 
4362
        :param name: An optional section name that will be passed to
 
4363
            get_sections().
 
4364
        """
 
4365
        sections = list(conf._get_sections(name))
 
4366
        self.assertLength(len(expected), sections)
 
4367
        self.assertEqual(expected, [n for n, _, _ in sections])
 
4368
 
 
4369
    def test_bazaar_default_section(self):
 
4370
        self.assertSectionNames(['DEFAULT'], self.bazaar_config)
 
4371
 
 
4372
    def test_locations_default_section(self):
 
4373
        # No sections are defined in an empty file
 
4374
        self.assertSectionNames([], self.locations_config)
 
4375
 
 
4376
    def test_locations_named_section(self):
 
4377
        self.locations_config.set_user_option('file', 'locations')
 
4378
        self.assertSectionNames([self.tree.basedir], self.locations_config)
 
4379
 
 
4380
    def test_locations_matching_sections(self):
 
4381
        loc_config = self.locations_config
 
4382
        loc_config.set_user_option('file', 'locations')
 
4383
        # We need to cheat a bit here to create an option in sections above and
 
4384
        # below the 'location' one.
 
4385
        parser = loc_config._get_parser()
 
4386
        # locations.cong deals with '/' ignoring native os.sep
 
4387
        location_names = self.tree.basedir.split('/')
 
4388
        parent = '/'.join(location_names[:-1])
 
4389
        child = '/'.join(location_names + ['child'])
 
4390
        parser[parent] = {}
 
4391
        parser[parent]['file'] = 'parent'
 
4392
        parser[child] = {}
 
4393
        parser[child]['file'] = 'child'
 
4394
        self.assertSectionNames([self.tree.basedir, parent], loc_config)
 
4395
 
 
4396
    def test_branch_data_default_section(self):
 
4397
        self.assertSectionNames([None],
 
4398
                                self.branch_config._get_branch_data_config())
 
4399
 
 
4400
    def test_branch_default_sections(self):
 
4401
        # No sections are defined in an empty locations file
 
4402
        self.assertSectionNames([None, 'DEFAULT'],
 
4403
                                self.branch_config)
 
4404
        # Unless we define an option
 
4405
        self.branch_config._get_location_config().set_user_option(
 
4406
            'file', 'locations')
 
4407
        self.assertSectionNames([self.tree.basedir, None, 'DEFAULT'],
 
4408
                                self.branch_config)
 
4409
 
 
4410
    def test_bazaar_named_section(self):
 
4411
        # We need to cheat as the API doesn't give direct access to sections
 
4412
        # other than DEFAULT.
 
4413
        self.bazaar_config.set_alias('bazaar', 'bzr')
 
4414
        self.assertSectionNames(['ALIASES'], self.bazaar_config, 'ALIASES')
 
4415
 
 
4416
 
 
4417
class TestSharedStores(tests.TestCaseInTempDir):
 
4418
 
 
4419
    def test_bazaar_conf_shared(self):
 
4420
        g1 = config.GlobalStack()
 
4421
        g2 = config.GlobalStack()
 
4422
        # The two stacks share the same store
 
4423
        self.assertIs(g1.store, g2.store)
 
4424
 
 
4425
 
1474
4426
class TestAuthenticationConfigFile(tests.TestCase):
1475
4427
    """Test the authentication.conf file matching"""
1476
4428
 
1491
4443
        self.assertEquals({}, conf._get_config())
1492
4444
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
1493
4445
 
 
4446
    def test_non_utf8_config(self):
 
4447
        conf = config.AuthenticationConfig(_file=StringIO(
 
4448
                'foo = bar\xff'))
 
4449
        self.assertRaises(errors.ConfigContentError, conf._get_config)
 
4450
 
1494
4451
    def test_missing_auth_section_header(self):
1495
4452
        conf = config.AuthenticationConfig(_file=StringIO('foo = bar'))
1496
4453
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
1686
4643
                                           port=99, path='/foo',
1687
4644
                                           realm='realm')
1688
4645
        CREDENTIALS = {'name': 'name', 'user': 'user', 'password': 'password',
1689
 
                       'verify_certificates': False, 'scheme': 'scheme', 
1690
 
                       'host': 'host', 'port': 99, 'path': '/foo', 
 
4646
                       'verify_certificates': False, 'scheme': 'scheme',
 
4647
                       'host': 'host', 'port': 99, 'path': '/foo',
1691
4648
                       'realm': 'realm'}
1692
4649
        self.assertEqual(CREDENTIALS, credentials)
1693
4650
        credentials_from_disk = config.AuthenticationConfig().get_credentials(
1701
4658
        self.assertIs(None, conf._get_config().get('name'))
1702
4659
        credentials = conf.get_credentials(host='host', scheme='scheme')
1703
4660
        CREDENTIALS = {'name': 'name2', 'user': 'user2', 'password':
1704
 
                       'password', 'verify_certificates': True, 
1705
 
                       'scheme': 'scheme', 'host': 'host', 'port': None, 
 
4661
                       'password', 'verify_certificates': True,
 
4662
                       'scheme': 'scheme', 'host': 'host', 'port': None,
1706
4663
                       'path': None, 'realm': None}
1707
4664
        self.assertEqual(CREDENTIALS, credentials)
1708
4665
 
1754
4711
 
1755
4712
    def test_username_defaults_prompts(self):
1756
4713
        # HTTP prompts can't be tested here, see test_http.py
1757
 
        self._check_default_username_prompt('FTP %(host)s username: ', 'ftp')
1758
 
        self._check_default_username_prompt(
1759
 
            'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
1760
 
        self._check_default_username_prompt(
1761
 
            'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
 
4714
        self._check_default_username_prompt(u'FTP %(host)s username: ', 'ftp')
 
4715
        self._check_default_username_prompt(
 
4716
            u'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
 
4717
        self._check_default_username_prompt(
 
4718
            u'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
1762
4719
 
1763
4720
    def test_username_default_no_prompt(self):
1764
4721
        conf = config.AuthenticationConfig()
1770
4727
    def test_password_default_prompts(self):
1771
4728
        # HTTP prompts can't be tested here, see test_http.py
1772
4729
        self._check_default_password_prompt(
1773
 
            'FTP %(user)s@%(host)s password: ', 'ftp')
1774
 
        self._check_default_password_prompt(
1775
 
            'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
1776
 
        self._check_default_password_prompt(
1777
 
            'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
 
4730
            u'FTP %(user)s@%(host)s password: ', 'ftp')
 
4731
        self._check_default_password_prompt(
 
4732
            u'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
 
4733
        self._check_default_password_prompt(
 
4734
            u'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
1778
4735
        # SMTP port handling is a bit special (it's handled if embedded in the
1779
4736
        # host too)
1780
4737
        # FIXME: should we: forbid that, extend it to other schemes, leave
1781
4738
        # things as they are that's fine thank you ?
1782
 
        self._check_default_password_prompt('SMTP %(user)s@%(host)s password: ',
1783
 
                                            'smtp')
1784
 
        self._check_default_password_prompt('SMTP %(user)s@%(host)s password: ',
1785
 
                                            'smtp', host='bar.org:10025')
1786
 
        self._check_default_password_prompt(
1787
 
            'SMTP %(user)s@%(host)s:%(port)d password: ',
1788
 
            'smtp', port=10025)
 
4739
        self._check_default_password_prompt(
 
4740
            u'SMTP %(user)s@%(host)s password: ', 'smtp')
 
4741
        self._check_default_password_prompt(
 
4742
            u'SMTP %(user)s@%(host)s password: ', 'smtp', host='bar.org:10025')
 
4743
        self._check_default_password_prompt(
 
4744
            u'SMTP %(user)s@%(host)s:%(port)d password: ', 'smtp', port=10025)
1789
4745
 
1790
4746
    def test_ssh_password_emits_warning(self):
1791
4747
        conf = config.AuthenticationConfig(_file=StringIO(
1961
4917
        self.assertEquals('secret', decoded)
1962
4918
 
1963
4919
 
 
4920
class TestBase64CredentialStore(tests.TestCase):
 
4921
 
 
4922
    def test_decode_password(self):
 
4923
        r = config.credential_store_registry
 
4924
        plain_text = r.get_credential_store('base64')
 
4925
        decoded = plain_text.decode_password(dict(password='c2VjcmV0'))
 
4926
        self.assertEquals('secret', decoded)
 
4927
 
 
4928
 
1964
4929
# FIXME: Once we have a way to declare authentication to all test servers, we
1965
4930
# can implement generic tests.
1966
4931
# test_user_password_in_url
1971
4936
# test_user_prompted ?
1972
4937
class TestAuthenticationRing(tests.TestCaseWithTransport):
1973
4938
    pass
 
4939
 
 
4940
 
 
4941
class TestAutoUserId(tests.TestCase):
 
4942
    """Test inferring an automatic user name."""
 
4943
 
 
4944
    def test_auto_user_id(self):
 
4945
        """Automatic inference of user name.
 
4946
 
 
4947
        This is a bit hard to test in an isolated way, because it depends on
 
4948
        system functions that go direct to /etc or perhaps somewhere else.
 
4949
        But it's reasonable to say that on Unix, with an /etc/mailname, we ought
 
4950
        to be able to choose a user name with no configuration.
 
4951
        """
 
4952
        if sys.platform == 'win32':
 
4953
            raise tests.TestSkipped(
 
4954
                "User name inference not implemented on win32")
 
4955
        realname, address = config._auto_user_id()
 
4956
        if os.path.exists('/etc/mailname'):
 
4957
            self.assertIsNot(None, realname)
 
4958
            self.assertIsNot(None, address)
 
4959
        else:
 
4960
            self.assertEquals((None, None), (realname, address))
 
4961
 
 
4962
 
 
4963
class TestDefaultMailDomain(tests.TestCaseInTempDir):
 
4964
    """Test retrieving default domain from mailname file"""
 
4965
 
 
4966
    def test_default_mail_domain_simple(self):
 
4967
        f = file('simple', 'w')
 
4968
        try:
 
4969
            f.write("domainname.com\n")
 
4970
        finally:
 
4971
            f.close()
 
4972
        r = config._get_default_mail_domain('simple')
 
4973
        self.assertEquals('domainname.com', r)
 
4974
 
 
4975
    def test_default_mail_domain_no_eol(self):
 
4976
        f = file('no_eol', 'w')
 
4977
        try:
 
4978
            f.write("domainname.com")
 
4979
        finally:
 
4980
            f.close()
 
4981
        r = config._get_default_mail_domain('no_eol')
 
4982
        self.assertEquals('domainname.com', r)
 
4983
 
 
4984
    def test_default_mail_domain_multiple_lines(self):
 
4985
        f = file('multiple_lines', 'w')
 
4986
        try:
 
4987
            f.write("domainname.com\nsome other text\n")
 
4988
        finally:
 
4989
            f.close()
 
4990
        r = config._get_default_mail_domain('multiple_lines')
 
4991
        self.assertEquals('domainname.com', r)
 
4992
 
 
4993
 
 
4994
class EmailOptionTests(tests.TestCase):
 
4995
 
 
4996
    def test_default_email_uses_BZR_EMAIL(self):
 
4997
        conf = config.MemoryStack('email=jelmer@debian.org')
 
4998
        # BZR_EMAIL takes precedence over EMAIL
 
4999
        self.overrideEnv('BZR_EMAIL', 'jelmer@samba.org')
 
5000
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
 
5001
        self.assertEquals('jelmer@samba.org', conf.get('email'))
 
5002
 
 
5003
    def test_default_email_uses_EMAIL(self):
 
5004
        conf = config.MemoryStack('')
 
5005
        self.overrideEnv('BZR_EMAIL', None)
 
5006
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
 
5007
        self.assertEquals('jelmer@apache.org', conf.get('email'))
 
5008
 
 
5009
    def test_BZR_EMAIL_overrides(self):
 
5010
        conf = config.MemoryStack('email=jelmer@debian.org')
 
5011
        self.overrideEnv('BZR_EMAIL', 'jelmer@apache.org')
 
5012
        self.assertEquals('jelmer@apache.org', conf.get('email'))
 
5013
        self.overrideEnv('BZR_EMAIL', None)
 
5014
        self.overrideEnv('EMAIL', 'jelmer@samba.org')
 
5015
        self.assertEquals('jelmer@debian.org', conf.get('email'))
 
5016
 
 
5017
 
 
5018
class MailClientOptionTests(tests.TestCase):
 
5019
 
 
5020
    def test_default(self):
 
5021
        conf = config.MemoryStack('')
 
5022
        client = conf.get('mail_client')
 
5023
        self.assertIs(client, mail_client.DefaultMail)
 
5024
 
 
5025
    def test_evolution(self):
 
5026
        conf = config.MemoryStack('mail_client=evolution')
 
5027
        client = conf.get('mail_client')
 
5028
        self.assertIs(client, mail_client.Evolution)
 
5029
 
 
5030
    def test_kmail(self):
 
5031
        conf = config.MemoryStack('mail_client=kmail')
 
5032
        client = conf.get('mail_client')
 
5033
        self.assertIs(client, mail_client.KMail)
 
5034
 
 
5035
    def test_mutt(self):
 
5036
        conf = config.MemoryStack('mail_client=mutt')
 
5037
        client = conf.get('mail_client')
 
5038
        self.assertIs(client, mail_client.Mutt)
 
5039
 
 
5040
    def test_thunderbird(self):
 
5041
        conf = config.MemoryStack('mail_client=thunderbird')
 
5042
        client = conf.get('mail_client')
 
5043
        self.assertIs(client, mail_client.Thunderbird)
 
5044
 
 
5045
    def test_explicit_default(self):
 
5046
        conf = config.MemoryStack('mail_client=default')
 
5047
        client = conf.get('mail_client')
 
5048
        self.assertIs(client, mail_client.DefaultMail)
 
5049
 
 
5050
    def test_editor(self):
 
5051
        conf = config.MemoryStack('mail_client=editor')
 
5052
        client = conf.get('mail_client')
 
5053
        self.assertIs(client, mail_client.Editor)
 
5054
 
 
5055
    def test_mapi(self):
 
5056
        conf = config.MemoryStack('mail_client=mapi')
 
5057
        client = conf.get('mail_client')
 
5058
        self.assertIs(client, mail_client.MAPIClient)
 
5059
 
 
5060
    def test_xdg_email(self):
 
5061
        conf = config.MemoryStack('mail_client=xdg-email')
 
5062
        client = conf.get('mail_client')
 
5063
        self.assertIs(client, mail_client.XDGEmail)
 
5064
 
 
5065
    def test_unknown(self):
 
5066
        conf = config.MemoryStack('mail_client=firebird')
 
5067
        self.assertRaises(errors.ConfigOptionValueError, conf.get,
 
5068
                'mail_client')