~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_http.py

  • Committer: Colin Watson
  • Date: 2015-07-02 11:30:47 UTC
  • mto: This revision was merged to the branch mainline in revision 6605.
  • Revision ID: cjwatson@canonical.com-20150702113047-359s4zsi07wvfwso
UseĀ assertLength.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
23
23
# TODO: Should be renamed to bzrlib.transport.http.tests?
24
24
# TODO: What about renaming to bzrlib.tests.transport.http ?
25
25
 
26
 
from cStringIO import StringIO
27
26
import httplib
28
 
import os
29
 
import select
30
27
import SimpleHTTPServer
31
28
import socket
32
29
import sys
34
31
 
35
32
import bzrlib
36
33
from bzrlib import (
37
 
    bzrdir,
38
34
    config,
 
35
    controldir,
 
36
    debug,
39
37
    errors,
40
38
    osutils,
41
39
    remote as _mod_remote,
42
40
    tests,
 
41
    trace,
43
42
    transport,
44
43
    ui,
45
 
    urlutils,
46
 
    )
47
 
from bzrlib.symbol_versioning import (
48
 
    deprecated_in,
49
44
    )
50
45
from bzrlib.tests import (
51
46
    features,
52
47
    http_server,
53
48
    http_utils,
 
49
    test_server,
 
50
    )
 
51
from bzrlib.tests.scenarios import (
 
52
    load_tests_apply_scenarios,
 
53
    multiply_scenarios,
54
54
    )
55
55
from bzrlib.transport import (
56
56
    http,
66
66
    from bzrlib.transport.http._pycurl import PyCurlTransport
67
67
 
68
68
 
69
 
def load_tests(standard_tests, module, loader):
70
 
    """Multiply tests for http clients and protocol versions."""
71
 
    result = loader.suiteClass()
72
 
 
73
 
    # one for each transport implementation
74
 
    t_tests, remaining_tests = tests.split_suite_by_condition(
75
 
        standard_tests, tests.condition_isinstance((
76
 
                TestHttpTransportRegistration,
77
 
                TestHttpTransportUrls,
78
 
                Test_redirected_to,
79
 
                )))
 
69
load_tests = load_tests_apply_scenarios
 
70
 
 
71
 
 
72
def vary_by_http_client_implementation():
 
73
    """Test the two libraries we can use, pycurl and urllib."""
80
74
    transport_scenarios = [
81
75
        ('urllib', dict(_transport=_urllib.HttpTransport_urllib,
82
76
                        _server=http_server.HttpServer_urllib,
83
 
                        _qualified_prefix='http+urllib',)),
 
77
                        _url_protocol='http+urllib',)),
84
78
        ]
85
79
    if features.pycurl.available():
86
80
        transport_scenarios.append(
87
81
            ('pycurl', dict(_transport=PyCurlTransport,
88
82
                            _server=http_server.HttpServer_PyCurl,
89
 
                            _qualified_prefix='http+pycurl',)))
90
 
    tests.multiply_tests(t_tests, transport_scenarios, result)
91
 
 
92
 
    # each implementation tested with each HTTP version
93
 
    tp_tests, remaining_tests = tests.split_suite_by_condition(
94
 
        remaining_tests, tests.condition_isinstance((
95
 
                SmartHTTPTunnellingTest,
96
 
                TestDoCatchRedirections,
97
 
                TestHTTPConnections,
98
 
                TestHTTPRedirections,
99
 
                TestHTTPSilentRedirections,
100
 
                TestLimitedRangeRequestServer,
101
 
                TestPost,
102
 
                TestProxyHttpServer,
103
 
                TestRanges,
104
 
                TestSpecificRequestHandler,
105
 
                )))
106
 
    protocol_scenarios = [
107
 
            ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
108
 
            ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
109
 
            ]
110
 
    tp_scenarios = tests.multiply_scenarios(transport_scenarios,
111
 
                                            protocol_scenarios)
112
 
    tests.multiply_tests(tp_tests, tp_scenarios, result)
113
 
 
114
 
    # proxy auth: each auth scheme on all http versions on all implementations.
115
 
    tppa_tests, remaining_tests = tests.split_suite_by_condition(
116
 
        remaining_tests, tests.condition_isinstance((
117
 
                TestProxyAuth,
118
 
                )))
119
 
    proxy_auth_scheme_scenarios = [
120
 
        ('basic', dict(_auth_server=http_utils.ProxyBasicAuthServer)),
121
 
        ('digest', dict(_auth_server=http_utils.ProxyDigestAuthServer)),
122
 
        ('basicdigest',
123
 
         dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
 
83
                            _url_protocol='http+pycurl',)))
 
84
    return transport_scenarios
 
85
 
 
86
 
 
87
def vary_by_http_protocol_version():
 
88
    """Test on http/1.0 and 1.1"""
 
89
    return [
 
90
        ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
 
91
        ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
124
92
        ]
125
 
    tppa_scenarios = tests.multiply_scenarios(tp_scenarios,
126
 
                                              proxy_auth_scheme_scenarios)
127
 
    tests.multiply_tests(tppa_tests, tppa_scenarios, result)
128
 
 
129
 
    # auth: each auth scheme on all http versions on all implementations.
130
 
    tpa_tests, remaining_tests = tests.split_suite_by_condition(
131
 
        remaining_tests, tests.condition_isinstance((
132
 
                TestAuth,
133
 
                )))
134
 
    auth_scheme_scenarios = [
 
93
 
 
94
 
 
95
def vary_by_http_auth_scheme():
 
96
    scenarios = [
135
97
        ('basic', dict(_auth_server=http_utils.HTTPBasicAuthServer)),
136
98
        ('digest', dict(_auth_server=http_utils.HTTPDigestAuthServer)),
137
99
        ('basicdigest',
138
 
         dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
139
 
        ]
140
 
    tpa_scenarios = tests.multiply_scenarios(tp_scenarios,
141
 
                                             auth_scheme_scenarios)
142
 
    tests.multiply_tests(tpa_tests, tpa_scenarios, result)
143
 
 
144
 
    # activity: on all http[s] versions on all implementations
145
 
    tpact_tests, remaining_tests = tests.split_suite_by_condition(
146
 
        remaining_tests, tests.condition_isinstance((
147
 
                TestActivity,
148
 
                )))
 
100
            dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
 
101
        ]
 
102
    # Add some attributes common to all scenarios
 
103
    for scenario_id, scenario_dict in scenarios:
 
104
        scenario_dict.update(_auth_header='Authorization',
 
105
                             _username_prompt_prefix='',
 
106
                             _password_prompt_prefix='')
 
107
    return scenarios
 
108
 
 
109
 
 
110
def vary_by_http_proxy_auth_scheme():
 
111
    scenarios = [
 
112
        ('proxy-basic', dict(_auth_server=http_utils.ProxyBasicAuthServer)),
 
113
        ('proxy-digest', dict(_auth_server=http_utils.ProxyDigestAuthServer)),
 
114
        ('proxy-basicdigest',
 
115
            dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
 
116
        ]
 
117
    # Add some attributes common to all scenarios
 
118
    for scenario_id, scenario_dict in scenarios:
 
119
        scenario_dict.update(_auth_header='Proxy-Authorization',
 
120
                             _username_prompt_prefix='Proxy ',
 
121
                             _password_prompt_prefix='Proxy ')
 
122
    return scenarios
 
123
 
 
124
 
 
125
def vary_by_http_activity():
149
126
    activity_scenarios = [
150
127
        ('urllib,http', dict(_activity_server=ActivityHTTPServer,
151
 
                             _transport=_urllib.HttpTransport_urllib,)),
 
128
                            _transport=_urllib.HttpTransport_urllib,)),
152
129
        ]
153
 
    if tests.HTTPSServerFeature.available():
 
130
    if features.pycurl.available():
 
131
        activity_scenarios.append(
 
132
            ('pycurl,http', dict(_activity_server=ActivityHTTPServer,
 
133
                                _transport=PyCurlTransport,)),)
 
134
    if features.HTTPSServerFeature.available():
 
135
        # FIXME: Until we have a better way to handle self-signed certificates
 
136
        # (like allowing them in a test specific authentication.conf for
 
137
        # example), we need some specialized pycurl/urllib transport for tests.
 
138
        # -- vila 2012-01-20
 
139
        from bzrlib.tests import (
 
140
            ssl_certs,
 
141
            )
 
142
        class HTTPS_urllib_transport(_urllib.HttpTransport_urllib):
 
143
 
 
144
            def __init__(self, base, _from_transport=None):
 
145
                super(HTTPS_urllib_transport, self).__init__(
 
146
                    base, _from_transport=_from_transport,
 
147
                    ca_certs=ssl_certs.build_path('ca.crt'))
 
148
 
154
149
        activity_scenarios.append(
155
150
            ('urllib,https', dict(_activity_server=ActivityHTTPSServer,
156
 
                                  _transport=_urllib.HttpTransport_urllib,)),)
157
 
    if features.pycurl.available():
158
 
        activity_scenarios.append(
159
 
            ('pycurl,http', dict(_activity_server=ActivityHTTPServer,
160
 
                                 _transport=PyCurlTransport,)),)
161
 
        if tests.HTTPSServerFeature.available():
162
 
            from bzrlib.tests import (
163
 
                ssl_certs,
164
 
                )
165
 
            # FIXME: Until we have a better way to handle self-signed
166
 
            # certificates (like allowing them in a test specific
167
 
            # authentication.conf for example), we need some specialized pycurl
168
 
            # transport for tests.
 
151
                                  _transport=HTTPS_urllib_transport,)),)
 
152
        if features.pycurl.available():
169
153
            class HTTPS_pycurl_transport(PyCurlTransport):
170
154
 
171
155
                def __init__(self, base, _from_transport=None):
175
159
 
176
160
            activity_scenarios.append(
177
161
                ('pycurl,https', dict(_activity_server=ActivityHTTPSServer,
178
 
                                      _transport=HTTPS_pycurl_transport,)),)
179
 
 
180
 
    tpact_scenarios = tests.multiply_scenarios(activity_scenarios,
181
 
                                               protocol_scenarios)
182
 
    tests.multiply_tests(tpact_tests, tpact_scenarios, result)
183
 
 
184
 
    # No parametrization for the remaining tests
185
 
    result.addTests(remaining_tests)
186
 
 
187
 
    return result
 
162
                                    _transport=HTTPS_pycurl_transport,)),)
 
163
    return activity_scenarios
188
164
 
189
165
 
190
166
class FakeManager(object):
223
199
        self._sock.bind(('127.0.0.1', 0))
224
200
        self.host, self.port = self._sock.getsockname()
225
201
        self._ready = threading.Event()
226
 
        self._thread = threading.Thread(target=self._accept_read_and_reply)
227
 
        self._thread.setDaemon(True)
 
202
        self._thread = test_server.TestThread(
 
203
            sync_event=self._ready, target=self._accept_read_and_reply)
228
204
        self._thread.start()
229
 
        self._ready.wait(5)
 
205
        if 'threads' in tests.selftest_debug_flags:
 
206
            sys.stderr.write('Thread started: %s\n' % (self._thread.ident,))
 
207
        self._ready.wait()
230
208
 
231
209
    def _accept_read_and_reply(self):
232
210
        self._sock.listen(1)
233
211
        self._ready.set()
234
 
        self._sock.settimeout(5)
235
 
        try:
236
 
            conn, address = self._sock.accept()
237
 
            # On win32, the accepted connection will be non-blocking to start
238
 
            # with because we're using settimeout.
239
 
            conn.setblocking(True)
 
212
        conn, address = self._sock.accept()
 
213
        if self._expect_body_tail is not None:
240
214
            while not self.received_bytes.endswith(self._expect_body_tail):
241
215
                self.received_bytes += conn.recv(4096)
242
216
            conn.sendall('HTTP/1.1 200 OK\r\n')
243
 
        except socket.timeout:
244
 
            # Make sure the client isn't stuck waiting for us to e.g. accept.
 
217
        try:
245
218
            self._sock.close()
246
219
        except socket.error:
247
220
            # The client may have already closed the socket.
249
222
 
250
223
    def stop_server(self):
251
224
        try:
252
 
            self._sock.close()
 
225
            # Issue a fake connection to wake up the server and allow it to
 
226
            # finish quickly
 
227
            fake_conn = osutils.connect_socket((self.host, self.port))
 
228
            fake_conn.close()
253
229
        except socket.error:
254
230
            # We might have already closed it.  We don't care.
255
231
            pass
256
232
        self.host = None
257
233
        self.port = None
 
234
        self._thread.join()
 
235
        if 'threads' in tests.selftest_debug_flags:
 
236
            sys.stderr.write('Thread  joined: %s\n' % (self._thread.ident,))
258
237
 
259
238
 
260
239
class TestAuthHeader(tests.TestCase):
296
275
        self.assertEqual('realm="Thou should not pass"', remainder)
297
276
 
298
277
 
 
278
class TestHTTPRangeParsing(tests.TestCase):
 
279
 
 
280
    def setUp(self):
 
281
        super(TestHTTPRangeParsing, self).setUp()
 
282
        # We focus on range  parsing here and ignore everything else
 
283
        class RequestHandler(http_server.TestingHTTPRequestHandler):
 
284
            def setup(self): pass
 
285
            def handle(self): pass
 
286
            def finish(self): pass
 
287
 
 
288
        self.req_handler = RequestHandler(None, None, None)
 
289
 
 
290
    def assertRanges(self, ranges, header, file_size):
 
291
        self.assertEquals(ranges,
 
292
                          self.req_handler._parse_ranges(header, file_size))
 
293
 
 
294
    def test_simple_range(self):
 
295
        self.assertRanges([(0,2)], 'bytes=0-2', 12)
 
296
 
 
297
    def test_tail(self):
 
298
        self.assertRanges([(8, 11)], 'bytes=-4', 12)
 
299
 
 
300
    def test_tail_bigger_than_file(self):
 
301
        self.assertRanges([(0, 11)], 'bytes=-99', 12)
 
302
 
 
303
    def test_range_without_end(self):
 
304
        self.assertRanges([(4, 11)], 'bytes=4-', 12)
 
305
 
 
306
    def test_invalid_ranges(self):
 
307
        self.assertRanges(None, 'bytes=12-22', 12)
 
308
        self.assertRanges(None, 'bytes=1-3,12-22', 12)
 
309
        self.assertRanges(None, 'bytes=-', 12)
 
310
 
 
311
 
299
312
class TestHTTPServer(tests.TestCase):
300
313
    """Test the HTTP servers implementations."""
301
314
 
304
317
 
305
318
            protocol_version = 'HTTP/0.1'
306
319
 
307
 
        server = http_server.HttpServer(BogusRequestHandler)
308
 
        try:
309
 
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
310
 
        except:
311
 
            server.stop_server()
312
 
            self.fail('HTTP Server creation did not raise UnknownProtocol')
 
320
        self.assertRaises(httplib.UnknownProtocol,
 
321
                          http_server.HttpServer, BogusRequestHandler)
313
322
 
314
323
    def test_force_invalid_protocol(self):
315
 
        server = http_server.HttpServer(protocol_version='HTTP/0.1')
316
 
        try:
317
 
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
318
 
        except:
319
 
            server.stop_server()
320
 
            self.fail('HTTP Server creation did not raise UnknownProtocol')
 
324
        self.assertRaises(httplib.UnknownProtocol,
 
325
                          http_server.HttpServer, protocol_version='HTTP/0.1')
321
326
 
322
327
    def test_server_start_and_stop(self):
323
328
        server = http_server.HttpServer()
 
329
        self.addCleanup(server.stop_server)
324
330
        server.start_server()
325
 
        try:
326
 
            self.assertTrue(server._http_running)
327
 
        finally:
328
 
            server.stop_server()
329
 
        self.assertFalse(server._http_running)
 
331
        self.assertTrue(server.server is not None)
 
332
        self.assertTrue(server.server.serving is not None)
 
333
        self.assertTrue(server.server.serving)
330
334
 
331
335
    def test_create_http_server_one_zero(self):
332
336
        class RequestHandlerOneZero(http_server.TestingHTTPRequestHandler):
335
339
 
336
340
        server = http_server.HttpServer(RequestHandlerOneZero)
337
341
        self.start_server(server)
338
 
        self.assertIsInstance(server._httpd, http_server.TestingHTTPServer)
 
342
        self.assertIsInstance(server.server, http_server.TestingHTTPServer)
339
343
 
340
344
    def test_create_http_server_one_one(self):
341
345
        class RequestHandlerOneOne(http_server.TestingHTTPRequestHandler):
344
348
 
345
349
        server = http_server.HttpServer(RequestHandlerOneOne)
346
350
        self.start_server(server)
347
 
        self.assertIsInstance(server._httpd,
 
351
        self.assertIsInstance(server.server,
348
352
                              http_server.TestingThreadingHTTPServer)
349
353
 
350
354
    def test_create_http_server_force_one_one(self):
355
359
        server = http_server.HttpServer(RequestHandlerOneZero,
356
360
                                        protocol_version='HTTP/1.1')
357
361
        self.start_server(server)
358
 
        self.assertIsInstance(server._httpd,
 
362
        self.assertIsInstance(server.server,
359
363
                              http_server.TestingThreadingHTTPServer)
360
364
 
361
365
    def test_create_http_server_force_one_zero(self):
366
370
        server = http_server.HttpServer(RequestHandlerOneOne,
367
371
                                        protocol_version='HTTP/1.0')
368
372
        self.start_server(server)
369
 
        self.assertIsInstance(server._httpd,
 
373
        self.assertIsInstance(server.server,
370
374
                              http_server.TestingHTTPServer)
371
375
 
372
376
 
380
384
    _transport = property(_get_pycurl_maybe)
381
385
 
382
386
 
383
 
class TestHttpUrls(tests.TestCase):
384
 
 
385
 
    # TODO: This should be moved to authorization tests once they
386
 
    # are written.
387
 
 
388
 
    def test_url_parsing(self):
389
 
        f = FakeManager()
390
 
        url = http.extract_auth('http://example.com', f)
391
 
        self.assertEqual('http://example.com', url)
392
 
        self.assertEqual(0, len(f.credentials))
393
 
        url = http.extract_auth(
394
 
            'http://user:pass@example.com/bzr/bzr.dev', f)
395
 
        self.assertEqual('http://example.com/bzr/bzr.dev', url)
396
 
        self.assertEqual(1, len(f.credentials))
397
 
        self.assertEqual([None, 'example.com', 'user', 'pass'],
398
 
                         f.credentials[0])
399
 
 
400
 
 
401
387
class TestHttpTransportUrls(tests.TestCase):
402
388
    """Test the http urls."""
403
389
 
 
390
    scenarios = vary_by_http_client_implementation()
 
391
 
404
392
    def test_abs_url(self):
405
393
        """Construction of absolute http URLs"""
406
 
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
 
394
        t = self._transport('http://example.com/bzr/bzr.dev/')
407
395
        eq = self.assertEqualDiff
408
 
        eq(t.abspath('.'), 'http://bazaar-vcs.org/bzr/bzr.dev')
409
 
        eq(t.abspath('foo/bar'), 'http://bazaar-vcs.org/bzr/bzr.dev/foo/bar')
410
 
        eq(t.abspath('.bzr'), 'http://bazaar-vcs.org/bzr/bzr.dev/.bzr')
 
396
        eq(t.abspath('.'), 'http://example.com/bzr/bzr.dev')
 
397
        eq(t.abspath('foo/bar'), 'http://example.com/bzr/bzr.dev/foo/bar')
 
398
        eq(t.abspath('.bzr'), 'http://example.com/bzr/bzr.dev/.bzr')
411
399
        eq(t.abspath('.bzr/1//2/./3'),
412
 
           'http://bazaar-vcs.org/bzr/bzr.dev/.bzr/1/2/3')
 
400
           'http://example.com/bzr/bzr.dev/.bzr/1/2/3')
413
401
 
414
402
    def test_invalid_http_urls(self):
415
403
        """Trap invalid construction of urls"""
416
 
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
 
404
        self._transport('http://example.com/bzr/bzr.dev/')
417
405
        self.assertRaises(errors.InvalidURL,
418
406
                          self._transport,
419
 
                          'http://http://bazaar-vcs.org/bzr/bzr.dev/')
 
407
                          'http://http://example.com/bzr/bzr.dev/')
420
408
 
421
409
    def test_http_root_urls(self):
422
410
        """Construction of URLs from server root"""
423
 
        t = self._transport('http://bzr.ozlabs.org/')
 
411
        t = self._transport('http://example.com/')
424
412
        eq = self.assertEqualDiff
425
413
        eq(t.abspath('.bzr/tree-version'),
426
 
           'http://bzr.ozlabs.org/.bzr/tree-version')
 
414
           'http://example.com/.bzr/tree-version')
427
415
 
428
416
    def test_http_impl_urls(self):
429
417
        """There are servers which ask for particular clients to connect"""
431
419
        server.start_server()
432
420
        try:
433
421
            url = server.get_url()
434
 
            self.assertTrue(url.startswith('%s://' % self._qualified_prefix))
 
422
            self.assertTrue(url.startswith('%s://' % self._url_protocol))
435
423
        finally:
436
424
            server.stop_server()
437
425
 
475
463
class TestHTTPConnections(http_utils.TestCaseWithWebserver):
476
464
    """Test the http connections."""
477
465
 
 
466
    scenarios = multiply_scenarios(
 
467
        vary_by_http_client_implementation(),
 
468
        vary_by_http_protocol_version(),
 
469
        )
 
470
 
478
471
    def setUp(self):
479
 
        http_utils.TestCaseWithWebserver.setUp(self)
 
472
        super(TestHTTPConnections, self).setUp()
480
473
        self.build_tree(['foo/', 'foo/bar'], line_endings='binary',
481
474
                        transport=self.get_transport())
482
475
 
483
476
    def test_http_has(self):
484
477
        server = self.get_readonly_server()
485
 
        t = self._transport(server.get_url())
 
478
        t = self.get_readonly_transport()
486
479
        self.assertEqual(t.has('foo/bar'), True)
487
480
        self.assertEqual(len(server.logs), 1)
488
481
        self.assertContainsRe(server.logs[0],
490
483
 
491
484
    def test_http_has_not_found(self):
492
485
        server = self.get_readonly_server()
493
 
        t = self._transport(server.get_url())
 
486
        t = self.get_readonly_transport()
494
487
        self.assertEqual(t.has('not-found'), False)
495
488
        self.assertContainsRe(server.logs[1],
496
489
            r'"HEAD /not-found HTTP/1.." 404 - "-" "bzr/')
497
490
 
498
491
    def test_http_get(self):
499
492
        server = self.get_readonly_server()
500
 
        t = self._transport(server.get_url())
 
493
        t = self.get_readonly_transport()
501
494
        fp = t.get('foo/bar')
502
495
        self.assertEqualDiff(
503
496
            fp.read(),
525
518
class TestHttpTransportRegistration(tests.TestCase):
526
519
    """Test registrations of various http implementations"""
527
520
 
 
521
    scenarios = vary_by_http_client_implementation()
 
522
 
528
523
    def test_http_registered(self):
529
 
        t = transport.get_transport('%s://foo.com/' % self._qualified_prefix)
 
524
        t = transport.get_transport_from_url(
 
525
            '%s://foo.com/' % self._url_protocol)
530
526
        self.assertIsInstance(t, transport.Transport)
531
527
        self.assertIsInstance(t, self._transport)
532
528
 
533
529
 
534
530
class TestPost(tests.TestCase):
535
531
 
 
532
    scenarios = multiply_scenarios(
 
533
        vary_by_http_client_implementation(),
 
534
        vary_by_http_protocol_version(),
 
535
        )
 
536
 
536
537
    def test_post_body_is_received(self):
537
538
        server = RecordingServer(expect_body_tail='end-of-body',
538
 
            scheme=self._qualified_prefix)
 
539
                                 scheme=self._url_protocol)
539
540
        self.start_server(server)
540
541
        url = server.get_url()
541
 
        http_transport = self._transport(url)
 
542
        # FIXME: needs a cleanup -- vila 20100611
 
543
        http_transport = transport.get_transport_from_url(url)
542
544
        code, response = http_transport._post('abc def end-of-body')
543
545
        self.assertTrue(
544
546
            server.received_bytes.startswith('POST /.bzr/smart HTTP/1.'))
545
547
        self.assertTrue('content-length: 19\r' in server.received_bytes.lower())
 
548
        self.assertTrue('content-type: application/octet-stream\r'
 
549
                        in server.received_bytes.lower())
546
550
        # The transport should not be assuming that the server can accept
547
551
        # chunked encoding the first time it connects, because HTTP/1.1, so we
548
552
        # check for the literal string.
584
588
    Daughter classes are expected to override _req_handler_class
585
589
    """
586
590
 
 
591
    scenarios = multiply_scenarios(
 
592
        vary_by_http_client_implementation(),
 
593
        vary_by_http_protocol_version(),
 
594
        )
 
595
 
587
596
    # Provide a useful default
588
597
    _req_handler_class = http_server.TestingHTTPRequestHandler
589
598
 
590
599
    def create_transport_readonly_server(self):
591
 
        return http_server.HttpServer(self._req_handler_class,
592
 
                                      protocol_version=self._protocol_version)
 
600
        server = http_server.HttpServer(self._req_handler_class,
 
601
                                        protocol_version=self._protocol_version)
 
602
        server._url_protocol = self._url_protocol
 
603
        return server
593
604
 
594
605
    def _testing_pycurl(self):
595
606
        # TODO: This is duplicated for lots of the classes in this file
600
611
class WallRequestHandler(http_server.TestingHTTPRequestHandler):
601
612
    """Whatever request comes in, close the connection"""
602
613
 
603
 
    def handle_one_request(self):
 
614
    def _handle_one_request(self):
604
615
        """Handle a single HTTP request, by abruptly closing the connection"""
605
616
        self.close_connection = 1
606
617
 
611
622
    _req_handler_class = WallRequestHandler
612
623
 
613
624
    def test_http_has(self):
614
 
        server = self.get_readonly_server()
615
 
        t = self._transport(server.get_url())
 
625
        t = self.get_readonly_transport()
616
626
        # Unfortunately httplib (see HTTPResponse._read_status
617
627
        # for details) make no distinction between a closed
618
628
        # socket and badly formatted status line, so we can't
624
634
                          t.has, 'foo/bar')
625
635
 
626
636
    def test_http_get(self):
627
 
        server = self.get_readonly_server()
628
 
        t = self._transport(server.get_url())
 
637
        t = self.get_readonly_transport()
629
638
        self.assertRaises((errors.ConnectionError, errors.ConnectionReset,
630
639
                           errors.InvalidHttpResponse),
631
640
                          t.get, 'foo/bar')
648
657
    _req_handler_class = BadStatusRequestHandler
649
658
 
650
659
    def test_http_has(self):
651
 
        server = self.get_readonly_server()
652
 
        t = self._transport(server.get_url())
 
660
        t = self.get_readonly_transport()
653
661
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
654
662
 
655
663
    def test_http_get(self):
656
 
        server = self.get_readonly_server()
657
 
        t = self._transport(server.get_url())
 
664
        t = self.get_readonly_transport()
658
665
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
659
666
 
660
667
 
665
672
        """Fakes handling a single HTTP request, returns a bad status"""
666
673
        ignored = http_server.TestingHTTPRequestHandler.parse_request(self)
667
674
        self.wfile.write("Invalid status line\r\n")
 
675
        # If we don't close the connection pycurl will hang. Since this is a
 
676
        # stress test we don't *have* to respect the protocol, but we don't
 
677
        # have to sabotage it too much either.
 
678
        self.close_connection = True
668
679
        return False
669
680
 
670
681
 
676
687
 
677
688
    _req_handler_class = InvalidStatusRequestHandler
678
689
 
679
 
    def test_http_has(self):
680
 
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
681
 
            raise tests.KnownFailure(
682
 
                'pycurl hangs if the server send back garbage')
683
 
        super(TestInvalidStatusServer, self).test_http_has()
684
 
 
685
 
    def test_http_get(self):
686
 
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
687
 
            raise tests.KnownFailure(
688
 
                'pycurl hangs if the server send back garbage')
689
 
        super(TestInvalidStatusServer, self).test_http_get()
690
 
 
691
690
 
692
691
class BadProtocolRequestHandler(http_server.TestingHTTPRequestHandler):
693
692
    """Whatever request comes in, returns a bad protocol version"""
715
714
        super(TestBadProtocolServer, self).setUp()
716
715
 
717
716
    def test_http_has(self):
718
 
        server = self.get_readonly_server()
719
 
        t = self._transport(server.get_url())
 
717
        t = self.get_readonly_transport()
720
718
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
721
719
 
722
720
    def test_http_get(self):
723
 
        server = self.get_readonly_server()
724
 
        t = self._transport(server.get_url())
 
721
        t = self.get_readonly_transport()
725
722
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
726
723
 
727
724
 
741
738
    _req_handler_class = ForbiddenRequestHandler
742
739
 
743
740
    def test_http_has(self):
744
 
        server = self.get_readonly_server()
745
 
        t = self._transport(server.get_url())
 
741
        t = self.get_readonly_transport()
746
742
        self.assertRaises(errors.TransportError, t.has, 'foo/bar')
747
743
 
748
744
    def test_http_get(self):
749
 
        server = self.get_readonly_server()
750
 
        t = self._transport(server.get_url())
 
745
        t = self.get_readonly_transport()
751
746
        self.assertRaises(errors.TransportError, t.get, 'foo/bar')
752
747
 
753
748
 
792
787
        self.build_tree_contents([('a', '0123456789')],)
793
788
 
794
789
    def test_readv(self):
795
 
        server = self.get_readonly_server()
796
 
        t = self._transport(server.get_url())
 
790
        t = self.get_readonly_transport()
797
791
        l = list(t.readv('a', ((0, 1), (1, 1), (3, 2), (9, 1))))
798
792
        self.assertEqual(l[0], (0, '0'))
799
793
        self.assertEqual(l[1], (1, '1'))
801
795
        self.assertEqual(l[3], (9, '9'))
802
796
 
803
797
    def test_readv_out_of_order(self):
804
 
        server = self.get_readonly_server()
805
 
        t = self._transport(server.get_url())
 
798
        t = self.get_readonly_transport()
806
799
        l = list(t.readv('a', ((1, 1), (9, 1), (0, 1), (3, 2))))
807
800
        self.assertEqual(l[0], (1, '1'))
808
801
        self.assertEqual(l[1], (9, '9'))
810
803
        self.assertEqual(l[3], (3, '34'))
811
804
 
812
805
    def test_readv_invalid_ranges(self):
813
 
        server = self.get_readonly_server()
814
 
        t = self._transport(server.get_url())
 
806
        t = self.get_readonly_transport()
815
807
 
816
808
        # This is intentionally reading off the end of the file
817
809
        # since we are sure that it cannot get there
825
817
 
826
818
    def test_readv_multiple_get_requests(self):
827
819
        server = self.get_readonly_server()
828
 
        t = self._transport(server.get_url())
 
820
        t = self.get_readonly_transport()
829
821
        # force transport to issue multiple requests
830
822
        t._max_readv_combine = 1
831
823
        t._max_get_ranges = 1
839
831
 
840
832
    def test_readv_get_max_size(self):
841
833
        server = self.get_readonly_server()
842
 
        t = self._transport(server.get_url())
 
834
        t = self.get_readonly_transport()
843
835
        # force transport to issue multiple requests by limiting the number of
844
836
        # bytes by request. Note that this apply to coalesced offsets only, a
845
837
        # single range will keep its size even if bigger than the limit.
854
846
 
855
847
    def test_complete_readv_leave_pipe_clean(self):
856
848
        server = self.get_readonly_server()
857
 
        t = self._transport(server.get_url())
 
849
        t = self.get_readonly_transport()
858
850
        # force transport to issue multiple requests
859
851
        t._get_max_size = 2
860
 
        l = list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
 
852
        list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
861
853
        # The server should have issued 3 requests
862
854
        self.assertEqual(3, server.GET_request_nb)
863
855
        self.assertEqual('0123456789', t.get_bytes('a'))
865
857
 
866
858
    def test_incomplete_readv_leave_pipe_clean(self):
867
859
        server = self.get_readonly_server()
868
 
        t = self._transport(server.get_url())
 
860
        t = self.get_readonly_transport()
869
861
        # force transport to issue multiple requests
870
862
        t._get_max_size = 2
871
863
        # Don't collapse readv results into a list so that we leave unread
940
932
    def get_multiple_ranges(self, file, file_size, ranges):
941
933
        self.send_response(206)
942
934
        self.send_header('Accept-Ranges', 'bytes')
 
935
        # XXX: this is strange; the 'random' name below seems undefined and
 
936
        # yet the tests pass -- mbp 2010-10-11 bug 658773
943
937
        boundary = "%d" % random.randint(0,0x7FFFFFFF)
944
938
        self.send_header("Content-Type",
945
939
                         "multipart/byteranges; boundary=%s" % boundary)
1007
1001
                return
1008
1002
            self.send_range_content(file, start, end - start + 1)
1009
1003
            cur += 1
1010
 
        # No final boundary
 
1004
        # Final boundary
1011
1005
        self.wfile.write(boundary_line)
1012
1006
 
1013
1007
 
1021
1015
 
1022
1016
    def test_readv_with_short_reads(self):
1023
1017
        server = self.get_readonly_server()
1024
 
        t = self._transport(server.get_url())
 
1018
        t = self.get_readonly_transport()
1025
1019
        # Force separate ranges for each offset
1026
1020
        t._bytes_to_read_before_seek = 0
1027
1021
        ireadv = iter(t.readv('a', ((0, 1), (2, 1), (4, 2), (9, 1))))
1042
1036
        # that mode
1043
1037
        self.assertEqual('single', t._range_hint)
1044
1038
 
 
1039
 
 
1040
class TruncatedBeforeBoundaryRequestHandler(
 
1041
    http_server.TestingHTTPRequestHandler):
 
1042
    """Truncation before a boundary, like in bug 198646"""
 
1043
 
 
1044
    _truncated_ranges = 1
 
1045
 
 
1046
    def get_multiple_ranges(self, file, file_size, ranges):
 
1047
        self.send_response(206)
 
1048
        self.send_header('Accept-Ranges', 'bytes')
 
1049
        boundary = 'tagada'
 
1050
        self.send_header('Content-Type',
 
1051
                         'multipart/byteranges; boundary=%s' % boundary)
 
1052
        boundary_line = '--%s\r\n' % boundary
 
1053
        # Calculate the Content-Length
 
1054
        content_length = 0
 
1055
        for (start, end) in ranges:
 
1056
            content_length += len(boundary_line)
 
1057
            content_length += self._header_line_length(
 
1058
                'Content-type', 'application/octet-stream')
 
1059
            content_length += self._header_line_length(
 
1060
                'Content-Range', 'bytes %d-%d/%d' % (start, end, file_size))
 
1061
            content_length += len('\r\n') # end headers
 
1062
            content_length += end - start # + 1
 
1063
        content_length += len(boundary_line)
 
1064
        self.send_header('Content-length', content_length)
 
1065
        self.end_headers()
 
1066
 
 
1067
        # Send the multipart body
 
1068
        cur = 0
 
1069
        for (start, end) in ranges:
 
1070
            if cur + self._truncated_ranges >= len(ranges):
 
1071
                # Abruptly ends the response and close the connection
 
1072
                self.close_connection = 1
 
1073
                return
 
1074
            self.wfile.write(boundary_line)
 
1075
            self.send_header('Content-type', 'application/octet-stream')
 
1076
            self.send_header('Content-Range', 'bytes %d-%d/%d'
 
1077
                             % (start, end, file_size))
 
1078
            self.end_headers()
 
1079
            self.send_range_content(file, start, end - start + 1)
 
1080
            cur += 1
 
1081
        # Final boundary
 
1082
        self.wfile.write(boundary_line)
 
1083
 
 
1084
 
 
1085
class TestTruncatedBeforeBoundary(TestSpecificRequestHandler):
 
1086
    """Tests the case of bug 198646, disconnecting before a boundary."""
 
1087
 
 
1088
    _req_handler_class = TruncatedBeforeBoundaryRequestHandler
 
1089
 
 
1090
    def setUp(self):
 
1091
        super(TestTruncatedBeforeBoundary, self).setUp()
 
1092
        self.build_tree_contents([('a', '0123456789')],)
 
1093
 
 
1094
    def test_readv_with_short_reads(self):
 
1095
        server = self.get_readonly_server()
 
1096
        t = self.get_readonly_transport()
 
1097
        # Force separate ranges for each offset
 
1098
        t._bytes_to_read_before_seek = 0
 
1099
        ireadv = iter(t.readv('a', ((0, 1), (2, 1), (4, 2), (9, 1))))
 
1100
        self.assertEqual((0, '0'), ireadv.next())
 
1101
        self.assertEqual((2, '2'), ireadv.next())
 
1102
        self.assertEqual((4, '45'), ireadv.next())
 
1103
        self.assertEqual((9, '9'), ireadv.next())
 
1104
 
 
1105
 
1045
1106
class LimitedRangeRequestHandler(http_server.TestingHTTPRequestHandler):
1046
1107
    """Errors out when range specifiers exceed the limit"""
1047
1108
 
1071
1132
class TestLimitedRangeRequestServer(http_utils.TestCaseWithWebserver):
1072
1133
    """Tests readv requests against a server erroring out on too much ranges."""
1073
1134
 
 
1135
    scenarios = multiply_scenarios(
 
1136
        vary_by_http_client_implementation(),
 
1137
        vary_by_http_protocol_version(),
 
1138
        )
 
1139
 
1074
1140
    # Requests with more range specifiers will error out
1075
1141
    range_limit = 3
1076
1142
 
1078
1144
        return LimitedRangeHTTPServer(range_limit=self.range_limit,
1079
1145
                                      protocol_version=self._protocol_version)
1080
1146
 
1081
 
    def get_transport(self):
1082
 
        return self._transport(self.get_readonly_server().get_url())
1083
 
 
1084
1147
    def setUp(self):
1085
 
        http_utils.TestCaseWithWebserver.setUp(self)
 
1148
        super(TestLimitedRangeRequestServer, self).setUp()
1086
1149
        # We need to manipulate ranges that correspond to real chunks in the
1087
1150
        # response, so we build a content appropriately.
1088
1151
        filler = ''.join(['abcdefghij' for x in range(102)])
1090
1153
        self.build_tree_contents([('a', content)],)
1091
1154
 
1092
1155
    def test_few_ranges(self):
1093
 
        t = self.get_transport()
 
1156
        t = self.get_readonly_transport()
1094
1157
        l = list(t.readv('a', ((0, 4), (1024, 4), )))
1095
1158
        self.assertEqual(l[0], (0, '0000'))
1096
1159
        self.assertEqual(l[1], (1024, '0001'))
1097
1160
        self.assertEqual(1, self.get_readonly_server().GET_request_nb)
1098
1161
 
1099
1162
    def test_more_ranges(self):
1100
 
        t = self.get_transport()
 
1163
        t = self.get_readonly_transport()
1101
1164
        l = list(t.readv('a', ((0, 4), (1024, 4), (4096, 4), (8192, 4))))
1102
1165
        self.assertEqual(l[0], (0, '0000'))
1103
1166
        self.assertEqual(l[1], (1024, '0001'))
1114
1177
    Only the urllib implementation is tested here.
1115
1178
    """
1116
1179
 
1117
 
    def setUp(self):
1118
 
        tests.TestCase.setUp(self)
1119
 
        self._old_env = {}
1120
 
 
1121
 
    def tearDown(self):
1122
 
        self._restore_env()
1123
 
        tests.TestCase.tearDown(self)
1124
 
 
1125
 
    def _install_env(self, env):
1126
 
        for name, value in env.iteritems():
1127
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1128
 
 
1129
 
    def _restore_env(self):
1130
 
        for name, value in self._old_env.iteritems():
1131
 
            osutils.set_or_unset_env(name, value)
1132
 
 
1133
1180
    def _proxied_request(self):
1134
1181
        handler = _urllib2_wrappers.ProxyHandler()
1135
 
        request = _urllib2_wrappers.Request('GET','http://baz/buzzle')
 
1182
        request = _urllib2_wrappers.Request('GET', 'http://baz/buzzle')
1136
1183
        handler.set_proxy(request, 'http')
1137
1184
        return request
1138
1185
 
 
1186
    def assertEvaluateProxyBypass(self, expected, host, no_proxy):
 
1187
        handler = _urllib2_wrappers.ProxyHandler()
 
1188
        self.assertEquals(expected,
 
1189
                          handler.evaluate_proxy_bypass(host, no_proxy))
 
1190
 
1139
1191
    def test_empty_user(self):
1140
 
        self._install_env({'http_proxy': 'http://bar.com'})
 
1192
        self.overrideEnv('http_proxy', 'http://bar.com')
 
1193
        request = self._proxied_request()
 
1194
        self.assertFalse(request.headers.has_key('Proxy-authorization'))
 
1195
 
 
1196
    def test_user_with_at(self):
 
1197
        self.overrideEnv('http_proxy',
 
1198
                         'http://username@domain:password@proxy_host:1234')
1141
1199
        request = self._proxied_request()
1142
1200
        self.assertFalse(request.headers.has_key('Proxy-authorization'))
1143
1201
 
1144
1202
    def test_invalid_proxy(self):
1145
1203
        """A proxy env variable without scheme"""
1146
 
        self._install_env({'http_proxy': 'host:1234'})
 
1204
        self.overrideEnv('http_proxy', 'host:1234')
1147
1205
        self.assertRaises(errors.InvalidURL, self._proxied_request)
1148
1206
 
 
1207
    def test_evaluate_proxy_bypass_true(self):
 
1208
        """The host is not proxied"""
 
1209
        self.assertEvaluateProxyBypass(True, 'example.com', 'example.com')
 
1210
        self.assertEvaluateProxyBypass(True, 'bzr.example.com', '*example.com')
 
1211
 
 
1212
    def test_evaluate_proxy_bypass_false(self):
 
1213
        """The host is proxied"""
 
1214
        self.assertEvaluateProxyBypass(False, 'bzr.example.com', None)
 
1215
 
 
1216
    def test_evaluate_proxy_bypass_unknown(self):
 
1217
        """The host is not explicitly proxied"""
 
1218
        self.assertEvaluateProxyBypass(None, 'example.com', 'not.example.com')
 
1219
        self.assertEvaluateProxyBypass(None, 'bzr.example.com', 'example.com')
 
1220
 
 
1221
    def test_evaluate_proxy_bypass_empty_entries(self):
 
1222
        """Ignore empty entries"""
 
1223
        self.assertEvaluateProxyBypass(None, 'example.com', '')
 
1224
        self.assertEvaluateProxyBypass(None, 'example.com', ',')
 
1225
        self.assertEvaluateProxyBypass(None, 'example.com', 'foo,,bar')
 
1226
 
1149
1227
 
1150
1228
class TestProxyHttpServer(http_utils.TestCaseWithTwoWebservers):
1151
1229
    """Tests proxy server.
1156
1234
    to the file names).
1157
1235
    """
1158
1236
 
 
1237
    scenarios = multiply_scenarios(
 
1238
        vary_by_http_client_implementation(),
 
1239
        vary_by_http_protocol_version(),
 
1240
        )
 
1241
 
1159
1242
    # FIXME: We don't have an https server available, so we don't
1160
 
    # test https connections.
 
1243
    # test https connections. --vila toolongago
1161
1244
 
1162
1245
    def setUp(self):
1163
1246
        super(TestProxyHttpServer, self).setUp()
 
1247
        self.transport_secondary_server = http_utils.ProxyServer
1164
1248
        self.build_tree_contents([('foo', 'contents of foo\n'),
1165
1249
                                  ('foo-proxied', 'proxied contents of foo\n')])
1166
1250
        # Let's setup some attributes for tests
1167
 
        self.server = self.get_readonly_server()
1168
 
        self.proxy_address = '%s:%d' % (self.server.host, self.server.port)
 
1251
        server = self.get_readonly_server()
 
1252
        self.server_host_port = '%s:%d' % (server.host, server.port)
1169
1253
        if self._testing_pycurl():
1170
1254
            # Oh my ! pycurl does not check for the port as part of
1171
1255
            # no_proxy :-( So we just test the host part
1172
 
            self.no_proxy_host = self.server.host
 
1256
            self.no_proxy_host = server.host
1173
1257
        else:
1174
 
            self.no_proxy_host = self.proxy_address
 
1258
            self.no_proxy_host = self.server_host_port
1175
1259
        # The secondary server is the proxy
1176
 
        self.proxy = self.get_secondary_server()
1177
 
        self.proxy_url = self.proxy.get_url()
1178
 
        self._old_env = {}
 
1260
        self.proxy_url = self.get_secondary_url()
1179
1261
 
1180
1262
    def _testing_pycurl(self):
1181
1263
        # TODO: This is duplicated for lots of the classes in this file
1182
1264
        return (features.pycurl.available()
1183
1265
                and self._transport == PyCurlTransport)
1184
1266
 
1185
 
    def create_transport_secondary_server(self):
1186
 
        """Creates an http server that will serve files with
1187
 
        '-proxied' appended to their names.
1188
 
        """
1189
 
        return http_utils.ProxyServer(protocol_version=self._protocol_version)
1190
 
 
1191
 
    def _install_env(self, env):
1192
 
        for name, value in env.iteritems():
1193
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1194
 
 
1195
 
    def _restore_env(self):
1196
 
        for name, value in self._old_env.iteritems():
1197
 
            osutils.set_or_unset_env(name, value)
1198
 
 
1199
 
    def proxied_in_env(self, env):
1200
 
        self._install_env(env)
1201
 
        url = self.server.get_url()
1202
 
        t = self._transport(url)
1203
 
        try:
1204
 
            self.assertEqual('proxied contents of foo\n', t.get('foo').read())
1205
 
        finally:
1206
 
            self._restore_env()
1207
 
 
1208
 
    def not_proxied_in_env(self, env):
1209
 
        self._install_env(env)
1210
 
        url = self.server.get_url()
1211
 
        t = self._transport(url)
1212
 
        try:
1213
 
            self.assertEqual('contents of foo\n', t.get('foo').read())
1214
 
        finally:
1215
 
            self._restore_env()
 
1267
    def assertProxied(self):
 
1268
        t = self.get_readonly_transport()
 
1269
        self.assertEqual('proxied contents of foo\n', t.get('foo').read())
 
1270
 
 
1271
    def assertNotProxied(self):
 
1272
        t = self.get_readonly_transport()
 
1273
        self.assertEqual('contents of foo\n', t.get('foo').read())
1216
1274
 
1217
1275
    def test_http_proxy(self):
1218
 
        self.proxied_in_env({'http_proxy': self.proxy_url})
 
1276
        self.overrideEnv('http_proxy', self.proxy_url)
 
1277
        self.assertProxied()
1219
1278
 
1220
1279
    def test_HTTP_PROXY(self):
1221
1280
        if self._testing_pycurl():
1224
1283
            # about. Should we ?)
1225
1284
            raise tests.TestNotApplicable(
1226
1285
                'pycurl does not check HTTP_PROXY for security reasons')
1227
 
        self.proxied_in_env({'HTTP_PROXY': self.proxy_url})
 
1286
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
 
1287
        self.assertProxied()
1228
1288
 
1229
1289
    def test_all_proxy(self):
1230
 
        self.proxied_in_env({'all_proxy': self.proxy_url})
 
1290
        self.overrideEnv('all_proxy', self.proxy_url)
 
1291
        self.assertProxied()
1231
1292
 
1232
1293
    def test_ALL_PROXY(self):
1233
 
        self.proxied_in_env({'ALL_PROXY': self.proxy_url})
 
1294
        self.overrideEnv('ALL_PROXY', self.proxy_url)
 
1295
        self.assertProxied()
1234
1296
 
1235
1297
    def test_http_proxy_with_no_proxy(self):
1236
 
        self.not_proxied_in_env({'http_proxy': self.proxy_url,
1237
 
                                 'no_proxy': self.no_proxy_host})
 
1298
        self.overrideEnv('no_proxy', self.no_proxy_host)
 
1299
        self.overrideEnv('http_proxy', self.proxy_url)
 
1300
        self.assertNotProxied()
1238
1301
 
1239
1302
    def test_HTTP_PROXY_with_NO_PROXY(self):
1240
1303
        if self._testing_pycurl():
1241
1304
            raise tests.TestNotApplicable(
1242
1305
                'pycurl does not check HTTP_PROXY for security reasons')
1243
 
        self.not_proxied_in_env({'HTTP_PROXY': self.proxy_url,
1244
 
                                 'NO_PROXY': self.no_proxy_host})
 
1306
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
 
1307
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
 
1308
        self.assertNotProxied()
1245
1309
 
1246
1310
    def test_all_proxy_with_no_proxy(self):
1247
 
        self.not_proxied_in_env({'all_proxy': self.proxy_url,
1248
 
                                 'no_proxy': self.no_proxy_host})
 
1311
        self.overrideEnv('no_proxy', self.no_proxy_host)
 
1312
        self.overrideEnv('all_proxy', self.proxy_url)
 
1313
        self.assertNotProxied()
1249
1314
 
1250
1315
    def test_ALL_PROXY_with_NO_PROXY(self):
1251
 
        self.not_proxied_in_env({'ALL_PROXY': self.proxy_url,
1252
 
                                 'NO_PROXY': self.no_proxy_host})
 
1316
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
 
1317
        self.overrideEnv('ALL_PROXY', self.proxy_url)
 
1318
        self.assertNotProxied()
1253
1319
 
1254
1320
    def test_http_proxy_without_scheme(self):
 
1321
        self.overrideEnv('http_proxy', self.server_host_port)
1255
1322
        if self._testing_pycurl():
1256
1323
            # pycurl *ignores* invalid proxy env variables. If that ever change
1257
1324
            # in the future, this test will fail indicating that pycurl do not
1258
1325
            # ignore anymore such variables.
1259
 
            self.not_proxied_in_env({'http_proxy': self.proxy_address})
 
1326
            self.assertNotProxied()
1260
1327
        else:
1261
 
            self.assertRaises(errors.InvalidURL,
1262
 
                              self.proxied_in_env,
1263
 
                              {'http_proxy': self.proxy_address})
 
1328
            self.assertRaises(errors.InvalidURL, self.assertProxied)
1264
1329
 
1265
1330
 
1266
1331
class TestRanges(http_utils.TestCaseWithWebserver):
1267
1332
    """Test the Range header in GET methods."""
1268
1333
 
 
1334
    scenarios = multiply_scenarios(
 
1335
        vary_by_http_client_implementation(),
 
1336
        vary_by_http_protocol_version(),
 
1337
        )
 
1338
 
1269
1339
    def setUp(self):
1270
 
        http_utils.TestCaseWithWebserver.setUp(self)
 
1340
        super(TestRanges, self).setUp()
1271
1341
        self.build_tree_contents([('a', '0123456789')],)
1272
 
        server = self.get_readonly_server()
1273
 
        self.transport = self._transport(server.get_url())
1274
1342
 
1275
1343
    def create_transport_readonly_server(self):
1276
1344
        return http_server.HttpServer(protocol_version=self._protocol_version)
1277
1345
 
1278
1346
    def _file_contents(self, relpath, ranges):
 
1347
        t = self.get_readonly_transport()
1279
1348
        offsets = [ (start, end - start + 1) for start, end in ranges]
1280
 
        coalesce = self.transport._coalesce_offsets
 
1349
        coalesce = t._coalesce_offsets
1281
1350
        coalesced = list(coalesce(offsets, limit=0, fudge_factor=0))
1282
 
        code, data = self.transport._get(relpath, coalesced)
 
1351
        code, data = t._get(relpath, coalesced)
1283
1352
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1284
1353
        for start, end in ranges:
1285
1354
            data.seek(start)
1286
1355
            yield data.read(end - start + 1)
1287
1356
 
1288
1357
    def _file_tail(self, relpath, tail_amount):
1289
 
        code, data = self.transport._get(relpath, [], tail_amount)
 
1358
        t = self.get_readonly_transport()
 
1359
        code, data = t._get(relpath, [], tail_amount)
1290
1360
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1291
1361
        data.seek(-tail_amount, 2)
1292
1362
        return data.read(tail_amount)
1311
1381
class TestHTTPRedirections(http_utils.TestCaseWithRedirectedWebserver):
1312
1382
    """Test redirection between http servers."""
1313
1383
 
1314
 
    def create_transport_secondary_server(self):
1315
 
        """Create the secondary server redirecting to the primary server"""
1316
 
        new = self.get_readonly_server()
1317
 
 
1318
 
        redirecting = http_utils.HTTPServerRedirecting(
1319
 
            protocol_version=self._protocol_version)
1320
 
        redirecting.redirect_to(new.host, new.port)
1321
 
        return redirecting
 
1384
    scenarios = multiply_scenarios(
 
1385
        vary_by_http_client_implementation(),
 
1386
        vary_by_http_protocol_version(),
 
1387
        )
1322
1388
 
1323
1389
    def setUp(self):
1324
1390
        super(TestHTTPRedirections, self).setUp()
1326
1392
                                  ('bundle',
1327
1393
                                  '# Bazaar revision bundle v0.9\n#\n')
1328
1394
                                  ],)
1329
 
        # The requests to the old server will be redirected to the new server
1330
 
        self.old_transport = self._transport(self.old_server.get_url())
1331
1395
 
1332
1396
    def test_redirected(self):
1333
 
        self.assertRaises(errors.RedirectRequested, self.old_transport.get, 'a')
1334
 
        t = self._transport(self.new_server.get_url())
1335
 
        self.assertEqual('0123456789', t.get('a').read())
1336
 
 
1337
 
    def test_read_redirected_bundle_from_url(self):
1338
 
        from bzrlib.bundle import read_bundle_from_url
1339
 
        url = self.old_transport.abspath('bundle')
1340
 
        bundle = self.applyDeprecated(deprecated_in((1, 12, 0)),
1341
 
                read_bundle_from_url, url)
1342
 
        # If read_bundle_from_url was successful we get an empty bundle
1343
 
        self.assertEqual([], bundle.revisions)
 
1397
        self.assertRaises(errors.RedirectRequested,
 
1398
                          self.get_old_transport().get, 'a')
 
1399
        self.assertEqual('0123456789', self.get_new_transport().get('a').read())
1344
1400
 
1345
1401
 
1346
1402
class RedirectedRequest(_urllib2_wrappers.Request):
1363
1419
    test.overrideAttr(_urllib2_wrappers, 'Request', RedirectedRequest)
1364
1420
 
1365
1421
 
 
1422
def cleanup_http_redirection_connections(test):
 
1423
    # Some sockets are opened but never seen by _urllib, so we trap them at
 
1424
    # the _urllib2_wrappers level to be able to clean them up.
 
1425
    def socket_disconnect(sock):
 
1426
        try:
 
1427
            sock.shutdown(socket.SHUT_RDWR)
 
1428
            sock.close()
 
1429
        except socket.error:
 
1430
            pass
 
1431
    def connect(connection):
 
1432
        test.http_connect_orig(connection)
 
1433
        test.addCleanup(socket_disconnect, connection.sock)
 
1434
    test.http_connect_orig = test.overrideAttr(
 
1435
        _urllib2_wrappers.HTTPConnection, 'connect', connect)
 
1436
    def connect(connection):
 
1437
        test.https_connect_orig(connection)
 
1438
        test.addCleanup(socket_disconnect, connection.sock)
 
1439
    test.https_connect_orig = test.overrideAttr(
 
1440
        _urllib2_wrappers.HTTPSConnection, 'connect', connect)
 
1441
 
 
1442
 
1366
1443
class TestHTTPSilentRedirections(http_utils.TestCaseWithRedirectedWebserver):
1367
1444
    """Test redirections.
1368
1445
 
1377
1454
    -- vila 20070212
1378
1455
    """
1379
1456
 
 
1457
    scenarios = multiply_scenarios(
 
1458
        vary_by_http_client_implementation(),
 
1459
        vary_by_http_protocol_version(),
 
1460
        )
 
1461
 
1380
1462
    def setUp(self):
1381
1463
        if (features.pycurl.available()
1382
1464
            and self._transport == PyCurlTransport):
1383
1465
            raise tests.TestNotApplicable(
1384
 
                "pycurl doesn't redirect silently annymore")
 
1466
                "pycurl doesn't redirect silently anymore")
1385
1467
        super(TestHTTPSilentRedirections, self).setUp()
1386
1468
        install_redirected_request(self)
 
1469
        cleanup_http_redirection_connections(self)
1387
1470
        self.build_tree_contents([('a','a'),
1388
1471
                                  ('1/',),
1389
1472
                                  ('1/a', 'redirected once'),
1397
1480
                                  ('5/a', 'redirected 5 times'),
1398
1481
                                  ],)
1399
1482
 
1400
 
        self.old_transport = self._transport(self.old_server.get_url())
1401
 
 
1402
 
    def create_transport_secondary_server(self):
1403
 
        """Create the secondary server, redirections are defined in the tests"""
1404
 
        return http_utils.HTTPServerRedirecting(
1405
 
            protocol_version=self._protocol_version)
1406
 
 
1407
1483
    def test_one_redirection(self):
1408
 
        t = self.old_transport
1409
 
 
1410
 
        req = RedirectedRequest('GET', t.abspath('a'))
 
1484
        t = self.get_old_transport()
 
1485
        req = RedirectedRequest('GET', t._remote_path('a'))
1411
1486
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1412
1487
                                       self.new_server.port)
1413
1488
        self.old_server.redirections = \
1414
1489
            [('(.*)', r'%s/1\1' % (new_prefix), 301),]
1415
 
        self.assertEqual('redirected once',t._perform(req).read())
 
1490
        self.assertEqual('redirected once', t._perform(req).read())
1416
1491
 
1417
1492
    def test_five_redirections(self):
1418
 
        t = self.old_transport
1419
 
 
1420
 
        req = RedirectedRequest('GET', t.abspath('a'))
 
1493
        t = self.get_old_transport()
 
1494
        req = RedirectedRequest('GET', t._remote_path('a'))
1421
1495
        old_prefix = 'http://%s:%s' % (self.old_server.host,
1422
1496
                                       self.old_server.port)
1423
1497
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1429
1503
            ('/4(.*)', r'%s/5\1' % (new_prefix), 301),
1430
1504
            ('(/[^/]+)', r'%s/1\1' % (old_prefix), 301),
1431
1505
            ]
1432
 
        self.assertEqual('redirected 5 times',t._perform(req).read())
 
1506
        self.assertEqual('redirected 5 times', t._perform(req).read())
1433
1507
 
1434
1508
 
1435
1509
class TestDoCatchRedirections(http_utils.TestCaseWithRedirectedWebserver):
1436
1510
    """Test transport.do_catching_redirections."""
1437
1511
 
 
1512
    scenarios = multiply_scenarios(
 
1513
        vary_by_http_client_implementation(),
 
1514
        vary_by_http_protocol_version(),
 
1515
        )
 
1516
 
1438
1517
    def setUp(self):
1439
1518
        super(TestDoCatchRedirections, self).setUp()
1440
1519
        self.build_tree_contents([('a', '0123456789'),],)
1441
 
 
1442
 
        self.old_transport = self._transport(self.old_server.get_url())
1443
 
 
1444
 
    def get_a(self, transport):
1445
 
        return transport.get('a')
 
1520
        cleanup_http_redirection_connections(self)
 
1521
 
 
1522
        self.old_transport = self.get_old_transport()
 
1523
 
 
1524
    def get_a(self, t):
 
1525
        return t.get('a')
1446
1526
 
1447
1527
    def test_no_redirection(self):
1448
 
        t = self._transport(self.new_server.get_url())
 
1528
        t = self.get_new_transport()
1449
1529
 
1450
1530
        # We use None for redirected so that we fail if redirected
1451
1531
        self.assertEqual('0123456789',
1455
1535
    def test_one_redirection(self):
1456
1536
        self.redirections = 0
1457
1537
 
1458
 
        def redirected(transport, exception, redirection_notice):
 
1538
        def redirected(t, exception, redirection_notice):
1459
1539
            self.redirections += 1
1460
 
            dir, file = urlutils.split(exception.target)
1461
 
            return self._transport(dir)
 
1540
            redirected_t = t._redirected_to(exception.source, exception.target)
 
1541
            return redirected_t
1462
1542
 
1463
1543
        self.assertEqual('0123456789',
1464
1544
                         transport.do_catching_redirections(
1478
1558
                          self.get_a, self.old_transport, redirected)
1479
1559
 
1480
1560
 
 
1561
def _setup_authentication_config(**kwargs):
 
1562
    conf = config.AuthenticationConfig()
 
1563
    conf._get_config().update({'httptest': kwargs})
 
1564
    conf._save()
 
1565
 
 
1566
 
 
1567
class TestUrllib2AuthHandler(tests.TestCaseWithTransport):
 
1568
    """Unit tests for glue by which urllib2 asks us for authentication"""
 
1569
 
 
1570
    def test_get_user_password_without_port(self):
 
1571
        """We cope if urllib2 doesn't tell us the port.
 
1572
 
 
1573
        See https://bugs.launchpad.net/bzr/+bug/654684
 
1574
        """
 
1575
        user = 'joe'
 
1576
        password = 'foo'
 
1577
        _setup_authentication_config(scheme='http', host='localhost',
 
1578
                                     user=user, password=password)
 
1579
        handler = _urllib2_wrappers.HTTPAuthHandler()
 
1580
        got_pass = handler.get_user_password(dict(
 
1581
            user='joe',
 
1582
            protocol='http',
 
1583
            host='localhost',
 
1584
            path='/',
 
1585
            realm='Realm',
 
1586
            ))
 
1587
        self.assertEquals((user, password), got_pass)
 
1588
 
 
1589
 
1481
1590
class TestAuth(http_utils.TestCaseWithWebserver):
1482
1591
    """Test authentication scheme"""
1483
1592
 
1484
 
    _auth_header = 'Authorization'
1485
 
    _password_prompt_prefix = ''
1486
 
    _username_prompt_prefix = ''
1487
 
    # Set by load_tests
1488
 
    _auth_server = None
 
1593
    scenarios = multiply_scenarios(
 
1594
        vary_by_http_client_implementation(),
 
1595
        vary_by_http_protocol_version(),
 
1596
        vary_by_http_auth_scheme(),
 
1597
        )
1489
1598
 
1490
1599
    def setUp(self):
1491
1600
        super(TestAuth, self).setUp()
1494
1603
                                  ('b', 'contents of b\n'),])
1495
1604
 
1496
1605
    def create_transport_readonly_server(self):
1497
 
        return self._auth_server(protocol_version=self._protocol_version)
 
1606
        server = self._auth_server(protocol_version=self._protocol_version)
 
1607
        server._url_protocol = self._url_protocol
 
1608
        return server
1498
1609
 
1499
1610
    def _testing_pycurl(self):
1500
1611
        # TODO: This is duplicated for lots of the classes in this file
1513
1624
        return url
1514
1625
 
1515
1626
    def get_user_transport(self, user, password):
1516
 
        return self._transport(self.get_user_url(user, password))
 
1627
        t = transport.get_transport_from_url(
 
1628
            self.get_user_url(user, password))
 
1629
        return t
1517
1630
 
1518
1631
    def test_no_user(self):
1519
1632
        self.server.add_user('joe', 'foo')
1630
1743
        ui.ui_factory = tests.TestUIFactory(stdin=stdin_content,
1631
1744
                                            stderr=tests.StringIOWrapper())
1632
1745
        # Create a minimal config file with the right password
1633
 
        conf = config.AuthenticationConfig()
1634
 
        conf._get_config().update(
1635
 
            {'httptest': {'scheme': 'http', 'port': self.server.port,
1636
 
                          'user': user, 'password': password}})
1637
 
        conf._save()
 
1746
        _setup_authentication_config(scheme='http', port=self.server.port,
 
1747
                                     user=user, password=password)
1638
1748
        # Issue a request to the server to connect
1639
1749
        self.assertEqual('contents of a\n',t.get('a').read())
1640
1750
        # stdin should have  been left untouched
1642
1752
        # Only one 'Authentication Required' error should occur
1643
1753
        self.assertEqual(1, self.server.auth_required_errors)
1644
1754
 
1645
 
    def test_user_from_auth_conf(self):
1646
 
        if self._testing_pycurl():
1647
 
            raise tests.TestNotApplicable(
1648
 
                'pycurl does not support authentication.conf')
1649
 
        user = 'joe'
1650
 
        password = 'foo'
1651
 
        self.server.add_user(user, password)
1652
 
        # Create a minimal config file with the right password
1653
 
        conf = config.AuthenticationConfig()
1654
 
        conf._get_config().update(
1655
 
            {'httptest': {'scheme': 'http', 'port': self.server.port,
1656
 
                          'user': user, 'password': password}})
1657
 
        conf._save()
1658
 
        t = self.get_user_transport(None, None)
1659
 
        # Issue a request to the server to connect
1660
 
        self.assertEqual('contents of a\n', t.get('a').read())
1661
 
        # Only one 'Authentication Required' error should occur
1662
 
        self.assertEqual(1, self.server.auth_required_errors)
1663
 
 
1664
1755
    def test_changing_nonce(self):
1665
1756
        if self._auth_server not in (http_utils.HTTPDigestAuthServer,
1666
1757
                                     http_utils.ProxyDigestAuthServer):
1667
1758
            raise tests.TestNotApplicable('HTTP/proxy auth digest only test')
1668
1759
        if self._testing_pycurl():
1669
 
            raise tests.KnownFailure(
 
1760
            self.knownFailure(
1670
1761
                'pycurl does not handle a nonce change')
1671
1762
        self.server.add_user('joe', 'foo')
1672
1763
        t = self.get_user_transport('joe', 'foo')
1682
1773
        # initial 'who are you' and a second 'who are you' with the new nonce)
1683
1774
        self.assertEqual(2, self.server.auth_required_errors)
1684
1775
 
 
1776
    def test_user_from_auth_conf(self):
 
1777
        if self._testing_pycurl():
 
1778
            raise tests.TestNotApplicable(
 
1779
                'pycurl does not support authentication.conf')
 
1780
        user = 'joe'
 
1781
        password = 'foo'
 
1782
        self.server.add_user(user, password)
 
1783
        _setup_authentication_config(scheme='http', port=self.server.port,
 
1784
                                     user=user, password=password)
 
1785
        t = self.get_user_transport(None, None)
 
1786
        # Issue a request to the server to connect
 
1787
        self.assertEqual('contents of a\n', t.get('a').read())
 
1788
        # Only one 'Authentication Required' error should occur
 
1789
        self.assertEqual(1, self.server.auth_required_errors)
 
1790
 
 
1791
    def test_no_credential_leaks_in_log(self):
 
1792
        self.overrideAttr(debug, 'debug_flags', set(['http']))
 
1793
        user = 'joe'
 
1794
        password = 'very-sensitive-password'
 
1795
        self.server.add_user(user, password)
 
1796
        t = self.get_user_transport(user, password)
 
1797
        # Capture the debug calls to mutter
 
1798
        self.mutters = []
 
1799
        def mutter(*args):
 
1800
            lines = args[0] % args[1:]
 
1801
            # Some calls output multiple lines, just split them now since we
 
1802
            # care about a single one later.
 
1803
            self.mutters.extend(lines.splitlines())
 
1804
        self.overrideAttr(trace, 'mutter', mutter)
 
1805
        # Issue a request to the server to connect
 
1806
        self.assertEqual(True, t.has('a'))
 
1807
        # Only one 'Authentication Required' error should occur
 
1808
        self.assertEqual(1, self.server.auth_required_errors)
 
1809
        # Since the authentification succeeded, there should be a corresponding
 
1810
        # debug line
 
1811
        sent_auth_headers = [line for line in self.mutters
 
1812
                             if line.startswith('> %s' % (self._auth_header,))]
 
1813
        self.assertLength(1, sent_auth_headers)
 
1814
        self.assertStartsWith(sent_auth_headers[0],
 
1815
                              '> %s: <masked>' % (self._auth_header,))
1685
1816
 
1686
1817
 
1687
1818
class TestProxyAuth(TestAuth):
1688
 
    """Test proxy authentication schemes."""
1689
 
 
1690
 
    _auth_header = 'Proxy-authorization'
1691
 
    _password_prompt_prefix = 'Proxy '
1692
 
    _username_prompt_prefix = 'Proxy '
 
1819
    """Test proxy authentication schemes.
 
1820
 
 
1821
    This inherits from TestAuth to tweak the setUp and filter some failing
 
1822
    tests.
 
1823
    """
 
1824
 
 
1825
    scenarios = multiply_scenarios(
 
1826
        vary_by_http_client_implementation(),
 
1827
        vary_by_http_protocol_version(),
 
1828
        vary_by_http_proxy_auth_scheme(),
 
1829
        )
1693
1830
 
1694
1831
    def setUp(self):
1695
1832
        super(TestProxyAuth, self).setUp()
1696
 
        self._old_env = {}
1697
 
        self.addCleanup(self._restore_env)
1698
1833
        # Override the contents to avoid false positives
1699
1834
        self.build_tree_contents([('a', 'not proxied contents of a\n'),
1700
1835
                                  ('b', 'not proxied contents of b\n'),
1703
1838
                                  ])
1704
1839
 
1705
1840
    def get_user_transport(self, user, password):
1706
 
        self._install_env({'all_proxy': self.get_user_url(user, password)})
1707
 
        return self._transport(self.server.get_url())
1708
 
 
1709
 
    def _install_env(self, env):
1710
 
        for name, value in env.iteritems():
1711
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1712
 
 
1713
 
    def _restore_env(self):
1714
 
        for name, value in self._old_env.iteritems():
1715
 
            osutils.set_or_unset_env(name, value)
 
1841
        self.overrideEnv('all_proxy', self.get_user_url(user, password))
 
1842
        return TestAuth.get_user_transport(self, user, password)
1716
1843
 
1717
1844
    def test_empty_pass(self):
1718
1845
        if self._testing_pycurl():
1719
1846
            import pycurl
1720
1847
            if pycurl.version_info()[1] < '7.16.0':
1721
 
                raise tests.KnownFailure(
 
1848
                self.knownFailure(
1722
1849
                    'pycurl < 7.16.0 does not handle empty proxy passwords')
1723
1850
        super(TestProxyAuth, self).test_empty_pass()
1724
1851
 
1737
1864
        self.readfile = StringIO(socket_read_content)
1738
1865
        self.writefile = StringIO()
1739
1866
        self.writefile.close = lambda: None
 
1867
        self.close = lambda: None
1740
1868
 
1741
1869
    def makefile(self, mode='r', bufsize=None):
1742
1870
        if 'r' in mode:
1747
1875
 
1748
1876
class SmartHTTPTunnellingTest(tests.TestCaseWithTransport):
1749
1877
 
 
1878
    scenarios = multiply_scenarios(
 
1879
        vary_by_http_client_implementation(),
 
1880
        vary_by_http_protocol_version(),
 
1881
        )
 
1882
 
1750
1883
    def setUp(self):
1751
1884
        super(SmartHTTPTunnellingTest, self).setUp()
1752
1885
        # We use the VFS layer as part of HTTP tunnelling tests.
1753
 
        self._captureVar('BZR_NO_SMART_VFS', None)
 
1886
        self.overrideEnv('BZR_NO_SMART_VFS', None)
1754
1887
        self.transport_readonly_server = http_utils.HTTPServerWithSmarts
 
1888
        self.http_server = self.get_readonly_server()
1755
1889
 
1756
1890
    def create_transport_readonly_server(self):
1757
 
        return http_utils.HTTPServerWithSmarts(
 
1891
        server = http_utils.HTTPServerWithSmarts(
1758
1892
            protocol_version=self._protocol_version)
 
1893
        server._url_protocol = self._url_protocol
 
1894
        return server
1759
1895
 
1760
 
    def test_open_bzrdir(self):
 
1896
    def test_open_controldir(self):
1761
1897
        branch = self.make_branch('relpath')
1762
 
        http_server = self.get_readonly_server()
1763
 
        url = http_server.get_url() + 'relpath'
1764
 
        bd = bzrdir.BzrDir.open(url)
 
1898
        url = self.http_server.get_url() + 'relpath'
 
1899
        bd = controldir.ControlDir.open(url)
 
1900
        self.addCleanup(bd.transport.disconnect)
1765
1901
        self.assertIsInstance(bd, _mod_remote.RemoteBzrDir)
1766
1902
 
1767
1903
    def test_bulk_data(self):
1769
1905
        # The 'readv' command in the smart protocol both sends and receives
1770
1906
        # bulk data, so we use that.
1771
1907
        self.build_tree(['data-file'])
1772
 
        http_server = self.get_readonly_server()
1773
 
        http_transport = self._transport(http_server.get_url())
 
1908
        http_transport = transport.get_transport_from_url(
 
1909
            self.http_server.get_url())
1774
1910
        medium = http_transport.get_smart_medium()
1775
1911
        # Since we provide the medium, the url below will be mostly ignored
1776
1912
        # during the test, as long as the path is '/'.
1784
1920
        post_body = 'hello\n'
1785
1921
        expected_reply_body = 'ok\x012\n'
1786
1922
 
1787
 
        http_server = self.get_readonly_server()
1788
 
        http_transport = self._transport(http_server.get_url())
 
1923
        http_transport = transport.get_transport_from_url(
 
1924
            self.http_server.get_url())
1789
1925
        medium = http_transport.get_smart_medium()
1790
1926
        response = medium.send_http_smart_request(post_body)
1791
1927
        reply_body = response.read()
1792
1928
        self.assertEqual(expected_reply_body, reply_body)
1793
1929
 
1794
1930
    def test_smart_http_server_post_request_handler(self):
1795
 
        httpd = self.get_readonly_server()._get_httpd()
 
1931
        httpd = self.http_server.server
1796
1932
 
1797
1933
        socket = SampleSocket(
1798
1934
            'POST /.bzr/smart %s \r\n' % self._protocol_version
1830
1966
 
1831
1967
    def test_probe_smart_server(self):
1832
1968
        """Test error handling against server refusing smart requests."""
1833
 
        server = self.get_readonly_server()
1834
 
        t = self._transport(server.get_url())
 
1969
        t = self.get_readonly_transport()
1835
1970
        # No need to build a valid smart request here, the server will not even
1836
1971
        # try to interpret it.
1837
1972
        self.assertRaises(errors.SmartProtocolError,
1838
1973
                          t.get_smart_medium().send_http_smart_request,
1839
1974
                          'whatever')
1840
1975
 
 
1976
 
1841
1977
class Test_redirected_to(tests.TestCase):
1842
1978
 
 
1979
    scenarios = vary_by_http_client_implementation()
 
1980
 
1843
1981
    def test_redirected_to_subdir(self):
1844
1982
        t = self._transport('http://www.example.com/foo')
1845
1983
        r = t._redirected_to('http://www.example.com/foo',
1847
1985
        self.assertIsInstance(r, type(t))
1848
1986
        # Both transports share the some connection
1849
1987
        self.assertEqual(t._get_connection(), r._get_connection())
 
1988
        self.assertEquals('http://www.example.com/foo/subdir/', r.base)
1850
1989
 
1851
1990
    def test_redirected_to_self_with_slash(self):
1852
1991
        t = self._transport('http://www.example.com/foo')
1863
2002
        r = t._redirected_to('http://www.example.com/foo',
1864
2003
                             'http://foo.example.com/foo/subdir')
1865
2004
        self.assertIsInstance(r, type(t))
 
2005
        self.assertEquals('http://foo.example.com/foo/subdir/',
 
2006
            r.external_url())
1866
2007
 
1867
2008
    def test_redirected_to_same_host_sibling_protocol(self):
1868
2009
        t = self._transport('http://www.example.com/foo')
1869
2010
        r = t._redirected_to('http://www.example.com/foo',
1870
2011
                             'https://www.example.com/foo')
1871
2012
        self.assertIsInstance(r, type(t))
 
2013
        self.assertEquals('https://www.example.com/foo/',
 
2014
            r.external_url())
1872
2015
 
1873
2016
    def test_redirected_to_same_host_different_protocol(self):
1874
2017
        t = self._transport('http://www.example.com/foo')
1875
2018
        r = t._redirected_to('http://www.example.com/foo',
1876
2019
                             'ftp://www.example.com/foo')
1877
2020
        self.assertNotEquals(type(r), type(t))
 
2021
        self.assertEquals('ftp://www.example.com/foo/', r.external_url())
 
2022
 
 
2023
    def test_redirected_to_same_host_specific_implementation(self):
 
2024
        t = self._transport('http://www.example.com/foo')
 
2025
        r = t._redirected_to('http://www.example.com/foo',
 
2026
                             'https+urllib://www.example.com/foo')
 
2027
        self.assertEquals('https://www.example.com/foo/', r.external_url())
1878
2028
 
1879
2029
    def test_redirected_to_different_host_same_user(self):
1880
2030
        t = self._transport('http://joe@www.example.com/foo')
1881
2031
        r = t._redirected_to('http://www.example.com/foo',
1882
2032
                             'https://foo.example.com/foo')
1883
2033
        self.assertIsInstance(r, type(t))
1884
 
        self.assertEqual(t._user, r._user)
 
2034
        self.assertEqual(t._parsed_url.user, r._parsed_url.user)
 
2035
        self.assertEquals('https://joe@foo.example.com/foo/', r.external_url())
1885
2036
 
1886
2037
 
1887
2038
class PredefinedRequestHandler(http_server.TestingHTTPRequestHandler):
1896
2047
    line.
1897
2048
    """
1898
2049
 
1899
 
    def handle_one_request(self):
 
2050
    def _handle_one_request(self):
1900
2051
        tcs = self.server.test_case_server
1901
2052
        requestline = self.rfile.readline()
1902
2053
        headers = self.MessageClass(self.rfile, 0)
1940
2091
    pass
1941
2092
 
1942
2093
 
1943
 
if tests.HTTPSServerFeature.available():
 
2094
if features.HTTPSServerFeature.available():
1944
2095
    from bzrlib.tests import https_server
1945
2096
    class ActivityHTTPSServer(ActivityServerMixin, https_server.HTTPSServer):
1946
2097
        pass
1954
2105
    """
1955
2106
 
1956
2107
    def setUp(self):
1957
 
        tests.TestCase.setUp(self)
1958
2108
        self.server = self._activity_server(self._protocol_version)
1959
2109
        self.server.start_server()
1960
 
        self.activities = {}
 
2110
        self.addCleanup(self.server.stop_server)
 
2111
        _activities = {} # Don't close over self and create a cycle
1961
2112
        def report_activity(t, bytes, direction):
1962
 
            count = self.activities.get(direction, 0)
 
2113
            count = _activities.get(direction, 0)
1963
2114
            count += bytes
1964
 
            self.activities[direction] = count
1965
 
 
 
2115
            _activities[direction] = count
 
2116
        self.activities = _activities
1966
2117
        # We override at class level because constructors may propagate the
1967
2118
        # bound method and render instance overriding ineffective (an
1968
2119
        # alternative would be to define a specific ui factory instead...)
1969
 
        self.orig_report_activity = self._transport._report_activity
1970
 
        self._transport._report_activity = report_activity
1971
 
 
1972
 
    def tearDown(self):
1973
 
        self._transport._report_activity = self.orig_report_activity
1974
 
        self.server.stop_server()
1975
 
        tests.TestCase.tearDown(self)
 
2120
        self.overrideAttr(self._transport, '_report_activity', report_activity)
1976
2121
 
1977
2122
    def get_transport(self):
1978
 
        return self._transport(self.server.get_url())
 
2123
        t = self._transport(self.server.get_url())
 
2124
        # FIXME: Needs cleanup -- vila 20100611
 
2125
        return t
1979
2126
 
1980
2127
    def assertActivitiesMatch(self):
1981
2128
        self.assertEqual(self.server.bytes_read,
2086
2233
'''
2087
2234
        t = self.get_transport()
2088
2235
        # We must send a single line of body bytes, see
2089
 
        # PredefinedRequestHandler.handle_one_request
 
2236
        # PredefinedRequestHandler._handle_one_request
2090
2237
        code, f = t._post('abc def end-of-body\n')
2091
2238
        self.assertEqual('lalala whatever as long as itsssss\n', f.read())
2092
2239
        self.assertActivitiesMatch()
2094
2241
 
2095
2242
class TestActivity(tests.TestCase, TestActivityMixin):
2096
2243
 
 
2244
    scenarios = multiply_scenarios(
 
2245
        vary_by_http_activity(),
 
2246
        vary_by_http_protocol_version(),
 
2247
        )
 
2248
 
2097
2249
    def setUp(self):
2098
 
        tests.TestCase.setUp(self)
2099
 
        self.server = self._activity_server(self._protocol_version)
2100
 
        self.server.start_server()
2101
 
        self.activities = {}
2102
 
        def report_activity(t, bytes, direction):
2103
 
            count = self.activities.get(direction, 0)
2104
 
            count += bytes
2105
 
            self.activities[direction] = count
2106
 
 
2107
 
        # We override at class level because constructors may propagate the
2108
 
        # bound method and render instance overriding ineffective (an
2109
 
        # alternative would be to define a specific ui factory instead...)
2110
 
        self.orig_report_activity = self._transport._report_activity
2111
 
        self._transport._report_activity = report_activity
2112
 
 
2113
 
    def tearDown(self):
2114
 
        self._transport._report_activity = self.orig_report_activity
2115
 
        self.server.stop_server()
2116
 
        tests.TestCase.tearDown(self)
 
2250
        super(TestActivity, self).setUp()
 
2251
        TestActivityMixin.setUp(self)
2117
2252
 
2118
2253
 
2119
2254
class TestNoReportActivity(tests.TestCase, TestActivityMixin):
2120
2255
 
 
2256
    # Unlike TestActivity, we are really testing ReportingFileSocket and
 
2257
    # ReportingSocket, so we don't need all the parametrization. Since
 
2258
    # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
 
2259
    # test them through their use by the transport than directly (that's a
 
2260
    # bit less clean but far more simpler and effective).
 
2261
    _activity_server = ActivityHTTPServer
 
2262
    _protocol_version = 'HTTP/1.1'
 
2263
 
2121
2264
    def setUp(self):
2122
 
        tests.TestCase.setUp(self)
2123
 
        # Unlike TestActivity, we are really testing ReportingFileSocket and
2124
 
        # ReportingSocket, so we don't need all the parametrization. Since
2125
 
        # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
2126
 
        # test them through their use by the transport than directly (that's a
2127
 
        # bit less clean but far more simpler and effective).
2128
 
        self.server = ActivityHTTPServer('HTTP/1.1')
2129
 
        self._transport=_urllib.HttpTransport_urllib
2130
 
 
2131
 
        self.server.start_server()
2132
 
 
2133
 
        # We override at class level because constructors may propagate the
2134
 
        # bound method and render instance overriding ineffective (an
2135
 
        # alternative would be to define a specific ui factory instead...)
2136
 
        self.orig_report_activity = self._transport._report_activity
2137
 
        self._transport._report_activity = None
2138
 
 
2139
 
    def tearDown(self):
2140
 
        self._transport._report_activity = self.orig_report_activity
2141
 
        self.server.stop_server()
2142
 
        tests.TestCase.tearDown(self)
 
2265
        super(TestNoReportActivity, self).setUp()
 
2266
        self._transport =_urllib.HttpTransport_urllib
 
2267
        TestActivityMixin.setUp(self)
2143
2268
 
2144
2269
    def assertActivitiesMatch(self):
2145
2270
        # Nothing to check here
2149
2274
class TestAuthOnRedirected(http_utils.TestCaseWithRedirectedWebserver):
2150
2275
    """Test authentication on the redirected http server."""
2151
2276
 
 
2277
    scenarios = vary_by_http_protocol_version()
 
2278
 
2152
2279
    _auth_header = 'Authorization'
2153
2280
    _password_prompt_prefix = ''
2154
2281
    _username_prompt_prefix = ''
2155
2282
    _auth_server = http_utils.HTTPBasicAuthServer
2156
2283
    _transport = _urllib.HttpTransport_urllib
2157
2284
 
2158
 
    def create_transport_readonly_server(self):
2159
 
        return self._auth_server()
2160
 
 
2161
 
    def create_transport_secondary_server(self):
2162
 
        """Create the secondary server redirecting to the primary server"""
2163
 
        new = self.get_readonly_server()
2164
 
 
2165
 
        redirecting = http_utils.HTTPServerRedirecting()
2166
 
        redirecting.redirect_to(new.host, new.port)
2167
 
        return redirecting
2168
 
 
2169
2285
    def setUp(self):
2170
2286
        super(TestAuthOnRedirected, self).setUp()
2171
2287
        self.build_tree_contents([('a','a'),
2176
2292
                                       self.new_server.port)
2177
2293
        self.old_server.redirections = [
2178
2294
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2179
 
        self.old_transport = self._transport(self.old_server.get_url())
 
2295
        self.old_transport = self.get_old_transport()
2180
2296
        self.new_server.add_user('joe', 'foo')
2181
 
 
2182
 
    def get_a(self, transport):
2183
 
        return transport.get('a')
 
2297
        cleanup_http_redirection_connections(self)
 
2298
 
 
2299
    def create_transport_readonly_server(self):
 
2300
        server = self._auth_server(protocol_version=self._protocol_version)
 
2301
        server._url_protocol = self._url_protocol
 
2302
        return server
 
2303
 
 
2304
    def get_a(self, t):
 
2305
        return t.get('a')
2184
2306
 
2185
2307
    def test_auth_on_redirected_via_do_catching_redirections(self):
2186
2308
        self.redirections = 0
2187
2309
 
2188
 
        def redirected(transport, exception, redirection_notice):
 
2310
        def redirected(t, exception, redirection_notice):
2189
2311
            self.redirections += 1
2190
 
            dir, file = urlutils.split(exception.target)
2191
 
            return self._transport(dir)
 
2312
            redirected_t = t._redirected_to(exception.source, exception.target)
 
2313
            self.addCleanup(redirected_t.disconnect)
 
2314
            return redirected_t
2192
2315
 
2193
2316
        stdout = tests.StringIOWrapper()
2194
2317
        stderr = tests.StringIOWrapper()
2215
2338
                                       self.new_server.port)
2216
2339
        self.old_server.redirections = [
2217
2340
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2218
 
        self.assertEqual('redirected once',t._perform(req).read())
 
2341
        self.assertEqual('redirected once', t._perform(req).read())
2219
2342
        # stdin should be empty
2220
2343
        self.assertEqual('', ui.ui_factory.stdin.readline())
2221
2344
        # stdout should be empty, stderr will contains the prompts
2222
2345
        self.assertEqual('', stdout.getvalue())
2223
2346
 
2224