~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_lockdir.py

  • Committer: John Arbash Meinel
  • Date: 2013-06-24 12:03:12 UTC
  • mfrom: (6437.77.2 2.5)
  • mto: This revision was merged to the branch mainline in revision 6579.
  • Revision ID: john@arbash-meinel.com-20130624120312-pmvck24x052csigx
Merge lp:bzr/2.5 r6515 to get the fix for bug #855155 (Dirstate.update_basis_by_delta)

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006 Canonical Ltd
 
1
# Copyright (C) 2006-2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
17
"""Tests for LockDir"""
18
18
 
19
 
from cStringIO import StringIO
20
19
import os
21
 
from threading import Thread, Lock
22
20
import time
23
21
 
24
22
import bzrlib
25
23
from bzrlib import (
26
24
    config,
27
25
    errors,
 
26
    lock,
 
27
    lockdir,
28
28
    osutils,
29
29
    tests,
 
30
    transport,
30
31
    )
31
32
from bzrlib.errors import (
32
 
        LockBreakMismatch,
33
 
        LockContention, LockError, UnlockableTransport,
34
 
        LockNotHeld, LockBroken
35
 
        )
36
 
from bzrlib.lockdir import LockDir
37
 
from bzrlib.tests import TestCaseWithTransport
38
 
from bzrlib.trace import note
39
 
 
40
 
# These tests sometimes use threads to test the behaviour of lock files with
41
 
# concurrent actors.  This is not a typical (or necessarily supported) use;
42
 
# they're really meant for guarding between processes.
 
33
    LockBreakMismatch,
 
34
    LockBroken,
 
35
    LockContention,
 
36
    LockFailed,
 
37
    LockNotHeld,
 
38
    )
 
39
from bzrlib.lockdir import (
 
40
    LockDir,
 
41
    LockHeldInfo,
 
42
    )
 
43
from bzrlib.tests import (
 
44
    features,
 
45
    TestCase,
 
46
    TestCaseInTempDir,
 
47
    TestCaseWithTransport,
 
48
    )
43
49
 
44
50
# These tests are run on the default transport provided by the test framework
45
51
# (typically a local disk transport).  That can be changed by the --transport
47
53
# implementation are tested separately.  (The main requirement is just that
48
54
# they don't allow overwriting nonempty directories.)
49
55
 
 
56
 
50
57
class TestLockDir(TestCaseWithTransport):
51
58
    """Test LockDir operations"""
52
59
 
104
111
        """Fail to create lock on readonly transport"""
105
112
        t = self.get_readonly_transport()
106
113
        lf = LockDir(t, 'test_lock')
107
 
        self.assertRaises(UnlockableTransport, lf.create)
 
114
        self.assertRaises(LockFailed, lf.create)
108
115
 
109
116
    def test_12_lock_readonly_transport(self):
110
117
        """Fail to lock on readonly transport"""
111
118
        lf = LockDir(self.get_transport(), 'test_lock')
112
119
        lf.create()
113
120
        lf = LockDir(self.get_readonly_transport(), 'test_lock')
114
 
        self.assertRaises(UnlockableTransport, lf.attempt_lock)
 
121
        self.assertRaises(LockFailed, lf.attempt_lock)
115
122
 
116
123
    def test_20_lock_contested(self):
117
124
        """Contention to get a lock"""
121
128
        lf1.attempt_lock()
122
129
        lf2 = LockDir(t, 'test_lock')
123
130
        try:
124
 
            # locking is between LockDir instances; aliases within 
 
131
            # locking is between LockDir instances; aliases within
125
132
            # a single process are not detected
126
133
            lf2.attempt_lock()
127
134
            self.fail('Failed to detect lock collision')
137
144
        lf1 = LockDir(t, 'test_lock')
138
145
        lf1.create()
139
146
        lf1.attempt_lock()
 
147
        self.addCleanup(lf1.unlock)
140
148
        # lock is held, should get some info on it
141
149
        info1 = lf1.peek()
142
 
        self.assertEqual(set(info1.keys()),
143
 
                         set(['user', 'nonce', 'hostname', 'pid', 'start_time']))
 
150
        self.assertEqual(set(info1.info_dict.keys()),
 
151
            set(['user', 'nonce', 'hostname', 'pid', 'start_time']))
144
152
        # should get the same info if we look at it through a different
145
153
        # instance
146
154
        info2 = LockDir(t, 'test_lock').peek()
156
164
        lf2 = LockDir(self.get_readonly_transport(), 'test_lock')
157
165
        self.assertEqual(lf2.peek(), None)
158
166
        lf1.attempt_lock()
 
167
        self.addCleanup(lf1.unlock)
159
168
        info2 = lf2.peek()
160
169
        self.assertTrue(info2)
161
 
        self.assertEqual(info2['nonce'], lf1.nonce)
 
170
        self.assertEqual(info2.get('nonce'), lf1.nonce)
162
171
 
163
172
    def test_30_lock_wait_fail(self):
164
173
        """Wait on a lock, then fail
165
 
        
 
174
 
166
175
        We ask to wait up to 400ms; this should fail within at most one
167
176
        second.  (Longer times are more realistic but we don't want the test
168
177
        suite to take too long, and this should do for now.)
180
189
            after = time.time()
181
190
            # it should only take about 0.4 seconds, but we allow more time in
182
191
            # case the machine is heavily loaded
183
 
            self.assertTrue(after - before <= 8.0, 
184
 
                    "took %f seconds to detect lock contention" % (after - before))
 
192
            self.assertTrue(after - before <= 8.0,
 
193
                "took %f seconds to detect lock contention" % (after - before))
185
194
        finally:
186
195
            lf1.unlock()
187
 
        lock_base = lf2.transport.abspath(lf2.path)
188
196
        self.assertEqual(1, len(self._logged_reports))
189
 
        self.assertEqual('%s %s\n'
190
 
                         '%s\n%s\n'
191
 
                         'Will continue to try until %s\n',
192
 
                         self._logged_reports[0][0])
193
 
        args = self._logged_reports[0][1]
194
 
        self.assertEqual('Unable to obtain', args[0])
195
 
        self.assertEqual('lock %s' % (lock_base,), args[1])
196
 
        self.assertStartsWith(args[2], 'held by ')
197
 
        self.assertStartsWith(args[3], 'locked ')
198
 
        self.assertEndsWith(args[3], ' ago')
199
 
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
 
197
        self.assertContainsRe(self._logged_reports[0][0],
 
198
            r'Unable to obtain lock .* held by jrandom@example\.com on .*'
 
199
            r' \(process #\d+\), acquired .* ago\.\n'
 
200
            r'Will continue to try until \d{2}:\d{2}:\d{2}, unless '
 
201
            r'you press Ctrl-C.\n'
 
202
            r'See "bzr help break-lock" for more.')
200
203
 
201
204
    def test_31_lock_wait_easy(self):
202
205
        """Succeed when waiting on a lock with no contention.
214
217
            lf1.unlock()
215
218
        self.assertEqual([], self._logged_reports)
216
219
 
217
 
    def test_32_lock_wait_succeed(self):
218
 
        """Succeed when trying to acquire a lock that gets released
219
 
 
220
 
        One thread holds on a lock and then releases it; another 
221
 
        tries to lock it.
222
 
        """
223
 
        t = self.get_transport()
224
 
        lf1 = LockDir(t, 'test_lock')
225
 
        lf1.create()
226
 
        lf1.attempt_lock()
227
 
 
228
 
        def wait_and_unlock():
229
 
            time.sleep(0.1)
230
 
            lf1.unlock()
231
 
        unlocker = Thread(target=wait_and_unlock)
232
 
        unlocker.start()
233
 
        try:
234
 
            lf2 = LockDir(t, 'test_lock')
235
 
            self.setup_log_reporter(lf2)
236
 
            before = time.time()
237
 
            # wait and then lock
238
 
            lf2.wait_lock(timeout=0.4, poll=0.1)
239
 
            after = time.time()
240
 
            self.assertTrue(after - before <= 1.0)
241
 
        finally:
242
 
            unlocker.join()
243
 
 
244
 
        # There should be only 1 report, even though it should have to
245
 
        # wait for a while
246
 
        lock_base = lf2.transport.abspath(lf2.path)
247
 
        self.assertEqual(1, len(self._logged_reports))
248
 
        self.assertEqual('%s %s\n'
249
 
                         '%s\n%s\n'
250
 
                         'Will continue to try until %s\n',
251
 
                         self._logged_reports[0][0])
252
 
        args = self._logged_reports[0][1]
253
 
        self.assertEqual('Unable to obtain', args[0])
254
 
        self.assertEqual('lock %s' % (lock_base,), args[1])
255
 
        self.assertStartsWith(args[2], 'held by ')
256
 
        self.assertStartsWith(args[3], 'locked ')
257
 
        self.assertEndsWith(args[3], ' ago')
258
 
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
259
 
 
260
 
    def test_33_wait(self):
261
 
        """Succeed when waiting on a lock that gets released
262
 
 
263
 
        The difference from test_32_lock_wait_succeed is that the second 
264
 
        caller does not actually acquire the lock, but just waits for it
265
 
        to be released.  This is done over a readonly transport.
266
 
        """
267
 
        t = self.get_transport()
268
 
        lf1 = LockDir(t, 'test_lock')
269
 
        lf1.create()
270
 
        lf1.attempt_lock()
271
 
 
272
 
        def wait_and_unlock():
273
 
            time.sleep(0.1)
274
 
            lf1.unlock()
275
 
        unlocker = Thread(target=wait_and_unlock)
276
 
        unlocker.start()
277
 
        try:
278
 
            lf2 = LockDir(self.get_readonly_transport(), 'test_lock')
279
 
            before = time.time()
280
 
            # wait but don't lock
281
 
            lf2.wait(timeout=0.4, poll=0.1)
282
 
            after = time.time()
283
 
            self.assertTrue(after - before <= 1.0)
284
 
        finally:
285
 
            unlocker.join()
286
 
 
287
 
    def test_34_lock_write_waits(self):
288
 
        """LockDir.lock_write() will wait for the lock.""" 
289
 
        # the test suite sets the default to 0 to make deadlocks fail fast.
290
 
        # change it for this test, as we want to try a manual deadlock.
291
 
        bzrlib.lockdir._DEFAULT_TIMEOUT_SECONDS = 300
292
 
        t = self.get_transport()
293
 
        lf1 = LockDir(t, 'test_lock')
294
 
        lf1.create()
295
 
        lf1.attempt_lock()
296
 
 
297
 
        def wait_and_unlock():
298
 
            time.sleep(0.1)
299
 
            lf1.unlock()
300
 
        unlocker = Thread(target=wait_and_unlock)
301
 
        unlocker.start()
302
 
        try:
303
 
            lf2 = LockDir(t, 'test_lock')
304
 
            self.setup_log_reporter(lf2)
305
 
            before = time.time()
306
 
            # wait and then lock
307
 
            lf2.lock_write()
308
 
            after = time.time()
309
 
        finally:
310
 
            unlocker.join()
311
 
 
312
 
        # There should be only 1 report, even though it should have to
313
 
        # wait for a while
314
 
        lock_base = lf2.transport.abspath(lf2.path)
315
 
        self.assertEqual(1, len(self._logged_reports))
316
 
        self.assertEqual('%s %s\n'
317
 
                         '%s\n%s\n'
318
 
                         'Will continue to try until %s\n',
319
 
                         self._logged_reports[0][0])
320
 
        args = self._logged_reports[0][1]
321
 
        self.assertEqual('Unable to obtain', args[0])
322
 
        self.assertEqual('lock %s' % (lock_base,), args[1])
323
 
        self.assertStartsWith(args[2], 'held by ')
324
 
        self.assertStartsWith(args[3], 'locked ')
325
 
        self.assertEndsWith(args[3], ' ago')
326
 
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
327
 
 
328
 
    def test_35_wait_lock_changing(self):
329
 
        """LockDir.wait_lock() will report if the lock changes underneath.
330
 
        
331
 
        This is the stages we want to happen:
332
 
 
333
 
        0) Synchronization locks are created and locked.
334
 
        1) Lock1 obtains the lockdir, and releases the 'check' lock.
335
 
        2) Lock2 grabs the 'check' lock, and checks the lockdir.
336
 
           It sees the lockdir is already acquired, reports the fact, 
337
 
           and unsets the 'checked' lock.
338
 
        3) Thread1 blocks on acquiring the 'checked' lock, and then tells
339
 
           Lock1 to release and acquire the lockdir. This resets the 'check'
340
 
           lock.
341
 
        4) Lock2 acquires the 'check' lock, and checks again. It notices
342
 
           that the holder of the lock has changed, and so reports a new 
343
 
           lock holder.
344
 
        5) Thread1 blocks on the 'checked' lock, this time, it completely
345
 
           unlocks the lockdir, allowing Lock2 to acquire the lock.
346
 
        """
347
 
 
348
 
        wait_to_check_lock = Lock()
349
 
        wait_until_checked_lock = Lock()
350
 
 
351
 
        wait_to_check_lock.acquire()
352
 
        wait_until_checked_lock.acquire()
353
 
        note('locked check and checked locks')
354
 
 
355
 
        class LockDir1(LockDir):
356
 
            """Use the synchronization points for the first lock."""
357
 
 
358
 
            def attempt_lock(self):
359
 
                # Once we have acquired the lock, it is okay for
360
 
                # the other lock to check it
361
 
                try:
362
 
                    return super(LockDir1, self).attempt_lock()
363
 
                finally:
364
 
                    note('lock1: releasing check lock')
365
 
                    wait_to_check_lock.release()
366
 
 
367
 
        class LockDir2(LockDir):
368
 
            """Use the synchronization points for the second lock."""
369
 
 
370
 
            def attempt_lock(self):
371
 
                note('lock2: waiting for check lock')
372
 
                wait_to_check_lock.acquire()
373
 
                note('lock2: acquired check lock')
374
 
                try:
375
 
                    return super(LockDir2, self).attempt_lock()
376
 
                finally:
377
 
                    note('lock2: releasing checked lock')
378
 
                    wait_until_checked_lock.release()
379
 
 
380
 
        t = self.get_transport()
381
 
        lf1 = LockDir1(t, 'test_lock')
382
 
        lf1.create()
383
 
 
384
 
        lf2 = LockDir2(t, 'test_lock')
385
 
        self.setup_log_reporter(lf2)
386
 
 
387
 
        def wait_and_switch():
388
 
            lf1.attempt_lock()
389
 
            # Block until lock2 has had a chance to check
390
 
            note('lock1: waiting 1 for checked lock')
391
 
            wait_until_checked_lock.acquire()
392
 
            note('lock1: acquired for checked lock')
393
 
            note('lock1: released lockdir')
394
 
            lf1.unlock()
395
 
            note('lock1: acquiring lockdir')
396
 
            # Create a new nonce, so the lock looks different.
397
 
            lf1.nonce = osutils.rand_chars(20)
398
 
            lf1.lock_write()
399
 
            note('lock1: acquired lockdir')
400
 
 
401
 
            # Block until lock2 has peeked again
402
 
            note('lock1: waiting 2 for checked lock')
403
 
            wait_until_checked_lock.acquire()
404
 
            note('lock1: acquired for checked lock')
405
 
            # Now unlock, and let lock 2 grab the lock
406
 
            lf1.unlock()
407
 
            wait_to_check_lock.release()
408
 
 
409
 
        unlocker = Thread(target=wait_and_switch)
410
 
        unlocker.start()
411
 
        try:
412
 
            # Wait and play against the other thread
413
 
            lf2.wait_lock(timeout=1.0, poll=0.01)
414
 
        finally:
415
 
            unlocker.join()
416
 
        lf2.unlock()
417
 
 
418
 
        # There should be 2 reports, because the lock changed
419
 
        lock_base = lf2.transport.abspath(lf2.path)
420
 
        self.assertEqual(2, len(self._logged_reports))
421
 
 
422
 
        self.assertEqual('%s %s\n'
423
 
                         '%s\n%s\n'
424
 
                         'Will continue to try until %s\n',
425
 
                         self._logged_reports[0][0])
426
 
        args = self._logged_reports[0][1]
427
 
        self.assertEqual('Unable to obtain', args[0])
428
 
        self.assertEqual('lock %s' % (lock_base,), args[1])
429
 
        self.assertStartsWith(args[2], 'held by ')
430
 
        self.assertStartsWith(args[3], 'locked ')
431
 
        self.assertEndsWith(args[3], ' ago')
432
 
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
433
 
 
434
 
        self.assertEqual('%s %s\n'
435
 
                         '%s\n%s\n'
436
 
                         'Will continue to try until %s\n',
437
 
                         self._logged_reports[1][0])
438
 
        args = self._logged_reports[1][1]
439
 
        self.assertEqual('Lock owner changed for', args[0])
440
 
        self.assertEqual('lock %s' % (lock_base,), args[1])
441
 
        self.assertStartsWith(args[2], 'held by ')
442
 
        self.assertStartsWith(args[3], 'locked ')
443
 
        self.assertEndsWith(args[3], ' ago')
444
 
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
445
 
 
446
220
    def test_40_confirm_easy(self):
447
221
        """Confirm a lock that's already held"""
448
222
        t = self.get_transport()
449
223
        lf1 = LockDir(t, 'test_lock')
450
224
        lf1.create()
451
225
        lf1.attempt_lock()
 
226
        self.addCleanup(lf1.unlock)
452
227
        lf1.confirm()
453
228
 
454
229
    def test_41_confirm_not_held(self):
466
241
        lf1.attempt_lock()
467
242
        t.move('test_lock', 'lock_gone_now')
468
243
        self.assertRaises(LockBroken, lf1.confirm)
 
244
        # Clean up
 
245
        t.move('lock_gone_now', 'test_lock')
 
246
        lf1.unlock()
469
247
 
470
248
    def test_43_break(self):
471
249
        """Break a lock whose caller has forgotten it"""
482
260
        lf2.force_break(holder_info)
483
261
        # now we should be able to take it
484
262
        lf2.attempt_lock()
 
263
        self.addCleanup(lf2.unlock)
485
264
        lf2.confirm()
486
265
 
487
266
    def test_44_break_already_released(self):
499
278
        lf2.force_break(holder_info)
500
279
        # now we should be able to take it
501
280
        lf2.attempt_lock()
 
281
        self.addCleanup(lf2.unlock)
502
282
        lf2.confirm()
503
283
 
504
284
    def test_45_break_mismatch(self):
530
310
        """Check the on-disk representation of LockDirs is as expected.
531
311
 
532
312
        There should always be a top-level directory named by the lock.
533
 
        When the lock is held, there should be a lockname/held directory 
 
313
        When the lock is held, there should be a lockname/held directory
534
314
        containing an info file.
535
315
        """
536
316
        t = self.get_transport()
551
331
        # do this without IO redirection to ensure it doesn't prompt.
552
332
        self.assertRaises(AssertionError, ld1.break_lock)
553
333
        orig_factory = bzrlib.ui.ui_factory
554
 
        # silent ui - no need for stdout
555
 
        bzrlib.ui.ui_factory = bzrlib.ui.SilentUIFactory()
556
 
        bzrlib.ui.ui_factory.stdin = StringIO("y\n")
 
334
        bzrlib.ui.ui_factory = bzrlib.ui.CannedInputUIFactory([True])
557
335
        try:
558
336
            ld2.break_lock()
559
337
            self.assertRaises(LockBroken, ld1.unlock)
560
338
        finally:
561
339
            bzrlib.ui.ui_factory = orig_factory
562
340
 
 
341
    def test_break_lock_corrupt_info(self):
 
342
        """break_lock works even if the info file is corrupt (and tells the UI
 
343
        that it is corrupt).
 
344
        """
 
345
        ld = self.get_lock()
 
346
        ld2 = self.get_lock()
 
347
        ld.create()
 
348
        ld.lock_write()
 
349
        ld.transport.put_bytes_non_atomic('test_lock/held/info', '\0')
 
350
 
 
351
        class LoggingUIFactory(bzrlib.ui.SilentUIFactory):
 
352
            def __init__(self):
 
353
                self.prompts = []
 
354
 
 
355
            def get_boolean(self, prompt):
 
356
                self.prompts.append(('boolean', prompt))
 
357
                return True
 
358
 
 
359
        ui = LoggingUIFactory()
 
360
        self.overrideAttr(bzrlib.ui, 'ui_factory', ui)
 
361
        ld2.break_lock()
 
362
        self.assertLength(1, ui.prompts)
 
363
        self.assertEqual('boolean', ui.prompts[0][0])
 
364
        self.assertStartsWith(ui.prompts[0][1], 'Break (corrupt LockDir')
 
365
        self.assertRaises(LockBroken, ld.unlock)
 
366
 
 
367
    def test_break_lock_missing_info(self):
 
368
        """break_lock works even if the info file is missing (and tells the UI
 
369
        that it is corrupt).
 
370
        """
 
371
        ld = self.get_lock()
 
372
        ld2 = self.get_lock()
 
373
        ld.create()
 
374
        ld.lock_write()
 
375
        ld.transport.delete('test_lock/held/info')
 
376
 
 
377
        class LoggingUIFactory(bzrlib.ui.SilentUIFactory):
 
378
            def __init__(self):
 
379
                self.prompts = []
 
380
 
 
381
            def get_boolean(self, prompt):
 
382
                self.prompts.append(('boolean', prompt))
 
383
                return True
 
384
 
 
385
        ui = LoggingUIFactory()
 
386
        orig_factory = bzrlib.ui.ui_factory
 
387
        bzrlib.ui.ui_factory = ui
 
388
        try:
 
389
            ld2.break_lock()
 
390
            self.assertRaises(LockBroken, ld.unlock)
 
391
            self.assertLength(0, ui.prompts)
 
392
        finally:
 
393
            bzrlib.ui.ui_factory = orig_factory
 
394
        # Suppress warnings due to ld not being unlocked
 
395
        # XXX: if lock_broken hook was invoked in this case, this hack would
 
396
        # not be necessary.  - Andrew Bennetts, 2010-09-06.
 
397
        del self._lock_actions[:]
 
398
 
563
399
    def test_create_missing_base_directory(self):
564
400
        """If LockDir.path doesn't exist, it can be created
565
401
 
571
407
        lf1 = LockDir(t, 'test_lock')
572
408
 
573
409
        lf1.create()
574
 
        self.failUnless(t.has('test_lock'))
 
410
        self.assertTrue(t.has('test_lock'))
575
411
 
576
412
        t.rmdir('test_lock')
577
 
        self.failIf(t.has('test_lock'))
 
413
        self.assertFalse(t.has('test_lock'))
578
414
 
579
415
        # This will create 'test_lock' if it needs to
580
416
        lf1.lock_write()
581
 
        self.failUnless(t.has('test_lock'))
582
 
        self.failUnless(t.has('test_lock/held/info'))
 
417
        self.assertTrue(t.has('test_lock'))
 
418
        self.assertTrue(t.has('test_lock/held/info'))
583
419
 
584
420
        lf1.unlock()
585
 
        self.failIf(t.has('test_lock/held/info'))
 
421
        self.assertFalse(t.has('test_lock/held/info'))
586
422
 
587
 
    def test__format_lock_info(self):
 
423
    def test_display_form(self):
588
424
        ld1 = self.get_lock()
589
425
        ld1.create()
590
426
        ld1.lock_write()
591
427
        try:
592
 
            info_list = ld1._format_lock_info(ld1.peek())
 
428
            info_list = ld1.peek().to_readable_dict()
593
429
        finally:
594
430
            ld1.unlock()
595
 
        self.assertEqual('lock %s' % (ld1.transport.abspath(ld1.path),),
596
 
                         info_list[0])
597
 
        self.assertContainsRe(info_list[1],
598
 
                              r'^held by .* on host .* \[process #\d*\]$')
599
 
        self.assertContainsRe(info_list[2], r'locked \d+ seconds? ago$')
 
431
        self.assertEqual(info_list['user'], u'jrandom@example.com')
 
432
        self.assertContainsRe(info_list['pid'], '^\d+$')
 
433
        self.assertContainsRe(info_list['time_ago'], r'^\d+ seconds? ago$')
600
434
 
601
435
    def test_lock_without_email(self):
602
 
        global_config = config.GlobalConfig()
 
436
        global_config = config.GlobalStack()
603
437
        # Intentionally has no email address
604
 
        global_config.set_user_option('email', 'User Identity')
 
438
        global_config.set('email', 'User Identity')
605
439
        ld1 = self.get_lock()
606
440
        ld1.create()
607
441
        ld1.lock_write()
608
442
        ld1.unlock()
609
443
 
610
444
    def test_lock_permission(self):
 
445
        self.requireFeature(features.not_running_as_root)
611
446
        if not osutils.supports_posix_readonly():
612
447
            raise tests.TestSkipped('Cannot induce a permission failure')
613
448
        ld1 = self.get_lock()
614
449
        lock_path = ld1.transport.local_abspath('test_lock')
615
450
        os.mkdir(lock_path)
616
451
        osutils.make_readonly(lock_path)
617
 
        self.assertRaises(errors.PermissionDenied, ld1.attempt_lock)
 
452
        self.assertRaises(errors.LockFailed, ld1.attempt_lock)
 
453
 
 
454
    def test_lock_by_token(self):
 
455
        ld1 = self.get_lock()
 
456
        token = ld1.lock_write()
 
457
        self.addCleanup(ld1.unlock)
 
458
        self.assertNotEqual(None, token)
 
459
        ld2 = self.get_lock()
 
460
        t2 = ld2.lock_write(token)
 
461
        self.addCleanup(ld2.unlock)
 
462
        self.assertEqual(token, t2)
 
463
 
 
464
    def test_lock_with_buggy_rename(self):
 
465
        # test that lock acquisition handles servers which pretend they
 
466
        # renamed correctly but that actually fail
 
467
        t = transport.get_transport_from_url(
 
468
            'brokenrename+' + self.get_url())
 
469
        ld1 = LockDir(t, 'test_lock')
 
470
        ld1.create()
 
471
        ld1.attempt_lock()
 
472
        ld2 = LockDir(t, 'test_lock')
 
473
        # we should fail to lock
 
474
        e = self.assertRaises(errors.LockContention, ld2.attempt_lock)
 
475
        # now the original caller should succeed in unlocking
 
476
        ld1.unlock()
 
477
        # and there should be nothing left over
 
478
        self.assertEquals([], t.list_dir('test_lock'))
 
479
 
 
480
    def test_failed_lock_leaves_no_trash(self):
 
481
        # if we fail to acquire the lock, we don't leave pending directories
 
482
        # behind -- https://bugs.launchpad.net/bzr/+bug/109169
 
483
        ld1 = self.get_lock()
 
484
        ld2 = self.get_lock()
 
485
        # should be nothing before we start
 
486
        ld1.create()
 
487
        t = self.get_transport().clone('test_lock')
 
488
 
 
489
        def check_dir(a):
 
490
            self.assertEquals(a, t.list_dir('.'))
 
491
 
 
492
        check_dir([])
 
493
        # when held, that's all we see
 
494
        ld1.attempt_lock()
 
495
        self.addCleanup(ld1.unlock)
 
496
        check_dir(['held'])
 
497
        # second guy should fail
 
498
        self.assertRaises(errors.LockContention, ld2.attempt_lock)
 
499
        # no kibble
 
500
        check_dir(['held'])
 
501
 
 
502
    def test_no_lockdir_info(self):
 
503
        """We can cope with empty info files."""
 
504
        # This seems like a fairly common failure case - see
 
505
        # <https://bugs.launchpad.net/bzr/+bug/185103> and all its dupes.
 
506
        # Processes are often interrupted after opening the file
 
507
        # before the actual contents are committed.
 
508
        t = self.get_transport()
 
509
        t.mkdir('test_lock')
 
510
        t.mkdir('test_lock/held')
 
511
        t.put_bytes('test_lock/held/info', '')
 
512
        lf = LockDir(t, 'test_lock')
 
513
        info = lf.peek()
 
514
        formatted_info = info.to_readable_dict()
 
515
        self.assertEquals(
 
516
            dict(user='<unknown>', hostname='<unknown>', pid='<unknown>',
 
517
                time_ago='(unknown)'),
 
518
            formatted_info)
 
519
 
 
520
    def test_corrupt_lockdir_info(self):
 
521
        """We can cope with corrupt (and thus unparseable) info files."""
 
522
        # This seems like a fairly common failure case too - see
 
523
        # <https://bugs.launchpad.net/bzr/+bug/619872> for instance.
 
524
        # In particular some systems tend to fill recently created files with
 
525
        # nul bytes after recovering from a system crash.
 
526
        t = self.get_transport()
 
527
        t.mkdir('test_lock')
 
528
        t.mkdir('test_lock/held')
 
529
        t.put_bytes('test_lock/held/info', '\0')
 
530
        lf = LockDir(t, 'test_lock')
 
531
        self.assertRaises(errors.LockCorrupt, lf.peek)
 
532
        # Currently attempt_lock gives LockContention, but LockCorrupt would be
 
533
        # a reasonable result too.
 
534
        self.assertRaises(
 
535
            (errors.LockCorrupt, errors.LockContention), lf.attempt_lock)
 
536
        self.assertRaises(errors.LockCorrupt, lf.validate_token, 'fake token')
 
537
 
 
538
    def test_missing_lockdir_info(self):
 
539
        """We can cope with absent info files."""
 
540
        t = self.get_transport()
 
541
        t.mkdir('test_lock')
 
542
        t.mkdir('test_lock/held')
 
543
        lf = LockDir(t, 'test_lock')
 
544
        # In this case we expect the 'not held' result from peek, because peek
 
545
        # cannot be expected to notice that there is a 'held' directory with no
 
546
        # 'info' file.
 
547
        self.assertEqual(None, lf.peek())
 
548
        # And lock/unlock may work or give LockContention (but not any other
 
549
        # error).
 
550
        try:
 
551
            lf.attempt_lock()
 
552
        except LockContention:
 
553
            # LockContention is ok, and expected on Windows
 
554
            pass
 
555
        else:
 
556
            # no error is ok, and expected on POSIX (because POSIX allows
 
557
            # os.rename over an empty directory).
 
558
            lf.unlock()
 
559
        # Currently raises TokenMismatch, but LockCorrupt would be reasonable
 
560
        # too.
 
561
        self.assertRaises(
 
562
            (errors.TokenMismatch, errors.LockCorrupt),
 
563
            lf.validate_token, 'fake token')
 
564
 
 
565
 
 
566
class TestLockDirHooks(TestCaseWithTransport):
 
567
 
 
568
    def setUp(self):
 
569
        super(TestLockDirHooks, self).setUp()
 
570
        self._calls = []
 
571
 
 
572
    def get_lock(self):
 
573
        return LockDir(self.get_transport(), 'test_lock')
 
574
 
 
575
    def record_hook(self, result):
 
576
        self._calls.append(result)
 
577
 
 
578
    def test_LockDir_acquired_success(self):
 
579
        # the LockDir.lock_acquired hook fires when a lock is acquired.
 
580
        LockDir.hooks.install_named_hook('lock_acquired',
 
581
                                         self.record_hook, 'record_hook')
 
582
        ld = self.get_lock()
 
583
        ld.create()
 
584
        self.assertEqual([], self._calls)
 
585
        result = ld.attempt_lock()
 
586
        lock_path = ld.transport.abspath(ld.path)
 
587
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
 
588
        ld.unlock()
 
589
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
 
590
 
 
591
    def test_LockDir_acquired_fail(self):
 
592
        # the LockDir.lock_acquired hook does not fire on failure.
 
593
        ld = self.get_lock()
 
594
        ld.create()
 
595
        ld2 = self.get_lock()
 
596
        ld2.attempt_lock()
 
597
        # install a lock hook now, when the disk lock is locked
 
598
        LockDir.hooks.install_named_hook('lock_acquired',
 
599
                                         self.record_hook, 'record_hook')
 
600
        self.assertRaises(errors.LockContention, ld.attempt_lock)
 
601
        self.assertEqual([], self._calls)
 
602
        ld2.unlock()
 
603
        self.assertEqual([], self._calls)
 
604
 
 
605
    def test_LockDir_released_success(self):
 
606
        # the LockDir.lock_released hook fires when a lock is acquired.
 
607
        LockDir.hooks.install_named_hook('lock_released',
 
608
                                         self.record_hook, 'record_hook')
 
609
        ld = self.get_lock()
 
610
        ld.create()
 
611
        self.assertEqual([], self._calls)
 
612
        result = ld.attempt_lock()
 
613
        self.assertEqual([], self._calls)
 
614
        ld.unlock()
 
615
        lock_path = ld.transport.abspath(ld.path)
 
616
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
 
617
 
 
618
    def test_LockDir_released_fail(self):
 
619
        # the LockDir.lock_released hook does not fire on failure.
 
620
        ld = self.get_lock()
 
621
        ld.create()
 
622
        ld2 = self.get_lock()
 
623
        ld.attempt_lock()
 
624
        ld2.force_break(ld2.peek())
 
625
        LockDir.hooks.install_named_hook('lock_released',
 
626
                                         self.record_hook, 'record_hook')
 
627
        self.assertRaises(LockBroken, ld.unlock)
 
628
        self.assertEqual([], self._calls)
 
629
 
 
630
    def test_LockDir_broken_success(self):
 
631
        # the LockDir.lock_broken hook fires when a lock is broken.
 
632
        ld = self.get_lock()
 
633
        ld.create()
 
634
        ld2 = self.get_lock()
 
635
        result = ld.attempt_lock()
 
636
        LockDir.hooks.install_named_hook('lock_broken',
 
637
                                         self.record_hook, 'record_hook')
 
638
        ld2.force_break(ld2.peek())
 
639
        lock_path = ld.transport.abspath(ld.path)
 
640
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
 
641
 
 
642
    def test_LockDir_broken_failure(self):
 
643
        # the LockDir.lock_broken hook does not fires when a lock is already
 
644
        # released.
 
645
        ld = self.get_lock()
 
646
        ld.create()
 
647
        ld2 = self.get_lock()
 
648
        result = ld.attempt_lock()
 
649
        holder_info = ld2.peek()
 
650
        ld.unlock()
 
651
        LockDir.hooks.install_named_hook('lock_broken',
 
652
                                         self.record_hook, 'record_hook')
 
653
        ld2.force_break(holder_info)
 
654
        lock_path = ld.transport.abspath(ld.path)
 
655
        self.assertEqual([], self._calls)
 
656
 
 
657
 
 
658
class TestLockHeldInfo(TestCaseInTempDir):
 
659
    """Can get information about the lock holder, and detect whether they're
 
660
    still alive."""
 
661
 
 
662
    def test_repr(self):
 
663
        info = LockHeldInfo.for_this_process(None)
 
664
        self.assertContainsRe(repr(info), r"LockHeldInfo\(.*\)")
 
665
 
 
666
    def test_unicode(self):
 
667
        info = LockHeldInfo.for_this_process(None)
 
668
        self.assertContainsRe(unicode(info),
 
669
            r'held by .* on .* \(process #\d+\), acquired .* ago')
 
670
 
 
671
    def test_is_locked_by_this_process(self):
 
672
        info = LockHeldInfo.for_this_process(None)
 
673
        self.assertTrue(info.is_locked_by_this_process())
 
674
 
 
675
    def test_is_not_locked_by_this_process(self):
 
676
        info = LockHeldInfo.for_this_process(None)
 
677
        info.info_dict['pid'] = '123123123123123'
 
678
        self.assertFalse(info.is_locked_by_this_process())
 
679
 
 
680
    def test_lock_holder_live_process(self):
 
681
        """Detect that the holder (this process) is still running."""
 
682
        info = LockHeldInfo.for_this_process(None)
 
683
        self.assertFalse(info.is_lock_holder_known_dead())
 
684
 
 
685
    def test_lock_holder_dead_process(self):
 
686
        """Detect that the holder (this process) is still running."""
 
687
        self.overrideAttr(lockdir, 'get_host_name',
 
688
            lambda: 'aproperhostname')
 
689
        info = LockHeldInfo.for_this_process(None)
 
690
        info.info_dict['pid'] = '123123123'
 
691
        self.assertTrue(info.is_lock_holder_known_dead())
 
692
 
 
693
    def test_lock_holder_other_machine(self):
 
694
        """The lock holder isn't here so we don't know if they're alive."""
 
695
        info = LockHeldInfo.for_this_process(None)
 
696
        info.info_dict['hostname'] = 'egg.example.com'
 
697
        info.info_dict['pid'] = '123123123'
 
698
        self.assertFalse(info.is_lock_holder_known_dead())
 
699
 
 
700
    def test_lock_holder_other_user(self):
 
701
        """Only auto-break locks held by this user."""
 
702
        info = LockHeldInfo.for_this_process(None)
 
703
        info.info_dict['user'] = 'notme@example.com'
 
704
        info.info_dict['pid'] = '123123123'
 
705
        self.assertFalse(info.is_lock_holder_known_dead())
 
706
 
 
707
    def test_no_good_hostname(self):
 
708
        """Correctly handle ambiguous hostnames.
 
709
 
 
710
        If the lock's recorded with just 'localhost' we can't really trust
 
711
        it's the same 'localhost'.  (There are quite a few of them. :-)
 
712
        So even if the process is known not to be alive, we can't say that's
 
713
        known for sure.
 
714
        """
 
715
        self.overrideAttr(lockdir, 'get_host_name',
 
716
            lambda: 'localhost')
 
717
        info = LockHeldInfo.for_this_process(None)
 
718
        info.info_dict['pid'] = '123123123'
 
719
        self.assertFalse(info.is_lock_holder_known_dead())
 
720
 
 
721
 
 
722
class TestStaleLockDir(TestCaseWithTransport):
 
723
    """Can automatically break stale locks.
 
724
 
 
725
    :see: https://bugs.launchpad.net/bzr/+bug/220464
 
726
    """
 
727
 
 
728
    def test_auto_break_stale_lock(self):
 
729
        """Locks safely known to be stale are just cleaned up.
 
730
 
 
731
        This generates a warning but no other user interaction.
 
732
        """
 
733
        self.overrideAttr(lockdir, 'get_host_name',
 
734
            lambda: 'aproperhostname')
 
735
        # This is off by default at present; see the discussion in the bug.
 
736
        # If you change the default, don't forget to update the docs.
 
737
        config.GlobalStack().set('locks.steal_dead', True)
 
738
        # Create a lock pretending to come from a different nonexistent
 
739
        # process on the same machine.
 
740
        l1 = LockDir(self.get_transport(), 'a',
 
741
            extra_holder_info={'pid': '12312313'})
 
742
        token_1 = l1.attempt_lock()
 
743
        l2 = LockDir(self.get_transport(), 'a')
 
744
        token_2 = l2.attempt_lock()
 
745
        # l1 will notice its lock was stolen.
 
746
        self.assertRaises(errors.LockBroken,
 
747
            l1.unlock)
 
748
        l2.unlock()
 
749
 
 
750
    def test_auto_break_stale_lock_configured_off(self):
 
751
        """Automatic breaking can be turned off"""
 
752
        l1 = LockDir(self.get_transport(), 'a',
 
753
            extra_holder_info={'pid': '12312313'})
 
754
        token_1 = l1.attempt_lock()
 
755
        self.addCleanup(l1.unlock)
 
756
        l2 = LockDir(self.get_transport(), 'a')
 
757
        # This fails now, because dead lock breaking is off by default.
 
758
        self.assertRaises(LockContention,
 
759
            l2.attempt_lock)
 
760
        # and it's in fact not broken
 
761
        l1.confirm()