~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_config.py

  • Committer: Patch Queue Manager
  • Date: 2012-10-25 11:13:27 UTC
  • mfrom: (6570.1.6 rubberstamp)
  • Revision ID: pqm@pqm.ubuntu.com-20121025111327-p0ylql0nh9fla0rs
(gz) Set approved revision and vote "Approve" when using lp-propose
 --approve (Jonathan Lange)

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2012 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
17
"""Tests for finding and reading the bzr config file[s]."""
18
 
# import system imports here
 
18
 
 
19
import base64
19
20
from cStringIO import StringIO
 
21
from textwrap import dedent
20
22
import os
21
23
import sys
22
24
import threading
23
25
 
24
 
#import bzrlib specific imports here
 
26
from testtools import matchers
 
27
 
25
28
from bzrlib import (
26
29
    branch,
27
 
    bzrdir,
28
30
    config,
 
31
    controldir,
29
32
    diff,
30
33
    errors,
31
34
    osutils,
32
35
    mail_client,
33
36
    ui,
34
37
    urlutils,
 
38
    registry as _mod_registry,
 
39
    remote,
35
40
    tests,
36
41
    trace,
37
 
    transport,
38
 
    )
39
 
from bzrlib.tests import features
 
42
    )
 
43
from bzrlib.symbol_versioning import (
 
44
    deprecated_in,
 
45
    )
 
46
from bzrlib.transport import remote as transport_remote
 
47
from bzrlib.tests import (
 
48
    features,
 
49
    scenarios,
 
50
    test_server,
 
51
    )
40
52
from bzrlib.util.configobj import configobj
41
53
 
42
54
 
52
64
          'config_section': '.'}),]
53
65
 
54
66
 
55
 
def load_tests(standard_tests, module, loader):
56
 
    suite = loader.suiteClass()
57
 
 
58
 
    lc_tests, remaining_tests = tests.split_suite_by_condition(
59
 
        standard_tests, tests.condition_isinstance((
60
 
                TestLockableConfig,
61
 
                )))
62
 
    tests.multiply_tests(lc_tests, lockable_config_scenarios(), suite)
63
 
    suite.addTest(remaining_tests)
64
 
    return suite
 
67
load_tests = scenarios.load_tests_apply_scenarios
 
68
 
 
69
# Register helpers to build stores
 
70
config.test_store_builder_registry.register(
 
71
    'configobj', lambda test: config.TransportIniFileStore(
 
72
        test.get_transport(), 'configobj.conf'))
 
73
config.test_store_builder_registry.register(
 
74
    'bazaar', lambda test: config.GlobalStore())
 
75
config.test_store_builder_registry.register(
 
76
    'location', lambda test: config.LocationStore())
 
77
 
 
78
 
 
79
def build_backing_branch(test, relpath,
 
80
                         transport_class=None, server_class=None):
 
81
    """Test helper to create a backing branch only once.
 
82
 
 
83
    Some tests needs multiple stores/stacks to check concurrent update
 
84
    behaviours. As such, they need to build different branch *objects* even if
 
85
    they share the branch on disk.
 
86
 
 
87
    :param relpath: The relative path to the branch. (Note that the helper
 
88
        should always specify the same relpath).
 
89
 
 
90
    :param transport_class: The Transport class the test needs to use.
 
91
 
 
92
    :param server_class: The server associated with the ``transport_class``
 
93
        above.
 
94
 
 
95
    Either both or neither of ``transport_class`` and ``server_class`` should
 
96
    be specified.
 
97
    """
 
98
    if transport_class is not None and server_class is not None:
 
99
        test.transport_class = transport_class
 
100
        test.transport_server = server_class
 
101
    elif not (transport_class is None and server_class is None):
 
102
        raise AssertionError('Specify both ``transport_class`` and '
 
103
                             '``server_class`` or neither of them')
 
104
    if getattr(test, 'backing_branch', None) is None:
 
105
        # First call, let's build the branch on disk
 
106
        test.backing_branch = test.make_branch(relpath)
 
107
 
 
108
 
 
109
def build_branch_store(test):
 
110
    build_backing_branch(test, 'branch')
 
111
    b = branch.Branch.open('branch')
 
112
    return config.BranchStore(b)
 
113
config.test_store_builder_registry.register('branch', build_branch_store)
 
114
 
 
115
 
 
116
def build_control_store(test):
 
117
    build_backing_branch(test, 'branch')
 
118
    b = controldir.ControlDir.open('branch')
 
119
    return config.ControlStore(b)
 
120
config.test_store_builder_registry.register('control', build_control_store)
 
121
 
 
122
 
 
123
def build_remote_branch_store(test):
 
124
    # There is only one permutation (but we won't be able to handle more with
 
125
    # this design anyway)
 
126
    (transport_class,
 
127
     server_class) = transport_remote.get_test_permutations()[0]
 
128
    build_backing_branch(test, 'branch', transport_class, server_class)
 
129
    b = branch.Branch.open(test.get_url('branch'))
 
130
    return config.BranchStore(b)
 
131
config.test_store_builder_registry.register('remote_branch',
 
132
                                            build_remote_branch_store)
 
133
 
 
134
 
 
135
config.test_stack_builder_registry.register(
 
136
    'bazaar', lambda test: config.GlobalStack())
 
137
config.test_stack_builder_registry.register(
 
138
    'location', lambda test: config.LocationStack('.'))
 
139
 
 
140
 
 
141
def build_branch_stack(test):
 
142
    build_backing_branch(test, 'branch')
 
143
    b = branch.Branch.open('branch')
 
144
    return config.BranchStack(b)
 
145
config.test_stack_builder_registry.register('branch', build_branch_stack)
 
146
 
 
147
 
 
148
def build_branch_only_stack(test):
 
149
    # There is only one permutation (but we won't be able to handle more with
 
150
    # this design anyway)
 
151
    (transport_class,
 
152
     server_class) = transport_remote.get_test_permutations()[0]
 
153
    build_backing_branch(test, 'branch', transport_class, server_class)
 
154
    b = branch.Branch.open(test.get_url('branch'))
 
155
    return config.BranchOnlyStack(b)
 
156
config.test_stack_builder_registry.register('branch_only',
 
157
                                            build_branch_only_stack)
 
158
 
 
159
def build_remote_control_stack(test):
 
160
    # There is only one permutation (but we won't be able to handle more with
 
161
    # this design anyway)
 
162
    (transport_class,
 
163
     server_class) = transport_remote.get_test_permutations()[0]
 
164
    # We need only a bzrdir for this, not a full branch, but it's not worth
 
165
    # creating a dedicated helper to create only the bzrdir
 
166
    build_backing_branch(test, 'branch', transport_class, server_class)
 
167
    b = branch.Branch.open(test.get_url('branch'))
 
168
    return config.RemoteControlStack(b.bzrdir)
 
169
config.test_stack_builder_registry.register('remote_control',
 
170
                                            build_remote_control_stack)
65
171
 
66
172
 
67
173
sample_long_alias="log -r-15..-1 --line"
71
177
editor=vim
72
178
change_editor=vimdiff -of @new_path @old_path
73
179
gpg_signing_command=gnome-gpg
 
180
gpg_signing_key=DD4D5088
74
181
log_format=short
 
182
validate_signatures_in_log=true
 
183
acceptable_keys=amy
75
184
user_global_option=something
 
185
bzr.mergetool.sometool=sometool {base} {this} {other} -o {result}
 
186
bzr.mergetool.funkytool=funkytool "arg with spaces" {this_temp}
 
187
bzr.mergetool.newtool='"newtool with spaces" {this_temp}'
 
188
bzr.default_mergetool=sometool
76
189
[ALIASES]
77
190
h=help
78
191
ll=""" + sample_long_alias + "\n"
120
233
[/a/]
121
234
check_signatures=check-available
122
235
gpg_signing_command=false
 
236
gpg_signing_key=default
123
237
user_local_option=local
124
238
# test trailing / matching
125
239
[/a/*]
131
245
"""
132
246
 
133
247
 
 
248
def create_configs(test):
 
249
    """Create configuration files for a given test.
 
250
 
 
251
    This requires creating a tree (and populate the ``test.tree`` attribute)
 
252
    and its associated branch and will populate the following attributes:
 
253
 
 
254
    - branch_config: A BranchConfig for the associated branch.
 
255
 
 
256
    - locations_config : A LocationConfig for the associated branch
 
257
 
 
258
    - bazaar_config: A GlobalConfig.
 
259
 
 
260
    The tree and branch are created in a 'tree' subdirectory so the tests can
 
261
    still use the test directory to stay outside of the branch.
 
262
    """
 
263
    tree = test.make_branch_and_tree('tree')
 
264
    test.tree = tree
 
265
    test.branch_config = config.BranchConfig(tree.branch)
 
266
    test.locations_config = config.LocationConfig(tree.basedir)
 
267
    test.bazaar_config = config.GlobalConfig()
 
268
 
 
269
 
 
270
def create_configs_with_file_option(test):
 
271
    """Create configuration files with a ``file`` option set in each.
 
272
 
 
273
    This builds on ``create_configs`` and add one ``file`` option in each
 
274
    configuration with a value which allows identifying the configuration file.
 
275
    """
 
276
    create_configs(test)
 
277
    test.bazaar_config.set_user_option('file', 'bazaar')
 
278
    test.locations_config.set_user_option('file', 'locations')
 
279
    test.branch_config.set_user_option('file', 'branch')
 
280
 
 
281
 
 
282
class TestOptionsMixin:
 
283
 
 
284
    def assertOptions(self, expected, conf):
 
285
        # We don't care about the parser (as it will make tests hard to write
 
286
        # and error-prone anyway)
 
287
        self.assertThat([opt[:4] for opt in conf._get_options()],
 
288
                        matchers.Equals(expected))
 
289
 
 
290
 
134
291
class InstrumentedConfigObj(object):
135
292
    """A config obj look-enough-alike to record calls made to it."""
136
293
 
172
329
 
173
330
class FakeBranch(object):
174
331
 
175
 
    def __init__(self, base=None, user_id=None):
 
332
    def __init__(self, base=None):
176
333
        if base is None:
177
334
            self.base = "http://example.com/branches/demo"
178
335
        else:
179
336
            self.base = base
180
337
        self._transport = self.control_files = \
181
 
            FakeControlFilesAndTransport(user_id=user_id)
 
338
            FakeControlFilesAndTransport()
182
339
 
183
340
    def _get_config(self):
184
341
        return config.TransportConfig(self._transport, 'branch.conf')
192
349
 
193
350
class FakeControlFilesAndTransport(object):
194
351
 
195
 
    def __init__(self, user_id=None):
 
352
    def __init__(self):
196
353
        self.files = {}
197
 
        if user_id:
198
 
            self.files['email'] = user_id
199
354
        self._transport = self
200
355
 
201
 
    def get_utf8(self, filename):
202
 
        # from LockableFiles
203
 
        raise AssertionError("get_utf8 should no longer be used")
204
 
 
205
356
    def get(self, filename):
206
357
        # from Transport
207
358
        try:
269
420
        """
270
421
        co = config.ConfigObj()
271
422
        co['test'] = 'foo#bar'
272
 
        lines = co.write()
 
423
        outfile = StringIO()
 
424
        co.write(outfile=outfile)
 
425
        lines = outfile.getvalue().splitlines()
273
426
        self.assertEqual(lines, ['test = "foo#bar"'])
274
427
        co2 = config.ConfigObj(lines)
275
428
        self.assertEqual(co2['test'], 'foo#bar')
276
429
 
 
430
    def test_triple_quotes(self):
 
431
        # Bug #710410: if the value string has triple quotes
 
432
        # then ConfigObj versions up to 4.7.2 will quote them wrong
 
433
        # and won't able to read them back
 
434
        triple_quotes_value = '''spam
 
435
""" that's my spam """
 
436
eggs'''
 
437
        co = config.ConfigObj()
 
438
        co['test'] = triple_quotes_value
 
439
        # While writing this test another bug in ConfigObj has been found:
 
440
        # method co.write() without arguments produces list of lines
 
441
        # one option per line, and multiline values are not split
 
442
        # across multiple lines,
 
443
        # and that breaks the parsing these lines back by ConfigObj.
 
444
        # This issue only affects test, but it's better to avoid
 
445
        # `co.write()` construct at all.
 
446
        # [bialix 20110222] bug report sent to ConfigObj's author
 
447
        outfile = StringIO()
 
448
        co.write(outfile=outfile)
 
449
        output = outfile.getvalue()
 
450
        # now we're trying to read it back
 
451
        co2 = config.ConfigObj(StringIO(output))
 
452
        self.assertEquals(triple_quotes_value, co2['test'])
 
453
 
277
454
 
278
455
erroneous_config = """[section] # line 1
279
456
good=good # line 2
299
476
    def test_constructs(self):
300
477
        config.Config()
301
478
 
302
 
    def test_no_default_editor(self):
303
 
        self.assertRaises(NotImplementedError, config.Config().get_editor)
304
 
 
305
479
    def test_user_email(self):
306
480
        my_config = InstrumentedConfig()
307
481
        self.assertEqual('robert.collins@example.org', my_config.user_email())
315
489
 
316
490
    def test_signatures_default(self):
317
491
        my_config = config.Config()
318
 
        self.assertFalse(my_config.signature_needed())
 
492
        self.assertFalse(
 
493
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
494
                my_config.signature_needed))
319
495
        self.assertEqual(config.CHECK_IF_POSSIBLE,
320
 
                         my_config.signature_checking())
 
496
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
497
                my_config.signature_checking))
321
498
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
322
 
                         my_config.signing_policy())
 
499
                self.applyDeprecated(deprecated_in((2, 5, 0)),
 
500
                    my_config.signing_policy))
323
501
 
324
502
    def test_signatures_template_method(self):
325
503
        my_config = InstrumentedConfig()
326
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
 
504
        self.assertEqual(config.CHECK_NEVER,
 
505
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
506
                my_config.signature_checking))
327
507
        self.assertEqual(['_get_signature_checking'], my_config._calls)
328
508
 
329
509
    def test_signatures_template_method_none(self):
330
510
        my_config = InstrumentedConfig()
331
511
        my_config._signatures = None
332
512
        self.assertEqual(config.CHECK_IF_POSSIBLE,
333
 
                         my_config.signature_checking())
 
513
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
514
                             my_config.signature_checking))
334
515
        self.assertEqual(['_get_signature_checking'], my_config._calls)
335
516
 
336
517
    def test_gpg_signing_command_default(self):
337
518
        my_config = config.Config()
338
 
        self.assertEqual('gpg', my_config.gpg_signing_command())
 
519
        self.assertEqual('gpg',
 
520
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
521
                my_config.gpg_signing_command))
339
522
 
340
523
    def test_get_user_option_default(self):
341
524
        my_config = config.Config()
343
526
 
344
527
    def test_post_commit_default(self):
345
528
        my_config = config.Config()
346
 
        self.assertEqual(None, my_config.post_commit())
 
529
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
530
                                                    my_config.post_commit))
 
531
 
347
532
 
348
533
    def test_log_format_default(self):
349
534
        my_config = config.Config()
350
 
        self.assertEqual('long', my_config.log_format())
 
535
        self.assertEqual('long',
 
536
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
537
                                              my_config.log_format))
 
538
 
 
539
    def test_acceptable_keys_default(self):
 
540
        my_config = config.Config()
 
541
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
542
            my_config.acceptable_keys))
 
543
 
 
544
    def test_validate_signatures_in_log_default(self):
 
545
        my_config = config.Config()
 
546
        self.assertEqual(False, my_config.validate_signatures_in_log())
351
547
 
352
548
    def test_get_change_editor(self):
353
549
        my_config = InstrumentedConfig()
362
558
 
363
559
    def setUp(self):
364
560
        super(TestConfigPath, self).setUp()
365
 
        os.environ['HOME'] = '/home/bogus'
366
 
        os.environ['XDG_CACHE_DIR'] = ''
 
561
        self.overrideEnv('HOME', '/home/bogus')
 
562
        self.overrideEnv('XDG_CACHE_DIR', '')
367
563
        if sys.platform == 'win32':
368
 
            os.environ['BZR_HOME'] = \
369
 
                r'C:\Documents and Settings\bogus\Application Data'
 
564
            self.overrideEnv(
 
565
                'BZR_HOME', r'C:\Documents and Settings\bogus\Application Data')
370
566
            self.bzr_home = \
371
567
                'C:/Documents and Settings/bogus/Application Data/bazaar/2.0'
372
568
        else:
375
571
    def test_config_dir(self):
376
572
        self.assertEqual(config.config_dir(), self.bzr_home)
377
573
 
 
574
    def test_config_dir_is_unicode(self):
 
575
        self.assertIsInstance(config.config_dir(), unicode)
 
576
 
378
577
    def test_config_filename(self):
379
578
        self.assertEqual(config.config_filename(),
380
579
                         self.bzr_home + '/bazaar.conf')
392
591
            '/home/bogus/.cache')
393
592
 
394
593
 
 
594
class TestXDGConfigDir(tests.TestCaseInTempDir):
 
595
    # must be in temp dir because config tests for the existence of the bazaar
 
596
    # subdirectory of $XDG_CONFIG_HOME
 
597
 
 
598
    def setUp(self):
 
599
        if sys.platform in ('darwin', 'win32'):
 
600
            raise tests.TestNotApplicable(
 
601
                'XDG config dir not used on this platform')
 
602
        super(TestXDGConfigDir, self).setUp()
 
603
        self.overrideEnv('HOME', self.test_home_dir)
 
604
        # BZR_HOME overrides everything we want to test so unset it.
 
605
        self.overrideEnv('BZR_HOME', None)
 
606
 
 
607
    def test_xdg_config_dir_exists(self):
 
608
        """When ~/.config/bazaar exists, use it as the config dir."""
 
609
        newdir = osutils.pathjoin(self.test_home_dir, '.config', 'bazaar')
 
610
        os.makedirs(newdir)
 
611
        self.assertEqual(config.config_dir(), newdir)
 
612
 
 
613
    def test_xdg_config_home(self):
 
614
        """When XDG_CONFIG_HOME is set, use it."""
 
615
        xdgconfigdir = osutils.pathjoin(self.test_home_dir, 'xdgconfig')
 
616
        self.overrideEnv('XDG_CONFIG_HOME', xdgconfigdir)
 
617
        newdir = osutils.pathjoin(xdgconfigdir, 'bazaar')
 
618
        os.makedirs(newdir)
 
619
        self.assertEqual(config.config_dir(), newdir)
 
620
 
 
621
 
395
622
class TestIniConfig(tests.TestCaseInTempDir):
396
623
 
397
624
    def make_config_parser(self, s):
411
638
    def test_cached(self):
412
639
        my_config = config.IniBasedConfig.from_string(sample_config_text)
413
640
        parser = my_config._get_parser()
414
 
        self.failUnless(my_config._get_parser() is parser)
 
641
        self.assertTrue(my_config._get_parser() is parser)
415
642
 
416
643
    def _dummy_chown(self, path, uid, gid):
417
644
        self.path, self.uid, self.gid = path, uid, gid
442
669
            ' Use IniBasedConfig(_content=xxx) instead.'],
443
670
            conf._get_parser, file=config_file)
444
671
 
 
672
 
445
673
class TestIniConfigSaving(tests.TestCaseInTempDir):
446
674
 
447
675
    def test_cant_save_without_a_file_name(self):
455
683
        self.assertFileEqual(content, 'test.conf')
456
684
 
457
685
 
 
686
class TestIniConfigOptionExpansion(tests.TestCase):
 
687
    """Test option expansion from the IniConfig level.
 
688
 
 
689
    What we really want here is to test the Config level, but the class being
 
690
    abstract as far as storing values is concerned, this can't be done
 
691
    properly (yet).
 
692
    """
 
693
    # FIXME: This should be rewritten when all configs share a storage
 
694
    # implementation -- vila 2011-02-18
 
695
 
 
696
    def get_config(self, string=None):
 
697
        if string is None:
 
698
            string = ''
 
699
        c = config.IniBasedConfig.from_string(string)
 
700
        return c
 
701
 
 
702
    def assertExpansion(self, expected, conf, string, env=None):
 
703
        self.assertEquals(expected, conf.expand_options(string, env))
 
704
 
 
705
    def test_no_expansion(self):
 
706
        c = self.get_config('')
 
707
        self.assertExpansion('foo', c, 'foo')
 
708
 
 
709
    def test_env_adding_options(self):
 
710
        c = self.get_config('')
 
711
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
 
712
 
 
713
    def test_env_overriding_options(self):
 
714
        c = self.get_config('foo=baz')
 
715
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
 
716
 
 
717
    def test_simple_ref(self):
 
718
        c = self.get_config('foo=xxx')
 
719
        self.assertExpansion('xxx', c, '{foo}')
 
720
 
 
721
    def test_unknown_ref(self):
 
722
        c = self.get_config('')
 
723
        self.assertRaises(errors.ExpandingUnknownOption,
 
724
                          c.expand_options, '{foo}')
 
725
 
 
726
    def test_indirect_ref(self):
 
727
        c = self.get_config('''
 
728
foo=xxx
 
729
bar={foo}
 
730
''')
 
731
        self.assertExpansion('xxx', c, '{bar}')
 
732
 
 
733
    def test_embedded_ref(self):
 
734
        c = self.get_config('''
 
735
foo=xxx
 
736
bar=foo
 
737
''')
 
738
        self.assertExpansion('xxx', c, '{{bar}}')
 
739
 
 
740
    def test_simple_loop(self):
 
741
        c = self.get_config('foo={foo}')
 
742
        self.assertRaises(errors.OptionExpansionLoop, c.expand_options, '{foo}')
 
743
 
 
744
    def test_indirect_loop(self):
 
745
        c = self.get_config('''
 
746
foo={bar}
 
747
bar={baz}
 
748
baz={foo}''')
 
749
        e = self.assertRaises(errors.OptionExpansionLoop,
 
750
                              c.expand_options, '{foo}')
 
751
        self.assertEquals('foo->bar->baz', e.refs)
 
752
        self.assertEquals('{foo}', e.string)
 
753
 
 
754
    def test_list(self):
 
755
        conf = self.get_config('''
 
756
foo=start
 
757
bar=middle
 
758
baz=end
 
759
list={foo},{bar},{baz}
 
760
''')
 
761
        self.assertEquals(['start', 'middle', 'end'],
 
762
                           conf.get_user_option('list', expand=True))
 
763
 
 
764
    def test_cascading_list(self):
 
765
        conf = self.get_config('''
 
766
foo=start,{bar}
 
767
bar=middle,{baz}
 
768
baz=end
 
769
list={foo}
 
770
''')
 
771
        self.assertEquals(['start', 'middle', 'end'],
 
772
                           conf.get_user_option('list', expand=True))
 
773
 
 
774
    def test_pathological_hidden_list(self):
 
775
        conf = self.get_config('''
 
776
foo=bin
 
777
bar=go
 
778
start={foo
 
779
middle=},{
 
780
end=bar}
 
781
hidden={start}{middle}{end}
 
782
''')
 
783
        # Nope, it's either a string or a list, and the list wins as soon as a
 
784
        # ',' appears, so the string concatenation never occur.
 
785
        self.assertEquals(['{foo', '}', '{', 'bar}'],
 
786
                          conf.get_user_option('hidden', expand=True))
 
787
 
 
788
 
 
789
class TestLocationConfigOptionExpansion(tests.TestCaseInTempDir):
 
790
 
 
791
    def get_config(self, location, string=None):
 
792
        if string is None:
 
793
            string = ''
 
794
        # Since we don't save the config we won't strictly require to inherit
 
795
        # from TestCaseInTempDir, but an error occurs so quickly...
 
796
        c = config.LocationConfig.from_string(string, location)
 
797
        return c
 
798
 
 
799
    def test_dont_cross_unrelated_section(self):
 
800
        c = self.get_config('/another/branch/path','''
 
801
[/one/branch/path]
 
802
foo = hello
 
803
bar = {foo}/2
 
804
 
 
805
[/another/branch/path]
 
806
bar = {foo}/2
 
807
''')
 
808
        self.assertRaises(errors.ExpandingUnknownOption,
 
809
                          c.get_user_option, 'bar', expand=True)
 
810
 
 
811
    def test_cross_related_sections(self):
 
812
        c = self.get_config('/project/branch/path','''
 
813
[/project]
 
814
foo = qu
 
815
 
 
816
[/project/branch/path]
 
817
bar = {foo}ux
 
818
''')
 
819
        self.assertEquals('quux', c.get_user_option('bar', expand=True))
 
820
 
 
821
 
458
822
class TestIniBaseConfigOnDisk(tests.TestCaseInTempDir):
459
823
 
460
824
    def test_cannot_reload_without_name(self):
477
841
 
478
842
class TestLockableConfig(tests.TestCaseInTempDir):
479
843
 
 
844
    scenarios = lockable_config_scenarios()
 
845
 
480
846
    # Set by load_tests
481
847
    config_class = None
482
848
    config_args = None
538
904
        def c1_write_config_file():
539
905
            before_writing.set()
540
906
            c1_orig()
541
 
            # The lock is held we wait for the main thread to decide when to
 
907
            # The lock is held. We wait for the main thread to decide when to
542
908
            # continue
543
909
            after_writing.wait()
544
910
        c1._write_config_file = c1_write_config_file
571
937
       c1_orig = c1._write_config_file
572
938
       def c1_write_config_file():
573
939
           ready_to_write.set()
574
 
           # The lock is held we wait for the main thread to decide when to
 
940
           # The lock is held. We wait for the main thread to decide when to
575
941
           # continue
576
942
           do_writing.wait()
577
943
           c1_orig()
636
1002
        # automatically cast to list
637
1003
        self.assertEqual(['x'], get_list('one_item'))
638
1004
 
 
1005
    def test_get_user_option_as_int_from_SI(self):
 
1006
        conf, parser = self.make_config_parser("""
 
1007
plain = 100
 
1008
si_k = 5k,
 
1009
si_kb = 5kb,
 
1010
si_m = 5M,
 
1011
si_mb = 5MB,
 
1012
si_g = 5g,
 
1013
si_gb = 5gB,
 
1014
""")
 
1015
        def get_si(s, default=None):
 
1016
            return self.applyDeprecated(
 
1017
                deprecated_in((2, 5, 0)),
 
1018
                conf.get_user_option_as_int_from_SI, s, default)
 
1019
        self.assertEqual(100, get_si('plain'))
 
1020
        self.assertEqual(5000, get_si('si_k'))
 
1021
        self.assertEqual(5000, get_si('si_kb'))
 
1022
        self.assertEqual(5000000, get_si('si_m'))
 
1023
        self.assertEqual(5000000, get_si('si_mb'))
 
1024
        self.assertEqual(5000000000, get_si('si_g'))
 
1025
        self.assertEqual(5000000000, get_si('si_gb'))
 
1026
        self.assertEqual(None, get_si('non-exist'))
 
1027
        self.assertEqual(42, get_si('non-exist-with-default',  42))
 
1028
 
639
1029
 
640
1030
class TestSupressWarning(TestIniConfig):
641
1031
 
668
1058
            parser = my_config._get_parser()
669
1059
        finally:
670
1060
            config.ConfigObj = oldparserclass
671
 
        self.failUnless(isinstance(parser, InstrumentedConfigObj))
 
1061
        self.assertIsInstance(parser, InstrumentedConfigObj)
672
1062
        self.assertEqual(parser._calls, [('__init__', config.config_filename(),
673
1063
                                          'utf-8')])
674
1064
 
685
1075
        my_config = config.BranchConfig(branch)
686
1076
        location_config = my_config._get_location_config()
687
1077
        self.assertEqual(branch.base, location_config.location)
688
 
        self.failUnless(location_config is my_config._get_location_config())
 
1078
        self.assertIs(location_config, my_config._get_location_config())
689
1079
 
690
1080
    def test_get_config(self):
691
1081
        """The Branch.get_config method works properly"""
692
 
        b = bzrdir.BzrDir.create_standalone_workingtree('.').branch
 
1082
        b = controldir.ControlDir.create_standalone_workingtree('.').branch
693
1083
        my_config = b.get_config()
694
1084
        self.assertIs(my_config.get_user_option('wacky'), None)
695
1085
        my_config.set_user_option('wacky', 'unlikely')
744
1134
        b = self.make_branch('!repo')
745
1135
        self.assertEqual('!repo', b.get_config().get_nickname())
746
1136
 
 
1137
    def test_autonick_uses_branch_name(self):
 
1138
        b = self.make_branch('foo', name='bar')
 
1139
        self.assertEqual('bar', b.get_config().get_nickname())
 
1140
 
747
1141
    def test_warn_if_masked(self):
748
1142
        warnings = []
749
1143
        def warning(*args):
789
1183
        my_config = config.GlobalConfig()
790
1184
        self.assertEqual(None, my_config._get_user_id())
791
1185
 
792
 
    def test_configured_editor(self):
793
 
        my_config = config.GlobalConfig.from_string(sample_config_text)
794
 
        self.assertEqual("vim", my_config.get_editor())
795
 
 
796
1186
    def test_signatures_always(self):
797
1187
        my_config = config.GlobalConfig.from_string(sample_always_signatures)
798
1188
        self.assertEqual(config.CHECK_NEVER,
799
 
                         my_config.signature_checking())
 
1189
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1190
                             my_config.signature_checking))
800
1191
        self.assertEqual(config.SIGN_ALWAYS,
801
 
                         my_config.signing_policy())
802
 
        self.assertEqual(True, my_config.signature_needed())
 
1192
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1193
                             my_config.signing_policy))
 
1194
        self.assertEqual(True,
 
1195
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1196
                my_config.signature_needed))
803
1197
 
804
1198
    def test_signatures_if_possible(self):
805
1199
        my_config = config.GlobalConfig.from_string(sample_maybe_signatures)
806
1200
        self.assertEqual(config.CHECK_NEVER,
807
 
                         my_config.signature_checking())
 
1201
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1202
                             my_config.signature_checking))
808
1203
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
809
 
                         my_config.signing_policy())
810
 
        self.assertEqual(False, my_config.signature_needed())
 
1204
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1205
                             my_config.signing_policy))
 
1206
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1207
            my_config.signature_needed))
811
1208
 
812
1209
    def test_signatures_ignore(self):
813
1210
        my_config = config.GlobalConfig.from_string(sample_ignore_signatures)
814
1211
        self.assertEqual(config.CHECK_ALWAYS,
815
 
                         my_config.signature_checking())
 
1212
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1213
                             my_config.signature_checking))
816
1214
        self.assertEqual(config.SIGN_NEVER,
817
 
                         my_config.signing_policy())
818
 
        self.assertEqual(False, my_config.signature_needed())
 
1215
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1216
                             my_config.signing_policy))
 
1217
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1218
            my_config.signature_needed))
819
1219
 
820
1220
    def _get_sample_config(self):
821
1221
        my_config = config.GlobalConfig.from_string(sample_config_text)
823
1223
 
824
1224
    def test_gpg_signing_command(self):
825
1225
        my_config = self._get_sample_config()
826
 
        self.assertEqual("gnome-gpg", my_config.gpg_signing_command())
827
 
        self.assertEqual(False, my_config.signature_needed())
 
1226
        self.assertEqual("gnome-gpg",
 
1227
            self.applyDeprecated(
 
1228
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
 
1229
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1230
            my_config.signature_needed))
 
1231
 
 
1232
    def test_gpg_signing_key(self):
 
1233
        my_config = self._get_sample_config()
 
1234
        self.assertEqual("DD4D5088",
 
1235
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1236
                my_config.gpg_signing_key))
828
1237
 
829
1238
    def _get_empty_config(self):
830
1239
        my_config = config.GlobalConfig()
832
1241
 
833
1242
    def test_gpg_signing_command_unset(self):
834
1243
        my_config = self._get_empty_config()
835
 
        self.assertEqual("gpg", my_config.gpg_signing_command())
 
1244
        self.assertEqual("gpg",
 
1245
            self.applyDeprecated(
 
1246
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
836
1247
 
837
1248
    def test_get_user_option_default(self):
838
1249
        my_config = self._get_empty_config()
845
1256
 
846
1257
    def test_post_commit_default(self):
847
1258
        my_config = self._get_sample_config()
848
 
        self.assertEqual(None, my_config.post_commit())
 
1259
        self.assertEqual(None,
 
1260
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1261
                                              my_config.post_commit))
849
1262
 
850
1263
    def test_configured_logformat(self):
851
1264
        my_config = self._get_sample_config()
852
 
        self.assertEqual("short", my_config.log_format())
 
1265
        self.assertEqual("short",
 
1266
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1267
                                              my_config.log_format))
 
1268
 
 
1269
    def test_configured_acceptable_keys(self):
 
1270
        my_config = self._get_sample_config()
 
1271
        self.assertEqual("amy",
 
1272
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1273
                my_config.acceptable_keys))
 
1274
 
 
1275
    def test_configured_validate_signatures_in_log(self):
 
1276
        my_config = self._get_sample_config()
 
1277
        self.assertEqual(True, my_config.validate_signatures_in_log())
853
1278
 
854
1279
    def test_get_alias(self):
855
1280
        my_config = self._get_sample_config()
883
1308
        change_editor = my_config.get_change_editor('old', 'new')
884
1309
        self.assertIs(None, change_editor)
885
1310
 
 
1311
    def test_get_merge_tools(self):
 
1312
        conf = self._get_sample_config()
 
1313
        tools = conf.get_merge_tools()
 
1314
        self.log(repr(tools))
 
1315
        self.assertEqual(
 
1316
            {u'funkytool' : u'funkytool "arg with spaces" {this_temp}',
 
1317
            u'sometool' : u'sometool {base} {this} {other} -o {result}',
 
1318
            u'newtool' : u'"newtool with spaces" {this_temp}'},
 
1319
            tools)
 
1320
 
 
1321
    def test_get_merge_tools_empty(self):
 
1322
        conf = self._get_empty_config()
 
1323
        tools = conf.get_merge_tools()
 
1324
        self.assertEqual({}, tools)
 
1325
 
 
1326
    def test_find_merge_tool(self):
 
1327
        conf = self._get_sample_config()
 
1328
        cmdline = conf.find_merge_tool('sometool')
 
1329
        self.assertEqual('sometool {base} {this} {other} -o {result}', cmdline)
 
1330
 
 
1331
    def test_find_merge_tool_not_found(self):
 
1332
        conf = self._get_sample_config()
 
1333
        cmdline = conf.find_merge_tool('DOES NOT EXIST')
 
1334
        self.assertIs(cmdline, None)
 
1335
 
 
1336
    def test_find_merge_tool_known(self):
 
1337
        conf = self._get_empty_config()
 
1338
        cmdline = conf.find_merge_tool('kdiff3')
 
1339
        self.assertEquals('kdiff3 {base} {this} {other} -o {result}', cmdline)
 
1340
 
 
1341
    def test_find_merge_tool_override_known(self):
 
1342
        conf = self._get_empty_config()
 
1343
        conf.set_user_option('bzr.mergetool.kdiff3', 'kdiff3 blah')
 
1344
        cmdline = conf.find_merge_tool('kdiff3')
 
1345
        self.assertEqual('kdiff3 blah', cmdline)
 
1346
 
886
1347
 
887
1348
class TestGlobalConfigSavingOptions(tests.TestCaseInTempDir):
888
1349
 
906
1367
        self.assertIs(None, new_config.get_alias('commit'))
907
1368
 
908
1369
 
909
 
class TestLocationConfig(tests.TestCaseInTempDir):
 
1370
class TestLocationConfig(tests.TestCaseInTempDir, TestOptionsMixin):
910
1371
 
911
1372
    def test_constructs(self):
912
1373
        my_config = config.LocationConfig('http://example.com')
924
1385
            parser = my_config._get_parser()
925
1386
        finally:
926
1387
            config.ConfigObj = oldparserclass
927
 
        self.failUnless(isinstance(parser, InstrumentedConfigObj))
 
1388
        self.assertIsInstance(parser, InstrumentedConfigObj)
928
1389
        self.assertEqual(parser._calls,
929
1390
                         [('__init__', config.locations_config_filename(),
930
1391
                           'utf-8')])
932
1393
    def test_get_global_config(self):
933
1394
        my_config = config.BranchConfig(FakeBranch('http://example.com'))
934
1395
        global_config = my_config._get_global_config()
935
 
        self.failUnless(isinstance(global_config, config.GlobalConfig))
936
 
        self.failUnless(global_config is my_config._get_global_config())
 
1396
        self.assertIsInstance(global_config, config.GlobalConfig)
 
1397
        self.assertIs(global_config, my_config._get_global_config())
 
1398
 
 
1399
    def assertLocationMatching(self, expected):
 
1400
        self.assertEqual(expected,
 
1401
                         list(self.my_location_config._get_matching_sections()))
937
1402
 
938
1403
    def test__get_matching_sections_no_match(self):
939
1404
        self.get_branch_config('/')
940
 
        self.assertEqual([], self.my_location_config._get_matching_sections())
 
1405
        self.assertLocationMatching([])
941
1406
 
942
1407
    def test__get_matching_sections_exact(self):
943
1408
        self.get_branch_config('http://www.example.com')
944
 
        self.assertEqual([('http://www.example.com', '')],
945
 
                         self.my_location_config._get_matching_sections())
 
1409
        self.assertLocationMatching([('http://www.example.com', '')])
946
1410
 
947
1411
    def test__get_matching_sections_suffix_does_not(self):
948
1412
        self.get_branch_config('http://www.example.com-com')
949
 
        self.assertEqual([], self.my_location_config._get_matching_sections())
 
1413
        self.assertLocationMatching([])
950
1414
 
951
1415
    def test__get_matching_sections_subdir_recursive(self):
952
1416
        self.get_branch_config('http://www.example.com/com')
953
 
        self.assertEqual([('http://www.example.com', 'com')],
954
 
                         self.my_location_config._get_matching_sections())
 
1417
        self.assertLocationMatching([('http://www.example.com', 'com')])
955
1418
 
956
1419
    def test__get_matching_sections_ignoreparent(self):
957
1420
        self.get_branch_config('http://www.example.com/ignoreparent')
958
 
        self.assertEqual([('http://www.example.com/ignoreparent', '')],
959
 
                         self.my_location_config._get_matching_sections())
 
1421
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
 
1422
                                      '')])
960
1423
 
961
1424
    def test__get_matching_sections_ignoreparent_subdir(self):
962
1425
        self.get_branch_config(
963
1426
            'http://www.example.com/ignoreparent/childbranch')
964
 
        self.assertEqual([('http://www.example.com/ignoreparent',
965
 
                           'childbranch')],
966
 
                         self.my_location_config._get_matching_sections())
 
1427
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
 
1428
                                      'childbranch')])
967
1429
 
968
1430
    def test__get_matching_sections_subdir_trailing_slash(self):
969
1431
        self.get_branch_config('/b')
970
 
        self.assertEqual([('/b/', '')],
971
 
                         self.my_location_config._get_matching_sections())
 
1432
        self.assertLocationMatching([('/b/', '')])
972
1433
 
973
1434
    def test__get_matching_sections_subdir_child(self):
974
1435
        self.get_branch_config('/a/foo')
975
 
        self.assertEqual([('/a/*', ''), ('/a/', 'foo')],
976
 
                         self.my_location_config._get_matching_sections())
 
1436
        self.assertLocationMatching([('/a/*', ''), ('/a/', 'foo')])
977
1437
 
978
1438
    def test__get_matching_sections_subdir_child_child(self):
979
1439
        self.get_branch_config('/a/foo/bar')
980
 
        self.assertEqual([('/a/*', 'bar'), ('/a/', 'foo/bar')],
981
 
                         self.my_location_config._get_matching_sections())
 
1440
        self.assertLocationMatching([('/a/*', 'bar'), ('/a/', 'foo/bar')])
982
1441
 
983
1442
    def test__get_matching_sections_trailing_slash_with_children(self):
984
1443
        self.get_branch_config('/a/')
985
 
        self.assertEqual([('/a/', '')],
986
 
                         self.my_location_config._get_matching_sections())
 
1444
        self.assertLocationMatching([('/a/', '')])
987
1445
 
988
1446
    def test__get_matching_sections_explicit_over_glob(self):
989
1447
        # XXX: 2006-09-08 jamesh
991
1449
        # was a config section for '/a/?', it would get precedence
992
1450
        # over '/a/c'.
993
1451
        self.get_branch_config('/a/c')
994
 
        self.assertEqual([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')],
995
 
                         self.my_location_config._get_matching_sections())
 
1452
        self.assertLocationMatching([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')])
996
1453
 
997
1454
    def test__get_option_policy_normal(self):
998
1455
        self.get_branch_config('http://www.example.com')
1020
1477
            'http://www.example.com', 'appendpath_option'),
1021
1478
            config.POLICY_APPENDPATH)
1022
1479
 
 
1480
    def test__get_options_with_policy(self):
 
1481
        self.get_branch_config('/dir/subdir',
 
1482
                               location_config="""\
 
1483
[/dir]
 
1484
other_url = /other-dir
 
1485
other_url:policy = appendpath
 
1486
[/dir/subdir]
 
1487
other_url = /other-subdir
 
1488
""")
 
1489
        self.assertOptions(
 
1490
            [(u'other_url', u'/other-subdir', u'/dir/subdir', 'locations'),
 
1491
             (u'other_url', u'/other-dir', u'/dir', 'locations'),
 
1492
             (u'other_url:policy', u'appendpath', u'/dir', 'locations')],
 
1493
            self.my_location_config)
 
1494
 
1023
1495
    def test_location_without_username(self):
1024
1496
        self.get_branch_config('http://www.example.com/ignoreparent')
1025
1497
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
1040
1512
        self.get_branch_config('http://www.example.com',
1041
1513
                                 global_config=sample_ignore_signatures)
1042
1514
        self.assertEqual(config.CHECK_ALWAYS,
1043
 
                         self.my_config.signature_checking())
 
1515
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1516
                             self.my_config.signature_checking))
1044
1517
        self.assertEqual(config.SIGN_NEVER,
1045
 
                         self.my_config.signing_policy())
 
1518
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1519
                             self.my_config.signing_policy))
1046
1520
 
1047
1521
    def test_signatures_never(self):
1048
1522
        self.get_branch_config('/a/c')
1049
1523
        self.assertEqual(config.CHECK_NEVER,
1050
 
                         self.my_config.signature_checking())
 
1524
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1525
                             self.my_config.signature_checking))
1051
1526
 
1052
1527
    def test_signatures_when_available(self):
1053
1528
        self.get_branch_config('/a/', global_config=sample_ignore_signatures)
1054
1529
        self.assertEqual(config.CHECK_IF_POSSIBLE,
1055
 
                         self.my_config.signature_checking())
 
1530
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1531
                             self.my_config.signature_checking))
1056
1532
 
1057
1533
    def test_signatures_always(self):
1058
1534
        self.get_branch_config('/b')
1059
1535
        self.assertEqual(config.CHECK_ALWAYS,
1060
 
                         self.my_config.signature_checking())
 
1536
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1537
                         self.my_config.signature_checking))
1061
1538
 
1062
1539
    def test_gpg_signing_command(self):
1063
1540
        self.get_branch_config('/b')
1064
 
        self.assertEqual("gnome-gpg", self.my_config.gpg_signing_command())
 
1541
        self.assertEqual("gnome-gpg",
 
1542
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1543
                self.my_config.gpg_signing_command))
1065
1544
 
1066
1545
    def test_gpg_signing_command_missing(self):
1067
1546
        self.get_branch_config('/a')
1068
 
        self.assertEqual("false", self.my_config.gpg_signing_command())
 
1547
        self.assertEqual("false",
 
1548
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1549
                self.my_config.gpg_signing_command))
 
1550
 
 
1551
    def test_gpg_signing_key(self):
 
1552
        self.get_branch_config('/b')
 
1553
        self.assertEqual("DD4D5088", self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1554
            self.my_config.gpg_signing_key))
 
1555
 
 
1556
    def test_gpg_signing_key_default(self):
 
1557
        self.get_branch_config('/a')
 
1558
        self.assertEqual("erik@bagfors.nu",
 
1559
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1560
                self.my_config.gpg_signing_key))
1069
1561
 
1070
1562
    def test_get_user_option_global(self):
1071
1563
        self.get_branch_config('/a')
1159
1651
    def test_post_commit_default(self):
1160
1652
        self.get_branch_config('/a/c')
1161
1653
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1162
 
                         self.my_config.post_commit())
 
1654
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1655
                                              self.my_config.post_commit))
1163
1656
 
1164
 
    def get_branch_config(self, location, global_config=None):
 
1657
    def get_branch_config(self, location, global_config=None,
 
1658
                          location_config=None):
1165
1659
        my_branch = FakeBranch(location)
1166
1660
        if global_config is None:
1167
1661
            global_config = sample_config_text
 
1662
        if location_config is None:
 
1663
            location_config = sample_branches_text
1168
1664
 
1169
1665
        my_global_config = config.GlobalConfig.from_string(global_config,
1170
1666
                                                           save=True)
1171
1667
        my_location_config = config.LocationConfig.from_string(
1172
 
            sample_branches_text, my_branch.base, save=True)
 
1668
            location_config, my_branch.base, save=True)
1173
1669
        my_config = config.BranchConfig(my_branch)
1174
1670
        self.my_config = my_config
1175
1671
        self.my_location_config = my_config._get_location_config()
1220
1716
        self.assertEqual('bzr', my_config.get_bzr_remote_path())
1221
1717
        my_config.set_user_option('bzr_remote_path', '/path-bzr')
1222
1718
        self.assertEqual('/path-bzr', my_config.get_bzr_remote_path())
1223
 
        os.environ['BZR_REMOTE_PATH'] = '/environ-bzr'
 
1719
        self.overrideEnv('BZR_REMOTE_PATH', '/environ-bzr')
1224
1720
        self.assertEqual('/environ-bzr', my_config.get_bzr_remote_path())
1225
1721
 
1226
1722
 
1252
1748
        return my_config
1253
1749
 
1254
1750
    def test_user_id(self):
1255
 
        branch = FakeBranch(user_id='Robert Collins <robertc@example.net>')
 
1751
        branch = FakeBranch()
1256
1752
        my_config = config.BranchConfig(branch)
1257
 
        self.assertEqual("Robert Collins <robertc@example.net>",
1258
 
                         my_config.username())
 
1753
        self.assertIsNot(None, my_config.username())
1259
1754
        my_config.branch.control_files.files['email'] = "John"
1260
1755
        my_config.set_user_option('email',
1261
1756
                                  "Robert Collins <robertc@example.org>")
1262
 
        self.assertEqual("John", my_config.username())
1263
 
        del my_config.branch.control_files.files['email']
1264
1757
        self.assertEqual("Robert Collins <robertc@example.org>",
1265
 
                         my_config.username())
1266
 
 
1267
 
    def test_not_set_in_branch(self):
1268
 
        my_config = self.get_branch_config(global_config=sample_config_text)
1269
 
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
1270
 
                         my_config._get_user_id())
1271
 
        my_config.branch.control_files.files['email'] = "John"
1272
 
        self.assertEqual("John", my_config._get_user_id())
 
1758
                        my_config.username())
1273
1759
 
1274
1760
    def test_BZR_EMAIL_OVERRIDES(self):
1275
 
        os.environ['BZR_EMAIL'] = "Robert Collins <robertc@example.org>"
 
1761
        self.overrideEnv('BZR_EMAIL', "Robert Collins <robertc@example.org>")
1276
1762
        branch = FakeBranch()
1277
1763
        my_config = config.BranchConfig(branch)
1278
1764
        self.assertEqual("Robert Collins <robertc@example.org>",
1281
1767
    def test_signatures_forced(self):
1282
1768
        my_config = self.get_branch_config(
1283
1769
            global_config=sample_always_signatures)
1284
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1285
 
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1286
 
        self.assertTrue(my_config.signature_needed())
 
1770
        self.assertEqual(config.CHECK_NEVER,
 
1771
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1772
                my_config.signature_checking))
 
1773
        self.assertEqual(config.SIGN_ALWAYS,
 
1774
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1775
                my_config.signing_policy))
 
1776
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1777
            my_config.signature_needed))
1287
1778
 
1288
1779
    def test_signatures_forced_branch(self):
1289
1780
        my_config = self.get_branch_config(
1290
1781
            global_config=sample_ignore_signatures,
1291
1782
            branch_data_config=sample_always_signatures)
1292
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1293
 
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1294
 
        self.assertTrue(my_config.signature_needed())
 
1783
        self.assertEqual(config.CHECK_NEVER,
 
1784
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1785
                my_config.signature_checking))
 
1786
        self.assertEqual(config.SIGN_ALWAYS,
 
1787
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1788
                my_config.signing_policy))
 
1789
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1790
            my_config.signature_needed))
1295
1791
 
1296
1792
    def test_gpg_signing_command(self):
1297
1793
        my_config = self.get_branch_config(
1298
1794
            global_config=sample_config_text,
1299
1795
            # branch data cannot set gpg_signing_command
1300
1796
            branch_data_config="gpg_signing_command=pgp")
1301
 
        self.assertEqual('gnome-gpg', my_config.gpg_signing_command())
 
1797
        self.assertEqual('gnome-gpg',
 
1798
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1799
                my_config.gpg_signing_command))
1302
1800
 
1303
1801
    def test_get_user_option_global(self):
1304
1802
        my_config = self.get_branch_config(global_config=sample_config_text)
1311
1809
                                      location_config=sample_branches_text)
1312
1810
        self.assertEqual(my_config.branch.base, '/a/c')
1313
1811
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1314
 
                         my_config.post_commit())
 
1812
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1813
                                              my_config.post_commit))
1315
1814
        my_config.set_user_option('post_commit', 'rmtree_root')
1316
1815
        # post-commit is ignored when present in branch data
1317
1816
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1318
 
                         my_config.post_commit())
 
1817
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1818
                                              my_config.post_commit))
1319
1819
        my_config.set_user_option('post_commit', 'rmtree_root',
1320
1820
                                  store=config.STORE_LOCATION)
1321
 
        self.assertEqual('rmtree_root', my_config.post_commit())
 
1821
        self.assertEqual('rmtree_root',
 
1822
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1823
                                              my_config.post_commit))
1322
1824
 
1323
1825
    def test_config_precedence(self):
1324
1826
        # FIXME: eager test, luckily no persitent config file makes it fail
1340
1842
            location='http://example.com/specific')
1341
1843
        self.assertEqual(my_config.get_user_option('option'), 'exact')
1342
1844
 
1343
 
    def test_get_mail_client(self):
1344
 
        config = self.get_branch_config()
1345
 
        client = config.get_mail_client()
1346
 
        self.assertIsInstance(client, mail_client.DefaultMail)
1347
 
 
1348
 
        # Specific clients
1349
 
        config.set_user_option('mail_client', 'evolution')
1350
 
        client = config.get_mail_client()
1351
 
        self.assertIsInstance(client, mail_client.Evolution)
1352
 
 
1353
 
        config.set_user_option('mail_client', 'kmail')
1354
 
        client = config.get_mail_client()
1355
 
        self.assertIsInstance(client, mail_client.KMail)
1356
 
 
1357
 
        config.set_user_option('mail_client', 'mutt')
1358
 
        client = config.get_mail_client()
1359
 
        self.assertIsInstance(client, mail_client.Mutt)
1360
 
 
1361
 
        config.set_user_option('mail_client', 'thunderbird')
1362
 
        client = config.get_mail_client()
1363
 
        self.assertIsInstance(client, mail_client.Thunderbird)
1364
 
 
1365
 
        # Generic options
1366
 
        config.set_user_option('mail_client', 'default')
1367
 
        client = config.get_mail_client()
1368
 
        self.assertIsInstance(client, mail_client.DefaultMail)
1369
 
 
1370
 
        config.set_user_option('mail_client', 'editor')
1371
 
        client = config.get_mail_client()
1372
 
        self.assertIsInstance(client, mail_client.Editor)
1373
 
 
1374
 
        config.set_user_option('mail_client', 'mapi')
1375
 
        client = config.get_mail_client()
1376
 
        self.assertIsInstance(client, mail_client.MAPIClient)
1377
 
 
1378
 
        config.set_user_option('mail_client', 'xdg-email')
1379
 
        client = config.get_mail_client()
1380
 
        self.assertIsInstance(client, mail_client.XDGEmail)
1381
 
 
1382
 
        config.set_user_option('mail_client', 'firebird')
1383
 
        self.assertRaises(errors.UnknownMailClient, config.get_mail_client)
1384
 
 
1385
1845
 
1386
1846
class TestMailAddressExtraction(tests.TestCase):
1387
1847
 
1433
1893
 
1434
1894
class TestTransportConfig(tests.TestCaseWithTransport):
1435
1895
 
 
1896
    def test_load_utf8(self):
 
1897
        """Ensure we can load an utf8-encoded file."""
 
1898
        t = self.get_transport()
 
1899
        unicode_user = u'b\N{Euro Sign}ar'
 
1900
        unicode_content = u'user=%s' % (unicode_user,)
 
1901
        utf8_content = unicode_content.encode('utf8')
 
1902
        # Store the raw content in the config file
 
1903
        t.put_bytes('foo.conf', utf8_content)
 
1904
        conf = config.TransportConfig(t, 'foo.conf')
 
1905
        self.assertEquals(unicode_user, conf.get_option('user'))
 
1906
 
 
1907
    def test_load_non_ascii(self):
 
1908
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
1909
        t = self.get_transport()
 
1910
        t.put_bytes('foo.conf', 'user=foo\n#\xff\n')
 
1911
        conf = config.TransportConfig(t, 'foo.conf')
 
1912
        self.assertRaises(errors.ConfigContentError, conf._get_configobj)
 
1913
 
 
1914
    def test_load_erroneous_content(self):
 
1915
        """Ensure we display a proper error on content that can't be parsed."""
 
1916
        t = self.get_transport()
 
1917
        t.put_bytes('foo.conf', '[open_section\n')
 
1918
        conf = config.TransportConfig(t, 'foo.conf')
 
1919
        self.assertRaises(errors.ParseConfigError, conf._get_configobj)
 
1920
 
 
1921
    def test_load_permission_denied(self):
 
1922
        """Ensure we get an empty config file if the file is inaccessible."""
 
1923
        warnings = []
 
1924
        def warning(*args):
 
1925
            warnings.append(args[0] % args[1:])
 
1926
        self.overrideAttr(trace, 'warning', warning)
 
1927
 
 
1928
        class DenyingTransport(object):
 
1929
 
 
1930
            def __init__(self, base):
 
1931
                self.base = base
 
1932
 
 
1933
            def get_bytes(self, relpath):
 
1934
                raise errors.PermissionDenied(relpath, "")
 
1935
 
 
1936
        cfg = config.TransportConfig(
 
1937
            DenyingTransport("nonexisting://"), 'control.conf')
 
1938
        self.assertIs(None, cfg.get_option('non-existant', 'SECTION'))
 
1939
        self.assertEquals(
 
1940
            warnings,
 
1941
            [u'Permission denied while trying to open configuration file '
 
1942
             u'nonexisting:///control.conf.'])
 
1943
 
1436
1944
    def test_get_value(self):
1437
1945
        """Test that retreiving a value from a section is possible"""
1438
 
        bzrdir_config = config.TransportConfig(transport.get_transport('.'),
 
1946
        bzrdir_config = config.TransportConfig(self.get_transport('.'),
1439
1947
                                               'control.conf')
1440
1948
        bzrdir_config.set_option('value', 'key', 'SECTION')
1441
1949
        bzrdir_config.set_option('value2', 'key2')
1471
1979
        self.assertIs(None, bzrdir_config.get_default_stack_on())
1472
1980
 
1473
1981
 
 
1982
class TestOldConfigHooks(tests.TestCaseWithTransport):
 
1983
 
 
1984
    def setUp(self):
 
1985
        super(TestOldConfigHooks, self).setUp()
 
1986
        create_configs_with_file_option(self)
 
1987
 
 
1988
    def assertGetHook(self, conf, name, value):
 
1989
        calls = []
 
1990
        def hook(*args):
 
1991
            calls.append(args)
 
1992
        config.OldConfigHooks.install_named_hook('get', hook, None)
 
1993
        self.addCleanup(
 
1994
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
 
1995
        self.assertLength(0, calls)
 
1996
        actual_value = conf.get_user_option(name)
 
1997
        self.assertEquals(value, actual_value)
 
1998
        self.assertLength(1, calls)
 
1999
        self.assertEquals((conf, name, value), calls[0])
 
2000
 
 
2001
    def test_get_hook_bazaar(self):
 
2002
        self.assertGetHook(self.bazaar_config, 'file', 'bazaar')
 
2003
 
 
2004
    def test_get_hook_locations(self):
 
2005
        self.assertGetHook(self.locations_config, 'file', 'locations')
 
2006
 
 
2007
    def test_get_hook_branch(self):
 
2008
        # Since locations masks branch, we define a different option
 
2009
        self.branch_config.set_user_option('file2', 'branch')
 
2010
        self.assertGetHook(self.branch_config, 'file2', 'branch')
 
2011
 
 
2012
    def assertSetHook(self, conf, name, value):
 
2013
        calls = []
 
2014
        def hook(*args):
 
2015
            calls.append(args)
 
2016
        config.OldConfigHooks.install_named_hook('set', hook, None)
 
2017
        self.addCleanup(
 
2018
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
 
2019
        self.assertLength(0, calls)
 
2020
        conf.set_user_option(name, value)
 
2021
        self.assertLength(1, calls)
 
2022
        # We can't assert the conf object below as different configs use
 
2023
        # different means to implement set_user_option and we care only about
 
2024
        # coverage here.
 
2025
        self.assertEquals((name, value), calls[0][1:])
 
2026
 
 
2027
    def test_set_hook_bazaar(self):
 
2028
        self.assertSetHook(self.bazaar_config, 'foo', 'bazaar')
 
2029
 
 
2030
    def test_set_hook_locations(self):
 
2031
        self.assertSetHook(self.locations_config, 'foo', 'locations')
 
2032
 
 
2033
    def test_set_hook_branch(self):
 
2034
        self.assertSetHook(self.branch_config, 'foo', 'branch')
 
2035
 
 
2036
    def assertRemoveHook(self, conf, name, section_name=None):
 
2037
        calls = []
 
2038
        def hook(*args):
 
2039
            calls.append(args)
 
2040
        config.OldConfigHooks.install_named_hook('remove', hook, None)
 
2041
        self.addCleanup(
 
2042
            config.OldConfigHooks.uninstall_named_hook, 'remove', None)
 
2043
        self.assertLength(0, calls)
 
2044
        conf.remove_user_option(name, section_name)
 
2045
        self.assertLength(1, calls)
 
2046
        # We can't assert the conf object below as different configs use
 
2047
        # different means to implement remove_user_option and we care only about
 
2048
        # coverage here.
 
2049
        self.assertEquals((name,), calls[0][1:])
 
2050
 
 
2051
    def test_remove_hook_bazaar(self):
 
2052
        self.assertRemoveHook(self.bazaar_config, 'file')
 
2053
 
 
2054
    def test_remove_hook_locations(self):
 
2055
        self.assertRemoveHook(self.locations_config, 'file',
 
2056
                              self.locations_config.location)
 
2057
 
 
2058
    def test_remove_hook_branch(self):
 
2059
        self.assertRemoveHook(self.branch_config, 'file')
 
2060
 
 
2061
    def assertLoadHook(self, name, conf_class, *conf_args):
 
2062
        calls = []
 
2063
        def hook(*args):
 
2064
            calls.append(args)
 
2065
        config.OldConfigHooks.install_named_hook('load', hook, None)
 
2066
        self.addCleanup(
 
2067
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
 
2068
        self.assertLength(0, calls)
 
2069
        # Build a config
 
2070
        conf = conf_class(*conf_args)
 
2071
        # Access an option to trigger a load
 
2072
        conf.get_user_option(name)
 
2073
        self.assertLength(1, calls)
 
2074
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2075
 
 
2076
    def test_load_hook_bazaar(self):
 
2077
        self.assertLoadHook('file', config.GlobalConfig)
 
2078
 
 
2079
    def test_load_hook_locations(self):
 
2080
        self.assertLoadHook('file', config.LocationConfig, self.tree.basedir)
 
2081
 
 
2082
    def test_load_hook_branch(self):
 
2083
        self.assertLoadHook('file', config.BranchConfig, self.tree.branch)
 
2084
 
 
2085
    def assertSaveHook(self, conf):
 
2086
        calls = []
 
2087
        def hook(*args):
 
2088
            calls.append(args)
 
2089
        config.OldConfigHooks.install_named_hook('save', hook, None)
 
2090
        self.addCleanup(
 
2091
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
 
2092
        self.assertLength(0, calls)
 
2093
        # Setting an option triggers a save
 
2094
        conf.set_user_option('foo', 'bar')
 
2095
        self.assertLength(1, calls)
 
2096
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2097
 
 
2098
    def test_save_hook_bazaar(self):
 
2099
        self.assertSaveHook(self.bazaar_config)
 
2100
 
 
2101
    def test_save_hook_locations(self):
 
2102
        self.assertSaveHook(self.locations_config)
 
2103
 
 
2104
    def test_save_hook_branch(self):
 
2105
        self.assertSaveHook(self.branch_config)
 
2106
 
 
2107
 
 
2108
class TestOldConfigHooksForRemote(tests.TestCaseWithTransport):
 
2109
    """Tests config hooks for remote configs.
 
2110
 
 
2111
    No tests for the remove hook as this is not implemented there.
 
2112
    """
 
2113
 
 
2114
    def setUp(self):
 
2115
        super(TestOldConfigHooksForRemote, self).setUp()
 
2116
        self.transport_server = test_server.SmartTCPServer_for_testing
 
2117
        create_configs_with_file_option(self)
 
2118
 
 
2119
    def assertGetHook(self, conf, name, value):
 
2120
        calls = []
 
2121
        def hook(*args):
 
2122
            calls.append(args)
 
2123
        config.OldConfigHooks.install_named_hook('get', hook, None)
 
2124
        self.addCleanup(
 
2125
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
 
2126
        self.assertLength(0, calls)
 
2127
        actual_value = conf.get_option(name)
 
2128
        self.assertEquals(value, actual_value)
 
2129
        self.assertLength(1, calls)
 
2130
        self.assertEquals((conf, name, value), calls[0])
 
2131
 
 
2132
    def test_get_hook_remote_branch(self):
 
2133
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2134
        self.assertGetHook(remote_branch._get_config(), 'file', 'branch')
 
2135
 
 
2136
    def test_get_hook_remote_bzrdir(self):
 
2137
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
 
2138
        conf = remote_bzrdir._get_config()
 
2139
        conf.set_option('remotedir', 'file')
 
2140
        self.assertGetHook(conf, 'file', 'remotedir')
 
2141
 
 
2142
    def assertSetHook(self, conf, name, value):
 
2143
        calls = []
 
2144
        def hook(*args):
 
2145
            calls.append(args)
 
2146
        config.OldConfigHooks.install_named_hook('set', hook, None)
 
2147
        self.addCleanup(
 
2148
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
 
2149
        self.assertLength(0, calls)
 
2150
        conf.set_option(value, name)
 
2151
        self.assertLength(1, calls)
 
2152
        # We can't assert the conf object below as different configs use
 
2153
        # different means to implement set_user_option and we care only about
 
2154
        # coverage here.
 
2155
        self.assertEquals((name, value), calls[0][1:])
 
2156
 
 
2157
    def test_set_hook_remote_branch(self):
 
2158
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2159
        self.addCleanup(remote_branch.lock_write().unlock)
 
2160
        self.assertSetHook(remote_branch._get_config(), 'file', 'remote')
 
2161
 
 
2162
    def test_set_hook_remote_bzrdir(self):
 
2163
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2164
        self.addCleanup(remote_branch.lock_write().unlock)
 
2165
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
 
2166
        self.assertSetHook(remote_bzrdir._get_config(), 'file', 'remotedir')
 
2167
 
 
2168
    def assertLoadHook(self, expected_nb_calls, name, conf_class, *conf_args):
 
2169
        calls = []
 
2170
        def hook(*args):
 
2171
            calls.append(args)
 
2172
        config.OldConfigHooks.install_named_hook('load', hook, None)
 
2173
        self.addCleanup(
 
2174
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
 
2175
        self.assertLength(0, calls)
 
2176
        # Build a config
 
2177
        conf = conf_class(*conf_args)
 
2178
        # Access an option to trigger a load
 
2179
        conf.get_option(name)
 
2180
        self.assertLength(expected_nb_calls, calls)
 
2181
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2182
 
 
2183
    def test_load_hook_remote_branch(self):
 
2184
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2185
        self.assertLoadHook(1, 'file', remote.RemoteBranchConfig, remote_branch)
 
2186
 
 
2187
    def test_load_hook_remote_bzrdir(self):
 
2188
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
 
2189
        # The config file doesn't exist, set an option to force its creation
 
2190
        conf = remote_bzrdir._get_config()
 
2191
        conf.set_option('remotedir', 'file')
 
2192
        # We get one call for the server and one call for the client, this is
 
2193
        # caused by the differences in implementations betwen
 
2194
        # SmartServerBzrDirRequestConfigFile (in smart/bzrdir.py) and
 
2195
        # SmartServerBranchGetConfigFile (in smart/branch.py)
 
2196
        self.assertLoadHook(2 ,'file', remote.RemoteBzrDirConfig, remote_bzrdir)
 
2197
 
 
2198
    def assertSaveHook(self, conf):
 
2199
        calls = []
 
2200
        def hook(*args):
 
2201
            calls.append(args)
 
2202
        config.OldConfigHooks.install_named_hook('save', hook, None)
 
2203
        self.addCleanup(
 
2204
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
 
2205
        self.assertLength(0, calls)
 
2206
        # Setting an option triggers a save
 
2207
        conf.set_option('foo', 'bar')
 
2208
        self.assertLength(1, calls)
 
2209
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2210
 
 
2211
    def test_save_hook_remote_branch(self):
 
2212
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2213
        self.addCleanup(remote_branch.lock_write().unlock)
 
2214
        self.assertSaveHook(remote_branch._get_config())
 
2215
 
 
2216
    def test_save_hook_remote_bzrdir(self):
 
2217
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2218
        self.addCleanup(remote_branch.lock_write().unlock)
 
2219
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
 
2220
        self.assertSaveHook(remote_bzrdir._get_config())
 
2221
 
 
2222
 
 
2223
class TestOption(tests.TestCase):
 
2224
 
 
2225
    def test_default_value(self):
 
2226
        opt = config.Option('foo', default='bar')
 
2227
        self.assertEquals('bar', opt.get_default())
 
2228
 
 
2229
    def test_callable_default_value(self):
 
2230
        def bar_as_unicode():
 
2231
            return u'bar'
 
2232
        opt = config.Option('foo', default=bar_as_unicode)
 
2233
        self.assertEquals('bar', opt.get_default())
 
2234
 
 
2235
    def test_default_value_from_env(self):
 
2236
        opt = config.Option('foo', default='bar', default_from_env=['FOO'])
 
2237
        self.overrideEnv('FOO', 'quux')
 
2238
        # Env variable provides a default taking over the option one
 
2239
        self.assertEquals('quux', opt.get_default())
 
2240
 
 
2241
    def test_first_default_value_from_env_wins(self):
 
2242
        opt = config.Option('foo', default='bar',
 
2243
                            default_from_env=['NO_VALUE', 'FOO', 'BAZ'])
 
2244
        self.overrideEnv('FOO', 'foo')
 
2245
        self.overrideEnv('BAZ', 'baz')
 
2246
        # The first env var set wins
 
2247
        self.assertEquals('foo', opt.get_default())
 
2248
 
 
2249
    def test_not_supported_list_default_value(self):
 
2250
        self.assertRaises(AssertionError, config.Option, 'foo', default=[1])
 
2251
 
 
2252
    def test_not_supported_object_default_value(self):
 
2253
        self.assertRaises(AssertionError, config.Option, 'foo',
 
2254
                          default=object())
 
2255
 
 
2256
    def test_not_supported_callable_default_value_not_unicode(self):
 
2257
        def bar_not_unicode():
 
2258
            return 'bar'
 
2259
        opt = config.Option('foo', default=bar_not_unicode)
 
2260
        self.assertRaises(AssertionError, opt.get_default)
 
2261
 
 
2262
    def test_get_help_topic(self):
 
2263
        opt = config.Option('foo')
 
2264
        self.assertEquals('foo', opt.get_help_topic())
 
2265
 
 
2266
 
 
2267
class TestOptionConverterMixin(object):
 
2268
 
 
2269
    def assertConverted(self, expected, opt, value):
 
2270
        self.assertEquals(expected, opt.convert_from_unicode(None, value))
 
2271
 
 
2272
    def assertWarns(self, opt, value):
 
2273
        warnings = []
 
2274
        def warning(*args):
 
2275
            warnings.append(args[0] % args[1:])
 
2276
        self.overrideAttr(trace, 'warning', warning)
 
2277
        self.assertEquals(None, opt.convert_from_unicode(None, value))
 
2278
        self.assertLength(1, warnings)
 
2279
        self.assertEquals(
 
2280
            'Value "%s" is not valid for "%s"' % (value, opt.name),
 
2281
            warnings[0])
 
2282
 
 
2283
    def assertErrors(self, opt, value):
 
2284
        self.assertRaises(errors.ConfigOptionValueError,
 
2285
                          opt.convert_from_unicode, None, value)
 
2286
 
 
2287
    def assertConvertInvalid(self, opt, invalid_value):
 
2288
        opt.invalid = None
 
2289
        self.assertEquals(None, opt.convert_from_unicode(None, invalid_value))
 
2290
        opt.invalid = 'warning'
 
2291
        self.assertWarns(opt, invalid_value)
 
2292
        opt.invalid = 'error'
 
2293
        self.assertErrors(opt, invalid_value)
 
2294
 
 
2295
 
 
2296
class TestOptionWithBooleanConverter(tests.TestCase, TestOptionConverterMixin):
 
2297
 
 
2298
    def get_option(self):
 
2299
        return config.Option('foo', help='A boolean.',
 
2300
                             from_unicode=config.bool_from_store)
 
2301
 
 
2302
    def test_convert_invalid(self):
 
2303
        opt = self.get_option()
 
2304
        # A string that is not recognized as a boolean
 
2305
        self.assertConvertInvalid(opt, u'invalid-boolean')
 
2306
        # A list of strings is never recognized as a boolean
 
2307
        self.assertConvertInvalid(opt, [u'not', u'a', u'boolean'])
 
2308
 
 
2309
    def test_convert_valid(self):
 
2310
        opt = self.get_option()
 
2311
        self.assertConverted(True, opt, u'True')
 
2312
        self.assertConverted(True, opt, u'1')
 
2313
        self.assertConverted(False, opt, u'False')
 
2314
 
 
2315
 
 
2316
class TestOptionWithIntegerConverter(tests.TestCase, TestOptionConverterMixin):
 
2317
 
 
2318
    def get_option(self):
 
2319
        return config.Option('foo', help='An integer.',
 
2320
                             from_unicode=config.int_from_store)
 
2321
 
 
2322
    def test_convert_invalid(self):
 
2323
        opt = self.get_option()
 
2324
        # A string that is not recognized as an integer
 
2325
        self.assertConvertInvalid(opt, u'forty-two')
 
2326
        # A list of strings is never recognized as an integer
 
2327
        self.assertConvertInvalid(opt, [u'a', u'list'])
 
2328
 
 
2329
    def test_convert_valid(self):
 
2330
        opt = self.get_option()
 
2331
        self.assertConverted(16, opt, u'16')
 
2332
 
 
2333
 
 
2334
class TestOptionWithSIUnitConverter(tests.TestCase, TestOptionConverterMixin):
 
2335
 
 
2336
    def get_option(self):
 
2337
        return config.Option('foo', help='An integer in SI units.',
 
2338
                             from_unicode=config.int_SI_from_store)
 
2339
 
 
2340
    def test_convert_invalid(self):
 
2341
        opt = self.get_option()
 
2342
        self.assertConvertInvalid(opt, u'not-a-unit')
 
2343
        self.assertConvertInvalid(opt, u'Gb') # Forgot the int
 
2344
        self.assertConvertInvalid(opt, u'1b') # Forgot the unit
 
2345
        self.assertConvertInvalid(opt, u'1GG')
 
2346
        self.assertConvertInvalid(opt, u'1Mbb')
 
2347
        self.assertConvertInvalid(opt, u'1MM')
 
2348
 
 
2349
    def test_convert_valid(self):
 
2350
        opt = self.get_option()
 
2351
        self.assertConverted(int(5e3), opt, u'5kb')
 
2352
        self.assertConverted(int(5e6), opt, u'5M')
 
2353
        self.assertConverted(int(5e6), opt, u'5MB')
 
2354
        self.assertConverted(int(5e9), opt, u'5g')
 
2355
        self.assertConverted(int(5e9), opt, u'5gB')
 
2356
        self.assertConverted(100, opt, u'100')
 
2357
 
 
2358
 
 
2359
class TestListOption(tests.TestCase, TestOptionConverterMixin):
 
2360
 
 
2361
    def get_option(self):
 
2362
        return config.ListOption('foo', help='A list.')
 
2363
 
 
2364
    def test_convert_invalid(self):
 
2365
        opt = self.get_option()
 
2366
        # We don't even try to convert a list into a list, we only expect
 
2367
        # strings
 
2368
        self.assertConvertInvalid(opt, [1])
 
2369
        # No string is invalid as all forms can be converted to a list
 
2370
 
 
2371
    def test_convert_valid(self):
 
2372
        opt = self.get_option()
 
2373
        # An empty string is an empty list
 
2374
        self.assertConverted([], opt, '') # Using a bare str() just in case
 
2375
        self.assertConverted([], opt, u'')
 
2376
        # A boolean
 
2377
        self.assertConverted([u'True'], opt, u'True')
 
2378
        # An integer
 
2379
        self.assertConverted([u'42'], opt, u'42')
 
2380
        # A single string
 
2381
        self.assertConverted([u'bar'], opt, u'bar')
 
2382
 
 
2383
 
 
2384
class TestRegistryOption(tests.TestCase, TestOptionConverterMixin):
 
2385
 
 
2386
    def get_option(self, registry):
 
2387
        return config.RegistryOption('foo', registry,
 
2388
                help='A registry option.')
 
2389
 
 
2390
    def test_convert_invalid(self):
 
2391
        registry = _mod_registry.Registry()
 
2392
        opt = self.get_option(registry)
 
2393
        self.assertConvertInvalid(opt, [1])
 
2394
        self.assertConvertInvalid(opt, u"notregistered")
 
2395
 
 
2396
    def test_convert_valid(self):
 
2397
        registry = _mod_registry.Registry()
 
2398
        registry.register("someval", 1234)
 
2399
        opt = self.get_option(registry)
 
2400
        # Using a bare str() just in case
 
2401
        self.assertConverted(1234, opt, "someval")
 
2402
        self.assertConverted(1234, opt, u'someval')
 
2403
        self.assertConverted(None, opt, None)
 
2404
 
 
2405
    def test_help(self):
 
2406
        registry = _mod_registry.Registry()
 
2407
        registry.register("someval", 1234, help="some option")
 
2408
        registry.register("dunno", 1234, help="some other option")
 
2409
        opt = self.get_option(registry)
 
2410
        self.assertEquals(
 
2411
            'A registry option.\n'
 
2412
            '\n'
 
2413
            'The following values are supported:\n'
 
2414
            ' dunno - some other option\n'
 
2415
            ' someval - some option\n',
 
2416
            opt.help)
 
2417
 
 
2418
    def test_get_help_text(self):
 
2419
        registry = _mod_registry.Registry()
 
2420
        registry.register("someval", 1234, help="some option")
 
2421
        registry.register("dunno", 1234, help="some other option")
 
2422
        opt = self.get_option(registry)
 
2423
        self.assertEquals(
 
2424
            'A registry option.\n'
 
2425
            '\n'
 
2426
            'The following values are supported:\n'
 
2427
            ' dunno - some other option\n'
 
2428
            ' someval - some option\n',
 
2429
            opt.get_help_text())
 
2430
 
 
2431
 
 
2432
class TestOptionRegistry(tests.TestCase):
 
2433
 
 
2434
    def setUp(self):
 
2435
        super(TestOptionRegistry, self).setUp()
 
2436
        # Always start with an empty registry
 
2437
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
2438
        self.registry = config.option_registry
 
2439
 
 
2440
    def test_register(self):
 
2441
        opt = config.Option('foo')
 
2442
        self.registry.register(opt)
 
2443
        self.assertIs(opt, self.registry.get('foo'))
 
2444
 
 
2445
    def test_registered_help(self):
 
2446
        opt = config.Option('foo', help='A simple option')
 
2447
        self.registry.register(opt)
 
2448
        self.assertEquals('A simple option', self.registry.get_help('foo'))
 
2449
 
 
2450
    lazy_option = config.Option('lazy_foo', help='Lazy help')
 
2451
 
 
2452
    def test_register_lazy(self):
 
2453
        self.registry.register_lazy('lazy_foo', self.__module__,
 
2454
                                    'TestOptionRegistry.lazy_option')
 
2455
        self.assertIs(self.lazy_option, self.registry.get('lazy_foo'))
 
2456
 
 
2457
    def test_registered_lazy_help(self):
 
2458
        self.registry.register_lazy('lazy_foo', self.__module__,
 
2459
                                    'TestOptionRegistry.lazy_option')
 
2460
        self.assertEquals('Lazy help', self.registry.get_help('lazy_foo'))
 
2461
 
 
2462
 
 
2463
class TestRegisteredOptions(tests.TestCase):
 
2464
    """All registered options should verify some constraints."""
 
2465
 
 
2466
    scenarios = [(key, {'option_name': key, 'option': option}) for key, option
 
2467
                 in config.option_registry.iteritems()]
 
2468
 
 
2469
    def setUp(self):
 
2470
        super(TestRegisteredOptions, self).setUp()
 
2471
        self.registry = config.option_registry
 
2472
 
 
2473
    def test_proper_name(self):
 
2474
        # An option should be registered under its own name, this can't be
 
2475
        # checked at registration time for the lazy ones.
 
2476
        self.assertEquals(self.option_name, self.option.name)
 
2477
 
 
2478
    def test_help_is_set(self):
 
2479
        option_help = self.registry.get_help(self.option_name)
 
2480
        # Come on, think about the user, he really wants to know what the
 
2481
        # option is about
 
2482
        self.assertIsNot(None, option_help)
 
2483
        self.assertNotEquals('', option_help)
 
2484
 
 
2485
 
 
2486
class TestSection(tests.TestCase):
 
2487
 
 
2488
    # FIXME: Parametrize so that all sections produced by Stores run these
 
2489
    # tests -- vila 2011-04-01
 
2490
 
 
2491
    def test_get_a_value(self):
 
2492
        a_dict = dict(foo='bar')
 
2493
        section = config.Section('myID', a_dict)
 
2494
        self.assertEquals('bar', section.get('foo'))
 
2495
 
 
2496
    def test_get_unknown_option(self):
 
2497
        a_dict = dict()
 
2498
        section = config.Section(None, a_dict)
 
2499
        self.assertEquals('out of thin air',
 
2500
                          section.get('foo', 'out of thin air'))
 
2501
 
 
2502
    def test_options_is_shared(self):
 
2503
        a_dict = dict()
 
2504
        section = config.Section(None, a_dict)
 
2505
        self.assertIs(a_dict, section.options)
 
2506
 
 
2507
 
 
2508
class TestMutableSection(tests.TestCase):
 
2509
 
 
2510
    scenarios = [('mutable',
 
2511
                  {'get_section':
 
2512
                       lambda opts: config.MutableSection('myID', opts)},),
 
2513
        ]
 
2514
 
 
2515
    def test_set(self):
 
2516
        a_dict = dict(foo='bar')
 
2517
        section = self.get_section(a_dict)
 
2518
        section.set('foo', 'new_value')
 
2519
        self.assertEquals('new_value', section.get('foo'))
 
2520
        # The change appears in the shared section
 
2521
        self.assertEquals('new_value', a_dict.get('foo'))
 
2522
        # We keep track of the change
 
2523
        self.assertTrue('foo' in section.orig)
 
2524
        self.assertEquals('bar', section.orig.get('foo'))
 
2525
 
 
2526
    def test_set_preserve_original_once(self):
 
2527
        a_dict = dict(foo='bar')
 
2528
        section = self.get_section(a_dict)
 
2529
        section.set('foo', 'first_value')
 
2530
        section.set('foo', 'second_value')
 
2531
        # We keep track of the original value
 
2532
        self.assertTrue('foo' in section.orig)
 
2533
        self.assertEquals('bar', section.orig.get('foo'))
 
2534
 
 
2535
    def test_remove(self):
 
2536
        a_dict = dict(foo='bar')
 
2537
        section = self.get_section(a_dict)
 
2538
        section.remove('foo')
 
2539
        # We get None for unknown options via the default value
 
2540
        self.assertEquals(None, section.get('foo'))
 
2541
        # Or we just get the default value
 
2542
        self.assertEquals('unknown', section.get('foo', 'unknown'))
 
2543
        self.assertFalse('foo' in section.options)
 
2544
        # We keep track of the deletion
 
2545
        self.assertTrue('foo' in section.orig)
 
2546
        self.assertEquals('bar', section.orig.get('foo'))
 
2547
 
 
2548
    def test_remove_new_option(self):
 
2549
        a_dict = dict()
 
2550
        section = self.get_section(a_dict)
 
2551
        section.set('foo', 'bar')
 
2552
        section.remove('foo')
 
2553
        self.assertFalse('foo' in section.options)
 
2554
        # The option didn't exist initially so it we need to keep track of it
 
2555
        # with a special value
 
2556
        self.assertTrue('foo' in section.orig)
 
2557
        self.assertEquals(config._NewlyCreatedOption, section.orig['foo'])
 
2558
 
 
2559
 
 
2560
class TestCommandLineStore(tests.TestCase):
 
2561
 
 
2562
    def setUp(self):
 
2563
        super(TestCommandLineStore, self).setUp()
 
2564
        self.store = config.CommandLineStore()
 
2565
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
2566
 
 
2567
    def get_section(self):
 
2568
        """Get the unique section for the command line overrides."""
 
2569
        sections = list(self.store.get_sections())
 
2570
        self.assertLength(1, sections)
 
2571
        store, section = sections[0]
 
2572
        self.assertEquals(self.store, store)
 
2573
        return section
 
2574
 
 
2575
    def test_no_override(self):
 
2576
        self.store._from_cmdline([])
 
2577
        section = self.get_section()
 
2578
        self.assertLength(0, list(section.iter_option_names()))
 
2579
 
 
2580
    def test_simple_override(self):
 
2581
        self.store._from_cmdline(['a=b'])
 
2582
        section = self.get_section()
 
2583
        self.assertEqual('b', section.get('a'))
 
2584
 
 
2585
    def test_list_override(self):
 
2586
        opt = config.ListOption('l')
 
2587
        config.option_registry.register(opt)
 
2588
        self.store._from_cmdline(['l=1,2,3'])
 
2589
        val = self.get_section().get('l')
 
2590
        self.assertEqual('1,2,3', val)
 
2591
        # Reminder: lists should be registered as such explicitely, otherwise
 
2592
        # the conversion needs to be done afterwards.
 
2593
        self.assertEqual(['1', '2', '3'],
 
2594
                         opt.convert_from_unicode(self.store, val))
 
2595
 
 
2596
    def test_multiple_overrides(self):
 
2597
        self.store._from_cmdline(['a=b', 'x=y'])
 
2598
        section = self.get_section()
 
2599
        self.assertEquals('b', section.get('a'))
 
2600
        self.assertEquals('y', section.get('x'))
 
2601
 
 
2602
    def test_wrong_syntax(self):
 
2603
        self.assertRaises(errors.BzrCommandError,
 
2604
                          self.store._from_cmdline, ['a=b', 'c'])
 
2605
 
 
2606
class TestStoreMinimalAPI(tests.TestCaseWithTransport):
 
2607
 
 
2608
    scenarios = [(key, {'get_store': builder}) for key, builder
 
2609
                 in config.test_store_builder_registry.iteritems()] + [
 
2610
        ('cmdline', {'get_store': lambda test: config.CommandLineStore()})]
 
2611
 
 
2612
    def test_id(self):
 
2613
        store = self.get_store(self)
 
2614
        if type(store) == config.TransportIniFileStore:
 
2615
            raise tests.TestNotApplicable(
 
2616
                "%s is not a concrete Store implementation"
 
2617
                " so it doesn't need an id" % (store.__class__.__name__,))
 
2618
        self.assertIsNot(None, store.id)
 
2619
 
 
2620
 
 
2621
class TestStore(tests.TestCaseWithTransport):
 
2622
 
 
2623
    def assertSectionContent(self, expected, (store, section)):
 
2624
        """Assert that some options have the proper values in a section."""
 
2625
        expected_name, expected_options = expected
 
2626
        self.assertEquals(expected_name, section.id)
 
2627
        self.assertEquals(
 
2628
            expected_options,
 
2629
            dict([(k, section.get(k)) for k in expected_options.keys()]))
 
2630
 
 
2631
 
 
2632
class TestReadonlyStore(TestStore):
 
2633
 
 
2634
    scenarios = [(key, {'get_store': builder}) for key, builder
 
2635
                 in config.test_store_builder_registry.iteritems()]
 
2636
 
 
2637
    def test_building_delays_load(self):
 
2638
        store = self.get_store(self)
 
2639
        self.assertEquals(False, store.is_loaded())
 
2640
        store._load_from_string('')
 
2641
        self.assertEquals(True, store.is_loaded())
 
2642
 
 
2643
    def test_get_no_sections_for_empty(self):
 
2644
        store = self.get_store(self)
 
2645
        store._load_from_string('')
 
2646
        self.assertEquals([], list(store.get_sections()))
 
2647
 
 
2648
    def test_get_default_section(self):
 
2649
        store = self.get_store(self)
 
2650
        store._load_from_string('foo=bar')
 
2651
        sections = list(store.get_sections())
 
2652
        self.assertLength(1, sections)
 
2653
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2654
 
 
2655
    def test_get_named_section(self):
 
2656
        store = self.get_store(self)
 
2657
        store._load_from_string('[baz]\nfoo=bar')
 
2658
        sections = list(store.get_sections())
 
2659
        self.assertLength(1, sections)
 
2660
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
 
2661
 
 
2662
    def test_load_from_string_fails_for_non_empty_store(self):
 
2663
        store = self.get_store(self)
 
2664
        store._load_from_string('foo=bar')
 
2665
        self.assertRaises(AssertionError, store._load_from_string, 'bar=baz')
 
2666
 
 
2667
 
 
2668
class TestStoreQuoting(TestStore):
 
2669
 
 
2670
    scenarios = [(key, {'get_store': builder}) for key, builder
 
2671
                 in config.test_store_builder_registry.iteritems()]
 
2672
 
 
2673
    def setUp(self):
 
2674
        super(TestStoreQuoting, self).setUp()
 
2675
        self.store = self.get_store(self)
 
2676
        # We need a loaded store but any content will do
 
2677
        self.store._load_from_string('')
 
2678
 
 
2679
    def assertIdempotent(self, s):
 
2680
        """Assert that quoting an unquoted string is a no-op and vice-versa.
 
2681
 
 
2682
        What matters here is that option values, as they appear in a store, can
 
2683
        be safely round-tripped out of the store and back.
 
2684
 
 
2685
        :param s: A string, quoted if required.
 
2686
        """
 
2687
        self.assertEquals(s, self.store.quote(self.store.unquote(s)))
 
2688
        self.assertEquals(s, self.store.unquote(self.store.quote(s)))
 
2689
 
 
2690
    def test_empty_string(self):
 
2691
        if isinstance(self.store, config.IniFileStore):
 
2692
            # configobj._quote doesn't handle empty values
 
2693
            self.assertRaises(AssertionError,
 
2694
                              self.assertIdempotent, '')
 
2695
        else:
 
2696
            self.assertIdempotent('')
 
2697
        # But quoted empty strings are ok
 
2698
        self.assertIdempotent('""')
 
2699
 
 
2700
    def test_embedded_spaces(self):
 
2701
        self.assertIdempotent('" a b c "')
 
2702
 
 
2703
    def test_embedded_commas(self):
 
2704
        self.assertIdempotent('" a , b c "')
 
2705
 
 
2706
    def test_simple_comma(self):
 
2707
        if isinstance(self.store, config.IniFileStore):
 
2708
            # configobj requires that lists are special-cased
 
2709
           self.assertRaises(AssertionError,
 
2710
                             self.assertIdempotent, ',')
 
2711
        else:
 
2712
            self.assertIdempotent(',')
 
2713
        # When a single comma is required, quoting is also required
 
2714
        self.assertIdempotent('","')
 
2715
 
 
2716
    def test_list(self):
 
2717
        if isinstance(self.store, config.IniFileStore):
 
2718
            # configobj requires that lists are special-cased
 
2719
            self.assertRaises(AssertionError,
 
2720
                              self.assertIdempotent, 'a,b')
 
2721
        else:
 
2722
            self.assertIdempotent('a,b')
 
2723
 
 
2724
 
 
2725
class TestDictFromStore(tests.TestCase):
 
2726
 
 
2727
    def test_unquote_not_string(self):
 
2728
        conf = config.MemoryStack('x=2\n[a_section]\na=1\n')
 
2729
        value = conf.get('a_section')
 
2730
        # Urgh, despite 'conf' asking for the no-name section, we get the
 
2731
        # content of another section as a dict o_O
 
2732
        self.assertEquals({'a': '1'}, value)
 
2733
        unquoted = conf.store.unquote(value)
 
2734
        # Which cannot be unquoted but shouldn't crash either (the use cases
 
2735
        # are getting the value or displaying it. In the later case, '%s' will
 
2736
        # do).
 
2737
        self.assertEquals({'a': '1'}, unquoted)
 
2738
        self.assertEquals("{u'a': u'1'}", '%s' % (unquoted,))
 
2739
 
 
2740
 
 
2741
class TestIniFileStoreContent(tests.TestCaseWithTransport):
 
2742
    """Simulate loading a config store with content of various encodings.
 
2743
 
 
2744
    All files produced by bzr are in utf8 content.
 
2745
 
 
2746
    Users may modify them manually and end up with a file that can't be
 
2747
    loaded. We need to issue proper error messages in this case.
 
2748
    """
 
2749
 
 
2750
    invalid_utf8_char = '\xff'
 
2751
 
 
2752
    def test_load_utf8(self):
 
2753
        """Ensure we can load an utf8-encoded file."""
 
2754
        t = self.get_transport()
 
2755
        # From http://pad.lv/799212
 
2756
        unicode_user = u'b\N{Euro Sign}ar'
 
2757
        unicode_content = u'user=%s' % (unicode_user,)
 
2758
        utf8_content = unicode_content.encode('utf8')
 
2759
        # Store the raw content in the config file
 
2760
        t.put_bytes('foo.conf', utf8_content)
 
2761
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2762
        store.load()
 
2763
        stack = config.Stack([store.get_sections], store)
 
2764
        self.assertEquals(unicode_user, stack.get('user'))
 
2765
 
 
2766
    def test_load_non_ascii(self):
 
2767
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2768
        t = self.get_transport()
 
2769
        t.put_bytes('foo.conf', 'user=foo\n#%s\n' % (self.invalid_utf8_char,))
 
2770
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2771
        self.assertRaises(errors.ConfigContentError, store.load)
 
2772
 
 
2773
    def test_load_erroneous_content(self):
 
2774
        """Ensure we display a proper error on content that can't be parsed."""
 
2775
        t = self.get_transport()
 
2776
        t.put_bytes('foo.conf', '[open_section\n')
 
2777
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2778
        self.assertRaises(errors.ParseConfigError, store.load)
 
2779
 
 
2780
    def test_load_permission_denied(self):
 
2781
        """Ensure we get warned when trying to load an inaccessible file."""
 
2782
        warnings = []
 
2783
        def warning(*args):
 
2784
            warnings.append(args[0] % args[1:])
 
2785
        self.overrideAttr(trace, 'warning', warning)
 
2786
 
 
2787
        t = self.get_transport()
 
2788
 
 
2789
        def get_bytes(relpath):
 
2790
            raise errors.PermissionDenied(relpath, "")
 
2791
        t.get_bytes = get_bytes
 
2792
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2793
        self.assertRaises(errors.PermissionDenied, store.load)
 
2794
        self.assertEquals(
 
2795
            warnings,
 
2796
            [u'Permission denied while trying to load configuration store %s.'
 
2797
             % store.external_url()])
 
2798
 
 
2799
 
 
2800
class TestIniConfigContent(tests.TestCaseWithTransport):
 
2801
    """Simulate loading a IniBasedConfig with content of various encodings.
 
2802
 
 
2803
    All files produced by bzr are in utf8 content.
 
2804
 
 
2805
    Users may modify them manually and end up with a file that can't be
 
2806
    loaded. We need to issue proper error messages in this case.
 
2807
    """
 
2808
 
 
2809
    invalid_utf8_char = '\xff'
 
2810
 
 
2811
    def test_load_utf8(self):
 
2812
        """Ensure we can load an utf8-encoded file."""
 
2813
        # From http://pad.lv/799212
 
2814
        unicode_user = u'b\N{Euro Sign}ar'
 
2815
        unicode_content = u'user=%s' % (unicode_user,)
 
2816
        utf8_content = unicode_content.encode('utf8')
 
2817
        # Store the raw content in the config file
 
2818
        with open('foo.conf', 'wb') as f:
 
2819
            f.write(utf8_content)
 
2820
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2821
        self.assertEquals(unicode_user, conf.get_user_option('user'))
 
2822
 
 
2823
    def test_load_badly_encoded_content(self):
 
2824
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2825
        with open('foo.conf', 'wb') as f:
 
2826
            f.write('user=foo\n#%s\n' % (self.invalid_utf8_char,))
 
2827
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2828
        self.assertRaises(errors.ConfigContentError, conf._get_parser)
 
2829
 
 
2830
    def test_load_erroneous_content(self):
 
2831
        """Ensure we display a proper error on content that can't be parsed."""
 
2832
        with open('foo.conf', 'wb') as f:
 
2833
            f.write('[open_section\n')
 
2834
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2835
        self.assertRaises(errors.ParseConfigError, conf._get_parser)
 
2836
 
 
2837
 
 
2838
class TestMutableStore(TestStore):
 
2839
 
 
2840
    scenarios = [(key, {'store_id': key, 'get_store': builder}) for key, builder
 
2841
                 in config.test_store_builder_registry.iteritems()]
 
2842
 
 
2843
    def setUp(self):
 
2844
        super(TestMutableStore, self).setUp()
 
2845
        self.transport = self.get_transport()
 
2846
 
 
2847
    def has_store(self, store):
 
2848
        store_basename = urlutils.relative_url(self.transport.external_url(),
 
2849
                                               store.external_url())
 
2850
        return self.transport.has(store_basename)
 
2851
 
 
2852
    def test_save_empty_creates_no_file(self):
 
2853
        # FIXME: There should be a better way than relying on the test
 
2854
        # parametrization to identify branch.conf -- vila 2011-0526
 
2855
        if self.store_id in ('branch', 'remote_branch'):
 
2856
            raise tests.TestNotApplicable(
 
2857
                'branch.conf is *always* created when a branch is initialized')
 
2858
        store = self.get_store(self)
 
2859
        store.save()
 
2860
        self.assertEquals(False, self.has_store(store))
 
2861
 
 
2862
    def test_mutable_section_shared(self):
 
2863
        store = self.get_store(self)
 
2864
        store._load_from_string('foo=bar\n')
 
2865
        # FIXME: There should be a better way than relying on the test
 
2866
        # parametrization to identify branch.conf -- vila 2011-0526
 
2867
        if self.store_id in ('branch', 'remote_branch'):
 
2868
            # branch stores requires write locked branches
 
2869
            self.addCleanup(store.branch.lock_write().unlock)
 
2870
        section1 = store.get_mutable_section(None)
 
2871
        section2 = store.get_mutable_section(None)
 
2872
        # If we get different sections, different callers won't share the
 
2873
        # modification
 
2874
        self.assertIs(section1, section2)
 
2875
 
 
2876
    def test_save_emptied_succeeds(self):
 
2877
        store = self.get_store(self)
 
2878
        store._load_from_string('foo=bar\n')
 
2879
        # FIXME: There should be a better way than relying on the test
 
2880
        # parametrization to identify branch.conf -- vila 2011-0526
 
2881
        if self.store_id in ('branch', 'remote_branch'):
 
2882
            # branch stores requires write locked branches
 
2883
            self.addCleanup(store.branch.lock_write().unlock)
 
2884
        section = store.get_mutable_section(None)
 
2885
        section.remove('foo')
 
2886
        store.save()
 
2887
        self.assertEquals(True, self.has_store(store))
 
2888
        modified_store = self.get_store(self)
 
2889
        sections = list(modified_store.get_sections())
 
2890
        self.assertLength(0, sections)
 
2891
 
 
2892
    def test_save_with_content_succeeds(self):
 
2893
        # FIXME: There should be a better way than relying on the test
 
2894
        # parametrization to identify branch.conf -- vila 2011-0526
 
2895
        if self.store_id in ('branch', 'remote_branch'):
 
2896
            raise tests.TestNotApplicable(
 
2897
                'branch.conf is *always* created when a branch is initialized')
 
2898
        store = self.get_store(self)
 
2899
        store._load_from_string('foo=bar\n')
 
2900
        self.assertEquals(False, self.has_store(store))
 
2901
        store.save()
 
2902
        self.assertEquals(True, self.has_store(store))
 
2903
        modified_store = self.get_store(self)
 
2904
        sections = list(modified_store.get_sections())
 
2905
        self.assertLength(1, sections)
 
2906
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2907
 
 
2908
    def test_set_option_in_empty_store(self):
 
2909
        store = self.get_store(self)
 
2910
        # FIXME: There should be a better way than relying on the test
 
2911
        # parametrization to identify branch.conf -- vila 2011-0526
 
2912
        if self.store_id in ('branch', 'remote_branch'):
 
2913
            # branch stores requires write locked branches
 
2914
            self.addCleanup(store.branch.lock_write().unlock)
 
2915
        section = store.get_mutable_section(None)
 
2916
        section.set('foo', 'bar')
 
2917
        store.save()
 
2918
        modified_store = self.get_store(self)
 
2919
        sections = list(modified_store.get_sections())
 
2920
        self.assertLength(1, sections)
 
2921
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2922
 
 
2923
    def test_set_option_in_default_section(self):
 
2924
        store = self.get_store(self)
 
2925
        store._load_from_string('')
 
2926
        # FIXME: There should be a better way than relying on the test
 
2927
        # parametrization to identify branch.conf -- vila 2011-0526
 
2928
        if self.store_id in ('branch', 'remote_branch'):
 
2929
            # branch stores requires write locked branches
 
2930
            self.addCleanup(store.branch.lock_write().unlock)
 
2931
        section = store.get_mutable_section(None)
 
2932
        section.set('foo', 'bar')
 
2933
        store.save()
 
2934
        modified_store = self.get_store(self)
 
2935
        sections = list(modified_store.get_sections())
 
2936
        self.assertLength(1, sections)
 
2937
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2938
 
 
2939
    def test_set_option_in_named_section(self):
 
2940
        store = self.get_store(self)
 
2941
        store._load_from_string('')
 
2942
        # FIXME: There should be a better way than relying on the test
 
2943
        # parametrization to identify branch.conf -- vila 2011-0526
 
2944
        if self.store_id in ('branch', 'remote_branch'):
 
2945
            # branch stores requires write locked branches
 
2946
            self.addCleanup(store.branch.lock_write().unlock)
 
2947
        section = store.get_mutable_section('baz')
 
2948
        section.set('foo', 'bar')
 
2949
        store.save()
 
2950
        modified_store = self.get_store(self)
 
2951
        sections = list(modified_store.get_sections())
 
2952
        self.assertLength(1, sections)
 
2953
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
 
2954
 
 
2955
    def test_load_hook(self):
 
2956
        # First, we need to ensure that the store exists
 
2957
        store = self.get_store(self)
 
2958
        # FIXME: There should be a better way than relying on the test
 
2959
        # parametrization to identify branch.conf -- vila 2011-0526
 
2960
        if self.store_id in ('branch', 'remote_branch'):
 
2961
            # branch stores requires write locked branches
 
2962
            self.addCleanup(store.branch.lock_write().unlock)
 
2963
        section = store.get_mutable_section('baz')
 
2964
        section.set('foo', 'bar')
 
2965
        store.save()
 
2966
        # Now we can try to load it
 
2967
        store = self.get_store(self)
 
2968
        calls = []
 
2969
        def hook(*args):
 
2970
            calls.append(args)
 
2971
        config.ConfigHooks.install_named_hook('load', hook, None)
 
2972
        self.assertLength(0, calls)
 
2973
        store.load()
 
2974
        self.assertLength(1, calls)
 
2975
        self.assertEquals((store,), calls[0])
 
2976
 
 
2977
    def test_save_hook(self):
 
2978
        calls = []
 
2979
        def hook(*args):
 
2980
            calls.append(args)
 
2981
        config.ConfigHooks.install_named_hook('save', hook, None)
 
2982
        self.assertLength(0, calls)
 
2983
        store = self.get_store(self)
 
2984
        # FIXME: There should be a better way than relying on the test
 
2985
        # parametrization to identify branch.conf -- vila 2011-0526
 
2986
        if self.store_id in ('branch', 'remote_branch'):
 
2987
            # branch stores requires write locked branches
 
2988
            self.addCleanup(store.branch.lock_write().unlock)
 
2989
        section = store.get_mutable_section('baz')
 
2990
        section.set('foo', 'bar')
 
2991
        store.save()
 
2992
        self.assertLength(1, calls)
 
2993
        self.assertEquals((store,), calls[0])
 
2994
 
 
2995
    def test_set_mark_dirty(self):
 
2996
        stack = config.MemoryStack('')
 
2997
        self.assertLength(0, stack.store.dirty_sections)
 
2998
        stack.set('foo', 'baz')
 
2999
        self.assertLength(1, stack.store.dirty_sections)
 
3000
        self.assertTrue(stack.store._need_saving())
 
3001
 
 
3002
    def test_remove_mark_dirty(self):
 
3003
        stack = config.MemoryStack('foo=bar')
 
3004
        self.assertLength(0, stack.store.dirty_sections)
 
3005
        stack.remove('foo')
 
3006
        self.assertLength(1, stack.store.dirty_sections)
 
3007
        self.assertTrue(stack.store._need_saving())
 
3008
 
 
3009
 
 
3010
class TestStoreSaveChanges(tests.TestCaseWithTransport):
 
3011
    """Tests that config changes are kept in memory and saved on-demand."""
 
3012
 
 
3013
    def setUp(self):
 
3014
        super(TestStoreSaveChanges, self).setUp()
 
3015
        self.transport = self.get_transport()
 
3016
        # Most of the tests involve two stores pointing to the same persistent
 
3017
        # storage to observe the effects of concurrent changes
 
3018
        self.st1 = config.TransportIniFileStore(self.transport, 'foo.conf')
 
3019
        self.st2 = config.TransportIniFileStore(self.transport, 'foo.conf')
 
3020
        self.warnings = []
 
3021
        def warning(*args):
 
3022
            self.warnings.append(args[0] % args[1:])
 
3023
        self.overrideAttr(trace, 'warning', warning)
 
3024
 
 
3025
    def has_store(self, store):
 
3026
        store_basename = urlutils.relative_url(self.transport.external_url(),
 
3027
                                               store.external_url())
 
3028
        return self.transport.has(store_basename)
 
3029
 
 
3030
    def get_stack(self, store):
 
3031
        # Any stack will do as long as it uses the right store, just a single
 
3032
        # no-name section is enough
 
3033
        return config.Stack([store.get_sections], store)
 
3034
 
 
3035
    def test_no_changes_no_save(self):
 
3036
        s = self.get_stack(self.st1)
 
3037
        s.store.save_changes()
 
3038
        self.assertEquals(False, self.has_store(self.st1))
 
3039
 
 
3040
    def test_unrelated_concurrent_update(self):
 
3041
        s1 = self.get_stack(self.st1)
 
3042
        s2 = self.get_stack(self.st2)
 
3043
        s1.set('foo', 'bar')
 
3044
        s2.set('baz', 'quux')
 
3045
        s1.store.save()
 
3046
        # Changes don't propagate magically
 
3047
        self.assertEquals(None, s1.get('baz'))
 
3048
        s2.store.save_changes()
 
3049
        self.assertEquals('quux', s2.get('baz'))
 
3050
        # Changes are acquired when saving
 
3051
        self.assertEquals('bar', s2.get('foo'))
 
3052
        # Since there is no overlap, no warnings are emitted
 
3053
        self.assertLength(0, self.warnings)
 
3054
 
 
3055
    def test_concurrent_update_modified(self):
 
3056
        s1 = self.get_stack(self.st1)
 
3057
        s2 = self.get_stack(self.st2)
 
3058
        s1.set('foo', 'bar')
 
3059
        s2.set('foo', 'baz')
 
3060
        s1.store.save()
 
3061
        # Last speaker wins
 
3062
        s2.store.save_changes()
 
3063
        self.assertEquals('baz', s2.get('foo'))
 
3064
        # But the user get a warning
 
3065
        self.assertLength(1, self.warnings)
 
3066
        warning = self.warnings[0]
 
3067
        self.assertStartsWith(warning, 'Option foo in section None')
 
3068
        self.assertEndsWith(warning, 'was changed from <CREATED> to bar.'
 
3069
                            ' The baz value will be saved.')
 
3070
 
 
3071
    def test_concurrent_deletion(self):
 
3072
        self.st1._load_from_string('foo=bar')
 
3073
        self.st1.save()
 
3074
        s1 = self.get_stack(self.st1)
 
3075
        s2 = self.get_stack(self.st2)
 
3076
        s1.remove('foo')
 
3077
        s2.remove('foo')
 
3078
        s1.store.save_changes()
 
3079
        # No warning yet
 
3080
        self.assertLength(0, self.warnings)
 
3081
        s2.store.save_changes()
 
3082
        # Now we get one
 
3083
        self.assertLength(1, self.warnings)
 
3084
        warning = self.warnings[0]
 
3085
        self.assertStartsWith(warning, 'Option foo in section None')
 
3086
        self.assertEndsWith(warning, 'was changed from bar to <CREATED>.'
 
3087
                            ' The <DELETED> value will be saved.')
 
3088
 
 
3089
 
 
3090
class TestQuotingIniFileStore(tests.TestCaseWithTransport):
 
3091
 
 
3092
    def get_store(self):
 
3093
        return config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3094
 
 
3095
    def test_get_quoted_string(self):
 
3096
        store = self.get_store()
 
3097
        store._load_from_string('foo= " abc "')
 
3098
        stack = config.Stack([store.get_sections])
 
3099
        self.assertEquals(' abc ', stack.get('foo'))
 
3100
 
 
3101
    def test_set_quoted_string(self):
 
3102
        store = self.get_store()
 
3103
        stack = config.Stack([store.get_sections], store)
 
3104
        stack.set('foo', ' a b c ')
 
3105
        store.save()
 
3106
        self.assertFileEqual('foo = " a b c "' + os.linesep, 'foo.conf')
 
3107
 
 
3108
 
 
3109
class TestTransportIniFileStore(TestStore):
 
3110
 
 
3111
    def test_loading_unknown_file_fails(self):
 
3112
        store = config.TransportIniFileStore(self.get_transport(),
 
3113
            'I-do-not-exist')
 
3114
        self.assertRaises(errors.NoSuchFile, store.load)
 
3115
 
 
3116
    def test_invalid_content(self):
 
3117
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3118
        self.assertEquals(False, store.is_loaded())
 
3119
        exc = self.assertRaises(
 
3120
            errors.ParseConfigError, store._load_from_string,
 
3121
            'this is invalid !')
 
3122
        self.assertEndsWith(exc.filename, 'foo.conf')
 
3123
        # And the load failed
 
3124
        self.assertEquals(False, store.is_loaded())
 
3125
 
 
3126
    def test_get_embedded_sections(self):
 
3127
        # A more complicated example (which also shows that section names and
 
3128
        # option names share the same name space...)
 
3129
        # FIXME: This should be fixed by forbidding dicts as values ?
 
3130
        # -- vila 2011-04-05
 
3131
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3132
        store._load_from_string('''
 
3133
foo=bar
 
3134
l=1,2
 
3135
[DEFAULT]
 
3136
foo_in_DEFAULT=foo_DEFAULT
 
3137
[bar]
 
3138
foo_in_bar=barbar
 
3139
[baz]
 
3140
foo_in_baz=barbaz
 
3141
[[qux]]
 
3142
foo_in_qux=quux
 
3143
''')
 
3144
        sections = list(store.get_sections())
 
3145
        self.assertLength(4, sections)
 
3146
        # The default section has no name.
 
3147
        # List values are provided as strings and need to be explicitly
 
3148
        # converted by specifying from_unicode=list_from_store at option
 
3149
        # registration
 
3150
        self.assertSectionContent((None, {'foo': 'bar', 'l': u'1,2'}),
 
3151
                                  sections[0])
 
3152
        self.assertSectionContent(
 
3153
            ('DEFAULT', {'foo_in_DEFAULT': 'foo_DEFAULT'}), sections[1])
 
3154
        self.assertSectionContent(
 
3155
            ('bar', {'foo_in_bar': 'barbar'}), sections[2])
 
3156
        # sub sections are provided as embedded dicts.
 
3157
        self.assertSectionContent(
 
3158
            ('baz', {'foo_in_baz': 'barbaz', 'qux': {'foo_in_qux': 'quux'}}),
 
3159
            sections[3])
 
3160
 
 
3161
 
 
3162
class TestLockableIniFileStore(TestStore):
 
3163
 
 
3164
    def test_create_store_in_created_dir(self):
 
3165
        self.assertPathDoesNotExist('dir')
 
3166
        t = self.get_transport('dir/subdir')
 
3167
        store = config.LockableIniFileStore(t, 'foo.conf')
 
3168
        store.get_mutable_section(None).set('foo', 'bar')
 
3169
        store.save()
 
3170
        self.assertPathExists('dir/subdir')
 
3171
 
 
3172
 
 
3173
class TestConcurrentStoreUpdates(TestStore):
 
3174
    """Test that Stores properly handle conccurent updates.
 
3175
 
 
3176
    New Store implementation may fail some of these tests but until such
 
3177
    implementations exist it's hard to properly filter them from the scenarios
 
3178
    applied here. If you encounter such a case, contact the bzr devs.
 
3179
    """
 
3180
 
 
3181
    scenarios = [(key, {'get_stack': builder}) for key, builder
 
3182
                 in config.test_stack_builder_registry.iteritems()]
 
3183
 
 
3184
    def setUp(self):
 
3185
        super(TestConcurrentStoreUpdates, self).setUp()
 
3186
        self.stack = self.get_stack(self)
 
3187
        if not isinstance(self.stack, config._CompatibleStack):
 
3188
            raise tests.TestNotApplicable(
 
3189
                '%s is not meant to be compatible with the old config design'
 
3190
                % (self.stack,))
 
3191
        self.stack.set('one', '1')
 
3192
        self.stack.set('two', '2')
 
3193
        # Flush the store
 
3194
        self.stack.store.save()
 
3195
 
 
3196
    def test_simple_read_access(self):
 
3197
        self.assertEquals('1', self.stack.get('one'))
 
3198
 
 
3199
    def test_simple_write_access(self):
 
3200
        self.stack.set('one', 'one')
 
3201
        self.assertEquals('one', self.stack.get('one'))
 
3202
 
 
3203
    def test_listen_to_the_last_speaker(self):
 
3204
        c1 = self.stack
 
3205
        c2 = self.get_stack(self)
 
3206
        c1.set('one', 'ONE')
 
3207
        c2.set('two', 'TWO')
 
3208
        self.assertEquals('ONE', c1.get('one'))
 
3209
        self.assertEquals('TWO', c2.get('two'))
 
3210
        # The second update respect the first one
 
3211
        self.assertEquals('ONE', c2.get('one'))
 
3212
 
 
3213
    def test_last_speaker_wins(self):
 
3214
        # If the same config is not shared, the same variable modified twice
 
3215
        # can only see a single result.
 
3216
        c1 = self.stack
 
3217
        c2 = self.get_stack(self)
 
3218
        c1.set('one', 'c1')
 
3219
        c2.set('one', 'c2')
 
3220
        self.assertEquals('c2', c2.get('one'))
 
3221
        # The first modification is still available until another refresh
 
3222
        # occur
 
3223
        self.assertEquals('c1', c1.get('one'))
 
3224
        c1.set('two', 'done')
 
3225
        self.assertEquals('c2', c1.get('one'))
 
3226
 
 
3227
    def test_writes_are_serialized(self):
 
3228
        c1 = self.stack
 
3229
        c2 = self.get_stack(self)
 
3230
 
 
3231
        # We spawn a thread that will pause *during* the config saving.
 
3232
        before_writing = threading.Event()
 
3233
        after_writing = threading.Event()
 
3234
        writing_done = threading.Event()
 
3235
        c1_save_without_locking_orig = c1.store.save_without_locking
 
3236
        def c1_save_without_locking():
 
3237
            before_writing.set()
 
3238
            c1_save_without_locking_orig()
 
3239
            # The lock is held. We wait for the main thread to decide when to
 
3240
            # continue
 
3241
            after_writing.wait()
 
3242
        c1.store.save_without_locking = c1_save_without_locking
 
3243
        def c1_set():
 
3244
            c1.set('one', 'c1')
 
3245
            writing_done.set()
 
3246
        t1 = threading.Thread(target=c1_set)
 
3247
        # Collect the thread after the test
 
3248
        self.addCleanup(t1.join)
 
3249
        # Be ready to unblock the thread if the test goes wrong
 
3250
        self.addCleanup(after_writing.set)
 
3251
        t1.start()
 
3252
        before_writing.wait()
 
3253
        self.assertRaises(errors.LockContention,
 
3254
                          c2.set, 'one', 'c2')
 
3255
        self.assertEquals('c1', c1.get('one'))
 
3256
        # Let the lock be released
 
3257
        after_writing.set()
 
3258
        writing_done.wait()
 
3259
        c2.set('one', 'c2')
 
3260
        self.assertEquals('c2', c2.get('one'))
 
3261
 
 
3262
    def test_read_while_writing(self):
 
3263
       c1 = self.stack
 
3264
       # We spawn a thread that will pause *during* the write
 
3265
       ready_to_write = threading.Event()
 
3266
       do_writing = threading.Event()
 
3267
       writing_done = threading.Event()
 
3268
       # We override the _save implementation so we know the store is locked
 
3269
       c1_save_without_locking_orig = c1.store.save_without_locking
 
3270
       def c1_save_without_locking():
 
3271
           ready_to_write.set()
 
3272
           # The lock is held. We wait for the main thread to decide when to
 
3273
           # continue
 
3274
           do_writing.wait()
 
3275
           c1_save_without_locking_orig()
 
3276
           writing_done.set()
 
3277
       c1.store.save_without_locking = c1_save_without_locking
 
3278
       def c1_set():
 
3279
           c1.set('one', 'c1')
 
3280
       t1 = threading.Thread(target=c1_set)
 
3281
       # Collect the thread after the test
 
3282
       self.addCleanup(t1.join)
 
3283
       # Be ready to unblock the thread if the test goes wrong
 
3284
       self.addCleanup(do_writing.set)
 
3285
       t1.start()
 
3286
       # Ensure the thread is ready to write
 
3287
       ready_to_write.wait()
 
3288
       self.assertEquals('c1', c1.get('one'))
 
3289
       # If we read during the write, we get the old value
 
3290
       c2 = self.get_stack(self)
 
3291
       self.assertEquals('1', c2.get('one'))
 
3292
       # Let the writing occur and ensure it occurred
 
3293
       do_writing.set()
 
3294
       writing_done.wait()
 
3295
       # Now we get the updated value
 
3296
       c3 = self.get_stack(self)
 
3297
       self.assertEquals('c1', c3.get('one'))
 
3298
 
 
3299
    # FIXME: It may be worth looking into removing the lock dir when it's not
 
3300
    # needed anymore and look at possible fallouts for concurrent lockers. This
 
3301
    # will matter if/when we use config files outside of bazaar directories
 
3302
    # (.bazaar or .bzr) -- vila 20110-04-111
 
3303
 
 
3304
 
 
3305
class TestSectionMatcher(TestStore):
 
3306
 
 
3307
    scenarios = [('location', {'matcher': config.LocationMatcher}),
 
3308
                 ('id', {'matcher': config.NameMatcher}),]
 
3309
 
 
3310
    def setUp(self):
 
3311
        super(TestSectionMatcher, self).setUp()
 
3312
        # Any simple store is good enough
 
3313
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3314
 
 
3315
    def test_no_matches_for_empty_stores(self):
 
3316
        store = self.get_store(self)
 
3317
        store._load_from_string('')
 
3318
        matcher = self.matcher(store, '/bar')
 
3319
        self.assertEquals([], list(matcher.get_sections()))
 
3320
 
 
3321
    def test_build_doesnt_load_store(self):
 
3322
        store = self.get_store(self)
 
3323
        matcher = self.matcher(store, '/bar')
 
3324
        self.assertFalse(store.is_loaded())
 
3325
 
 
3326
 
 
3327
class TestLocationSection(tests.TestCase):
 
3328
 
 
3329
    def get_section(self, options, extra_path):
 
3330
        section = config.Section('foo', options)
 
3331
        return config.LocationSection(section, extra_path)
 
3332
 
 
3333
    def test_simple_option(self):
 
3334
        section = self.get_section({'foo': 'bar'}, '')
 
3335
        self.assertEquals('bar', section.get('foo'))
 
3336
 
 
3337
    def test_option_with_extra_path(self):
 
3338
        section = self.get_section({'foo': 'bar', 'foo:policy': 'appendpath'},
 
3339
                                   'baz')
 
3340
        self.assertEquals('bar/baz', section.get('foo'))
 
3341
 
 
3342
    def test_invalid_policy(self):
 
3343
        section = self.get_section({'foo': 'bar', 'foo:policy': 'die'},
 
3344
                                   'baz')
 
3345
        # invalid policies are ignored
 
3346
        self.assertEquals('bar', section.get('foo'))
 
3347
 
 
3348
 
 
3349
class TestLocationMatcher(TestStore):
 
3350
 
 
3351
    def setUp(self):
 
3352
        super(TestLocationMatcher, self).setUp()
 
3353
        # Any simple store is good enough
 
3354
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3355
 
 
3356
    def test_unrelated_section_excluded(self):
 
3357
        store = self.get_store(self)
 
3358
        store._load_from_string('''
 
3359
[/foo]
 
3360
section=/foo
 
3361
[/foo/baz]
 
3362
section=/foo/baz
 
3363
[/foo/bar]
 
3364
section=/foo/bar
 
3365
[/foo/bar/baz]
 
3366
section=/foo/bar/baz
 
3367
[/quux/quux]
 
3368
section=/quux/quux
 
3369
''')
 
3370
        self.assertEquals(['/foo', '/foo/baz', '/foo/bar', '/foo/bar/baz',
 
3371
                           '/quux/quux'],
 
3372
                          [section.id for _, section in store.get_sections()])
 
3373
        matcher = config.LocationMatcher(store, '/foo/bar/quux')
 
3374
        sections = [section for _, section in matcher.get_sections()]
 
3375
        self.assertEquals(['/foo/bar', '/foo'],
 
3376
                          [section.id for section in sections])
 
3377
        self.assertEquals(['quux', 'bar/quux'],
 
3378
                          [section.extra_path for section in sections])
 
3379
 
 
3380
    def test_more_specific_sections_first(self):
 
3381
        store = self.get_store(self)
 
3382
        store._load_from_string('''
 
3383
[/foo]
 
3384
section=/foo
 
3385
[/foo/bar]
 
3386
section=/foo/bar
 
3387
''')
 
3388
        self.assertEquals(['/foo', '/foo/bar'],
 
3389
                          [section.id for _, section in store.get_sections()])
 
3390
        matcher = config.LocationMatcher(store, '/foo/bar/baz')
 
3391
        sections = [section for _, section in matcher.get_sections()]
 
3392
        self.assertEquals(['/foo/bar', '/foo'],
 
3393
                          [section.id for section in sections])
 
3394
        self.assertEquals(['baz', 'bar/baz'],
 
3395
                          [section.extra_path for section in sections])
 
3396
 
 
3397
    def test_appendpath_in_no_name_section(self):
 
3398
        # It's a bit weird to allow appendpath in a no-name section, but
 
3399
        # someone may found a use for it
 
3400
        store = self.get_store(self)
 
3401
        store._load_from_string('''
 
3402
foo=bar
 
3403
foo:policy = appendpath
 
3404
''')
 
3405
        matcher = config.LocationMatcher(store, 'dir/subdir')
 
3406
        sections = list(matcher.get_sections())
 
3407
        self.assertLength(1, sections)
 
3408
        self.assertEquals('bar/dir/subdir', sections[0][1].get('foo'))
 
3409
 
 
3410
    def test_file_urls_are_normalized(self):
 
3411
        store = self.get_store(self)
 
3412
        if sys.platform == 'win32':
 
3413
            expected_url = 'file:///C:/dir/subdir'
 
3414
            expected_location = 'C:/dir/subdir'
 
3415
        else:
 
3416
            expected_url = 'file:///dir/subdir'
 
3417
            expected_location = '/dir/subdir'
 
3418
        matcher = config.LocationMatcher(store, expected_url)
 
3419
        self.assertEquals(expected_location, matcher.location)
 
3420
 
 
3421
    def test_branch_name_colo(self):
 
3422
        store = self.get_store(self)
 
3423
        store._load_from_string(dedent("""\
 
3424
            [/]
 
3425
            push_location=my{branchname}
 
3426
        """))
 
3427
        matcher = config.LocationMatcher(store, 'file:///,branch=example%3c')
 
3428
        self.assertEqual('example<', matcher.branch_name)
 
3429
        ((_, section),) = matcher.get_sections()
 
3430
        self.assertEqual('example<', section.locals['branchname'])
 
3431
 
 
3432
    def test_branch_name_basename(self):
 
3433
        store = self.get_store(self)
 
3434
        store._load_from_string(dedent("""\
 
3435
            [/]
 
3436
            push_location=my{branchname}
 
3437
        """))
 
3438
        matcher = config.LocationMatcher(store, 'file:///parent/example%3c')
 
3439
        self.assertEqual('example<', matcher.branch_name)
 
3440
        ((_, section),) = matcher.get_sections()
 
3441
        self.assertEqual('example<', section.locals['branchname'])
 
3442
 
 
3443
 
 
3444
class TestStartingPathMatcher(TestStore):
 
3445
 
 
3446
    def setUp(self):
 
3447
        super(TestStartingPathMatcher, self).setUp()
 
3448
        # Any simple store is good enough
 
3449
        self.store = config.IniFileStore()
 
3450
 
 
3451
    def assertSectionIDs(self, expected, location, content):
 
3452
        self.store._load_from_string(content)
 
3453
        matcher = config.StartingPathMatcher(self.store, location)
 
3454
        sections = list(matcher.get_sections())
 
3455
        self.assertLength(len(expected), sections)
 
3456
        self.assertEqual(expected, [section.id for _, section in sections])
 
3457
        return sections
 
3458
 
 
3459
    def test_empty(self):
 
3460
        self.assertSectionIDs([], self.get_url(), '')
 
3461
 
 
3462
    def test_url_vs_local_paths(self):
 
3463
        # The matcher location is an url and the section names are local paths
 
3464
        sections = self.assertSectionIDs(['/foo/bar', '/foo'],
 
3465
                                         'file:///foo/bar/baz', '''\
 
3466
[/foo]
 
3467
[/foo/bar]
 
3468
''')
 
3469
 
 
3470
    def test_local_path_vs_url(self):
 
3471
        # The matcher location is a local path and the section names are urls
 
3472
        sections = self.assertSectionIDs(['file:///foo/bar', 'file:///foo'],
 
3473
                                         '/foo/bar/baz', '''\
 
3474
[file:///foo]
 
3475
[file:///foo/bar]
 
3476
''')
 
3477
 
 
3478
 
 
3479
    def test_no_name_section_included_when_present(self):
 
3480
        # Note that other tests will cover the case where the no-name section
 
3481
        # is empty and as such, not included.
 
3482
        sections = self.assertSectionIDs(['/foo/bar', '/foo', None],
 
3483
                                         '/foo/bar/baz', '''\
 
3484
option = defined so the no-name section exists
 
3485
[/foo]
 
3486
[/foo/bar]
 
3487
''')
 
3488
        self.assertEquals(['baz', 'bar/baz', '/foo/bar/baz'],
 
3489
                          [s.locals['relpath'] for _, s in sections])
 
3490
 
 
3491
    def test_order_reversed(self):
 
3492
        self.assertSectionIDs(['/foo/bar', '/foo'], '/foo/bar/baz', '''\
 
3493
[/foo]
 
3494
[/foo/bar]
 
3495
''')
 
3496
 
 
3497
    def test_unrelated_section_excluded(self):
 
3498
        self.assertSectionIDs(['/foo/bar', '/foo'], '/foo/bar/baz', '''\
 
3499
[/foo]
 
3500
[/foo/qux]
 
3501
[/foo/bar]
 
3502
''')
 
3503
 
 
3504
    def test_glob_included(self):
 
3505
        sections = self.assertSectionIDs(['/foo/*/baz', '/foo/b*', '/foo'],
 
3506
                                         '/foo/bar/baz', '''\
 
3507
[/foo]
 
3508
[/foo/qux]
 
3509
[/foo/b*]
 
3510
[/foo/*/baz]
 
3511
''')
 
3512
        # Note that 'baz' as a relpath for /foo/b* is not fully correct, but
 
3513
        # nothing really is... as far using {relpath} to append it to something
 
3514
        # else, this seems good enough though.
 
3515
        self.assertEquals(['', 'baz', 'bar/baz'],
 
3516
                          [s.locals['relpath'] for _, s in sections])
 
3517
 
 
3518
    def test_respect_order(self):
 
3519
        self.assertSectionIDs(['/foo', '/foo/b*', '/foo/*/baz'],
 
3520
                              '/foo/bar/baz', '''\
 
3521
[/foo/*/baz]
 
3522
[/foo/qux]
 
3523
[/foo/b*]
 
3524
[/foo]
 
3525
''')
 
3526
 
 
3527
 
 
3528
class TestNameMatcher(TestStore):
 
3529
 
 
3530
    def setUp(self):
 
3531
        super(TestNameMatcher, self).setUp()
 
3532
        self.matcher = config.NameMatcher
 
3533
        # Any simple store is good enough
 
3534
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3535
 
 
3536
    def get_matching_sections(self, name):
 
3537
        store = self.get_store(self)
 
3538
        store._load_from_string('''
 
3539
[foo]
 
3540
option=foo
 
3541
[foo/baz]
 
3542
option=foo/baz
 
3543
[bar]
 
3544
option=bar
 
3545
''')
 
3546
        matcher = self.matcher(store, name)
 
3547
        return list(matcher.get_sections())
 
3548
 
 
3549
    def test_matching(self):
 
3550
        sections = self.get_matching_sections('foo')
 
3551
        self.assertLength(1, sections)
 
3552
        self.assertSectionContent(('foo', {'option': 'foo'}), sections[0])
 
3553
 
 
3554
    def test_not_matching(self):
 
3555
        sections = self.get_matching_sections('baz')
 
3556
        self.assertLength(0, sections)
 
3557
 
 
3558
 
 
3559
class TestBaseStackGet(tests.TestCase):
 
3560
 
 
3561
    def setUp(self):
 
3562
        super(TestBaseStackGet, self).setUp()
 
3563
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3564
 
 
3565
    def test_get_first_definition(self):
 
3566
        store1 = config.IniFileStore()
 
3567
        store1._load_from_string('foo=bar')
 
3568
        store2 = config.IniFileStore()
 
3569
        store2._load_from_string('foo=baz')
 
3570
        conf = config.Stack([store1.get_sections, store2.get_sections])
 
3571
        self.assertEquals('bar', conf.get('foo'))
 
3572
 
 
3573
    def test_get_with_registered_default_value(self):
 
3574
        config.option_registry.register(config.Option('foo', default='bar'))
 
3575
        conf_stack = config.Stack([])
 
3576
        self.assertEquals('bar', conf_stack.get('foo'))
 
3577
 
 
3578
    def test_get_without_registered_default_value(self):
 
3579
        config.option_registry.register(config.Option('foo'))
 
3580
        conf_stack = config.Stack([])
 
3581
        self.assertEquals(None, conf_stack.get('foo'))
 
3582
 
 
3583
    def test_get_without_default_value_for_not_registered(self):
 
3584
        conf_stack = config.Stack([])
 
3585
        self.assertEquals(None, conf_stack.get('foo'))
 
3586
 
 
3587
    def test_get_for_empty_section_callable(self):
 
3588
        conf_stack = config.Stack([lambda : []])
 
3589
        self.assertEquals(None, conf_stack.get('foo'))
 
3590
 
 
3591
    def test_get_for_broken_callable(self):
 
3592
        # Trying to use and invalid callable raises an exception on first use
 
3593
        conf_stack = config.Stack([object])
 
3594
        self.assertRaises(TypeError, conf_stack.get, 'foo')
 
3595
 
 
3596
 
 
3597
class TestStackWithSimpleStore(tests.TestCase):
 
3598
 
 
3599
    def setUp(self):
 
3600
        super(TestStackWithSimpleStore, self).setUp()
 
3601
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3602
        self.registry = config.option_registry
 
3603
 
 
3604
    def get_conf(self, content=None):
 
3605
        return config.MemoryStack(content)
 
3606
 
 
3607
    def test_override_value_from_env(self):
 
3608
        self.overrideEnv('FOO', None)
 
3609
        self.registry.register(
 
3610
            config.Option('foo', default='bar', override_from_env=['FOO']))
 
3611
        self.overrideEnv('FOO', 'quux')
 
3612
        # Env variable provides a default taking over the option one
 
3613
        conf = self.get_conf('foo=store')
 
3614
        self.assertEquals('quux', conf.get('foo'))
 
3615
 
 
3616
    def test_first_override_value_from_env_wins(self):
 
3617
        self.overrideEnv('NO_VALUE', None)
 
3618
        self.overrideEnv('FOO', None)
 
3619
        self.overrideEnv('BAZ', None)
 
3620
        self.registry.register(
 
3621
            config.Option('foo', default='bar',
 
3622
                          override_from_env=['NO_VALUE', 'FOO', 'BAZ']))
 
3623
        self.overrideEnv('FOO', 'foo')
 
3624
        self.overrideEnv('BAZ', 'baz')
 
3625
        # The first env var set wins
 
3626
        conf = self.get_conf('foo=store')
 
3627
        self.assertEquals('foo', conf.get('foo'))
 
3628
 
 
3629
 
 
3630
class TestMemoryStack(tests.TestCase):
 
3631
 
 
3632
    def test_get(self):
 
3633
        conf = config.MemoryStack('foo=bar')
 
3634
        self.assertEquals('bar', conf.get('foo'))
 
3635
 
 
3636
    def test_set(self):
 
3637
        conf = config.MemoryStack('foo=bar')
 
3638
        conf.set('foo', 'baz')
 
3639
        self.assertEquals('baz', conf.get('foo'))
 
3640
 
 
3641
    def test_no_content(self):
 
3642
        conf = config.MemoryStack()
 
3643
        # No content means no loading
 
3644
        self.assertFalse(conf.store.is_loaded())
 
3645
        self.assertRaises(NotImplementedError, conf.get, 'foo')
 
3646
        # But a content can still be provided
 
3647
        conf.store._load_from_string('foo=bar')
 
3648
        self.assertEquals('bar', conf.get('foo'))
 
3649
 
 
3650
 
 
3651
class TestStackIterSections(tests.TestCase):
 
3652
 
 
3653
    def test_empty_stack(self):
 
3654
        conf = config.Stack([])
 
3655
        sections = list(conf.iter_sections())
 
3656
        self.assertLength(0, sections)
 
3657
 
 
3658
    def test_empty_store(self):
 
3659
        store = config.IniFileStore()
 
3660
        store._load_from_string('')
 
3661
        conf = config.Stack([store.get_sections])
 
3662
        sections = list(conf.iter_sections())
 
3663
        self.assertLength(0, sections)
 
3664
 
 
3665
    def test_simple_store(self):
 
3666
        store = config.IniFileStore()
 
3667
        store._load_from_string('foo=bar')
 
3668
        conf = config.Stack([store.get_sections])
 
3669
        tuples = list(conf.iter_sections())
 
3670
        self.assertLength(1, tuples)
 
3671
        (found_store, found_section) = tuples[0]
 
3672
        self.assertIs(store, found_store)
 
3673
 
 
3674
    def test_two_stores(self):
 
3675
        store1 = config.IniFileStore()
 
3676
        store1._load_from_string('foo=bar')
 
3677
        store2 = config.IniFileStore()
 
3678
        store2._load_from_string('bar=qux')
 
3679
        conf = config.Stack([store1.get_sections, store2.get_sections])
 
3680
        tuples = list(conf.iter_sections())
 
3681
        self.assertLength(2, tuples)
 
3682
        self.assertIs(store1, tuples[0][0])
 
3683
        self.assertIs(store2, tuples[1][0])
 
3684
 
 
3685
 
 
3686
class TestStackWithTransport(tests.TestCaseWithTransport):
 
3687
 
 
3688
    scenarios = [(key, {'get_stack': builder}) for key, builder
 
3689
                 in config.test_stack_builder_registry.iteritems()]
 
3690
 
 
3691
 
 
3692
class TestConcreteStacks(TestStackWithTransport):
 
3693
 
 
3694
    def test_build_stack(self):
 
3695
        # Just a smoke test to help debug builders
 
3696
        stack = self.get_stack(self)
 
3697
 
 
3698
 
 
3699
class TestStackGet(TestStackWithTransport):
 
3700
 
 
3701
    def setUp(self):
 
3702
        super(TestStackGet, self).setUp()
 
3703
        self.conf = self.get_stack(self)
 
3704
 
 
3705
    def test_get_for_empty_stack(self):
 
3706
        self.assertEquals(None, self.conf.get('foo'))
 
3707
 
 
3708
    def test_get_hook(self):
 
3709
        self.conf.set('foo', 'bar')
 
3710
        calls = []
 
3711
        def hook(*args):
 
3712
            calls.append(args)
 
3713
        config.ConfigHooks.install_named_hook('get', hook, None)
 
3714
        self.assertLength(0, calls)
 
3715
        value = self.conf.get('foo')
 
3716
        self.assertEquals('bar', value)
 
3717
        self.assertLength(1, calls)
 
3718
        self.assertEquals((self.conf, 'foo', 'bar'), calls[0])
 
3719
 
 
3720
 
 
3721
class TestStackGetWithConverter(tests.TestCase):
 
3722
 
 
3723
    def setUp(self):
 
3724
        super(TestStackGetWithConverter, self).setUp()
 
3725
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3726
        self.registry = config.option_registry
 
3727
 
 
3728
    def get_conf(self, content=None):
 
3729
        return config.MemoryStack(content)
 
3730
 
 
3731
    def register_bool_option(self, name, default=None, default_from_env=None):
 
3732
        b = config.Option(name, help='A boolean.',
 
3733
                          default=default, default_from_env=default_from_env,
 
3734
                          from_unicode=config.bool_from_store)
 
3735
        self.registry.register(b)
 
3736
 
 
3737
    def test_get_default_bool_None(self):
 
3738
        self.register_bool_option('foo')
 
3739
        conf = self.get_conf('')
 
3740
        self.assertEquals(None, conf.get('foo'))
 
3741
 
 
3742
    def test_get_default_bool_True(self):
 
3743
        self.register_bool_option('foo', u'True')
 
3744
        conf = self.get_conf('')
 
3745
        self.assertEquals(True, conf.get('foo'))
 
3746
 
 
3747
    def test_get_default_bool_False(self):
 
3748
        self.register_bool_option('foo', False)
 
3749
        conf = self.get_conf('')
 
3750
        self.assertEquals(False, conf.get('foo'))
 
3751
 
 
3752
    def test_get_default_bool_False_as_string(self):
 
3753
        self.register_bool_option('foo', u'False')
 
3754
        conf = self.get_conf('')
 
3755
        self.assertEquals(False, conf.get('foo'))
 
3756
 
 
3757
    def test_get_default_bool_from_env_converted(self):
 
3758
        self.register_bool_option('foo', u'True', default_from_env=['FOO'])
 
3759
        self.overrideEnv('FOO', 'False')
 
3760
        conf = self.get_conf('')
 
3761
        self.assertEquals(False, conf.get('foo'))
 
3762
 
 
3763
    def test_get_default_bool_when_conversion_fails(self):
 
3764
        self.register_bool_option('foo', default='True')
 
3765
        conf = self.get_conf('foo=invalid boolean')
 
3766
        self.assertEquals(True, conf.get('foo'))
 
3767
 
 
3768
    def register_integer_option(self, name,
 
3769
                                default=None, default_from_env=None):
 
3770
        i = config.Option(name, help='An integer.',
 
3771
                          default=default, default_from_env=default_from_env,
 
3772
                          from_unicode=config.int_from_store)
 
3773
        self.registry.register(i)
 
3774
 
 
3775
    def test_get_default_integer_None(self):
 
3776
        self.register_integer_option('foo')
 
3777
        conf = self.get_conf('')
 
3778
        self.assertEquals(None, conf.get('foo'))
 
3779
 
 
3780
    def test_get_default_integer(self):
 
3781
        self.register_integer_option('foo', 42)
 
3782
        conf = self.get_conf('')
 
3783
        self.assertEquals(42, conf.get('foo'))
 
3784
 
 
3785
    def test_get_default_integer_as_string(self):
 
3786
        self.register_integer_option('foo', u'42')
 
3787
        conf = self.get_conf('')
 
3788
        self.assertEquals(42, conf.get('foo'))
 
3789
 
 
3790
    def test_get_default_integer_from_env(self):
 
3791
        self.register_integer_option('foo', default_from_env=['FOO'])
 
3792
        self.overrideEnv('FOO', '18')
 
3793
        conf = self.get_conf('')
 
3794
        self.assertEquals(18, conf.get('foo'))
 
3795
 
 
3796
    def test_get_default_integer_when_conversion_fails(self):
 
3797
        self.register_integer_option('foo', default='12')
 
3798
        conf = self.get_conf('foo=invalid integer')
 
3799
        self.assertEquals(12, conf.get('foo'))
 
3800
 
 
3801
    def register_list_option(self, name, default=None, default_from_env=None):
 
3802
        l = config.ListOption(name, help='A list.', default=default,
 
3803
                              default_from_env=default_from_env)
 
3804
        self.registry.register(l)
 
3805
 
 
3806
    def test_get_default_list_None(self):
 
3807
        self.register_list_option('foo')
 
3808
        conf = self.get_conf('')
 
3809
        self.assertEquals(None, conf.get('foo'))
 
3810
 
 
3811
    def test_get_default_list_empty(self):
 
3812
        self.register_list_option('foo', '')
 
3813
        conf = self.get_conf('')
 
3814
        self.assertEquals([], conf.get('foo'))
 
3815
 
 
3816
    def test_get_default_list_from_env(self):
 
3817
        self.register_list_option('foo', default_from_env=['FOO'])
 
3818
        self.overrideEnv('FOO', '')
 
3819
        conf = self.get_conf('')
 
3820
        self.assertEquals([], conf.get('foo'))
 
3821
 
 
3822
    def test_get_with_list_converter_no_item(self):
 
3823
        self.register_list_option('foo', None)
 
3824
        conf = self.get_conf('foo=,')
 
3825
        self.assertEquals([], conf.get('foo'))
 
3826
 
 
3827
    def test_get_with_list_converter_many_items(self):
 
3828
        self.register_list_option('foo', None)
 
3829
        conf = self.get_conf('foo=m,o,r,e')
 
3830
        self.assertEquals(['m', 'o', 'r', 'e'], conf.get('foo'))
 
3831
 
 
3832
    def test_get_with_list_converter_embedded_spaces_many_items(self):
 
3833
        self.register_list_option('foo', None)
 
3834
        conf = self.get_conf('foo=" bar", "baz "')
 
3835
        self.assertEquals([' bar', 'baz '], conf.get('foo'))
 
3836
 
 
3837
    def test_get_with_list_converter_stripped_spaces_many_items(self):
 
3838
        self.register_list_option('foo', None)
 
3839
        conf = self.get_conf('foo= bar ,  baz ')
 
3840
        self.assertEquals(['bar', 'baz'], conf.get('foo'))
 
3841
 
 
3842
 
 
3843
class TestIterOptionRefs(tests.TestCase):
 
3844
    """iter_option_refs is a bit unusual, document some cases."""
 
3845
 
 
3846
    def assertRefs(self, expected, string):
 
3847
        self.assertEquals(expected, list(config.iter_option_refs(string)))
 
3848
 
 
3849
    def test_empty(self):
 
3850
        self.assertRefs([(False, '')], '')
 
3851
 
 
3852
    def test_no_refs(self):
 
3853
        self.assertRefs([(False, 'foo bar')], 'foo bar')
 
3854
 
 
3855
    def test_single_ref(self):
 
3856
        self.assertRefs([(False, ''), (True, '{foo}'), (False, '')], '{foo}')
 
3857
 
 
3858
    def test_broken_ref(self):
 
3859
        self.assertRefs([(False, '{foo')], '{foo')
 
3860
 
 
3861
    def test_embedded_ref(self):
 
3862
        self.assertRefs([(False, '{'), (True, '{foo}'), (False, '}')],
 
3863
                        '{{foo}}')
 
3864
 
 
3865
    def test_two_refs(self):
 
3866
        self.assertRefs([(False, ''), (True, '{foo}'),
 
3867
                         (False, ''), (True, '{bar}'),
 
3868
                         (False, ''),],
 
3869
                        '{foo}{bar}')
 
3870
 
 
3871
    def test_newline_in_refs_are_not_matched(self):
 
3872
        self.assertRefs([(False, '{\nxx}{xx\n}{{\n}}')], '{\nxx}{xx\n}{{\n}}')
 
3873
 
 
3874
 
 
3875
class TestStackExpandOptions(tests.TestCaseWithTransport):
 
3876
 
 
3877
    def setUp(self):
 
3878
        super(TestStackExpandOptions, self).setUp()
 
3879
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3880
        self.registry = config.option_registry
 
3881
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3882
        self.conf = config.Stack([store.get_sections], store)
 
3883
 
 
3884
    def assertExpansion(self, expected, string, env=None):
 
3885
        self.assertEquals(expected, self.conf.expand_options(string, env))
 
3886
 
 
3887
    def test_no_expansion(self):
 
3888
        self.assertExpansion('foo', 'foo')
 
3889
 
 
3890
    def test_expand_default_value(self):
 
3891
        self.conf.store._load_from_string('bar=baz')
 
3892
        self.registry.register(config.Option('foo', default=u'{bar}'))
 
3893
        self.assertEquals('baz', self.conf.get('foo', expand=True))
 
3894
 
 
3895
    def test_expand_default_from_env(self):
 
3896
        self.conf.store._load_from_string('bar=baz')
 
3897
        self.registry.register(config.Option('foo', default_from_env=['FOO']))
 
3898
        self.overrideEnv('FOO', '{bar}')
 
3899
        self.assertEquals('baz', self.conf.get('foo', expand=True))
 
3900
 
 
3901
    def test_expand_default_on_failed_conversion(self):
 
3902
        self.conf.store._load_from_string('baz=bogus\nbar=42\nfoo={baz}')
 
3903
        self.registry.register(
 
3904
            config.Option('foo', default=u'{bar}',
 
3905
                          from_unicode=config.int_from_store))
 
3906
        self.assertEquals(42, self.conf.get('foo', expand=True))
 
3907
 
 
3908
    def test_env_adding_options(self):
 
3909
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
 
3910
 
 
3911
    def test_env_overriding_options(self):
 
3912
        self.conf.store._load_from_string('foo=baz')
 
3913
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
 
3914
 
 
3915
    def test_simple_ref(self):
 
3916
        self.conf.store._load_from_string('foo=xxx')
 
3917
        self.assertExpansion('xxx', '{foo}')
 
3918
 
 
3919
    def test_unknown_ref(self):
 
3920
        self.assertRaises(errors.ExpandingUnknownOption,
 
3921
                          self.conf.expand_options, '{foo}')
 
3922
 
 
3923
    def test_indirect_ref(self):
 
3924
        self.conf.store._load_from_string('''
 
3925
foo=xxx
 
3926
bar={foo}
 
3927
''')
 
3928
        self.assertExpansion('xxx', '{bar}')
 
3929
 
 
3930
    def test_embedded_ref(self):
 
3931
        self.conf.store._load_from_string('''
 
3932
foo=xxx
 
3933
bar=foo
 
3934
''')
 
3935
        self.assertExpansion('xxx', '{{bar}}')
 
3936
 
 
3937
    def test_simple_loop(self):
 
3938
        self.conf.store._load_from_string('foo={foo}')
 
3939
        self.assertRaises(errors.OptionExpansionLoop,
 
3940
                          self.conf.expand_options, '{foo}')
 
3941
 
 
3942
    def test_indirect_loop(self):
 
3943
        self.conf.store._load_from_string('''
 
3944
foo={bar}
 
3945
bar={baz}
 
3946
baz={foo}''')
 
3947
        e = self.assertRaises(errors.OptionExpansionLoop,
 
3948
                              self.conf.expand_options, '{foo}')
 
3949
        self.assertEquals('foo->bar->baz', e.refs)
 
3950
        self.assertEquals('{foo}', e.string)
 
3951
 
 
3952
    def test_list(self):
 
3953
        self.conf.store._load_from_string('''
 
3954
foo=start
 
3955
bar=middle
 
3956
baz=end
 
3957
list={foo},{bar},{baz}
 
3958
''')
 
3959
        self.registry.register(
 
3960
            config.ListOption('list'))
 
3961
        self.assertEquals(['start', 'middle', 'end'],
 
3962
                           self.conf.get('list', expand=True))
 
3963
 
 
3964
    def test_cascading_list(self):
 
3965
        self.conf.store._load_from_string('''
 
3966
foo=start,{bar}
 
3967
bar=middle,{baz}
 
3968
baz=end
 
3969
list={foo}
 
3970
''')
 
3971
        self.registry.register(config.ListOption('list'))
 
3972
        # Register an intermediate option as a list to ensure no conversion
 
3973
        # happen while expanding. Conversion should only occur for the original
 
3974
        # option ('list' here).
 
3975
        self.registry.register(config.ListOption('baz'))
 
3976
        self.assertEquals(['start', 'middle', 'end'],
 
3977
                           self.conf.get('list', expand=True))
 
3978
 
 
3979
    def test_pathologically_hidden_list(self):
 
3980
        self.conf.store._load_from_string('''
 
3981
foo=bin
 
3982
bar=go
 
3983
start={foo
 
3984
middle=},{
 
3985
end=bar}
 
3986
hidden={start}{middle}{end}
 
3987
''')
 
3988
        # What matters is what the registration says, the conversion happens
 
3989
        # only after all expansions have been performed
 
3990
        self.registry.register(config.ListOption('hidden'))
 
3991
        self.assertEquals(['bin', 'go'],
 
3992
                          self.conf.get('hidden', expand=True))
 
3993
 
 
3994
 
 
3995
class TestStackCrossSectionsExpand(tests.TestCaseWithTransport):
 
3996
 
 
3997
    def setUp(self):
 
3998
        super(TestStackCrossSectionsExpand, self).setUp()
 
3999
 
 
4000
    def get_config(self, location, string):
 
4001
        if string is None:
 
4002
            string = ''
 
4003
        # Since we don't save the config we won't strictly require to inherit
 
4004
        # from TestCaseInTempDir, but an error occurs so quickly...
 
4005
        c = config.LocationStack(location)
 
4006
        c.store._load_from_string(string)
 
4007
        return c
 
4008
 
 
4009
    def test_dont_cross_unrelated_section(self):
 
4010
        c = self.get_config('/another/branch/path','''
 
4011
[/one/branch/path]
 
4012
foo = hello
 
4013
bar = {foo}/2
 
4014
 
 
4015
[/another/branch/path]
 
4016
bar = {foo}/2
 
4017
''')
 
4018
        self.assertRaises(errors.ExpandingUnknownOption,
 
4019
                          c.get, 'bar', expand=True)
 
4020
 
 
4021
    def test_cross_related_sections(self):
 
4022
        c = self.get_config('/project/branch/path','''
 
4023
[/project]
 
4024
foo = qu
 
4025
 
 
4026
[/project/branch/path]
 
4027
bar = {foo}ux
 
4028
''')
 
4029
        self.assertEquals('quux', c.get('bar', expand=True))
 
4030
 
 
4031
 
 
4032
class TestStackCrossStoresExpand(tests.TestCaseWithTransport):
 
4033
 
 
4034
    def test_cross_global_locations(self):
 
4035
        l_store = config.LocationStore()
 
4036
        l_store._load_from_string('''
 
4037
[/branch]
 
4038
lfoo = loc-foo
 
4039
lbar = {gbar}
 
4040
''')
 
4041
        l_store.save()
 
4042
        g_store = config.GlobalStore()
 
4043
        g_store._load_from_string('''
 
4044
[DEFAULT]
 
4045
gfoo = {lfoo}
 
4046
gbar = glob-bar
 
4047
''')
 
4048
        g_store.save()
 
4049
        stack = config.LocationStack('/branch')
 
4050
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
 
4051
        self.assertEquals('loc-foo', stack.get('gfoo', expand=True))
 
4052
 
 
4053
 
 
4054
class TestStackExpandSectionLocals(tests.TestCaseWithTransport):
 
4055
 
 
4056
    def test_expand_locals_empty(self):
 
4057
        l_store = config.LocationStore()
 
4058
        l_store._load_from_string('''
 
4059
[/home/user/project]
 
4060
base = {basename}
 
4061
rel = {relpath}
 
4062
''')
 
4063
        l_store.save()
 
4064
        stack = config.LocationStack('/home/user/project/')
 
4065
        self.assertEquals('', stack.get('base', expand=True))
 
4066
        self.assertEquals('', stack.get('rel', expand=True))
 
4067
 
 
4068
    def test_expand_basename_locally(self):
 
4069
        l_store = config.LocationStore()
 
4070
        l_store._load_from_string('''
 
4071
[/home/user/project]
 
4072
bfoo = {basename}
 
4073
''')
 
4074
        l_store.save()
 
4075
        stack = config.LocationStack('/home/user/project/branch')
 
4076
        self.assertEquals('branch', stack.get('bfoo', expand=True))
 
4077
 
 
4078
    def test_expand_basename_locally_longer_path(self):
 
4079
        l_store = config.LocationStore()
 
4080
        l_store._load_from_string('''
 
4081
[/home/user]
 
4082
bfoo = {basename}
 
4083
''')
 
4084
        l_store.save()
 
4085
        stack = config.LocationStack('/home/user/project/dir/branch')
 
4086
        self.assertEquals('branch', stack.get('bfoo', expand=True))
 
4087
 
 
4088
    def test_expand_relpath_locally(self):
 
4089
        l_store = config.LocationStore()
 
4090
        l_store._load_from_string('''
 
4091
[/home/user/project]
 
4092
lfoo = loc-foo/{relpath}
 
4093
''')
 
4094
        l_store.save()
 
4095
        stack = config.LocationStack('/home/user/project/branch')
 
4096
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
 
4097
 
 
4098
    def test_expand_relpath_unknonw_in_global(self):
 
4099
        g_store = config.GlobalStore()
 
4100
        g_store._load_from_string('''
 
4101
[DEFAULT]
 
4102
gfoo = {relpath}
 
4103
''')
 
4104
        g_store.save()
 
4105
        stack = config.LocationStack('/home/user/project/branch')
 
4106
        self.assertRaises(errors.ExpandingUnknownOption,
 
4107
                          stack.get, 'gfoo', expand=True)
 
4108
 
 
4109
    def test_expand_local_option_locally(self):
 
4110
        l_store = config.LocationStore()
 
4111
        l_store._load_from_string('''
 
4112
[/home/user/project]
 
4113
lfoo = loc-foo/{relpath}
 
4114
lbar = {gbar}
 
4115
''')
 
4116
        l_store.save()
 
4117
        g_store = config.GlobalStore()
 
4118
        g_store._load_from_string('''
 
4119
[DEFAULT]
 
4120
gfoo = {lfoo}
 
4121
gbar = glob-bar
 
4122
''')
 
4123
        g_store.save()
 
4124
        stack = config.LocationStack('/home/user/project/branch')
 
4125
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
 
4126
        self.assertEquals('loc-foo/branch', stack.get('gfoo', expand=True))
 
4127
 
 
4128
    def test_locals_dont_leak(self):
 
4129
        """Make sure we chose the right local in presence of several sections.
 
4130
        """
 
4131
        l_store = config.LocationStore()
 
4132
        l_store._load_from_string('''
 
4133
[/home/user]
 
4134
lfoo = loc-foo/{relpath}
 
4135
[/home/user/project]
 
4136
lfoo = loc-foo/{relpath}
 
4137
''')
 
4138
        l_store.save()
 
4139
        stack = config.LocationStack('/home/user/project/branch')
 
4140
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
 
4141
        stack = config.LocationStack('/home/user/bar/baz')
 
4142
        self.assertEquals('loc-foo/bar/baz', stack.get('lfoo', expand=True))
 
4143
 
 
4144
 
 
4145
 
 
4146
class TestStackSet(TestStackWithTransport):
 
4147
 
 
4148
    def test_simple_set(self):
 
4149
        conf = self.get_stack(self)
 
4150
        self.assertEquals(None, conf.get('foo'))
 
4151
        conf.set('foo', 'baz')
 
4152
        # Did we get it back ?
 
4153
        self.assertEquals('baz', conf.get('foo'))
 
4154
 
 
4155
    def test_set_creates_a_new_section(self):
 
4156
        conf = self.get_stack(self)
 
4157
        conf.set('foo', 'baz')
 
4158
        self.assertEquals, 'baz', conf.get('foo')
 
4159
 
 
4160
    def test_set_hook(self):
 
4161
        calls = []
 
4162
        def hook(*args):
 
4163
            calls.append(args)
 
4164
        config.ConfigHooks.install_named_hook('set', hook, None)
 
4165
        self.assertLength(0, calls)
 
4166
        conf = self.get_stack(self)
 
4167
        conf.set('foo', 'bar')
 
4168
        self.assertLength(1, calls)
 
4169
        self.assertEquals((conf, 'foo', 'bar'), calls[0])
 
4170
 
 
4171
 
 
4172
class TestStackRemove(TestStackWithTransport):
 
4173
 
 
4174
    def test_remove_existing(self):
 
4175
        conf = self.get_stack(self)
 
4176
        conf.set('foo', 'bar')
 
4177
        self.assertEquals('bar', conf.get('foo'))
 
4178
        conf.remove('foo')
 
4179
        # Did we get it back ?
 
4180
        self.assertEquals(None, conf.get('foo'))
 
4181
 
 
4182
    def test_remove_unknown(self):
 
4183
        conf = self.get_stack(self)
 
4184
        self.assertRaises(KeyError, conf.remove, 'I_do_not_exist')
 
4185
 
 
4186
    def test_remove_hook(self):
 
4187
        calls = []
 
4188
        def hook(*args):
 
4189
            calls.append(args)
 
4190
        config.ConfigHooks.install_named_hook('remove', hook, None)
 
4191
        self.assertLength(0, calls)
 
4192
        conf = self.get_stack(self)
 
4193
        conf.set('foo', 'bar')
 
4194
        conf.remove('foo')
 
4195
        self.assertLength(1, calls)
 
4196
        self.assertEquals((conf, 'foo'), calls[0])
 
4197
 
 
4198
 
 
4199
class TestConfigGetOptions(tests.TestCaseWithTransport, TestOptionsMixin):
 
4200
 
 
4201
    def setUp(self):
 
4202
        super(TestConfigGetOptions, self).setUp()
 
4203
        create_configs(self)
 
4204
 
 
4205
    def test_no_variable(self):
 
4206
        # Using branch should query branch, locations and bazaar
 
4207
        self.assertOptions([], self.branch_config)
 
4208
 
 
4209
    def test_option_in_bazaar(self):
 
4210
        self.bazaar_config.set_user_option('file', 'bazaar')
 
4211
        self.assertOptions([('file', 'bazaar', 'DEFAULT', 'bazaar')],
 
4212
                           self.bazaar_config)
 
4213
 
 
4214
    def test_option_in_locations(self):
 
4215
        self.locations_config.set_user_option('file', 'locations')
 
4216
        self.assertOptions(
 
4217
            [('file', 'locations', self.tree.basedir, 'locations')],
 
4218
            self.locations_config)
 
4219
 
 
4220
    def test_option_in_branch(self):
 
4221
        self.branch_config.set_user_option('file', 'branch')
 
4222
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch')],
 
4223
                           self.branch_config)
 
4224
 
 
4225
    def test_option_in_bazaar_and_branch(self):
 
4226
        self.bazaar_config.set_user_option('file', 'bazaar')
 
4227
        self.branch_config.set_user_option('file', 'branch')
 
4228
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch'),
 
4229
                            ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4230
                           self.branch_config)
 
4231
 
 
4232
    def test_option_in_branch_and_locations(self):
 
4233
        # Hmm, locations override branch :-/
 
4234
        self.locations_config.set_user_option('file', 'locations')
 
4235
        self.branch_config.set_user_option('file', 'branch')
 
4236
        self.assertOptions(
 
4237
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4238
             ('file', 'branch', 'DEFAULT', 'branch'),],
 
4239
            self.branch_config)
 
4240
 
 
4241
    def test_option_in_bazaar_locations_and_branch(self):
 
4242
        self.bazaar_config.set_user_option('file', 'bazaar')
 
4243
        self.locations_config.set_user_option('file', 'locations')
 
4244
        self.branch_config.set_user_option('file', 'branch')
 
4245
        self.assertOptions(
 
4246
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4247
             ('file', 'branch', 'DEFAULT', 'branch'),
 
4248
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4249
            self.branch_config)
 
4250
 
 
4251
 
 
4252
class TestConfigRemoveOption(tests.TestCaseWithTransport, TestOptionsMixin):
 
4253
 
 
4254
    def setUp(self):
 
4255
        super(TestConfigRemoveOption, self).setUp()
 
4256
        create_configs_with_file_option(self)
 
4257
 
 
4258
    def test_remove_in_locations(self):
 
4259
        self.locations_config.remove_user_option('file', self.tree.basedir)
 
4260
        self.assertOptions(
 
4261
            [('file', 'branch', 'DEFAULT', 'branch'),
 
4262
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4263
            self.branch_config)
 
4264
 
 
4265
    def test_remove_in_branch(self):
 
4266
        self.branch_config.remove_user_option('file')
 
4267
        self.assertOptions(
 
4268
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4269
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4270
            self.branch_config)
 
4271
 
 
4272
    def test_remove_in_bazaar(self):
 
4273
        self.bazaar_config.remove_user_option('file')
 
4274
        self.assertOptions(
 
4275
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4276
             ('file', 'branch', 'DEFAULT', 'branch'),],
 
4277
            self.branch_config)
 
4278
 
 
4279
 
 
4280
class TestConfigGetSections(tests.TestCaseWithTransport):
 
4281
 
 
4282
    def setUp(self):
 
4283
        super(TestConfigGetSections, self).setUp()
 
4284
        create_configs(self)
 
4285
 
 
4286
    def assertSectionNames(self, expected, conf, name=None):
 
4287
        """Check which sections are returned for a given config.
 
4288
 
 
4289
        If fallback configurations exist their sections can be included.
 
4290
 
 
4291
        :param expected: A list of section names.
 
4292
 
 
4293
        :param conf: The configuration that will be queried.
 
4294
 
 
4295
        :param name: An optional section name that will be passed to
 
4296
            get_sections().
 
4297
        """
 
4298
        sections = list(conf._get_sections(name))
 
4299
        self.assertLength(len(expected), sections)
 
4300
        self.assertEqual(expected, [name for name, _, _ in sections])
 
4301
 
 
4302
    def test_bazaar_default_section(self):
 
4303
        self.assertSectionNames(['DEFAULT'], self.bazaar_config)
 
4304
 
 
4305
    def test_locations_default_section(self):
 
4306
        # No sections are defined in an empty file
 
4307
        self.assertSectionNames([], self.locations_config)
 
4308
 
 
4309
    def test_locations_named_section(self):
 
4310
        self.locations_config.set_user_option('file', 'locations')
 
4311
        self.assertSectionNames([self.tree.basedir], self.locations_config)
 
4312
 
 
4313
    def test_locations_matching_sections(self):
 
4314
        loc_config = self.locations_config
 
4315
        loc_config.set_user_option('file', 'locations')
 
4316
        # We need to cheat a bit here to create an option in sections above and
 
4317
        # below the 'location' one.
 
4318
        parser = loc_config._get_parser()
 
4319
        # locations.cong deals with '/' ignoring native os.sep
 
4320
        location_names = self.tree.basedir.split('/')
 
4321
        parent = '/'.join(location_names[:-1])
 
4322
        child = '/'.join(location_names + ['child'])
 
4323
        parser[parent] = {}
 
4324
        parser[parent]['file'] = 'parent'
 
4325
        parser[child] = {}
 
4326
        parser[child]['file'] = 'child'
 
4327
        self.assertSectionNames([self.tree.basedir, parent], loc_config)
 
4328
 
 
4329
    def test_branch_data_default_section(self):
 
4330
        self.assertSectionNames([None],
 
4331
                                self.branch_config._get_branch_data_config())
 
4332
 
 
4333
    def test_branch_default_sections(self):
 
4334
        # No sections are defined in an empty locations file
 
4335
        self.assertSectionNames([None, 'DEFAULT'],
 
4336
                                self.branch_config)
 
4337
        # Unless we define an option
 
4338
        self.branch_config._get_location_config().set_user_option(
 
4339
            'file', 'locations')
 
4340
        self.assertSectionNames([self.tree.basedir, None, 'DEFAULT'],
 
4341
                                self.branch_config)
 
4342
 
 
4343
    def test_bazaar_named_section(self):
 
4344
        # We need to cheat as the API doesn't give direct access to sections
 
4345
        # other than DEFAULT.
 
4346
        self.bazaar_config.set_alias('bazaar', 'bzr')
 
4347
        self.assertSectionNames(['ALIASES'], self.bazaar_config, 'ALIASES')
 
4348
 
 
4349
 
 
4350
class TestSharedStores(tests.TestCaseInTempDir):
 
4351
 
 
4352
    def test_bazaar_conf_shared(self):
 
4353
        g1 = config.GlobalStack()
 
4354
        g2 = config.GlobalStack()
 
4355
        # The two stacks share the same store
 
4356
        self.assertIs(g1.store, g2.store)
 
4357
 
 
4358
 
1474
4359
class TestAuthenticationConfigFile(tests.TestCase):
1475
4360
    """Test the authentication.conf file matching"""
1476
4361
 
1491
4376
        self.assertEquals({}, conf._get_config())
1492
4377
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
1493
4378
 
 
4379
    def test_non_utf8_config(self):
 
4380
        conf = config.AuthenticationConfig(_file=StringIO(
 
4381
                'foo = bar\xff'))
 
4382
        self.assertRaises(errors.ConfigContentError, conf._get_config)
 
4383
 
1494
4384
    def test_missing_auth_section_header(self):
1495
4385
        conf = config.AuthenticationConfig(_file=StringIO('foo = bar'))
1496
4386
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
1686
4576
                                           port=99, path='/foo',
1687
4577
                                           realm='realm')
1688
4578
        CREDENTIALS = {'name': 'name', 'user': 'user', 'password': 'password',
1689
 
                       'verify_certificates': False, 'scheme': 'scheme', 
1690
 
                       'host': 'host', 'port': 99, 'path': '/foo', 
 
4579
                       'verify_certificates': False, 'scheme': 'scheme',
 
4580
                       'host': 'host', 'port': 99, 'path': '/foo',
1691
4581
                       'realm': 'realm'}
1692
4582
        self.assertEqual(CREDENTIALS, credentials)
1693
4583
        credentials_from_disk = config.AuthenticationConfig().get_credentials(
1701
4591
        self.assertIs(None, conf._get_config().get('name'))
1702
4592
        credentials = conf.get_credentials(host='host', scheme='scheme')
1703
4593
        CREDENTIALS = {'name': 'name2', 'user': 'user2', 'password':
1704
 
                       'password', 'verify_certificates': True, 
1705
 
                       'scheme': 'scheme', 'host': 'host', 'port': None, 
 
4594
                       'password', 'verify_certificates': True,
 
4595
                       'scheme': 'scheme', 'host': 'host', 'port': None,
1706
4596
                       'path': None, 'realm': None}
1707
4597
        self.assertEqual(CREDENTIALS, credentials)
1708
4598
 
1754
4644
 
1755
4645
    def test_username_defaults_prompts(self):
1756
4646
        # HTTP prompts can't be tested here, see test_http.py
1757
 
        self._check_default_username_prompt('FTP %(host)s username: ', 'ftp')
1758
 
        self._check_default_username_prompt(
1759
 
            'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
1760
 
        self._check_default_username_prompt(
1761
 
            'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
 
4647
        self._check_default_username_prompt(u'FTP %(host)s username: ', 'ftp')
 
4648
        self._check_default_username_prompt(
 
4649
            u'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
 
4650
        self._check_default_username_prompt(
 
4651
            u'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
1762
4652
 
1763
4653
    def test_username_default_no_prompt(self):
1764
4654
        conf = config.AuthenticationConfig()
1770
4660
    def test_password_default_prompts(self):
1771
4661
        # HTTP prompts can't be tested here, see test_http.py
1772
4662
        self._check_default_password_prompt(
1773
 
            'FTP %(user)s@%(host)s password: ', 'ftp')
1774
 
        self._check_default_password_prompt(
1775
 
            'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
1776
 
        self._check_default_password_prompt(
1777
 
            'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
 
4663
            u'FTP %(user)s@%(host)s password: ', 'ftp')
 
4664
        self._check_default_password_prompt(
 
4665
            u'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
 
4666
        self._check_default_password_prompt(
 
4667
            u'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
1778
4668
        # SMTP port handling is a bit special (it's handled if embedded in the
1779
4669
        # host too)
1780
4670
        # FIXME: should we: forbid that, extend it to other schemes, leave
1781
4671
        # things as they are that's fine thank you ?
1782
 
        self._check_default_password_prompt('SMTP %(user)s@%(host)s password: ',
1783
 
                                            'smtp')
1784
 
        self._check_default_password_prompt('SMTP %(user)s@%(host)s password: ',
1785
 
                                            'smtp', host='bar.org:10025')
1786
 
        self._check_default_password_prompt(
1787
 
            'SMTP %(user)s@%(host)s:%(port)d password: ',
1788
 
            'smtp', port=10025)
 
4672
        self._check_default_password_prompt(
 
4673
            u'SMTP %(user)s@%(host)s password: ', 'smtp')
 
4674
        self._check_default_password_prompt(
 
4675
            u'SMTP %(user)s@%(host)s password: ', 'smtp', host='bar.org:10025')
 
4676
        self._check_default_password_prompt(
 
4677
            u'SMTP %(user)s@%(host)s:%(port)d password: ', 'smtp', port=10025)
1789
4678
 
1790
4679
    def test_ssh_password_emits_warning(self):
1791
4680
        conf = config.AuthenticationConfig(_file=StringIO(
1961
4850
        self.assertEquals('secret', decoded)
1962
4851
 
1963
4852
 
 
4853
class TestBase64CredentialStore(tests.TestCase):
 
4854
 
 
4855
    def test_decode_password(self):
 
4856
        r = config.credential_store_registry
 
4857
        plain_text = r.get_credential_store('base64')
 
4858
        decoded = plain_text.decode_password(dict(password='c2VjcmV0'))
 
4859
        self.assertEquals('secret', decoded)
 
4860
 
 
4861
 
1964
4862
# FIXME: Once we have a way to declare authentication to all test servers, we
1965
4863
# can implement generic tests.
1966
4864
# test_user_password_in_url
1971
4869
# test_user_prompted ?
1972
4870
class TestAuthenticationRing(tests.TestCaseWithTransport):
1973
4871
    pass
 
4872
 
 
4873
 
 
4874
class TestAutoUserId(tests.TestCase):
 
4875
    """Test inferring an automatic user name."""
 
4876
 
 
4877
    def test_auto_user_id(self):
 
4878
        """Automatic inference of user name.
 
4879
 
 
4880
        This is a bit hard to test in an isolated way, because it depends on
 
4881
        system functions that go direct to /etc or perhaps somewhere else.
 
4882
        But it's reasonable to say that on Unix, with an /etc/mailname, we ought
 
4883
        to be able to choose a user name with no configuration.
 
4884
        """
 
4885
        if sys.platform == 'win32':
 
4886
            raise tests.TestSkipped(
 
4887
                "User name inference not implemented on win32")
 
4888
        realname, address = config._auto_user_id()
 
4889
        if os.path.exists('/etc/mailname'):
 
4890
            self.assertIsNot(None, realname)
 
4891
            self.assertIsNot(None, address)
 
4892
        else:
 
4893
            self.assertEquals((None, None), (realname, address))
 
4894
 
 
4895
 
 
4896
class TestDefaultMailDomain(tests.TestCaseInTempDir):
 
4897
    """Test retrieving default domain from mailname file"""
 
4898
 
 
4899
    def test_default_mail_domain_simple(self):
 
4900
        f = file('simple', 'w')
 
4901
        try:
 
4902
            f.write("domainname.com\n")
 
4903
        finally:
 
4904
            f.close()
 
4905
        r = config._get_default_mail_domain('simple')
 
4906
        self.assertEquals('domainname.com', r)
 
4907
 
 
4908
    def test_default_mail_domain_no_eol(self):
 
4909
        f = file('no_eol', 'w')
 
4910
        try:
 
4911
            f.write("domainname.com")
 
4912
        finally:
 
4913
            f.close()
 
4914
        r = config._get_default_mail_domain('no_eol')
 
4915
        self.assertEquals('domainname.com', r)
 
4916
 
 
4917
    def test_default_mail_domain_multiple_lines(self):
 
4918
        f = file('multiple_lines', 'w')
 
4919
        try:
 
4920
            f.write("domainname.com\nsome other text\n")
 
4921
        finally:
 
4922
            f.close()
 
4923
        r = config._get_default_mail_domain('multiple_lines')
 
4924
        self.assertEquals('domainname.com', r)
 
4925
 
 
4926
 
 
4927
class EmailOptionTests(tests.TestCase):
 
4928
 
 
4929
    def test_default_email_uses_BZR_EMAIL(self):
 
4930
        conf = config.MemoryStack('email=jelmer@debian.org')
 
4931
        # BZR_EMAIL takes precedence over EMAIL
 
4932
        self.overrideEnv('BZR_EMAIL', 'jelmer@samba.org')
 
4933
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
 
4934
        self.assertEquals('jelmer@samba.org', conf.get('email'))
 
4935
 
 
4936
    def test_default_email_uses_EMAIL(self):
 
4937
        conf = config.MemoryStack('')
 
4938
        self.overrideEnv('BZR_EMAIL', None)
 
4939
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
 
4940
        self.assertEquals('jelmer@apache.org', conf.get('email'))
 
4941
 
 
4942
    def test_BZR_EMAIL_overrides(self):
 
4943
        conf = config.MemoryStack('email=jelmer@debian.org')
 
4944
        self.overrideEnv('BZR_EMAIL', 'jelmer@apache.org')
 
4945
        self.assertEquals('jelmer@apache.org', conf.get('email'))
 
4946
        self.overrideEnv('BZR_EMAIL', None)
 
4947
        self.overrideEnv('EMAIL', 'jelmer@samba.org')
 
4948
        self.assertEquals('jelmer@debian.org', conf.get('email'))
 
4949
 
 
4950
 
 
4951
class MailClientOptionTests(tests.TestCase):
 
4952
 
 
4953
    def test_default(self):
 
4954
        conf = config.MemoryStack('')
 
4955
        client = conf.get('mail_client')
 
4956
        self.assertIs(client, mail_client.DefaultMail)
 
4957
 
 
4958
    def test_evolution(self):
 
4959
        conf = config.MemoryStack('mail_client=evolution')
 
4960
        client = conf.get('mail_client')
 
4961
        self.assertIs(client, mail_client.Evolution)
 
4962
 
 
4963
    def test_kmail(self):
 
4964
        conf = config.MemoryStack('mail_client=kmail')
 
4965
        client = conf.get('mail_client')
 
4966
        self.assertIs(client, mail_client.KMail)
 
4967
 
 
4968
    def test_mutt(self):
 
4969
        conf = config.MemoryStack('mail_client=mutt')
 
4970
        client = conf.get('mail_client')
 
4971
        self.assertIs(client, mail_client.Mutt)
 
4972
 
 
4973
    def test_thunderbird(self):
 
4974
        conf = config.MemoryStack('mail_client=thunderbird')
 
4975
        client = conf.get('mail_client')
 
4976
        self.assertIs(client, mail_client.Thunderbird)
 
4977
 
 
4978
    def test_explicit_default(self):
 
4979
        conf = config.MemoryStack('mail_client=default')
 
4980
        client = conf.get('mail_client')
 
4981
        self.assertIs(client, mail_client.DefaultMail)
 
4982
 
 
4983
    def test_editor(self):
 
4984
        conf = config.MemoryStack('mail_client=editor')
 
4985
        client = conf.get('mail_client')
 
4986
        self.assertIs(client, mail_client.Editor)
 
4987
 
 
4988
    def test_mapi(self):
 
4989
        conf = config.MemoryStack('mail_client=mapi')
 
4990
        client = conf.get('mail_client')
 
4991
        self.assertIs(client, mail_client.MAPIClient)
 
4992
 
 
4993
    def test_xdg_email(self):
 
4994
        conf = config.MemoryStack('mail_client=xdg-email')
 
4995
        client = conf.get('mail_client')
 
4996
        self.assertIs(client, mail_client.XDGEmail)
 
4997
 
 
4998
    def test_unknown(self):
 
4999
        conf = config.MemoryStack('mail_client=firebird')
 
5000
        self.assertRaises(errors.ConfigOptionValueError, conf.get,
 
5001
                'mail_client')