~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_bzrdir.py

  • Committer: Jelmer Vernooij
  • Date: 2011-12-30 12:52:54 UTC
  • mto: This revision was merged to the branch mainline in revision 6418.
  • Revision ID: jelmer@samba.org-20111230125254-igy1abnixsvulfqd
Simplify code a bit.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005, 2006, 2007 Canonical Ltd
 
1
# Copyright (C) 2006-2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
24
24
import sys
25
25
 
26
26
from bzrlib import (
 
27
    branch,
27
28
    bzrdir,
 
29
    config,
 
30
    controldir,
28
31
    errors,
29
32
    help_topics,
 
33
    lock,
30
34
    repository,
 
35
    revision as _mod_revision,
31
36
    osutils,
32
37
    remote,
 
38
    symbol_versioning,
 
39
    transport as _mod_transport,
33
40
    urlutils,
34
41
    win32utils,
35
 
    workingtree,
 
42
    workingtree_3,
 
43
    workingtree_4,
36
44
    )
37
45
import bzrlib.branch
38
 
from bzrlib.errors import (NotBranchError,
39
 
                           UnknownFormatError,
40
 
                           UnsupportedFormatError,
41
 
                           )
 
46
from bzrlib.errors import (
 
47
    NotBranchError,
 
48
    NoColocatedBranchSupport,
 
49
    UnknownFormatError,
 
50
    UnsupportedFormatError,
 
51
    )
42
52
from bzrlib.tests import (
43
53
    TestCase,
44
54
    TestCaseWithMemoryTransport,
51
61
    )
52
62
from bzrlib.tests.test_http import TestWithTransport_pycurl
53
63
from bzrlib.transport import (
54
 
    get_transport,
55
64
    memory,
 
65
    pathfilter,
56
66
    )
57
67
from bzrlib.transport.http._urllib import HttpTransport_urllib
58
68
from bzrlib.transport.nosmart import NoSmartTransportDecorator
59
69
from bzrlib.transport.readonly import ReadonlyTransportDecorator
60
 
from bzrlib.repofmt import knitrepo, weaverepo, pack_repo
 
70
from bzrlib.repofmt import knitrepo, knitpack_repo
61
71
 
62
72
 
63
73
class TestDefaultFormat(TestCase):
64
74
 
65
75
    def test_get_set_default_format(self):
66
76
        old_format = bzrdir.BzrDirFormat.get_default_format()
67
 
        # default is BzrDirFormat6
68
 
        self.failUnless(isinstance(old_format, bzrdir.BzrDirMetaFormat1))
69
 
        bzrdir.BzrDirFormat._set_default_format(SampleBzrDirFormat())
 
77
        # default is BzrDirMetaFormat1
 
78
        self.assertIsInstance(old_format, bzrdir.BzrDirMetaFormat1)
 
79
        controldir.ControlDirFormat._set_default_format(SampleBzrDirFormat())
70
80
        # creating a bzr dir should now create an instrumented dir.
71
81
        try:
72
82
            result = bzrdir.BzrDir.create('memory:///')
73
 
            self.failUnless(isinstance(result, SampleBzrDir))
 
83
            self.assertIsInstance(result, SampleBzrDir)
74
84
        finally:
75
 
            bzrdir.BzrDirFormat._set_default_format(old_format)
 
85
            controldir.ControlDirFormat._set_default_format(old_format)
76
86
        self.assertEqual(old_format, bzrdir.BzrDirFormat.get_default_format())
77
87
 
78
88
 
 
89
class DeprecatedBzrDirFormat(bzrdir.BzrDirFormat):
 
90
    """A deprecated bzr dir format."""
 
91
 
 
92
 
79
93
class TestFormatRegistry(TestCase):
80
94
 
81
95
    def make_format_registry(self):
82
 
        my_format_registry = bzrdir.BzrDirFormatRegistry()
83
 
        my_format_registry.register('weave', bzrdir.BzrDirFormat6,
84
 
            'Pre-0.8 format.  Slower and does not support checkouts or shared'
85
 
            ' repositories', deprecated=True)
86
 
        my_format_registry.register_lazy('lazy', 'bzrlib.bzrdir',
87
 
            'BzrDirFormat6', 'Format registered lazily', deprecated=True)
88
 
        my_format_registry.register_metadir('knit',
 
96
        my_format_registry = controldir.ControlDirFormatRegistry()
 
97
        my_format_registry.register('deprecated', DeprecatedBzrDirFormat,
 
98
            'Some format.  Slower and unawesome and deprecated.',
 
99
            deprecated=True)
 
100
        my_format_registry.register_lazy('lazy', 'bzrlib.tests.test_bzrdir',
 
101
            'DeprecatedBzrDirFormat', 'Format registered lazily',
 
102
            deprecated=True)
 
103
        bzrdir.register_metadir(my_format_registry, 'knit',
89
104
            'bzrlib.repofmt.knitrepo.RepositoryFormatKnit1',
90
105
            'Format using knits',
91
106
            )
92
107
        my_format_registry.set_default('knit')
93
 
        my_format_registry.register_metadir(
 
108
        bzrdir.register_metadir(my_format_registry,
94
109
            'branch6',
95
110
            'bzrlib.repofmt.knitrepo.RepositoryFormatKnit3',
96
111
            'Experimental successor to knit.  Use at your own risk.',
97
112
            branch_format='bzrlib.branch.BzrBranchFormat6',
98
113
            experimental=True)
99
 
        my_format_registry.register_metadir(
 
114
        bzrdir.register_metadir(my_format_registry,
100
115
            'hidden format',
101
116
            'bzrlib.repofmt.knitrepo.RepositoryFormatKnit3',
102
117
            'Experimental successor to knit.  Use at your own risk.',
103
118
            branch_format='bzrlib.branch.BzrBranchFormat6', hidden=True)
104
 
        my_format_registry.register('hiddenweave', bzrdir.BzrDirFormat6,
105
 
            'Pre-0.8 format.  Slower and does not support checkouts or shared'
106
 
            ' repositories', hidden=True)
107
 
        my_format_registry.register_lazy('hiddenlazy', 'bzrlib.bzrdir',
108
 
            'BzrDirFormat6', 'Format registered lazily', deprecated=True,
109
 
            hidden=True)
 
119
        my_format_registry.register('hiddendeprecated', DeprecatedBzrDirFormat,
 
120
            'Old format.  Slower and does not support things. ', hidden=True)
 
121
        my_format_registry.register_lazy('hiddenlazy', 'bzrlib.tests.test_bzrdir',
 
122
            'DeprecatedBzrDirFormat', 'Format registered lazily',
 
123
            deprecated=True, hidden=True)
110
124
        return my_format_registry
111
125
 
112
126
    def test_format_registry(self):
113
127
        my_format_registry = self.make_format_registry()
114
128
        my_bzrdir = my_format_registry.make_bzrdir('lazy')
115
 
        self.assertIsInstance(my_bzrdir, bzrdir.BzrDirFormat6)
116
 
        my_bzrdir = my_format_registry.make_bzrdir('weave')
117
 
        self.assertIsInstance(my_bzrdir, bzrdir.BzrDirFormat6)
 
129
        self.assertIsInstance(my_bzrdir, DeprecatedBzrDirFormat)
 
130
        my_bzrdir = my_format_registry.make_bzrdir('deprecated')
 
131
        self.assertIsInstance(my_bzrdir, DeprecatedBzrDirFormat)
118
132
        my_bzrdir = my_format_registry.make_bzrdir('default')
119
133
        self.assertIsInstance(my_bzrdir.repository_format,
120
134
            knitrepo.RepositoryFormatKnit1)
133
147
                         my_format_registry.get_help('knit'))
134
148
        self.assertEqual('Format using knits',
135
149
                         my_format_registry.get_help('default'))
136
 
        self.assertEqual('Pre-0.8 format.  Slower and does not support'
137
 
                         ' checkouts or shared repositories',
138
 
                         my_format_registry.get_help('weave'))
 
150
        self.assertEqual('Some format.  Slower and unawesome and deprecated.',
 
151
                         my_format_registry.get_help('deprecated'))
139
152
 
140
153
    def test_help_topic(self):
141
154
        topics = help_topics.HelpTopicRegistry()
165
178
            self.assertIs(bzrdir.format_registry.get('dirstate-with-subtree'),
166
179
                          bzrdir.format_registry.get('default'))
167
180
            self.assertIs(
168
 
                repository.RepositoryFormat.get_default_format().__class__,
 
181
                repository.format_registry.get_default().__class__,
169
182
                knitrepo.RepositoryFormatKnit3)
170
183
        finally:
171
184
            bzrdir.format_registry.set_default_repository(old_default)
172
185
 
173
186
    def test_aliases(self):
174
 
        a_registry = bzrdir.BzrDirFormatRegistry()
175
 
        a_registry.register('weave', bzrdir.BzrDirFormat6,
176
 
            'Pre-0.8 format.  Slower and does not support checkouts or shared'
177
 
            ' repositories', deprecated=True)
178
 
        a_registry.register('weavealias', bzrdir.BzrDirFormat6,
179
 
            'Pre-0.8 format.  Slower and does not support checkouts or shared'
180
 
            ' repositories', deprecated=True, alias=True)
181
 
        self.assertEqual(frozenset(['weavealias']), a_registry.aliases())
 
187
        a_registry = controldir.ControlDirFormatRegistry()
 
188
        a_registry.register('deprecated', DeprecatedBzrDirFormat,
 
189
            'Old format.  Slower and does not support stuff',
 
190
            deprecated=True)
 
191
        a_registry.register('deprecatedalias', DeprecatedBzrDirFormat,
 
192
            'Old format.  Slower and does not support stuff',
 
193
            deprecated=True, alias=True)
 
194
        self.assertEqual(frozenset(['deprecatedalias']), a_registry.aliases())
182
195
 
183
196
 
184
197
class SampleBranch(bzrlib.branch.Branch):
206
219
        """See BzrDir.open_repository."""
207
220
        return SampleRepository(self)
208
221
 
209
 
    def create_branch(self):
 
222
    def create_branch(self, name=None):
210
223
        """See BzrDir.create_branch."""
 
224
        if name is not None:
 
225
            raise NoColocatedBranchSupport(self)
211
226
        return SampleBranch(self)
212
227
 
213
228
    def create_workingtree(self):
238
253
    def open(self, transport, _found=None):
239
254
        return "opened branch."
240
255
 
 
256
    @classmethod
 
257
    def from_string(cls, format_string):
 
258
        return cls()
 
259
 
 
260
 
 
261
class BzrDirFormatTest1(bzrdir.BzrDirMetaFormat1):
 
262
 
 
263
    @staticmethod
 
264
    def get_format_string():
 
265
        return "Test format 1"
 
266
 
 
267
 
 
268
class BzrDirFormatTest2(bzrdir.BzrDirMetaFormat1):
 
269
 
 
270
    @staticmethod
 
271
    def get_format_string():
 
272
        return "Test format 2"
 
273
 
241
274
 
242
275
class TestBzrDirFormat(TestCaseWithTransport):
243
276
    """Tests for the BzrDirFormat facility."""
245
278
    def test_find_format(self):
246
279
        # is the right format object found for a branch?
247
280
        # create a branch with a few known format objects.
248
 
        # this is not quite the same as
249
 
        t = get_transport(self.get_url())
 
281
        bzrdir.BzrProber.formats.register(BzrDirFormatTest1.get_format_string(),
 
282
            BzrDirFormatTest1())
 
283
        self.addCleanup(bzrdir.BzrProber.formats.remove,
 
284
            BzrDirFormatTest1.get_format_string())
 
285
        bzrdir.BzrProber.formats.register(BzrDirFormatTest2.get_format_string(),
 
286
            BzrDirFormatTest2())
 
287
        self.addCleanup(bzrdir.BzrProber.formats.remove,
 
288
            BzrDirFormatTest2.get_format_string())
 
289
        t = self.get_transport()
250
290
        self.build_tree(["foo/", "bar/"], transport=t)
251
291
        def check_format(format, url):
252
292
            format.initialize(url)
253
 
            t = get_transport(url)
 
293
            t = _mod_transport.get_transport_from_path(url)
254
294
            found_format = bzrdir.BzrDirFormat.find_format(t)
255
 
            self.failUnless(isinstance(found_format, format.__class__))
256
 
        check_format(bzrdir.BzrDirFormat5(), "foo")
257
 
        check_format(bzrdir.BzrDirFormat6(), "bar")
 
295
            self.assertIsInstance(found_format, format.__class__)
 
296
        check_format(BzrDirFormatTest1(), "foo")
 
297
        check_format(BzrDirFormatTest2(), "bar")
258
298
 
259
299
    def test_find_format_nothing_there(self):
260
300
        self.assertRaises(NotBranchError,
261
301
                          bzrdir.BzrDirFormat.find_format,
262
 
                          get_transport('.'))
 
302
                          _mod_transport.get_transport_from_path('.'))
263
303
 
264
304
    def test_find_format_unknown_format(self):
265
 
        t = get_transport(self.get_url())
 
305
        t = self.get_transport()
266
306
        t.mkdir('.bzr')
267
307
        t.put_bytes('.bzr/branch-format', '')
268
308
        self.assertRaises(UnknownFormatError,
269
309
                          bzrdir.BzrDirFormat.find_format,
270
 
                          get_transport('.'))
 
310
                          _mod_transport.get_transport_from_path('.'))
271
311
 
272
312
    def test_register_unregister_format(self):
273
313
        format = SampleBzrDirFormat()
275
315
        # make a bzrdir
276
316
        format.initialize(url)
277
317
        # register a format for it.
278
 
        bzrdir.BzrDirFormat.register_format(format)
 
318
        bzrdir.BzrProber.formats.register(format.get_format_string(), format)
279
319
        # which bzrdir.Open will refuse (not supported)
280
320
        self.assertRaises(UnsupportedFormatError, bzrdir.BzrDir.open, url)
281
321
        # which bzrdir.open_containing will refuse (not supported)
282
322
        self.assertRaises(UnsupportedFormatError, bzrdir.BzrDir.open_containing, url)
283
323
        # but open_downlevel will work
284
 
        t = get_transport(url)
 
324
        t = _mod_transport.get_transport_from_url(url)
285
325
        self.assertEqual(format.open(t), bzrdir.BzrDir.open_unsupported(url))
286
326
        # unregister the format
287
 
        bzrdir.BzrDirFormat.unregister_format(format)
 
327
        bzrdir.BzrProber.formats.remove(format.get_format_string())
288
328
        # now open_downlevel should fail too.
289
329
        self.assertRaises(UnknownFormatError, bzrdir.BzrDir.open_unsupported, url)
290
330
 
467
507
    def test_default_stacking_with_stackable_branch_unstackable_repo(self):
468
508
        # Make stackable source branch with an unstackable repo format.
469
509
        source_bzrdir = self.make_bzrdir('source')
470
 
        pack_repo.RepositoryFormatKnitPack1().initialize(source_bzrdir)
471
 
        source_branch = bzrlib.branch.BzrBranchFormat7().initialize(source_bzrdir)
 
510
        knitpack_repo.RepositoryFormatKnitPack1().initialize(source_bzrdir)
 
511
        source_branch = bzrlib.branch.BzrBranchFormat7().initialize(
 
512
            source_bzrdir)
472
513
        # Make a directory with a default stacking policy
473
514
        parent_bzrdir = self.make_bzrdir('parent')
474
515
        stacked_on = self.make_branch('parent/stacked-on', format='pack-0.92')
476
517
        # Clone source into directory
477
518
        target = source_bzrdir.clone(self.get_url('parent/target'))
478
519
 
 
520
    def test_format_initialize_on_transport_ex_stacked_on(self):
 
521
        # trunk is a stackable format.  Note that its in the same server area
 
522
        # which is what launchpad does, but not sufficient to exercise the
 
523
        # general case.
 
524
        trunk = self.make_branch('trunk', format='1.9')
 
525
        t = self.get_transport('stacked')
 
526
        old_fmt = bzrdir.format_registry.make_bzrdir('pack-0.92')
 
527
        repo_name = old_fmt.repository_format.network_name()
 
528
        # Should end up with a 1.9 format (stackable)
 
529
        repo, control, require_stacking, repo_policy = \
 
530
            old_fmt.initialize_on_transport_ex(t,
 
531
                    repo_format_name=repo_name, stacked_on='../trunk',
 
532
                    stack_on_pwd=t.base)
 
533
        if repo is not None:
 
534
            # Repositories are open write-locked
 
535
            self.assertTrue(repo.is_write_locked())
 
536
            self.addCleanup(repo.unlock)
 
537
        else:
 
538
            repo = control.open_repository()
 
539
        self.assertIsInstance(control, bzrdir.BzrDir)
 
540
        opened = bzrdir.BzrDir.open(t.base)
 
541
        if not isinstance(old_fmt, remote.RemoteBzrDirFormat):
 
542
            self.assertEqual(control._format.network_name(),
 
543
                old_fmt.network_name())
 
544
            self.assertEqual(control._format.network_name(),
 
545
                opened._format.network_name())
 
546
        self.assertEqual(control.__class__, opened.__class__)
 
547
        self.assertLength(1, repo._fallback_repositories)
 
548
 
479
549
    def test_sprout_obeys_stacking_policy(self):
480
550
        child_branch, new_child_transport = self.prepare_default_stacking()
481
551
        new_child = child_branch.bzrdir.sprout(new_child_transport.base)
672
742
        self.assertEqual(relpath, 'baz')
673
743
 
674
744
    def test_open_containing_from_transport(self):
675
 
        self.assertRaises(NotBranchError, bzrdir.BzrDir.open_containing_from_transport,
676
 
                          get_transport(self.get_readonly_url('')))
677
 
        self.assertRaises(NotBranchError, bzrdir.BzrDir.open_containing_from_transport,
678
 
                          get_transport(self.get_readonly_url('g/p/q')))
 
745
        self.assertRaises(NotBranchError,
 
746
            bzrdir.BzrDir.open_containing_from_transport,
 
747
            _mod_transport.get_transport_from_url(self.get_readonly_url('')))
 
748
        self.assertRaises(NotBranchError,
 
749
            bzrdir.BzrDir.open_containing_from_transport,
 
750
            _mod_transport.get_transport_from_url(
 
751
                self.get_readonly_url('g/p/q')))
679
752
        control = bzrdir.BzrDir.create(self.get_url())
680
753
        branch, relpath = bzrdir.BzrDir.open_containing_from_transport(
681
 
            get_transport(self.get_readonly_url('')))
 
754
            _mod_transport.get_transport_from_url(
 
755
                self.get_readonly_url('')))
682
756
        self.assertEqual('', relpath)
683
757
        branch, relpath = bzrdir.BzrDir.open_containing_from_transport(
684
 
            get_transport(self.get_readonly_url('g/p/q')))
 
758
            _mod_transport.get_transport_from_url(
 
759
                self.get_readonly_url('g/p/q')))
685
760
        self.assertEqual('g/p/q', relpath)
686
761
 
687
762
    def test_open_containing_tree_or_branch(self):
731
806
        # transport pointing at bzrdir should give a bzrdir with root transport
732
807
        # set to the given transport
733
808
        control = bzrdir.BzrDir.create(self.get_url())
734
 
        transport = get_transport(self.get_url())
735
 
        opened_bzrdir = bzrdir.BzrDir.open_from_transport(transport)
736
 
        self.assertEqual(transport.base, opened_bzrdir.root_transport.base)
 
809
        t = self.get_transport()
 
810
        opened_bzrdir = bzrdir.BzrDir.open_from_transport(t)
 
811
        self.assertEqual(t.base, opened_bzrdir.root_transport.base)
737
812
        self.assertIsInstance(opened_bzrdir, bzrdir.BzrDir)
738
813
 
739
814
    def test_open_from_transport_no_bzrdir(self):
740
 
        transport = get_transport(self.get_url())
741
 
        self.assertRaises(NotBranchError, bzrdir.BzrDir.open_from_transport,
742
 
                          transport)
 
815
        t = self.get_transport()
 
816
        self.assertRaises(NotBranchError, bzrdir.BzrDir.open_from_transport, t)
743
817
 
744
818
    def test_open_from_transport_bzrdir_in_parent(self):
745
819
        control = bzrdir.BzrDir.create(self.get_url())
746
 
        transport = get_transport(self.get_url())
747
 
        transport.mkdir('subdir')
748
 
        transport = transport.clone('subdir')
749
 
        self.assertRaises(NotBranchError, bzrdir.BzrDir.open_from_transport,
750
 
                          transport)
 
820
        t = self.get_transport()
 
821
        t.mkdir('subdir')
 
822
        t = t.clone('subdir')
 
823
        self.assertRaises(NotBranchError, bzrdir.BzrDir.open_from_transport, t)
751
824
 
752
825
    def test_sprout_recursive(self):
753
826
        tree = self.make_branch_and_tree('tree1',
762
835
        tree2 = tree.bzrdir.sprout('tree2').open_workingtree()
763
836
        tree2.lock_read()
764
837
        self.addCleanup(tree2.unlock)
765
 
        self.failUnlessExists('tree2/subtree/file')
 
838
        self.assertPathExists('tree2/subtree/file')
766
839
        self.assertEqual('tree-reference', tree2.kind('subtree-root'))
767
840
 
768
841
    def test_cloning_metadir(self):
772
845
        branch = self.make_branch('branch', format='knit')
773
846
        format = branch.bzrdir.cloning_metadir()
774
847
        self.assertIsInstance(format.workingtree_format,
775
 
            workingtree.WorkingTreeFormat3)
 
848
            workingtree_4.WorkingTreeFormat6)
776
849
 
777
850
    def test_sprout_recursive_treeless(self):
778
851
        tree = self.make_branch_and_tree('tree1',
783
856
        self.build_tree(['tree1/subtree/file'])
784
857
        sub_tree.add('file')
785
858
        tree.commit('Initial commit')
 
859
        # The following line force the orhaning to reveal bug #634470
 
860
        tree.branch.get_config().set_user_option(
 
861
            'bzr.transform.orphan_policy', 'move')
786
862
        tree.bzrdir.destroy_workingtree()
 
863
        # FIXME: subtree/.bzr is left here which allows the test to pass (or
 
864
        # fail :-( ) -- vila 20100909
787
865
        repo = self.make_repository('repo', shared=True,
788
866
            format='dirstate-with-subtree')
789
867
        repo.set_make_working_trees(False)
790
 
        tree.bzrdir.sprout('repo/tree2')
791
 
        self.failUnlessExists('repo/tree2/subtree')
792
 
        self.failIfExists('repo/tree2/subtree/file')
 
868
        # FIXME: we just deleted the workingtree and now we want to use it ????
 
869
        # At a minimum, we should use tree.branch below (but this fails too
 
870
        # currently) or stop calling this test 'treeless'. Specifically, I've
 
871
        # turn the line below into an assertRaises when 'subtree/.bzr' is
 
872
        # orphaned and sprout tries to access the branch there (which is left
 
873
        # by bzrdir.BzrDirMeta1.destroy_workingtree when it ignores the
 
874
        # [DeletingParent('Not deleting', u'subtree', None)] conflict). See bug
 
875
        # #634470.  -- vila 20100909
 
876
        self.assertRaises(errors.NotBranchError,
 
877
                          tree.bzrdir.sprout, 'repo/tree2')
 
878
#        self.assertPathExists('repo/tree2/subtree')
 
879
#        self.assertPathDoesNotExist('repo/tree2/subtree/file')
793
880
 
794
881
    def make_foo_bar_baz(self):
795
882
        foo = bzrdir.BzrDir.create_branch_convenience('foo').bzrdir
799
886
 
800
887
    def test_find_bzrdirs(self):
801
888
        foo, bar, baz = self.make_foo_bar_baz()
802
 
        transport = get_transport(self.get_url())
803
 
        self.assertEqualBzrdirs([baz, foo, bar],
804
 
                                bzrdir.BzrDir.find_bzrdirs(transport))
 
889
        t = self.get_transport()
 
890
        self.assertEqualBzrdirs([baz, foo, bar], bzrdir.BzrDir.find_bzrdirs(t))
 
891
 
 
892
    def make_fake_permission_denied_transport(self, transport, paths):
 
893
        """Create a transport that raises PermissionDenied for some paths."""
 
894
        def filter(path):
 
895
            if path in paths:
 
896
                raise errors.PermissionDenied(path)
 
897
            return path
 
898
        path_filter_server = pathfilter.PathFilteringServer(transport, filter)
 
899
        path_filter_server.start_server()
 
900
        self.addCleanup(path_filter_server.stop_server)
 
901
        path_filter_transport = pathfilter.PathFilteringTransport(
 
902
            path_filter_server, '.')
 
903
        return (path_filter_server, path_filter_transport)
 
904
 
 
905
    def assertBranchUrlsEndWith(self, expect_url_suffix, actual_bzrdirs):
 
906
        """Check that each branch url ends with the given suffix."""
 
907
        for actual_bzrdir in actual_bzrdirs:
 
908
            self.assertEndsWith(actual_bzrdir.user_url, expect_url_suffix)
 
909
 
 
910
    def test_find_bzrdirs_permission_denied(self):
 
911
        foo, bar, baz = self.make_foo_bar_baz()
 
912
        t = self.get_transport()
 
913
        path_filter_server, path_filter_transport = \
 
914
            self.make_fake_permission_denied_transport(t, ['foo'])
 
915
        # local transport
 
916
        self.assertBranchUrlsEndWith('/baz/',
 
917
            bzrdir.BzrDir.find_bzrdirs(path_filter_transport))
 
918
        # smart server
 
919
        smart_transport = self.make_smart_server('.',
 
920
            backing_server=path_filter_server)
 
921
        self.assertBranchUrlsEndWith('/baz/',
 
922
            bzrdir.BzrDir.find_bzrdirs(smart_transport))
805
923
 
806
924
    def test_find_bzrdirs_list_current(self):
807
925
        def list_current(transport):
808
926
            return [s for s in transport.list_dir('') if s != 'baz']
809
927
 
810
928
        foo, bar, baz = self.make_foo_bar_baz()
811
 
        transport = get_transport(self.get_url())
812
 
        self.assertEqualBzrdirs([foo, bar],
813
 
                                bzrdir.BzrDir.find_bzrdirs(transport,
814
 
                                    list_current=list_current))
815
 
 
 
929
        t = self.get_transport()
 
930
        self.assertEqualBzrdirs(
 
931
            [foo, bar],
 
932
            bzrdir.BzrDir.find_bzrdirs(t, list_current=list_current))
816
933
 
817
934
    def test_find_bzrdirs_evaluate(self):
818
935
        def evaluate(bzrdir):
819
936
            try:
820
937
                repo = bzrdir.open_repository()
821
 
            except NoRepositoryPresent:
 
938
            except errors.NoRepositoryPresent:
822
939
                return True, bzrdir.root_transport.base
823
940
            else:
824
941
                return False, bzrdir.root_transport.base
825
942
 
826
943
        foo, bar, baz = self.make_foo_bar_baz()
827
 
        transport = get_transport(self.get_url())
 
944
        t = self.get_transport()
828
945
        self.assertEqual([baz.root_transport.base, foo.root_transport.base],
829
 
                         list(bzrdir.BzrDir.find_bzrdirs(transport,
830
 
                                                         evaluate=evaluate)))
 
946
                         list(bzrdir.BzrDir.find_bzrdirs(t, evaluate=evaluate)))
831
947
 
832
948
    def assertEqualBzrdirs(self, first, second):
833
949
        first = list(first)
840
956
        root = self.make_repository('', shared=True)
841
957
        foo, bar, baz = self.make_foo_bar_baz()
842
958
        qux = self.make_bzrdir('foo/qux')
843
 
        transport = get_transport(self.get_url())
844
 
        branches = bzrdir.BzrDir.find_branches(transport)
 
959
        t = self.get_transport()
 
960
        branches = bzrdir.BzrDir.find_branches(t)
845
961
        self.assertEqual(baz.root_transport.base, branches[0].base)
846
962
        self.assertEqual(foo.root_transport.base, branches[1].base)
847
963
        self.assertEqual(bar.root_transport.base, branches[2].base)
848
964
 
849
965
        # ensure this works without a top-level repo
850
 
        branches = bzrdir.BzrDir.find_branches(transport.clone('foo'))
 
966
        branches = bzrdir.BzrDir.find_branches(t.clone('foo'))
851
967
        self.assertEqual(foo.root_transport.base, branches[0].base)
852
968
        self.assertEqual(bar.root_transport.base, branches[1].base)
853
969
 
854
970
 
 
971
class TestMissingRepoBranchesSkipped(TestCaseWithMemoryTransport):
 
972
 
 
973
    def test_find_bzrdirs_missing_repo(self):
 
974
        t = self.get_transport()
 
975
        arepo = self.make_repository('arepo', shared=True)
 
976
        abranch_url = arepo.user_url + '/abranch'
 
977
        abranch = bzrdir.BzrDir.create(abranch_url).create_branch()
 
978
        t.delete_tree('arepo/.bzr')
 
979
        self.assertRaises(errors.NoRepositoryPresent,
 
980
            branch.Branch.open, abranch_url)
 
981
        self.make_branch('baz')
 
982
        for actual_bzrdir in bzrdir.BzrDir.find_branches(t):
 
983
            self.assertEndsWith(actual_bzrdir.user_url, '/baz/')
 
984
 
 
985
 
855
986
class TestMeta1DirFormat(TestCaseWithTransport):
856
987
    """Tests specific to the meta1 dir format."""
857
988
 
864
995
                         dir.get_branch_transport(bzrlib.branch.BzrBranchFormat5()).base)
865
996
        repository_base = t.clone('repository').base
866
997
        self.assertEqual(repository_base, dir.get_repository_transport(None).base)
 
998
        repository_format = repository.format_registry.get_default()
867
999
        self.assertEqual(repository_base,
868
 
                         dir.get_repository_transport(weaverepo.RepositoryFormat7()).base)
 
1000
                         dir.get_repository_transport(repository_format).base)
869
1001
        checkout_base = t.clone('checkout').base
870
1002
        self.assertEqual(checkout_base, dir.get_workingtree_transport(None).base)
871
1003
        self.assertEqual(checkout_base,
872
 
                         dir.get_workingtree_transport(workingtree.WorkingTreeFormat3()).base)
 
1004
                         dir.get_workingtree_transport(workingtree_3.WorkingTreeFormat3()).base)
873
1005
 
874
1006
    def test_meta1dir_uses_lockdir(self):
875
1007
        """Meta1 format uses a LockDir to guard the whole directory, not a file."""
893
1025
        self.assertNotEqual(otherdir2, mydir)
894
1026
        self.assertFalse(otherdir2 == mydir)
895
1027
 
 
1028
    def test_with_features(self):
 
1029
        tree = self.make_branch_and_tree('tree', format='2a')
 
1030
        tree.bzrdir.control_transport.put_bytes(
 
1031
            'branch-format',
 
1032
            tree.bzrdir._format.get_format_string() + "required bar\n")
 
1033
        self.assertRaises(errors.MissingFeature, bzrdir.BzrDir.open, 'tree')
 
1034
        bzrdir.BzrDirMetaFormat1.register_feature('bar')
 
1035
        self.addCleanup(bzrdir.BzrDirMetaFormat1.unregister_feature, 'bar')
 
1036
        dir = bzrdir.BzrDir.open('tree')
 
1037
        self.assertEquals("required", dir._format.features.get("bar"))
 
1038
 
896
1039
    def test_needs_conversion_different_working_tree(self):
897
1040
        # meta1dirs need an conversion if any element is not the default.
898
1041
        new_format = bzrdir.format_registry.make_bzrdir('dirstate')
917
1060
        self.assertEqual(2, rpc_count)
918
1061
 
919
1062
 
920
 
class TestFormat5(TestCaseWithTransport):
921
 
    """Tests specific to the version 5 bzrdir format."""
922
 
 
923
 
    def test_same_lockfiles_between_tree_repo_branch(self):
924
 
        # this checks that only a single lockfiles instance is created
925
 
        # for format 5 objects
926
 
        dir = bzrdir.BzrDirFormat5().initialize(self.get_url())
927
 
        def check_dir_components_use_same_lock(dir):
928
 
            ctrl_1 = dir.open_repository().control_files
929
 
            ctrl_2 = dir.open_branch().control_files
930
 
            ctrl_3 = dir.open_workingtree()._control_files
931
 
            self.assertTrue(ctrl_1 is ctrl_2)
932
 
            self.assertTrue(ctrl_2 is ctrl_3)
933
 
        check_dir_components_use_same_lock(dir)
934
 
        # and if we open it normally.
935
 
        dir = bzrdir.BzrDir.open(self.get_url())
936
 
        check_dir_components_use_same_lock(dir)
937
 
 
938
 
    def test_can_convert(self):
939
 
        # format 5 dirs are convertable
940
 
        dir = bzrdir.BzrDirFormat5().initialize(self.get_url())
941
 
        self.assertTrue(dir.can_convert_format())
942
 
 
943
 
    def test_needs_conversion(self):
944
 
        # format 5 dirs need a conversion if they are not the default,
945
 
        # and they aren't
946
 
        dir = bzrdir.BzrDirFormat5().initialize(self.get_url())
947
 
        # don't need to convert it to itself
948
 
        self.assertFalse(dir.needs_format_conversion(bzrdir.BzrDirFormat5()))
949
 
        # do need to convert it to the current default
950
 
        self.assertTrue(dir.needs_format_conversion(
951
 
            bzrdir.BzrDirFormat.get_default_format()))
952
 
 
953
 
 
954
 
class TestFormat6(TestCaseWithTransport):
955
 
    """Tests specific to the version 6 bzrdir format."""
956
 
 
957
 
    def test_same_lockfiles_between_tree_repo_branch(self):
958
 
        # this checks that only a single lockfiles instance is created
959
 
        # for format 6 objects
960
 
        dir = bzrdir.BzrDirFormat6().initialize(self.get_url())
961
 
        def check_dir_components_use_same_lock(dir):
962
 
            ctrl_1 = dir.open_repository().control_files
963
 
            ctrl_2 = dir.open_branch().control_files
964
 
            ctrl_3 = dir.open_workingtree()._control_files
965
 
            self.assertTrue(ctrl_1 is ctrl_2)
966
 
            self.assertTrue(ctrl_2 is ctrl_3)
967
 
        check_dir_components_use_same_lock(dir)
968
 
        # and if we open it normally.
969
 
        dir = bzrdir.BzrDir.open(self.get_url())
970
 
        check_dir_components_use_same_lock(dir)
971
 
 
972
 
    def test_can_convert(self):
973
 
        # format 6 dirs are convertable
974
 
        dir = bzrdir.BzrDirFormat6().initialize(self.get_url())
975
 
        self.assertTrue(dir.can_convert_format())
976
 
 
977
 
    def test_needs_conversion(self):
978
 
        # format 6 dirs need an conversion if they are not the default.
979
 
        dir = bzrdir.BzrDirFormat6().initialize(self.get_url())
980
 
        self.assertTrue(dir.needs_format_conversion(
981
 
            bzrdir.BzrDirFormat.get_default_format()))
982
 
 
983
 
 
984
 
class NotBzrDir(bzrlib.bzrdir.BzrDir):
985
 
    """A non .bzr based control directory."""
986
 
 
987
 
    def __init__(self, transport, format):
988
 
        self._format = format
989
 
        self.root_transport = transport
990
 
        self.transport = transport.clone('.not')
991
 
 
992
 
 
993
 
class NotBzrDirFormat(bzrlib.bzrdir.BzrDirFormat):
994
 
    """A test class representing any non-.bzr based disk format."""
995
 
 
996
 
    def initialize_on_transport(self, transport):
997
 
        """Initialize a new .not dir in the base directory of a Transport."""
998
 
        transport.mkdir('.not')
999
 
        return self.open(transport)
1000
 
 
1001
 
    def open(self, transport):
1002
 
        """Open this directory."""
1003
 
        return NotBzrDir(transport, self)
1004
 
 
1005
 
    @classmethod
1006
 
    def _known_formats(self):
1007
 
        return set([NotBzrDirFormat()])
1008
 
 
1009
 
    @classmethod
1010
 
    def probe_transport(self, transport):
1011
 
        """Our format is present if the transport ends in '.not/'."""
1012
 
        if transport.has('.not'):
1013
 
            return NotBzrDirFormat()
1014
 
 
1015
 
 
1016
 
class TestNotBzrDir(TestCaseWithTransport):
1017
 
    """Tests for using the bzrdir api with a non .bzr based disk format.
1018
 
 
1019
 
    If/when one of these is in the core, we can let the implementation tests
1020
 
    verify this works.
1021
 
    """
1022
 
 
1023
 
    def test_create_and_find_format(self):
1024
 
        # create a .notbzr dir
1025
 
        format = NotBzrDirFormat()
1026
 
        dir = format.initialize(self.get_url())
1027
 
        self.assertIsInstance(dir, NotBzrDir)
1028
 
        # now probe for it.
1029
 
        bzrlib.bzrdir.BzrDirFormat.register_control_format(format)
1030
 
        try:
1031
 
            found = bzrlib.bzrdir.BzrDirFormat.find_format(
1032
 
                get_transport(self.get_url()))
1033
 
            self.assertIsInstance(found, NotBzrDirFormat)
1034
 
        finally:
1035
 
            bzrlib.bzrdir.BzrDirFormat.unregister_control_format(format)
1036
 
 
1037
 
    def test_included_in_known_formats(self):
1038
 
        bzrlib.bzrdir.BzrDirFormat.register_control_format(NotBzrDirFormat)
1039
 
        try:
1040
 
            formats = bzrlib.bzrdir.BzrDirFormat.known_formats()
1041
 
            for format in formats:
1042
 
                if isinstance(format, NotBzrDirFormat):
1043
 
                    return
1044
 
            self.fail("No NotBzrDirFormat in %s" % formats)
1045
 
        finally:
1046
 
            bzrlib.bzrdir.BzrDirFormat.unregister_control_format(NotBzrDirFormat)
1047
 
 
1048
 
 
1049
1063
class NonLocalTests(TestCaseWithTransport):
1050
1064
    """Tests for bzrdir static behaviour on non local paths."""
1051
1065
 
1070
1084
            self.get_url('foo'),
1071
1085
            force_new_tree=True,
1072
1086
            format=format)
1073
 
        t = get_transport(self.get_url('.'))
 
1087
        t = self.get_transport()
1074
1088
        self.assertFalse(t.has('foo'))
1075
1089
 
1076
1090
    def test_clone(self):
1092
1106
        my_bzrdir = bzrdir.BzrDir.open(self.get_url('branch-knit2'))
1093
1107
        checkout_format = my_bzrdir.checkout_metadir()
1094
1108
        self.assertIsInstance(checkout_format.workingtree_format,
1095
 
                              workingtree.WorkingTreeFormat3)
 
1109
                              workingtree_4.WorkingTreeFormat4)
1096
1110
 
1097
1111
 
1098
1112
class TestHTTPRedirections(object):
1107
1121
    """
1108
1122
 
1109
1123
    def create_transport_readonly_server(self):
 
1124
        # We don't set the http protocol version, relying on the default
1110
1125
        return http_utils.HTTPServerRedirecting()
1111
1126
 
1112
1127
    def create_transport_secondary_server(self):
 
1128
        # We don't set the http protocol version, relying on the default
1113
1129
        return http_utils.HTTPServerRedirecting()
1114
1130
 
1115
1131
    def setUp(self):
1240
1256
 
1241
1257
    def __init__(self, *args, **kwargs):
1242
1258
        super(_TestBzrDir, self).__init__(*args, **kwargs)
1243
 
        self.test_branch = _TestBranch()
 
1259
        self.test_branch = _TestBranch(self.transport)
1244
1260
        self.test_branch.repository = self.create_repository()
1245
1261
 
1246
 
    def open_branch(self, unsupported=False):
 
1262
    def open_branch(self, unsupported=False, possible_transports=None):
1247
1263
        return self.test_branch
1248
1264
 
1249
1265
    def cloning_metadir(self, require_stacking=False):
1257
1273
class _TestBranch(bzrlib.branch.Branch):
1258
1274
    """Test Branch implementation for TestBzrDirSprout."""
1259
1275
 
1260
 
    def __init__(self, *args, **kwargs):
 
1276
    def __init__(self, transport, *args, **kwargs):
1261
1277
        self._format = _TestBranchFormat()
 
1278
        self._transport = transport
 
1279
        self.base = transport.base
1262
1280
        super(_TestBranch, self).__init__(*args, **kwargs)
1263
1281
        self.calls = []
1264
1282
        self._parent = None
1265
1283
 
1266
1284
    def sprout(self, *args, **kwargs):
1267
1285
        self.calls.append('sprout')
1268
 
        return _TestBranch()
 
1286
        return _TestBranch(self._transport)
1269
1287
 
1270
1288
    def copy_content_into(self, destination, revision_id=None):
1271
1289
        self.calls.append('copy_content_into')
1272
1290
 
 
1291
    def last_revision(self):
 
1292
        return _mod_revision.NULL_REVISION
 
1293
 
1273
1294
    def get_parent(self):
1274
1295
        return self._parent
1275
1296
 
 
1297
    def _get_config(self):
 
1298
        return config.TransportConfig(self._transport, 'branch.conf')
 
1299
 
1276
1300
    def set_parent(self, parent):
1277
1301
        self._parent = parent
1278
1302
 
 
1303
    def lock_read(self):
 
1304
        return lock.LogicalLockResult(self.unlock)
 
1305
 
 
1306
    def unlock(self):
 
1307
        return
 
1308
 
1279
1309
 
1280
1310
class TestBzrDirSprout(TestCaseWithMemoryTransport):
1281
1311
 
1335
1365
        url = transport.base
1336
1366
        err = self.assertRaises(errors.BzrError, bzrdir.BzrDir.open, url)
1337
1367
        self.assertEqual('fail', err._preformatted_string)
 
1368
 
 
1369
    def test_post_repo_init(self):
 
1370
        from bzrlib.controldir import RepoInitHookParams
 
1371
        calls = []
 
1372
        bzrdir.BzrDir.hooks.install_named_hook('post_repo_init',
 
1373
            calls.append, None)
 
1374
        self.make_repository('foo')
 
1375
        self.assertLength(1, calls)
 
1376
        params = calls[0]
 
1377
        self.assertIsInstance(params, RepoInitHookParams)
 
1378
        self.assertTrue(hasattr(params, 'bzrdir'))
 
1379
        self.assertTrue(hasattr(params, 'repository'))
 
1380
 
 
1381
    def test_post_repo_init_hook_repr(self):
 
1382
        param_reprs = []
 
1383
        bzrdir.BzrDir.hooks.install_named_hook('post_repo_init',
 
1384
            lambda params: param_reprs.append(repr(params)), None)
 
1385
        self.make_repository('foo')
 
1386
        self.assertLength(1, param_reprs)
 
1387
        param_repr = param_reprs[0]
 
1388
        self.assertStartsWith(param_repr, '<RepoInitHookParams for ')
 
1389
 
 
1390
 
 
1391
class TestGenerateBackupName(TestCaseWithMemoryTransport):
 
1392
    # FIXME: This may need to be unified with test_osutils.TestBackupNames or
 
1393
    # moved to per_bzrdir or per_transport for better coverage ?
 
1394
    # -- vila 20100909
 
1395
 
 
1396
    def setUp(self):
 
1397
        super(TestGenerateBackupName, self).setUp()
 
1398
        self._transport = self.get_transport()
 
1399
        bzrdir.BzrDir.create(self.get_url(),
 
1400
            possible_transports=[self._transport])
 
1401
        self._bzrdir = bzrdir.BzrDir.open_from_transport(self._transport)
 
1402
 
 
1403
    def test_deprecated_generate_backup_name(self):
 
1404
        res = self.applyDeprecated(
 
1405
                symbol_versioning.deprecated_in((2, 3, 0)),
 
1406
                self._bzrdir.generate_backup_name, 'whatever')
 
1407
 
 
1408
    def test_new(self):
 
1409
        self.assertEqual("a.~1~", self._bzrdir._available_backup_name("a"))
 
1410
 
 
1411
    def test_exiting(self):
 
1412
        self._transport.put_bytes("a.~1~", "some content")
 
1413
        self.assertEqual("a.~2~", self._bzrdir._available_backup_name("a"))
 
1414
 
 
1415
 
 
1416
class TestMeta1DirColoFormat(TestCaseWithTransport):
 
1417
    """Tests specific to the meta1 dir with colocated branches format."""
 
1418
 
 
1419
    def test_supports_colo(self):
 
1420
        format = bzrdir.BzrDirMetaFormat1Colo()
 
1421
        self.assertTrue(format.colocated_branches)
 
1422
 
 
1423
    def test_upgrade_from_2a(self):
 
1424
        tree = self.make_branch_and_tree('.', format='2a')
 
1425
        format = bzrdir.BzrDirMetaFormat1Colo()
 
1426
        self.assertTrue(tree.bzrdir.needs_format_conversion(format))
 
1427
        converter = tree.bzrdir._format.get_converter(format)
 
1428
        result = converter.convert(tree.bzrdir, None)
 
1429
        self.assertIsInstance(result._format, bzrdir.BzrDirMetaFormat1Colo)
 
1430
        self.assertFalse(result.needs_format_conversion(format))
 
1431
 
 
1432
    def test_downgrade_to_2a(self):
 
1433
        tree = self.make_branch_and_tree('.', format='development-colo')
 
1434
        format = bzrdir.BzrDirMetaFormat1()
 
1435
        self.assertTrue(tree.bzrdir.needs_format_conversion(format))
 
1436
        converter = tree.bzrdir._format.get_converter(format)
 
1437
        result = converter.convert(tree.bzrdir, None)
 
1438
        self.assertIsInstance(result._format, bzrdir.BzrDirMetaFormat1)
 
1439
        self.assertFalse(result.needs_format_conversion(format))
 
1440
 
 
1441
    def test_downgrade_to_2a_too_many_branches(self):
 
1442
        tree = self.make_branch_and_tree('.', format='development-colo')
 
1443
        tree.bzrdir.create_branch(name="another-colocated-branch")
 
1444
        converter = tree.bzrdir._format.get_converter(
 
1445
            bzrdir.BzrDirMetaFormat1())
 
1446
        self.assertRaises(errors.BzrError, converter.convert, tree.bzrdir,
 
1447
            None)
 
1448
 
 
1449
 
 
1450
class SampleBzrFormat(bzrdir.BzrFormat):
 
1451
 
 
1452
    @classmethod
 
1453
    def get_format_string(cls):
 
1454
        return "First line\n"
 
1455
 
 
1456
 
 
1457
class TestBzrFormat(TestCase):
 
1458
    """Tests for BzrFormat."""
 
1459
 
 
1460
    def test_as_string(self):
 
1461
        format = SampleBzrFormat()
 
1462
        format.features = {"foo": "required"}
 
1463
        self.assertEquals(format.as_string(),
 
1464
            "First line\n"
 
1465
            "required foo\n")
 
1466
        format.features["another"] = "optional"
 
1467
        self.assertEquals(format.as_string(),
 
1468
            "First line\n"
 
1469
            "required foo\n"
 
1470
            "optional another\n")
 
1471
 
 
1472
    def test_network_name(self):
 
1473
        # The network string should include the feature info
 
1474
        format = SampleBzrFormat()
 
1475
        format.features = {"foo": "required"}
 
1476
        self.assertEquals(
 
1477
            "First line\nrequired foo\n",
 
1478
            format.network_name())
 
1479
 
 
1480
    def test_from_string_no_features(self):
 
1481
        # No features
 
1482
        format = SampleBzrFormat.from_string(
 
1483
            "First line\n")
 
1484
        self.assertEquals({}, format.features)
 
1485
 
 
1486
    def test_from_string_with_feature(self):
 
1487
        # Proper feature
 
1488
        format = SampleBzrFormat.from_string(
 
1489
            "First line\nrequired foo\n")
 
1490
        self.assertEquals("required", format.features.get("foo"))
 
1491
 
 
1492
    def test_from_string_format_string_mismatch(self):
 
1493
        # The first line has to match the format string
 
1494
        self.assertRaises(AssertionError, SampleBzrFormat.from_string,
 
1495
            "Second line\nrequired foo\n")
 
1496
 
 
1497
    def test_from_string_missing_space(self):
 
1498
        # At least one space is required in the feature lines
 
1499
        self.assertRaises(errors.ParseFormatError, SampleBzrFormat.from_string,
 
1500
            "First line\nfoo\n")
 
1501
 
 
1502
    def test_from_string_with_spaces(self):
 
1503
        # Feature with spaces (in case we add stuff like this in the future)
 
1504
        format = SampleBzrFormat.from_string(
 
1505
            "First line\nrequired foo with spaces\n")
 
1506
        self.assertEquals("required", format.features.get("foo with spaces"))
 
1507
 
 
1508
    def test_eq(self):
 
1509
        format1 = SampleBzrFormat()
 
1510
        format1.features = {"nested-trees": "optional"}
 
1511
        format2 = SampleBzrFormat()
 
1512
        format2.features = {"nested-trees": "optional"}
 
1513
        self.assertEquals(format1, format1)
 
1514
        self.assertEquals(format1, format2)
 
1515
        format3 = SampleBzrFormat()
 
1516
        self.assertNotEquals(format1, format3)
 
1517
 
 
1518
    def test_check_support_status_optional(self):
 
1519
        # Optional, so silently ignore
 
1520
        format = SampleBzrFormat()
 
1521
        format.features = {"nested-trees": "optional"}
 
1522
        format.check_support_status(True)
 
1523
        self.addCleanup(SampleBzrFormat.unregister_feature, "nested-trees")
 
1524
        SampleBzrFormat.register_feature("nested-trees")
 
1525
        format.check_support_status(True)
 
1526
 
 
1527
    def test_check_support_status_required(self):
 
1528
        # Optional, so trigger an exception
 
1529
        format = SampleBzrFormat()
 
1530
        format.features = {"nested-trees": "required"}
 
1531
        self.assertRaises(errors.MissingFeature, format.check_support_status,
 
1532
            True)
 
1533
        self.addCleanup(SampleBzrFormat.unregister_feature, "nested-trees")
 
1534
        SampleBzrFormat.register_feature("nested-trees")
 
1535
        format.check_support_status(True)
 
1536
 
 
1537
    def test_check_support_status_unknown(self):
 
1538
        # treat unknown necessity as required
 
1539
        format = SampleBzrFormat()
 
1540
        format.features = {"nested-trees": "unknown"}
 
1541
        self.assertRaises(errors.MissingFeature, format.check_support_status,
 
1542
            True)
 
1543
        self.addCleanup(SampleBzrFormat.unregister_feature, "nested-trees")
 
1544
        SampleBzrFormat.register_feature("nested-trees")
 
1545
        format.check_support_status(True)
 
1546
 
 
1547
    def test_feature_already_registered(self):
 
1548
        # a feature can only be registered once
 
1549
        self.addCleanup(SampleBzrFormat.unregister_feature, "nested-trees")
 
1550
        SampleBzrFormat.register_feature("nested-trees")
 
1551
        self.assertRaises(errors.FeatureAlreadyRegistered,
 
1552
            SampleBzrFormat.register_feature, "nested-trees")
 
1553
 
 
1554
    def test_feature_with_space(self):
 
1555
        # spaces are not allowed in feature names
 
1556
        self.assertRaises(ValueError, SampleBzrFormat.register_feature,
 
1557
            "nested trees")