← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_shelf_ui.py

  • Committer: Vincent Ladeuil
  • Date: 2012-01-18 14:09:19 UTC
  • mto: This revision was merged to the branch mainline in revision 6468.
  • Revision ID: v.ladeuil+lp@free.fr-20120118140919-rlvdrhpc0nq1lbwi
Change set/remove to require a lock for the branch config files.

This means that tests (or any plugin for that matter) do not requires an
explicit lock on the branch anymore to change a single option. This also
means the optimisation becomes "opt-in" and as such won't be as
spectacular as it may be and/or harder to get right (nothing fails
anymore).

This reduces the diff by ~300 lines.

Code/tests that were updating more than one config option is still taking
a lock to at least avoid some IOs and demonstrate the benefits through
the decreased number of hpss calls.

The duplication between BranchStack and BranchOnlyStack will be removed
once the same sharing is in place for local config files, at which point
the Stack class itself may be able to host the changes.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_shelf_ui.py
27
27
    tests,
28
28
)
29
29
from bzrlib.tests import script
 
30
from bzrlib.tests import (
 
31
    features,
 
32
    )
30
33
 
31
34
 
32
35
class ExpectShelver(shelf_ui.Shelver):
41
44
        self.expected = []
42
45
        self.diff_writer = StringIO()
43
46
 
44
 
    def expect(self, prompt, response):
45
 
        self.expected.append((prompt, response))
 
47
    def expect(self, message, response):
 
48
        self.expected.append((message, response))
46
49
 
47
 
    def prompt(self, message):
 
50
    def prompt(self, message, choices, default):
48
51
        try:
49
 
            prompt, response = self.expected.pop(0)
 
52
            expected_message, response = self.expected.pop(0)
50
53
        except IndexError:
51
54
            raise AssertionError('Unexpected prompt: %s' % message)
52
 
        if prompt != message:
 
55
        if message != expected_message:
53
56
            raise AssertionError('Wrong prompt: %s' % message)
 
57
        if choices != '&yes\n&No\n&finish\n&quit':
 
58
            raise AssertionError('Wrong choices: %s' % choices)
54
59
        return response
55
60
 
56
61
 
63
68
LINES_AY = 'a\nb\nc\nd\ne\nf\ng\nh\ni\ny\n'
64
69
 
65
70
 
66
 
class TestShelver(tests.TestCaseWithTransport):
 
71
class ShelfTestCase(tests.TestCaseWithTransport):
67
72
 
68
73
    def create_shelvable_tree(self):
69
74
        tree = self.make_branch_and_tree('tree')
73
78
        self.build_tree_contents([('tree/foo', LINES_ZY)])
74
79
        return tree
75
80
 
 
81
 
 
82
class TestShelver(ShelfTestCase):
 
83
 
76
84
    def test_unexpected_prompt_failure(self):
77
85
        tree = self.create_shelvable_tree()
78
86
        tree.lock_tree_write()
80
88
        shelver = ExpectShelver(tree, tree.basis_tree())
81
89
        self.addCleanup(shelver.finalize)
82
90
        e = self.assertRaises(AssertionError, shelver.run)
83
 
        self.assertEqual('Unexpected prompt: Shelve? [yNfq?]', str(e))
 
91
        self.assertEqual('Unexpected prompt: Shelve?', str(e))
84
92
 
85
93
    def test_wrong_prompt_failure(self):
86
94
        tree = self.create_shelvable_tree()
88
96
        self.addCleanup(tree.unlock)
89
97
        shelver = ExpectShelver(tree, tree.basis_tree())
90
98
        self.addCleanup(shelver.finalize)
91
 
        shelver.expect('foo', 'y')
 
99
        shelver.expect('foo', 0)
92
100
        e = self.assertRaises(AssertionError, shelver.run)
93
 
        self.assertEqual('Wrong prompt: Shelve? [yNfq?]', str(e))
 
101
        self.assertEqual('Wrong prompt: Shelve?', str(e))
94
102
 
95
103
    def test_shelve_not_diff(self):
96
104
        tree = self.create_shelvable_tree()
98
106
        self.addCleanup(tree.unlock)
99
107
        shelver = ExpectShelver(tree, tree.basis_tree())
100
108
        self.addCleanup(shelver.finalize)
101
 
        shelver.expect('Shelve? [yNfq?]', 'n')
102
 
        shelver.expect('Shelve? [yNfq?]', 'n')
 
109
        shelver.expect('Shelve?', 1)
 
110
        shelver.expect('Shelve?', 1)
103
111
        # No final shelving prompt because no changes were selected
104
112
        shelver.run()
105
113
        self.assertFileEqual(LINES_ZY, 'tree/foo')
110
118
        self.addCleanup(tree.unlock)
111
119
        shelver = ExpectShelver(tree, tree.basis_tree())
112
120
        self.addCleanup(shelver.finalize)
113
 
        shelver.expect('Shelve? [yNfq?]', 'y')
114
 
        shelver.expect('Shelve? [yNfq?]', 'y')
115
 
        shelver.expect('Shelve 2 change(s)? [yNfq?]', 'n')
 
121
        shelver.expect('Shelve?', 0)
 
122
        shelver.expect('Shelve?', 0)
 
123
        shelver.expect('Shelve 2 change(s)?', 1)
116
124
        shelver.run()
117
125
        self.assertFileEqual(LINES_ZY, 'tree/foo')
118
126
 
122
130
        self.addCleanup(tree.unlock)
123
131
        shelver = ExpectShelver(tree, tree.basis_tree())
124
132
        self.addCleanup(shelver.finalize)
125
 
        shelver.expect('Shelve? [yNfq?]', 'y')
126
 
        shelver.expect('Shelve? [yNfq?]', 'y')
127
 
        shelver.expect('Shelve 2 change(s)? [yNfq?]', 'y')
 
133
        shelver.expect('Shelve?', 0)
 
134
        shelver.expect('Shelve?', 0)
 
135
        shelver.expect('Shelve 2 change(s)?', 0)
128
136
        shelver.run()
129
137
        self.assertFileEqual(LINES_AJ, 'tree/foo')
130
138
 
134
142
        self.addCleanup(tree.unlock)
135
143
        shelver = ExpectShelver(tree, tree.basis_tree())
136
144
        self.addCleanup(shelver.finalize)
137
 
        shelver.expect('Shelve? [yNfq?]', 'y')
138
 
        shelver.expect('Shelve? [yNfq?]', 'n')
139
 
        shelver.expect('Shelve 1 change(s)? [yNfq?]', 'y')
 
145
        shelver.expect('Shelve?', 0)
 
146
        shelver.expect('Shelve?', 1)
 
147
        shelver.expect('Shelve 1 change(s)?', 0)
140
148
        shelver.run()
141
149
        self.assertFileEqual(LINES_AY, 'tree/foo')
142
150
 
147
155
        self.addCleanup(tree.unlock)
148
156
        shelver = ExpectShelver(tree, tree.basis_tree())
149
157
        self.addCleanup(shelver.finalize)
150
 
        shelver.expect('Shelve binary changes? [yNfq?]', 'y')
151
 
        shelver.expect('Shelve 1 change(s)? [yNfq?]', 'y')
 
158
        shelver.expect('Shelve binary changes?', 0)
 
159
        shelver.expect('Shelve 1 change(s)?', 0)
152
160
        shelver.run()
153
161
        self.assertFileEqual(LINES_AJ, 'tree/foo')
154
162
 
159
167
        self.addCleanup(tree.unlock)
160
168
        shelver = ExpectShelver(tree, tree.basis_tree())
161
169
        self.addCleanup(shelver.finalize)
162
 
        shelver.expect('Shelve renaming "foo" => "bar"? [yNfq?]', 'y')
163
 
        shelver.expect('Shelve? [yNfq?]', 'y')
164
 
        shelver.expect('Shelve? [yNfq?]', 'y')
165
 
        shelver.expect('Shelve 3 change(s)? [yNfq?]', 'y')
 
170
        shelver.expect('Shelve renaming "foo" => "bar"?', 0)
 
171
        shelver.expect('Shelve?', 0)
 
172
        shelver.expect('Shelve?', 0)
 
173
        shelver.expect('Shelve 3 change(s)?', 0)
166
174
        shelver.run()
167
175
        self.assertFileEqual(LINES_AJ, 'tree/foo')
168
176
 
173
181
        self.addCleanup(tree.unlock)
174
182
        shelver = ExpectShelver(tree, tree.basis_tree())
175
183
        self.addCleanup(shelver.finalize)
176
 
        shelver.expect('Shelve removing file "foo"? [yNfq?]', 'y')
177
 
        shelver.expect('Shelve 1 change(s)? [yNfq?]', 'y')
 
184
        shelver.expect('Shelve removing file "foo"?', 0)
 
185
        shelver.expect('Shelve 1 change(s)?', 0)
178
186
        shelver.run()
179
187
        self.assertFileEqual(LINES_AJ, 'tree/foo')
180
188
 
187
195
        self.addCleanup(tree.unlock)
188
196
        shelver = ExpectShelver(tree, tree.basis_tree())
189
197
        self.addCleanup(shelver.finalize)
190
 
        shelver.expect('Shelve adding file "foo"? [yNfq?]', 'y')
191
 
        shelver.expect('Shelve 1 change(s)? [yNfq?]', 'y')
 
198
        shelver.expect('Shelve adding file "foo"?', 0)
 
199
        shelver.expect('Shelve 1 change(s)?', 0)
192
200
        shelver.run()
193
 
        self.failIfExists('tree/foo')
 
201
        self.assertPathDoesNotExist('tree/foo')
194
202
 
195
203
    def test_shelve_kind_change(self):
196
204
        tree = self.create_shelvable_tree()
200
208
        self.addCleanup(tree.unlock)
201
209
        shelver = ExpectShelver(tree, tree.basis_tree())
202
210
        self.addCleanup(shelver.finalize)
203
 
        shelver.expect('Shelve changing "foo" from file to directory? [yNfq?]',
204
 
                       'y')
205
 
        shelver.expect('Shelve 1 change(s)? [yNfq?]', 'y')
 
211
        shelver.expect('Shelve changing "foo" from file to directory?',
 
212
                       0)
 
213
        shelver.expect('Shelve 1 change(s)?', 0)
206
214
 
207
215
    def test_shelve_modify_target(self):
208
 
        self.requireFeature(tests.SymlinkFeature)
 
216
        self.requireFeature(features.SymlinkFeature)
209
217
        tree = self.create_shelvable_tree()
210
218
        os.symlink('bar', 'tree/baz')
211
219
        tree.add('baz', 'baz-id')
217
225
        shelver = ExpectShelver(tree, tree.basis_tree())
218
226
        self.addCleanup(shelver.finalize)
219
227
        shelver.expect('Shelve changing target of "baz" from "bar" to '
220
 
                '"vax"? [yNfq?]', 'y')
221
 
        shelver.expect('Shelve 1 change(s)? [yNfq?]', 'y')
 
228
                '"vax"?', 0)
 
229
        shelver.expect('Shelve 1 change(s)?', 0)
222
230
        shelver.run()
223
231
        self.assertEqual('bar', os.readlink('tree/baz'))
224
232
 
228
236
        self.addCleanup(tree.unlock)
229
237
        shelver = ExpectShelver(tree, tree.basis_tree())
230
238
        self.addCleanup(shelver.finalize)
231
 
        shelver.expect('Shelve? [yNfq?]', 'f')
232
 
        shelver.expect('Shelve 2 change(s)? [yNfq?]', 'y')
 
239
        shelver.expect('Shelve?', 2)
 
240
        shelver.expect('Shelve 2 change(s)?', 0)
233
241
        shelver.run()
234
242
        self.assertFileEqual(LINES_AJ, 'tree/foo')
235
243
 
239
247
        self.addCleanup(tree.unlock)
240
248
        shelver = ExpectShelver(tree, tree.basis_tree())
241
249
        self.addCleanup(shelver.finalize)
242
 
        shelver.expect('Shelve? [yNfq?]', 'q')
 
250
        shelver.expect('Shelve?', 3)
243
251
        self.assertRaises(errors.UserAbort, shelver.run)
244
252
        self.assertFileEqual(LINES_ZY, 'tree/foo')
245
253
 
261
269
        self.addCleanup(tree.unlock)
262
270
        shelver = ExpectShelver(tree, tree.basis_tree(), file_list=['bar'])
263
271
        self.addCleanup(shelver.finalize)
264
 
        shelver.expect('Shelve adding file "bar"? [yNfq?]', 'y')
265
 
        shelver.expect('Shelve 1 change(s)? [yNfq?]', 'y')
266
 
        shelver.run()
267
 
 
268
 
    def test_shelve_help(self):
269
 
        tree = self.create_shelvable_tree()
270
 
        tree.lock_tree_write()
271
 
        self.addCleanup(tree.unlock)
272
 
        shelver = ExpectShelver(tree, tree.basis_tree())
273
 
        self.addCleanup(shelver.finalize)
274
 
        shelver.expect('Shelve? [yNfq?]', '?')
275
 
        shelver.expect('Shelve? [(y)es, (N)o, (f)inish, or (q)uit]', 'f')
276
 
        shelver.expect('Shelve 2 change(s)? [yNfq?]', 'y')
 
272
        shelver.expect('Shelve adding file "bar"?', 0)
 
273
        shelver.expect('Shelve 1 change(s)?', 0)
277
274
        shelver.run()
278
275
 
279
276
    def test_shelve_destroy(self):
299
296
        finally:
300
297
            tree.unlock()
301
298
 
302
 
    def test_shelve_old_root_deleted(self):
 
299
    def test_shelve_old_root_preserved(self):
303
300
        tree1 = self.make_branch_and_tree('tree1')
304
301
        tree1.commit('add root')
 
302
        tree1_root_id = tree1.get_root_id()
305
303
        tree2 = self.make_branch_and_tree('tree2')
306
304
        rev2 = tree2.commit('add root')
 
305
        self.assertNotEquals(tree1_root_id, tree2.get_root_id())
307
306
        tree1.merge_from_branch(tree2.branch,
308
307
                                from_revision=revision.NULL_REVISION)
309
 
        tree1.commit('Replaced root entry')
 
308
        tree1.commit('merging in tree2')
 
309
        self.assertEquals(tree1_root_id, tree1.get_root_id())
310
310
        # This is essentially assertNotRaises(InconsistentDelta)
311
 
        self.expectFailure('Cannot shelve replacing a root entry',
312
 
                           self.assertRaises, AssertionError,
313
 
                           self.assertRaises, errors.InconsistentDelta,
314
 
                           self.shelve_all, tree1, rev2)
 
311
        # With testtools 0.9.9, it can be rewritten as:
 
312
        # with ExpectedException(AssertionError,
 
313
        #                        'InconsistentDelta not raised'):
 
314
        #     with ExpectedException(errors.InconsistentDelta, ''):
 
315
        #         self.shelve_all(tree1, rev2)
 
316
        e = self.assertRaises(AssertionError, self.assertRaises,
 
317
                              errors.InconsistentDelta, self.shelve_all, tree1,
 
318
                              rev2)
 
319
        self.assertContainsRe('InconsistentDelta not raised', str(e))
315
320
 
316
321
    def test_shelve_split(self):
317
322
        outer_tree = self.make_branch_and_tree('outer')
327
332
                           outer_tree, rev2)
328
333
 
329
334
 
330
 
class TestApplyReporter(TestShelver):
 
335
class TestApplyReporter(ShelfTestCase):
331
336
 
332
337
    def test_shelve_not_diff(self):
333
338
        tree = self.create_shelvable_tree()
336
341
        shelver = ExpectShelver(tree, tree.basis_tree(),
337
342
                                reporter=shelf_ui.ApplyReporter())
338
343
        self.addCleanup(shelver.finalize)
339
 
        shelver.expect('Apply change? [yNfq?]', 'n')
340
 
        shelver.expect('Apply change? [yNfq?]', 'n')
 
344
        shelver.expect('Apply change?', 1)
 
345
        shelver.expect('Apply change?', 1)
341
346
        # No final shelving prompt because no changes were selected
342
347
        shelver.run()
343
348
        self.assertFileEqual(LINES_ZY, 'tree/foo')
349
354
        shelver = ExpectShelver(tree, tree.basis_tree(),
350
355
                                reporter=shelf_ui.ApplyReporter())
351
356
        self.addCleanup(shelver.finalize)
352
 
        shelver.expect('Apply change? [yNfq?]', 'y')
353
 
        shelver.expect('Apply change? [yNfq?]', 'y')
354
 
        shelver.expect('Apply 2 change(s)? [yNfq?]', 'n')
 
357
        shelver.expect('Apply change?', 0)
 
358
        shelver.expect('Apply change?', 0)
 
359
        shelver.expect('Apply 2 change(s)?', 1)
355
360
        shelver.run()
356
361
        self.assertFileEqual(LINES_ZY, 'tree/foo')
357
362
 
362
367
        shelver = ExpectShelver(tree, tree.basis_tree(),
363
368
                                reporter=shelf_ui.ApplyReporter())
364
369
        self.addCleanup(shelver.finalize)
365
 
        shelver.expect('Apply change? [yNfq?]', 'y')
366
 
        shelver.expect('Apply change? [yNfq?]', 'y')
367
 
        shelver.expect('Apply 2 change(s)? [yNfq?]', 'y')
 
370
        shelver.expect('Apply change?', 0)
 
371
        shelver.expect('Apply change?', 0)
 
372
        shelver.expect('Apply 2 change(s)?', 0)
368
373
        shelver.run()
369
374
        self.assertFileEqual(LINES_AJ, 'tree/foo')
370
375
 
376
381
        shelver = ExpectShelver(tree, tree.basis_tree(),
377
382
                                reporter=shelf_ui.ApplyReporter())
378
383
        self.addCleanup(shelver.finalize)
379
 
        shelver.expect('Apply binary changes? [yNfq?]', 'y')
380
 
        shelver.expect('Apply 1 change(s)? [yNfq?]', 'y')
 
384
        shelver.expect('Apply binary changes?', 0)
 
385
        shelver.expect('Apply 1 change(s)?', 0)
381
386
        shelver.run()
382
387
        self.assertFileEqual(LINES_AJ, 'tree/foo')
383
388
 
389
394
        shelver = ExpectShelver(tree, tree.basis_tree(),
390
395
                                reporter=shelf_ui.ApplyReporter())
391
396
        self.addCleanup(shelver.finalize)
392
 
        shelver.expect('Rename "bar" => "foo"? [yNfq?]', 'y')
393
 
        shelver.expect('Apply change? [yNfq?]', 'y')
394
 
        shelver.expect('Apply change? [yNfq?]', 'y')
395
 
        shelver.expect('Apply 3 change(s)? [yNfq?]', 'y')
 
397
        shelver.expect('Rename "bar" => "foo"?', 0)
 
398
        shelver.expect('Apply change?', 0)
 
399
        shelver.expect('Apply change?', 0)
 
400
        shelver.expect('Apply 3 change(s)?', 0)
396
401
        shelver.run()
397
402
        self.assertFileEqual(LINES_AJ, 'tree/foo')
398
403
 
404
409
        shelver = ExpectShelver(tree, tree.basis_tree(),
405
410
                                reporter=shelf_ui.ApplyReporter())
406
411
        self.addCleanup(shelver.finalize)
407
 
        shelver.expect('Add file "foo"? [yNfq?]', 'y')
408
 
        shelver.expect('Apply 1 change(s)? [yNfq?]', 'y')
 
412
        shelver.expect('Add file "foo"?', 0)
 
413
        shelver.expect('Apply 1 change(s)?', 0)
409
414
        shelver.run()
410
415
        self.assertFileEqual(LINES_AJ, 'tree/foo')
411
416
 
419
424
        shelver = ExpectShelver(tree, tree.basis_tree(),
420
425
                                reporter=shelf_ui.ApplyReporter())
421
426
        self.addCleanup(shelver.finalize)
422
 
        shelver.expect('Delete file "foo"? [yNfq?]', 'y')
423
 
        shelver.expect('Apply 1 change(s)? [yNfq?]', 'y')
 
427
        shelver.expect('Delete file "foo"?', 0)
 
428
        shelver.expect('Apply 1 change(s)?', 0)
424
429
        shelver.run()
425
 
        self.failIfExists('tree/foo')
 
430
        self.assertPathDoesNotExist('tree/foo')
426
431
 
427
432
    def test_shelve_kind_change(self):
428
433
        tree = self.create_shelvable_tree()
433
438
        shelver = ExpectShelver(tree, tree.basis_tree(),
434
439
                               reporter=shelf_ui.ApplyReporter())
435
440
        self.addCleanup(shelver.finalize)
436
 
        shelver.expect('Change "foo" from directory to a file? [yNfq?]', 'y')
437
 
        shelver.expect('Apply 1 change(s)? [yNfq?]', 'y')
 
441
        shelver.expect('Change "foo" from directory to a file?', 0)
 
442
        shelver.expect('Apply 1 change(s)?', 0)
438
443
 
439
444
    def test_shelve_modify_target(self):
440
 
        self.requireFeature(tests.SymlinkFeature)
 
445
        self.requireFeature(features.SymlinkFeature)
441
446
        tree = self.create_shelvable_tree()
442
447
        os.symlink('bar', 'tree/baz')
443
448
        tree.add('baz', 'baz-id')
449
454
        shelver = ExpectShelver(tree, tree.basis_tree(),
450
455
                                reporter=shelf_ui.ApplyReporter())
451
456
        self.addCleanup(shelver.finalize)
452
 
        shelver.expect('Change target of "baz" from "vax" to "bar"? [yNfq?]',
453
 
                       'y')
454
 
        shelver.expect('Apply 1 change(s)? [yNfq?]', 'y')
 
457
        shelver.expect('Change target of "baz" from "vax" to "bar"?',
 
458
                       0)
 
459
        shelver.expect('Apply 1 change(s)?', 0)
455
460
        shelver.run()
456
461
        self.assertEqual('bar', os.readlink('tree/baz'))
457
462