~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_config.py

  • Committer: Jelmer Vernooij
  • Date: 2011-12-16 19:18:39 UTC
  • mto: This revision was merged to the branch mainline in revision 6391.
  • Revision ID: jelmer@samba.org-20111216191839-eg681lxqibi1qxu1
Fix remaining tests.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
21
21
import sys
22
22
import threading
23
23
 
 
24
 
 
25
from testtools import matchers
 
26
 
24
27
#import bzrlib specific imports here
25
28
from bzrlib import (
26
29
    branch,
32
35
    mail_client,
33
36
    ui,
34
37
    urlutils,
 
38
    remote,
35
39
    tests,
36
40
    trace,
37
 
    transport,
38
 
    )
39
 
from bzrlib.tests import features
 
41
    )
 
42
from bzrlib.symbol_versioning import (
 
43
    deprecated_in,
 
44
    )
 
45
from bzrlib.transport import remote as transport_remote
 
46
from bzrlib.tests import (
 
47
    features,
 
48
    scenarios,
 
49
    test_server,
 
50
    )
40
51
from bzrlib.util.configobj import configobj
41
52
 
42
53
 
52
63
          'config_section': '.'}),]
53
64
 
54
65
 
55
 
def load_tests(standard_tests, module, loader):
56
 
    suite = loader.suiteClass()
57
 
 
58
 
    lc_tests, remaining_tests = tests.split_suite_by_condition(
59
 
        standard_tests, tests.condition_isinstance((
60
 
                TestLockableConfig,
61
 
                )))
62
 
    tests.multiply_tests(lc_tests, lockable_config_scenarios(), suite)
63
 
    suite.addTest(remaining_tests)
64
 
    return suite
 
66
load_tests = scenarios.load_tests_apply_scenarios
 
67
 
 
68
# Register helpers to build stores
 
69
config.test_store_builder_registry.register(
 
70
    'configobj', lambda test: config.TransportIniFileStore(
 
71
        test.get_transport(), 'configobj.conf'))
 
72
config.test_store_builder_registry.register(
 
73
    'bazaar', lambda test: config.GlobalStore())
 
74
config.test_store_builder_registry.register(
 
75
    'location', lambda test: config.LocationStore())
 
76
 
 
77
 
 
78
def build_backing_branch(test, relpath,
 
79
                         transport_class=None, server_class=None):
 
80
    """Test helper to create a backing branch only once.
 
81
 
 
82
    Some tests needs multiple stores/stacks to check concurrent update
 
83
    behaviours. As such, they need to build different branch *objects* even if
 
84
    they share the branch on disk.
 
85
 
 
86
    :param relpath: The relative path to the branch. (Note that the helper
 
87
        should always specify the same relpath).
 
88
 
 
89
    :param transport_class: The Transport class the test needs to use.
 
90
 
 
91
    :param server_class: The server associated with the ``transport_class``
 
92
        above.
 
93
 
 
94
    Either both or neither of ``transport_class`` and ``server_class`` should
 
95
    be specified.
 
96
    """
 
97
    if transport_class is not None and server_class is not None:
 
98
        test.transport_class = transport_class
 
99
        test.transport_server = server_class
 
100
    elif not (transport_class is None and server_class is None):
 
101
        raise AssertionError('Specify both ``transport_class`` and '
 
102
                             '``server_class`` or neither of them')
 
103
    if getattr(test, 'backing_branch', None) is None:
 
104
        # First call, let's build the branch on disk
 
105
        test.backing_branch = test.make_branch(relpath)
 
106
 
 
107
 
 
108
def build_branch_store(test):
 
109
    build_backing_branch(test, 'branch')
 
110
    b = branch.Branch.open('branch')
 
111
    return config.BranchStore(b)
 
112
config.test_store_builder_registry.register('branch', build_branch_store)
 
113
 
 
114
 
 
115
def build_control_store(test):
 
116
    build_backing_branch(test, 'branch')
 
117
    b = bzrdir.BzrDir.open('branch')
 
118
    return config.ControlStore(b)
 
119
config.test_store_builder_registry.register('control', build_control_store)
 
120
 
 
121
 
 
122
def build_remote_branch_store(test):
 
123
    # There is only one permutation (but we won't be able to handle more with
 
124
    # this design anyway)
 
125
    (transport_class,
 
126
     server_class) = transport_remote.get_test_permutations()[0]
 
127
    build_backing_branch(test, 'branch', transport_class, server_class)
 
128
    b = branch.Branch.open(test.get_url('branch'))
 
129
    return config.BranchStore(b)
 
130
config.test_store_builder_registry.register('remote_branch',
 
131
                                            build_remote_branch_store)
 
132
 
 
133
 
 
134
config.test_stack_builder_registry.register(
 
135
    'bazaar', lambda test: config.GlobalStack())
 
136
config.test_stack_builder_registry.register(
 
137
    'location', lambda test: config.LocationStack('.'))
 
138
 
 
139
 
 
140
def build_branch_stack(test):
 
141
    build_backing_branch(test, 'branch')
 
142
    b = branch.Branch.open('branch')
 
143
    return config.BranchStack(b)
 
144
config.test_stack_builder_registry.register('branch', build_branch_stack)
 
145
 
 
146
 
 
147
def build_remote_branch_stack(test):
 
148
    # There is only one permutation (but we won't be able to handle more with
 
149
    # this design anyway)
 
150
    (transport_class,
 
151
     server_class) = transport_remote.get_test_permutations()[0]
 
152
    build_backing_branch(test, 'branch', transport_class, server_class)
 
153
    b = branch.Branch.open(test.get_url('branch'))
 
154
    return config.RemoteBranchStack(b)
 
155
config.test_stack_builder_registry.register('remote_branch',
 
156
                                            build_remote_branch_stack)
 
157
 
 
158
def build_remote_control_stack(test):
 
159
    # There is only one permutation (but we won't be able to handle more with
 
160
    # this design anyway)
 
161
    (transport_class,
 
162
     server_class) = transport_remote.get_test_permutations()[0]
 
163
    # We need only a bzrdir for this, not a full branch, but it's not worth
 
164
    # creating a dedicated helper to create only the bzrdir
 
165
    build_backing_branch(test, 'branch', transport_class, server_class)
 
166
    b = branch.Branch.open(test.get_url('branch'))
 
167
    return config.RemoteControlStack(b.bzrdir)
 
168
config.test_stack_builder_registry.register('remote_control',
 
169
                                            build_remote_control_stack)
65
170
 
66
171
 
67
172
sample_long_alias="log -r-15..-1 --line"
71
176
editor=vim
72
177
change_editor=vimdiff -of @new_path @old_path
73
178
gpg_signing_command=gnome-gpg
 
179
gpg_signing_key=DD4D5088
74
180
log_format=short
 
181
validate_signatures_in_log=true
 
182
acceptable_keys=amy
75
183
user_global_option=something
 
184
bzr.mergetool.sometool=sometool {base} {this} {other} -o {result}
 
185
bzr.mergetool.funkytool=funkytool "arg with spaces" {this_temp}
 
186
bzr.mergetool.newtool='"newtool with spaces" {this_temp}'
 
187
bzr.default_mergetool=sometool
76
188
[ALIASES]
77
189
h=help
78
190
ll=""" + sample_long_alias + "\n"
120
232
[/a/]
121
233
check_signatures=check-available
122
234
gpg_signing_command=false
 
235
gpg_signing_key=default
123
236
user_local_option=local
124
237
# test trailing / matching
125
238
[/a/*]
131
244
"""
132
245
 
133
246
 
 
247
def create_configs(test):
 
248
    """Create configuration files for a given test.
 
249
 
 
250
    This requires creating a tree (and populate the ``test.tree`` attribute)
 
251
    and its associated branch and will populate the following attributes:
 
252
 
 
253
    - branch_config: A BranchConfig for the associated branch.
 
254
 
 
255
    - locations_config : A LocationConfig for the associated branch
 
256
 
 
257
    - bazaar_config: A GlobalConfig.
 
258
 
 
259
    The tree and branch are created in a 'tree' subdirectory so the tests can
 
260
    still use the test directory to stay outside of the branch.
 
261
    """
 
262
    tree = test.make_branch_and_tree('tree')
 
263
    test.tree = tree
 
264
    test.branch_config = config.BranchConfig(tree.branch)
 
265
    test.locations_config = config.LocationConfig(tree.basedir)
 
266
    test.bazaar_config = config.GlobalConfig()
 
267
 
 
268
 
 
269
def create_configs_with_file_option(test):
 
270
    """Create configuration files with a ``file`` option set in each.
 
271
 
 
272
    This builds on ``create_configs`` and add one ``file`` option in each
 
273
    configuration with a value which allows identifying the configuration file.
 
274
    """
 
275
    create_configs(test)
 
276
    test.bazaar_config.set_user_option('file', 'bazaar')
 
277
    test.locations_config.set_user_option('file', 'locations')
 
278
    test.branch_config.set_user_option('file', 'branch')
 
279
 
 
280
 
 
281
class TestOptionsMixin:
 
282
 
 
283
    def assertOptions(self, expected, conf):
 
284
        # We don't care about the parser (as it will make tests hard to write
 
285
        # and error-prone anyway)
 
286
        self.assertThat([opt[:4] for opt in conf._get_options()],
 
287
                        matchers.Equals(expected))
 
288
 
 
289
 
134
290
class InstrumentedConfigObj(object):
135
291
    """A config obj look-enough-alike to record calls made to it."""
136
292
 
172
328
 
173
329
class FakeBranch(object):
174
330
 
175
 
    def __init__(self, base=None, user_id=None):
 
331
    def __init__(self, base=None):
176
332
        if base is None:
177
333
            self.base = "http://example.com/branches/demo"
178
334
        else:
179
335
            self.base = base
180
336
        self._transport = self.control_files = \
181
 
            FakeControlFilesAndTransport(user_id=user_id)
 
337
            FakeControlFilesAndTransport()
182
338
 
183
339
    def _get_config(self):
184
340
        return config.TransportConfig(self._transport, 'branch.conf')
192
348
 
193
349
class FakeControlFilesAndTransport(object):
194
350
 
195
 
    def __init__(self, user_id=None):
 
351
    def __init__(self):
196
352
        self.files = {}
197
 
        if user_id:
198
 
            self.files['email'] = user_id
199
353
        self._transport = self
200
354
 
201
 
    def get_utf8(self, filename):
202
 
        # from LockableFiles
203
 
        raise AssertionError("get_utf8 should no longer be used")
204
 
 
205
355
    def get(self, filename):
206
356
        # from Transport
207
357
        try:
269
419
        """
270
420
        co = config.ConfigObj()
271
421
        co['test'] = 'foo#bar'
272
 
        lines = co.write()
 
422
        outfile = StringIO()
 
423
        co.write(outfile=outfile)
 
424
        lines = outfile.getvalue().splitlines()
273
425
        self.assertEqual(lines, ['test = "foo#bar"'])
274
426
        co2 = config.ConfigObj(lines)
275
427
        self.assertEqual(co2['test'], 'foo#bar')
276
428
 
 
429
    def test_triple_quotes(self):
 
430
        # Bug #710410: if the value string has triple quotes
 
431
        # then ConfigObj versions up to 4.7.2 will quote them wrong
 
432
        # and won't able to read them back
 
433
        triple_quotes_value = '''spam
 
434
""" that's my spam """
 
435
eggs'''
 
436
        co = config.ConfigObj()
 
437
        co['test'] = triple_quotes_value
 
438
        # While writing this test another bug in ConfigObj has been found:
 
439
        # method co.write() without arguments produces list of lines
 
440
        # one option per line, and multiline values are not split
 
441
        # across multiple lines,
 
442
        # and that breaks the parsing these lines back by ConfigObj.
 
443
        # This issue only affects test, but it's better to avoid
 
444
        # `co.write()` construct at all.
 
445
        # [bialix 20110222] bug report sent to ConfigObj's author
 
446
        outfile = StringIO()
 
447
        co.write(outfile=outfile)
 
448
        output = outfile.getvalue()
 
449
        # now we're trying to read it back
 
450
        co2 = config.ConfigObj(StringIO(output))
 
451
        self.assertEquals(triple_quotes_value, co2['test'])
 
452
 
277
453
 
278
454
erroneous_config = """[section] # line 1
279
455
good=good # line 2
300
476
        config.Config()
301
477
 
302
478
    def test_no_default_editor(self):
303
 
        self.assertRaises(NotImplementedError, config.Config().get_editor)
 
479
        self.assertRaises(
 
480
            NotImplementedError,
 
481
            self.applyDeprecated, deprecated_in((2, 4, 0)),
 
482
            config.Config().get_editor)
304
483
 
305
484
    def test_user_email(self):
306
485
        my_config = InstrumentedConfig()
315
494
 
316
495
    def test_signatures_default(self):
317
496
        my_config = config.Config()
318
 
        self.assertFalse(my_config.signature_needed())
 
497
        self.assertFalse(
 
498
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
499
                my_config.signature_needed))
319
500
        self.assertEqual(config.CHECK_IF_POSSIBLE,
320
 
                         my_config.signature_checking())
 
501
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
502
                my_config.signature_checking))
321
503
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
322
 
                         my_config.signing_policy())
 
504
                self.applyDeprecated(deprecated_in((2, 5, 0)),
 
505
                    my_config.signing_policy))
323
506
 
324
507
    def test_signatures_template_method(self):
325
508
        my_config = InstrumentedConfig()
326
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
 
509
        self.assertEqual(config.CHECK_NEVER,
 
510
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
511
                my_config.signature_checking))
327
512
        self.assertEqual(['_get_signature_checking'], my_config._calls)
328
513
 
329
514
    def test_signatures_template_method_none(self):
330
515
        my_config = InstrumentedConfig()
331
516
        my_config._signatures = None
332
517
        self.assertEqual(config.CHECK_IF_POSSIBLE,
333
 
                         my_config.signature_checking())
 
518
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
519
                             my_config.signature_checking))
334
520
        self.assertEqual(['_get_signature_checking'], my_config._calls)
335
521
 
336
522
    def test_gpg_signing_command_default(self):
337
523
        my_config = config.Config()
338
 
        self.assertEqual('gpg', my_config.gpg_signing_command())
 
524
        self.assertEqual('gpg',
 
525
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
526
                my_config.gpg_signing_command))
339
527
 
340
528
    def test_get_user_option_default(self):
341
529
        my_config = config.Config()
343
531
 
344
532
    def test_post_commit_default(self):
345
533
        my_config = config.Config()
346
 
        self.assertEqual(None, my_config.post_commit())
 
534
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
535
                                                    my_config.post_commit))
 
536
 
347
537
 
348
538
    def test_log_format_default(self):
349
539
        my_config = config.Config()
350
540
        self.assertEqual('long', my_config.log_format())
351
541
 
 
542
    def test_acceptable_keys_default(self):
 
543
        my_config = config.Config()
 
544
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
545
            my_config.acceptable_keys))
 
546
 
 
547
    def test_validate_signatures_in_log_default(self):
 
548
        my_config = config.Config()
 
549
        self.assertEqual(False, my_config.validate_signatures_in_log())
 
550
 
352
551
    def test_get_change_editor(self):
353
552
        my_config = InstrumentedConfig()
354
553
        change_editor = my_config.get_change_editor('old_tree', 'new_tree')
362
561
 
363
562
    def setUp(self):
364
563
        super(TestConfigPath, self).setUp()
365
 
        os.environ['HOME'] = '/home/bogus'
366
 
        os.environ['XDG_CACHE_DIR'] = ''
 
564
        self.overrideEnv('HOME', '/home/bogus')
 
565
        self.overrideEnv('XDG_CACHE_DIR', '')
367
566
        if sys.platform == 'win32':
368
 
            os.environ['BZR_HOME'] = \
369
 
                r'C:\Documents and Settings\bogus\Application Data'
 
567
            self.overrideEnv(
 
568
                'BZR_HOME', r'C:\Documents and Settings\bogus\Application Data')
370
569
            self.bzr_home = \
371
570
                'C:/Documents and Settings/bogus/Application Data/bazaar/2.0'
372
571
        else:
392
591
            '/home/bogus/.cache')
393
592
 
394
593
 
 
594
class TestXDGConfigDir(tests.TestCaseInTempDir):
 
595
    # must be in temp dir because config tests for the existence of the bazaar
 
596
    # subdirectory of $XDG_CONFIG_HOME
 
597
 
 
598
    def setUp(self):
 
599
        if sys.platform in ('darwin', 'win32'):
 
600
            raise tests.TestNotApplicable(
 
601
                'XDG config dir not used on this platform')
 
602
        super(TestXDGConfigDir, self).setUp()
 
603
        self.overrideEnv('HOME', self.test_home_dir)
 
604
        # BZR_HOME overrides everything we want to test so unset it.
 
605
        self.overrideEnv('BZR_HOME', None)
 
606
 
 
607
    def test_xdg_config_dir_exists(self):
 
608
        """When ~/.config/bazaar exists, use it as the config dir."""
 
609
        newdir = osutils.pathjoin(self.test_home_dir, '.config', 'bazaar')
 
610
        os.makedirs(newdir)
 
611
        self.assertEqual(config.config_dir(), newdir)
 
612
 
 
613
    def test_xdg_config_home(self):
 
614
        """When XDG_CONFIG_HOME is set, use it."""
 
615
        xdgconfigdir = osutils.pathjoin(self.test_home_dir, 'xdgconfig')
 
616
        self.overrideEnv('XDG_CONFIG_HOME', xdgconfigdir)
 
617
        newdir = osutils.pathjoin(xdgconfigdir, 'bazaar')
 
618
        os.makedirs(newdir)
 
619
        self.assertEqual(config.config_dir(), newdir)
 
620
 
 
621
 
395
622
class TestIniConfig(tests.TestCaseInTempDir):
396
623
 
397
624
    def make_config_parser(self, s):
411
638
    def test_cached(self):
412
639
        my_config = config.IniBasedConfig.from_string(sample_config_text)
413
640
        parser = my_config._get_parser()
414
 
        self.failUnless(my_config._get_parser() is parser)
 
641
        self.assertTrue(my_config._get_parser() is parser)
415
642
 
416
643
    def _dummy_chown(self, path, uid, gid):
417
644
        self.path, self.uid, self.gid = path, uid, gid
442
669
            ' Use IniBasedConfig(_content=xxx) instead.'],
443
670
            conf._get_parser, file=config_file)
444
671
 
 
672
 
445
673
class TestIniConfigSaving(tests.TestCaseInTempDir):
446
674
 
447
675
    def test_cant_save_without_a_file_name(self):
455
683
        self.assertFileEqual(content, 'test.conf')
456
684
 
457
685
 
 
686
class TestIniConfigOptionExpansionDefaultValue(tests.TestCaseInTempDir):
 
687
    """What is the default value of expand for config options.
 
688
 
 
689
    This is an opt-in beta feature used to evaluate whether or not option
 
690
    references can appear in dangerous place raising exceptions, disapearing
 
691
    (and as such corrupting data) or if it's safe to activate the option by
 
692
    default.
 
693
 
 
694
    Note that these tests relies on config._expand_default_value being already
 
695
    overwritten in the parent class setUp.
 
696
    """
 
697
 
 
698
    def setUp(self):
 
699
        super(TestIniConfigOptionExpansionDefaultValue, self).setUp()
 
700
        self.config = None
 
701
        self.warnings = []
 
702
        def warning(*args):
 
703
            self.warnings.append(args[0] % args[1:])
 
704
        self.overrideAttr(trace, 'warning', warning)
 
705
 
 
706
    def get_config(self, expand):
 
707
        c = config.GlobalConfig.from_string('bzr.config.expand=%s' % (expand,),
 
708
                                            save=True)
 
709
        return c
 
710
 
 
711
    def assertExpandIs(self, expected):
 
712
        actual = config._get_expand_default_value()
 
713
        #self.config.get_user_option_as_bool('bzr.config.expand')
 
714
        self.assertEquals(expected, actual)
 
715
 
 
716
    def test_default_is_None(self):
 
717
        self.assertEquals(None, config._expand_default_value)
 
718
 
 
719
    def test_default_is_False_even_if_None(self):
 
720
        self.config = self.get_config(None)
 
721
        self.assertExpandIs(False)
 
722
 
 
723
    def test_default_is_False_even_if_invalid(self):
 
724
        self.config = self.get_config('<your choice>')
 
725
        self.assertExpandIs(False)
 
726
        # ...
 
727
        # Huh ? My choice is False ? Thanks, always happy to hear that :D
 
728
        # Wait, you've been warned !
 
729
        self.assertLength(1, self.warnings)
 
730
        self.assertEquals(
 
731
            'Value "<your choice>" is not a boolean for "bzr.config.expand"',
 
732
            self.warnings[0])
 
733
 
 
734
    def test_default_is_True(self):
 
735
        self.config = self.get_config(True)
 
736
        self.assertExpandIs(True)
 
737
 
 
738
    def test_default_is_False(self):
 
739
        self.config = self.get_config(False)
 
740
        self.assertExpandIs(False)
 
741
 
 
742
 
 
743
class TestIniConfigOptionExpansion(tests.TestCase):
 
744
    """Test option expansion from the IniConfig level.
 
745
 
 
746
    What we really want here is to test the Config level, but the class being
 
747
    abstract as far as storing values is concerned, this can't be done
 
748
    properly (yet).
 
749
    """
 
750
    # FIXME: This should be rewritten when all configs share a storage
 
751
    # implementation -- vila 2011-02-18
 
752
 
 
753
    def get_config(self, string=None):
 
754
        if string is None:
 
755
            string = ''
 
756
        c = config.IniBasedConfig.from_string(string)
 
757
        return c
 
758
 
 
759
    def assertExpansion(self, expected, conf, string, env=None):
 
760
        self.assertEquals(expected, conf.expand_options(string, env))
 
761
 
 
762
    def test_no_expansion(self):
 
763
        c = self.get_config('')
 
764
        self.assertExpansion('foo', c, 'foo')
 
765
 
 
766
    def test_env_adding_options(self):
 
767
        c = self.get_config('')
 
768
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
 
769
 
 
770
    def test_env_overriding_options(self):
 
771
        c = self.get_config('foo=baz')
 
772
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
 
773
 
 
774
    def test_simple_ref(self):
 
775
        c = self.get_config('foo=xxx')
 
776
        self.assertExpansion('xxx', c, '{foo}')
 
777
 
 
778
    def test_unknown_ref(self):
 
779
        c = self.get_config('')
 
780
        self.assertRaises(errors.ExpandingUnknownOption,
 
781
                          c.expand_options, '{foo}')
 
782
 
 
783
    def test_indirect_ref(self):
 
784
        c = self.get_config('''
 
785
foo=xxx
 
786
bar={foo}
 
787
''')
 
788
        self.assertExpansion('xxx', c, '{bar}')
 
789
 
 
790
    def test_embedded_ref(self):
 
791
        c = self.get_config('''
 
792
foo=xxx
 
793
bar=foo
 
794
''')
 
795
        self.assertExpansion('xxx', c, '{{bar}}')
 
796
 
 
797
    def test_simple_loop(self):
 
798
        c = self.get_config('foo={foo}')
 
799
        self.assertRaises(errors.OptionExpansionLoop, c.expand_options, '{foo}')
 
800
 
 
801
    def test_indirect_loop(self):
 
802
        c = self.get_config('''
 
803
foo={bar}
 
804
bar={baz}
 
805
baz={foo}''')
 
806
        e = self.assertRaises(errors.OptionExpansionLoop,
 
807
                              c.expand_options, '{foo}')
 
808
        self.assertEquals('foo->bar->baz', e.refs)
 
809
        self.assertEquals('{foo}', e.string)
 
810
 
 
811
    def test_list(self):
 
812
        conf = self.get_config('''
 
813
foo=start
 
814
bar=middle
 
815
baz=end
 
816
list={foo},{bar},{baz}
 
817
''')
 
818
        self.assertEquals(['start', 'middle', 'end'],
 
819
                           conf.get_user_option('list', expand=True))
 
820
 
 
821
    def test_cascading_list(self):
 
822
        conf = self.get_config('''
 
823
foo=start,{bar}
 
824
bar=middle,{baz}
 
825
baz=end
 
826
list={foo}
 
827
''')
 
828
        self.assertEquals(['start', 'middle', 'end'],
 
829
                           conf.get_user_option('list', expand=True))
 
830
 
 
831
    def test_pathological_hidden_list(self):
 
832
        conf = self.get_config('''
 
833
foo=bin
 
834
bar=go
 
835
start={foo
 
836
middle=},{
 
837
end=bar}
 
838
hidden={start}{middle}{end}
 
839
''')
 
840
        # Nope, it's either a string or a list, and the list wins as soon as a
 
841
        # ',' appears, so the string concatenation never occur.
 
842
        self.assertEquals(['{foo', '}', '{', 'bar}'],
 
843
                          conf.get_user_option('hidden', expand=True))
 
844
 
 
845
 
 
846
class TestLocationConfigOptionExpansion(tests.TestCaseInTempDir):
 
847
 
 
848
    def get_config(self, location, string=None):
 
849
        if string is None:
 
850
            string = ''
 
851
        # Since we don't save the config we won't strictly require to inherit
 
852
        # from TestCaseInTempDir, but an error occurs so quickly...
 
853
        c = config.LocationConfig.from_string(string, location)
 
854
        return c
 
855
 
 
856
    def test_dont_cross_unrelated_section(self):
 
857
        c = self.get_config('/another/branch/path','''
 
858
[/one/branch/path]
 
859
foo = hello
 
860
bar = {foo}/2
 
861
 
 
862
[/another/branch/path]
 
863
bar = {foo}/2
 
864
''')
 
865
        self.assertRaises(errors.ExpandingUnknownOption,
 
866
                          c.get_user_option, 'bar', expand=True)
 
867
 
 
868
    def test_cross_related_sections(self):
 
869
        c = self.get_config('/project/branch/path','''
 
870
[/project]
 
871
foo = qu
 
872
 
 
873
[/project/branch/path]
 
874
bar = {foo}ux
 
875
''')
 
876
        self.assertEquals('quux', c.get_user_option('bar', expand=True))
 
877
 
 
878
 
458
879
class TestIniBaseConfigOnDisk(tests.TestCaseInTempDir):
459
880
 
460
881
    def test_cannot_reload_without_name(self):
477
898
 
478
899
class TestLockableConfig(tests.TestCaseInTempDir):
479
900
 
 
901
    scenarios = lockable_config_scenarios()
 
902
 
480
903
    # Set by load_tests
481
904
    config_class = None
482
905
    config_args = None
538
961
        def c1_write_config_file():
539
962
            before_writing.set()
540
963
            c1_orig()
541
 
            # The lock is held we wait for the main thread to decide when to
 
964
            # The lock is held. We wait for the main thread to decide when to
542
965
            # continue
543
966
            after_writing.wait()
544
967
        c1._write_config_file = c1_write_config_file
571
994
       c1_orig = c1._write_config_file
572
995
       def c1_write_config_file():
573
996
           ready_to_write.set()
574
 
           # The lock is held we wait for the main thread to decide when to
 
997
           # The lock is held. We wait for the main thread to decide when to
575
998
           # continue
576
999
           do_writing.wait()
577
1000
           c1_orig()
636
1059
        # automatically cast to list
637
1060
        self.assertEqual(['x'], get_list('one_item'))
638
1061
 
 
1062
    def test_get_user_option_as_int_from_SI(self):
 
1063
        conf, parser = self.make_config_parser("""
 
1064
plain = 100
 
1065
si_k = 5k,
 
1066
si_kb = 5kb,
 
1067
si_m = 5M,
 
1068
si_mb = 5MB,
 
1069
si_g = 5g,
 
1070
si_gb = 5gB,
 
1071
""")
 
1072
        get_si = conf.get_user_option_as_int_from_SI
 
1073
        self.assertEqual(100, get_si('plain'))
 
1074
        self.assertEqual(5000, get_si('si_k'))
 
1075
        self.assertEqual(5000, get_si('si_kb'))
 
1076
        self.assertEqual(5000000, get_si('si_m'))
 
1077
        self.assertEqual(5000000, get_si('si_mb'))
 
1078
        self.assertEqual(5000000000, get_si('si_g'))
 
1079
        self.assertEqual(5000000000, get_si('si_gb'))
 
1080
        self.assertEqual(None, get_si('non-exist'))
 
1081
        self.assertEqual(42, get_si('non-exist-with-default',  42))
639
1082
 
640
1083
class TestSupressWarning(TestIniConfig):
641
1084
 
668
1111
            parser = my_config._get_parser()
669
1112
        finally:
670
1113
            config.ConfigObj = oldparserclass
671
 
        self.failUnless(isinstance(parser, InstrumentedConfigObj))
 
1114
        self.assertIsInstance(parser, InstrumentedConfigObj)
672
1115
        self.assertEqual(parser._calls, [('__init__', config.config_filename(),
673
1116
                                          'utf-8')])
674
1117
 
685
1128
        my_config = config.BranchConfig(branch)
686
1129
        location_config = my_config._get_location_config()
687
1130
        self.assertEqual(branch.base, location_config.location)
688
 
        self.failUnless(location_config is my_config._get_location_config())
 
1131
        self.assertIs(location_config, my_config._get_location_config())
689
1132
 
690
1133
    def test_get_config(self):
691
1134
        """The Branch.get_config method works properly"""
791
1234
 
792
1235
    def test_configured_editor(self):
793
1236
        my_config = config.GlobalConfig.from_string(sample_config_text)
794
 
        self.assertEqual("vim", my_config.get_editor())
 
1237
        editor = self.applyDeprecated(
 
1238
            deprecated_in((2, 4, 0)), my_config.get_editor)
 
1239
        self.assertEqual('vim', editor)
795
1240
 
796
1241
    def test_signatures_always(self):
797
1242
        my_config = config.GlobalConfig.from_string(sample_always_signatures)
798
1243
        self.assertEqual(config.CHECK_NEVER,
799
 
                         my_config.signature_checking())
 
1244
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1245
                             my_config.signature_checking))
800
1246
        self.assertEqual(config.SIGN_ALWAYS,
801
 
                         my_config.signing_policy())
802
 
        self.assertEqual(True, my_config.signature_needed())
 
1247
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1248
                             my_config.signing_policy))
 
1249
        self.assertEqual(True,
 
1250
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1251
                my_config.signature_needed))
803
1252
 
804
1253
    def test_signatures_if_possible(self):
805
1254
        my_config = config.GlobalConfig.from_string(sample_maybe_signatures)
806
1255
        self.assertEqual(config.CHECK_NEVER,
807
 
                         my_config.signature_checking())
 
1256
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1257
                             my_config.signature_checking))
808
1258
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
809
 
                         my_config.signing_policy())
810
 
        self.assertEqual(False, my_config.signature_needed())
 
1259
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1260
                             my_config.signing_policy))
 
1261
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1262
            my_config.signature_needed))
811
1263
 
812
1264
    def test_signatures_ignore(self):
813
1265
        my_config = config.GlobalConfig.from_string(sample_ignore_signatures)
814
1266
        self.assertEqual(config.CHECK_ALWAYS,
815
 
                         my_config.signature_checking())
 
1267
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1268
                             my_config.signature_checking))
816
1269
        self.assertEqual(config.SIGN_NEVER,
817
 
                         my_config.signing_policy())
818
 
        self.assertEqual(False, my_config.signature_needed())
 
1270
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1271
                             my_config.signing_policy))
 
1272
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1273
            my_config.signature_needed))
819
1274
 
820
1275
    def _get_sample_config(self):
821
1276
        my_config = config.GlobalConfig.from_string(sample_config_text)
823
1278
 
824
1279
    def test_gpg_signing_command(self):
825
1280
        my_config = self._get_sample_config()
826
 
        self.assertEqual("gnome-gpg", my_config.gpg_signing_command())
827
 
        self.assertEqual(False, my_config.signature_needed())
 
1281
        self.assertEqual("gnome-gpg",
 
1282
            self.applyDeprecated(
 
1283
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
 
1284
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1285
            my_config.signature_needed))
 
1286
 
 
1287
    def test_gpg_signing_key(self):
 
1288
        my_config = self._get_sample_config()
 
1289
        self.assertEqual("DD4D5088",
 
1290
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1291
                my_config.gpg_signing_key))
828
1292
 
829
1293
    def _get_empty_config(self):
830
1294
        my_config = config.GlobalConfig()
832
1296
 
833
1297
    def test_gpg_signing_command_unset(self):
834
1298
        my_config = self._get_empty_config()
835
 
        self.assertEqual("gpg", my_config.gpg_signing_command())
 
1299
        self.assertEqual("gpg",
 
1300
            self.applyDeprecated(
 
1301
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
836
1302
 
837
1303
    def test_get_user_option_default(self):
838
1304
        my_config = self._get_empty_config()
845
1311
 
846
1312
    def test_post_commit_default(self):
847
1313
        my_config = self._get_sample_config()
848
 
        self.assertEqual(None, my_config.post_commit())
 
1314
        self.assertEqual(None,
 
1315
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1316
                                              my_config.post_commit))
849
1317
 
850
1318
    def test_configured_logformat(self):
851
1319
        my_config = self._get_sample_config()
852
1320
        self.assertEqual("short", my_config.log_format())
853
1321
 
 
1322
    def test_configured_acceptable_keys(self):
 
1323
        my_config = self._get_sample_config()
 
1324
        self.assertEqual("amy",
 
1325
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1326
                my_config.acceptable_keys))
 
1327
 
 
1328
    def test_configured_validate_signatures_in_log(self):
 
1329
        my_config = self._get_sample_config()
 
1330
        self.assertEqual(True, my_config.validate_signatures_in_log())
 
1331
 
854
1332
    def test_get_alias(self):
855
1333
        my_config = self._get_sample_config()
856
1334
        self.assertEqual('help', my_config.get_alias('h'))
883
1361
        change_editor = my_config.get_change_editor('old', 'new')
884
1362
        self.assertIs(None, change_editor)
885
1363
 
 
1364
    def test_get_merge_tools(self):
 
1365
        conf = self._get_sample_config()
 
1366
        tools = conf.get_merge_tools()
 
1367
        self.log(repr(tools))
 
1368
        self.assertEqual(
 
1369
            {u'funkytool' : u'funkytool "arg with spaces" {this_temp}',
 
1370
            u'sometool' : u'sometool {base} {this} {other} -o {result}',
 
1371
            u'newtool' : u'"newtool with spaces" {this_temp}'},
 
1372
            tools)
 
1373
 
 
1374
    def test_get_merge_tools_empty(self):
 
1375
        conf = self._get_empty_config()
 
1376
        tools = conf.get_merge_tools()
 
1377
        self.assertEqual({}, tools)
 
1378
 
 
1379
    def test_find_merge_tool(self):
 
1380
        conf = self._get_sample_config()
 
1381
        cmdline = conf.find_merge_tool('sometool')
 
1382
        self.assertEqual('sometool {base} {this} {other} -o {result}', cmdline)
 
1383
 
 
1384
    def test_find_merge_tool_not_found(self):
 
1385
        conf = self._get_sample_config()
 
1386
        cmdline = conf.find_merge_tool('DOES NOT EXIST')
 
1387
        self.assertIs(cmdline, None)
 
1388
 
 
1389
    def test_find_merge_tool_known(self):
 
1390
        conf = self._get_empty_config()
 
1391
        cmdline = conf.find_merge_tool('kdiff3')
 
1392
        self.assertEquals('kdiff3 {base} {this} {other} -o {result}', cmdline)
 
1393
 
 
1394
    def test_find_merge_tool_override_known(self):
 
1395
        conf = self._get_empty_config()
 
1396
        conf.set_user_option('bzr.mergetool.kdiff3', 'kdiff3 blah')
 
1397
        cmdline = conf.find_merge_tool('kdiff3')
 
1398
        self.assertEqual('kdiff3 blah', cmdline)
 
1399
 
886
1400
 
887
1401
class TestGlobalConfigSavingOptions(tests.TestCaseInTempDir):
888
1402
 
906
1420
        self.assertIs(None, new_config.get_alias('commit'))
907
1421
 
908
1422
 
909
 
class TestLocationConfig(tests.TestCaseInTempDir):
 
1423
class TestLocationConfig(tests.TestCaseInTempDir, TestOptionsMixin):
910
1424
 
911
1425
    def test_constructs(self):
912
1426
        my_config = config.LocationConfig('http://example.com')
924
1438
            parser = my_config._get_parser()
925
1439
        finally:
926
1440
            config.ConfigObj = oldparserclass
927
 
        self.failUnless(isinstance(parser, InstrumentedConfigObj))
 
1441
        self.assertIsInstance(parser, InstrumentedConfigObj)
928
1442
        self.assertEqual(parser._calls,
929
1443
                         [('__init__', config.locations_config_filename(),
930
1444
                           'utf-8')])
932
1446
    def test_get_global_config(self):
933
1447
        my_config = config.BranchConfig(FakeBranch('http://example.com'))
934
1448
        global_config = my_config._get_global_config()
935
 
        self.failUnless(isinstance(global_config, config.GlobalConfig))
936
 
        self.failUnless(global_config is my_config._get_global_config())
 
1449
        self.assertIsInstance(global_config, config.GlobalConfig)
 
1450
        self.assertIs(global_config, my_config._get_global_config())
 
1451
 
 
1452
    def assertLocationMatching(self, expected):
 
1453
        self.assertEqual(expected,
 
1454
                         list(self.my_location_config._get_matching_sections()))
937
1455
 
938
1456
    def test__get_matching_sections_no_match(self):
939
1457
        self.get_branch_config('/')
940
 
        self.assertEqual([], self.my_location_config._get_matching_sections())
 
1458
        self.assertLocationMatching([])
941
1459
 
942
1460
    def test__get_matching_sections_exact(self):
943
1461
        self.get_branch_config('http://www.example.com')
944
 
        self.assertEqual([('http://www.example.com', '')],
945
 
                         self.my_location_config._get_matching_sections())
 
1462
        self.assertLocationMatching([('http://www.example.com', '')])
946
1463
 
947
1464
    def test__get_matching_sections_suffix_does_not(self):
948
1465
        self.get_branch_config('http://www.example.com-com')
949
 
        self.assertEqual([], self.my_location_config._get_matching_sections())
 
1466
        self.assertLocationMatching([])
950
1467
 
951
1468
    def test__get_matching_sections_subdir_recursive(self):
952
1469
        self.get_branch_config('http://www.example.com/com')
953
 
        self.assertEqual([('http://www.example.com', 'com')],
954
 
                         self.my_location_config._get_matching_sections())
 
1470
        self.assertLocationMatching([('http://www.example.com', 'com')])
955
1471
 
956
1472
    def test__get_matching_sections_ignoreparent(self):
957
1473
        self.get_branch_config('http://www.example.com/ignoreparent')
958
 
        self.assertEqual([('http://www.example.com/ignoreparent', '')],
959
 
                         self.my_location_config._get_matching_sections())
 
1474
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
 
1475
                                      '')])
960
1476
 
961
1477
    def test__get_matching_sections_ignoreparent_subdir(self):
962
1478
        self.get_branch_config(
963
1479
            'http://www.example.com/ignoreparent/childbranch')
964
 
        self.assertEqual([('http://www.example.com/ignoreparent',
965
 
                           'childbranch')],
966
 
                         self.my_location_config._get_matching_sections())
 
1480
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
 
1481
                                      'childbranch')])
967
1482
 
968
1483
    def test__get_matching_sections_subdir_trailing_slash(self):
969
1484
        self.get_branch_config('/b')
970
 
        self.assertEqual([('/b/', '')],
971
 
                         self.my_location_config._get_matching_sections())
 
1485
        self.assertLocationMatching([('/b/', '')])
972
1486
 
973
1487
    def test__get_matching_sections_subdir_child(self):
974
1488
        self.get_branch_config('/a/foo')
975
 
        self.assertEqual([('/a/*', ''), ('/a/', 'foo')],
976
 
                         self.my_location_config._get_matching_sections())
 
1489
        self.assertLocationMatching([('/a/*', ''), ('/a/', 'foo')])
977
1490
 
978
1491
    def test__get_matching_sections_subdir_child_child(self):
979
1492
        self.get_branch_config('/a/foo/bar')
980
 
        self.assertEqual([('/a/*', 'bar'), ('/a/', 'foo/bar')],
981
 
                         self.my_location_config._get_matching_sections())
 
1493
        self.assertLocationMatching([('/a/*', 'bar'), ('/a/', 'foo/bar')])
982
1494
 
983
1495
    def test__get_matching_sections_trailing_slash_with_children(self):
984
1496
        self.get_branch_config('/a/')
985
 
        self.assertEqual([('/a/', '')],
986
 
                         self.my_location_config._get_matching_sections())
 
1497
        self.assertLocationMatching([('/a/', '')])
987
1498
 
988
1499
    def test__get_matching_sections_explicit_over_glob(self):
989
1500
        # XXX: 2006-09-08 jamesh
991
1502
        # was a config section for '/a/?', it would get precedence
992
1503
        # over '/a/c'.
993
1504
        self.get_branch_config('/a/c')
994
 
        self.assertEqual([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')],
995
 
                         self.my_location_config._get_matching_sections())
 
1505
        self.assertLocationMatching([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')])
996
1506
 
997
1507
    def test__get_option_policy_normal(self):
998
1508
        self.get_branch_config('http://www.example.com')
1020
1530
            'http://www.example.com', 'appendpath_option'),
1021
1531
            config.POLICY_APPENDPATH)
1022
1532
 
 
1533
    def test__get_options_with_policy(self):
 
1534
        self.get_branch_config('/dir/subdir',
 
1535
                               location_config="""\
 
1536
[/dir]
 
1537
other_url = /other-dir
 
1538
other_url:policy = appendpath
 
1539
[/dir/subdir]
 
1540
other_url = /other-subdir
 
1541
""")
 
1542
        self.assertOptions(
 
1543
            [(u'other_url', u'/other-subdir', u'/dir/subdir', 'locations'),
 
1544
             (u'other_url', u'/other-dir', u'/dir', 'locations'),
 
1545
             (u'other_url:policy', u'appendpath', u'/dir', 'locations')],
 
1546
            self.my_location_config)
 
1547
 
1023
1548
    def test_location_without_username(self):
1024
1549
        self.get_branch_config('http://www.example.com/ignoreparent')
1025
1550
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
1040
1565
        self.get_branch_config('http://www.example.com',
1041
1566
                                 global_config=sample_ignore_signatures)
1042
1567
        self.assertEqual(config.CHECK_ALWAYS,
1043
 
                         self.my_config.signature_checking())
 
1568
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1569
                             self.my_config.signature_checking))
1044
1570
        self.assertEqual(config.SIGN_NEVER,
1045
 
                         self.my_config.signing_policy())
 
1571
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1572
                             self.my_config.signing_policy))
1046
1573
 
1047
1574
    def test_signatures_never(self):
1048
1575
        self.get_branch_config('/a/c')
1049
1576
        self.assertEqual(config.CHECK_NEVER,
1050
 
                         self.my_config.signature_checking())
 
1577
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1578
                             self.my_config.signature_checking))
1051
1579
 
1052
1580
    def test_signatures_when_available(self):
1053
1581
        self.get_branch_config('/a/', global_config=sample_ignore_signatures)
1054
1582
        self.assertEqual(config.CHECK_IF_POSSIBLE,
1055
 
                         self.my_config.signature_checking())
 
1583
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1584
                             self.my_config.signature_checking))
1056
1585
 
1057
1586
    def test_signatures_always(self):
1058
1587
        self.get_branch_config('/b')
1059
1588
        self.assertEqual(config.CHECK_ALWAYS,
1060
 
                         self.my_config.signature_checking())
 
1589
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1590
                         self.my_config.signature_checking))
1061
1591
 
1062
1592
    def test_gpg_signing_command(self):
1063
1593
        self.get_branch_config('/b')
1064
 
        self.assertEqual("gnome-gpg", self.my_config.gpg_signing_command())
 
1594
        self.assertEqual("gnome-gpg",
 
1595
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1596
                self.my_config.gpg_signing_command))
1065
1597
 
1066
1598
    def test_gpg_signing_command_missing(self):
1067
1599
        self.get_branch_config('/a')
1068
 
        self.assertEqual("false", self.my_config.gpg_signing_command())
 
1600
        self.assertEqual("false",
 
1601
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1602
                self.my_config.gpg_signing_command))
 
1603
 
 
1604
    def test_gpg_signing_key(self):
 
1605
        self.get_branch_config('/b')
 
1606
        self.assertEqual("DD4D5088", self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1607
            self.my_config.gpg_signing_key))
 
1608
 
 
1609
    def test_gpg_signing_key_default(self):
 
1610
        self.get_branch_config('/a')
 
1611
        self.assertEqual("erik@bagfors.nu",
 
1612
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1613
                self.my_config.gpg_signing_key))
1069
1614
 
1070
1615
    def test_get_user_option_global(self):
1071
1616
        self.get_branch_config('/a')
1159
1704
    def test_post_commit_default(self):
1160
1705
        self.get_branch_config('/a/c')
1161
1706
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1162
 
                         self.my_config.post_commit())
 
1707
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1708
                                              self.my_config.post_commit))
1163
1709
 
1164
 
    def get_branch_config(self, location, global_config=None):
 
1710
    def get_branch_config(self, location, global_config=None,
 
1711
                          location_config=None):
1165
1712
        my_branch = FakeBranch(location)
1166
1713
        if global_config is None:
1167
1714
            global_config = sample_config_text
 
1715
        if location_config is None:
 
1716
            location_config = sample_branches_text
1168
1717
 
1169
1718
        my_global_config = config.GlobalConfig.from_string(global_config,
1170
1719
                                                           save=True)
1171
1720
        my_location_config = config.LocationConfig.from_string(
1172
 
            sample_branches_text, my_branch.base, save=True)
 
1721
            location_config, my_branch.base, save=True)
1173
1722
        my_config = config.BranchConfig(my_branch)
1174
1723
        self.my_config = my_config
1175
1724
        self.my_location_config = my_config._get_location_config()
1220
1769
        self.assertEqual('bzr', my_config.get_bzr_remote_path())
1221
1770
        my_config.set_user_option('bzr_remote_path', '/path-bzr')
1222
1771
        self.assertEqual('/path-bzr', my_config.get_bzr_remote_path())
1223
 
        os.environ['BZR_REMOTE_PATH'] = '/environ-bzr'
 
1772
        self.overrideEnv('BZR_REMOTE_PATH', '/environ-bzr')
1224
1773
        self.assertEqual('/environ-bzr', my_config.get_bzr_remote_path())
1225
1774
 
1226
1775
 
1252
1801
        return my_config
1253
1802
 
1254
1803
    def test_user_id(self):
1255
 
        branch = FakeBranch(user_id='Robert Collins <robertc@example.net>')
 
1804
        branch = FakeBranch()
1256
1805
        my_config = config.BranchConfig(branch)
1257
 
        self.assertEqual("Robert Collins <robertc@example.net>",
1258
 
                         my_config.username())
 
1806
        self.assertIsNot(None, my_config.username())
1259
1807
        my_config.branch.control_files.files['email'] = "John"
1260
1808
        my_config.set_user_option('email',
1261
1809
                                  "Robert Collins <robertc@example.org>")
1262
 
        self.assertEqual("John", my_config.username())
1263
 
        del my_config.branch.control_files.files['email']
1264
1810
        self.assertEqual("Robert Collins <robertc@example.org>",
1265
 
                         my_config.username())
1266
 
 
1267
 
    def test_not_set_in_branch(self):
1268
 
        my_config = self.get_branch_config(global_config=sample_config_text)
1269
 
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
1270
 
                         my_config._get_user_id())
1271
 
        my_config.branch.control_files.files['email'] = "John"
1272
 
        self.assertEqual("John", my_config._get_user_id())
 
1811
                        my_config.username())
1273
1812
 
1274
1813
    def test_BZR_EMAIL_OVERRIDES(self):
1275
 
        os.environ['BZR_EMAIL'] = "Robert Collins <robertc@example.org>"
 
1814
        self.overrideEnv('BZR_EMAIL', "Robert Collins <robertc@example.org>")
1276
1815
        branch = FakeBranch()
1277
1816
        my_config = config.BranchConfig(branch)
1278
1817
        self.assertEqual("Robert Collins <robertc@example.org>",
1281
1820
    def test_signatures_forced(self):
1282
1821
        my_config = self.get_branch_config(
1283
1822
            global_config=sample_always_signatures)
1284
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1285
 
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1286
 
        self.assertTrue(my_config.signature_needed())
 
1823
        self.assertEqual(config.CHECK_NEVER,
 
1824
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1825
                my_config.signature_checking))
 
1826
        self.assertEqual(config.SIGN_ALWAYS,
 
1827
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1828
                my_config.signing_policy))
 
1829
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1830
            my_config.signature_needed))
1287
1831
 
1288
1832
    def test_signatures_forced_branch(self):
1289
1833
        my_config = self.get_branch_config(
1290
1834
            global_config=sample_ignore_signatures,
1291
1835
            branch_data_config=sample_always_signatures)
1292
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1293
 
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1294
 
        self.assertTrue(my_config.signature_needed())
 
1836
        self.assertEqual(config.CHECK_NEVER,
 
1837
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1838
                my_config.signature_checking))
 
1839
        self.assertEqual(config.SIGN_ALWAYS,
 
1840
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1841
                my_config.signing_policy))
 
1842
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1843
            my_config.signature_needed))
1295
1844
 
1296
1845
    def test_gpg_signing_command(self):
1297
1846
        my_config = self.get_branch_config(
1298
1847
            global_config=sample_config_text,
1299
1848
            # branch data cannot set gpg_signing_command
1300
1849
            branch_data_config="gpg_signing_command=pgp")
1301
 
        self.assertEqual('gnome-gpg', my_config.gpg_signing_command())
 
1850
        self.assertEqual('gnome-gpg',
 
1851
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1852
                my_config.gpg_signing_command))
1302
1853
 
1303
1854
    def test_get_user_option_global(self):
1304
1855
        my_config = self.get_branch_config(global_config=sample_config_text)
1311
1862
                                      location_config=sample_branches_text)
1312
1863
        self.assertEqual(my_config.branch.base, '/a/c')
1313
1864
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1314
 
                         my_config.post_commit())
 
1865
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1866
                                              my_config.post_commit))
1315
1867
        my_config.set_user_option('post_commit', 'rmtree_root')
1316
1868
        # post-commit is ignored when present in branch data
1317
1869
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1318
 
                         my_config.post_commit())
 
1870
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1871
                                              my_config.post_commit))
1319
1872
        my_config.set_user_option('post_commit', 'rmtree_root',
1320
1873
                                  store=config.STORE_LOCATION)
1321
 
        self.assertEqual('rmtree_root', my_config.post_commit())
 
1874
        self.assertEqual('rmtree_root',
 
1875
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1876
                                              my_config.post_commit))
1322
1877
 
1323
1878
    def test_config_precedence(self):
1324
1879
        # FIXME: eager test, luckily no persitent config file makes it fail
1433
1988
 
1434
1989
class TestTransportConfig(tests.TestCaseWithTransport):
1435
1990
 
 
1991
    def test_load_utf8(self):
 
1992
        """Ensure we can load an utf8-encoded file."""
 
1993
        t = self.get_transport()
 
1994
        unicode_user = u'b\N{Euro Sign}ar'
 
1995
        unicode_content = u'user=%s' % (unicode_user,)
 
1996
        utf8_content = unicode_content.encode('utf8')
 
1997
        # Store the raw content in the config file
 
1998
        t.put_bytes('foo.conf', utf8_content)
 
1999
        conf = config.TransportConfig(t, 'foo.conf')
 
2000
        self.assertEquals(unicode_user, conf.get_option('user'))
 
2001
 
 
2002
    def test_load_non_ascii(self):
 
2003
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2004
        t = self.get_transport()
 
2005
        t.put_bytes('foo.conf', 'user=foo\n#\xff\n')
 
2006
        conf = config.TransportConfig(t, 'foo.conf')
 
2007
        self.assertRaises(errors.ConfigContentError, conf._get_configobj)
 
2008
 
 
2009
    def test_load_erroneous_content(self):
 
2010
        """Ensure we display a proper error on content that can't be parsed."""
 
2011
        t = self.get_transport()
 
2012
        t.put_bytes('foo.conf', '[open_section\n')
 
2013
        conf = config.TransportConfig(t, 'foo.conf')
 
2014
        self.assertRaises(errors.ParseConfigError, conf._get_configobj)
 
2015
 
 
2016
    def test_load_permission_denied(self):
 
2017
        """Ensure we get an empty config file if the file is inaccessible."""
 
2018
        warnings = []
 
2019
        def warning(*args):
 
2020
            warnings.append(args[0] % args[1:])
 
2021
        self.overrideAttr(trace, 'warning', warning)
 
2022
 
 
2023
        class DenyingTransport(object):
 
2024
 
 
2025
            def __init__(self, base):
 
2026
                self.base = base
 
2027
 
 
2028
            def get_bytes(self, relpath):
 
2029
                raise errors.PermissionDenied(relpath, "")
 
2030
 
 
2031
        cfg = config.TransportConfig(
 
2032
            DenyingTransport("nonexisting://"), 'control.conf')
 
2033
        self.assertIs(None, cfg.get_option('non-existant', 'SECTION'))
 
2034
        self.assertEquals(
 
2035
            warnings,
 
2036
            [u'Permission denied while trying to open configuration file '
 
2037
             u'nonexisting:///control.conf.'])
 
2038
 
1436
2039
    def test_get_value(self):
1437
2040
        """Test that retreiving a value from a section is possible"""
1438
 
        bzrdir_config = config.TransportConfig(transport.get_transport('.'),
 
2041
        bzrdir_config = config.TransportConfig(self.get_transport('.'),
1439
2042
                                               'control.conf')
1440
2043
        bzrdir_config.set_option('value', 'key', 'SECTION')
1441
2044
        bzrdir_config.set_option('value2', 'key2')
1471
2074
        self.assertIs(None, bzrdir_config.get_default_stack_on())
1472
2075
 
1473
2076
 
 
2077
class TestOldConfigHooks(tests.TestCaseWithTransport):
 
2078
 
 
2079
    def setUp(self):
 
2080
        super(TestOldConfigHooks, self).setUp()
 
2081
        create_configs_with_file_option(self)
 
2082
 
 
2083
    def assertGetHook(self, conf, name, value):
 
2084
        calls = []
 
2085
        def hook(*args):
 
2086
            calls.append(args)
 
2087
        config.OldConfigHooks.install_named_hook('get', hook, None)
 
2088
        self.addCleanup(
 
2089
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
 
2090
        self.assertLength(0, calls)
 
2091
        actual_value = conf.get_user_option(name)
 
2092
        self.assertEquals(value, actual_value)
 
2093
        self.assertLength(1, calls)
 
2094
        self.assertEquals((conf, name, value), calls[0])
 
2095
 
 
2096
    def test_get_hook_bazaar(self):
 
2097
        self.assertGetHook(self.bazaar_config, 'file', 'bazaar')
 
2098
 
 
2099
    def test_get_hook_locations(self):
 
2100
        self.assertGetHook(self.locations_config, 'file', 'locations')
 
2101
 
 
2102
    def test_get_hook_branch(self):
 
2103
        # Since locations masks branch, we define a different option
 
2104
        self.branch_config.set_user_option('file2', 'branch')
 
2105
        self.assertGetHook(self.branch_config, 'file2', 'branch')
 
2106
 
 
2107
    def assertSetHook(self, conf, name, value):
 
2108
        calls = []
 
2109
        def hook(*args):
 
2110
            calls.append(args)
 
2111
        config.OldConfigHooks.install_named_hook('set', hook, None)
 
2112
        self.addCleanup(
 
2113
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
 
2114
        self.assertLength(0, calls)
 
2115
        conf.set_user_option(name, value)
 
2116
        self.assertLength(1, calls)
 
2117
        # We can't assert the conf object below as different configs use
 
2118
        # different means to implement set_user_option and we care only about
 
2119
        # coverage here.
 
2120
        self.assertEquals((name, value), calls[0][1:])
 
2121
 
 
2122
    def test_set_hook_bazaar(self):
 
2123
        self.assertSetHook(self.bazaar_config, 'foo', 'bazaar')
 
2124
 
 
2125
    def test_set_hook_locations(self):
 
2126
        self.assertSetHook(self.locations_config, 'foo', 'locations')
 
2127
 
 
2128
    def test_set_hook_branch(self):
 
2129
        self.assertSetHook(self.branch_config, 'foo', 'branch')
 
2130
 
 
2131
    def assertRemoveHook(self, conf, name, section_name=None):
 
2132
        calls = []
 
2133
        def hook(*args):
 
2134
            calls.append(args)
 
2135
        config.OldConfigHooks.install_named_hook('remove', hook, None)
 
2136
        self.addCleanup(
 
2137
            config.OldConfigHooks.uninstall_named_hook, 'remove', None)
 
2138
        self.assertLength(0, calls)
 
2139
        conf.remove_user_option(name, section_name)
 
2140
        self.assertLength(1, calls)
 
2141
        # We can't assert the conf object below as different configs use
 
2142
        # different means to implement remove_user_option and we care only about
 
2143
        # coverage here.
 
2144
        self.assertEquals((name,), calls[0][1:])
 
2145
 
 
2146
    def test_remove_hook_bazaar(self):
 
2147
        self.assertRemoveHook(self.bazaar_config, 'file')
 
2148
 
 
2149
    def test_remove_hook_locations(self):
 
2150
        self.assertRemoveHook(self.locations_config, 'file',
 
2151
                              self.locations_config.location)
 
2152
 
 
2153
    def test_remove_hook_branch(self):
 
2154
        self.assertRemoveHook(self.branch_config, 'file')
 
2155
 
 
2156
    def assertLoadHook(self, name, conf_class, *conf_args):
 
2157
        calls = []
 
2158
        def hook(*args):
 
2159
            calls.append(args)
 
2160
        config.OldConfigHooks.install_named_hook('load', hook, None)
 
2161
        self.addCleanup(
 
2162
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
 
2163
        self.assertLength(0, calls)
 
2164
        # Build a config
 
2165
        conf = conf_class(*conf_args)
 
2166
        # Access an option to trigger a load
 
2167
        conf.get_user_option(name)
 
2168
        self.assertLength(1, calls)
 
2169
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2170
 
 
2171
    def test_load_hook_bazaar(self):
 
2172
        self.assertLoadHook('file', config.GlobalConfig)
 
2173
 
 
2174
    def test_load_hook_locations(self):
 
2175
        self.assertLoadHook('file', config.LocationConfig, self.tree.basedir)
 
2176
 
 
2177
    def test_load_hook_branch(self):
 
2178
        self.assertLoadHook('file', config.BranchConfig, self.tree.branch)
 
2179
 
 
2180
    def assertSaveHook(self, conf):
 
2181
        calls = []
 
2182
        def hook(*args):
 
2183
            calls.append(args)
 
2184
        config.OldConfigHooks.install_named_hook('save', hook, None)
 
2185
        self.addCleanup(
 
2186
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
 
2187
        self.assertLength(0, calls)
 
2188
        # Setting an option triggers a save
 
2189
        conf.set_user_option('foo', 'bar')
 
2190
        self.assertLength(1, calls)
 
2191
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2192
 
 
2193
    def test_save_hook_bazaar(self):
 
2194
        self.assertSaveHook(self.bazaar_config)
 
2195
 
 
2196
    def test_save_hook_locations(self):
 
2197
        self.assertSaveHook(self.locations_config)
 
2198
 
 
2199
    def test_save_hook_branch(self):
 
2200
        self.assertSaveHook(self.branch_config)
 
2201
 
 
2202
 
 
2203
class TestOldConfigHooksForRemote(tests.TestCaseWithTransport):
 
2204
    """Tests config hooks for remote configs.
 
2205
 
 
2206
    No tests for the remove hook as this is not implemented there.
 
2207
    """
 
2208
 
 
2209
    def setUp(self):
 
2210
        super(TestOldConfigHooksForRemote, self).setUp()
 
2211
        self.transport_server = test_server.SmartTCPServer_for_testing
 
2212
        create_configs_with_file_option(self)
 
2213
 
 
2214
    def assertGetHook(self, conf, name, value):
 
2215
        calls = []
 
2216
        def hook(*args):
 
2217
            calls.append(args)
 
2218
        config.OldConfigHooks.install_named_hook('get', hook, None)
 
2219
        self.addCleanup(
 
2220
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
 
2221
        self.assertLength(0, calls)
 
2222
        actual_value = conf.get_option(name)
 
2223
        self.assertEquals(value, actual_value)
 
2224
        self.assertLength(1, calls)
 
2225
        self.assertEquals((conf, name, value), calls[0])
 
2226
 
 
2227
    def test_get_hook_remote_branch(self):
 
2228
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2229
        self.assertGetHook(remote_branch._get_config(), 'file', 'branch')
 
2230
 
 
2231
    def test_get_hook_remote_bzrdir(self):
 
2232
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2233
        conf = remote_bzrdir._get_config()
 
2234
        conf.set_option('remotedir', 'file')
 
2235
        self.assertGetHook(conf, 'file', 'remotedir')
 
2236
 
 
2237
    def assertSetHook(self, conf, name, value):
 
2238
        calls = []
 
2239
        def hook(*args):
 
2240
            calls.append(args)
 
2241
        config.OldConfigHooks.install_named_hook('set', hook, None)
 
2242
        self.addCleanup(
 
2243
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
 
2244
        self.assertLength(0, calls)
 
2245
        conf.set_option(value, name)
 
2246
        self.assertLength(1, calls)
 
2247
        # We can't assert the conf object below as different configs use
 
2248
        # different means to implement set_user_option and we care only about
 
2249
        # coverage here.
 
2250
        self.assertEquals((name, value), calls[0][1:])
 
2251
 
 
2252
    def test_set_hook_remote_branch(self):
 
2253
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2254
        self.addCleanup(remote_branch.lock_write().unlock)
 
2255
        self.assertSetHook(remote_branch._get_config(), 'file', 'remote')
 
2256
 
 
2257
    def test_set_hook_remote_bzrdir(self):
 
2258
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2259
        self.addCleanup(remote_branch.lock_write().unlock)
 
2260
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2261
        self.assertSetHook(remote_bzrdir._get_config(), 'file', 'remotedir')
 
2262
 
 
2263
    def assertLoadHook(self, expected_nb_calls, name, conf_class, *conf_args):
 
2264
        calls = []
 
2265
        def hook(*args):
 
2266
            calls.append(args)
 
2267
        config.OldConfigHooks.install_named_hook('load', hook, None)
 
2268
        self.addCleanup(
 
2269
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
 
2270
        self.assertLength(0, calls)
 
2271
        # Build a config
 
2272
        conf = conf_class(*conf_args)
 
2273
        # Access an option to trigger a load
 
2274
        conf.get_option(name)
 
2275
        self.assertLength(expected_nb_calls, calls)
 
2276
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2277
 
 
2278
    def test_load_hook_remote_branch(self):
 
2279
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2280
        self.assertLoadHook(1, 'file', remote.RemoteBranchConfig, remote_branch)
 
2281
 
 
2282
    def test_load_hook_remote_bzrdir(self):
 
2283
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2284
        # The config file doesn't exist, set an option to force its creation
 
2285
        conf = remote_bzrdir._get_config()
 
2286
        conf.set_option('remotedir', 'file')
 
2287
        # We get one call for the server and one call for the client, this is
 
2288
        # caused by the differences in implementations betwen
 
2289
        # SmartServerBzrDirRequestConfigFile (in smart/bzrdir.py) and
 
2290
        # SmartServerBranchGetConfigFile (in smart/branch.py)
 
2291
        self.assertLoadHook(2 ,'file', remote.RemoteBzrDirConfig, remote_bzrdir)
 
2292
 
 
2293
    def assertSaveHook(self, conf):
 
2294
        calls = []
 
2295
        def hook(*args):
 
2296
            calls.append(args)
 
2297
        config.OldConfigHooks.install_named_hook('save', hook, None)
 
2298
        self.addCleanup(
 
2299
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
 
2300
        self.assertLength(0, calls)
 
2301
        # Setting an option triggers a save
 
2302
        conf.set_option('foo', 'bar')
 
2303
        self.assertLength(1, calls)
 
2304
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2305
 
 
2306
    def test_save_hook_remote_branch(self):
 
2307
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2308
        self.addCleanup(remote_branch.lock_write().unlock)
 
2309
        self.assertSaveHook(remote_branch._get_config())
 
2310
 
 
2311
    def test_save_hook_remote_bzrdir(self):
 
2312
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2313
        self.addCleanup(remote_branch.lock_write().unlock)
 
2314
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2315
        self.assertSaveHook(remote_bzrdir._get_config())
 
2316
 
 
2317
 
 
2318
class TestOption(tests.TestCase):
 
2319
 
 
2320
    def test_default_value(self):
 
2321
        opt = config.Option('foo', default='bar')
 
2322
        self.assertEquals('bar', opt.get_default())
 
2323
 
 
2324
    def test_callable_default_value(self):
 
2325
        def bar_as_unicode():
 
2326
            return u'bar'
 
2327
        opt = config.Option('foo', default=bar_as_unicode)
 
2328
        self.assertEquals('bar', opt.get_default())
 
2329
 
 
2330
    def test_default_value_from_env(self):
 
2331
        opt = config.Option('foo', default='bar', default_from_env=['FOO'])
 
2332
        self.overrideEnv('FOO', 'quux')
 
2333
        # Env variable provides a default taking over the option one
 
2334
        self.assertEquals('quux', opt.get_default())
 
2335
 
 
2336
    def test_first_default_value_from_env_wins(self):
 
2337
        opt = config.Option('foo', default='bar',
 
2338
                            default_from_env=['NO_VALUE', 'FOO', 'BAZ'])
 
2339
        self.overrideEnv('FOO', 'foo')
 
2340
        self.overrideEnv('BAZ', 'baz')
 
2341
        # The first env var set wins
 
2342
        self.assertEquals('foo', opt.get_default())
 
2343
 
 
2344
    def test_not_supported_list_default_value(self):
 
2345
        self.assertRaises(AssertionError, config.Option, 'foo', default=[1])
 
2346
 
 
2347
    def test_not_supported_object_default_value(self):
 
2348
        self.assertRaises(AssertionError, config.Option, 'foo',
 
2349
                          default=object())
 
2350
 
 
2351
    def test_not_supported_callable_default_value_not_unicode(self):
 
2352
        def bar_not_unicode():
 
2353
            return 'bar'
 
2354
        opt = config.Option('foo', default=bar_not_unicode)
 
2355
        self.assertRaises(AssertionError, opt.get_default)
 
2356
 
 
2357
 
 
2358
class TestOptionConverterMixin(object):
 
2359
 
 
2360
    def assertConverted(self, expected, opt, value):
 
2361
        self.assertEquals(expected, opt.convert_from_unicode(value))
 
2362
 
 
2363
    def assertWarns(self, opt, value):
 
2364
        warnings = []
 
2365
        def warning(*args):
 
2366
            warnings.append(args[0] % args[1:])
 
2367
        self.overrideAttr(trace, 'warning', warning)
 
2368
        self.assertEquals(None, opt.convert_from_unicode(value))
 
2369
        self.assertLength(1, warnings)
 
2370
        self.assertEquals(
 
2371
            'Value "%s" is not valid for "%s"' % (value, opt.name),
 
2372
            warnings[0])
 
2373
 
 
2374
    def assertErrors(self, opt, value):
 
2375
        self.assertRaises(errors.ConfigOptionValueError,
 
2376
                          opt.convert_from_unicode, value)
 
2377
 
 
2378
    def assertConvertInvalid(self, opt, invalid_value):
 
2379
        opt.invalid = None
 
2380
        self.assertEquals(None, opt.convert_from_unicode(invalid_value))
 
2381
        opt.invalid = 'warning'
 
2382
        self.assertWarns(opt, invalid_value)
 
2383
        opt.invalid = 'error'
 
2384
        self.assertErrors(opt, invalid_value)
 
2385
 
 
2386
 
 
2387
class TestOptionWithBooleanConverter(tests.TestCase, TestOptionConverterMixin):
 
2388
 
 
2389
    def get_option(self):
 
2390
        return config.Option('foo', help='A boolean.',
 
2391
                             from_unicode=config.bool_from_store)
 
2392
 
 
2393
    def test_convert_invalid(self):
 
2394
        opt = self.get_option()
 
2395
        # A string that is not recognized as a boolean
 
2396
        self.assertConvertInvalid(opt, u'invalid-boolean')
 
2397
        # A list of strings is never recognized as a boolean
 
2398
        self.assertConvertInvalid(opt, [u'not', u'a', u'boolean'])
 
2399
 
 
2400
    def test_convert_valid(self):
 
2401
        opt = self.get_option()
 
2402
        self.assertConverted(True, opt, u'True')
 
2403
        self.assertConverted(True, opt, u'1')
 
2404
        self.assertConverted(False, opt, u'False')
 
2405
 
 
2406
 
 
2407
class TestOptionWithIntegerConverter(tests.TestCase, TestOptionConverterMixin):
 
2408
 
 
2409
    def get_option(self):
 
2410
        return config.Option('foo', help='An integer.',
 
2411
                             from_unicode=config.int_from_store)
 
2412
 
 
2413
    def test_convert_invalid(self):
 
2414
        opt = self.get_option()
 
2415
        # A string that is not recognized as an integer
 
2416
        self.assertConvertInvalid(opt, u'forty-two')
 
2417
        # A list of strings is never recognized as an integer
 
2418
        self.assertConvertInvalid(opt, [u'a', u'list'])
 
2419
 
 
2420
    def test_convert_valid(self):
 
2421
        opt = self.get_option()
 
2422
        self.assertConverted(16, opt, u'16')
 
2423
 
 
2424
 
 
2425
class TestOptionWithListConverter(tests.TestCase, TestOptionConverterMixin):
 
2426
 
 
2427
    def get_option(self):
 
2428
        return config.Option('foo', help='A list.',
 
2429
                             from_unicode=config.list_from_store)
 
2430
 
 
2431
    def test_convert_invalid(self):
 
2432
        # No string is invalid as all forms can be converted to a list
 
2433
        pass
 
2434
 
 
2435
    def test_convert_valid(self):
 
2436
        opt = self.get_option()
 
2437
        # An empty string is an empty list
 
2438
        self.assertConverted([], opt, '') # Using a bare str() just in case
 
2439
        self.assertConverted([], opt, u'')
 
2440
        # A boolean
 
2441
        self.assertConverted([u'True'], opt, u'True')
 
2442
        # An integer
 
2443
        self.assertConverted([u'42'], opt, u'42')
 
2444
        # A single string
 
2445
        self.assertConverted([u'bar'], opt, u'bar')
 
2446
        # A list remains a list (configObj will turn a string containing commas
 
2447
        # into a list, but that's not what we're testing here)
 
2448
        self.assertConverted([u'foo', u'1', u'True'],
 
2449
                             opt, [u'foo', u'1', u'True'])
 
2450
 
 
2451
 
 
2452
class TestOptionConverterMixin(object):
 
2453
 
 
2454
    def assertConverted(self, expected, opt, value):
 
2455
        self.assertEquals(expected, opt.convert_from_unicode(value))
 
2456
 
 
2457
    def assertWarns(self, opt, value):
 
2458
        warnings = []
 
2459
        def warning(*args):
 
2460
            warnings.append(args[0] % args[1:])
 
2461
        self.overrideAttr(trace, 'warning', warning)
 
2462
        self.assertEquals(None, opt.convert_from_unicode(value))
 
2463
        self.assertLength(1, warnings)
 
2464
        self.assertEquals(
 
2465
            'Value "%s" is not valid for "%s"' % (value, opt.name),
 
2466
            warnings[0])
 
2467
 
 
2468
    def assertErrors(self, opt, value):
 
2469
        self.assertRaises(errors.ConfigOptionValueError,
 
2470
                          opt.convert_from_unicode, value)
 
2471
 
 
2472
    def assertConvertInvalid(self, opt, invalid_value):
 
2473
        opt.invalid = None
 
2474
        self.assertEquals(None, opt.convert_from_unicode(invalid_value))
 
2475
        opt.invalid = 'warning'
 
2476
        self.assertWarns(opt, invalid_value)
 
2477
        opt.invalid = 'error'
 
2478
        self.assertErrors(opt, invalid_value)
 
2479
 
 
2480
 
 
2481
class TestOptionWithBooleanConverter(tests.TestCase, TestOptionConverterMixin):
 
2482
 
 
2483
    def get_option(self):
 
2484
        return config.Option('foo', help='A boolean.',
 
2485
                             from_unicode=config.bool_from_store)
 
2486
 
 
2487
    def test_convert_invalid(self):
 
2488
        opt = self.get_option()
 
2489
        # A string that is not recognized as a boolean
 
2490
        self.assertConvertInvalid(opt, u'invalid-boolean')
 
2491
        # A list of strings is never recognized as a boolean
 
2492
        self.assertConvertInvalid(opt, [u'not', u'a', u'boolean'])
 
2493
 
 
2494
    def test_convert_valid(self):
 
2495
        opt = self.get_option()
 
2496
        self.assertConverted(True, opt, u'True')
 
2497
        self.assertConverted(True, opt, u'1')
 
2498
        self.assertConverted(False, opt, u'False')
 
2499
 
 
2500
 
 
2501
class TestOptionWithIntegerConverter(tests.TestCase, TestOptionConverterMixin):
 
2502
 
 
2503
    def get_option(self):
 
2504
        return config.Option('foo', help='An integer.',
 
2505
                             from_unicode=config.int_from_store)
 
2506
 
 
2507
    def test_convert_invalid(self):
 
2508
        opt = self.get_option()
 
2509
        # A string that is not recognized as an integer
 
2510
        self.assertConvertInvalid(opt, u'forty-two')
 
2511
        # A list of strings is never recognized as an integer
 
2512
        self.assertConvertInvalid(opt, [u'a', u'list'])
 
2513
 
 
2514
    def test_convert_valid(self):
 
2515
        opt = self.get_option()
 
2516
        self.assertConverted(16, opt, u'16')
 
2517
 
 
2518
 
 
2519
class TestOptionWithListConverter(tests.TestCase, TestOptionConverterMixin):
 
2520
 
 
2521
    def get_option(self):
 
2522
        return config.Option('foo', help='A list.',
 
2523
                             from_unicode=config.list_from_store)
 
2524
 
 
2525
    def test_convert_invalid(self):
 
2526
        opt = self.get_option()
 
2527
        # We don't even try to convert a list into a list, we only expect
 
2528
        # strings
 
2529
        self.assertConvertInvalid(opt, [1])
 
2530
        # No string is invalid as all forms can be converted to a list
 
2531
 
 
2532
    def test_convert_valid(self):
 
2533
        opt = self.get_option()
 
2534
        # An empty string is an empty list
 
2535
        self.assertConverted([], opt, '') # Using a bare str() just in case
 
2536
        self.assertConverted([], opt, u'')
 
2537
        # A boolean
 
2538
        self.assertConverted([u'True'], opt, u'True')
 
2539
        # An integer
 
2540
        self.assertConverted([u'42'], opt, u'42')
 
2541
        # A single string
 
2542
        self.assertConverted([u'bar'], opt, u'bar')
 
2543
 
 
2544
 
 
2545
class TestOptionRegistry(tests.TestCase):
 
2546
 
 
2547
    def setUp(self):
 
2548
        super(TestOptionRegistry, self).setUp()
 
2549
        # Always start with an empty registry
 
2550
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
2551
        self.registry = config.option_registry
 
2552
 
 
2553
    def test_register(self):
 
2554
        opt = config.Option('foo')
 
2555
        self.registry.register(opt)
 
2556
        self.assertIs(opt, self.registry.get('foo'))
 
2557
 
 
2558
    def test_registered_help(self):
 
2559
        opt = config.Option('foo', help='A simple option')
 
2560
        self.registry.register(opt)
 
2561
        self.assertEquals('A simple option', self.registry.get_help('foo'))
 
2562
 
 
2563
    lazy_option = config.Option('lazy_foo', help='Lazy help')
 
2564
 
 
2565
    def test_register_lazy(self):
 
2566
        self.registry.register_lazy('lazy_foo', self.__module__,
 
2567
                                    'TestOptionRegistry.lazy_option')
 
2568
        self.assertIs(self.lazy_option, self.registry.get('lazy_foo'))
 
2569
 
 
2570
    def test_registered_lazy_help(self):
 
2571
        self.registry.register_lazy('lazy_foo', self.__module__,
 
2572
                                    'TestOptionRegistry.lazy_option')
 
2573
        self.assertEquals('Lazy help', self.registry.get_help('lazy_foo'))
 
2574
 
 
2575
 
 
2576
class TestRegisteredOptions(tests.TestCase):
 
2577
    """All registered options should verify some constraints."""
 
2578
 
 
2579
    scenarios = [(key, {'option_name': key, 'option': option}) for key, option
 
2580
                 in config.option_registry.iteritems()]
 
2581
 
 
2582
    def setUp(self):
 
2583
        super(TestRegisteredOptions, self).setUp()
 
2584
        self.registry = config.option_registry
 
2585
 
 
2586
    def test_proper_name(self):
 
2587
        # An option should be registered under its own name, this can't be
 
2588
        # checked at registration time for the lazy ones.
 
2589
        self.assertEquals(self.option_name, self.option.name)
 
2590
 
 
2591
    def test_help_is_set(self):
 
2592
        option_help = self.registry.get_help(self.option_name)
 
2593
        self.assertNotEquals(None, option_help)
 
2594
        # Come on, think about the user, he really wants to know what the
 
2595
        # option is about
 
2596
        self.assertIsNot(None, option_help)
 
2597
        self.assertNotEquals('', option_help)
 
2598
 
 
2599
 
 
2600
class TestSection(tests.TestCase):
 
2601
 
 
2602
    # FIXME: Parametrize so that all sections produced by Stores run these
 
2603
    # tests -- vila 2011-04-01
 
2604
 
 
2605
    def test_get_a_value(self):
 
2606
        a_dict = dict(foo='bar')
 
2607
        section = config.Section('myID', a_dict)
 
2608
        self.assertEquals('bar', section.get('foo'))
 
2609
 
 
2610
    def test_get_unknown_option(self):
 
2611
        a_dict = dict()
 
2612
        section = config.Section(None, a_dict)
 
2613
        self.assertEquals('out of thin air',
 
2614
                          section.get('foo', 'out of thin air'))
 
2615
 
 
2616
    def test_options_is_shared(self):
 
2617
        a_dict = dict()
 
2618
        section = config.Section(None, a_dict)
 
2619
        self.assertIs(a_dict, section.options)
 
2620
 
 
2621
 
 
2622
class TestMutableSection(tests.TestCase):
 
2623
 
 
2624
    scenarios = [('mutable',
 
2625
                  {'get_section':
 
2626
                       lambda opts: config.MutableSection('myID', opts)},),
 
2627
        ]
 
2628
 
 
2629
    def test_set(self):
 
2630
        a_dict = dict(foo='bar')
 
2631
        section = self.get_section(a_dict)
 
2632
        section.set('foo', 'new_value')
 
2633
        self.assertEquals('new_value', section.get('foo'))
 
2634
        # The change appears in the shared section
 
2635
        self.assertEquals('new_value', a_dict.get('foo'))
 
2636
        # We keep track of the change
 
2637
        self.assertTrue('foo' in section.orig)
 
2638
        self.assertEquals('bar', section.orig.get('foo'))
 
2639
 
 
2640
    def test_set_preserve_original_once(self):
 
2641
        a_dict = dict(foo='bar')
 
2642
        section = self.get_section(a_dict)
 
2643
        section.set('foo', 'first_value')
 
2644
        section.set('foo', 'second_value')
 
2645
        # We keep track of the original value
 
2646
        self.assertTrue('foo' in section.orig)
 
2647
        self.assertEquals('bar', section.orig.get('foo'))
 
2648
 
 
2649
    def test_remove(self):
 
2650
        a_dict = dict(foo='bar')
 
2651
        section = self.get_section(a_dict)
 
2652
        section.remove('foo')
 
2653
        # We get None for unknown options via the default value
 
2654
        self.assertEquals(None, section.get('foo'))
 
2655
        # Or we just get the default value
 
2656
        self.assertEquals('unknown', section.get('foo', 'unknown'))
 
2657
        self.assertFalse('foo' in section.options)
 
2658
        # We keep track of the deletion
 
2659
        self.assertTrue('foo' in section.orig)
 
2660
        self.assertEquals('bar', section.orig.get('foo'))
 
2661
 
 
2662
    def test_remove_new_option(self):
 
2663
        a_dict = dict()
 
2664
        section = self.get_section(a_dict)
 
2665
        section.set('foo', 'bar')
 
2666
        section.remove('foo')
 
2667
        self.assertFalse('foo' in section.options)
 
2668
        # The option didn't exist initially so it we need to keep track of it
 
2669
        # with a special value
 
2670
        self.assertTrue('foo' in section.orig)
 
2671
        self.assertEquals(config._NewlyCreatedOption, section.orig['foo'])
 
2672
 
 
2673
 
 
2674
class TestCommandLineStore(tests.TestCase):
 
2675
 
 
2676
    def setUp(self):
 
2677
        super(TestCommandLineStore, self).setUp()
 
2678
        self.store = config.CommandLineStore()
 
2679
 
 
2680
    def get_section(self):
 
2681
        """Get the unique section for the command line overrides."""
 
2682
        sections = list(self.store.get_sections())
 
2683
        self.assertLength(1, sections)
 
2684
        store, section = sections[0]
 
2685
        self.assertEquals(self.store, store)
 
2686
        return section
 
2687
 
 
2688
    def test_no_override(self):
 
2689
        self.store._from_cmdline([])
 
2690
        section = self.get_section()
 
2691
        self.assertLength(0, list(section.iter_option_names()))
 
2692
 
 
2693
    def test_simple_override(self):
 
2694
        self.store._from_cmdline(['a=b'])
 
2695
        section = self.get_section()
 
2696
        self.assertEqual('b', section.get('a'))
 
2697
 
 
2698
    def test_list_override(self):
 
2699
        self.store._from_cmdline(['l=1,2,3'])
 
2700
        val = self.get_section().get('l')
 
2701
        self.assertEqual('1,2,3', val)
 
2702
        # Reminder: lists should be registered as such explicitely, otherwise
 
2703
        # the conversion needs to be done afterwards.
 
2704
        self.assertEqual(['1', '2', '3'], config.list_from_store(val))
 
2705
 
 
2706
    def test_multiple_overrides(self):
 
2707
        self.store._from_cmdline(['a=b', 'x=y'])
 
2708
        section = self.get_section()
 
2709
        self.assertEquals('b', section.get('a'))
 
2710
        self.assertEquals('y', section.get('x'))
 
2711
 
 
2712
    def test_wrong_syntax(self):
 
2713
        self.assertRaises(errors.BzrCommandError,
 
2714
                          self.store._from_cmdline, ['a=b', 'c'])
 
2715
 
 
2716
 
 
2717
class TestStore(tests.TestCaseWithTransport):
 
2718
 
 
2719
    def assertSectionContent(self, expected, (store, section)):
 
2720
        """Assert that some options have the proper values in a section."""
 
2721
        expected_name, expected_options = expected
 
2722
        self.assertEquals(expected_name, section.id)
 
2723
        self.assertEquals(
 
2724
            expected_options,
 
2725
            dict([(k, section.get(k)) for k in expected_options.keys()]))
 
2726
 
 
2727
 
 
2728
class TestReadonlyStore(TestStore):
 
2729
 
 
2730
    scenarios = [(key, {'get_store': builder}) for key, builder
 
2731
                 in config.test_store_builder_registry.iteritems()]
 
2732
 
 
2733
    def test_building_delays_load(self):
 
2734
        store = self.get_store(self)
 
2735
        self.assertEquals(False, store.is_loaded())
 
2736
        store._load_from_string('')
 
2737
        self.assertEquals(True, store.is_loaded())
 
2738
 
 
2739
    def test_get_no_sections_for_empty(self):
 
2740
        store = self.get_store(self)
 
2741
        store._load_from_string('')
 
2742
        self.assertEquals([], list(store.get_sections()))
 
2743
 
 
2744
    def test_get_default_section(self):
 
2745
        store = self.get_store(self)
 
2746
        store._load_from_string('foo=bar')
 
2747
        sections = list(store.get_sections())
 
2748
        self.assertLength(1, sections)
 
2749
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2750
 
 
2751
    def test_get_named_section(self):
 
2752
        store = self.get_store(self)
 
2753
        store._load_from_string('[baz]\nfoo=bar')
 
2754
        sections = list(store.get_sections())
 
2755
        self.assertLength(1, sections)
 
2756
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
 
2757
 
 
2758
    def test_load_from_string_fails_for_non_empty_store(self):
 
2759
        store = self.get_store(self)
 
2760
        store._load_from_string('foo=bar')
 
2761
        self.assertRaises(AssertionError, store._load_from_string, 'bar=baz')
 
2762
 
 
2763
 
 
2764
class TestIniFileStoreContent(tests.TestCaseWithTransport):
 
2765
    """Simulate loading a config store with content of various encodings.
 
2766
 
 
2767
    All files produced by bzr are in utf8 content.
 
2768
 
 
2769
    Users may modify them manually and end up with a file that can't be
 
2770
    loaded. We need to issue proper error messages in this case.
 
2771
    """
 
2772
 
 
2773
    invalid_utf8_char = '\xff'
 
2774
 
 
2775
    def test_load_utf8(self):
 
2776
        """Ensure we can load an utf8-encoded file."""
 
2777
        t = self.get_transport()
 
2778
        # From http://pad.lv/799212
 
2779
        unicode_user = u'b\N{Euro Sign}ar'
 
2780
        unicode_content = u'user=%s' % (unicode_user,)
 
2781
        utf8_content = unicode_content.encode('utf8')
 
2782
        # Store the raw content in the config file
 
2783
        t.put_bytes('foo.conf', utf8_content)
 
2784
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2785
        store.load()
 
2786
        stack = config.Stack([store.get_sections], store)
 
2787
        self.assertEquals(unicode_user, stack.get('user'))
 
2788
 
 
2789
    def test_load_non_ascii(self):
 
2790
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2791
        t = self.get_transport()
 
2792
        t.put_bytes('foo.conf', 'user=foo\n#%s\n' % (self.invalid_utf8_char,))
 
2793
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2794
        self.assertRaises(errors.ConfigContentError, store.load)
 
2795
 
 
2796
    def test_load_erroneous_content(self):
 
2797
        """Ensure we display a proper error on content that can't be parsed."""
 
2798
        t = self.get_transport()
 
2799
        t.put_bytes('foo.conf', '[open_section\n')
 
2800
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2801
        self.assertRaises(errors.ParseConfigError, store.load)
 
2802
 
 
2803
    def test_load_permission_denied(self):
 
2804
        """Ensure we get warned when trying to load an inaccessible file."""
 
2805
        warnings = []
 
2806
        def warning(*args):
 
2807
            warnings.append(args[0] % args[1:])
 
2808
        self.overrideAttr(trace, 'warning', warning)
 
2809
 
 
2810
        t = self.get_transport()
 
2811
 
 
2812
        def get_bytes(relpath):
 
2813
            raise errors.PermissionDenied(relpath, "")
 
2814
        t.get_bytes = get_bytes
 
2815
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2816
        self.assertRaises(errors.PermissionDenied, store.load)
 
2817
        self.assertEquals(
 
2818
            warnings,
 
2819
            [u'Permission denied while trying to load configuration store %s.'
 
2820
             % store.external_url()])
 
2821
 
 
2822
 
 
2823
class TestIniConfigContent(tests.TestCaseWithTransport):
 
2824
    """Simulate loading a IniBasedConfig with content of various encodings.
 
2825
 
 
2826
    All files produced by bzr are in utf8 content.
 
2827
 
 
2828
    Users may modify them manually and end up with a file that can't be
 
2829
    loaded. We need to issue proper error messages in this case.
 
2830
    """
 
2831
 
 
2832
    invalid_utf8_char = '\xff'
 
2833
 
 
2834
    def test_load_utf8(self):
 
2835
        """Ensure we can load an utf8-encoded file."""
 
2836
        # From http://pad.lv/799212
 
2837
        unicode_user = u'b\N{Euro Sign}ar'
 
2838
        unicode_content = u'user=%s' % (unicode_user,)
 
2839
        utf8_content = unicode_content.encode('utf8')
 
2840
        # Store the raw content in the config file
 
2841
        with open('foo.conf', 'wb') as f:
 
2842
            f.write(utf8_content)
 
2843
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2844
        self.assertEquals(unicode_user, conf.get_user_option('user'))
 
2845
 
 
2846
    def test_load_badly_encoded_content(self):
 
2847
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2848
        with open('foo.conf', 'wb') as f:
 
2849
            f.write('user=foo\n#%s\n' % (self.invalid_utf8_char,))
 
2850
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2851
        self.assertRaises(errors.ConfigContentError, conf._get_parser)
 
2852
 
 
2853
    def test_load_erroneous_content(self):
 
2854
        """Ensure we display a proper error on content that can't be parsed."""
 
2855
        with open('foo.conf', 'wb') as f:
 
2856
            f.write('[open_section\n')
 
2857
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2858
        self.assertRaises(errors.ParseConfigError, conf._get_parser)
 
2859
 
 
2860
 
 
2861
class TestMutableStore(TestStore):
 
2862
 
 
2863
    scenarios = [(key, {'store_id': key, 'get_store': builder}) for key, builder
 
2864
                 in config.test_store_builder_registry.iteritems()]
 
2865
 
 
2866
    def setUp(self):
 
2867
        super(TestMutableStore, self).setUp()
 
2868
        self.transport = self.get_transport()
 
2869
 
 
2870
    def has_store(self, store):
 
2871
        store_basename = urlutils.relative_url(self.transport.external_url(),
 
2872
                                               store.external_url())
 
2873
        return self.transport.has(store_basename)
 
2874
 
 
2875
    def test_save_empty_creates_no_file(self):
 
2876
        # FIXME: There should be a better way than relying on the test
 
2877
        # parametrization to identify branch.conf -- vila 2011-0526
 
2878
        if self.store_id in ('branch', 'remote_branch'):
 
2879
            raise tests.TestNotApplicable(
 
2880
                'branch.conf is *always* created when a branch is initialized')
 
2881
        store = self.get_store(self)
 
2882
        store.save()
 
2883
        self.assertEquals(False, self.has_store(store))
 
2884
 
 
2885
    def test_save_emptied_succeeds(self):
 
2886
        store = self.get_store(self)
 
2887
        store._load_from_string('foo=bar\n')
 
2888
        section = store.get_mutable_section(None)
 
2889
        section.remove('foo')
 
2890
        store.save()
 
2891
        self.assertEquals(True, self.has_store(store))
 
2892
        modified_store = self.get_store(self)
 
2893
        sections = list(modified_store.get_sections())
 
2894
        self.assertLength(0, sections)
 
2895
 
 
2896
    def test_save_with_content_succeeds(self):
 
2897
        # FIXME: There should be a better way than relying on the test
 
2898
        # parametrization to identify branch.conf -- vila 2011-0526
 
2899
        if self.store_id in ('branch', 'remote_branch'):
 
2900
            raise tests.TestNotApplicable(
 
2901
                'branch.conf is *always* created when a branch is initialized')
 
2902
        store = self.get_store(self)
 
2903
        store._load_from_string('foo=bar\n')
 
2904
        self.assertEquals(False, self.has_store(store))
 
2905
        store.save()
 
2906
        self.assertEquals(True, self.has_store(store))
 
2907
        modified_store = self.get_store(self)
 
2908
        sections = list(modified_store.get_sections())
 
2909
        self.assertLength(1, sections)
 
2910
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2911
 
 
2912
    def test_set_option_in_empty_store(self):
 
2913
        store = self.get_store(self)
 
2914
        section = store.get_mutable_section(None)
 
2915
        section.set('foo', 'bar')
 
2916
        store.save()
 
2917
        modified_store = self.get_store(self)
 
2918
        sections = list(modified_store.get_sections())
 
2919
        self.assertLength(1, sections)
 
2920
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2921
 
 
2922
    def test_set_option_in_default_section(self):
 
2923
        store = self.get_store(self)
 
2924
        store._load_from_string('')
 
2925
        section = store.get_mutable_section(None)
 
2926
        section.set('foo', 'bar')
 
2927
        store.save()
 
2928
        modified_store = self.get_store(self)
 
2929
        sections = list(modified_store.get_sections())
 
2930
        self.assertLength(1, sections)
 
2931
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2932
 
 
2933
    def test_set_option_in_named_section(self):
 
2934
        store = self.get_store(self)
 
2935
        store._load_from_string('')
 
2936
        section = store.get_mutable_section('baz')
 
2937
        section.set('foo', 'bar')
 
2938
        store.save()
 
2939
        modified_store = self.get_store(self)
 
2940
        sections = list(modified_store.get_sections())
 
2941
        self.assertLength(1, sections)
 
2942
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
 
2943
 
 
2944
    def test_load_hook(self):
 
2945
        # We first needs to ensure that the store exists
 
2946
        store = self.get_store(self)
 
2947
        section = store.get_mutable_section('baz')
 
2948
        section.set('foo', 'bar')
 
2949
        store.save()
 
2950
        # Now we can try to load it
 
2951
        store = self.get_store(self)
 
2952
        calls = []
 
2953
        def hook(*args):
 
2954
            calls.append(args)
 
2955
        config.ConfigHooks.install_named_hook('load', hook, None)
 
2956
        self.assertLength(0, calls)
 
2957
        store.load()
 
2958
        self.assertLength(1, calls)
 
2959
        self.assertEquals((store,), calls[0])
 
2960
 
 
2961
    def test_save_hook(self):
 
2962
        calls = []
 
2963
        def hook(*args):
 
2964
            calls.append(args)
 
2965
        config.ConfigHooks.install_named_hook('save', hook, None)
 
2966
        self.assertLength(0, calls)
 
2967
        store = self.get_store(self)
 
2968
        section = store.get_mutable_section('baz')
 
2969
        section.set('foo', 'bar')
 
2970
        store.save()
 
2971
        self.assertLength(1, calls)
 
2972
        self.assertEquals((store,), calls[0])
 
2973
 
 
2974
 
 
2975
class TestTransportIniFileStore(TestStore):
 
2976
 
 
2977
    def test_loading_unknown_file_fails(self):
 
2978
        store = config.TransportIniFileStore(self.get_transport(),
 
2979
            'I-do-not-exist')
 
2980
        self.assertRaises(errors.NoSuchFile, store.load)
 
2981
 
 
2982
    def test_invalid_content(self):
 
2983
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
2984
        self.assertEquals(False, store.is_loaded())
 
2985
        exc = self.assertRaises(
 
2986
            errors.ParseConfigError, store._load_from_string,
 
2987
            'this is invalid !')
 
2988
        self.assertEndsWith(exc.filename, 'foo.conf')
 
2989
        # And the load failed
 
2990
        self.assertEquals(False, store.is_loaded())
 
2991
 
 
2992
    def test_get_embedded_sections(self):
 
2993
        # A more complicated example (which also shows that section names and
 
2994
        # option names share the same name space...)
 
2995
        # FIXME: This should be fixed by forbidding dicts as values ?
 
2996
        # -- vila 2011-04-05
 
2997
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
2998
        store._load_from_string('''
 
2999
foo=bar
 
3000
l=1,2
 
3001
[DEFAULT]
 
3002
foo_in_DEFAULT=foo_DEFAULT
 
3003
[bar]
 
3004
foo_in_bar=barbar
 
3005
[baz]
 
3006
foo_in_baz=barbaz
 
3007
[[qux]]
 
3008
foo_in_qux=quux
 
3009
''')
 
3010
        sections = list(store.get_sections())
 
3011
        self.assertLength(4, sections)
 
3012
        # The default section has no name.
 
3013
        # List values are provided as strings and need to be explicitly
 
3014
        # converted by specifying from_unicode=list_from_store at option
 
3015
        # registration
 
3016
        self.assertSectionContent((None, {'foo': 'bar', 'l': u'1,2'}),
 
3017
                                  sections[0])
 
3018
        self.assertSectionContent(
 
3019
            ('DEFAULT', {'foo_in_DEFAULT': 'foo_DEFAULT'}), sections[1])
 
3020
        self.assertSectionContent(
 
3021
            ('bar', {'foo_in_bar': 'barbar'}), sections[2])
 
3022
        # sub sections are provided as embedded dicts.
 
3023
        self.assertSectionContent(
 
3024
            ('baz', {'foo_in_baz': 'barbaz', 'qux': {'foo_in_qux': 'quux'}}),
 
3025
            sections[3])
 
3026
 
 
3027
 
 
3028
class TestLockableIniFileStore(TestStore):
 
3029
 
 
3030
    def test_create_store_in_created_dir(self):
 
3031
        self.assertPathDoesNotExist('dir')
 
3032
        t = self.get_transport('dir/subdir')
 
3033
        store = config.LockableIniFileStore(t, 'foo.conf')
 
3034
        store.get_mutable_section(None).set('foo', 'bar')
 
3035
        store.save()
 
3036
        self.assertPathExists('dir/subdir')
 
3037
 
 
3038
 
 
3039
class TestConcurrentStoreUpdates(TestStore):
 
3040
    """Test that Stores properly handle conccurent updates.
 
3041
 
 
3042
    New Store implementation may fail some of these tests but until such
 
3043
    implementations exist it's hard to properly filter them from the scenarios
 
3044
    applied here. If you encounter such a case, contact the bzr devs.
 
3045
    """
 
3046
 
 
3047
    scenarios = [(key, {'get_stack': builder}) for key, builder
 
3048
                 in config.test_stack_builder_registry.iteritems()]
 
3049
 
 
3050
    def setUp(self):
 
3051
        super(TestConcurrentStoreUpdates, self).setUp()
 
3052
        self.stack = self.get_stack(self)
 
3053
        if not isinstance(self.stack, config._CompatibleStack):
 
3054
            raise tests.TestNotApplicable(
 
3055
                '%s is not meant to be compatible with the old config design'
 
3056
                % (self.stack,))
 
3057
        self.stack.set('one', '1')
 
3058
        self.stack.set('two', '2')
 
3059
        # Flush the store
 
3060
        self.stack.store.save()
 
3061
 
 
3062
    def test_simple_read_access(self):
 
3063
        self.assertEquals('1', self.stack.get('one'))
 
3064
 
 
3065
    def test_simple_write_access(self):
 
3066
        self.stack.set('one', 'one')
 
3067
        self.assertEquals('one', self.stack.get('one'))
 
3068
 
 
3069
    def test_listen_to_the_last_speaker(self):
 
3070
        c1 = self.stack
 
3071
        c2 = self.get_stack(self)
 
3072
        c1.set('one', 'ONE')
 
3073
        c2.set('two', 'TWO')
 
3074
        self.assertEquals('ONE', c1.get('one'))
 
3075
        self.assertEquals('TWO', c2.get('two'))
 
3076
        # The second update respect the first one
 
3077
        self.assertEquals('ONE', c2.get('one'))
 
3078
 
 
3079
    def test_last_speaker_wins(self):
 
3080
        # If the same config is not shared, the same variable modified twice
 
3081
        # can only see a single result.
 
3082
        c1 = self.stack
 
3083
        c2 = self.get_stack(self)
 
3084
        c1.set('one', 'c1')
 
3085
        c2.set('one', 'c2')
 
3086
        self.assertEquals('c2', c2.get('one'))
 
3087
        # The first modification is still available until another refresh
 
3088
        # occur
 
3089
        self.assertEquals('c1', c1.get('one'))
 
3090
        c1.set('two', 'done')
 
3091
        self.assertEquals('c2', c1.get('one'))
 
3092
 
 
3093
    def test_writes_are_serialized(self):
 
3094
        c1 = self.stack
 
3095
        c2 = self.get_stack(self)
 
3096
 
 
3097
        # We spawn a thread that will pause *during* the config saving.
 
3098
        before_writing = threading.Event()
 
3099
        after_writing = threading.Event()
 
3100
        writing_done = threading.Event()
 
3101
        c1_save_without_locking_orig = c1.store.save_without_locking
 
3102
        def c1_save_without_locking():
 
3103
            before_writing.set()
 
3104
            c1_save_without_locking_orig()
 
3105
            # The lock is held. We wait for the main thread to decide when to
 
3106
            # continue
 
3107
            after_writing.wait()
 
3108
        c1.store.save_without_locking = c1_save_without_locking
 
3109
        def c1_set():
 
3110
            c1.set('one', 'c1')
 
3111
            writing_done.set()
 
3112
        t1 = threading.Thread(target=c1_set)
 
3113
        # Collect the thread after the test
 
3114
        self.addCleanup(t1.join)
 
3115
        # Be ready to unblock the thread if the test goes wrong
 
3116
        self.addCleanup(after_writing.set)
 
3117
        t1.start()
 
3118
        before_writing.wait()
 
3119
        self.assertRaises(errors.LockContention,
 
3120
                          c2.set, 'one', 'c2')
 
3121
        self.assertEquals('c1', c1.get('one'))
 
3122
        # Let the lock be released
 
3123
        after_writing.set()
 
3124
        writing_done.wait()
 
3125
        c2.set('one', 'c2')
 
3126
        self.assertEquals('c2', c2.get('one'))
 
3127
 
 
3128
    def test_read_while_writing(self):
 
3129
       c1 = self.stack
 
3130
       # We spawn a thread that will pause *during* the write
 
3131
       ready_to_write = threading.Event()
 
3132
       do_writing = threading.Event()
 
3133
       writing_done = threading.Event()
 
3134
       # We override the _save implementation so we know the store is locked
 
3135
       c1_save_without_locking_orig = c1.store.save_without_locking
 
3136
       def c1_save_without_locking():
 
3137
           ready_to_write.set()
 
3138
           # The lock is held. We wait for the main thread to decide when to
 
3139
           # continue
 
3140
           do_writing.wait()
 
3141
           c1_save_without_locking_orig()
 
3142
           writing_done.set()
 
3143
       c1.store.save_without_locking = c1_save_without_locking
 
3144
       def c1_set():
 
3145
           c1.set('one', 'c1')
 
3146
       t1 = threading.Thread(target=c1_set)
 
3147
       # Collect the thread after the test
 
3148
       self.addCleanup(t1.join)
 
3149
       # Be ready to unblock the thread if the test goes wrong
 
3150
       self.addCleanup(do_writing.set)
 
3151
       t1.start()
 
3152
       # Ensure the thread is ready to write
 
3153
       ready_to_write.wait()
 
3154
       self.assertEquals('c1', c1.get('one'))
 
3155
       # If we read during the write, we get the old value
 
3156
       c2 = self.get_stack(self)
 
3157
       self.assertEquals('1', c2.get('one'))
 
3158
       # Let the writing occur and ensure it occurred
 
3159
       do_writing.set()
 
3160
       writing_done.wait()
 
3161
       # Now we get the updated value
 
3162
       c3 = self.get_stack(self)
 
3163
       self.assertEquals('c1', c3.get('one'))
 
3164
 
 
3165
    # FIXME: It may be worth looking into removing the lock dir when it's not
 
3166
    # needed anymore and look at possible fallouts for concurrent lockers. This
 
3167
    # will matter if/when we use config files outside of bazaar directories
 
3168
    # (.bazaar or .bzr) -- vila 20110-04-111
 
3169
 
 
3170
 
 
3171
class TestSectionMatcher(TestStore):
 
3172
 
 
3173
    scenarios = [('location', {'matcher': config.LocationMatcher}),
 
3174
                 ('id', {'matcher': config.NameMatcher}),]
 
3175
 
 
3176
    def setUp(self):
 
3177
        super(TestSectionMatcher, self).setUp()
 
3178
        # Any simple store is good enough
 
3179
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3180
 
 
3181
    def test_no_matches_for_empty_stores(self):
 
3182
        store = self.get_store(self)
 
3183
        store._load_from_string('')
 
3184
        matcher = self.matcher(store, '/bar')
 
3185
        self.assertEquals([], list(matcher.get_sections()))
 
3186
 
 
3187
    def test_build_doesnt_load_store(self):
 
3188
        store = self.get_store(self)
 
3189
        matcher = self.matcher(store, '/bar')
 
3190
        self.assertFalse(store.is_loaded())
 
3191
 
 
3192
 
 
3193
class TestLocationSection(tests.TestCase):
 
3194
 
 
3195
    def get_section(self, options, extra_path):
 
3196
        section = config.Section('foo', options)
 
3197
        # We don't care about the length so we use '0'
 
3198
        return config.LocationSection(section, 0, extra_path)
 
3199
 
 
3200
    def test_simple_option(self):
 
3201
        section = self.get_section({'foo': 'bar'}, '')
 
3202
        self.assertEquals('bar', section.get('foo'))
 
3203
 
 
3204
    def test_option_with_extra_path(self):
 
3205
        section = self.get_section({'foo': 'bar', 'foo:policy': 'appendpath'},
 
3206
                                   'baz')
 
3207
        self.assertEquals('bar/baz', section.get('foo'))
 
3208
 
 
3209
    def test_invalid_policy(self):
 
3210
        section = self.get_section({'foo': 'bar', 'foo:policy': 'die'},
 
3211
                                   'baz')
 
3212
        # invalid policies are ignored
 
3213
        self.assertEquals('bar', section.get('foo'))
 
3214
 
 
3215
 
 
3216
class TestLocationMatcher(TestStore):
 
3217
 
 
3218
    def setUp(self):
 
3219
        super(TestLocationMatcher, self).setUp()
 
3220
        # Any simple store is good enough
 
3221
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3222
 
 
3223
    def test_unrelated_section_excluded(self):
 
3224
        store = self.get_store(self)
 
3225
        store._load_from_string('''
 
3226
[/foo]
 
3227
section=/foo
 
3228
[/foo/baz]
 
3229
section=/foo/baz
 
3230
[/foo/bar]
 
3231
section=/foo/bar
 
3232
[/foo/bar/baz]
 
3233
section=/foo/bar/baz
 
3234
[/quux/quux]
 
3235
section=/quux/quux
 
3236
''')
 
3237
        self.assertEquals(['/foo', '/foo/baz', '/foo/bar', '/foo/bar/baz',
 
3238
                           '/quux/quux'],
 
3239
                          [section.id for _, section in store.get_sections()])
 
3240
        matcher = config.LocationMatcher(store, '/foo/bar/quux')
 
3241
        sections = [section for s, section in matcher.get_sections()]
 
3242
        self.assertEquals([3, 2],
 
3243
                          [section.length for section in sections])
 
3244
        self.assertEquals(['/foo/bar', '/foo'],
 
3245
                          [section.id for section in sections])
 
3246
        self.assertEquals(['quux', 'bar/quux'],
 
3247
                          [section.extra_path for section in sections])
 
3248
 
 
3249
    def test_more_specific_sections_first(self):
 
3250
        store = self.get_store(self)
 
3251
        store._load_from_string('''
 
3252
[/foo]
 
3253
section=/foo
 
3254
[/foo/bar]
 
3255
section=/foo/bar
 
3256
''')
 
3257
        self.assertEquals(['/foo', '/foo/bar'],
 
3258
                          [section.id for _, section in store.get_sections()])
 
3259
        matcher = config.LocationMatcher(store, '/foo/bar/baz')
 
3260
        sections = [section for s, section in matcher.get_sections()]
 
3261
        self.assertEquals([3, 2],
 
3262
                          [section.length for section in sections])
 
3263
        self.assertEquals(['/foo/bar', '/foo'],
 
3264
                          [section.id for section in sections])
 
3265
        self.assertEquals(['baz', 'bar/baz'],
 
3266
                          [section.extra_path for section in sections])
 
3267
 
 
3268
    def test_appendpath_in_no_name_section(self):
 
3269
        # It's a bit weird to allow appendpath in a no-name section, but
 
3270
        # someone may found a use for it
 
3271
        store = self.get_store(self)
 
3272
        store._load_from_string('''
 
3273
foo=bar
 
3274
foo:policy = appendpath
 
3275
''')
 
3276
        matcher = config.LocationMatcher(store, 'dir/subdir')
 
3277
        sections = list(matcher.get_sections())
 
3278
        self.assertLength(1, sections)
 
3279
        self.assertEquals('bar/dir/subdir', sections[0][1].get('foo'))
 
3280
 
 
3281
    def test_file_urls_are_normalized(self):
 
3282
        store = self.get_store(self)
 
3283
        if sys.platform == 'win32':
 
3284
            expected_url = 'file:///C:/dir/subdir'
 
3285
            expected_location = 'C:/dir/subdir'
 
3286
        else:
 
3287
            expected_url = 'file:///dir/subdir'
 
3288
            expected_location = '/dir/subdir'
 
3289
        matcher = config.LocationMatcher(store, expected_url)
 
3290
        self.assertEquals(expected_location, matcher.location)
 
3291
 
 
3292
 
 
3293
class TestNameMatcher(TestStore):
 
3294
 
 
3295
    def setUp(self):
 
3296
        super(TestNameMatcher, self).setUp()
 
3297
        self.matcher = config.NameMatcher
 
3298
        # Any simple store is good enough
 
3299
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3300
 
 
3301
    def get_matching_sections(self, name):
 
3302
        store = self.get_store(self)
 
3303
        store._load_from_string('''
 
3304
[foo]
 
3305
option=foo
 
3306
[foo/baz]
 
3307
option=foo/baz
 
3308
[bar]
 
3309
option=bar
 
3310
''')
 
3311
        matcher = self.matcher(store, name)
 
3312
        return list(matcher.get_sections())
 
3313
 
 
3314
    def test_matching(self):
 
3315
        sections = self.get_matching_sections('foo')
 
3316
        self.assertLength(1, sections)
 
3317
        self.assertSectionContent(('foo', {'option': 'foo'}), sections[0])
 
3318
 
 
3319
    def test_not_matching(self):
 
3320
        sections = self.get_matching_sections('baz')
 
3321
        self.assertLength(0, sections)
 
3322
 
 
3323
 
 
3324
class TestStackGet(tests.TestCase):
 
3325
 
 
3326
    # FIXME: This should be parametrized for all known Stack or dedicated
 
3327
    # paramerized tests created to avoid bloating -- vila 2011-03-31
 
3328
 
 
3329
    def overrideOptionRegistry(self):
 
3330
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3331
 
 
3332
    def test_single_config_get(self):
 
3333
        conf = dict(foo='bar')
 
3334
        conf_stack = config.Stack([conf])
 
3335
        self.assertEquals('bar', conf_stack.get('foo'))
 
3336
 
 
3337
    def test_get_with_registered_default_value(self):
 
3338
        conf_stack = config.Stack([dict()])
 
3339
        opt = config.Option('foo', default='bar')
 
3340
        self.overrideOptionRegistry()
 
3341
        config.option_registry.register('foo', opt)
 
3342
        self.assertEquals('bar', conf_stack.get('foo'))
 
3343
 
 
3344
    def test_get_without_registered_default_value(self):
 
3345
        conf_stack = config.Stack([dict()])
 
3346
        opt = config.Option('foo')
 
3347
        self.overrideOptionRegistry()
 
3348
        config.option_registry.register('foo', opt)
 
3349
        self.assertEquals(None, conf_stack.get('foo'))
 
3350
 
 
3351
    def test_get_without_default_value_for_not_registered(self):
 
3352
        conf_stack = config.Stack([dict()])
 
3353
        opt = config.Option('foo')
 
3354
        self.overrideOptionRegistry()
 
3355
        self.assertEquals(None, conf_stack.get('foo'))
 
3356
 
 
3357
    def test_get_first_definition(self):
 
3358
        conf1 = dict(foo='bar')
 
3359
        conf2 = dict(foo='baz')
 
3360
        conf_stack = config.Stack([conf1, conf2])
 
3361
        self.assertEquals('bar', conf_stack.get('foo'))
 
3362
 
 
3363
    def test_get_embedded_definition(self):
 
3364
        conf1 = dict(yy='12')
 
3365
        conf2 = config.Stack([dict(xx='42'), dict(foo='baz')])
 
3366
        conf_stack = config.Stack([conf1, conf2])
 
3367
        self.assertEquals('baz', conf_stack.get('foo'))
 
3368
 
 
3369
    def test_get_for_empty_section_callable(self):
 
3370
        conf_stack = config.Stack([lambda : []])
 
3371
        self.assertEquals(None, conf_stack.get('foo'))
 
3372
 
 
3373
    def test_get_for_broken_callable(self):
 
3374
        # Trying to use and invalid callable raises an exception on first use
 
3375
        conf_stack = config.Stack([lambda : object()])
 
3376
        self.assertRaises(TypeError, conf_stack.get, 'foo')
 
3377
 
 
3378
 
 
3379
class TestStackWithTransport(tests.TestCaseWithTransport):
 
3380
 
 
3381
    scenarios = [(key, {'get_stack': builder}) for key, builder
 
3382
                 in config.test_stack_builder_registry.iteritems()]
 
3383
 
 
3384
 
 
3385
class TestConcreteStacks(TestStackWithTransport):
 
3386
 
 
3387
    def test_build_stack(self):
 
3388
        # Just a smoke test to help debug builders
 
3389
        stack = self.get_stack(self)
 
3390
 
 
3391
 
 
3392
class TestStackGet(TestStackWithTransport):
 
3393
 
 
3394
    def setUp(self):
 
3395
        super(TestStackGet, self).setUp()
 
3396
        self.conf = self.get_stack(self)
 
3397
 
 
3398
    def test_get_for_empty_stack(self):
 
3399
        self.assertEquals(None, self.conf.get('foo'))
 
3400
 
 
3401
    def test_get_hook(self):
 
3402
        self.conf.set('foo', 'bar')
 
3403
        calls = []
 
3404
        def hook(*args):
 
3405
            calls.append(args)
 
3406
        config.ConfigHooks.install_named_hook('get', hook, None)
 
3407
        self.assertLength(0, calls)
 
3408
        value = self.conf.get('foo')
 
3409
        self.assertEquals('bar', value)
 
3410
        self.assertLength(1, calls)
 
3411
        self.assertEquals((self.conf, 'foo', 'bar'), calls[0])
 
3412
 
 
3413
 
 
3414
class TestStackGetWithConverter(tests.TestCaseWithTransport):
 
3415
 
 
3416
    def setUp(self):
 
3417
        super(TestStackGetWithConverter, self).setUp()
 
3418
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3419
        self.registry = config.option_registry
 
3420
        # We just want a simple stack with a simple store so we can inject
 
3421
        # whatever content the tests need without caring about what section
 
3422
        # names are valid for a given store/stack.
 
3423
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3424
        self.conf = config.Stack([store.get_sections], store)
 
3425
 
 
3426
    def register_bool_option(self, name, default=None, default_from_env=None):
 
3427
        b = config.Option(name, help='A boolean.',
 
3428
                          default=default, default_from_env=default_from_env,
 
3429
                          from_unicode=config.bool_from_store)
 
3430
        self.registry.register(b)
 
3431
 
 
3432
    def test_get_default_bool_None(self):
 
3433
        self.register_bool_option('foo')
 
3434
        self.assertEquals(None, self.conf.get('foo'))
 
3435
 
 
3436
    def test_get_default_bool_True(self):
 
3437
        self.register_bool_option('foo', u'True')
 
3438
        self.assertEquals(True, self.conf.get('foo'))
 
3439
 
 
3440
    def test_get_default_bool_False(self):
 
3441
        self.register_bool_option('foo', False)
 
3442
        self.assertEquals(False, self.conf.get('foo'))
 
3443
 
 
3444
    def test_get_default_bool_False_as_string(self):
 
3445
        self.register_bool_option('foo', u'False')
 
3446
        self.assertEquals(False, self.conf.get('foo'))
 
3447
 
 
3448
    def test_get_default_bool_from_env_converted(self):
 
3449
        self.register_bool_option('foo', u'True', default_from_env=['FOO'])
 
3450
        self.overrideEnv('FOO', 'False')
 
3451
        self.assertEquals(False, self.conf.get('foo'))
 
3452
 
 
3453
    def test_get_default_bool_when_conversion_fails(self):
 
3454
        self.register_bool_option('foo', default='True')
 
3455
        self.conf.store._load_from_string('foo=invalid boolean')
 
3456
        self.assertEquals(True, self.conf.get('foo'))
 
3457
 
 
3458
    def register_integer_option(self, name,
 
3459
                                default=None, default_from_env=None):
 
3460
        i = config.Option(name, help='An integer.',
 
3461
                          default=default, default_from_env=default_from_env,
 
3462
                          from_unicode=config.int_from_store)
 
3463
        self.registry.register(i)
 
3464
 
 
3465
    def test_get_default_integer_None(self):
 
3466
        self.register_integer_option('foo')
 
3467
        self.assertEquals(None, self.conf.get('foo'))
 
3468
 
 
3469
    def test_get_default_integer(self):
 
3470
        self.register_integer_option('foo', 42)
 
3471
        self.assertEquals(42, self.conf.get('foo'))
 
3472
 
 
3473
    def test_get_default_integer_as_string(self):
 
3474
        self.register_integer_option('foo', u'42')
 
3475
        self.assertEquals(42, self.conf.get('foo'))
 
3476
 
 
3477
    def test_get_default_integer_from_env(self):
 
3478
        self.register_integer_option('foo', default_from_env=['FOO'])
 
3479
        self.overrideEnv('FOO', '18')
 
3480
        self.assertEquals(18, self.conf.get('foo'))
 
3481
 
 
3482
    def test_get_default_integer_when_conversion_fails(self):
 
3483
        self.register_integer_option('foo', default='12')
 
3484
        self.conf.store._load_from_string('foo=invalid integer')
 
3485
        self.assertEquals(12, self.conf.get('foo'))
 
3486
 
 
3487
    def register_list_option(self, name, default=None, default_from_env=None):
 
3488
        l = config.Option(name, help='A list.',
 
3489
                          default=default, default_from_env=default_from_env,
 
3490
                          from_unicode=config.list_from_store)
 
3491
        self.registry.register(l)
 
3492
 
 
3493
    def test_get_default_list_None(self):
 
3494
        self.register_list_option('foo')
 
3495
        self.assertEquals(None, self.conf.get('foo'))
 
3496
 
 
3497
    def test_get_default_list_empty(self):
 
3498
        self.register_list_option('foo', '')
 
3499
        self.assertEquals([], self.conf.get('foo'))
 
3500
 
 
3501
    def test_get_default_list_from_env(self):
 
3502
        self.register_list_option('foo', default_from_env=['FOO'])
 
3503
        self.overrideEnv('FOO', '')
 
3504
        self.assertEquals([], self.conf.get('foo'))
 
3505
 
 
3506
    def test_get_with_list_converter_no_item(self):
 
3507
        self.register_list_option('foo', None)
 
3508
        self.conf.store._load_from_string('foo=,')
 
3509
        self.assertEquals([], self.conf.get('foo'))
 
3510
 
 
3511
    def test_get_with_list_converter_many_items(self):
 
3512
        self.register_list_option('foo', None)
 
3513
        self.conf.store._load_from_string('foo=m,o,r,e')
 
3514
        self.assertEquals(['m', 'o', 'r', 'e'], self.conf.get('foo'))
 
3515
 
 
3516
    def test_get_with_list_converter_embedded_spaces_many_items(self):
 
3517
        self.register_list_option('foo', None)
 
3518
        self.conf.store._load_from_string('foo=" bar", "baz "')
 
3519
        self.assertEquals([' bar', 'baz '], self.conf.get('foo'))
 
3520
 
 
3521
    def test_get_with_list_converter_stripped_spaces_many_items(self):
 
3522
        self.register_list_option('foo', None)
 
3523
        self.conf.store._load_from_string('foo= bar ,  baz ')
 
3524
        self.assertEquals(['bar', 'baz'], self.conf.get('foo'))
 
3525
 
 
3526
 
 
3527
class TestIterOptionRefs(tests.TestCase):
 
3528
    """iter_option_refs is a bit unusual, document some cases."""
 
3529
 
 
3530
    def assertRefs(self, expected, string):
 
3531
        self.assertEquals(expected, list(config.iter_option_refs(string)))
 
3532
 
 
3533
    def test_empty(self):
 
3534
        self.assertRefs([(False, '')], '')
 
3535
 
 
3536
    def test_no_refs(self):
 
3537
        self.assertRefs([(False, 'foo bar')], 'foo bar')
 
3538
 
 
3539
    def test_single_ref(self):
 
3540
        self.assertRefs([(False, ''), (True, '{foo}'), (False, '')], '{foo}')
 
3541
 
 
3542
    def test_broken_ref(self):
 
3543
        self.assertRefs([(False, '{foo')], '{foo')
 
3544
 
 
3545
    def test_embedded_ref(self):
 
3546
        self.assertRefs([(False, '{'), (True, '{foo}'), (False, '}')],
 
3547
                        '{{foo}}')
 
3548
 
 
3549
    def test_two_refs(self):
 
3550
        self.assertRefs([(False, ''), (True, '{foo}'),
 
3551
                         (False, ''), (True, '{bar}'),
 
3552
                         (False, ''),],
 
3553
                        '{foo}{bar}')
 
3554
 
 
3555
    def test_newline_in_refs_are_not_matched(self):
 
3556
        self.assertRefs([(False, '{\nxx}{xx\n}{{\n}}')], '{\nxx}{xx\n}{{\n}}')
 
3557
 
 
3558
 
 
3559
class TestStackExpandOptions(tests.TestCaseWithTransport):
 
3560
 
 
3561
    def setUp(self):
 
3562
        super(TestStackExpandOptions, self).setUp()
 
3563
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3564
        self.registry = config.option_registry
 
3565
        self.conf = build_branch_stack(self)
 
3566
 
 
3567
    def assertExpansion(self, expected, string, env=None):
 
3568
        self.assertEquals(expected, self.conf.expand_options(string, env))
 
3569
 
 
3570
    def test_no_expansion(self):
 
3571
        self.assertExpansion('foo', 'foo')
 
3572
 
 
3573
    def test_expand_default_value(self):
 
3574
        self.conf.store._load_from_string('bar=baz')
 
3575
        self.registry.register(config.Option('foo', default=u'{bar}'))
 
3576
        self.assertEquals('baz', self.conf.get('foo', expand=True))
 
3577
 
 
3578
    def test_expand_default_from_env(self):
 
3579
        self.conf.store._load_from_string('bar=baz')
 
3580
        self.registry.register(config.Option('foo', default_from_env=['FOO']))
 
3581
        self.overrideEnv('FOO', '{bar}')
 
3582
        self.assertEquals('baz', self.conf.get('foo', expand=True))
 
3583
 
 
3584
    def test_expand_default_on_failed_conversion(self):
 
3585
        self.conf.store._load_from_string('baz=bogus\nbar=42\nfoo={baz}')
 
3586
        self.registry.register(
 
3587
            config.Option('foo', default=u'{bar}',
 
3588
                          from_unicode=config.int_from_store))
 
3589
        self.assertEquals(42, self.conf.get('foo', expand=True))
 
3590
 
 
3591
    def test_env_adding_options(self):
 
3592
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
 
3593
 
 
3594
    def test_env_overriding_options(self):
 
3595
        self.conf.store._load_from_string('foo=baz')
 
3596
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
 
3597
 
 
3598
    def test_simple_ref(self):
 
3599
        self.conf.store._load_from_string('foo=xxx')
 
3600
        self.assertExpansion('xxx', '{foo}')
 
3601
 
 
3602
    def test_unknown_ref(self):
 
3603
        self.assertRaises(errors.ExpandingUnknownOption,
 
3604
                          self.conf.expand_options, '{foo}')
 
3605
 
 
3606
    def test_indirect_ref(self):
 
3607
        self.conf.store._load_from_string('''
 
3608
foo=xxx
 
3609
bar={foo}
 
3610
''')
 
3611
        self.assertExpansion('xxx', '{bar}')
 
3612
 
 
3613
    def test_embedded_ref(self):
 
3614
        self.conf.store._load_from_string('''
 
3615
foo=xxx
 
3616
bar=foo
 
3617
''')
 
3618
        self.assertExpansion('xxx', '{{bar}}')
 
3619
 
 
3620
    def test_simple_loop(self):
 
3621
        self.conf.store._load_from_string('foo={foo}')
 
3622
        self.assertRaises(errors.OptionExpansionLoop,
 
3623
                          self.conf.expand_options, '{foo}')
 
3624
 
 
3625
    def test_indirect_loop(self):
 
3626
        self.conf.store._load_from_string('''
 
3627
foo={bar}
 
3628
bar={baz}
 
3629
baz={foo}''')
 
3630
        e = self.assertRaises(errors.OptionExpansionLoop,
 
3631
                              self.conf.expand_options, '{foo}')
 
3632
        self.assertEquals('foo->bar->baz', e.refs)
 
3633
        self.assertEquals('{foo}', e.string)
 
3634
 
 
3635
    def test_list(self):
 
3636
        self.conf.store._load_from_string('''
 
3637
foo=start
 
3638
bar=middle
 
3639
baz=end
 
3640
list={foo},{bar},{baz}
 
3641
''')
 
3642
        self.registry.register(
 
3643
            config.Option('list', from_unicode=config.list_from_store))
 
3644
        self.assertEquals(['start', 'middle', 'end'],
 
3645
                           self.conf.get('list', expand=True))
 
3646
 
 
3647
    def test_cascading_list(self):
 
3648
        self.conf.store._load_from_string('''
 
3649
foo=start,{bar}
 
3650
bar=middle,{baz}
 
3651
baz=end
 
3652
list={foo}
 
3653
''')
 
3654
        self.registry.register(
 
3655
            config.Option('list', from_unicode=config.list_from_store))
 
3656
        self.assertEquals(['start', 'middle', 'end'],
 
3657
                           self.conf.get('list', expand=True))
 
3658
 
 
3659
    def test_pathologically_hidden_list(self):
 
3660
        self.conf.store._load_from_string('''
 
3661
foo=bin
 
3662
bar=go
 
3663
start={foo
 
3664
middle=},{
 
3665
end=bar}
 
3666
hidden={start}{middle}{end}
 
3667
''')
 
3668
        # What matters is what the registration says, the conversion happens
 
3669
        # only after all expansions have been performed
 
3670
        self.registry.register(
 
3671
            config.Option('hidden', from_unicode=config.list_from_store))
 
3672
        self.assertEquals(['bin', 'go'],
 
3673
                          self.conf.get('hidden', expand=True))
 
3674
 
 
3675
 
 
3676
class TestStackCrossSectionsExpand(tests.TestCaseWithTransport):
 
3677
 
 
3678
    def setUp(self):
 
3679
        super(TestStackCrossSectionsExpand, self).setUp()
 
3680
 
 
3681
    def get_config(self, location, string):
 
3682
        if string is None:
 
3683
            string = ''
 
3684
        # Since we don't save the config we won't strictly require to inherit
 
3685
        # from TestCaseInTempDir, but an error occurs so quickly...
 
3686
        c = config.LocationStack(location)
 
3687
        c.store._load_from_string(string)
 
3688
        return c
 
3689
 
 
3690
    def test_dont_cross_unrelated_section(self):
 
3691
        c = self.get_config('/another/branch/path','''
 
3692
[/one/branch/path]
 
3693
foo = hello
 
3694
bar = {foo}/2
 
3695
 
 
3696
[/another/branch/path]
 
3697
bar = {foo}/2
 
3698
''')
 
3699
        self.assertRaises(errors.ExpandingUnknownOption,
 
3700
                          c.get, 'bar', expand=True)
 
3701
 
 
3702
    def test_cross_related_sections(self):
 
3703
        c = self.get_config('/project/branch/path','''
 
3704
[/project]
 
3705
foo = qu
 
3706
 
 
3707
[/project/branch/path]
 
3708
bar = {foo}ux
 
3709
''')
 
3710
        self.assertEquals('quux', c.get('bar', expand=True))
 
3711
 
 
3712
 
 
3713
class TestStackCrossStoresExpand(tests.TestCaseWithTransport):
 
3714
 
 
3715
    def test_cross_global_locations(self):
 
3716
        l_store = config.LocationStore()
 
3717
        l_store._load_from_string('''
 
3718
[/branch]
 
3719
lfoo = loc-foo
 
3720
lbar = {gbar}
 
3721
''')
 
3722
        l_store.save()
 
3723
        g_store = config.GlobalStore()
 
3724
        g_store._load_from_string('''
 
3725
[DEFAULT]
 
3726
gfoo = {lfoo}
 
3727
gbar = glob-bar
 
3728
''')
 
3729
        g_store.save()
 
3730
        stack = config.LocationStack('/branch')
 
3731
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
 
3732
        self.assertEquals('loc-foo', stack.get('gfoo', expand=True))
 
3733
 
 
3734
 
 
3735
class TestStackExpandSectionLocals(tests.TestCaseWithTransport):
 
3736
 
 
3737
    def test_expand_locals_empty(self):
 
3738
        l_store = config.LocationStore()
 
3739
        l_store._load_from_string('''
 
3740
[/home/user/project]
 
3741
base = {basename}
 
3742
rel = {relpath}
 
3743
''')
 
3744
        l_store.save()
 
3745
        stack = config.LocationStack('/home/user/project/')
 
3746
        self.assertEquals('', stack.get('base', expand=True))
 
3747
        self.assertEquals('', stack.get('rel', expand=True))
 
3748
 
 
3749
    def test_expand_basename_locally(self):
 
3750
        l_store = config.LocationStore()
 
3751
        l_store._load_from_string('''
 
3752
[/home/user/project]
 
3753
bfoo = {basename}
 
3754
''')
 
3755
        l_store.save()
 
3756
        stack = config.LocationStack('/home/user/project/branch')
 
3757
        self.assertEquals('branch', stack.get('bfoo', expand=True))
 
3758
 
 
3759
    def test_expand_basename_locally_longer_path(self):
 
3760
        l_store = config.LocationStore()
 
3761
        l_store._load_from_string('''
 
3762
[/home/user]
 
3763
bfoo = {basename}
 
3764
''')
 
3765
        l_store.save()
 
3766
        stack = config.LocationStack('/home/user/project/dir/branch')
 
3767
        self.assertEquals('branch', stack.get('bfoo', expand=True))
 
3768
 
 
3769
    def test_expand_relpath_locally(self):
 
3770
        l_store = config.LocationStore()
 
3771
        l_store._load_from_string('''
 
3772
[/home/user/project]
 
3773
lfoo = loc-foo/{relpath}
 
3774
''')
 
3775
        l_store.save()
 
3776
        stack = config.LocationStack('/home/user/project/branch')
 
3777
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
 
3778
 
 
3779
    def test_expand_relpath_unknonw_in_global(self):
 
3780
        g_store = config.GlobalStore()
 
3781
        g_store._load_from_string('''
 
3782
[DEFAULT]
 
3783
gfoo = {relpath}
 
3784
''')
 
3785
        g_store.save()
 
3786
        stack = config.LocationStack('/home/user/project/branch')
 
3787
        self.assertRaises(errors.ExpandingUnknownOption,
 
3788
                          stack.get, 'gfoo', expand=True)
 
3789
 
 
3790
    def test_expand_local_option_locally(self):
 
3791
        l_store = config.LocationStore()
 
3792
        l_store._load_from_string('''
 
3793
[/home/user/project]
 
3794
lfoo = loc-foo/{relpath}
 
3795
lbar = {gbar}
 
3796
''')
 
3797
        l_store.save()
 
3798
        g_store = config.GlobalStore()
 
3799
        g_store._load_from_string('''
 
3800
[DEFAULT]
 
3801
gfoo = {lfoo}
 
3802
gbar = glob-bar
 
3803
''')
 
3804
        g_store.save()
 
3805
        stack = config.LocationStack('/home/user/project/branch')
 
3806
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
 
3807
        self.assertEquals('loc-foo/branch', stack.get('gfoo', expand=True))
 
3808
 
 
3809
    def test_locals_dont_leak(self):
 
3810
        """Make sure we chose the right local in presence of several sections.
 
3811
        """
 
3812
        l_store = config.LocationStore()
 
3813
        l_store._load_from_string('''
 
3814
[/home/user]
 
3815
lfoo = loc-foo/{relpath}
 
3816
[/home/user/project]
 
3817
lfoo = loc-foo/{relpath}
 
3818
''')
 
3819
        l_store.save()
 
3820
        stack = config.LocationStack('/home/user/project/branch')
 
3821
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
 
3822
        stack = config.LocationStack('/home/user/bar/baz')
 
3823
        self.assertEquals('loc-foo/bar/baz', stack.get('lfoo', expand=True))
 
3824
 
 
3825
 
 
3826
 
 
3827
class TestStackSet(TestStackWithTransport):
 
3828
 
 
3829
    def test_simple_set(self):
 
3830
        conf = self.get_stack(self)
 
3831
        self.assertEquals(None, conf.get('foo'))
 
3832
        conf.set('foo', 'baz')
 
3833
        # Did we get it back ?
 
3834
        self.assertEquals('baz', conf.get('foo'))
 
3835
 
 
3836
    def test_set_creates_a_new_section(self):
 
3837
        conf = self.get_stack(self)
 
3838
        conf.set('foo', 'baz')
 
3839
        self.assertEquals, 'baz', conf.get('foo')
 
3840
 
 
3841
    def test_set_hook(self):
 
3842
        calls = []
 
3843
        def hook(*args):
 
3844
            calls.append(args)
 
3845
        config.ConfigHooks.install_named_hook('set', hook, None)
 
3846
        self.assertLength(0, calls)
 
3847
        conf = self.get_stack(self)
 
3848
        conf.set('foo', 'bar')
 
3849
        self.assertLength(1, calls)
 
3850
        self.assertEquals((conf, 'foo', 'bar'), calls[0])
 
3851
 
 
3852
 
 
3853
class TestStackRemove(TestStackWithTransport):
 
3854
 
 
3855
    def test_remove_existing(self):
 
3856
        conf = self.get_stack(self)
 
3857
        conf.set('foo', 'bar')
 
3858
        self.assertEquals('bar', conf.get('foo'))
 
3859
        conf.remove('foo')
 
3860
        # Did we get it back ?
 
3861
        self.assertEquals(None, conf.get('foo'))
 
3862
 
 
3863
    def test_remove_unknown(self):
 
3864
        conf = self.get_stack(self)
 
3865
        self.assertRaises(KeyError, conf.remove, 'I_do_not_exist')
 
3866
 
 
3867
    def test_remove_hook(self):
 
3868
        calls = []
 
3869
        def hook(*args):
 
3870
            calls.append(args)
 
3871
        config.ConfigHooks.install_named_hook('remove', hook, None)
 
3872
        self.assertLength(0, calls)
 
3873
        conf = self.get_stack(self)
 
3874
        conf.set('foo', 'bar')
 
3875
        conf.remove('foo')
 
3876
        self.assertLength(1, calls)
 
3877
        self.assertEquals((conf, 'foo'), calls[0])
 
3878
 
 
3879
 
 
3880
class TestConfigGetOptions(tests.TestCaseWithTransport, TestOptionsMixin):
 
3881
 
 
3882
    def setUp(self):
 
3883
        super(TestConfigGetOptions, self).setUp()
 
3884
        create_configs(self)
 
3885
 
 
3886
    def test_no_variable(self):
 
3887
        # Using branch should query branch, locations and bazaar
 
3888
        self.assertOptions([], self.branch_config)
 
3889
 
 
3890
    def test_option_in_bazaar(self):
 
3891
        self.bazaar_config.set_user_option('file', 'bazaar')
 
3892
        self.assertOptions([('file', 'bazaar', 'DEFAULT', 'bazaar')],
 
3893
                           self.bazaar_config)
 
3894
 
 
3895
    def test_option_in_locations(self):
 
3896
        self.locations_config.set_user_option('file', 'locations')
 
3897
        self.assertOptions(
 
3898
            [('file', 'locations', self.tree.basedir, 'locations')],
 
3899
            self.locations_config)
 
3900
 
 
3901
    def test_option_in_branch(self):
 
3902
        self.branch_config.set_user_option('file', 'branch')
 
3903
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch')],
 
3904
                           self.branch_config)
 
3905
 
 
3906
    def test_option_in_bazaar_and_branch(self):
 
3907
        self.bazaar_config.set_user_option('file', 'bazaar')
 
3908
        self.branch_config.set_user_option('file', 'branch')
 
3909
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch'),
 
3910
                            ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
3911
                           self.branch_config)
 
3912
 
 
3913
    def test_option_in_branch_and_locations(self):
 
3914
        # Hmm, locations override branch :-/
 
3915
        self.locations_config.set_user_option('file', 'locations')
 
3916
        self.branch_config.set_user_option('file', 'branch')
 
3917
        self.assertOptions(
 
3918
            [('file', 'locations', self.tree.basedir, 'locations'),
 
3919
             ('file', 'branch', 'DEFAULT', 'branch'),],
 
3920
            self.branch_config)
 
3921
 
 
3922
    def test_option_in_bazaar_locations_and_branch(self):
 
3923
        self.bazaar_config.set_user_option('file', 'bazaar')
 
3924
        self.locations_config.set_user_option('file', 'locations')
 
3925
        self.branch_config.set_user_option('file', 'branch')
 
3926
        self.assertOptions(
 
3927
            [('file', 'locations', self.tree.basedir, 'locations'),
 
3928
             ('file', 'branch', 'DEFAULT', 'branch'),
 
3929
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
3930
            self.branch_config)
 
3931
 
 
3932
 
 
3933
class TestConfigRemoveOption(tests.TestCaseWithTransport, TestOptionsMixin):
 
3934
 
 
3935
    def setUp(self):
 
3936
        super(TestConfigRemoveOption, self).setUp()
 
3937
        create_configs_with_file_option(self)
 
3938
 
 
3939
    def test_remove_in_locations(self):
 
3940
        self.locations_config.remove_user_option('file', self.tree.basedir)
 
3941
        self.assertOptions(
 
3942
            [('file', 'branch', 'DEFAULT', 'branch'),
 
3943
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
3944
            self.branch_config)
 
3945
 
 
3946
    def test_remove_in_branch(self):
 
3947
        self.branch_config.remove_user_option('file')
 
3948
        self.assertOptions(
 
3949
            [('file', 'locations', self.tree.basedir, 'locations'),
 
3950
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
3951
            self.branch_config)
 
3952
 
 
3953
    def test_remove_in_bazaar(self):
 
3954
        self.bazaar_config.remove_user_option('file')
 
3955
        self.assertOptions(
 
3956
            [('file', 'locations', self.tree.basedir, 'locations'),
 
3957
             ('file', 'branch', 'DEFAULT', 'branch'),],
 
3958
            self.branch_config)
 
3959
 
 
3960
 
 
3961
class TestConfigGetSections(tests.TestCaseWithTransport):
 
3962
 
 
3963
    def setUp(self):
 
3964
        super(TestConfigGetSections, self).setUp()
 
3965
        create_configs(self)
 
3966
 
 
3967
    def assertSectionNames(self, expected, conf, name=None):
 
3968
        """Check which sections are returned for a given config.
 
3969
 
 
3970
        If fallback configurations exist their sections can be included.
 
3971
 
 
3972
        :param expected: A list of section names.
 
3973
 
 
3974
        :param conf: The configuration that will be queried.
 
3975
 
 
3976
        :param name: An optional section name that will be passed to
 
3977
            get_sections().
 
3978
        """
 
3979
        sections = list(conf._get_sections(name))
 
3980
        self.assertLength(len(expected), sections)
 
3981
        self.assertEqual(expected, [name for name, _, _ in sections])
 
3982
 
 
3983
    def test_bazaar_default_section(self):
 
3984
        self.assertSectionNames(['DEFAULT'], self.bazaar_config)
 
3985
 
 
3986
    def test_locations_default_section(self):
 
3987
        # No sections are defined in an empty file
 
3988
        self.assertSectionNames([], self.locations_config)
 
3989
 
 
3990
    def test_locations_named_section(self):
 
3991
        self.locations_config.set_user_option('file', 'locations')
 
3992
        self.assertSectionNames([self.tree.basedir], self.locations_config)
 
3993
 
 
3994
    def test_locations_matching_sections(self):
 
3995
        loc_config = self.locations_config
 
3996
        loc_config.set_user_option('file', 'locations')
 
3997
        # We need to cheat a bit here to create an option in sections above and
 
3998
        # below the 'location' one.
 
3999
        parser = loc_config._get_parser()
 
4000
        # locations.cong deals with '/' ignoring native os.sep
 
4001
        location_names = self.tree.basedir.split('/')
 
4002
        parent = '/'.join(location_names[:-1])
 
4003
        child = '/'.join(location_names + ['child'])
 
4004
        parser[parent] = {}
 
4005
        parser[parent]['file'] = 'parent'
 
4006
        parser[child] = {}
 
4007
        parser[child]['file'] = 'child'
 
4008
        self.assertSectionNames([self.tree.basedir, parent], loc_config)
 
4009
 
 
4010
    def test_branch_data_default_section(self):
 
4011
        self.assertSectionNames([None],
 
4012
                                self.branch_config._get_branch_data_config())
 
4013
 
 
4014
    def test_branch_default_sections(self):
 
4015
        # No sections are defined in an empty locations file
 
4016
        self.assertSectionNames([None, 'DEFAULT'],
 
4017
                                self.branch_config)
 
4018
        # Unless we define an option
 
4019
        self.branch_config._get_location_config().set_user_option(
 
4020
            'file', 'locations')
 
4021
        self.assertSectionNames([self.tree.basedir, None, 'DEFAULT'],
 
4022
                                self.branch_config)
 
4023
 
 
4024
    def test_bazaar_named_section(self):
 
4025
        # We need to cheat as the API doesn't give direct access to sections
 
4026
        # other than DEFAULT.
 
4027
        self.bazaar_config.set_alias('bazaar', 'bzr')
 
4028
        self.assertSectionNames(['ALIASES'], self.bazaar_config, 'ALIASES')
 
4029
 
 
4030
 
1474
4031
class TestAuthenticationConfigFile(tests.TestCase):
1475
4032
    """Test the authentication.conf file matching"""
1476
4033
 
1491
4048
        self.assertEquals({}, conf._get_config())
1492
4049
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
1493
4050
 
 
4051
    def test_non_utf8_config(self):
 
4052
        conf = config.AuthenticationConfig(_file=StringIO(
 
4053
                'foo = bar\xff'))
 
4054
        self.assertRaises(errors.ConfigContentError, conf._get_config)
 
4055
 
1494
4056
    def test_missing_auth_section_header(self):
1495
4057
        conf = config.AuthenticationConfig(_file=StringIO('foo = bar'))
1496
4058
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
1754
4316
 
1755
4317
    def test_username_defaults_prompts(self):
1756
4318
        # HTTP prompts can't be tested here, see test_http.py
1757
 
        self._check_default_username_prompt('FTP %(host)s username: ', 'ftp')
1758
 
        self._check_default_username_prompt(
1759
 
            'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
1760
 
        self._check_default_username_prompt(
1761
 
            'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
 
4319
        self._check_default_username_prompt(u'FTP %(host)s username: ', 'ftp')
 
4320
        self._check_default_username_prompt(
 
4321
            u'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
 
4322
        self._check_default_username_prompt(
 
4323
            u'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
1762
4324
 
1763
4325
    def test_username_default_no_prompt(self):
1764
4326
        conf = config.AuthenticationConfig()
1770
4332
    def test_password_default_prompts(self):
1771
4333
        # HTTP prompts can't be tested here, see test_http.py
1772
4334
        self._check_default_password_prompt(
1773
 
            'FTP %(user)s@%(host)s password: ', 'ftp')
1774
 
        self._check_default_password_prompt(
1775
 
            'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
1776
 
        self._check_default_password_prompt(
1777
 
            'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
 
4335
            u'FTP %(user)s@%(host)s password: ', 'ftp')
 
4336
        self._check_default_password_prompt(
 
4337
            u'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
 
4338
        self._check_default_password_prompt(
 
4339
            u'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
1778
4340
        # SMTP port handling is a bit special (it's handled if embedded in the
1779
4341
        # host too)
1780
4342
        # FIXME: should we: forbid that, extend it to other schemes, leave
1781
4343
        # things as they are that's fine thank you ?
1782
 
        self._check_default_password_prompt('SMTP %(user)s@%(host)s password: ',
1783
 
                                            'smtp')
1784
 
        self._check_default_password_prompt('SMTP %(user)s@%(host)s password: ',
1785
 
                                            'smtp', host='bar.org:10025')
1786
 
        self._check_default_password_prompt(
1787
 
            'SMTP %(user)s@%(host)s:%(port)d password: ',
1788
 
            'smtp', port=10025)
 
4344
        self._check_default_password_prompt(
 
4345
            u'SMTP %(user)s@%(host)s password: ', 'smtp')
 
4346
        self._check_default_password_prompt(
 
4347
            u'SMTP %(user)s@%(host)s password: ', 'smtp', host='bar.org:10025')
 
4348
        self._check_default_password_prompt(
 
4349
            u'SMTP %(user)s@%(host)s:%(port)d password: ', 'smtp', port=10025)
1789
4350
 
1790
4351
    def test_ssh_password_emits_warning(self):
1791
4352
        conf = config.AuthenticationConfig(_file=StringIO(
1971
4532
# test_user_prompted ?
1972
4533
class TestAuthenticationRing(tests.TestCaseWithTransport):
1973
4534
    pass
 
4535
 
 
4536
 
 
4537
class TestAutoUserId(tests.TestCase):
 
4538
    """Test inferring an automatic user name."""
 
4539
 
 
4540
    def test_auto_user_id(self):
 
4541
        """Automatic inference of user name.
 
4542
 
 
4543
        This is a bit hard to test in an isolated way, because it depends on
 
4544
        system functions that go direct to /etc or perhaps somewhere else.
 
4545
        But it's reasonable to say that on Unix, with an /etc/mailname, we ought
 
4546
        to be able to choose a user name with no configuration.
 
4547
        """
 
4548
        if sys.platform == 'win32':
 
4549
            raise tests.TestSkipped(
 
4550
                "User name inference not implemented on win32")
 
4551
        realname, address = config._auto_user_id()
 
4552
        if os.path.exists('/etc/mailname'):
 
4553
            self.assertIsNot(None, realname)
 
4554
            self.assertIsNot(None, address)
 
4555
        else:
 
4556
            self.assertEquals((None, None), (realname, address))
 
4557
 
 
4558
 
 
4559
class EmailOptionTests(tests.TestCase):
 
4560
 
 
4561
    def test_default_email_uses_BZR_EMAIL(self):
 
4562
        # BZR_EMAIL takes precedence over EMAIL
 
4563
        self.overrideEnv('BZR_EMAIL', 'jelmer@samba.org')
 
4564
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
 
4565
        self.assertEquals('jelmer@samba.org', config.default_email())
 
4566
 
 
4567
    def test_default_email_uses_EMAIL(self):
 
4568
        self.overrideEnv('BZR_EMAIL', None)
 
4569
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
 
4570
        self.assertEquals('jelmer@apache.org', config.default_email())
 
4571
 
 
4572
    def test_BZR_EMAIL_overrides(self):
 
4573
        self.overrideEnv('BZR_EMAIL', 'jelmer@apache.org')
 
4574
        self.assertEquals('jelmer@apache.org',
 
4575
            config.email_from_store('jelmer@debian.org'))
 
4576
        self.overrideEnv('BZR_EMAIL', None)
 
4577
        self.overrideEnv('EMAIL', 'jelmer@samba.org')
 
4578
        self.assertEquals('jelmer@debian.org',
 
4579
            config.email_from_store('jelmer@debian.org'))