~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_http.py

  • Committer: Neil Martinsen-Burrell
  • Date: 2011-11-28 19:00:43 UTC
  • mto: (6331.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 6332.
  • Revision ID: nmb@wartburg.edu-20111128190043-3txzmh7eb9erlvlh
document in Release Notes

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
23
23
# TODO: Should be renamed to bzrlib.transport.http.tests?
24
24
# TODO: What about renaming to bzrlib.tests.transport.http ?
25
25
 
26
 
from cStringIO import StringIO
27
26
import httplib
28
 
import os
29
 
import select
30
27
import SimpleHTTPServer
31
28
import socket
32
29
import sys
35
32
import bzrlib
36
33
from bzrlib import (
37
34
    bzrdir,
 
35
    cethread,
38
36
    config,
 
37
    debug,
39
38
    errors,
40
39
    osutils,
41
40
    remote as _mod_remote,
42
41
    tests,
 
42
    trace,
43
43
    transport,
44
44
    ui,
45
 
    urlutils,
46
 
    )
47
 
from bzrlib.symbol_versioning import (
48
 
    deprecated_in,
49
45
    )
50
46
from bzrlib.tests import (
51
47
    features,
52
48
    http_server,
53
49
    http_utils,
 
50
    test_server,
 
51
    )
 
52
from bzrlib.tests.scenarios import (
 
53
    load_tests_apply_scenarios,
 
54
    multiply_scenarios,
54
55
    )
55
56
from bzrlib.transport import (
56
57
    http,
66
67
    from bzrlib.transport.http._pycurl import PyCurlTransport
67
68
 
68
69
 
69
 
def load_tests(standard_tests, module, loader):
70
 
    """Multiply tests for http clients and protocol versions."""
71
 
    result = loader.suiteClass()
72
 
 
73
 
    # one for each transport implementation
74
 
    t_tests, remaining_tests = tests.split_suite_by_condition(
75
 
        standard_tests, tests.condition_isinstance((
76
 
                TestHttpTransportRegistration,
77
 
                TestHttpTransportUrls,
78
 
                Test_redirected_to,
79
 
                )))
 
70
load_tests = load_tests_apply_scenarios
 
71
 
 
72
 
 
73
def vary_by_http_client_implementation():
 
74
    """Test the two libraries we can use, pycurl and urllib."""
80
75
    transport_scenarios = [
81
76
        ('urllib', dict(_transport=_urllib.HttpTransport_urllib,
82
77
                        _server=http_server.HttpServer_urllib,
83
 
                        _qualified_prefix='http+urllib',)),
 
78
                        _url_protocol='http+urllib',)),
84
79
        ]
85
80
    if features.pycurl.available():
86
81
        transport_scenarios.append(
87
82
            ('pycurl', dict(_transport=PyCurlTransport,
88
83
                            _server=http_server.HttpServer_PyCurl,
89
 
                            _qualified_prefix='http+pycurl',)))
90
 
    tests.multiply_tests(t_tests, transport_scenarios, result)
91
 
 
92
 
    # each implementation tested with each HTTP version
93
 
    tp_tests, remaining_tests = tests.split_suite_by_condition(
94
 
        remaining_tests, tests.condition_isinstance((
95
 
                SmartHTTPTunnellingTest,
96
 
                TestDoCatchRedirections,
97
 
                TestHTTPConnections,
98
 
                TestHTTPRedirections,
99
 
                TestHTTPSilentRedirections,
100
 
                TestLimitedRangeRequestServer,
101
 
                TestPost,
102
 
                TestProxyHttpServer,
103
 
                TestRanges,
104
 
                TestSpecificRequestHandler,
105
 
                )))
106
 
    protocol_scenarios = [
107
 
            ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
108
 
            ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
109
 
            ]
110
 
    tp_scenarios = tests.multiply_scenarios(transport_scenarios,
111
 
                                            protocol_scenarios)
112
 
    tests.multiply_tests(tp_tests, tp_scenarios, result)
113
 
 
114
 
    # proxy auth: each auth scheme on all http versions on all implementations.
115
 
    tppa_tests, remaining_tests = tests.split_suite_by_condition(
116
 
        remaining_tests, tests.condition_isinstance((
117
 
                TestProxyAuth,
118
 
                )))
119
 
    proxy_auth_scheme_scenarios = [
120
 
        ('basic', dict(_auth_server=http_utils.ProxyBasicAuthServer)),
121
 
        ('digest', dict(_auth_server=http_utils.ProxyDigestAuthServer)),
122
 
        ('basicdigest',
123
 
         dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
 
84
                            _url_protocol='http+pycurl',)))
 
85
    return transport_scenarios
 
86
 
 
87
 
 
88
def vary_by_http_protocol_version():
 
89
    """Test on http/1.0 and 1.1"""
 
90
    return [
 
91
        ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
 
92
        ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
124
93
        ]
125
 
    tppa_scenarios = tests.multiply_scenarios(tp_scenarios,
126
 
                                              proxy_auth_scheme_scenarios)
127
 
    tests.multiply_tests(tppa_tests, tppa_scenarios, result)
128
 
 
129
 
    # auth: each auth scheme on all http versions on all implementations.
130
 
    tpa_tests, remaining_tests = tests.split_suite_by_condition(
131
 
        remaining_tests, tests.condition_isinstance((
132
 
                TestAuth,
133
 
                )))
134
 
    auth_scheme_scenarios = [
 
94
 
 
95
 
 
96
def vary_by_http_auth_scheme():
 
97
    scenarios = [
135
98
        ('basic', dict(_auth_server=http_utils.HTTPBasicAuthServer)),
136
99
        ('digest', dict(_auth_server=http_utils.HTTPDigestAuthServer)),
137
100
        ('basicdigest',
138
 
         dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
139
 
        ]
140
 
    tpa_scenarios = tests.multiply_scenarios(tp_scenarios,
141
 
                                             auth_scheme_scenarios)
142
 
    tests.multiply_tests(tpa_tests, tpa_scenarios, result)
143
 
 
144
 
    # activity: on all http[s] versions on all implementations
145
 
    tpact_tests, remaining_tests = tests.split_suite_by_condition(
146
 
        remaining_tests, tests.condition_isinstance((
147
 
                TestActivity,
148
 
                )))
 
101
            dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
 
102
        ]
 
103
    # Add some attributes common to all scenarios
 
104
    for scenario_id, scenario_dict in scenarios:
 
105
        scenario_dict.update(_auth_header='Authorization',
 
106
                             _username_prompt_prefix='',
 
107
                             _password_prompt_prefix='')
 
108
    return scenarios
 
109
 
 
110
 
 
111
def vary_by_http_proxy_auth_scheme():
 
112
    scenarios = [
 
113
        ('proxy-basic', dict(_auth_server=http_utils.ProxyBasicAuthServer)),
 
114
        ('proxy-digest', dict(_auth_server=http_utils.ProxyDigestAuthServer)),
 
115
        ('proxy-basicdigest',
 
116
            dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
 
117
        ]
 
118
    # Add some attributes common to all scenarios
 
119
    for scenario_id, scenario_dict in scenarios:
 
120
        scenario_dict.update(_auth_header='Proxy-Authorization',
 
121
                             _username_prompt_prefix='Proxy ',
 
122
                             _password_prompt_prefix='Proxy ')
 
123
    return scenarios
 
124
 
 
125
 
 
126
def vary_by_http_activity():
149
127
    activity_scenarios = [
150
128
        ('urllib,http', dict(_activity_server=ActivityHTTPServer,
151
 
                             _transport=_urllib.HttpTransport_urllib,)),
 
129
                            _transport=_urllib.HttpTransport_urllib,)),
152
130
        ]
153
 
    if tests.HTTPSServerFeature.available():
 
131
    if features.HTTPSServerFeature.available():
154
132
        activity_scenarios.append(
155
133
            ('urllib,https', dict(_activity_server=ActivityHTTPSServer,
156
 
                                  _transport=_urllib.HttpTransport_urllib,)),)
 
134
                                _transport=_urllib.HttpTransport_urllib,)),)
157
135
    if features.pycurl.available():
158
136
        activity_scenarios.append(
159
137
            ('pycurl,http', dict(_activity_server=ActivityHTTPServer,
160
 
                                 _transport=PyCurlTransport,)),)
161
 
        if tests.HTTPSServerFeature.available():
 
138
                                _transport=PyCurlTransport,)),)
 
139
        if features.HTTPSServerFeature.available():
162
140
            from bzrlib.tests import (
163
141
                ssl_certs,
164
142
                )
175
153
 
176
154
            activity_scenarios.append(
177
155
                ('pycurl,https', dict(_activity_server=ActivityHTTPSServer,
178
 
                                      _transport=HTTPS_pycurl_transport,)),)
179
 
 
180
 
    tpact_scenarios = tests.multiply_scenarios(activity_scenarios,
181
 
                                               protocol_scenarios)
182
 
    tests.multiply_tests(tpact_tests, tpact_scenarios, result)
183
 
 
184
 
    # No parametrization for the remaining tests
185
 
    result.addTests(remaining_tests)
186
 
 
187
 
    return result
 
156
                                    _transport=HTTPS_pycurl_transport,)),)
 
157
    return activity_scenarios
188
158
 
189
159
 
190
160
class FakeManager(object):
223
193
        self._sock.bind(('127.0.0.1', 0))
224
194
        self.host, self.port = self._sock.getsockname()
225
195
        self._ready = threading.Event()
226
 
        self._thread = threading.Thread(target=self._accept_read_and_reply)
227
 
        self._thread.setDaemon(True)
 
196
        self._thread = test_server.TestThread(
 
197
            sync_event=self._ready, target=self._accept_read_and_reply)
228
198
        self._thread.start()
229
 
        self._ready.wait(5)
 
199
        if 'threads' in tests.selftest_debug_flags:
 
200
            sys.stderr.write('Thread started: %s\n' % (self._thread.ident,))
 
201
        self._ready.wait()
230
202
 
231
203
    def _accept_read_and_reply(self):
232
204
        self._sock.listen(1)
233
205
        self._ready.set()
234
 
        self._sock.settimeout(5)
235
 
        try:
236
 
            conn, address = self._sock.accept()
237
 
            # On win32, the accepted connection will be non-blocking to start
238
 
            # with because we're using settimeout.
239
 
            conn.setblocking(True)
 
206
        conn, address = self._sock.accept()
 
207
        if self._expect_body_tail is not None:
240
208
            while not self.received_bytes.endswith(self._expect_body_tail):
241
209
                self.received_bytes += conn.recv(4096)
242
210
            conn.sendall('HTTP/1.1 200 OK\r\n')
243
 
        except socket.timeout:
244
 
            # Make sure the client isn't stuck waiting for us to e.g. accept.
 
211
        try:
245
212
            self._sock.close()
246
213
        except socket.error:
247
214
            # The client may have already closed the socket.
249
216
 
250
217
    def stop_server(self):
251
218
        try:
252
 
            self._sock.close()
 
219
            # Issue a fake connection to wake up the server and allow it to
 
220
            # finish quickly
 
221
            fake_conn = osutils.connect_socket((self.host, self.port))
 
222
            fake_conn.close()
253
223
        except socket.error:
254
224
            # We might have already closed it.  We don't care.
255
225
            pass
256
226
        self.host = None
257
227
        self.port = None
 
228
        self._thread.join()
 
229
        if 'threads' in tests.selftest_debug_flags:
 
230
            sys.stderr.write('Thread  joined: %s\n' % (self._thread.ident,))
258
231
 
259
232
 
260
233
class TestAuthHeader(tests.TestCase):
296
269
        self.assertEqual('realm="Thou should not pass"', remainder)
297
270
 
298
271
 
 
272
class TestHTTPRangeParsing(tests.TestCase):
 
273
 
 
274
    def setUp(self):
 
275
        super(TestHTTPRangeParsing, self).setUp()
 
276
        # We focus on range  parsing here and ignore everything else
 
277
        class RequestHandler(http_server.TestingHTTPRequestHandler):
 
278
            def setup(self): pass
 
279
            def handle(self): pass
 
280
            def finish(self): pass
 
281
 
 
282
        self.req_handler = RequestHandler(None, None, None)
 
283
 
 
284
    def assertRanges(self, ranges, header, file_size):
 
285
        self.assertEquals(ranges,
 
286
                          self.req_handler._parse_ranges(header, file_size))
 
287
 
 
288
    def test_simple_range(self):
 
289
        self.assertRanges([(0,2)], 'bytes=0-2', 12)
 
290
 
 
291
    def test_tail(self):
 
292
        self.assertRanges([(8, 11)], 'bytes=-4', 12)
 
293
 
 
294
    def test_tail_bigger_than_file(self):
 
295
        self.assertRanges([(0, 11)], 'bytes=-99', 12)
 
296
 
 
297
    def test_range_without_end(self):
 
298
        self.assertRanges([(4, 11)], 'bytes=4-', 12)
 
299
 
 
300
    def test_invalid_ranges(self):
 
301
        self.assertRanges(None, 'bytes=12-22', 12)
 
302
        self.assertRanges(None, 'bytes=1-3,12-22', 12)
 
303
        self.assertRanges(None, 'bytes=-', 12)
 
304
 
 
305
 
299
306
class TestHTTPServer(tests.TestCase):
300
307
    """Test the HTTP servers implementations."""
301
308
 
304
311
 
305
312
            protocol_version = 'HTTP/0.1'
306
313
 
307
 
        server = http_server.HttpServer(BogusRequestHandler)
308
 
        try:
309
 
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
310
 
        except:
311
 
            server.stop_server()
312
 
            self.fail('HTTP Server creation did not raise UnknownProtocol')
 
314
        self.assertRaises(httplib.UnknownProtocol,
 
315
                          http_server.HttpServer, BogusRequestHandler)
313
316
 
314
317
    def test_force_invalid_protocol(self):
315
 
        server = http_server.HttpServer(protocol_version='HTTP/0.1')
316
 
        try:
317
 
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
318
 
        except:
319
 
            server.stop_server()
320
 
            self.fail('HTTP Server creation did not raise UnknownProtocol')
 
318
        self.assertRaises(httplib.UnknownProtocol,
 
319
                          http_server.HttpServer, protocol_version='HTTP/0.1')
321
320
 
322
321
    def test_server_start_and_stop(self):
323
322
        server = http_server.HttpServer()
 
323
        self.addCleanup(server.stop_server)
324
324
        server.start_server()
325
 
        try:
326
 
            self.assertTrue(server._http_running)
327
 
        finally:
328
 
            server.stop_server()
329
 
        self.assertFalse(server._http_running)
 
325
        self.assertTrue(server.server is not None)
 
326
        self.assertTrue(server.server.serving is not None)
 
327
        self.assertTrue(server.server.serving)
330
328
 
331
329
    def test_create_http_server_one_zero(self):
332
330
        class RequestHandlerOneZero(http_server.TestingHTTPRequestHandler):
335
333
 
336
334
        server = http_server.HttpServer(RequestHandlerOneZero)
337
335
        self.start_server(server)
338
 
        self.assertIsInstance(server._httpd, http_server.TestingHTTPServer)
 
336
        self.assertIsInstance(server.server, http_server.TestingHTTPServer)
339
337
 
340
338
    def test_create_http_server_one_one(self):
341
339
        class RequestHandlerOneOne(http_server.TestingHTTPRequestHandler):
344
342
 
345
343
        server = http_server.HttpServer(RequestHandlerOneOne)
346
344
        self.start_server(server)
347
 
        self.assertIsInstance(server._httpd,
 
345
        self.assertIsInstance(server.server,
348
346
                              http_server.TestingThreadingHTTPServer)
349
347
 
350
348
    def test_create_http_server_force_one_one(self):
355
353
        server = http_server.HttpServer(RequestHandlerOneZero,
356
354
                                        protocol_version='HTTP/1.1')
357
355
        self.start_server(server)
358
 
        self.assertIsInstance(server._httpd,
 
356
        self.assertIsInstance(server.server,
359
357
                              http_server.TestingThreadingHTTPServer)
360
358
 
361
359
    def test_create_http_server_force_one_zero(self):
366
364
        server = http_server.HttpServer(RequestHandlerOneOne,
367
365
                                        protocol_version='HTTP/1.0')
368
366
        self.start_server(server)
369
 
        self.assertIsInstance(server._httpd,
 
367
        self.assertIsInstance(server.server,
370
368
                              http_server.TestingHTTPServer)
371
369
 
372
370
 
401
399
class TestHttpTransportUrls(tests.TestCase):
402
400
    """Test the http urls."""
403
401
 
 
402
    scenarios = vary_by_http_client_implementation()
 
403
 
404
404
    def test_abs_url(self):
405
405
        """Construction of absolute http URLs"""
406
 
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
 
406
        t = self._transport('http://example.com/bzr/bzr.dev/')
407
407
        eq = self.assertEqualDiff
408
 
        eq(t.abspath('.'), 'http://bazaar-vcs.org/bzr/bzr.dev')
409
 
        eq(t.abspath('foo/bar'), 'http://bazaar-vcs.org/bzr/bzr.dev/foo/bar')
410
 
        eq(t.abspath('.bzr'), 'http://bazaar-vcs.org/bzr/bzr.dev/.bzr')
 
408
        eq(t.abspath('.'), 'http://example.com/bzr/bzr.dev')
 
409
        eq(t.abspath('foo/bar'), 'http://example.com/bzr/bzr.dev/foo/bar')
 
410
        eq(t.abspath('.bzr'), 'http://example.com/bzr/bzr.dev/.bzr')
411
411
        eq(t.abspath('.bzr/1//2/./3'),
412
 
           'http://bazaar-vcs.org/bzr/bzr.dev/.bzr/1/2/3')
 
412
           'http://example.com/bzr/bzr.dev/.bzr/1/2/3')
413
413
 
414
414
    def test_invalid_http_urls(self):
415
415
        """Trap invalid construction of urls"""
416
 
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
 
416
        self._transport('http://example.com/bzr/bzr.dev/')
417
417
        self.assertRaises(errors.InvalidURL,
418
418
                          self._transport,
419
 
                          'http://http://bazaar-vcs.org/bzr/bzr.dev/')
 
419
                          'http://http://example.com/bzr/bzr.dev/')
420
420
 
421
421
    def test_http_root_urls(self):
422
422
        """Construction of URLs from server root"""
423
 
        t = self._transport('http://bzr.ozlabs.org/')
 
423
        t = self._transport('http://example.com/')
424
424
        eq = self.assertEqualDiff
425
425
        eq(t.abspath('.bzr/tree-version'),
426
 
           'http://bzr.ozlabs.org/.bzr/tree-version')
 
426
           'http://example.com/.bzr/tree-version')
427
427
 
428
428
    def test_http_impl_urls(self):
429
429
        """There are servers which ask for particular clients to connect"""
431
431
        server.start_server()
432
432
        try:
433
433
            url = server.get_url()
434
 
            self.assertTrue(url.startswith('%s://' % self._qualified_prefix))
 
434
            self.assertTrue(url.startswith('%s://' % self._url_protocol))
435
435
        finally:
436
436
            server.stop_server()
437
437
 
475
475
class TestHTTPConnections(http_utils.TestCaseWithWebserver):
476
476
    """Test the http connections."""
477
477
 
 
478
    scenarios = multiply_scenarios(
 
479
        vary_by_http_client_implementation(),
 
480
        vary_by_http_protocol_version(),
 
481
        )
 
482
 
478
483
    def setUp(self):
479
484
        http_utils.TestCaseWithWebserver.setUp(self)
480
485
        self.build_tree(['foo/', 'foo/bar'], line_endings='binary',
482
487
 
483
488
    def test_http_has(self):
484
489
        server = self.get_readonly_server()
485
 
        t = self._transport(server.get_url())
 
490
        t = self.get_readonly_transport()
486
491
        self.assertEqual(t.has('foo/bar'), True)
487
492
        self.assertEqual(len(server.logs), 1)
488
493
        self.assertContainsRe(server.logs[0],
490
495
 
491
496
    def test_http_has_not_found(self):
492
497
        server = self.get_readonly_server()
493
 
        t = self._transport(server.get_url())
 
498
        t = self.get_readonly_transport()
494
499
        self.assertEqual(t.has('not-found'), False)
495
500
        self.assertContainsRe(server.logs[1],
496
501
            r'"HEAD /not-found HTTP/1.." 404 - "-" "bzr/')
497
502
 
498
503
    def test_http_get(self):
499
504
        server = self.get_readonly_server()
500
 
        t = self._transport(server.get_url())
 
505
        t = self.get_readonly_transport()
501
506
        fp = t.get('foo/bar')
502
507
        self.assertEqualDiff(
503
508
            fp.read(),
525
530
class TestHttpTransportRegistration(tests.TestCase):
526
531
    """Test registrations of various http implementations"""
527
532
 
 
533
    scenarios = vary_by_http_client_implementation()
 
534
 
528
535
    def test_http_registered(self):
529
 
        t = transport.get_transport('%s://foo.com/' % self._qualified_prefix)
 
536
        t = transport.get_transport_from_url(
 
537
            '%s://foo.com/' % self._url_protocol)
530
538
        self.assertIsInstance(t, transport.Transport)
531
539
        self.assertIsInstance(t, self._transport)
532
540
 
533
541
 
534
542
class TestPost(tests.TestCase):
535
543
 
 
544
    scenarios = multiply_scenarios(
 
545
        vary_by_http_client_implementation(),
 
546
        vary_by_http_protocol_version(),
 
547
        )
 
548
 
536
549
    def test_post_body_is_received(self):
537
550
        server = RecordingServer(expect_body_tail='end-of-body',
538
 
            scheme=self._qualified_prefix)
 
551
                                 scheme=self._url_protocol)
539
552
        self.start_server(server)
540
553
        url = server.get_url()
541
 
        http_transport = self._transport(url)
 
554
        # FIXME: needs a cleanup -- vila 20100611
 
555
        http_transport = transport.get_transport_from_url(url)
542
556
        code, response = http_transport._post('abc def end-of-body')
543
557
        self.assertTrue(
544
558
            server.received_bytes.startswith('POST /.bzr/smart HTTP/1.'))
545
559
        self.assertTrue('content-length: 19\r' in server.received_bytes.lower())
 
560
        self.assertTrue('content-type: application/octet-stream\r'
 
561
                        in server.received_bytes.lower())
546
562
        # The transport should not be assuming that the server can accept
547
563
        # chunked encoding the first time it connects, because HTTP/1.1, so we
548
564
        # check for the literal string.
584
600
    Daughter classes are expected to override _req_handler_class
585
601
    """
586
602
 
 
603
    scenarios = multiply_scenarios(
 
604
        vary_by_http_client_implementation(),
 
605
        vary_by_http_protocol_version(),
 
606
        )
 
607
 
587
608
    # Provide a useful default
588
609
    _req_handler_class = http_server.TestingHTTPRequestHandler
589
610
 
590
611
    def create_transport_readonly_server(self):
591
 
        return http_server.HttpServer(self._req_handler_class,
592
 
                                      protocol_version=self._protocol_version)
 
612
        server = http_server.HttpServer(self._req_handler_class,
 
613
                                        protocol_version=self._protocol_version)
 
614
        server._url_protocol = self._url_protocol
 
615
        return server
593
616
 
594
617
    def _testing_pycurl(self):
595
618
        # TODO: This is duplicated for lots of the classes in this file
600
623
class WallRequestHandler(http_server.TestingHTTPRequestHandler):
601
624
    """Whatever request comes in, close the connection"""
602
625
 
603
 
    def handle_one_request(self):
 
626
    def _handle_one_request(self):
604
627
        """Handle a single HTTP request, by abruptly closing the connection"""
605
628
        self.close_connection = 1
606
629
 
611
634
    _req_handler_class = WallRequestHandler
612
635
 
613
636
    def test_http_has(self):
614
 
        server = self.get_readonly_server()
615
 
        t = self._transport(server.get_url())
 
637
        t = self.get_readonly_transport()
616
638
        # Unfortunately httplib (see HTTPResponse._read_status
617
639
        # for details) make no distinction between a closed
618
640
        # socket and badly formatted status line, so we can't
624
646
                          t.has, 'foo/bar')
625
647
 
626
648
    def test_http_get(self):
627
 
        server = self.get_readonly_server()
628
 
        t = self._transport(server.get_url())
 
649
        t = self.get_readonly_transport()
629
650
        self.assertRaises((errors.ConnectionError, errors.ConnectionReset,
630
651
                           errors.InvalidHttpResponse),
631
652
                          t.get, 'foo/bar')
648
669
    _req_handler_class = BadStatusRequestHandler
649
670
 
650
671
    def test_http_has(self):
651
 
        server = self.get_readonly_server()
652
 
        t = self._transport(server.get_url())
 
672
        t = self.get_readonly_transport()
653
673
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
654
674
 
655
675
    def test_http_get(self):
656
 
        server = self.get_readonly_server()
657
 
        t = self._transport(server.get_url())
 
676
        t = self.get_readonly_transport()
658
677
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
659
678
 
660
679
 
665
684
        """Fakes handling a single HTTP request, returns a bad status"""
666
685
        ignored = http_server.TestingHTTPRequestHandler.parse_request(self)
667
686
        self.wfile.write("Invalid status line\r\n")
 
687
        # If we don't close the connection pycurl will hang. Since this is a
 
688
        # stress test we don't *have* to respect the protocol, but we don't
 
689
        # have to sabotage it too much either.
 
690
        self.close_connection = True
668
691
        return False
669
692
 
670
693
 
676
699
 
677
700
    _req_handler_class = InvalidStatusRequestHandler
678
701
 
679
 
    def test_http_has(self):
680
 
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
681
 
            raise tests.KnownFailure(
682
 
                'pycurl hangs if the server send back garbage')
683
 
        super(TestInvalidStatusServer, self).test_http_has()
684
 
 
685
 
    def test_http_get(self):
686
 
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
687
 
            raise tests.KnownFailure(
688
 
                'pycurl hangs if the server send back garbage')
689
 
        super(TestInvalidStatusServer, self).test_http_get()
690
 
 
691
702
 
692
703
class BadProtocolRequestHandler(http_server.TestingHTTPRequestHandler):
693
704
    """Whatever request comes in, returns a bad protocol version"""
715
726
        super(TestBadProtocolServer, self).setUp()
716
727
 
717
728
    def test_http_has(self):
718
 
        server = self.get_readonly_server()
719
 
        t = self._transport(server.get_url())
 
729
        t = self.get_readonly_transport()
720
730
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
721
731
 
722
732
    def test_http_get(self):
723
 
        server = self.get_readonly_server()
724
 
        t = self._transport(server.get_url())
 
733
        t = self.get_readonly_transport()
725
734
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
726
735
 
727
736
 
741
750
    _req_handler_class = ForbiddenRequestHandler
742
751
 
743
752
    def test_http_has(self):
744
 
        server = self.get_readonly_server()
745
 
        t = self._transport(server.get_url())
 
753
        t = self.get_readonly_transport()
746
754
        self.assertRaises(errors.TransportError, t.has, 'foo/bar')
747
755
 
748
756
    def test_http_get(self):
749
 
        server = self.get_readonly_server()
750
 
        t = self._transport(server.get_url())
 
757
        t = self.get_readonly_transport()
751
758
        self.assertRaises(errors.TransportError, t.get, 'foo/bar')
752
759
 
753
760
 
792
799
        self.build_tree_contents([('a', '0123456789')],)
793
800
 
794
801
    def test_readv(self):
795
 
        server = self.get_readonly_server()
796
 
        t = self._transport(server.get_url())
 
802
        t = self.get_readonly_transport()
797
803
        l = list(t.readv('a', ((0, 1), (1, 1), (3, 2), (9, 1))))
798
804
        self.assertEqual(l[0], (0, '0'))
799
805
        self.assertEqual(l[1], (1, '1'))
801
807
        self.assertEqual(l[3], (9, '9'))
802
808
 
803
809
    def test_readv_out_of_order(self):
804
 
        server = self.get_readonly_server()
805
 
        t = self._transport(server.get_url())
 
810
        t = self.get_readonly_transport()
806
811
        l = list(t.readv('a', ((1, 1), (9, 1), (0, 1), (3, 2))))
807
812
        self.assertEqual(l[0], (1, '1'))
808
813
        self.assertEqual(l[1], (9, '9'))
810
815
        self.assertEqual(l[3], (3, '34'))
811
816
 
812
817
    def test_readv_invalid_ranges(self):
813
 
        server = self.get_readonly_server()
814
 
        t = self._transport(server.get_url())
 
818
        t = self.get_readonly_transport()
815
819
 
816
820
        # This is intentionally reading off the end of the file
817
821
        # since we are sure that it cannot get there
825
829
 
826
830
    def test_readv_multiple_get_requests(self):
827
831
        server = self.get_readonly_server()
828
 
        t = self._transport(server.get_url())
 
832
        t = self.get_readonly_transport()
829
833
        # force transport to issue multiple requests
830
834
        t._max_readv_combine = 1
831
835
        t._max_get_ranges = 1
839
843
 
840
844
    def test_readv_get_max_size(self):
841
845
        server = self.get_readonly_server()
842
 
        t = self._transport(server.get_url())
 
846
        t = self.get_readonly_transport()
843
847
        # force transport to issue multiple requests by limiting the number of
844
848
        # bytes by request. Note that this apply to coalesced offsets only, a
845
849
        # single range will keep its size even if bigger than the limit.
854
858
 
855
859
    def test_complete_readv_leave_pipe_clean(self):
856
860
        server = self.get_readonly_server()
857
 
        t = self._transport(server.get_url())
 
861
        t = self.get_readonly_transport()
858
862
        # force transport to issue multiple requests
859
863
        t._get_max_size = 2
860
 
        l = list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
 
864
        list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
861
865
        # The server should have issued 3 requests
862
866
        self.assertEqual(3, server.GET_request_nb)
863
867
        self.assertEqual('0123456789', t.get_bytes('a'))
865
869
 
866
870
    def test_incomplete_readv_leave_pipe_clean(self):
867
871
        server = self.get_readonly_server()
868
 
        t = self._transport(server.get_url())
 
872
        t = self.get_readonly_transport()
869
873
        # force transport to issue multiple requests
870
874
        t._get_max_size = 2
871
875
        # Don't collapse readv results into a list so that we leave unread
940
944
    def get_multiple_ranges(self, file, file_size, ranges):
941
945
        self.send_response(206)
942
946
        self.send_header('Accept-Ranges', 'bytes')
 
947
        # XXX: this is strange; the 'random' name below seems undefined and
 
948
        # yet the tests pass -- mbp 2010-10-11 bug 658773
943
949
        boundary = "%d" % random.randint(0,0x7FFFFFFF)
944
950
        self.send_header("Content-Type",
945
951
                         "multipart/byteranges; boundary=%s" % boundary)
1007
1013
                return
1008
1014
            self.send_range_content(file, start, end - start + 1)
1009
1015
            cur += 1
1010
 
        # No final boundary
 
1016
        # Final boundary
1011
1017
        self.wfile.write(boundary_line)
1012
1018
 
1013
1019
 
1021
1027
 
1022
1028
    def test_readv_with_short_reads(self):
1023
1029
        server = self.get_readonly_server()
1024
 
        t = self._transport(server.get_url())
 
1030
        t = self.get_readonly_transport()
1025
1031
        # Force separate ranges for each offset
1026
1032
        t._bytes_to_read_before_seek = 0
1027
1033
        ireadv = iter(t.readv('a', ((0, 1), (2, 1), (4, 2), (9, 1))))
1042
1048
        # that mode
1043
1049
        self.assertEqual('single', t._range_hint)
1044
1050
 
 
1051
 
 
1052
class TruncatedBeforeBoundaryRequestHandler(
 
1053
    http_server.TestingHTTPRequestHandler):
 
1054
    """Truncation before a boundary, like in bug 198646"""
 
1055
 
 
1056
    _truncated_ranges = 1
 
1057
 
 
1058
    def get_multiple_ranges(self, file, file_size, ranges):
 
1059
        self.send_response(206)
 
1060
        self.send_header('Accept-Ranges', 'bytes')
 
1061
        boundary = 'tagada'
 
1062
        self.send_header('Content-Type',
 
1063
                         'multipart/byteranges; boundary=%s' % boundary)
 
1064
        boundary_line = '--%s\r\n' % boundary
 
1065
        # Calculate the Content-Length
 
1066
        content_length = 0
 
1067
        for (start, end) in ranges:
 
1068
            content_length += len(boundary_line)
 
1069
            content_length += self._header_line_length(
 
1070
                'Content-type', 'application/octet-stream')
 
1071
            content_length += self._header_line_length(
 
1072
                'Content-Range', 'bytes %d-%d/%d' % (start, end, file_size))
 
1073
            content_length += len('\r\n') # end headers
 
1074
            content_length += end - start # + 1
 
1075
        content_length += len(boundary_line)
 
1076
        self.send_header('Content-length', content_length)
 
1077
        self.end_headers()
 
1078
 
 
1079
        # Send the multipart body
 
1080
        cur = 0
 
1081
        for (start, end) in ranges:
 
1082
            if cur + self._truncated_ranges >= len(ranges):
 
1083
                # Abruptly ends the response and close the connection
 
1084
                self.close_connection = 1
 
1085
                return
 
1086
            self.wfile.write(boundary_line)
 
1087
            self.send_header('Content-type', 'application/octet-stream')
 
1088
            self.send_header('Content-Range', 'bytes %d-%d/%d'
 
1089
                             % (start, end, file_size))
 
1090
            self.end_headers()
 
1091
            self.send_range_content(file, start, end - start + 1)
 
1092
            cur += 1
 
1093
        # Final boundary
 
1094
        self.wfile.write(boundary_line)
 
1095
 
 
1096
 
 
1097
class TestTruncatedBeforeBoundary(TestSpecificRequestHandler):
 
1098
    """Tests the case of bug 198646, disconnecting before a boundary."""
 
1099
 
 
1100
    _req_handler_class = TruncatedBeforeBoundaryRequestHandler
 
1101
 
 
1102
    def setUp(self):
 
1103
        super(TestTruncatedBeforeBoundary, self).setUp()
 
1104
        self.build_tree_contents([('a', '0123456789')],)
 
1105
 
 
1106
    def test_readv_with_short_reads(self):
 
1107
        server = self.get_readonly_server()
 
1108
        t = self.get_readonly_transport()
 
1109
        # Force separate ranges for each offset
 
1110
        t._bytes_to_read_before_seek = 0
 
1111
        ireadv = iter(t.readv('a', ((0, 1), (2, 1), (4, 2), (9, 1))))
 
1112
        self.assertEqual((0, '0'), ireadv.next())
 
1113
        self.assertEqual((2, '2'), ireadv.next())
 
1114
        self.assertEqual((4, '45'), ireadv.next())
 
1115
        self.assertEqual((9, '9'), ireadv.next())
 
1116
 
 
1117
 
1045
1118
class LimitedRangeRequestHandler(http_server.TestingHTTPRequestHandler):
1046
1119
    """Errors out when range specifiers exceed the limit"""
1047
1120
 
1071
1144
class TestLimitedRangeRequestServer(http_utils.TestCaseWithWebserver):
1072
1145
    """Tests readv requests against a server erroring out on too much ranges."""
1073
1146
 
 
1147
    scenarios = multiply_scenarios(
 
1148
        vary_by_http_client_implementation(),
 
1149
        vary_by_http_protocol_version(),
 
1150
        )
 
1151
 
1074
1152
    # Requests with more range specifiers will error out
1075
1153
    range_limit = 3
1076
1154
 
1078
1156
        return LimitedRangeHTTPServer(range_limit=self.range_limit,
1079
1157
                                      protocol_version=self._protocol_version)
1080
1158
 
1081
 
    def get_transport(self):
1082
 
        return self._transport(self.get_readonly_server().get_url())
1083
 
 
1084
1159
    def setUp(self):
1085
1160
        http_utils.TestCaseWithWebserver.setUp(self)
1086
1161
        # We need to manipulate ranges that correspond to real chunks in the
1090
1165
        self.build_tree_contents([('a', content)],)
1091
1166
 
1092
1167
    def test_few_ranges(self):
1093
 
        t = self.get_transport()
 
1168
        t = self.get_readonly_transport()
1094
1169
        l = list(t.readv('a', ((0, 4), (1024, 4), )))
1095
1170
        self.assertEqual(l[0], (0, '0000'))
1096
1171
        self.assertEqual(l[1], (1024, '0001'))
1097
1172
        self.assertEqual(1, self.get_readonly_server().GET_request_nb)
1098
1173
 
1099
1174
    def test_more_ranges(self):
1100
 
        t = self.get_transport()
 
1175
        t = self.get_readonly_transport()
1101
1176
        l = list(t.readv('a', ((0, 4), (1024, 4), (4096, 4), (8192, 4))))
1102
1177
        self.assertEqual(l[0], (0, '0000'))
1103
1178
        self.assertEqual(l[1], (1024, '0001'))
1114
1189
    Only the urllib implementation is tested here.
1115
1190
    """
1116
1191
 
1117
 
    def setUp(self):
1118
 
        tests.TestCase.setUp(self)
1119
 
        self._old_env = {}
1120
 
 
1121
 
    def tearDown(self):
1122
 
        self._restore_env()
1123
 
        tests.TestCase.tearDown(self)
1124
 
 
1125
 
    def _install_env(self, env):
1126
 
        for name, value in env.iteritems():
1127
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1128
 
 
1129
 
    def _restore_env(self):
1130
 
        for name, value in self._old_env.iteritems():
1131
 
            osutils.set_or_unset_env(name, value)
1132
 
 
1133
1192
    def _proxied_request(self):
1134
1193
        handler = _urllib2_wrappers.ProxyHandler()
1135
 
        request = _urllib2_wrappers.Request('GET','http://baz/buzzle')
 
1194
        request = _urllib2_wrappers.Request('GET', 'http://baz/buzzle')
1136
1195
        handler.set_proxy(request, 'http')
1137
1196
        return request
1138
1197
 
 
1198
    def assertEvaluateProxyBypass(self, expected, host, no_proxy):
 
1199
        handler = _urllib2_wrappers.ProxyHandler()
 
1200
        self.assertEquals(expected,
 
1201
                          handler.evaluate_proxy_bypass(host, no_proxy))
 
1202
 
1139
1203
    def test_empty_user(self):
1140
 
        self._install_env({'http_proxy': 'http://bar.com'})
 
1204
        self.overrideEnv('http_proxy', 'http://bar.com')
 
1205
        request = self._proxied_request()
 
1206
        self.assertFalse(request.headers.has_key('Proxy-authorization'))
 
1207
 
 
1208
    def test_user_with_at(self):
 
1209
        self.overrideEnv('http_proxy',
 
1210
                         'http://username@domain:password@proxy_host:1234')
1141
1211
        request = self._proxied_request()
1142
1212
        self.assertFalse(request.headers.has_key('Proxy-authorization'))
1143
1213
 
1144
1214
    def test_invalid_proxy(self):
1145
1215
        """A proxy env variable without scheme"""
1146
 
        self._install_env({'http_proxy': 'host:1234'})
 
1216
        self.overrideEnv('http_proxy', 'host:1234')
1147
1217
        self.assertRaises(errors.InvalidURL, self._proxied_request)
1148
1218
 
 
1219
    def test_evaluate_proxy_bypass_true(self):
 
1220
        """The host is not proxied"""
 
1221
        self.assertEvaluateProxyBypass(True, 'example.com', 'example.com')
 
1222
        self.assertEvaluateProxyBypass(True, 'bzr.example.com', '*example.com')
 
1223
 
 
1224
    def test_evaluate_proxy_bypass_false(self):
 
1225
        """The host is proxied"""
 
1226
        self.assertEvaluateProxyBypass(False, 'bzr.example.com', None)
 
1227
 
 
1228
    def test_evaluate_proxy_bypass_unknown(self):
 
1229
        """The host is not explicitly proxied"""
 
1230
        self.assertEvaluateProxyBypass(None, 'example.com', 'not.example.com')
 
1231
        self.assertEvaluateProxyBypass(None, 'bzr.example.com', 'example.com')
 
1232
 
 
1233
    def test_evaluate_proxy_bypass_empty_entries(self):
 
1234
        """Ignore empty entries"""
 
1235
        self.assertEvaluateProxyBypass(None, 'example.com', '')
 
1236
        self.assertEvaluateProxyBypass(None, 'example.com', ',')
 
1237
        self.assertEvaluateProxyBypass(None, 'example.com', 'foo,,bar')
 
1238
 
1149
1239
 
1150
1240
class TestProxyHttpServer(http_utils.TestCaseWithTwoWebservers):
1151
1241
    """Tests proxy server.
1156
1246
    to the file names).
1157
1247
    """
1158
1248
 
 
1249
    scenarios = multiply_scenarios(
 
1250
        vary_by_http_client_implementation(),
 
1251
        vary_by_http_protocol_version(),
 
1252
        )
 
1253
 
1159
1254
    # FIXME: We don't have an https server available, so we don't
1160
 
    # test https connections.
 
1255
    # test https connections. --vila toolongago
1161
1256
 
1162
1257
    def setUp(self):
1163
1258
        super(TestProxyHttpServer, self).setUp()
 
1259
        self.transport_secondary_server = http_utils.ProxyServer
1164
1260
        self.build_tree_contents([('foo', 'contents of foo\n'),
1165
1261
                                  ('foo-proxied', 'proxied contents of foo\n')])
1166
1262
        # Let's setup some attributes for tests
1167
 
        self.server = self.get_readonly_server()
1168
 
        self.proxy_address = '%s:%d' % (self.server.host, self.server.port)
 
1263
        server = self.get_readonly_server()
 
1264
        self.server_host_port = '%s:%d' % (server.host, server.port)
1169
1265
        if self._testing_pycurl():
1170
1266
            # Oh my ! pycurl does not check for the port as part of
1171
1267
            # no_proxy :-( So we just test the host part
1172
 
            self.no_proxy_host = self.server.host
 
1268
            self.no_proxy_host = server.host
1173
1269
        else:
1174
 
            self.no_proxy_host = self.proxy_address
 
1270
            self.no_proxy_host = self.server_host_port
1175
1271
        # The secondary server is the proxy
1176
 
        self.proxy = self.get_secondary_server()
1177
 
        self.proxy_url = self.proxy.get_url()
1178
 
        self._old_env = {}
 
1272
        self.proxy_url = self.get_secondary_url()
1179
1273
 
1180
1274
    def _testing_pycurl(self):
1181
1275
        # TODO: This is duplicated for lots of the classes in this file
1182
1276
        return (features.pycurl.available()
1183
1277
                and self._transport == PyCurlTransport)
1184
1278
 
1185
 
    def create_transport_secondary_server(self):
1186
 
        """Creates an http server that will serve files with
1187
 
        '-proxied' appended to their names.
1188
 
        """
1189
 
        return http_utils.ProxyServer(protocol_version=self._protocol_version)
1190
 
 
1191
 
    def _install_env(self, env):
1192
 
        for name, value in env.iteritems():
1193
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1194
 
 
1195
 
    def _restore_env(self):
1196
 
        for name, value in self._old_env.iteritems():
1197
 
            osutils.set_or_unset_env(name, value)
1198
 
 
1199
 
    def proxied_in_env(self, env):
1200
 
        self._install_env(env)
1201
 
        url = self.server.get_url()
1202
 
        t = self._transport(url)
1203
 
        try:
1204
 
            self.assertEqual('proxied contents of foo\n', t.get('foo').read())
1205
 
        finally:
1206
 
            self._restore_env()
1207
 
 
1208
 
    def not_proxied_in_env(self, env):
1209
 
        self._install_env(env)
1210
 
        url = self.server.get_url()
1211
 
        t = self._transport(url)
1212
 
        try:
1213
 
            self.assertEqual('contents of foo\n', t.get('foo').read())
1214
 
        finally:
1215
 
            self._restore_env()
 
1279
    def assertProxied(self):
 
1280
        t = self.get_readonly_transport()
 
1281
        self.assertEqual('proxied contents of foo\n', t.get('foo').read())
 
1282
 
 
1283
    def assertNotProxied(self):
 
1284
        t = self.get_readonly_transport()
 
1285
        self.assertEqual('contents of foo\n', t.get('foo').read())
1216
1286
 
1217
1287
    def test_http_proxy(self):
1218
 
        self.proxied_in_env({'http_proxy': self.proxy_url})
 
1288
        self.overrideEnv('http_proxy', self.proxy_url)
 
1289
        self.assertProxied()
1219
1290
 
1220
1291
    def test_HTTP_PROXY(self):
1221
1292
        if self._testing_pycurl():
1224
1295
            # about. Should we ?)
1225
1296
            raise tests.TestNotApplicable(
1226
1297
                'pycurl does not check HTTP_PROXY for security reasons')
1227
 
        self.proxied_in_env({'HTTP_PROXY': self.proxy_url})
 
1298
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
 
1299
        self.assertProxied()
1228
1300
 
1229
1301
    def test_all_proxy(self):
1230
 
        self.proxied_in_env({'all_proxy': self.proxy_url})
 
1302
        self.overrideEnv('all_proxy', self.proxy_url)
 
1303
        self.assertProxied()
1231
1304
 
1232
1305
    def test_ALL_PROXY(self):
1233
 
        self.proxied_in_env({'ALL_PROXY': self.proxy_url})
 
1306
        self.overrideEnv('ALL_PROXY', self.proxy_url)
 
1307
        self.assertProxied()
1234
1308
 
1235
1309
    def test_http_proxy_with_no_proxy(self):
1236
 
        self.not_proxied_in_env({'http_proxy': self.proxy_url,
1237
 
                                 'no_proxy': self.no_proxy_host})
 
1310
        self.overrideEnv('no_proxy', self.no_proxy_host)
 
1311
        self.overrideEnv('http_proxy', self.proxy_url)
 
1312
        self.assertNotProxied()
1238
1313
 
1239
1314
    def test_HTTP_PROXY_with_NO_PROXY(self):
1240
1315
        if self._testing_pycurl():
1241
1316
            raise tests.TestNotApplicable(
1242
1317
                'pycurl does not check HTTP_PROXY for security reasons')
1243
 
        self.not_proxied_in_env({'HTTP_PROXY': self.proxy_url,
1244
 
                                 'NO_PROXY': self.no_proxy_host})
 
1318
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
 
1319
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
 
1320
        self.assertNotProxied()
1245
1321
 
1246
1322
    def test_all_proxy_with_no_proxy(self):
1247
 
        self.not_proxied_in_env({'all_proxy': self.proxy_url,
1248
 
                                 'no_proxy': self.no_proxy_host})
 
1323
        self.overrideEnv('no_proxy', self.no_proxy_host)
 
1324
        self.overrideEnv('all_proxy', self.proxy_url)
 
1325
        self.assertNotProxied()
1249
1326
 
1250
1327
    def test_ALL_PROXY_with_NO_PROXY(self):
1251
 
        self.not_proxied_in_env({'ALL_PROXY': self.proxy_url,
1252
 
                                 'NO_PROXY': self.no_proxy_host})
 
1328
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
 
1329
        self.overrideEnv('ALL_PROXY', self.proxy_url)
 
1330
        self.assertNotProxied()
1253
1331
 
1254
1332
    def test_http_proxy_without_scheme(self):
 
1333
        self.overrideEnv('http_proxy', self.server_host_port)
1255
1334
        if self._testing_pycurl():
1256
1335
            # pycurl *ignores* invalid proxy env variables. If that ever change
1257
1336
            # in the future, this test will fail indicating that pycurl do not
1258
1337
            # ignore anymore such variables.
1259
 
            self.not_proxied_in_env({'http_proxy': self.proxy_address})
 
1338
            self.assertNotProxied()
1260
1339
        else:
1261
 
            self.assertRaises(errors.InvalidURL,
1262
 
                              self.proxied_in_env,
1263
 
                              {'http_proxy': self.proxy_address})
 
1340
            self.assertRaises(errors.InvalidURL, self.assertProxied)
1264
1341
 
1265
1342
 
1266
1343
class TestRanges(http_utils.TestCaseWithWebserver):
1267
1344
    """Test the Range header in GET methods."""
1268
1345
 
 
1346
    scenarios = multiply_scenarios(
 
1347
        vary_by_http_client_implementation(),
 
1348
        vary_by_http_protocol_version(),
 
1349
        )
 
1350
 
1269
1351
    def setUp(self):
1270
1352
        http_utils.TestCaseWithWebserver.setUp(self)
1271
1353
        self.build_tree_contents([('a', '0123456789')],)
1272
 
        server = self.get_readonly_server()
1273
 
        self.transport = self._transport(server.get_url())
1274
1354
 
1275
1355
    def create_transport_readonly_server(self):
1276
1356
        return http_server.HttpServer(protocol_version=self._protocol_version)
1277
1357
 
1278
1358
    def _file_contents(self, relpath, ranges):
 
1359
        t = self.get_readonly_transport()
1279
1360
        offsets = [ (start, end - start + 1) for start, end in ranges]
1280
 
        coalesce = self.transport._coalesce_offsets
 
1361
        coalesce = t._coalesce_offsets
1281
1362
        coalesced = list(coalesce(offsets, limit=0, fudge_factor=0))
1282
 
        code, data = self.transport._get(relpath, coalesced)
 
1363
        code, data = t._get(relpath, coalesced)
1283
1364
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1284
1365
        for start, end in ranges:
1285
1366
            data.seek(start)
1286
1367
            yield data.read(end - start + 1)
1287
1368
 
1288
1369
    def _file_tail(self, relpath, tail_amount):
1289
 
        code, data = self.transport._get(relpath, [], tail_amount)
 
1370
        t = self.get_readonly_transport()
 
1371
        code, data = t._get(relpath, [], tail_amount)
1290
1372
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1291
1373
        data.seek(-tail_amount, 2)
1292
1374
        return data.read(tail_amount)
1311
1393
class TestHTTPRedirections(http_utils.TestCaseWithRedirectedWebserver):
1312
1394
    """Test redirection between http servers."""
1313
1395
 
1314
 
    def create_transport_secondary_server(self):
1315
 
        """Create the secondary server redirecting to the primary server"""
1316
 
        new = self.get_readonly_server()
1317
 
 
1318
 
        redirecting = http_utils.HTTPServerRedirecting(
1319
 
            protocol_version=self._protocol_version)
1320
 
        redirecting.redirect_to(new.host, new.port)
1321
 
        return redirecting
 
1396
    scenarios = multiply_scenarios(
 
1397
        vary_by_http_client_implementation(),
 
1398
        vary_by_http_protocol_version(),
 
1399
        )
1322
1400
 
1323
1401
    def setUp(self):
1324
1402
        super(TestHTTPRedirections, self).setUp()
1326
1404
                                  ('bundle',
1327
1405
                                  '# Bazaar revision bundle v0.9\n#\n')
1328
1406
                                  ],)
1329
 
        # The requests to the old server will be redirected to the new server
1330
 
        self.old_transport = self._transport(self.old_server.get_url())
1331
1407
 
1332
1408
    def test_redirected(self):
1333
 
        self.assertRaises(errors.RedirectRequested, self.old_transport.get, 'a')
1334
 
        t = self._transport(self.new_server.get_url())
1335
 
        self.assertEqual('0123456789', t.get('a').read())
1336
 
 
1337
 
    def test_read_redirected_bundle_from_url(self):
1338
 
        from bzrlib.bundle import read_bundle_from_url
1339
 
        url = self.old_transport.abspath('bundle')
1340
 
        bundle = self.applyDeprecated(deprecated_in((1, 12, 0)),
1341
 
                read_bundle_from_url, url)
1342
 
        # If read_bundle_from_url was successful we get an empty bundle
1343
 
        self.assertEqual([], bundle.revisions)
 
1409
        self.assertRaises(errors.RedirectRequested,
 
1410
                          self.get_old_transport().get, 'a')
 
1411
        self.assertEqual('0123456789', self.get_new_transport().get('a').read())
1344
1412
 
1345
1413
 
1346
1414
class RedirectedRequest(_urllib2_wrappers.Request):
1363
1431
    test.overrideAttr(_urllib2_wrappers, 'Request', RedirectedRequest)
1364
1432
 
1365
1433
 
 
1434
def cleanup_http_redirection_connections(test):
 
1435
    # Some sockets are opened but never seen by _urllib, so we trap them at
 
1436
    # the _urllib2_wrappers level to be able to clean them up.
 
1437
    def socket_disconnect(sock):
 
1438
        try:
 
1439
            sock.shutdown(socket.SHUT_RDWR)
 
1440
            sock.close()
 
1441
        except socket.error:
 
1442
            pass
 
1443
    def connect(connection):
 
1444
        test.http_connect_orig(connection)
 
1445
        test.addCleanup(socket_disconnect, connection.sock)
 
1446
    test.http_connect_orig = test.overrideAttr(
 
1447
        _urllib2_wrappers.HTTPConnection, 'connect', connect)
 
1448
    def connect(connection):
 
1449
        test.https_connect_orig(connection)
 
1450
        test.addCleanup(socket_disconnect, connection.sock)
 
1451
    test.https_connect_orig = test.overrideAttr(
 
1452
        _urllib2_wrappers.HTTPSConnection, 'connect', connect)
 
1453
 
 
1454
 
1366
1455
class TestHTTPSilentRedirections(http_utils.TestCaseWithRedirectedWebserver):
1367
1456
    """Test redirections.
1368
1457
 
1377
1466
    -- vila 20070212
1378
1467
    """
1379
1468
 
 
1469
    scenarios = multiply_scenarios(
 
1470
        vary_by_http_client_implementation(),
 
1471
        vary_by_http_protocol_version(),
 
1472
        )
 
1473
 
1380
1474
    def setUp(self):
1381
1475
        if (features.pycurl.available()
1382
1476
            and self._transport == PyCurlTransport):
1383
1477
            raise tests.TestNotApplicable(
1384
 
                "pycurl doesn't redirect silently annymore")
 
1478
                "pycurl doesn't redirect silently anymore")
1385
1479
        super(TestHTTPSilentRedirections, self).setUp()
1386
1480
        install_redirected_request(self)
 
1481
        cleanup_http_redirection_connections(self)
1387
1482
        self.build_tree_contents([('a','a'),
1388
1483
                                  ('1/',),
1389
1484
                                  ('1/a', 'redirected once'),
1397
1492
                                  ('5/a', 'redirected 5 times'),
1398
1493
                                  ],)
1399
1494
 
1400
 
        self.old_transport = self._transport(self.old_server.get_url())
1401
 
 
1402
 
    def create_transport_secondary_server(self):
1403
 
        """Create the secondary server, redirections are defined in the tests"""
1404
 
        return http_utils.HTTPServerRedirecting(
1405
 
            protocol_version=self._protocol_version)
1406
 
 
1407
1495
    def test_one_redirection(self):
1408
 
        t = self.old_transport
1409
 
 
1410
 
        req = RedirectedRequest('GET', t.abspath('a'))
 
1496
        t = self.get_old_transport()
 
1497
        req = RedirectedRequest('GET', t._remote_path('a'))
1411
1498
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1412
1499
                                       self.new_server.port)
1413
1500
        self.old_server.redirections = \
1414
1501
            [('(.*)', r'%s/1\1' % (new_prefix), 301),]
1415
 
        self.assertEqual('redirected once',t._perform(req).read())
 
1502
        self.assertEqual('redirected once', t._perform(req).read())
1416
1503
 
1417
1504
    def test_five_redirections(self):
1418
 
        t = self.old_transport
1419
 
 
1420
 
        req = RedirectedRequest('GET', t.abspath('a'))
 
1505
        t = self.get_old_transport()
 
1506
        req = RedirectedRequest('GET', t._remote_path('a'))
1421
1507
        old_prefix = 'http://%s:%s' % (self.old_server.host,
1422
1508
                                       self.old_server.port)
1423
1509
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1429
1515
            ('/4(.*)', r'%s/5\1' % (new_prefix), 301),
1430
1516
            ('(/[^/]+)', r'%s/1\1' % (old_prefix), 301),
1431
1517
            ]
1432
 
        self.assertEqual('redirected 5 times',t._perform(req).read())
 
1518
        self.assertEqual('redirected 5 times', t._perform(req).read())
1433
1519
 
1434
1520
 
1435
1521
class TestDoCatchRedirections(http_utils.TestCaseWithRedirectedWebserver):
1436
1522
    """Test transport.do_catching_redirections."""
1437
1523
 
 
1524
    scenarios = multiply_scenarios(
 
1525
        vary_by_http_client_implementation(),
 
1526
        vary_by_http_protocol_version(),
 
1527
        )
 
1528
 
1438
1529
    def setUp(self):
1439
1530
        super(TestDoCatchRedirections, self).setUp()
1440
1531
        self.build_tree_contents([('a', '0123456789'),],)
1441
 
 
1442
 
        self.old_transport = self._transport(self.old_server.get_url())
1443
 
 
1444
 
    def get_a(self, transport):
1445
 
        return transport.get('a')
 
1532
        cleanup_http_redirection_connections(self)
 
1533
 
 
1534
        self.old_transport = self.get_old_transport()
 
1535
 
 
1536
    def get_a(self, t):
 
1537
        return t.get('a')
1446
1538
 
1447
1539
    def test_no_redirection(self):
1448
 
        t = self._transport(self.new_server.get_url())
 
1540
        t = self.get_new_transport()
1449
1541
 
1450
1542
        # We use None for redirected so that we fail if redirected
1451
1543
        self.assertEqual('0123456789',
1455
1547
    def test_one_redirection(self):
1456
1548
        self.redirections = 0
1457
1549
 
1458
 
        def redirected(transport, exception, redirection_notice):
 
1550
        def redirected(t, exception, redirection_notice):
1459
1551
            self.redirections += 1
1460
 
            dir, file = urlutils.split(exception.target)
1461
 
            return self._transport(dir)
 
1552
            redirected_t = t._redirected_to(exception.source, exception.target)
 
1553
            return redirected_t
1462
1554
 
1463
1555
        self.assertEqual('0123456789',
1464
1556
                         transport.do_catching_redirections(
1478
1570
                          self.get_a, self.old_transport, redirected)
1479
1571
 
1480
1572
 
 
1573
def _setup_authentication_config(**kwargs):
 
1574
    conf = config.AuthenticationConfig()
 
1575
    conf._get_config().update({'httptest': kwargs})
 
1576
    conf._save()
 
1577
 
 
1578
 
 
1579
class TestUrllib2AuthHandler(tests.TestCaseWithTransport):
 
1580
    """Unit tests for glue by which urllib2 asks us for authentication"""
 
1581
 
 
1582
    def test_get_user_password_without_port(self):
 
1583
        """We cope if urllib2 doesn't tell us the port.
 
1584
 
 
1585
        See https://bugs.launchpad.net/bzr/+bug/654684
 
1586
        """
 
1587
        user = 'joe'
 
1588
        password = 'foo'
 
1589
        _setup_authentication_config(scheme='http', host='localhost',
 
1590
                                     user=user, password=password)
 
1591
        handler = _urllib2_wrappers.HTTPAuthHandler()
 
1592
        got_pass = handler.get_user_password(dict(
 
1593
            user='joe',
 
1594
            protocol='http',
 
1595
            host='localhost',
 
1596
            path='/',
 
1597
            realm='Realm',
 
1598
            ))
 
1599
        self.assertEquals((user, password), got_pass)
 
1600
 
 
1601
 
1481
1602
class TestAuth(http_utils.TestCaseWithWebserver):
1482
1603
    """Test authentication scheme"""
1483
1604
 
1484
 
    _auth_header = 'Authorization'
1485
 
    _password_prompt_prefix = ''
1486
 
    _username_prompt_prefix = ''
1487
 
    # Set by load_tests
1488
 
    _auth_server = None
 
1605
    scenarios = multiply_scenarios(
 
1606
        vary_by_http_client_implementation(),
 
1607
        vary_by_http_protocol_version(),
 
1608
        vary_by_http_auth_scheme(),
 
1609
        )
1489
1610
 
1490
1611
    def setUp(self):
1491
1612
        super(TestAuth, self).setUp()
1494
1615
                                  ('b', 'contents of b\n'),])
1495
1616
 
1496
1617
    def create_transport_readonly_server(self):
1497
 
        return self._auth_server(protocol_version=self._protocol_version)
 
1618
        server = self._auth_server(protocol_version=self._protocol_version)
 
1619
        server._url_protocol = self._url_protocol
 
1620
        return server
1498
1621
 
1499
1622
    def _testing_pycurl(self):
1500
1623
        # TODO: This is duplicated for lots of the classes in this file
1513
1636
        return url
1514
1637
 
1515
1638
    def get_user_transport(self, user, password):
1516
 
        return self._transport(self.get_user_url(user, password))
 
1639
        t = transport.get_transport_from_url(
 
1640
            self.get_user_url(user, password))
 
1641
        return t
1517
1642
 
1518
1643
    def test_no_user(self):
1519
1644
        self.server.add_user('joe', 'foo')
1630
1755
        ui.ui_factory = tests.TestUIFactory(stdin=stdin_content,
1631
1756
                                            stderr=tests.StringIOWrapper())
1632
1757
        # Create a minimal config file with the right password
1633
 
        conf = config.AuthenticationConfig()
1634
 
        conf._get_config().update(
1635
 
            {'httptest': {'scheme': 'http', 'port': self.server.port,
1636
 
                          'user': user, 'password': password}})
1637
 
        conf._save()
 
1758
        _setup_authentication_config(scheme='http', port=self.server.port,
 
1759
                                     user=user, password=password)
1638
1760
        # Issue a request to the server to connect
1639
1761
        self.assertEqual('contents of a\n',t.get('a').read())
1640
1762
        # stdin should have  been left untouched
1642
1764
        # Only one 'Authentication Required' error should occur
1643
1765
        self.assertEqual(1, self.server.auth_required_errors)
1644
1766
 
1645
 
    def test_user_from_auth_conf(self):
1646
 
        if self._testing_pycurl():
1647
 
            raise tests.TestNotApplicable(
1648
 
                'pycurl does not support authentication.conf')
1649
 
        user = 'joe'
1650
 
        password = 'foo'
1651
 
        self.server.add_user(user, password)
1652
 
        # Create a minimal config file with the right password
1653
 
        conf = config.AuthenticationConfig()
1654
 
        conf._get_config().update(
1655
 
            {'httptest': {'scheme': 'http', 'port': self.server.port,
1656
 
                          'user': user, 'password': password}})
1657
 
        conf._save()
1658
 
        t = self.get_user_transport(None, None)
1659
 
        # Issue a request to the server to connect
1660
 
        self.assertEqual('contents of a\n', t.get('a').read())
1661
 
        # Only one 'Authentication Required' error should occur
1662
 
        self.assertEqual(1, self.server.auth_required_errors)
1663
 
 
1664
1767
    def test_changing_nonce(self):
1665
1768
        if self._auth_server not in (http_utils.HTTPDigestAuthServer,
1666
1769
                                     http_utils.ProxyDigestAuthServer):
1667
1770
            raise tests.TestNotApplicable('HTTP/proxy auth digest only test')
1668
1771
        if self._testing_pycurl():
1669
 
            raise tests.KnownFailure(
 
1772
            self.knownFailure(
1670
1773
                'pycurl does not handle a nonce change')
1671
1774
        self.server.add_user('joe', 'foo')
1672
1775
        t = self.get_user_transport('joe', 'foo')
1682
1785
        # initial 'who are you' and a second 'who are you' with the new nonce)
1683
1786
        self.assertEqual(2, self.server.auth_required_errors)
1684
1787
 
 
1788
    def test_user_from_auth_conf(self):
 
1789
        if self._testing_pycurl():
 
1790
            raise tests.TestNotApplicable(
 
1791
                'pycurl does not support authentication.conf')
 
1792
        user = 'joe'
 
1793
        password = 'foo'
 
1794
        self.server.add_user(user, password)
 
1795
        _setup_authentication_config(scheme='http', port=self.server.port,
 
1796
                                     user=user, password=password)
 
1797
        t = self.get_user_transport(None, None)
 
1798
        # Issue a request to the server to connect
 
1799
        self.assertEqual('contents of a\n', t.get('a').read())
 
1800
        # Only one 'Authentication Required' error should occur
 
1801
        self.assertEqual(1, self.server.auth_required_errors)
 
1802
 
 
1803
    def test_no_credential_leaks_in_log(self):
 
1804
        self.overrideAttr(debug, 'debug_flags', set(['http']))
 
1805
        user = 'joe'
 
1806
        password = 'very-sensitive-password'
 
1807
        self.server.add_user(user, password)
 
1808
        t = self.get_user_transport(user, password)
 
1809
        # Capture the debug calls to mutter
 
1810
        self.mutters = []
 
1811
        def mutter(*args):
 
1812
            lines = args[0] % args[1:]
 
1813
            # Some calls output multiple lines, just split them now since we
 
1814
            # care about a single one later.
 
1815
            self.mutters.extend(lines.splitlines())
 
1816
        self.overrideAttr(trace, 'mutter', mutter)
 
1817
        # Issue a request to the server to connect
 
1818
        self.assertEqual(True, t.has('a'))
 
1819
        # Only one 'Authentication Required' error should occur
 
1820
        self.assertEqual(1, self.server.auth_required_errors)
 
1821
        # Since the authentification succeeded, there should be a corresponding
 
1822
        # debug line
 
1823
        sent_auth_headers = [line for line in self.mutters
 
1824
                             if line.startswith('> %s' % (self._auth_header,))]
 
1825
        self.assertLength(1, sent_auth_headers)
 
1826
        self.assertStartsWith(sent_auth_headers[0],
 
1827
                              '> %s: <masked>' % (self._auth_header,))
1685
1828
 
1686
1829
 
1687
1830
class TestProxyAuth(TestAuth):
1688
 
    """Test proxy authentication schemes."""
1689
 
 
1690
 
    _auth_header = 'Proxy-authorization'
1691
 
    _password_prompt_prefix = 'Proxy '
1692
 
    _username_prompt_prefix = 'Proxy '
 
1831
    """Test proxy authentication schemes.
 
1832
 
 
1833
    This inherits from TestAuth to tweak the setUp and filter some failing
 
1834
    tests.
 
1835
    """
 
1836
 
 
1837
    scenarios = multiply_scenarios(
 
1838
        vary_by_http_client_implementation(),
 
1839
        vary_by_http_protocol_version(),
 
1840
        vary_by_http_proxy_auth_scheme(),
 
1841
        )
1693
1842
 
1694
1843
    def setUp(self):
1695
1844
        super(TestProxyAuth, self).setUp()
1696
 
        self._old_env = {}
1697
 
        self.addCleanup(self._restore_env)
1698
1845
        # Override the contents to avoid false positives
1699
1846
        self.build_tree_contents([('a', 'not proxied contents of a\n'),
1700
1847
                                  ('b', 'not proxied contents of b\n'),
1703
1850
                                  ])
1704
1851
 
1705
1852
    def get_user_transport(self, user, password):
1706
 
        self._install_env({'all_proxy': self.get_user_url(user, password)})
1707
 
        return self._transport(self.server.get_url())
1708
 
 
1709
 
    def _install_env(self, env):
1710
 
        for name, value in env.iteritems():
1711
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1712
 
 
1713
 
    def _restore_env(self):
1714
 
        for name, value in self._old_env.iteritems():
1715
 
            osutils.set_or_unset_env(name, value)
 
1853
        self.overrideEnv('all_proxy', self.get_user_url(user, password))
 
1854
        return TestAuth.get_user_transport(self, user, password)
1716
1855
 
1717
1856
    def test_empty_pass(self):
1718
1857
        if self._testing_pycurl():
1719
1858
            import pycurl
1720
1859
            if pycurl.version_info()[1] < '7.16.0':
1721
 
                raise tests.KnownFailure(
 
1860
                self.knownFailure(
1722
1861
                    'pycurl < 7.16.0 does not handle empty proxy passwords')
1723
1862
        super(TestProxyAuth, self).test_empty_pass()
1724
1863
 
1737
1876
        self.readfile = StringIO(socket_read_content)
1738
1877
        self.writefile = StringIO()
1739
1878
        self.writefile.close = lambda: None
 
1879
        self.close = lambda: None
1740
1880
 
1741
1881
    def makefile(self, mode='r', bufsize=None):
1742
1882
        if 'r' in mode:
1747
1887
 
1748
1888
class SmartHTTPTunnellingTest(tests.TestCaseWithTransport):
1749
1889
 
 
1890
    scenarios = multiply_scenarios(
 
1891
        vary_by_http_client_implementation(),
 
1892
        vary_by_http_protocol_version(),
 
1893
        )
 
1894
 
1750
1895
    def setUp(self):
1751
1896
        super(SmartHTTPTunnellingTest, self).setUp()
1752
1897
        # We use the VFS layer as part of HTTP tunnelling tests.
1753
 
        self._captureVar('BZR_NO_SMART_VFS', None)
 
1898
        self.overrideEnv('BZR_NO_SMART_VFS', None)
1754
1899
        self.transport_readonly_server = http_utils.HTTPServerWithSmarts
 
1900
        self.http_server = self.get_readonly_server()
1755
1901
 
1756
1902
    def create_transport_readonly_server(self):
1757
 
        return http_utils.HTTPServerWithSmarts(
 
1903
        server = http_utils.HTTPServerWithSmarts(
1758
1904
            protocol_version=self._protocol_version)
 
1905
        server._url_protocol = self._url_protocol
 
1906
        return server
1759
1907
 
1760
1908
    def test_open_bzrdir(self):
1761
1909
        branch = self.make_branch('relpath')
1762
 
        http_server = self.get_readonly_server()
1763
 
        url = http_server.get_url() + 'relpath'
 
1910
        url = self.http_server.get_url() + 'relpath'
1764
1911
        bd = bzrdir.BzrDir.open(url)
 
1912
        self.addCleanup(bd.transport.disconnect)
1765
1913
        self.assertIsInstance(bd, _mod_remote.RemoteBzrDir)
1766
1914
 
1767
1915
    def test_bulk_data(self):
1769
1917
        # The 'readv' command in the smart protocol both sends and receives
1770
1918
        # bulk data, so we use that.
1771
1919
        self.build_tree(['data-file'])
1772
 
        http_server = self.get_readonly_server()
1773
 
        http_transport = self._transport(http_server.get_url())
 
1920
        http_transport = transport.get_transport_from_url(
 
1921
            self.http_server.get_url())
1774
1922
        medium = http_transport.get_smart_medium()
1775
1923
        # Since we provide the medium, the url below will be mostly ignored
1776
1924
        # during the test, as long as the path is '/'.
1784
1932
        post_body = 'hello\n'
1785
1933
        expected_reply_body = 'ok\x012\n'
1786
1934
 
1787
 
        http_server = self.get_readonly_server()
1788
 
        http_transport = self._transport(http_server.get_url())
 
1935
        http_transport = transport.get_transport_from_url(
 
1936
            self.http_server.get_url())
1789
1937
        medium = http_transport.get_smart_medium()
1790
1938
        response = medium.send_http_smart_request(post_body)
1791
1939
        reply_body = response.read()
1792
1940
        self.assertEqual(expected_reply_body, reply_body)
1793
1941
 
1794
1942
    def test_smart_http_server_post_request_handler(self):
1795
 
        httpd = self.get_readonly_server()._get_httpd()
 
1943
        httpd = self.http_server.server
1796
1944
 
1797
1945
        socket = SampleSocket(
1798
1946
            'POST /.bzr/smart %s \r\n' % self._protocol_version
1830
1978
 
1831
1979
    def test_probe_smart_server(self):
1832
1980
        """Test error handling against server refusing smart requests."""
1833
 
        server = self.get_readonly_server()
1834
 
        t = self._transport(server.get_url())
 
1981
        t = self.get_readonly_transport()
1835
1982
        # No need to build a valid smart request here, the server will not even
1836
1983
        # try to interpret it.
1837
1984
        self.assertRaises(errors.SmartProtocolError,
1838
1985
                          t.get_smart_medium().send_http_smart_request,
1839
1986
                          'whatever')
1840
1987
 
 
1988
 
1841
1989
class Test_redirected_to(tests.TestCase):
1842
1990
 
 
1991
    scenarios = vary_by_http_client_implementation()
 
1992
 
1843
1993
    def test_redirected_to_subdir(self):
1844
1994
        t = self._transport('http://www.example.com/foo')
1845
1995
        r = t._redirected_to('http://www.example.com/foo',
1847
1997
        self.assertIsInstance(r, type(t))
1848
1998
        # Both transports share the some connection
1849
1999
        self.assertEqual(t._get_connection(), r._get_connection())
 
2000
        self.assertEquals('http://www.example.com/foo/subdir/', r.base)
1850
2001
 
1851
2002
    def test_redirected_to_self_with_slash(self):
1852
2003
        t = self._transport('http://www.example.com/foo')
1863
2014
        r = t._redirected_to('http://www.example.com/foo',
1864
2015
                             'http://foo.example.com/foo/subdir')
1865
2016
        self.assertIsInstance(r, type(t))
 
2017
        self.assertEquals('http://foo.example.com/foo/subdir/',
 
2018
            r.external_url())
1866
2019
 
1867
2020
    def test_redirected_to_same_host_sibling_protocol(self):
1868
2021
        t = self._transport('http://www.example.com/foo')
1869
2022
        r = t._redirected_to('http://www.example.com/foo',
1870
2023
                             'https://www.example.com/foo')
1871
2024
        self.assertIsInstance(r, type(t))
 
2025
        self.assertEquals('https://www.example.com/foo/',
 
2026
            r.external_url())
1872
2027
 
1873
2028
    def test_redirected_to_same_host_different_protocol(self):
1874
2029
        t = self._transport('http://www.example.com/foo')
1875
2030
        r = t._redirected_to('http://www.example.com/foo',
1876
2031
                             'ftp://www.example.com/foo')
1877
2032
        self.assertNotEquals(type(r), type(t))
 
2033
        self.assertEquals('ftp://www.example.com/foo/', r.external_url())
 
2034
 
 
2035
    def test_redirected_to_same_host_specific_implementation(self):
 
2036
        t = self._transport('http://www.example.com/foo')
 
2037
        r = t._redirected_to('http://www.example.com/foo',
 
2038
                             'https+urllib://www.example.com/foo')
 
2039
        self.assertEquals('https://www.example.com/foo/', r.external_url())
1878
2040
 
1879
2041
    def test_redirected_to_different_host_same_user(self):
1880
2042
        t = self._transport('http://joe@www.example.com/foo')
1881
2043
        r = t._redirected_to('http://www.example.com/foo',
1882
2044
                             'https://foo.example.com/foo')
1883
2045
        self.assertIsInstance(r, type(t))
1884
 
        self.assertEqual(t._user, r._user)
 
2046
        self.assertEqual(t._parsed_url.user, r._parsed_url.user)
 
2047
        self.assertEquals('https://joe@foo.example.com/foo/', r.external_url())
1885
2048
 
1886
2049
 
1887
2050
class PredefinedRequestHandler(http_server.TestingHTTPRequestHandler):
1896
2059
    line.
1897
2060
    """
1898
2061
 
1899
 
    def handle_one_request(self):
 
2062
    def _handle_one_request(self):
1900
2063
        tcs = self.server.test_case_server
1901
2064
        requestline = self.rfile.readline()
1902
2065
        headers = self.MessageClass(self.rfile, 0)
1940
2103
    pass
1941
2104
 
1942
2105
 
1943
 
if tests.HTTPSServerFeature.available():
 
2106
if features.HTTPSServerFeature.available():
1944
2107
    from bzrlib.tests import https_server
1945
2108
    class ActivityHTTPSServer(ActivityServerMixin, https_server.HTTPSServer):
1946
2109
        pass
1957
2120
        tests.TestCase.setUp(self)
1958
2121
        self.server = self._activity_server(self._protocol_version)
1959
2122
        self.server.start_server()
1960
 
        self.activities = {}
 
2123
        _activities = {} # Don't close over self and create a cycle
1961
2124
        def report_activity(t, bytes, direction):
1962
 
            count = self.activities.get(direction, 0)
 
2125
            count = _activities.get(direction, 0)
1963
2126
            count += bytes
1964
 
            self.activities[direction] = count
 
2127
            _activities[direction] = count
 
2128
        self.activities = _activities
1965
2129
 
1966
2130
        # We override at class level because constructors may propagate the
1967
2131
        # bound method and render instance overriding ineffective (an
1968
2132
        # alternative would be to define a specific ui factory instead...)
1969
 
        self.orig_report_activity = self._transport._report_activity
1970
 
        self._transport._report_activity = report_activity
1971
 
 
1972
 
    def tearDown(self):
1973
 
        self._transport._report_activity = self.orig_report_activity
1974
 
        self.server.stop_server()
1975
 
        tests.TestCase.tearDown(self)
 
2133
        self.overrideAttr(self._transport, '_report_activity', report_activity)
 
2134
        self.addCleanup(self.server.stop_server)
1976
2135
 
1977
2136
    def get_transport(self):
1978
 
        return self._transport(self.server.get_url())
 
2137
        t = self._transport(self.server.get_url())
 
2138
        # FIXME: Needs cleanup -- vila 20100611
 
2139
        return t
1979
2140
 
1980
2141
    def assertActivitiesMatch(self):
1981
2142
        self.assertEqual(self.server.bytes_read,
2086
2247
'''
2087
2248
        t = self.get_transport()
2088
2249
        # We must send a single line of body bytes, see
2089
 
        # PredefinedRequestHandler.handle_one_request
 
2250
        # PredefinedRequestHandler._handle_one_request
2090
2251
        code, f = t._post('abc def end-of-body\n')
2091
2252
        self.assertEqual('lalala whatever as long as itsssss\n', f.read())
2092
2253
        self.assertActivitiesMatch()
2094
2255
 
2095
2256
class TestActivity(tests.TestCase, TestActivityMixin):
2096
2257
 
 
2258
    scenarios = multiply_scenarios(
 
2259
        vary_by_http_activity(),
 
2260
        vary_by_http_protocol_version(),
 
2261
        )
 
2262
 
2097
2263
    def setUp(self):
2098
 
        tests.TestCase.setUp(self)
2099
 
        self.server = self._activity_server(self._protocol_version)
2100
 
        self.server.start_server()
2101
 
        self.activities = {}
2102
 
        def report_activity(t, bytes, direction):
2103
 
            count = self.activities.get(direction, 0)
2104
 
            count += bytes
2105
 
            self.activities[direction] = count
2106
 
 
2107
 
        # We override at class level because constructors may propagate the
2108
 
        # bound method and render instance overriding ineffective (an
2109
 
        # alternative would be to define a specific ui factory instead...)
2110
 
        self.orig_report_activity = self._transport._report_activity
2111
 
        self._transport._report_activity = report_activity
2112
 
 
2113
 
    def tearDown(self):
2114
 
        self._transport._report_activity = self.orig_report_activity
2115
 
        self.server.stop_server()
2116
 
        tests.TestCase.tearDown(self)
 
2264
        TestActivityMixin.setUp(self)
2117
2265
 
2118
2266
 
2119
2267
class TestNoReportActivity(tests.TestCase, TestActivityMixin):
2120
2268
 
 
2269
    # Unlike TestActivity, we are really testing ReportingFileSocket and
 
2270
    # ReportingSocket, so we don't need all the parametrization. Since
 
2271
    # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
 
2272
    # test them through their use by the transport than directly (that's a
 
2273
    # bit less clean but far more simpler and effective).
 
2274
    _activity_server = ActivityHTTPServer
 
2275
    _protocol_version = 'HTTP/1.1'
 
2276
 
2121
2277
    def setUp(self):
2122
 
        tests.TestCase.setUp(self)
2123
 
        # Unlike TestActivity, we are really testing ReportingFileSocket and
2124
 
        # ReportingSocket, so we don't need all the parametrization. Since
2125
 
        # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
2126
 
        # test them through their use by the transport than directly (that's a
2127
 
        # bit less clean but far more simpler and effective).
2128
 
        self.server = ActivityHTTPServer('HTTP/1.1')
2129
 
        self._transport=_urllib.HttpTransport_urllib
2130
 
 
2131
 
        self.server.start_server()
2132
 
 
2133
 
        # We override at class level because constructors may propagate the
2134
 
        # bound method and render instance overriding ineffective (an
2135
 
        # alternative would be to define a specific ui factory instead...)
2136
 
        self.orig_report_activity = self._transport._report_activity
2137
 
        self._transport._report_activity = None
2138
 
 
2139
 
    def tearDown(self):
2140
 
        self._transport._report_activity = self.orig_report_activity
2141
 
        self.server.stop_server()
2142
 
        tests.TestCase.tearDown(self)
 
2278
        self._transport =_urllib.HttpTransport_urllib
 
2279
        TestActivityMixin.setUp(self)
2143
2280
 
2144
2281
    def assertActivitiesMatch(self):
2145
2282
        # Nothing to check here
2149
2286
class TestAuthOnRedirected(http_utils.TestCaseWithRedirectedWebserver):
2150
2287
    """Test authentication on the redirected http server."""
2151
2288
 
 
2289
    scenarios = vary_by_http_protocol_version()
 
2290
 
2152
2291
    _auth_header = 'Authorization'
2153
2292
    _password_prompt_prefix = ''
2154
2293
    _username_prompt_prefix = ''
2155
2294
    _auth_server = http_utils.HTTPBasicAuthServer
2156
2295
    _transport = _urllib.HttpTransport_urllib
2157
2296
 
2158
 
    def create_transport_readonly_server(self):
2159
 
        return self._auth_server()
2160
 
 
2161
 
    def create_transport_secondary_server(self):
2162
 
        """Create the secondary server redirecting to the primary server"""
2163
 
        new = self.get_readonly_server()
2164
 
 
2165
 
        redirecting = http_utils.HTTPServerRedirecting()
2166
 
        redirecting.redirect_to(new.host, new.port)
2167
 
        return redirecting
2168
 
 
2169
2297
    def setUp(self):
2170
2298
        super(TestAuthOnRedirected, self).setUp()
2171
2299
        self.build_tree_contents([('a','a'),
2176
2304
                                       self.new_server.port)
2177
2305
        self.old_server.redirections = [
2178
2306
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2179
 
        self.old_transport = self._transport(self.old_server.get_url())
 
2307
        self.old_transport = self.get_old_transport()
2180
2308
        self.new_server.add_user('joe', 'foo')
2181
 
 
2182
 
    def get_a(self, transport):
2183
 
        return transport.get('a')
 
2309
        cleanup_http_redirection_connections(self)
 
2310
 
 
2311
    def create_transport_readonly_server(self):
 
2312
        server = self._auth_server(protocol_version=self._protocol_version)
 
2313
        server._url_protocol = self._url_protocol
 
2314
        return server
 
2315
 
 
2316
    def get_a(self, t):
 
2317
        return t.get('a')
2184
2318
 
2185
2319
    def test_auth_on_redirected_via_do_catching_redirections(self):
2186
2320
        self.redirections = 0
2187
2321
 
2188
 
        def redirected(transport, exception, redirection_notice):
 
2322
        def redirected(t, exception, redirection_notice):
2189
2323
            self.redirections += 1
2190
 
            dir, file = urlutils.split(exception.target)
2191
 
            return self._transport(dir)
 
2324
            redirected_t = t._redirected_to(exception.source, exception.target)
 
2325
            self.addCleanup(redirected_t.disconnect)
 
2326
            return redirected_t
2192
2327
 
2193
2328
        stdout = tests.StringIOWrapper()
2194
2329
        stderr = tests.StringIOWrapper()
2215
2350
                                       self.new_server.port)
2216
2351
        self.old_server.redirections = [
2217
2352
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2218
 
        self.assertEqual('redirected once',t._perform(req).read())
 
2353
        self.assertEqual('redirected once', t._perform(req).read())
2219
2354
        # stdin should be empty
2220
2355
        self.assertEqual('', ui.ui_factory.stdin.readline())
2221
2356
        # stdout should be empty, stderr will contains the prompts
2222
2357
        self.assertEqual('', stdout.getvalue())
2223
2358
 
2224