← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_revision.py

  • Committer: Patch Queue Manager
  • Date: 2011-09-22 14:12:18 UTC
  • mfrom: (6155.3.1 jam)
  • Revision ID: pqm@pqm.ubuntu.com-20110922141218-86s4uu6nqvourw4f
(jameinel) Cleanup comments bzrlib/smart/__init__.py (John A Meinel)

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_revision.py
1
 
# (C) 2005 Canonical Ltd
 
1
# Copyright (C) 2005-2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
 
 
17
 
 
18
 
import os
 
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
16
 
 
17
 
19
18
import warnings
20
19
 
21
 
from bzrlib.branch import Branch
22
 
from bzrlib.errors import NoSuchRevision
23
 
from bzrlib.graph import Graph
24
 
from bzrlib.revision import (find_present_ancestors, combined_graph,
25
 
                             common_ancestor,
26
 
                             is_ancestor, MultipleRevisionSources,
27
 
                             NULL_REVISION)
28
 
from bzrlib.tests import TestCaseWithTransport
29
 
from bzrlib.trace import mutter
30
 
from bzrlib.workingtree import WorkingTree
 
20
from bzrlib import (
 
21
    bugtracker,
 
22
    revision,
 
23
    )
 
24
from bzrlib.errors import (
 
25
    InvalidBugStatus,
 
26
    InvalidLineInBugsProperty,
 
27
    )
 
28
from bzrlib.revision import NULL_REVISION
 
29
from bzrlib.tests import TestCase, TestCaseWithTransport
 
30
from bzrlib.tests.matchers import MatchesAncestry
31
31
 
32
32
# We're allowed to test deprecated interfaces
33
33
warnings.filterwarnings('ignore',
36
36
        r'bzrlib\.tests\.test_revision')
37
37
 
38
38
# XXX: Make this a method of a merge base case
39
 
def make_branches(self):
 
39
def make_branches(self, format=None):
40
40
    """Create two branches
41
41
 
42
42
    branch 1 has 6 commits, branch 2 has 3 commits
44
44
 
45
45
    the object graph is
46
46
    B:     A:
47
 
    a..0   a..0 
 
47
    a..0   a..0
48
48
    a..1   a..1
49
49
    a..2   a..2
50
50
    b..3   a..3 merges b..4
55
55
    so A is missing b6 at the start
56
56
    and B is missing a3, a4, a5
57
57
    """
58
 
    tree1 = self.make_branch_and_tree("branch1")
 
58
    tree1 = self.make_branch_and_tree("branch1", format=format)
59
59
    br1 = tree1.branch
60
 
    
 
60
 
61
61
    tree1.commit("Commit one", rev_id="a@u-0-0")
62
62
    tree1.commit("Commit two", rev_id="a@u-0-1")
63
63
    tree1.commit("Commit three", rev_id="a@u-0-2")
64
64
 
65
 
    tree2 = tree1.bzrdir.clone("branch2").open_workingtree()
 
65
    tree2 = tree1.bzrdir.sprout("branch2").open_workingtree()
66
66
    br2 = tree2.branch
67
67
    tree2.commit("Commit four", rev_id="b@u-0-3")
68
68
    tree2.commit("Commit five", rev_id="b@u-0-4")
69
69
    revisions_2 = br2.revision_history()
70
 
    
71
 
    br1.fetch(br2)
72
 
    tree1.add_pending_merge(revisions_2[4])
73
 
    self.assertEquals(revisions_2[4], 'b@u-0-4')
 
70
    self.assertEquals(revisions_2[-1], 'b@u-0-4')
 
71
 
 
72
    tree1.merge_from_branch(br2)
74
73
    tree1.commit("Commit six", rev_id="a@u-0-3")
75
74
    tree1.commit("Commit seven", rev_id="a@u-0-4")
76
75
    tree2.commit("Commit eight", rev_id="b@u-0-5")
77
 
    
78
 
    br1.fetch(br2)
79
 
    tree1.add_pending_merge(br2.revision_history()[5])
 
76
    self.assertEquals(br2.revision_history()[-1], 'b@u-0-5')
 
77
 
 
78
    tree1.merge_from_branch(br2)
80
79
    tree1.commit("Commit nine", rev_id="a@u-0-5")
81
 
    # DO NOT FETCH HERE - we WANT a GHOST.
82
 
    # br2.fetch(br1)
83
 
    tree2.add_pending_merge(br1.revision_history()[4])
 
80
    # DO NOT MERGE HERE - we WANT a GHOST.
 
81
    tree2.add_parent_tree_id(br1.revision_history()[4])
84
82
    tree2.commit("Commit ten - ghost merge", rev_id="b@u-0-6")
85
 
    
 
83
 
86
84
    return br1, br2
87
85
 
88
86
 
106
104
             ('a@u-0-5', ['a@u-0-0', 'a@u-0-1', 'a@u-0-2', 'a@u-0-3', 'a@u-0-4',
107
105
                          'b@u-0-3', 'b@u-0-4',
108
106
                          'b@u-0-5', 'a@u-0-5']),
109
 
             ('b@u-0-6', ['a@u-0-0', 'a@u-0-1', 'a@u-0-2',
 
107
             ('b@u-0-6', ['a@u-0-0', 'a@u-0-1', 'a@u-0-2', 'a@u-0-4',
110
108
                          'b@u-0-3', 'b@u-0-4',
111
109
                          'b@u-0-5', 'b@u-0-6']),
112
110
             ]
118
116
                    continue
119
117
                if rev_id in br2_only and not branch is br2:
120
118
                    continue
121
 
                mutter('ancestry of {%s}: %r',
122
 
                       rev_id, branch.repository.get_ancestry(rev_id))
123
 
                result = sorted(branch.repository.get_ancestry(rev_id))
124
 
                self.assertEquals(result, [None] + sorted(anc))
125
 
    
126
 
    
127
 
    def test_is_ancestor(self):
128
 
        """Test checking whether a revision is an ancestor of another revision"""
129
 
        br1, br2 = make_branches(self)
130
 
        revisions = br1.revision_history()
131
 
        revisions_2 = br2.revision_history()
132
 
        sources = br1
133
 
 
134
 
        self.assert_(is_ancestor(revisions[0], revisions[0], br1))
135
 
        self.assert_(is_ancestor(revisions[1], revisions[0], sources))
136
 
        self.assert_(not is_ancestor(revisions[0], revisions[1], sources))
137
 
        self.assert_(is_ancestor(revisions_2[3], revisions[0], sources))
138
 
        # disabled mbp 20050914, doesn't seem to happen anymore
139
 
        ## self.assertRaises(NoSuchRevision, is_ancestor, revisions_2[3],
140
 
        ##                  revisions[0], br1)        
141
 
        self.assert_(is_ancestor(revisions[3], revisions_2[4], sources))
142
 
        self.assert_(is_ancestor(revisions[3], revisions_2[4], br1))
143
 
        self.assert_(is_ancestor(revisions[3], revisions_2[3], sources))
144
 
        ## self.assert_(not is_ancestor(revisions[3], revisions_2[3], br1))
 
119
                self.assertThat(anc,
 
120
                    MatchesAncestry(branch.repository, rev_id))
145
121
 
146
122
 
147
123
class TestIntermediateRevisions(TestCaseWithTransport):
155
131
        wt2.commit("Commit twelve", rev_id="b@u-0-8")
156
132
        wt2.commit("Commit thirtteen", rev_id="b@u-0-9")
157
133
 
158
 
        self.br1.fetch(self.br2)
159
 
        wt1.add_pending_merge(self.br2.revision_history()[6])
 
134
        wt1.merge_from_branch(self.br2)
160
135
        wt1.commit("Commit fourtten", rev_id="a@u-0-6")
161
136
 
162
 
        self.br2.fetch(self.br1)
163
 
        wt2.add_pending_merge(self.br1.revision_history()[6])
 
137
        wt2.merge_from_branch(self.br1)
164
138
        wt2.commit("Commit fifteen", rev_id="b@u-0-10")
165
139
 
166
 
        from bzrlib.revision import MultipleRevisionSources
167
 
        self.sources = MultipleRevisionSources(self.br1.repository,
168
 
                                               self.br2.repository)
169
 
 
170
 
 
171
140
 
172
141
class MockRevisionSource(object):
173
142
    """A RevisionSource that takes a pregenerated graph.
187
156
class TestCommonAncestor(TestCaseWithTransport):
188
157
    """Test checking whether a revision is an ancestor of another revision"""
189
158
 
190
 
    def test_common_ancestor(self):
191
 
        """Pick a reasonable merge base"""
192
 
        br1, br2 = make_branches(self)
193
 
        revisions = br1.revision_history()
194
 
        revisions_2 = br2.revision_history()
195
 
        sources = MultipleRevisionSources(br1.repository, br2.repository)
196
 
        expected_ancestors_list = {revisions[3]:(0, 0), 
197
 
                                   revisions[2]:(1, 1),
198
 
                                   revisions_2[4]:(2, 1), 
199
 
                                   revisions[1]:(3, 2),
200
 
                                   revisions_2[3]:(4, 2),
201
 
                                   revisions[0]:(5, 3) }
202
 
        ancestors_list = find_present_ancestors(revisions[3], sources)
203
 
        self.assertEquals(len(expected_ancestors_list), len(ancestors_list))
204
 
        for key, value in expected_ancestors_list.iteritems():
205
 
            self.assertEqual(ancestors_list[key], value, 
206
 
                              "key %r, %r != %r" % (key, ancestors_list[key],
207
 
                                                    value))
208
 
        self.assertEqual(common_ancestor(revisions[0], revisions[0], sources),
209
 
                          revisions[0])
210
 
        self.assertEqual(common_ancestor(revisions[1], revisions[2], sources),
211
 
                          revisions[1])
212
 
        self.assertEqual(common_ancestor(revisions[1], revisions[1], sources),
213
 
                          revisions[1])
214
 
        self.assertEqual(common_ancestor(revisions[2], revisions_2[4], sources),
215
 
                          revisions[2])
216
 
        self.assertEqual(common_ancestor(revisions[3], revisions_2[4], sources),
217
 
                          revisions_2[4])
218
 
        self.assertEqual(common_ancestor(revisions[4], revisions_2[5], sources),
219
 
                          revisions_2[4])
220
 
        self.assertTrue(common_ancestor(revisions[5], revisions_2[6], sources) in
221
 
                        (revisions[4], revisions_2[5]))
222
 
        self.assertTrue(common_ancestor(revisions_2[6], revisions[5], sources),
223
 
                        (revisions[4], revisions_2[5]))
224
 
        self.assertEqual(None, common_ancestor(None, revisions[5], sources))
225
 
        self.assertEqual(NULL_REVISION,
226
 
            common_ancestor(NULL_REVISION, NULL_REVISION, sources))
227
 
        self.assertEqual(NULL_REVISION,
228
 
            common_ancestor(revisions[0], NULL_REVISION, sources))
229
 
        self.assertEqual(NULL_REVISION,
230
 
            common_ancestor(NULL_REVISION, revisions[0], sources))
231
 
 
232
 
    def test_combined(self):
233
 
        """combined_graph
234
 
        Ensure it's not order-sensitive
235
 
        """
236
 
        br1, br2 = make_branches(self)
237
 
        source = MultipleRevisionSources(br1.repository, br2.repository)
238
 
        combined_1 = combined_graph(br1.last_revision(), 
239
 
                                    br2.last_revision(), source)
240
 
        combined_2 = combined_graph(br2.last_revision(),
241
 
                                    br1.last_revision(), source)
242
 
        self.assertEquals(combined_1[1], combined_2[1])
243
 
        self.assertEquals(combined_1[2], combined_2[2])
244
 
        self.assertEquals(combined_1[3], combined_2[3])
245
 
        self.assertEquals(combined_1, combined_2)
246
 
 
247
159
    def test_get_history(self):
248
160
        # TODO: test ghosts on the left hand branch's impact
249
161
        # TODO: test ghosts on all parents, we should get some
263
175
        history = rev.get_history(tree.branch.repository)
264
176
        self.assertEqual([None, '1', '2' ,'3'], history)
265
177
 
266
 
    def test_common_ancestor_rootless_graph(self):
267
 
        # common_ancestor on a graph with no reachable roots - only
268
 
        # ghosts - should still return a useful value.
269
 
        graph = Graph()
270
 
        # add a ghost node which would be a root if it wasn't a ghost.
271
 
        graph.add_ghost('a_ghost')
272
 
        # add a normal commit on top of that
273
 
        graph.add_node('rev1', ['a_ghost'])
274
 
        # add a left-branch revision
275
 
        graph.add_node('left', ['rev1'])
276
 
        # add a right-branch revision
277
 
        graph.add_node('right', ['rev1'])
278
 
        source = MockRevisionSource(graph)
279
 
        self.assertEqual('rev1', common_ancestor('left', 'right', source))
280
 
 
281
 
 
282
 
class TestMultipleRevisionSources(TestCaseWithTransport):
283
 
    """Tests for the MultipleRevisionSources adapter."""
284
 
 
285
 
    def test_get_revision_graph_merges_ghosts(self):
286
 
        # when we ask for the revision graph for B, which
287
 
        # is in repo 1 with a ghost of A, and which is not
288
 
        # in repo 2, which has A, the revision_graph()
289
 
        # should return A and B both.
290
 
        tree_1 = self.make_branch_and_tree('1')
291
 
        tree_1.add_pending_merge('A')
292
 
        tree_1.commit('foo', rev_id='B', allow_pointless=True)
293
 
        tree_2 = self.make_branch_and_tree('2')
294
 
        tree_2.commit('bar', rev_id='A', allow_pointless=True)
295
 
        source = MultipleRevisionSources(tree_1.branch.repository,
296
 
                                         tree_2.branch.repository)
297
 
        self.assertEqual({'B':['A'],
298
 
                          'A':[]},
299
 
                         source.get_revision_graph('B'))
300
 
 
301
 
class TestRevisionAttributes(TestCaseWithTransport):
302
 
    """Test that revision attributes are correct."""
303
 
 
304
 
    def test_revision_accessors(self):
305
 
        """Make sure the values that come out of a revision are the same as the ones that go in.
306
 
        """
307
 
        tree1 = self.make_branch_and_tree("br1")
308
 
 
309
 
        # create a revision
310
 
        tree1.commit(message="quux", allow_pointless=True, committer="jaq")
311
 
        assert len(tree1.branch.revision_history()) > 0
312
 
        rev_a = tree1.branch.repository.get_revision(tree1.branch.last_revision())
313
 
 
314
 
        tree2 = self.make_branch_and_tree("br2")
315
 
        tree2.commit(message=rev_a.message,
316
 
                     timestamp=rev_a.timestamp,
317
 
                     timezone=rev_a.timezone,
318
 
                     committer=rev_a.committer,
319
 
                     rev_id=rev_a.revision_id,
320
 
                     allow_pointless=True, # there's nothing in this commit
321
 
                     strict=True,
322
 
                     verbose=True)
323
 
        rev_b = tree2.branch.repository.get_revision(tree2.branch.last_revision())
324
 
        
325
 
        self.assertEqual(rev_a.message, rev_b.message)
326
 
        self.assertEqual(rev_a.timestamp, rev_b.timestamp)
327
 
        self.assertEqual(rev_a.timezone, rev_b.timezone)
328
 
        self.assertEqual(rev_a.committer, rev_b.committer)
329
 
        self.assertEqual(rev_a.revision_id, rev_b.revision_id)
 
178
 
 
179
class TestReservedId(TestCase):
 
180
 
 
181
    def test_is_reserved_id(self):
 
182
        self.assertEqual(True, revision.is_reserved_id(NULL_REVISION))
 
183
        self.assertEqual(True, revision.is_reserved_id(
 
184
            revision.CURRENT_REVISION))
 
185
        self.assertEqual(True, revision.is_reserved_id('arch:'))
 
186
        self.assertEqual(False, revision.is_reserved_id('null'))
 
187
        self.assertEqual(False, revision.is_reserved_id(
 
188
            'arch:a@example.com/c--b--v--r'))
 
189
        self.assertEqual(False, revision.is_reserved_id(None))
 
190
 
 
191
 
 
192
class TestRevisionMethods(TestCase):
 
193
 
 
194
    def test_get_summary(self):
 
195
        r = revision.Revision('1')
 
196
        r.message = 'a'
 
197
        self.assertEqual('a', r.get_summary())
 
198
        r.message = 'a\nb'
 
199
        self.assertEqual('a', r.get_summary())
 
200
        r.message = '\na\nb'
 
201
        self.assertEqual('a', r.get_summary())
 
202
        r.message = None
 
203
        self.assertEqual('', r.get_summary())
 
204
 
 
205
    def test_get_apparent_authors(self):
 
206
        r = revision.Revision('1')
 
207
        r.committer = 'A'
 
208
        self.assertEqual(['A'], r.get_apparent_authors())
 
209
        r.properties['author'] = 'B'
 
210
        self.assertEqual(['B'], r.get_apparent_authors())
 
211
        r.properties['authors'] = 'C\nD'
 
212
        self.assertEqual(['C', 'D'], r.get_apparent_authors())
 
213
 
 
214
    def test_get_apparent_authors_no_committer(self):
 
215
        r = revision.Revision('1')
 
216
        self.assertEqual([], r.get_apparent_authors())
 
217
 
 
218
 
 
219
class TestRevisionBugs(TestCase):
 
220
    """Tests for getting the bugs that a revision is linked to."""
 
221
 
 
222
    def test_no_bugs(self):
 
223
        r = revision.Revision('1')
 
224
        self.assertEqual([], list(r.iter_bugs()))
 
225
 
 
226
    def test_some_bugs(self):
 
227
        r = revision.Revision(
 
228
            '1', properties={
 
229
                'bugs': bugtracker.encode_fixes_bug_urls(
 
230
                    ['http://example.com/bugs/1',
 
231
                     'http://launchpad.net/bugs/1234'])})
 
232
        self.assertEqual(
 
233
            [('http://example.com/bugs/1', bugtracker.FIXED),
 
234
             ('http://launchpad.net/bugs/1234', bugtracker.FIXED)],
 
235
            list(r.iter_bugs()))
 
236
 
 
237
    def test_no_status(self):
 
238
        r = revision.Revision(
 
239
            '1', properties={'bugs': 'http://example.com/bugs/1'})
 
240
        self.assertRaises(InvalidLineInBugsProperty, list, r.iter_bugs())
 
241
 
 
242
    def test_too_much_information(self):
 
243
        r = revision.Revision(
 
244
            '1', properties={'bugs': 'http://example.com/bugs/1 fixed bar'})
 
245
        self.assertRaises(InvalidLineInBugsProperty, list, r.iter_bugs())
 
246
 
 
247
    def test_invalid_status(self):
 
248
        r = revision.Revision(
 
249
            '1', properties={'bugs': 'http://example.com/bugs/1 faxed'})
 
250
        self.assertRaises(InvalidBugStatus, list, r.iter_bugs())