~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_lockdir.py

  • Committer: Vincent Ladeuil
  • Date: 2011-08-12 09:49:24 UTC
  • mfrom: (6015.9.10 2.4)
  • mto: This revision was merged to the branch mainline in revision 6066.
  • Revision ID: v.ladeuil+lp@free.fr-20110812094924-knc5s0g7vs31a2f1
Merge 2.4 into trunk

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006, 2007 Canonical Ltd
 
1
# Copyright (C) 2006-2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
17
"""Tests for LockDir"""
18
18
 
19
 
from cStringIO import StringIO
20
19
import os
21
 
from threading import Thread, Lock
 
20
import sys
22
21
import time
23
22
 
24
23
import bzrlib
25
24
from bzrlib import (
26
25
    config,
27
26
    errors,
 
27
    lock,
 
28
    lockdir,
28
29
    osutils,
29
30
    tests,
30
31
    transport,
33
34
    LockBreakMismatch,
34
35
    LockBroken,
35
36
    LockContention,
36
 
    LockError,
37
37
    LockFailed,
38
38
    LockNotHeld,
39
39
    )
40
 
from bzrlib.lockdir import LockDir
41
 
from bzrlib.tests import TestCaseWithTransport
 
40
from bzrlib.lockdir import (
 
41
    LockDir,
 
42
    LockHeldInfo,
 
43
    )
 
44
from bzrlib.tests import (
 
45
    features,
 
46
    TestCase,
 
47
    TestCaseWithTransport,
 
48
    )
42
49
from bzrlib.trace import note
43
50
 
44
 
# These tests sometimes use threads to test the behaviour of lock files with
45
 
# concurrent actors.  This is not a typical (or necessarily supported) use;
46
 
# they're really meant for guarding between processes.
47
 
 
48
51
# These tests are run on the default transport provided by the test framework
49
52
# (typically a local disk transport).  That can be changed by the --transport
50
53
# option to bzr selftest.  The required properties of the transport
51
54
# implementation are tested separately.  (The main requirement is just that
52
55
# they don't allow overwriting nonempty directories.)
53
56
 
 
57
 
54
58
class TestLockDir(TestCaseWithTransport):
55
59
    """Test LockDir operations"""
56
60
 
125
129
        lf1.attempt_lock()
126
130
        lf2 = LockDir(t, 'test_lock')
127
131
        try:
128
 
            # locking is between LockDir instances; aliases within 
 
132
            # locking is between LockDir instances; aliases within
129
133
            # a single process are not detected
130
134
            lf2.attempt_lock()
131
135
            self.fail('Failed to detect lock collision')
141
145
        lf1 = LockDir(t, 'test_lock')
142
146
        lf1.create()
143
147
        lf1.attempt_lock()
 
148
        self.addCleanup(lf1.unlock)
144
149
        # lock is held, should get some info on it
145
150
        info1 = lf1.peek()
146
 
        self.assertEqual(set(info1.keys()),
147
 
                         set(['user', 'nonce', 'hostname', 'pid', 'start_time']))
 
151
        self.assertEqual(set(info1.info_dict.keys()),
 
152
            set(['user', 'nonce', 'hostname', 'pid', 'start_time']))
148
153
        # should get the same info if we look at it through a different
149
154
        # instance
150
155
        info2 = LockDir(t, 'test_lock').peek()
160
165
        lf2 = LockDir(self.get_readonly_transport(), 'test_lock')
161
166
        self.assertEqual(lf2.peek(), None)
162
167
        lf1.attempt_lock()
 
168
        self.addCleanup(lf1.unlock)
163
169
        info2 = lf2.peek()
164
170
        self.assertTrue(info2)
165
 
        self.assertEqual(info2['nonce'], lf1.nonce)
 
171
        self.assertEqual(info2.get('nonce'), lf1.nonce)
166
172
 
167
173
    def test_30_lock_wait_fail(self):
168
174
        """Wait on a lock, then fail
169
 
        
 
175
 
170
176
        We ask to wait up to 400ms; this should fail within at most one
171
177
        second.  (Longer times are more realistic but we don't want the test
172
178
        suite to take too long, and this should do for now.)
184
190
            after = time.time()
185
191
            # it should only take about 0.4 seconds, but we allow more time in
186
192
            # case the machine is heavily loaded
187
 
            self.assertTrue(after - before <= 8.0, 
188
 
                    "took %f seconds to detect lock contention" % (after - before))
 
193
            self.assertTrue(after - before <= 8.0,
 
194
                "took %f seconds to detect lock contention" % (after - before))
189
195
        finally:
190
196
            lf1.unlock()
191
 
        lock_base = lf2.transport.abspath(lf2.path)
192
197
        self.assertEqual(1, len(self._logged_reports))
193
 
        lock_url = lf2.transport.abspath(lf2.path)
194
 
        self.assertEqual('%s %s\n'
195
 
                         '%s\n%s\n'
196
 
                         'Will continue to try until %s, unless '
197
 
                         'you press Ctrl-C\n'
198
 
                         'If you\'re sure that it\'s not being '
199
 
                         'modified, use bzr break-lock %s',
200
 
                         self._logged_reports[0][0])
201
 
        args = self._logged_reports[0][1]
202
 
        self.assertEqual('Unable to obtain', args[0])
203
 
        self.assertEqual('lock %s' % (lock_base,), args[1])
204
 
        self.assertStartsWith(args[2], 'held by ')
205
 
        self.assertStartsWith(args[3], 'locked ')
206
 
        self.assertEndsWith(args[3], ' ago')
207
 
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
 
198
        self.assertContainsRe(self._logged_reports[0][0],
 
199
            r'Unable to obtain lock .* held by jrandom@example\.com on .*'
 
200
            r' \(process #\d+\), acquired .* ago\.\n'
 
201
            r'Will continue to try until \d{2}:\d{2}:\d{2}, unless '
 
202
            r'you press Ctrl-C.\n'
 
203
            r'See "bzr help break-lock" for more.')
208
204
 
209
205
    def test_31_lock_wait_easy(self):
210
206
        """Succeed when waiting on a lock with no contention.
222
218
            lf1.unlock()
223
219
        self.assertEqual([], self._logged_reports)
224
220
 
225
 
    def test_32_lock_wait_succeed(self):
226
 
        """Succeed when trying to acquire a lock that gets released
227
 
 
228
 
        One thread holds on a lock and then releases it; another 
229
 
        tries to lock it.
230
 
        """
231
 
        # This test sometimes fails like this:
232
 
        # Traceback (most recent call last):
233
 
 
234
 
        #   File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/
235
 
        # test_lockdir.py", line 247, in test_32_lock_wait_succeed
236
 
        #     self.assertEqual(1, len(self._logged_reports))
237
 
        # AssertionError: not equal:
238
 
        # a = 1
239
 
        # b = 0
240
 
        raise tests.TestSkipped("Test fails intermittently")
241
 
        t = self.get_transport()
242
 
        lf1 = LockDir(t, 'test_lock')
243
 
        lf1.create()
244
 
        lf1.attempt_lock()
245
 
 
246
 
        def wait_and_unlock():
247
 
            time.sleep(0.1)
248
 
            lf1.unlock()
249
 
        unlocker = Thread(target=wait_and_unlock)
250
 
        unlocker.start()
251
 
        try:
252
 
            lf2 = LockDir(t, 'test_lock')
253
 
            self.setup_log_reporter(lf2)
254
 
            before = time.time()
255
 
            # wait and then lock
256
 
            lf2.wait_lock(timeout=0.4, poll=0.1)
257
 
            after = time.time()
258
 
            self.assertTrue(after - before <= 1.0)
259
 
        finally:
260
 
            unlocker.join()
261
 
 
262
 
        # There should be only 1 report, even though it should have to
263
 
        # wait for a while
264
 
        lock_base = lf2.transport.abspath(lf2.path)
265
 
        self.assertEqual(1, len(self._logged_reports))
266
 
        self.assertEqual('%s %s\n'
267
 
                         '%s\n%s\n'
268
 
                         'Will continue to try until %s\n',
269
 
                         self._logged_reports[0][0])
270
 
        args = self._logged_reports[0][1]
271
 
        self.assertEqual('Unable to obtain', args[0])
272
 
        self.assertEqual('lock %s' % (lock_base,), args[1])
273
 
        self.assertStartsWith(args[2], 'held by ')
274
 
        self.assertStartsWith(args[3], 'locked ')
275
 
        self.assertEndsWith(args[3], ' ago')
276
 
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
277
 
 
278
 
    def test_34_lock_write_waits(self):
279
 
        """LockDir.lock_write() will wait for the lock.""" 
280
 
        # the test suite sets the default to 0 to make deadlocks fail fast.
281
 
        # change it for this test, as we want to try a manual deadlock.
282
 
        raise tests.TestSkipped('Timing-sensitive test')
283
 
        bzrlib.lockdir._DEFAULT_TIMEOUT_SECONDS = 300
284
 
        t = self.get_transport()
285
 
        lf1 = LockDir(t, 'test_lock')
286
 
        lf1.create()
287
 
        lf1.attempt_lock()
288
 
 
289
 
        def wait_and_unlock():
290
 
            time.sleep(0.1)
291
 
            lf1.unlock()
292
 
        unlocker = Thread(target=wait_and_unlock)
293
 
        unlocker.start()
294
 
        try:
295
 
            lf2 = LockDir(t, 'test_lock')
296
 
            self.setup_log_reporter(lf2)
297
 
            before = time.time()
298
 
            # wait and then lock
299
 
            lf2.lock_write()
300
 
            after = time.time()
301
 
        finally:
302
 
            unlocker.join()
303
 
 
304
 
        # There should be only 1 report, even though it should have to
305
 
        # wait for a while
306
 
        lock_base = lf2.transport.abspath(lf2.path)
307
 
        self.assertEqual(1, len(self._logged_reports))
308
 
        self.assertEqual('%s %s\n'
309
 
                         '%s\n%s\n'
310
 
                         'Will continue to try until %s\n',
311
 
                         self._logged_reports[0][0])
312
 
        args = self._logged_reports[0][1]
313
 
        self.assertEqual('Unable to obtain', args[0])
314
 
        self.assertEqual('lock %s' % (lock_base,), args[1])
315
 
        self.assertStartsWith(args[2], 'held by ')
316
 
        self.assertStartsWith(args[3], 'locked ')
317
 
        self.assertEndsWith(args[3], ' ago')
318
 
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
319
 
 
320
 
    def test_35_wait_lock_changing(self):
321
 
        """LockDir.wait_lock() will report if the lock changes underneath.
322
 
        
323
 
        This is the stages we want to happen:
324
 
 
325
 
        0) Synchronization locks are created and locked.
326
 
        1) Lock1 obtains the lockdir, and releases the 'check' lock.
327
 
        2) Lock2 grabs the 'check' lock, and checks the lockdir.
328
 
           It sees the lockdir is already acquired, reports the fact, 
329
 
           and unsets the 'checked' lock.
330
 
        3) Thread1 blocks on acquiring the 'checked' lock, and then tells
331
 
           Lock1 to release and acquire the lockdir. This resets the 'check'
332
 
           lock.
333
 
        4) Lock2 acquires the 'check' lock, and checks again. It notices
334
 
           that the holder of the lock has changed, and so reports a new 
335
 
           lock holder.
336
 
        5) Thread1 blocks on the 'checked' lock, this time, it completely
337
 
           unlocks the lockdir, allowing Lock2 to acquire the lock.
338
 
        """
339
 
 
340
 
        raise tests.KnownFailure(
341
 
            "timing dependency in lock tests (#213182)")
342
 
 
343
 
        wait_to_check_lock = Lock()
344
 
        wait_until_checked_lock = Lock()
345
 
 
346
 
        wait_to_check_lock.acquire()
347
 
        wait_until_checked_lock.acquire()
348
 
        note('locked check and checked locks')
349
 
 
350
 
        class LockDir1(LockDir):
351
 
            """Use the synchronization points for the first lock."""
352
 
 
353
 
            def attempt_lock(self):
354
 
                # Once we have acquired the lock, it is okay for
355
 
                # the other lock to check it
356
 
                try:
357
 
                    return super(LockDir1, self).attempt_lock()
358
 
                finally:
359
 
                    note('lock1: releasing check lock')
360
 
                    wait_to_check_lock.release()
361
 
 
362
 
        class LockDir2(LockDir):
363
 
            """Use the synchronization points for the second lock."""
364
 
 
365
 
            def attempt_lock(self):
366
 
                note('lock2: waiting for check lock')
367
 
                wait_to_check_lock.acquire()
368
 
                note('lock2: acquired check lock')
369
 
                try:
370
 
                    return super(LockDir2, self).attempt_lock()
371
 
                finally:
372
 
                    note('lock2: releasing checked lock')
373
 
                    wait_until_checked_lock.release()
374
 
 
375
 
        t = self.get_transport()
376
 
        lf1 = LockDir1(t, 'test_lock')
377
 
        lf1.create()
378
 
 
379
 
        lf2 = LockDir2(t, 'test_lock')
380
 
        self.setup_log_reporter(lf2)
381
 
 
382
 
        def wait_and_switch():
383
 
            lf1.attempt_lock()
384
 
            # Block until lock2 has had a chance to check
385
 
            note('lock1: waiting 1 for checked lock')
386
 
            wait_until_checked_lock.acquire()
387
 
            note('lock1: acquired for checked lock')
388
 
            note('lock1: released lockdir')
389
 
            lf1.unlock()
390
 
            note('lock1: acquiring lockdir')
391
 
            # Create a new nonce, so the lock looks different.
392
 
            lf1.nonce = osutils.rand_chars(20)
393
 
            lf1.lock_write()
394
 
            note('lock1: acquired lockdir')
395
 
 
396
 
            # Block until lock2 has peeked again
397
 
            note('lock1: waiting 2 for checked lock')
398
 
            wait_until_checked_lock.acquire()
399
 
            note('lock1: acquired for checked lock')
400
 
            # Now unlock, and let lock 2 grab the lock
401
 
            lf1.unlock()
402
 
            wait_to_check_lock.release()
403
 
 
404
 
        unlocker = Thread(target=wait_and_switch)
405
 
        unlocker.start()
406
 
        try:
407
 
            # Wait and play against the other thread
408
 
            lf2.wait_lock(timeout=20.0, poll=0.01)
409
 
        finally:
410
 
            unlocker.join()
411
 
        lf2.unlock()
412
 
 
413
 
        # There should be 2 reports, because the lock changed
414
 
        lock_base = lf2.transport.abspath(lf2.path)
415
 
        self.assertEqual(2, len(self._logged_reports))
416
 
        lock_url = lf2.transport.abspath(lf2.path)
417
 
        self.assertEqual('%s %s\n'
418
 
                         '%s\n%s\n'
419
 
                         'Will continue to try until %s, unless '
420
 
                         'you press Ctrl-C\n'
421
 
                         'If you\'re sure that it\'s not being '
422
 
                         'modified, use bzr break-lock %s',
423
 
                         self._logged_reports[0][0])
424
 
        args = self._logged_reports[0][1]
425
 
        self.assertEqual('Unable to obtain', args[0])
426
 
        self.assertEqual('lock %s' % (lock_base,), args[1])
427
 
        self.assertStartsWith(args[2], 'held by ')
428
 
        self.assertStartsWith(args[3], 'locked ')
429
 
        self.assertEndsWith(args[3], ' ago')
430
 
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
431
 
 
432
 
        self.assertEqual('%s %s\n'
433
 
                         '%s\n%s\n'
434
 
                         'Will continue to try until %s, unless '
435
 
                         'you press Ctrl-C\n'
436
 
                         'If you\'re sure that it\'s not being '
437
 
                         'modified, use bzr break-lock %s',
438
 
                         self._logged_reports[1][0])
439
 
        args = self._logged_reports[1][1]
440
 
        self.assertEqual('Lock owner changed for', args[0])
441
 
        self.assertEqual('lock %s' % (lock_base,), args[1])
442
 
        self.assertStartsWith(args[2], 'held by ')
443
 
        self.assertStartsWith(args[3], 'locked ')
444
 
        self.assertEndsWith(args[3], ' ago')
445
 
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
446
 
 
447
221
    def test_40_confirm_easy(self):
448
222
        """Confirm a lock that's already held"""
449
223
        t = self.get_transport()
450
224
        lf1 = LockDir(t, 'test_lock')
451
225
        lf1.create()
452
226
        lf1.attempt_lock()
 
227
        self.addCleanup(lf1.unlock)
453
228
        lf1.confirm()
454
229
 
455
230
    def test_41_confirm_not_held(self):
467
242
        lf1.attempt_lock()
468
243
        t.move('test_lock', 'lock_gone_now')
469
244
        self.assertRaises(LockBroken, lf1.confirm)
 
245
        # Clean up
 
246
        t.move('lock_gone_now', 'test_lock')
 
247
        lf1.unlock()
470
248
 
471
249
    def test_43_break(self):
472
250
        """Break a lock whose caller has forgotten it"""
483
261
        lf2.force_break(holder_info)
484
262
        # now we should be able to take it
485
263
        lf2.attempt_lock()
 
264
        self.addCleanup(lf2.unlock)
486
265
        lf2.confirm()
487
266
 
488
267
    def test_44_break_already_released(self):
500
279
        lf2.force_break(holder_info)
501
280
        # now we should be able to take it
502
281
        lf2.attempt_lock()
 
282
        self.addCleanup(lf2.unlock)
503
283
        lf2.confirm()
504
284
 
505
285
    def test_45_break_mismatch(self):
531
311
        """Check the on-disk representation of LockDirs is as expected.
532
312
 
533
313
        There should always be a top-level directory named by the lock.
534
 
        When the lock is held, there should be a lockname/held directory 
 
314
        When the lock is held, there should be a lockname/held directory
535
315
        containing an info file.
536
316
        """
537
317
        t = self.get_transport()
552
332
        # do this without IO redirection to ensure it doesn't prompt.
553
333
        self.assertRaises(AssertionError, ld1.break_lock)
554
334
        orig_factory = bzrlib.ui.ui_factory
555
 
        # silent ui - no need for stdout
556
 
        bzrlib.ui.ui_factory = bzrlib.ui.SilentUIFactory()
557
 
        bzrlib.ui.ui_factory.stdin = StringIO("y\n")
 
335
        bzrlib.ui.ui_factory = bzrlib.ui.CannedInputUIFactory([True])
558
336
        try:
559
337
            ld2.break_lock()
560
338
            self.assertRaises(LockBroken, ld1.unlock)
561
339
        finally:
562
340
            bzrlib.ui.ui_factory = orig_factory
563
341
 
 
342
    def test_break_lock_corrupt_info(self):
 
343
        """break_lock works even if the info file is corrupt (and tells the UI
 
344
        that it is corrupt).
 
345
        """
 
346
        ld = self.get_lock()
 
347
        ld2 = self.get_lock()
 
348
        ld.create()
 
349
        ld.lock_write()
 
350
        ld.transport.put_bytes_non_atomic('test_lock/held/info', '\0')
 
351
 
 
352
        class LoggingUIFactory(bzrlib.ui.SilentUIFactory):
 
353
            def __init__(self):
 
354
                self.prompts = []
 
355
 
 
356
            def get_boolean(self, prompt):
 
357
                self.prompts.append(('boolean', prompt))
 
358
                return True
 
359
 
 
360
        ui = LoggingUIFactory()
 
361
        self.overrideAttr(bzrlib.ui, 'ui_factory', ui)
 
362
        ld2.break_lock()
 
363
        self.assertLength(1, ui.prompts)
 
364
        self.assertEqual('boolean', ui.prompts[0][0])
 
365
        self.assertStartsWith(ui.prompts[0][1], 'Break (corrupt LockDir')
 
366
        self.assertRaises(LockBroken, ld.unlock)
 
367
 
 
368
    def test_break_lock_missing_info(self):
 
369
        """break_lock works even if the info file is missing (and tells the UI
 
370
        that it is corrupt).
 
371
        """
 
372
        ld = self.get_lock()
 
373
        ld2 = self.get_lock()
 
374
        ld.create()
 
375
        ld.lock_write()
 
376
        ld.transport.delete('test_lock/held/info')
 
377
 
 
378
        class LoggingUIFactory(bzrlib.ui.SilentUIFactory):
 
379
            def __init__(self):
 
380
                self.prompts = []
 
381
 
 
382
            def get_boolean(self, prompt):
 
383
                self.prompts.append(('boolean', prompt))
 
384
                return True
 
385
 
 
386
        ui = LoggingUIFactory()
 
387
        orig_factory = bzrlib.ui.ui_factory
 
388
        bzrlib.ui.ui_factory = ui
 
389
        try:
 
390
            ld2.break_lock()
 
391
            self.assertRaises(LockBroken, ld.unlock)
 
392
            self.assertLength(0, ui.prompts)
 
393
        finally:
 
394
            bzrlib.ui.ui_factory = orig_factory
 
395
        # Suppress warnings due to ld not being unlocked
 
396
        # XXX: if lock_broken hook was invoked in this case, this hack would
 
397
        # not be necessary.  - Andrew Bennetts, 2010-09-06.
 
398
        del self._lock_actions[:]
 
399
 
564
400
    def test_create_missing_base_directory(self):
565
401
        """If LockDir.path doesn't exist, it can be created
566
402
 
572
408
        lf1 = LockDir(t, 'test_lock')
573
409
 
574
410
        lf1.create()
575
 
        self.failUnless(t.has('test_lock'))
 
411
        self.assertTrue(t.has('test_lock'))
576
412
 
577
413
        t.rmdir('test_lock')
578
 
        self.failIf(t.has('test_lock'))
 
414
        self.assertFalse(t.has('test_lock'))
579
415
 
580
416
        # This will create 'test_lock' if it needs to
581
417
        lf1.lock_write()
582
 
        self.failUnless(t.has('test_lock'))
583
 
        self.failUnless(t.has('test_lock/held/info'))
 
418
        self.assertTrue(t.has('test_lock'))
 
419
        self.assertTrue(t.has('test_lock/held/info'))
584
420
 
585
421
        lf1.unlock()
586
 
        self.failIf(t.has('test_lock/held/info'))
 
422
        self.assertFalse(t.has('test_lock/held/info'))
587
423
 
588
 
    def test__format_lock_info(self):
 
424
    def test_display_form(self):
589
425
        ld1 = self.get_lock()
590
426
        ld1.create()
591
427
        ld1.lock_write()
592
428
        try:
593
 
            info_list = ld1._format_lock_info(ld1.peek())
 
429
            info_list = ld1.peek().to_readable_dict()
594
430
        finally:
595
431
            ld1.unlock()
596
 
        self.assertEqual('lock %s' % (ld1.transport.abspath(ld1.path),),
597
 
                         info_list[0])
598
 
        self.assertContainsRe(info_list[1],
599
 
                              r'^held by .* on host .* \[process #\d*\]$')
600
 
        self.assertContainsRe(info_list[2], r'locked \d+ seconds? ago$')
 
432
        self.assertEqual(info_list['user'], u'jrandom@example.com')
 
433
        self.assertContainsRe(info_list['pid'], '^\d+$')
 
434
        self.assertContainsRe(info_list['time_ago'], r'^\d+ seconds? ago$')
601
435
 
602
436
    def test_lock_without_email(self):
603
437
        global_config = config.GlobalConfig()
609
443
        ld1.unlock()
610
444
 
611
445
    def test_lock_permission(self):
 
446
        self.requireFeature(features.not_running_as_root)
612
447
        if not osutils.supports_posix_readonly():
613
448
            raise tests.TestSkipped('Cannot induce a permission failure')
614
449
        ld1 = self.get_lock()
620
455
    def test_lock_by_token(self):
621
456
        ld1 = self.get_lock()
622
457
        token = ld1.lock_write()
 
458
        self.addCleanup(ld1.unlock)
623
459
        self.assertNotEqual(None, token)
624
460
        ld2 = self.get_lock()
625
461
        t2 = ld2.lock_write(token)
 
462
        self.addCleanup(ld2.unlock)
626
463
        self.assertEqual(token, t2)
627
464
 
628
465
    def test_lock_with_buggy_rename(self):
648
485
        # should be nothing before we start
649
486
        ld1.create()
650
487
        t = self.get_transport().clone('test_lock')
 
488
 
651
489
        def check_dir(a):
652
490
            self.assertEquals(a, t.list_dir('.'))
 
491
 
653
492
        check_dir([])
654
493
        # when held, that's all we see
655
494
        ld1.attempt_lock()
 
495
        self.addCleanup(ld1.unlock)
656
496
        check_dir(['held'])
657
497
        # second guy should fail
658
498
        self.assertRaises(errors.LockContention, ld2.attempt_lock)
659
499
        # no kibble
660
500
        check_dir(['held'])
 
501
 
 
502
    def test_no_lockdir_info(self):
 
503
        """We can cope with empty info files."""
 
504
        # This seems like a fairly common failure case - see
 
505
        # <https://bugs.launchpad.net/bzr/+bug/185103> and all its dupes.
 
506
        # Processes are often interrupted after opening the file
 
507
        # before the actual contents are committed.
 
508
        t = self.get_transport()
 
509
        t.mkdir('test_lock')
 
510
        t.mkdir('test_lock/held')
 
511
        t.put_bytes('test_lock/held/info', '')
 
512
        lf = LockDir(t, 'test_lock')
 
513
        info = lf.peek()
 
514
        formatted_info = info.to_readable_dict()
 
515
        self.assertEquals(
 
516
            dict(user='<unknown>', hostname='<unknown>', pid='<unknown>',
 
517
                time_ago='(unknown)'),
 
518
            formatted_info)
 
519
 
 
520
    def test_corrupt_lockdir_info(self):
 
521
        """We can cope with corrupt (and thus unparseable) info files."""
 
522
        # This seems like a fairly common failure case too - see
 
523
        # <https://bugs.launchpad.net/bzr/+bug/619872> for instance.
 
524
        # In particular some systems tend to fill recently created files with
 
525
        # nul bytes after recovering from a system crash.
 
526
        t = self.get_transport()
 
527
        t.mkdir('test_lock')
 
528
        t.mkdir('test_lock/held')
 
529
        t.put_bytes('test_lock/held/info', '\0')
 
530
        lf = LockDir(t, 'test_lock')
 
531
        self.assertRaises(errors.LockCorrupt, lf.peek)
 
532
        # Currently attempt_lock gives LockContention, but LockCorrupt would be
 
533
        # a reasonable result too.
 
534
        self.assertRaises(
 
535
            (errors.LockCorrupt, errors.LockContention), lf.attempt_lock)
 
536
        self.assertRaises(errors.LockCorrupt, lf.validate_token, 'fake token')
 
537
 
 
538
    def test_missing_lockdir_info(self):
 
539
        """We can cope with absent info files."""
 
540
        t = self.get_transport()
 
541
        t.mkdir('test_lock')
 
542
        t.mkdir('test_lock/held')
 
543
        lf = LockDir(t, 'test_lock')
 
544
        # In this case we expect the 'not held' result from peek, because peek
 
545
        # cannot be expected to notice that there is a 'held' directory with no
 
546
        # 'info' file.
 
547
        self.assertEqual(None, lf.peek())
 
548
        # And lock/unlock may work or give LockContention (but not any other
 
549
        # error).
 
550
        try:
 
551
            lf.attempt_lock()
 
552
        except LockContention:
 
553
            # LockContention is ok, and expected on Windows
 
554
            pass
 
555
        else:
 
556
            # no error is ok, and expected on POSIX (because POSIX allows
 
557
            # os.rename over an empty directory).
 
558
            lf.unlock()
 
559
        # Currently raises TokenMismatch, but LockCorrupt would be reasonable
 
560
        # too.
 
561
        self.assertRaises(
 
562
            (errors.TokenMismatch, errors.LockCorrupt),
 
563
            lf.validate_token, 'fake token')
 
564
 
 
565
 
 
566
class TestLockDirHooks(TestCaseWithTransport):
 
567
 
 
568
    def setUp(self):
 
569
        super(TestLockDirHooks, self).setUp()
 
570
        self._calls = []
 
571
 
 
572
    def get_lock(self):
 
573
        return LockDir(self.get_transport(), 'test_lock')
 
574
 
 
575
    def record_hook(self, result):
 
576
        self._calls.append(result)
 
577
 
 
578
    def test_LockDir_acquired_success(self):
 
579
        # the LockDir.lock_acquired hook fires when a lock is acquired.
 
580
        LockDir.hooks.install_named_hook('lock_acquired',
 
581
                                         self.record_hook, 'record_hook')
 
582
        ld = self.get_lock()
 
583
        ld.create()
 
584
        self.assertEqual([], self._calls)
 
585
        result = ld.attempt_lock()
 
586
        lock_path = ld.transport.abspath(ld.path)
 
587
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
 
588
        ld.unlock()
 
589
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
 
590
 
 
591
    def test_LockDir_acquired_fail(self):
 
592
        # the LockDir.lock_acquired hook does not fire on failure.
 
593
        ld = self.get_lock()
 
594
        ld.create()
 
595
        ld2 = self.get_lock()
 
596
        ld2.attempt_lock()
 
597
        # install a lock hook now, when the disk lock is locked
 
598
        LockDir.hooks.install_named_hook('lock_acquired',
 
599
                                         self.record_hook, 'record_hook')
 
600
        self.assertRaises(errors.LockContention, ld.attempt_lock)
 
601
        self.assertEqual([], self._calls)
 
602
        ld2.unlock()
 
603
        self.assertEqual([], self._calls)
 
604
 
 
605
    def test_LockDir_released_success(self):
 
606
        # the LockDir.lock_released hook fires when a lock is acquired.
 
607
        LockDir.hooks.install_named_hook('lock_released',
 
608
                                         self.record_hook, 'record_hook')
 
609
        ld = self.get_lock()
 
610
        ld.create()
 
611
        self.assertEqual([], self._calls)
 
612
        result = ld.attempt_lock()
 
613
        self.assertEqual([], self._calls)
 
614
        ld.unlock()
 
615
        lock_path = ld.transport.abspath(ld.path)
 
616
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
 
617
 
 
618
    def test_LockDir_released_fail(self):
 
619
        # the LockDir.lock_released hook does not fire on failure.
 
620
        ld = self.get_lock()
 
621
        ld.create()
 
622
        ld2 = self.get_lock()
 
623
        ld.attempt_lock()
 
624
        ld2.force_break(ld2.peek())
 
625
        LockDir.hooks.install_named_hook('lock_released',
 
626
                                         self.record_hook, 'record_hook')
 
627
        self.assertRaises(LockBroken, ld.unlock)
 
628
        self.assertEqual([], self._calls)
 
629
 
 
630
    def test_LockDir_broken_success(self):
 
631
        # the LockDir.lock_broken hook fires when a lock is broken.
 
632
        ld = self.get_lock()
 
633
        ld.create()
 
634
        ld2 = self.get_lock()
 
635
        result = ld.attempt_lock()
 
636
        LockDir.hooks.install_named_hook('lock_broken',
 
637
                                         self.record_hook, 'record_hook')
 
638
        ld2.force_break(ld2.peek())
 
639
        lock_path = ld.transport.abspath(ld.path)
 
640
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
 
641
 
 
642
    def test_LockDir_broken_failure(self):
 
643
        # the LockDir.lock_broken hook does not fires when a lock is already
 
644
        # released.
 
645
        ld = self.get_lock()
 
646
        ld.create()
 
647
        ld2 = self.get_lock()
 
648
        result = ld.attempt_lock()
 
649
        holder_info = ld2.peek()
 
650
        ld.unlock()
 
651
        LockDir.hooks.install_named_hook('lock_broken',
 
652
                                         self.record_hook, 'record_hook')
 
653
        ld2.force_break(holder_info)
 
654
        lock_path = ld.transport.abspath(ld.path)
 
655
        self.assertEqual([], self._calls)
 
656
 
 
657
 
 
658
class TestLockHeldInfo(TestCase):
 
659
    """Can get information about the lock holder, and detect whether they're
 
660
    still alive."""
 
661
 
 
662
    def test_repr(self):
 
663
        info = LockHeldInfo.for_this_process(None)
 
664
        self.assertContainsRe(repr(info), r"LockHeldInfo\(.*\)")
 
665
 
 
666
    def test_unicode(self):
 
667
        info = LockHeldInfo.for_this_process(None)
 
668
        self.assertContainsRe(unicode(info),
 
669
            r'held by .* on .* \(process #\d+\), acquired .* ago')
 
670
 
 
671
    def test_is_locked_by_this_process(self):
 
672
        info = LockHeldInfo.for_this_process(None)
 
673
        self.assertTrue(info.is_locked_by_this_process())
 
674
 
 
675
    def test_is_not_locked_by_this_process(self):
 
676
        info = LockHeldInfo.for_this_process(None)
 
677
        info.info_dict['pid'] = '123123123123123'
 
678
        self.assertFalse(info.is_locked_by_this_process())
 
679
 
 
680
    def test_lock_holder_live_process(self):
 
681
        """Detect that the holder (this process) is still running."""
 
682
        info = LockHeldInfo.for_this_process(None)
 
683
        self.assertFalse(info.is_lock_holder_known_dead())
 
684
 
 
685
    def test_lock_holder_dead_process(self):
 
686
        """Detect that the holder (this process) is still running."""
 
687
        info = LockHeldInfo.for_this_process(None)
 
688
        info.info_dict['pid'] = '123123123'
 
689
        self.assertTrue(info.is_lock_holder_known_dead())
 
690
 
 
691
    def test_lock_holder_other_machine(self):
 
692
        """The lock holder isn't here so we don't know if they're alive."""
 
693
        info = LockHeldInfo.for_this_process(None)
 
694
        info.info_dict['hostname'] = 'egg.example.com'
 
695
        info.info_dict['pid'] = '123123123'
 
696
        self.assertFalse(info.is_lock_holder_known_dead())
 
697
 
 
698
    def test_lock_holder_other_user(self):
 
699
        """Only auto-break locks held by this user."""
 
700
        info = LockHeldInfo.for_this_process(None)
 
701
        info.info_dict['user'] = 'notme@example.com'
 
702
        info.info_dict['pid'] = '123123123'
 
703
        self.assertFalse(info.is_lock_holder_known_dead())
 
704
 
 
705
    def test_no_good_hostname(self):
 
706
        """Correctly handle ambiguous hostnames.
 
707
 
 
708
        If the lock's recorded with just 'localhost' we can't really trust
 
709
        it's the same 'localhost'.  (There are quite a few of them. :-)
 
710
        So even if the process is known not to be alive, we can't say that's
 
711
        known for sure.
 
712
        """
 
713
        self.overrideAttr(lockdir, 'get_host_name',
 
714
            lambda: 'localhost')
 
715
        info = LockHeldInfo.for_this_process(None)
 
716
        info.info_dict['pid'] = '123123123'
 
717
        self.assertFalse(info.is_lock_holder_known_dead())
 
718
 
 
719
 
 
720
class TestStaleLockDir(TestCaseWithTransport):
 
721
    """Can automatically break stale locks.
 
722
 
 
723
    :see: https://bugs.launchpad.net/bzr/+bug/220464
 
724
    """
 
725
 
 
726
    def test_auto_break_stale_lock(self):
 
727
        """Locks safely known to be stale are just cleaned up.
 
728
 
 
729
        This generates a warning but no other user interaction.
 
730
        """
 
731
        # This is off by default at present; see the discussion in the bug.
 
732
        # If you change the default, don't forget to update the docs.
 
733
        config.GlobalConfig().set_user_option('locks.steal_dead', True)
 
734
        # Create a lock pretending to come from a different nonexistent
 
735
        # process on the same machine.
 
736
        l1 = LockDir(self.get_transport(), 'a',
 
737
            extra_holder_info={'pid': '12312313'})
 
738
        token_1 = l1.attempt_lock()
 
739
        l2 = LockDir(self.get_transport(), 'a')
 
740
        token_2 = l2.attempt_lock()
 
741
        # l1 will notice its lock was stolen.
 
742
        self.assertRaises(errors.LockBroken,
 
743
            l1.unlock)
 
744
        l2.unlock()
 
745
 
 
746
    def test_auto_break_stale_lock_configured_off(self):
 
747
        """Automatic breaking can be turned off"""
 
748
        l1 = LockDir(self.get_transport(), 'a',
 
749
            extra_holder_info={'pid': '12312313'})
 
750
        token_1 = l1.attempt_lock()
 
751
        self.addCleanup(l1.unlock)
 
752
        l2 = LockDir(self.get_transport(), 'a')
 
753
        # This fails now, because dead lock breaking is off by default.
 
754
        self.assertRaises(LockContention,
 
755
            l2.attempt_lock)
 
756
        # and it's in fact not broken
 
757
        l1.confirm()