← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/plugins/launchpad/lp_propose.py

  • Committer: John Arbash Meinel
  • Date: 2011-05-11 11:35:28 UTC
  • mto: This revision was merged to the branch mainline in revision 5851.
  • Revision ID: john@arbash-meinel.com-20110511113528-qepibuwxicjrbb2h
Break compatibility with python <2.6.

This includes auditing the code for places where we were doing
explicit 'sys.version' checks and removing them as appropriate.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/plugins/launchpad/lp_propose.py
1
 
# Copyright (C) 2010 Canonical Ltd
 
1
# Copyright (C) 2010, 2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
 
18
 
import urlparse
19
 
import webbrowser
20
 
 
21
17
from bzrlib import (
22
18
    errors,
23
19
    hooks,
 
20
    )
 
21
from bzrlib.lazy_import import lazy_import
 
22
lazy_import(globals(), """
 
23
import webbrowser
 
24
 
 
25
from bzrlib import (
24
26
    msgeditor,
25
 
)
 
27
    )
26
28
from bzrlib.plugins.launchpad import (
27
29
    lp_api,
28
30
    lp_registration,
29
 
)
30
 
 
31
 
from lazr.restfulclient import errors as restful_errors
 
31
    )
 
32
""")
32
33
 
33
34
 
34
35
class ProposeMergeHooks(hooks.Hooks):
35
36
    """Hooks for proposing a merge on Launchpad."""
36
37
 
37
38
    def __init__(self):
38
 
        hooks.Hooks.__init__(self)
39
 
        self.create_hook(
40
 
            hooks.HookPoint(
41
 
                'get_prerequisite',
42
 
                "Return the prerequisite branch for proposing as merge.",
43
 
                (2, 1), None),
44
 
        )
45
 
        self.create_hook(
46
 
            hooks.HookPoint(
47
 
                'merge_proposal_body',
48
 
                "Return an initial body for the merge proposal message.",
49
 
                (2, 1), None),
50
 
        )
 
39
        hooks.Hooks.__init__(self, "bzrlib.plugins.launchpad.lp_propose",
 
40
            "Proposer.hooks")
 
41
        self.add_hook('get_prerequisite',
 
42
            "Return the prerequisite branch for proposing as merge.", (2, 1))
 
43
        self.add_hook('merge_proposal_body',
 
44
            "Return an initial body for the merge proposal message.", (2, 1))
51
45
 
52
46
 
53
47
class Proposer(object):
74
68
        if staging:
75
69
            lp_instance = 'staging'
76
70
        else:
77
 
            lp_instance = 'edge'
 
71
            lp_instance = 'production'
78
72
        service = lp_registration.LaunchpadService(lp_instance=lp_instance)
79
73
        self.launchpad = lp_api.login(service)
80
74
        self.source_branch = lp_api.LaunchpadBranch.from_bzr(
81
75
            self.launchpad, source_branch)
82
76
        if target_branch is None:
83
 
            self.target_branch = self.source_branch.get_dev_focus()
 
77
            self.target_branch = self.source_branch.get_target()
84
78
        else:
85
79
            self.target_branch = lp_api.LaunchpadBranch.from_bzr(
86
80
                self.launchpad, target_branch)
87
81
        self.commit_message = message
88
82
        # XXX: this is where bug lp:583638 could be tackled.
89
83
        if reviews == []:
90
 
            target_reviewer = self.target_branch.lp.reviewer
91
 
            if target_reviewer is None:
92
 
                raise errors.BzrCommandError('No reviewer specified')
93
 
            self.reviews = [(target_reviewer, '')]
 
84
            self.reviews = []
94
85
        else:
95
86
            self.reviews = [(self.launchpad.people[reviewer], review_type)
96
87
                            for reviewer, review_type in
153
144
            if mp.target_branch.self_link == self.target_branch.lp.self_link:
154
145
                raise errors.BzrCommandError(
155
146
                    'There is already a branch merge proposal: %s' %
156
 
                    canonical_url(mp))
 
147
                    lp_api.canonical_url(mp))
157
148
 
158
149
    def _get_prerequisite_branch(self):
159
150
        hooks = self.hooks['get_prerequisite']
174
165
        :param **kwargs: **kwargs for the call.
175
166
        :return: The result of calling call(*args, *kwargs).
176
167
        """
 
168
        from lazr.restfulclient import errors as restful_errors
177
169
        try:
178
170
            return call(*args, **kwargs)
179
171
        except restful_errors.HTTPError, e:
208
200
            review_types=review_types)
209
201
        if self.approve:
210
202
            self.call_webservice(mp.setStatus, status='Approved')
211
 
        webbrowser.open(canonical_url(mp))
 
203
        webbrowser.open(lp_api.canonical_url(mp))
212
204
 
213
205
 
214
206
def modified_files(old_tree, new_tree):
217
209
        old_tree):
218
210
        if c and k == 'file':
219
211
            yield str(path)
220
 
 
221
 
 
222
 
def canonical_url(object):
223
 
    """Return the canonical URL for a branch."""
224
 
    scheme, netloc, path, params, query, fragment = urlparse.urlparse(
225
 
        str(object.self_link))
226
 
    path = '/'.join(path.split('/')[2:])
227
 
    netloc = netloc.replace('api.', 'code.')
228
 
    return urlparse.urlunparse((scheme, netloc, path, params, query,
229
 
                                fragment))