~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_http.py

  • Committer: Andrew Bennetts
  • Date: 2011-05-05 06:11:43 UTC
  • mto: This revision was merged to the branch mainline in revision 5831.
  • Revision ID: andrew.bennetts@canonical.com-20110505061143-54119u25xtrfd28m
Share _group_cache when using GroupCompressVersionedFiles.without_fallbacks, and move _find_parents_keys_of_revisions call to before we clear repo.revisions' cache.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
23
23
# TODO: Should be renamed to bzrlib.transport.http.tests?
24
24
# TODO: What about renaming to bzrlib.tests.transport.http ?
25
25
 
26
 
from cStringIO import StringIO
27
26
import httplib
28
 
import os
29
 
import select
30
27
import SimpleHTTPServer
31
28
import socket
32
29
import sys
35
32
import bzrlib
36
33
from bzrlib import (
37
34
    bzrdir,
 
35
    cethread,
38
36
    config,
39
37
    errors,
40
38
    osutils,
42
40
    tests,
43
41
    transport,
44
42
    ui,
45
 
    urlutils,
46
 
    )
47
 
from bzrlib.symbol_versioning import (
48
 
    deprecated_in,
49
43
    )
50
44
from bzrlib.tests import (
51
45
    features,
52
46
    http_server,
53
47
    http_utils,
 
48
    test_server,
 
49
    )
 
50
from bzrlib.tests.scenarios import (
 
51
    load_tests_apply_scenarios,
 
52
    multiply_scenarios,
54
53
    )
55
54
from bzrlib.transport import (
56
55
    http,
66
65
    from bzrlib.transport.http._pycurl import PyCurlTransport
67
66
 
68
67
 
69
 
def load_tests(standard_tests, module, loader):
70
 
    """Multiply tests for http clients and protocol versions."""
71
 
    result = loader.suiteClass()
72
 
 
73
 
    # one for each transport implementation
74
 
    t_tests, remaining_tests = tests.split_suite_by_condition(
75
 
        standard_tests, tests.condition_isinstance((
76
 
                TestHttpTransportRegistration,
77
 
                TestHttpTransportUrls,
78
 
                Test_redirected_to,
79
 
                )))
 
68
load_tests = load_tests_apply_scenarios
 
69
 
 
70
 
 
71
def vary_by_http_client_implementation():
 
72
    """Test the two libraries we can use, pycurl and urllib."""
80
73
    transport_scenarios = [
81
74
        ('urllib', dict(_transport=_urllib.HttpTransport_urllib,
82
75
                        _server=http_server.HttpServer_urllib,
83
 
                        _qualified_prefix='http+urllib',)),
 
76
                        _url_protocol='http+urllib',)),
84
77
        ]
85
78
    if features.pycurl.available():
86
79
        transport_scenarios.append(
87
80
            ('pycurl', dict(_transport=PyCurlTransport,
88
81
                            _server=http_server.HttpServer_PyCurl,
89
 
                            _qualified_prefix='http+pycurl',)))
90
 
    tests.multiply_tests(t_tests, transport_scenarios, result)
91
 
 
92
 
    # each implementation tested with each HTTP version
93
 
    tp_tests, remaining_tests = tests.split_suite_by_condition(
94
 
        remaining_tests, tests.condition_isinstance((
95
 
                SmartHTTPTunnellingTest,
96
 
                TestDoCatchRedirections,
97
 
                TestHTTPConnections,
98
 
                TestHTTPRedirections,
99
 
                TestHTTPSilentRedirections,
100
 
                TestLimitedRangeRequestServer,
101
 
                TestPost,
102
 
                TestProxyHttpServer,
103
 
                TestRanges,
104
 
                TestSpecificRequestHandler,
105
 
                )))
106
 
    protocol_scenarios = [
107
 
            ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
108
 
            ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
109
 
            ]
110
 
    tp_scenarios = tests.multiply_scenarios(transport_scenarios,
111
 
                                            protocol_scenarios)
112
 
    tests.multiply_tests(tp_tests, tp_scenarios, result)
113
 
 
114
 
    # proxy auth: each auth scheme on all http versions on all implementations.
115
 
    tppa_tests, remaining_tests = tests.split_suite_by_condition(
116
 
        remaining_tests, tests.condition_isinstance((
117
 
                TestProxyAuth,
118
 
                )))
119
 
    proxy_auth_scheme_scenarios = [
 
82
                            _url_protocol='http+pycurl',)))
 
83
    return transport_scenarios
 
84
 
 
85
 
 
86
def vary_by_http_protocol_version():
 
87
    """Test on http/1.0 and 1.1"""
 
88
    return [
 
89
        ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
 
90
        ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
 
91
        ]
 
92
 
 
93
 
 
94
def vary_by_http_proxy_auth_scheme():
 
95
    return [
120
96
        ('basic', dict(_auth_server=http_utils.ProxyBasicAuthServer)),
121
97
        ('digest', dict(_auth_server=http_utils.ProxyDigestAuthServer)),
122
98
        ('basicdigest',
123
 
         dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
 
99
            dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
124
100
        ]
125
 
    tppa_scenarios = tests.multiply_scenarios(tp_scenarios,
126
 
                                              proxy_auth_scheme_scenarios)
127
 
    tests.multiply_tests(tppa_tests, tppa_scenarios, result)
128
 
 
129
 
    # auth: each auth scheme on all http versions on all implementations.
130
 
    tpa_tests, remaining_tests = tests.split_suite_by_condition(
131
 
        remaining_tests, tests.condition_isinstance((
132
 
                TestAuth,
133
 
                )))
134
 
    auth_scheme_scenarios = [
 
101
 
 
102
 
 
103
def vary_by_http_auth_scheme():
 
104
    return [
135
105
        ('basic', dict(_auth_server=http_utils.HTTPBasicAuthServer)),
136
106
        ('digest', dict(_auth_server=http_utils.HTTPDigestAuthServer)),
137
107
        ('basicdigest',
138
 
         dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
 
108
            dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
139
109
        ]
140
 
    tpa_scenarios = tests.multiply_scenarios(tp_scenarios,
141
 
                                             auth_scheme_scenarios)
142
 
    tests.multiply_tests(tpa_tests, tpa_scenarios, result)
143
 
 
144
 
    # activity: on all http[s] versions on all implementations
145
 
    tpact_tests, remaining_tests = tests.split_suite_by_condition(
146
 
        remaining_tests, tests.condition_isinstance((
147
 
                TestActivity,
148
 
                )))
 
110
 
 
111
 
 
112
def vary_by_http_activity():
149
113
    activity_scenarios = [
150
114
        ('urllib,http', dict(_activity_server=ActivityHTTPServer,
151
 
                             _transport=_urllib.HttpTransport_urllib,)),
 
115
                            _transport=_urllib.HttpTransport_urllib,)),
152
116
        ]
153
117
    if tests.HTTPSServerFeature.available():
154
118
        activity_scenarios.append(
155
119
            ('urllib,https', dict(_activity_server=ActivityHTTPSServer,
156
 
                                  _transport=_urllib.HttpTransport_urllib,)),)
 
120
                                _transport=_urllib.HttpTransport_urllib,)),)
157
121
    if features.pycurl.available():
158
122
        activity_scenarios.append(
159
123
            ('pycurl,http', dict(_activity_server=ActivityHTTPServer,
160
 
                                 _transport=PyCurlTransport,)),)
 
124
                                _transport=PyCurlTransport,)),)
161
125
        if tests.HTTPSServerFeature.available():
162
126
            from bzrlib.tests import (
163
127
                ssl_certs,
175
139
 
176
140
            activity_scenarios.append(
177
141
                ('pycurl,https', dict(_activity_server=ActivityHTTPSServer,
178
 
                                      _transport=HTTPS_pycurl_transport,)),)
179
 
 
180
 
    tpact_scenarios = tests.multiply_scenarios(activity_scenarios,
181
 
                                               protocol_scenarios)
182
 
    tests.multiply_tests(tpact_tests, tpact_scenarios, result)
183
 
 
184
 
    # No parametrization for the remaining tests
185
 
    result.addTests(remaining_tests)
186
 
 
187
 
    return result
 
142
                                    _transport=HTTPS_pycurl_transport,)),)
 
143
    return activity_scenarios
188
144
 
189
145
 
190
146
class FakeManager(object):
223
179
        self._sock.bind(('127.0.0.1', 0))
224
180
        self.host, self.port = self._sock.getsockname()
225
181
        self._ready = threading.Event()
226
 
        self._thread = threading.Thread(target=self._accept_read_and_reply)
227
 
        self._thread.setDaemon(True)
 
182
        self._thread = test_server.TestThread(
 
183
            sync_event=self._ready, target=self._accept_read_and_reply)
228
184
        self._thread.start()
229
 
        self._ready.wait(5)
 
185
        if 'threads' in tests.selftest_debug_flags:
 
186
            sys.stderr.write('Thread started: %s\n' % (self._thread.ident,))
 
187
        self._ready.wait()
230
188
 
231
189
    def _accept_read_and_reply(self):
232
190
        self._sock.listen(1)
233
191
        self._ready.set()
234
 
        self._sock.settimeout(5)
235
 
        try:
236
 
            conn, address = self._sock.accept()
237
 
            # On win32, the accepted connection will be non-blocking to start
238
 
            # with because we're using settimeout.
239
 
            conn.setblocking(True)
 
192
        conn, address = self._sock.accept()
 
193
        if self._expect_body_tail is not None:
240
194
            while not self.received_bytes.endswith(self._expect_body_tail):
241
195
                self.received_bytes += conn.recv(4096)
242
196
            conn.sendall('HTTP/1.1 200 OK\r\n')
243
 
        except socket.timeout:
244
 
            # Make sure the client isn't stuck waiting for us to e.g. accept.
 
197
        try:
245
198
            self._sock.close()
246
199
        except socket.error:
247
200
            # The client may have already closed the socket.
249
202
 
250
203
    def stop_server(self):
251
204
        try:
252
 
            self._sock.close()
 
205
            # Issue a fake connection to wake up the server and allow it to
 
206
            # finish quickly
 
207
            fake_conn = osutils.connect_socket((self.host, self.port))
 
208
            fake_conn.close()
253
209
        except socket.error:
254
210
            # We might have already closed it.  We don't care.
255
211
            pass
256
212
        self.host = None
257
213
        self.port = None
 
214
        self._thread.join()
 
215
        if 'threads' in tests.selftest_debug_flags:
 
216
            sys.stderr.write('Thread  joined: %s\n' % (self._thread.ident,))
258
217
 
259
218
 
260
219
class TestAuthHeader(tests.TestCase):
296
255
        self.assertEqual('realm="Thou should not pass"', remainder)
297
256
 
298
257
 
 
258
class TestHTTPRangeParsing(tests.TestCase):
 
259
 
 
260
    def setUp(self):
 
261
        super(TestHTTPRangeParsing, self).setUp()
 
262
        # We focus on range  parsing here and ignore everything else
 
263
        class RequestHandler(http_server.TestingHTTPRequestHandler):
 
264
            def setup(self): pass
 
265
            def handle(self): pass
 
266
            def finish(self): pass
 
267
 
 
268
        self.req_handler = RequestHandler(None, None, None)
 
269
 
 
270
    def assertRanges(self, ranges, header, file_size):
 
271
        self.assertEquals(ranges,
 
272
                          self.req_handler._parse_ranges(header, file_size))
 
273
 
 
274
    def test_simple_range(self):
 
275
        self.assertRanges([(0,2)], 'bytes=0-2', 12)
 
276
 
 
277
    def test_tail(self):
 
278
        self.assertRanges([(8, 11)], 'bytes=-4', 12)
 
279
 
 
280
    def test_tail_bigger_than_file(self):
 
281
        self.assertRanges([(0, 11)], 'bytes=-99', 12)
 
282
 
 
283
    def test_range_without_end(self):
 
284
        self.assertRanges([(4, 11)], 'bytes=4-', 12)
 
285
 
 
286
    def test_invalid_ranges(self):
 
287
        self.assertRanges(None, 'bytes=12-22', 12)
 
288
        self.assertRanges(None, 'bytes=1-3,12-22', 12)
 
289
        self.assertRanges(None, 'bytes=-', 12)
 
290
 
 
291
 
299
292
class TestHTTPServer(tests.TestCase):
300
293
    """Test the HTTP servers implementations."""
301
294
 
304
297
 
305
298
            protocol_version = 'HTTP/0.1'
306
299
 
307
 
        server = http_server.HttpServer(BogusRequestHandler)
308
 
        try:
309
 
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
310
 
        except:
311
 
            server.stop_server()
312
 
            self.fail('HTTP Server creation did not raise UnknownProtocol')
 
300
        self.assertRaises(httplib.UnknownProtocol,
 
301
                          http_server.HttpServer, BogusRequestHandler)
313
302
 
314
303
    def test_force_invalid_protocol(self):
315
 
        server = http_server.HttpServer(protocol_version='HTTP/0.1')
316
 
        try:
317
 
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
318
 
        except:
319
 
            server.stop_server()
320
 
            self.fail('HTTP Server creation did not raise UnknownProtocol')
 
304
        self.assertRaises(httplib.UnknownProtocol,
 
305
                          http_server.HttpServer, protocol_version='HTTP/0.1')
321
306
 
322
307
    def test_server_start_and_stop(self):
323
308
        server = http_server.HttpServer()
 
309
        self.addCleanup(server.stop_server)
324
310
        server.start_server()
325
 
        try:
326
 
            self.assertTrue(server._http_running)
327
 
        finally:
328
 
            server.stop_server()
329
 
        self.assertFalse(server._http_running)
 
311
        self.assertTrue(server.server is not None)
 
312
        self.assertTrue(server.server.serving is not None)
 
313
        self.assertTrue(server.server.serving)
330
314
 
331
315
    def test_create_http_server_one_zero(self):
332
316
        class RequestHandlerOneZero(http_server.TestingHTTPRequestHandler):
335
319
 
336
320
        server = http_server.HttpServer(RequestHandlerOneZero)
337
321
        self.start_server(server)
338
 
        self.assertIsInstance(server._httpd, http_server.TestingHTTPServer)
 
322
        self.assertIsInstance(server.server, http_server.TestingHTTPServer)
339
323
 
340
324
    def test_create_http_server_one_one(self):
341
325
        class RequestHandlerOneOne(http_server.TestingHTTPRequestHandler):
344
328
 
345
329
        server = http_server.HttpServer(RequestHandlerOneOne)
346
330
        self.start_server(server)
347
 
        self.assertIsInstance(server._httpd,
 
331
        self.assertIsInstance(server.server,
348
332
                              http_server.TestingThreadingHTTPServer)
349
333
 
350
334
    def test_create_http_server_force_one_one(self):
355
339
        server = http_server.HttpServer(RequestHandlerOneZero,
356
340
                                        protocol_version='HTTP/1.1')
357
341
        self.start_server(server)
358
 
        self.assertIsInstance(server._httpd,
 
342
        self.assertIsInstance(server.server,
359
343
                              http_server.TestingThreadingHTTPServer)
360
344
 
361
345
    def test_create_http_server_force_one_zero(self):
366
350
        server = http_server.HttpServer(RequestHandlerOneOne,
367
351
                                        protocol_version='HTTP/1.0')
368
352
        self.start_server(server)
369
 
        self.assertIsInstance(server._httpd,
 
353
        self.assertIsInstance(server.server,
370
354
                              http_server.TestingHTTPServer)
371
355
 
372
356
 
401
385
class TestHttpTransportUrls(tests.TestCase):
402
386
    """Test the http urls."""
403
387
 
 
388
    scenarios = vary_by_http_client_implementation()
 
389
 
404
390
    def test_abs_url(self):
405
391
        """Construction of absolute http URLs"""
406
 
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
 
392
        t = self._transport('http://example.com/bzr/bzr.dev/')
407
393
        eq = self.assertEqualDiff
408
 
        eq(t.abspath('.'), 'http://bazaar-vcs.org/bzr/bzr.dev')
409
 
        eq(t.abspath('foo/bar'), 'http://bazaar-vcs.org/bzr/bzr.dev/foo/bar')
410
 
        eq(t.abspath('.bzr'), 'http://bazaar-vcs.org/bzr/bzr.dev/.bzr')
 
394
        eq(t.abspath('.'), 'http://example.com/bzr/bzr.dev')
 
395
        eq(t.abspath('foo/bar'), 'http://example.com/bzr/bzr.dev/foo/bar')
 
396
        eq(t.abspath('.bzr'), 'http://example.com/bzr/bzr.dev/.bzr')
411
397
        eq(t.abspath('.bzr/1//2/./3'),
412
 
           'http://bazaar-vcs.org/bzr/bzr.dev/.bzr/1/2/3')
 
398
           'http://example.com/bzr/bzr.dev/.bzr/1/2/3')
413
399
 
414
400
    def test_invalid_http_urls(self):
415
401
        """Trap invalid construction of urls"""
416
 
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
 
402
        self._transport('http://example.com/bzr/bzr.dev/')
417
403
        self.assertRaises(errors.InvalidURL,
418
404
                          self._transport,
419
 
                          'http://http://bazaar-vcs.org/bzr/bzr.dev/')
 
405
                          'http://http://example.com/bzr/bzr.dev/')
420
406
 
421
407
    def test_http_root_urls(self):
422
408
        """Construction of URLs from server root"""
423
 
        t = self._transport('http://bzr.ozlabs.org/')
 
409
        t = self._transport('http://example.com/')
424
410
        eq = self.assertEqualDiff
425
411
        eq(t.abspath('.bzr/tree-version'),
426
 
           'http://bzr.ozlabs.org/.bzr/tree-version')
 
412
           'http://example.com/.bzr/tree-version')
427
413
 
428
414
    def test_http_impl_urls(self):
429
415
        """There are servers which ask for particular clients to connect"""
431
417
        server.start_server()
432
418
        try:
433
419
            url = server.get_url()
434
 
            self.assertTrue(url.startswith('%s://' % self._qualified_prefix))
 
420
            self.assertTrue(url.startswith('%s://' % self._url_protocol))
435
421
        finally:
436
422
            server.stop_server()
437
423
 
475
461
class TestHTTPConnections(http_utils.TestCaseWithWebserver):
476
462
    """Test the http connections."""
477
463
 
 
464
    scenarios = multiply_scenarios(
 
465
        vary_by_http_client_implementation(),
 
466
        vary_by_http_protocol_version(),
 
467
        )
 
468
 
478
469
    def setUp(self):
479
470
        http_utils.TestCaseWithWebserver.setUp(self)
480
471
        self.build_tree(['foo/', 'foo/bar'], line_endings='binary',
482
473
 
483
474
    def test_http_has(self):
484
475
        server = self.get_readonly_server()
485
 
        t = self._transport(server.get_url())
 
476
        t = self.get_readonly_transport()
486
477
        self.assertEqual(t.has('foo/bar'), True)
487
478
        self.assertEqual(len(server.logs), 1)
488
479
        self.assertContainsRe(server.logs[0],
490
481
 
491
482
    def test_http_has_not_found(self):
492
483
        server = self.get_readonly_server()
493
 
        t = self._transport(server.get_url())
 
484
        t = self.get_readonly_transport()
494
485
        self.assertEqual(t.has('not-found'), False)
495
486
        self.assertContainsRe(server.logs[1],
496
487
            r'"HEAD /not-found HTTP/1.." 404 - "-" "bzr/')
497
488
 
498
489
    def test_http_get(self):
499
490
        server = self.get_readonly_server()
500
 
        t = self._transport(server.get_url())
 
491
        t = self.get_readonly_transport()
501
492
        fp = t.get('foo/bar')
502
493
        self.assertEqualDiff(
503
494
            fp.read(),
525
516
class TestHttpTransportRegistration(tests.TestCase):
526
517
    """Test registrations of various http implementations"""
527
518
 
 
519
    scenarios = vary_by_http_client_implementation()
 
520
 
528
521
    def test_http_registered(self):
529
 
        t = transport.get_transport('%s://foo.com/' % self._qualified_prefix)
 
522
        t = transport.get_transport('%s://foo.com/' % self._url_protocol)
530
523
        self.assertIsInstance(t, transport.Transport)
531
524
        self.assertIsInstance(t, self._transport)
532
525
 
533
526
 
534
527
class TestPost(tests.TestCase):
535
528
 
 
529
    scenarios = multiply_scenarios(
 
530
        vary_by_http_client_implementation(),
 
531
        vary_by_http_protocol_version(),
 
532
        )
 
533
 
536
534
    def test_post_body_is_received(self):
537
535
        server = RecordingServer(expect_body_tail='end-of-body',
538
 
            scheme=self._qualified_prefix)
 
536
                                 scheme=self._url_protocol)
539
537
        self.start_server(server)
540
538
        url = server.get_url()
541
 
        http_transport = self._transport(url)
 
539
        # FIXME: needs a cleanup -- vila 20100611
 
540
        http_transport = transport.get_transport(url)
542
541
        code, response = http_transport._post('abc def end-of-body')
543
542
        self.assertTrue(
544
543
            server.received_bytes.startswith('POST /.bzr/smart HTTP/1.'))
545
544
        self.assertTrue('content-length: 19\r' in server.received_bytes.lower())
 
545
        self.assertTrue('content-type: application/octet-stream\r'
 
546
                        in server.received_bytes.lower())
546
547
        # The transport should not be assuming that the server can accept
547
548
        # chunked encoding the first time it connects, because HTTP/1.1, so we
548
549
        # check for the literal string.
584
585
    Daughter classes are expected to override _req_handler_class
585
586
    """
586
587
 
 
588
    scenarios = multiply_scenarios(
 
589
        vary_by_http_client_implementation(),
 
590
        vary_by_http_protocol_version(),
 
591
        )
 
592
 
587
593
    # Provide a useful default
588
594
    _req_handler_class = http_server.TestingHTTPRequestHandler
589
595
 
590
596
    def create_transport_readonly_server(self):
591
 
        return http_server.HttpServer(self._req_handler_class,
592
 
                                      protocol_version=self._protocol_version)
 
597
        server = http_server.HttpServer(self._req_handler_class,
 
598
                                        protocol_version=self._protocol_version)
 
599
        server._url_protocol = self._url_protocol
 
600
        return server
593
601
 
594
602
    def _testing_pycurl(self):
595
603
        # TODO: This is duplicated for lots of the classes in this file
600
608
class WallRequestHandler(http_server.TestingHTTPRequestHandler):
601
609
    """Whatever request comes in, close the connection"""
602
610
 
603
 
    def handle_one_request(self):
 
611
    def _handle_one_request(self):
604
612
        """Handle a single HTTP request, by abruptly closing the connection"""
605
613
        self.close_connection = 1
606
614
 
611
619
    _req_handler_class = WallRequestHandler
612
620
 
613
621
    def test_http_has(self):
614
 
        server = self.get_readonly_server()
615
 
        t = self._transport(server.get_url())
 
622
        t = self.get_readonly_transport()
616
623
        # Unfortunately httplib (see HTTPResponse._read_status
617
624
        # for details) make no distinction between a closed
618
625
        # socket and badly formatted status line, so we can't
624
631
                          t.has, 'foo/bar')
625
632
 
626
633
    def test_http_get(self):
627
 
        server = self.get_readonly_server()
628
 
        t = self._transport(server.get_url())
 
634
        t = self.get_readonly_transport()
629
635
        self.assertRaises((errors.ConnectionError, errors.ConnectionReset,
630
636
                           errors.InvalidHttpResponse),
631
637
                          t.get, 'foo/bar')
648
654
    _req_handler_class = BadStatusRequestHandler
649
655
 
650
656
    def test_http_has(self):
651
 
        server = self.get_readonly_server()
652
 
        t = self._transport(server.get_url())
 
657
        t = self.get_readonly_transport()
653
658
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
654
659
 
655
660
    def test_http_get(self):
656
 
        server = self.get_readonly_server()
657
 
        t = self._transport(server.get_url())
 
661
        t = self.get_readonly_transport()
658
662
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
659
663
 
660
664
 
665
669
        """Fakes handling a single HTTP request, returns a bad status"""
666
670
        ignored = http_server.TestingHTTPRequestHandler.parse_request(self)
667
671
        self.wfile.write("Invalid status line\r\n")
 
672
        # If we don't close the connection pycurl will hang. Since this is a
 
673
        # stress test we don't *have* to respect the protocol, but we don't
 
674
        # have to sabotage it too much either.
 
675
        self.close_connection = True
668
676
        return False
669
677
 
670
678
 
676
684
 
677
685
    _req_handler_class = InvalidStatusRequestHandler
678
686
 
679
 
    def test_http_has(self):
680
 
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
681
 
            raise tests.KnownFailure(
682
 
                'pycurl hangs if the server send back garbage')
683
 
        super(TestInvalidStatusServer, self).test_http_has()
684
 
 
685
 
    def test_http_get(self):
686
 
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
687
 
            raise tests.KnownFailure(
688
 
                'pycurl hangs if the server send back garbage')
689
 
        super(TestInvalidStatusServer, self).test_http_get()
690
 
 
691
687
 
692
688
class BadProtocolRequestHandler(http_server.TestingHTTPRequestHandler):
693
689
    """Whatever request comes in, returns a bad protocol version"""
715
711
        super(TestBadProtocolServer, self).setUp()
716
712
 
717
713
    def test_http_has(self):
718
 
        server = self.get_readonly_server()
719
 
        t = self._transport(server.get_url())
 
714
        t = self.get_readonly_transport()
720
715
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
721
716
 
722
717
    def test_http_get(self):
723
 
        server = self.get_readonly_server()
724
 
        t = self._transport(server.get_url())
 
718
        t = self.get_readonly_transport()
725
719
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
726
720
 
727
721
 
741
735
    _req_handler_class = ForbiddenRequestHandler
742
736
 
743
737
    def test_http_has(self):
744
 
        server = self.get_readonly_server()
745
 
        t = self._transport(server.get_url())
 
738
        t = self.get_readonly_transport()
746
739
        self.assertRaises(errors.TransportError, t.has, 'foo/bar')
747
740
 
748
741
    def test_http_get(self):
749
 
        server = self.get_readonly_server()
750
 
        t = self._transport(server.get_url())
 
742
        t = self.get_readonly_transport()
751
743
        self.assertRaises(errors.TransportError, t.get, 'foo/bar')
752
744
 
753
745
 
792
784
        self.build_tree_contents([('a', '0123456789')],)
793
785
 
794
786
    def test_readv(self):
795
 
        server = self.get_readonly_server()
796
 
        t = self._transport(server.get_url())
 
787
        t = self.get_readonly_transport()
797
788
        l = list(t.readv('a', ((0, 1), (1, 1), (3, 2), (9, 1))))
798
789
        self.assertEqual(l[0], (0, '0'))
799
790
        self.assertEqual(l[1], (1, '1'))
801
792
        self.assertEqual(l[3], (9, '9'))
802
793
 
803
794
    def test_readv_out_of_order(self):
804
 
        server = self.get_readonly_server()
805
 
        t = self._transport(server.get_url())
 
795
        t = self.get_readonly_transport()
806
796
        l = list(t.readv('a', ((1, 1), (9, 1), (0, 1), (3, 2))))
807
797
        self.assertEqual(l[0], (1, '1'))
808
798
        self.assertEqual(l[1], (9, '9'))
810
800
        self.assertEqual(l[3], (3, '34'))
811
801
 
812
802
    def test_readv_invalid_ranges(self):
813
 
        server = self.get_readonly_server()
814
 
        t = self._transport(server.get_url())
 
803
        t = self.get_readonly_transport()
815
804
 
816
805
        # This is intentionally reading off the end of the file
817
806
        # since we are sure that it cannot get there
825
814
 
826
815
    def test_readv_multiple_get_requests(self):
827
816
        server = self.get_readonly_server()
828
 
        t = self._transport(server.get_url())
 
817
        t = self.get_readonly_transport()
829
818
        # force transport to issue multiple requests
830
819
        t._max_readv_combine = 1
831
820
        t._max_get_ranges = 1
839
828
 
840
829
    def test_readv_get_max_size(self):
841
830
        server = self.get_readonly_server()
842
 
        t = self._transport(server.get_url())
 
831
        t = self.get_readonly_transport()
843
832
        # force transport to issue multiple requests by limiting the number of
844
833
        # bytes by request. Note that this apply to coalesced offsets only, a
845
834
        # single range will keep its size even if bigger than the limit.
854
843
 
855
844
    def test_complete_readv_leave_pipe_clean(self):
856
845
        server = self.get_readonly_server()
857
 
        t = self._transport(server.get_url())
 
846
        t = self.get_readonly_transport()
858
847
        # force transport to issue multiple requests
859
848
        t._get_max_size = 2
860
 
        l = list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
 
849
        list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
861
850
        # The server should have issued 3 requests
862
851
        self.assertEqual(3, server.GET_request_nb)
863
852
        self.assertEqual('0123456789', t.get_bytes('a'))
865
854
 
866
855
    def test_incomplete_readv_leave_pipe_clean(self):
867
856
        server = self.get_readonly_server()
868
 
        t = self._transport(server.get_url())
 
857
        t = self.get_readonly_transport()
869
858
        # force transport to issue multiple requests
870
859
        t._get_max_size = 2
871
860
        # Don't collapse readv results into a list so that we leave unread
940
929
    def get_multiple_ranges(self, file, file_size, ranges):
941
930
        self.send_response(206)
942
931
        self.send_header('Accept-Ranges', 'bytes')
 
932
        # XXX: this is strange; the 'random' name below seems undefined and
 
933
        # yet the tests pass -- mbp 2010-10-11 bug 658773
943
934
        boundary = "%d" % random.randint(0,0x7FFFFFFF)
944
935
        self.send_header("Content-Type",
945
936
                         "multipart/byteranges; boundary=%s" % boundary)
1007
998
                return
1008
999
            self.send_range_content(file, start, end - start + 1)
1009
1000
            cur += 1
1010
 
        # No final boundary
 
1001
        # Final boundary
1011
1002
        self.wfile.write(boundary_line)
1012
1003
 
1013
1004
 
1021
1012
 
1022
1013
    def test_readv_with_short_reads(self):
1023
1014
        server = self.get_readonly_server()
1024
 
        t = self._transport(server.get_url())
 
1015
        t = self.get_readonly_transport()
1025
1016
        # Force separate ranges for each offset
1026
1017
        t._bytes_to_read_before_seek = 0
1027
1018
        ireadv = iter(t.readv('a', ((0, 1), (2, 1), (4, 2), (9, 1))))
1042
1033
        # that mode
1043
1034
        self.assertEqual('single', t._range_hint)
1044
1035
 
 
1036
 
1045
1037
class LimitedRangeRequestHandler(http_server.TestingHTTPRequestHandler):
1046
1038
    """Errors out when range specifiers exceed the limit"""
1047
1039
 
1071
1063
class TestLimitedRangeRequestServer(http_utils.TestCaseWithWebserver):
1072
1064
    """Tests readv requests against a server erroring out on too much ranges."""
1073
1065
 
 
1066
    scenarios = multiply_scenarios(
 
1067
        vary_by_http_client_implementation(),
 
1068
        vary_by_http_protocol_version(),
 
1069
        )
 
1070
 
1074
1071
    # Requests with more range specifiers will error out
1075
1072
    range_limit = 3
1076
1073
 
1078
1075
        return LimitedRangeHTTPServer(range_limit=self.range_limit,
1079
1076
                                      protocol_version=self._protocol_version)
1080
1077
 
1081
 
    def get_transport(self):
1082
 
        return self._transport(self.get_readonly_server().get_url())
1083
 
 
1084
1078
    def setUp(self):
1085
1079
        http_utils.TestCaseWithWebserver.setUp(self)
1086
1080
        # We need to manipulate ranges that correspond to real chunks in the
1090
1084
        self.build_tree_contents([('a', content)],)
1091
1085
 
1092
1086
    def test_few_ranges(self):
1093
 
        t = self.get_transport()
 
1087
        t = self.get_readonly_transport()
1094
1088
        l = list(t.readv('a', ((0, 4), (1024, 4), )))
1095
1089
        self.assertEqual(l[0], (0, '0000'))
1096
1090
        self.assertEqual(l[1], (1024, '0001'))
1097
1091
        self.assertEqual(1, self.get_readonly_server().GET_request_nb)
1098
1092
 
1099
1093
    def test_more_ranges(self):
1100
 
        t = self.get_transport()
 
1094
        t = self.get_readonly_transport()
1101
1095
        l = list(t.readv('a', ((0, 4), (1024, 4), (4096, 4), (8192, 4))))
1102
1096
        self.assertEqual(l[0], (0, '0000'))
1103
1097
        self.assertEqual(l[1], (1024, '0001'))
1114
1108
    Only the urllib implementation is tested here.
1115
1109
    """
1116
1110
 
1117
 
    def setUp(self):
1118
 
        tests.TestCase.setUp(self)
1119
 
        self._old_env = {}
1120
 
 
1121
 
    def tearDown(self):
1122
 
        self._restore_env()
1123
 
        tests.TestCase.tearDown(self)
1124
 
 
1125
 
    def _install_env(self, env):
1126
 
        for name, value in env.iteritems():
1127
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1128
 
 
1129
 
    def _restore_env(self):
1130
 
        for name, value in self._old_env.iteritems():
1131
 
            osutils.set_or_unset_env(name, value)
1132
 
 
1133
1111
    def _proxied_request(self):
1134
1112
        handler = _urllib2_wrappers.ProxyHandler()
1135
 
        request = _urllib2_wrappers.Request('GET','http://baz/buzzle')
 
1113
        request = _urllib2_wrappers.Request('GET', 'http://baz/buzzle')
1136
1114
        handler.set_proxy(request, 'http')
1137
1115
        return request
1138
1116
 
 
1117
    def assertEvaluateProxyBypass(self, expected, host, no_proxy):
 
1118
        handler = _urllib2_wrappers.ProxyHandler()
 
1119
        self.assertEquals(expected,
 
1120
                          handler.evaluate_proxy_bypass(host, no_proxy))
 
1121
 
1139
1122
    def test_empty_user(self):
1140
 
        self._install_env({'http_proxy': 'http://bar.com'})
 
1123
        self.overrideEnv('http_proxy', 'http://bar.com')
 
1124
        request = self._proxied_request()
 
1125
        self.assertFalse(request.headers.has_key('Proxy-authorization'))
 
1126
 
 
1127
    def test_user_with_at(self):
 
1128
        self.overrideEnv('http_proxy',
 
1129
                         'http://username@domain:password@proxy_host:1234')
1141
1130
        request = self._proxied_request()
1142
1131
        self.assertFalse(request.headers.has_key('Proxy-authorization'))
1143
1132
 
1144
1133
    def test_invalid_proxy(self):
1145
1134
        """A proxy env variable without scheme"""
1146
 
        self._install_env({'http_proxy': 'host:1234'})
 
1135
        self.overrideEnv('http_proxy', 'host:1234')
1147
1136
        self.assertRaises(errors.InvalidURL, self._proxied_request)
1148
1137
 
 
1138
    def test_evaluate_proxy_bypass_true(self):
 
1139
        """The host is not proxied"""
 
1140
        self.assertEvaluateProxyBypass(True, 'example.com', 'example.com')
 
1141
        self.assertEvaluateProxyBypass(True, 'bzr.example.com', '*example.com')
 
1142
 
 
1143
    def test_evaluate_proxy_bypass_false(self):
 
1144
        """The host is proxied"""
 
1145
        self.assertEvaluateProxyBypass(False, 'bzr.example.com', None)
 
1146
 
 
1147
    def test_evaluate_proxy_bypass_unknown(self):
 
1148
        """The host is not explicitly proxied"""
 
1149
        self.assertEvaluateProxyBypass(None, 'example.com', 'not.example.com')
 
1150
        self.assertEvaluateProxyBypass(None, 'bzr.example.com', 'example.com')
 
1151
 
 
1152
    def test_evaluate_proxy_bypass_empty_entries(self):
 
1153
        """Ignore empty entries"""
 
1154
        self.assertEvaluateProxyBypass(None, 'example.com', '')
 
1155
        self.assertEvaluateProxyBypass(None, 'example.com', ',')
 
1156
        self.assertEvaluateProxyBypass(None, 'example.com', 'foo,,bar')
 
1157
 
1149
1158
 
1150
1159
class TestProxyHttpServer(http_utils.TestCaseWithTwoWebservers):
1151
1160
    """Tests proxy server.
1156
1165
    to the file names).
1157
1166
    """
1158
1167
 
 
1168
    scenarios = multiply_scenarios(
 
1169
        vary_by_http_client_implementation(),
 
1170
        vary_by_http_protocol_version(),
 
1171
        )
 
1172
 
1159
1173
    # FIXME: We don't have an https server available, so we don't
1160
 
    # test https connections.
 
1174
    # test https connections. --vila toolongago
1161
1175
 
1162
1176
    def setUp(self):
1163
1177
        super(TestProxyHttpServer, self).setUp()
 
1178
        self.transport_secondary_server = http_utils.ProxyServer
1164
1179
        self.build_tree_contents([('foo', 'contents of foo\n'),
1165
1180
                                  ('foo-proxied', 'proxied contents of foo\n')])
1166
1181
        # Let's setup some attributes for tests
1167
 
        self.server = self.get_readonly_server()
1168
 
        self.proxy_address = '%s:%d' % (self.server.host, self.server.port)
 
1182
        server = self.get_readonly_server()
 
1183
        self.server_host_port = '%s:%d' % (server.host, server.port)
1169
1184
        if self._testing_pycurl():
1170
1185
            # Oh my ! pycurl does not check for the port as part of
1171
1186
            # no_proxy :-( So we just test the host part
1172
 
            self.no_proxy_host = self.server.host
 
1187
            self.no_proxy_host = server.host
1173
1188
        else:
1174
 
            self.no_proxy_host = self.proxy_address
 
1189
            self.no_proxy_host = self.server_host_port
1175
1190
        # The secondary server is the proxy
1176
 
        self.proxy = self.get_secondary_server()
1177
 
        self.proxy_url = self.proxy.get_url()
1178
 
        self._old_env = {}
 
1191
        self.proxy_url = self.get_secondary_url()
1179
1192
 
1180
1193
    def _testing_pycurl(self):
1181
1194
        # TODO: This is duplicated for lots of the classes in this file
1182
1195
        return (features.pycurl.available()
1183
1196
                and self._transport == PyCurlTransport)
1184
1197
 
1185
 
    def create_transport_secondary_server(self):
1186
 
        """Creates an http server that will serve files with
1187
 
        '-proxied' appended to their names.
1188
 
        """
1189
 
        return http_utils.ProxyServer(protocol_version=self._protocol_version)
1190
 
 
1191
 
    def _install_env(self, env):
1192
 
        for name, value in env.iteritems():
1193
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1194
 
 
1195
 
    def _restore_env(self):
1196
 
        for name, value in self._old_env.iteritems():
1197
 
            osutils.set_or_unset_env(name, value)
1198
 
 
1199
 
    def proxied_in_env(self, env):
1200
 
        self._install_env(env)
1201
 
        url = self.server.get_url()
1202
 
        t = self._transport(url)
1203
 
        try:
1204
 
            self.assertEqual('proxied contents of foo\n', t.get('foo').read())
1205
 
        finally:
1206
 
            self._restore_env()
1207
 
 
1208
 
    def not_proxied_in_env(self, env):
1209
 
        self._install_env(env)
1210
 
        url = self.server.get_url()
1211
 
        t = self._transport(url)
1212
 
        try:
1213
 
            self.assertEqual('contents of foo\n', t.get('foo').read())
1214
 
        finally:
1215
 
            self._restore_env()
 
1198
    def assertProxied(self):
 
1199
        t = self.get_readonly_transport()
 
1200
        self.assertEqual('proxied contents of foo\n', t.get('foo').read())
 
1201
 
 
1202
    def assertNotProxied(self):
 
1203
        t = self.get_readonly_transport()
 
1204
        self.assertEqual('contents of foo\n', t.get('foo').read())
1216
1205
 
1217
1206
    def test_http_proxy(self):
1218
 
        self.proxied_in_env({'http_proxy': self.proxy_url})
 
1207
        self.overrideEnv('http_proxy', self.proxy_url)
 
1208
        self.assertProxied()
1219
1209
 
1220
1210
    def test_HTTP_PROXY(self):
1221
1211
        if self._testing_pycurl():
1224
1214
            # about. Should we ?)
1225
1215
            raise tests.TestNotApplicable(
1226
1216
                'pycurl does not check HTTP_PROXY for security reasons')
1227
 
        self.proxied_in_env({'HTTP_PROXY': self.proxy_url})
 
1217
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
 
1218
        self.assertProxied()
1228
1219
 
1229
1220
    def test_all_proxy(self):
1230
 
        self.proxied_in_env({'all_proxy': self.proxy_url})
 
1221
        self.overrideEnv('all_proxy', self.proxy_url)
 
1222
        self.assertProxied()
1231
1223
 
1232
1224
    def test_ALL_PROXY(self):
1233
 
        self.proxied_in_env({'ALL_PROXY': self.proxy_url})
 
1225
        self.overrideEnv('ALL_PROXY', self.proxy_url)
 
1226
        self.assertProxied()
1234
1227
 
1235
1228
    def test_http_proxy_with_no_proxy(self):
1236
 
        self.not_proxied_in_env({'http_proxy': self.proxy_url,
1237
 
                                 'no_proxy': self.no_proxy_host})
 
1229
        self.overrideEnv('no_proxy', self.no_proxy_host)
 
1230
        self.overrideEnv('http_proxy', self.proxy_url)
 
1231
        self.assertNotProxied()
1238
1232
 
1239
1233
    def test_HTTP_PROXY_with_NO_PROXY(self):
1240
1234
        if self._testing_pycurl():
1241
1235
            raise tests.TestNotApplicable(
1242
1236
                'pycurl does not check HTTP_PROXY for security reasons')
1243
 
        self.not_proxied_in_env({'HTTP_PROXY': self.proxy_url,
1244
 
                                 'NO_PROXY': self.no_proxy_host})
 
1237
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
 
1238
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
 
1239
        self.assertNotProxied()
1245
1240
 
1246
1241
    def test_all_proxy_with_no_proxy(self):
1247
 
        self.not_proxied_in_env({'all_proxy': self.proxy_url,
1248
 
                                 'no_proxy': self.no_proxy_host})
 
1242
        self.overrideEnv('no_proxy', self.no_proxy_host)
 
1243
        self.overrideEnv('all_proxy', self.proxy_url)
 
1244
        self.assertNotProxied()
1249
1245
 
1250
1246
    def test_ALL_PROXY_with_NO_PROXY(self):
1251
 
        self.not_proxied_in_env({'ALL_PROXY': self.proxy_url,
1252
 
                                 'NO_PROXY': self.no_proxy_host})
 
1247
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
 
1248
        self.overrideEnv('ALL_PROXY', self.proxy_url)
 
1249
        self.assertNotProxied()
1253
1250
 
1254
1251
    def test_http_proxy_without_scheme(self):
 
1252
        self.overrideEnv('http_proxy', self.server_host_port)
1255
1253
        if self._testing_pycurl():
1256
1254
            # pycurl *ignores* invalid proxy env variables. If that ever change
1257
1255
            # in the future, this test will fail indicating that pycurl do not
1258
1256
            # ignore anymore such variables.
1259
 
            self.not_proxied_in_env({'http_proxy': self.proxy_address})
 
1257
            self.assertNotProxied()
1260
1258
        else:
1261
 
            self.assertRaises(errors.InvalidURL,
1262
 
                              self.proxied_in_env,
1263
 
                              {'http_proxy': self.proxy_address})
 
1259
            self.assertRaises(errors.InvalidURL, self.assertProxied)
1264
1260
 
1265
1261
 
1266
1262
class TestRanges(http_utils.TestCaseWithWebserver):
1267
1263
    """Test the Range header in GET methods."""
1268
1264
 
 
1265
    scenarios = multiply_scenarios(
 
1266
        vary_by_http_client_implementation(),
 
1267
        vary_by_http_protocol_version(),
 
1268
        )
 
1269
 
1269
1270
    def setUp(self):
1270
1271
        http_utils.TestCaseWithWebserver.setUp(self)
1271
1272
        self.build_tree_contents([('a', '0123456789')],)
1272
 
        server = self.get_readonly_server()
1273
 
        self.transport = self._transport(server.get_url())
1274
1273
 
1275
1274
    def create_transport_readonly_server(self):
1276
1275
        return http_server.HttpServer(protocol_version=self._protocol_version)
1277
1276
 
1278
1277
    def _file_contents(self, relpath, ranges):
 
1278
        t = self.get_readonly_transport()
1279
1279
        offsets = [ (start, end - start + 1) for start, end in ranges]
1280
 
        coalesce = self.transport._coalesce_offsets
 
1280
        coalesce = t._coalesce_offsets
1281
1281
        coalesced = list(coalesce(offsets, limit=0, fudge_factor=0))
1282
 
        code, data = self.transport._get(relpath, coalesced)
 
1282
        code, data = t._get(relpath, coalesced)
1283
1283
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1284
1284
        for start, end in ranges:
1285
1285
            data.seek(start)
1286
1286
            yield data.read(end - start + 1)
1287
1287
 
1288
1288
    def _file_tail(self, relpath, tail_amount):
1289
 
        code, data = self.transport._get(relpath, [], tail_amount)
 
1289
        t = self.get_readonly_transport()
 
1290
        code, data = t._get(relpath, [], tail_amount)
1290
1291
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1291
1292
        data.seek(-tail_amount, 2)
1292
1293
        return data.read(tail_amount)
1311
1312
class TestHTTPRedirections(http_utils.TestCaseWithRedirectedWebserver):
1312
1313
    """Test redirection between http servers."""
1313
1314
 
1314
 
    def create_transport_secondary_server(self):
1315
 
        """Create the secondary server redirecting to the primary server"""
1316
 
        new = self.get_readonly_server()
1317
 
 
1318
 
        redirecting = http_utils.HTTPServerRedirecting(
1319
 
            protocol_version=self._protocol_version)
1320
 
        redirecting.redirect_to(new.host, new.port)
1321
 
        return redirecting
 
1315
    scenarios = multiply_scenarios(
 
1316
        vary_by_http_client_implementation(),
 
1317
        vary_by_http_protocol_version(),
 
1318
        )
1322
1319
 
1323
1320
    def setUp(self):
1324
1321
        super(TestHTTPRedirections, self).setUp()
1326
1323
                                  ('bundle',
1327
1324
                                  '# Bazaar revision bundle v0.9\n#\n')
1328
1325
                                  ],)
1329
 
        # The requests to the old server will be redirected to the new server
1330
 
        self.old_transport = self._transport(self.old_server.get_url())
1331
1326
 
1332
1327
    def test_redirected(self):
1333
 
        self.assertRaises(errors.RedirectRequested, self.old_transport.get, 'a')
1334
 
        t = self._transport(self.new_server.get_url())
1335
 
        self.assertEqual('0123456789', t.get('a').read())
1336
 
 
1337
 
    def test_read_redirected_bundle_from_url(self):
1338
 
        from bzrlib.bundle import read_bundle_from_url
1339
 
        url = self.old_transport.abspath('bundle')
1340
 
        bundle = self.applyDeprecated(deprecated_in((1, 12, 0)),
1341
 
                read_bundle_from_url, url)
1342
 
        # If read_bundle_from_url was successful we get an empty bundle
1343
 
        self.assertEqual([], bundle.revisions)
 
1328
        self.assertRaises(errors.RedirectRequested,
 
1329
                          self.get_old_transport().get, 'a')
 
1330
        self.assertEqual('0123456789', self.get_new_transport().get('a').read())
1344
1331
 
1345
1332
 
1346
1333
class RedirectedRequest(_urllib2_wrappers.Request):
1363
1350
    test.overrideAttr(_urllib2_wrappers, 'Request', RedirectedRequest)
1364
1351
 
1365
1352
 
 
1353
def cleanup_http_redirection_connections(test):
 
1354
    # Some sockets are opened but never seen by _urllib, so we trap them at
 
1355
    # the _urllib2_wrappers level to be able to clean them up.
 
1356
    def socket_disconnect(sock):
 
1357
        try:
 
1358
            sock.shutdown(socket.SHUT_RDWR)
 
1359
            sock.close()
 
1360
        except socket.error:
 
1361
            pass
 
1362
    def connect(connection):
 
1363
        test.http_connect_orig(connection)
 
1364
        test.addCleanup(socket_disconnect, connection.sock)
 
1365
    test.http_connect_orig = test.overrideAttr(
 
1366
        _urllib2_wrappers.HTTPConnection, 'connect', connect)
 
1367
    def connect(connection):
 
1368
        test.https_connect_orig(connection)
 
1369
        test.addCleanup(socket_disconnect, connection.sock)
 
1370
    test.https_connect_orig = test.overrideAttr(
 
1371
        _urllib2_wrappers.HTTPSConnection, 'connect', connect)
 
1372
 
 
1373
 
1366
1374
class TestHTTPSilentRedirections(http_utils.TestCaseWithRedirectedWebserver):
1367
1375
    """Test redirections.
1368
1376
 
1377
1385
    -- vila 20070212
1378
1386
    """
1379
1387
 
 
1388
    scenarios = multiply_scenarios(
 
1389
        vary_by_http_client_implementation(),
 
1390
        vary_by_http_protocol_version(),
 
1391
        )
 
1392
 
1380
1393
    def setUp(self):
1381
1394
        if (features.pycurl.available()
1382
1395
            and self._transport == PyCurlTransport):
1383
1396
            raise tests.TestNotApplicable(
1384
 
                "pycurl doesn't redirect silently annymore")
 
1397
                "pycurl doesn't redirect silently anymore")
1385
1398
        super(TestHTTPSilentRedirections, self).setUp()
1386
1399
        install_redirected_request(self)
 
1400
        cleanup_http_redirection_connections(self)
1387
1401
        self.build_tree_contents([('a','a'),
1388
1402
                                  ('1/',),
1389
1403
                                  ('1/a', 'redirected once'),
1397
1411
                                  ('5/a', 'redirected 5 times'),
1398
1412
                                  ],)
1399
1413
 
1400
 
        self.old_transport = self._transport(self.old_server.get_url())
1401
 
 
1402
 
    def create_transport_secondary_server(self):
1403
 
        """Create the secondary server, redirections are defined in the tests"""
1404
 
        return http_utils.HTTPServerRedirecting(
1405
 
            protocol_version=self._protocol_version)
1406
 
 
1407
1414
    def test_one_redirection(self):
1408
 
        t = self.old_transport
1409
 
 
1410
 
        req = RedirectedRequest('GET', t.abspath('a'))
 
1415
        t = self.get_old_transport()
 
1416
        req = RedirectedRequest('GET', t._remote_path('a'))
1411
1417
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1412
1418
                                       self.new_server.port)
1413
1419
        self.old_server.redirections = \
1414
1420
            [('(.*)', r'%s/1\1' % (new_prefix), 301),]
1415
 
        self.assertEqual('redirected once',t._perform(req).read())
 
1421
        self.assertEqual('redirected once', t._perform(req).read())
1416
1422
 
1417
1423
    def test_five_redirections(self):
1418
 
        t = self.old_transport
1419
 
 
1420
 
        req = RedirectedRequest('GET', t.abspath('a'))
 
1424
        t = self.get_old_transport()
 
1425
        req = RedirectedRequest('GET', t._remote_path('a'))
1421
1426
        old_prefix = 'http://%s:%s' % (self.old_server.host,
1422
1427
                                       self.old_server.port)
1423
1428
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1429
1434
            ('/4(.*)', r'%s/5\1' % (new_prefix), 301),
1430
1435
            ('(/[^/]+)', r'%s/1\1' % (old_prefix), 301),
1431
1436
            ]
1432
 
        self.assertEqual('redirected 5 times',t._perform(req).read())
 
1437
        self.assertEqual('redirected 5 times', t._perform(req).read())
1433
1438
 
1434
1439
 
1435
1440
class TestDoCatchRedirections(http_utils.TestCaseWithRedirectedWebserver):
1436
1441
    """Test transport.do_catching_redirections."""
1437
1442
 
 
1443
    scenarios = multiply_scenarios(
 
1444
        vary_by_http_client_implementation(),
 
1445
        vary_by_http_protocol_version(),
 
1446
        )
 
1447
 
1438
1448
    def setUp(self):
1439
1449
        super(TestDoCatchRedirections, self).setUp()
1440
1450
        self.build_tree_contents([('a', '0123456789'),],)
1441
 
 
1442
 
        self.old_transport = self._transport(self.old_server.get_url())
1443
 
 
1444
 
    def get_a(self, transport):
1445
 
        return transport.get('a')
 
1451
        cleanup_http_redirection_connections(self)
 
1452
 
 
1453
        self.old_transport = self.get_old_transport()
 
1454
 
 
1455
    def get_a(self, t):
 
1456
        return t.get('a')
1446
1457
 
1447
1458
    def test_no_redirection(self):
1448
 
        t = self._transport(self.new_server.get_url())
 
1459
        t = self.get_new_transport()
1449
1460
 
1450
1461
        # We use None for redirected so that we fail if redirected
1451
1462
        self.assertEqual('0123456789',
1455
1466
    def test_one_redirection(self):
1456
1467
        self.redirections = 0
1457
1468
 
1458
 
        def redirected(transport, exception, redirection_notice):
 
1469
        def redirected(t, exception, redirection_notice):
1459
1470
            self.redirections += 1
1460
 
            dir, file = urlutils.split(exception.target)
1461
 
            return self._transport(dir)
 
1471
            redirected_t = t._redirected_to(exception.source, exception.target)
 
1472
            return redirected_t
1462
1473
 
1463
1474
        self.assertEqual('0123456789',
1464
1475
                         transport.do_catching_redirections(
1481
1492
class TestAuth(http_utils.TestCaseWithWebserver):
1482
1493
    """Test authentication scheme"""
1483
1494
 
 
1495
    scenarios = multiply_scenarios(
 
1496
        vary_by_http_client_implementation(),
 
1497
        vary_by_http_protocol_version(),
 
1498
        vary_by_http_auth_scheme(),
 
1499
        )
 
1500
 
1484
1501
    _auth_header = 'Authorization'
1485
1502
    _password_prompt_prefix = ''
1486
1503
    _username_prompt_prefix = ''
1494
1511
                                  ('b', 'contents of b\n'),])
1495
1512
 
1496
1513
    def create_transport_readonly_server(self):
1497
 
        return self._auth_server(protocol_version=self._protocol_version)
 
1514
        server = self._auth_server(protocol_version=self._protocol_version)
 
1515
        server._url_protocol = self._url_protocol
 
1516
        return server
1498
1517
 
1499
1518
    def _testing_pycurl(self):
1500
1519
        # TODO: This is duplicated for lots of the classes in this file
1513
1532
        return url
1514
1533
 
1515
1534
    def get_user_transport(self, user, password):
1516
 
        return self._transport(self.get_user_url(user, password))
 
1535
        t = transport.get_transport(self.get_user_url(user, password))
 
1536
        return t
1517
1537
 
1518
1538
    def test_no_user(self):
1519
1539
        self.server.add_user('joe', 'foo')
1630
1650
        ui.ui_factory = tests.TestUIFactory(stdin=stdin_content,
1631
1651
                                            stderr=tests.StringIOWrapper())
1632
1652
        # Create a minimal config file with the right password
1633
 
        conf = config.AuthenticationConfig()
1634
 
        conf._get_config().update(
1635
 
            {'httptest': {'scheme': 'http', 'port': self.server.port,
1636
 
                          'user': user, 'password': password}})
1637
 
        conf._save()
 
1653
        _setup_authentication_config(
 
1654
            scheme='http', 
 
1655
            port=self.server.port,
 
1656
            user=user,
 
1657
            password=password)
1638
1658
        # Issue a request to the server to connect
1639
1659
        self.assertEqual('contents of a\n',t.get('a').read())
1640
1660
        # stdin should have  been left untouched
1642
1662
        # Only one 'Authentication Required' error should occur
1643
1663
        self.assertEqual(1, self.server.auth_required_errors)
1644
1664
 
1645
 
    def test_user_from_auth_conf(self):
1646
 
        if self._testing_pycurl():
1647
 
            raise tests.TestNotApplicable(
1648
 
                'pycurl does not support authentication.conf')
1649
 
        user = 'joe'
1650
 
        password = 'foo'
1651
 
        self.server.add_user(user, password)
1652
 
        # Create a minimal config file with the right password
1653
 
        conf = config.AuthenticationConfig()
1654
 
        conf._get_config().update(
1655
 
            {'httptest': {'scheme': 'http', 'port': self.server.port,
1656
 
                          'user': user, 'password': password}})
1657
 
        conf._save()
1658
 
        t = self.get_user_transport(None, None)
1659
 
        # Issue a request to the server to connect
1660
 
        self.assertEqual('contents of a\n', t.get('a').read())
1661
 
        # Only one 'Authentication Required' error should occur
1662
 
        self.assertEqual(1, self.server.auth_required_errors)
1663
 
 
1664
1665
    def test_changing_nonce(self):
1665
1666
        if self._auth_server not in (http_utils.HTTPDigestAuthServer,
1666
1667
                                     http_utils.ProxyDigestAuthServer):
1682
1683
        # initial 'who are you' and a second 'who are you' with the new nonce)
1683
1684
        self.assertEqual(2, self.server.auth_required_errors)
1684
1685
 
 
1686
    def test_user_from_auth_conf(self):
 
1687
        if self._testing_pycurl():
 
1688
            raise tests.TestNotApplicable(
 
1689
                'pycurl does not support authentication.conf')
 
1690
        user = 'joe'
 
1691
        password = 'foo'
 
1692
        self.server.add_user(user, password)
 
1693
        _setup_authentication_config(
 
1694
            scheme='http', 
 
1695
            port=self.server.port,
 
1696
            user=user,
 
1697
            password=password)
 
1698
        t = self.get_user_transport(None, None)
 
1699
        # Issue a request to the server to connect
 
1700
        self.assertEqual('contents of a\n', t.get('a').read())
 
1701
        # Only one 'Authentication Required' error should occur
 
1702
        self.assertEqual(1, self.server.auth_required_errors)
 
1703
 
 
1704
 
 
1705
def _setup_authentication_config(**kwargs):
 
1706
    conf = config.AuthenticationConfig()
 
1707
    conf._get_config().update({'httptest': kwargs})
 
1708
    conf._save()
 
1709
 
 
1710
 
 
1711
 
 
1712
class TestUrllib2AuthHandler(tests.TestCaseWithTransport):
 
1713
    """Unit tests for glue by which urllib2 asks us for authentication"""
 
1714
 
 
1715
    def test_get_user_password_without_port(self):
 
1716
        """We cope if urllib2 doesn't tell us the port.
 
1717
 
 
1718
        See https://bugs.launchpad.net/bzr/+bug/654684
 
1719
        """
 
1720
        user = 'joe'
 
1721
        password = 'foo'
 
1722
        _setup_authentication_config(
 
1723
            scheme='http', 
 
1724
            host='localhost',
 
1725
            user=user,
 
1726
            password=password)
 
1727
        handler = _urllib2_wrappers.HTTPAuthHandler()
 
1728
        got_pass = handler.get_user_password(dict(
 
1729
            user='joe',
 
1730
            protocol='http',
 
1731
            host='localhost',
 
1732
            path='/',
 
1733
            realm='Realm',
 
1734
            ))
 
1735
        self.assertEquals((user, password), got_pass)
1685
1736
 
1686
1737
 
1687
1738
class TestProxyAuth(TestAuth):
1688
1739
    """Test proxy authentication schemes."""
1689
1740
 
 
1741
    scenarios = multiply_scenarios(
 
1742
        vary_by_http_client_implementation(),
 
1743
        vary_by_http_protocol_version(),
 
1744
        vary_by_http_proxy_auth_scheme(),
 
1745
        )
 
1746
 
1690
1747
    _auth_header = 'Proxy-authorization'
1691
1748
    _password_prompt_prefix = 'Proxy '
1692
1749
    _username_prompt_prefix = 'Proxy '
1693
1750
 
1694
1751
    def setUp(self):
1695
1752
        super(TestProxyAuth, self).setUp()
1696
 
        self._old_env = {}
1697
 
        self.addCleanup(self._restore_env)
1698
1753
        # Override the contents to avoid false positives
1699
1754
        self.build_tree_contents([('a', 'not proxied contents of a\n'),
1700
1755
                                  ('b', 'not proxied contents of b\n'),
1703
1758
                                  ])
1704
1759
 
1705
1760
    def get_user_transport(self, user, password):
1706
 
        self._install_env({'all_proxy': self.get_user_url(user, password)})
1707
 
        return self._transport(self.server.get_url())
1708
 
 
1709
 
    def _install_env(self, env):
1710
 
        for name, value in env.iteritems():
1711
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1712
 
 
1713
 
    def _restore_env(self):
1714
 
        for name, value in self._old_env.iteritems():
1715
 
            osutils.set_or_unset_env(name, value)
 
1761
        self.overrideEnv('all_proxy', self.get_user_url(user, password))
 
1762
        return TestAuth.get_user_transport(self, user, password)
1716
1763
 
1717
1764
    def test_empty_pass(self):
1718
1765
        if self._testing_pycurl():
1737
1784
        self.readfile = StringIO(socket_read_content)
1738
1785
        self.writefile = StringIO()
1739
1786
        self.writefile.close = lambda: None
 
1787
        self.close = lambda: None
1740
1788
 
1741
1789
    def makefile(self, mode='r', bufsize=None):
1742
1790
        if 'r' in mode:
1747
1795
 
1748
1796
class SmartHTTPTunnellingTest(tests.TestCaseWithTransport):
1749
1797
 
 
1798
    scenarios = multiply_scenarios(
 
1799
        vary_by_http_client_implementation(),
 
1800
        vary_by_http_protocol_version(),
 
1801
        )
 
1802
 
1750
1803
    def setUp(self):
1751
1804
        super(SmartHTTPTunnellingTest, self).setUp()
1752
1805
        # We use the VFS layer as part of HTTP tunnelling tests.
1753
 
        self._captureVar('BZR_NO_SMART_VFS', None)
 
1806
        self.overrideEnv('BZR_NO_SMART_VFS', None)
1754
1807
        self.transport_readonly_server = http_utils.HTTPServerWithSmarts
 
1808
        self.http_server = self.get_readonly_server()
1755
1809
 
1756
1810
    def create_transport_readonly_server(self):
1757
 
        return http_utils.HTTPServerWithSmarts(
 
1811
        server = http_utils.HTTPServerWithSmarts(
1758
1812
            protocol_version=self._protocol_version)
 
1813
        server._url_protocol = self._url_protocol
 
1814
        return server
1759
1815
 
1760
1816
    def test_open_bzrdir(self):
1761
1817
        branch = self.make_branch('relpath')
1762
 
        http_server = self.get_readonly_server()
1763
 
        url = http_server.get_url() + 'relpath'
 
1818
        url = self.http_server.get_url() + 'relpath'
1764
1819
        bd = bzrdir.BzrDir.open(url)
 
1820
        self.addCleanup(bd.transport.disconnect)
1765
1821
        self.assertIsInstance(bd, _mod_remote.RemoteBzrDir)
1766
1822
 
1767
1823
    def test_bulk_data(self):
1769
1825
        # The 'readv' command in the smart protocol both sends and receives
1770
1826
        # bulk data, so we use that.
1771
1827
        self.build_tree(['data-file'])
1772
 
        http_server = self.get_readonly_server()
1773
 
        http_transport = self._transport(http_server.get_url())
 
1828
        http_transport = transport.get_transport(self.http_server.get_url())
1774
1829
        medium = http_transport.get_smart_medium()
1775
1830
        # Since we provide the medium, the url below will be mostly ignored
1776
1831
        # during the test, as long as the path is '/'.
1784
1839
        post_body = 'hello\n'
1785
1840
        expected_reply_body = 'ok\x012\n'
1786
1841
 
1787
 
        http_server = self.get_readonly_server()
1788
 
        http_transport = self._transport(http_server.get_url())
 
1842
        http_transport = transport.get_transport(self.http_server.get_url())
1789
1843
        medium = http_transport.get_smart_medium()
1790
1844
        response = medium.send_http_smart_request(post_body)
1791
1845
        reply_body = response.read()
1792
1846
        self.assertEqual(expected_reply_body, reply_body)
1793
1847
 
1794
1848
    def test_smart_http_server_post_request_handler(self):
1795
 
        httpd = self.get_readonly_server()._get_httpd()
 
1849
        httpd = self.http_server.server
1796
1850
 
1797
1851
        socket = SampleSocket(
1798
1852
            'POST /.bzr/smart %s \r\n' % self._protocol_version
1830
1884
 
1831
1885
    def test_probe_smart_server(self):
1832
1886
        """Test error handling against server refusing smart requests."""
1833
 
        server = self.get_readonly_server()
1834
 
        t = self._transport(server.get_url())
 
1887
        t = self.get_readonly_transport()
1835
1888
        # No need to build a valid smart request here, the server will not even
1836
1889
        # try to interpret it.
1837
1890
        self.assertRaises(errors.SmartProtocolError,
1838
1891
                          t.get_smart_medium().send_http_smart_request,
1839
1892
                          'whatever')
1840
1893
 
 
1894
 
1841
1895
class Test_redirected_to(tests.TestCase):
1842
1896
 
 
1897
    scenarios = vary_by_http_client_implementation()
 
1898
 
1843
1899
    def test_redirected_to_subdir(self):
1844
1900
        t = self._transport('http://www.example.com/foo')
1845
1901
        r = t._redirected_to('http://www.example.com/foo',
1896
1952
    line.
1897
1953
    """
1898
1954
 
1899
 
    def handle_one_request(self):
 
1955
    def _handle_one_request(self):
1900
1956
        tcs = self.server.test_case_server
1901
1957
        requestline = self.rfile.readline()
1902
1958
        headers = self.MessageClass(self.rfile, 0)
1966
2022
        # We override at class level because constructors may propagate the
1967
2023
        # bound method and render instance overriding ineffective (an
1968
2024
        # alternative would be to define a specific ui factory instead...)
1969
 
        self.orig_report_activity = self._transport._report_activity
1970
 
        self._transport._report_activity = report_activity
1971
 
 
1972
 
    def tearDown(self):
1973
 
        self._transport._report_activity = self.orig_report_activity
1974
 
        self.server.stop_server()
1975
 
        tests.TestCase.tearDown(self)
 
2025
        self.overrideAttr(self._transport, '_report_activity', report_activity)
 
2026
        self.addCleanup(self.server.stop_server)
1976
2027
 
1977
2028
    def get_transport(self):
1978
 
        return self._transport(self.server.get_url())
 
2029
        t = self._transport(self.server.get_url())
 
2030
        # FIXME: Needs cleanup -- vila 20100611
 
2031
        return t
1979
2032
 
1980
2033
    def assertActivitiesMatch(self):
1981
2034
        self.assertEqual(self.server.bytes_read,
2086
2139
'''
2087
2140
        t = self.get_transport()
2088
2141
        # We must send a single line of body bytes, see
2089
 
        # PredefinedRequestHandler.handle_one_request
 
2142
        # PredefinedRequestHandler._handle_one_request
2090
2143
        code, f = t._post('abc def end-of-body\n')
2091
2144
        self.assertEqual('lalala whatever as long as itsssss\n', f.read())
2092
2145
        self.assertActivitiesMatch()
2094
2147
 
2095
2148
class TestActivity(tests.TestCase, TestActivityMixin):
2096
2149
 
 
2150
    scenarios = multiply_scenarios(
 
2151
        vary_by_http_activity(),
 
2152
        vary_by_http_protocol_version(),
 
2153
        )
 
2154
 
2097
2155
    def setUp(self):
2098
 
        tests.TestCase.setUp(self)
2099
 
        self.server = self._activity_server(self._protocol_version)
2100
 
        self.server.start_server()
2101
 
        self.activities = {}
2102
 
        def report_activity(t, bytes, direction):
2103
 
            count = self.activities.get(direction, 0)
2104
 
            count += bytes
2105
 
            self.activities[direction] = count
2106
 
 
2107
 
        # We override at class level because constructors may propagate the
2108
 
        # bound method and render instance overriding ineffective (an
2109
 
        # alternative would be to define a specific ui factory instead...)
2110
 
        self.orig_report_activity = self._transport._report_activity
2111
 
        self._transport._report_activity = report_activity
2112
 
 
2113
 
    def tearDown(self):
2114
 
        self._transport._report_activity = self.orig_report_activity
2115
 
        self.server.stop_server()
2116
 
        tests.TestCase.tearDown(self)
 
2156
        TestActivityMixin.setUp(self)
2117
2157
 
2118
2158
 
2119
2159
class TestNoReportActivity(tests.TestCase, TestActivityMixin):
2120
2160
 
 
2161
    # Unlike TestActivity, we are really testing ReportingFileSocket and
 
2162
    # ReportingSocket, so we don't need all the parametrization. Since
 
2163
    # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
 
2164
    # test them through their use by the transport than directly (that's a
 
2165
    # bit less clean but far more simpler and effective).
 
2166
    _activity_server = ActivityHTTPServer
 
2167
    _protocol_version = 'HTTP/1.1'
 
2168
 
2121
2169
    def setUp(self):
2122
 
        tests.TestCase.setUp(self)
2123
 
        # Unlike TestActivity, we are really testing ReportingFileSocket and
2124
 
        # ReportingSocket, so we don't need all the parametrization. Since
2125
 
        # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
2126
 
        # test them through their use by the transport than directly (that's a
2127
 
        # bit less clean but far more simpler and effective).
2128
 
        self.server = ActivityHTTPServer('HTTP/1.1')
2129
 
        self._transport=_urllib.HttpTransport_urllib
2130
 
 
2131
 
        self.server.start_server()
2132
 
 
2133
 
        # We override at class level because constructors may propagate the
2134
 
        # bound method and render instance overriding ineffective (an
2135
 
        # alternative would be to define a specific ui factory instead...)
2136
 
        self.orig_report_activity = self._transport._report_activity
2137
 
        self._transport._report_activity = None
2138
 
 
2139
 
    def tearDown(self):
2140
 
        self._transport._report_activity = self.orig_report_activity
2141
 
        self.server.stop_server()
2142
 
        tests.TestCase.tearDown(self)
 
2170
        self._transport =_urllib.HttpTransport_urllib
 
2171
        TestActivityMixin.setUp(self)
2143
2172
 
2144
2173
    def assertActivitiesMatch(self):
2145
2174
        # Nothing to check here
2149
2178
class TestAuthOnRedirected(http_utils.TestCaseWithRedirectedWebserver):
2150
2179
    """Test authentication on the redirected http server."""
2151
2180
 
 
2181
    scenarios = vary_by_http_protocol_version()
 
2182
 
2152
2183
    _auth_header = 'Authorization'
2153
2184
    _password_prompt_prefix = ''
2154
2185
    _username_prompt_prefix = ''
2155
2186
    _auth_server = http_utils.HTTPBasicAuthServer
2156
2187
    _transport = _urllib.HttpTransport_urllib
2157
2188
 
2158
 
    def create_transport_readonly_server(self):
2159
 
        return self._auth_server()
2160
 
 
2161
 
    def create_transport_secondary_server(self):
2162
 
        """Create the secondary server redirecting to the primary server"""
2163
 
        new = self.get_readonly_server()
2164
 
 
2165
 
        redirecting = http_utils.HTTPServerRedirecting()
2166
 
        redirecting.redirect_to(new.host, new.port)
2167
 
        return redirecting
2168
 
 
2169
2189
    def setUp(self):
2170
2190
        super(TestAuthOnRedirected, self).setUp()
2171
2191
        self.build_tree_contents([('a','a'),
2176
2196
                                       self.new_server.port)
2177
2197
        self.old_server.redirections = [
2178
2198
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2179
 
        self.old_transport = self._transport(self.old_server.get_url())
 
2199
        self.old_transport = self.get_old_transport()
2180
2200
        self.new_server.add_user('joe', 'foo')
2181
 
 
2182
 
    def get_a(self, transport):
2183
 
        return transport.get('a')
 
2201
        cleanup_http_redirection_connections(self)
 
2202
 
 
2203
    def create_transport_readonly_server(self):
 
2204
        server = self._auth_server(protocol_version=self._protocol_version)
 
2205
        server._url_protocol = self._url_protocol
 
2206
        return server
 
2207
 
 
2208
    def get_a(self, t):
 
2209
        return t.get('a')
2184
2210
 
2185
2211
    def test_auth_on_redirected_via_do_catching_redirections(self):
2186
2212
        self.redirections = 0
2187
2213
 
2188
 
        def redirected(transport, exception, redirection_notice):
 
2214
        def redirected(t, exception, redirection_notice):
2189
2215
            self.redirections += 1
2190
 
            dir, file = urlutils.split(exception.target)
2191
 
            return self._transport(dir)
 
2216
            redirected_t = t._redirected_to(exception.source, exception.target)
 
2217
            self.addCleanup(redirected_t.disconnect)
 
2218
            return redirected_t
2192
2219
 
2193
2220
        stdout = tests.StringIOWrapper()
2194
2221
        stderr = tests.StringIOWrapper()
2215
2242
                                       self.new_server.port)
2216
2243
        self.old_server.redirections = [
2217
2244
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2218
 
        self.assertEqual('redirected once',t._perform(req).read())
 
2245
        self.assertEqual('redirected once', t._perform(req).read())
2219
2246
        # stdin should be empty
2220
2247
        self.assertEqual('', ui.ui_factory.stdin.readline())
2221
2248
        # stdout should be empty, stderr will contains the prompts