13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
18
18
"""Tests for the commit CLI of bzr."""
24
24
from bzrlib import (
29
32
from bzrlib.bzrdir import BzrDir
30
33
from bzrlib.tests import (
31
34
probe_bad_non_ascii,
36
UnicodeFilenameFeature,
34
from bzrlib.tests.blackbox import ExternalBase
37
class TestCommit(ExternalBase):
38
from bzrlib.tests import TestCaseWithTransport
41
class TestCommit(TestCaseWithTransport):
39
43
def test_05_empty_commit(self):
40
44
"""Commit of tree with no versioned files should fail"""
43
47
self.build_tree(['hello.txt'])
44
48
out,err = self.run_bzr('commit -m empty', retcode=3)
45
49
self.assertEqual('', out)
46
self.assertContainsRe(err, 'bzr: ERROR: no changes to commit\.'
47
' use --unchanged to commit anyhow\n')
50
self.assertContainsRe(err, 'bzr: ERROR: No changes to commit\.'
51
' Use --unchanged to commit anyhow.\n')
49
53
def test_commit_success(self):
50
54
"""Successful commit should not leave behind a bzr-commit-* file"""
102
106
self.build_tree_contents([('hello.txt', 'new contents')])
103
107
out, err = self.run_bzr('commit -m modified')
104
108
self.assertEqual('', out)
105
self.assertContainsRe(err, '^Committing revision 2 to ".*"\.\n'
109
self.assertContainsRe(err, '^Committing to: .*\n'
106
110
'modified hello\.txt\n'
107
111
'Committed revision 2\.\n$')
113
def test_unicode_commit_message_is_filename(self):
114
"""Unicode commit message same as a filename (Bug #563646).
116
self.requireFeature(UnicodeFilenameFeature)
117
file_name = u'\N{euro sign}'
118
self.run_bzr(['init'])
119
open(file_name, 'w').write('hello world')
120
self.run_bzr(['add'])
121
out, err = self.run_bzr(['commit', '-m', file_name])
122
reflags = re.MULTILINE|re.DOTALL|re.UNICODE
123
te = osutils.get_terminal_encoding()
124
self.assertContainsRe(err.decode(te),
125
u'The commit message is a file name:',
128
# Run same test with a filename that causes encode
129
# error for the terminal encoding. We do this
130
# by forcing terminal encoding of ascii for
131
# osutils.get_terminal_encoding which is used
132
# by ui.text.show_warning
133
default_get_terminal_enc = osutils.get_terminal_encoding
135
osutils.get_terminal_encoding = lambda trace=None: 'ascii'
136
file_name = u'foo\u1234'
137
open(file_name, 'w').write('hello world')
138
self.run_bzr(['add'])
139
out, err = self.run_bzr(['commit', '-m', file_name])
140
reflags = re.MULTILINE|re.DOTALL|re.UNICODE
141
te = osutils.get_terminal_encoding()
142
self.assertContainsRe(err.decode(te, 'replace'),
143
u'The commit message is a file name:',
146
osutils.get_terminal_encoding = default_get_terminal_enc
148
def test_warn_about_forgotten_commit_message(self):
149
"""Test that the lack of -m parameter is caught"""
150
wt = self.make_branch_and_tree('.')
151
self.build_tree(['one', 'two'])
153
out, err = self.run_bzr('commit -m one two')
154
self.assertContainsRe(err, "The commit message is a file name")
109
156
def test_verbose_commit_renamed(self):
110
157
# Verbose commit of renamed file should say so
111
158
wt = self.prepare_simple_history()
112
159
wt.rename_one('hello.txt', 'gutentag.txt')
113
160
out, err = self.run_bzr('commit -m renamed')
114
161
self.assertEqual('', out)
115
self.assertContainsRe(err, '^Committing revision 2 to ".*"\.\n'
162
self.assertContainsRe(err, '^Committing to: .*\n'
116
163
'renamed hello\.txt => gutentag\.txt\n'
117
164
'Committed revision 2\.$\n')
124
171
wt.rename_one('hello.txt', 'subdir/hello.txt')
125
172
out, err = self.run_bzr('commit -m renamed')
126
173
self.assertEqual('', out)
127
self.assertContainsRe(err, '^Committing revision 2 to ".*"\.\n'
129
'renamed hello\.txt => subdir/hello\.txt\n'
130
'Committed revision 2\.\n$')
174
self.assertEqual(set([
175
'Committing to: %s/' % osutils.getcwd(),
177
'renamed hello.txt => subdir/hello.txt',
178
'Committed revision 2.',
180
]), set(err.split('\n')))
132
182
def test_verbose_commit_with_unknown(self):
133
183
"""Unknown files should not be listed by default in verbose output"""
164
214
b_tree = a_tree.branch.create_checkout('b')
165
215
expected = "%s/" % (osutils.abspath('a'), )
166
216
out, err = self.run_bzr('commit -m blah --unchanged', working_dir='b')
167
self.assertEqual(err, 'Committing revision 2 to "%s".\n'
217
self.assertEqual(err, 'Committing to: %s\n'
168
218
'Committed revision 2.\n' % expected)
220
def test_commit_sanitizes_CR_in_message(self):
221
# See bug #433779, basically Emacs likes to pass '\r\n' style line
222
# endings to 'bzr commit -m ""' which breaks because we don't allow
223
# '\r' in commit messages. (Mostly because of issues where XML style
224
# formats arbitrarily strip it out of the data while parsing.)
225
# To make life easier for users, we just always translate '\r\n' =>
226
# '\n'. And '\r' => '\n'.
227
a_tree = self.make_branch_and_tree('a')
228
self.build_tree(['a/b'])
230
self.run_bzr(['commit',
231
'-m', 'a string\r\n\r\nwith mixed\r\rendings\n'],
233
rev_id = a_tree.branch.last_revision()
234
rev = a_tree.branch.repository.get_revision(rev_id)
235
self.assertEqualDiff('a string\n\nwith mixed\n\nendings\n',
170
238
def test_commit_merge_reports_all_modified_files(self):
171
239
# the commit command should show all the files that are shown by
172
240
# bzr diff or bzr status when committing, even when they were not
221
289
out,err = self.run_bzr('commit -m added')
222
290
self.assertEqual('', out)
223
expected = '%s/' % (osutils.getcwd(), )
224
self.assertEqualDiff(
225
'Committing revision 2 to "%s".\n'
226
'modified filetomodify\n'
229
'renamed dirtorename => renameddir\n'
230
'renamed filetorename => renamedfile\n'
231
'renamed dirtoreparent => renameddir/reparenteddir\n'
232
'renamed filetoreparent => renameddir/reparentedfile\n'
233
'deleted dirtoremove\n'
234
'deleted filetoremove\n'
235
'Committed revision 2.\n' % (expected, ),
291
self.assertEqual(set([
292
'Committing to: %s/' % osutils.getcwd(),
293
'modified filetomodify',
296
'renamed dirtorename => renameddir',
297
'renamed filetorename => renamedfile',
298
'renamed dirtoreparent => renameddir/reparenteddir',
299
'renamed filetoreparent => renameddir/reparentedfile',
300
'deleted dirtoremove',
301
'deleted filetoremove',
302
'Committed revision 2.',
304
]), set(err.split('\n')))
238
306
def test_empty_commit_message(self):
239
307
tree = self.make_branch_and_tree('.')
242
310
self.run_bzr('commit -m ""', retcode=3)
244
312
def test_unsupported_encoding_commit_message(self):
313
if sys.platform == 'win32':
314
raise tests.TestNotApplicable('Win32 parses arguments directly'
315
' as Unicode, so we can\'t pass invalid non-ascii')
245
316
tree = self.make_branch_and_tree('.')
246
317
self.build_tree_contents([('foo.c', 'int main() {}')])
247
318
tree.add('foo.c')
248
319
# LANG env variable has no effect on Windows
249
320
# but some characters anyway cannot be represented
250
321
# in default user encoding
251
char = probe_bad_non_ascii(bzrlib.user_encoding)
322
char = probe_bad_non_ascii(osutils.get_user_encoding())
253
324
raise TestSkipped('Cannot find suitable non-ascii character'
254
'for user_encoding (%s)' % bzrlib.user_encoding)
325
'for user_encoding (%s)' % osutils.get_user_encoding())
255
326
out,err = self.run_bzr_subprocess('commit -m "%s"' % char,
257
328
env_changes={'LANG': 'C'})
266
337
self.build_tree_contents([
267
338
('branch/foo.c', 'int main() {}'),
268
339
('branch/bar.c', 'int main() {}')])
269
inner_tree.add('foo.c')
270
inner_tree.add('bar.c')
340
inner_tree.add(['foo.c', 'bar.c'])
271
341
# can't commit files in different trees; sane error
272
342
self.run_bzr('commit -m newstuff branch/foo.c .', retcode=3)
343
# can commit to branch - records foo.c only
273
344
self.run_bzr('commit -m newstuff branch/foo.c')
345
# can commit to branch - records bar.c
274
346
self.run_bzr('commit -m newstuff branch')
275
self.run_bzr('commit -m newstuff branch', retcode=3)
348
self.run_bzr_error(["No changes to commit"], 'commit -m newstuff branch')
277
350
def test_out_of_date_tree_commit(self):
278
351
# check we get an error code and a clear message committing with an out
302
375
def test_commit_a_text_merge_in_a_checkout(self):
303
376
# checkouts perform multiple actions in a transaction across bond
304
377
# branches and their master, and have been observed to fail in the
305
# past. This is a user story reported to fail in bug #43959 where
378
# past. This is a user story reported to fail in bug #43959 where
306
379
# a merge done in a checkout (using the update command) failed to
307
380
# commit correctly.
308
381
trunk = self.make_branch_and_tree('trunk')
310
383
u1 = trunk.branch.create_checkout('u1')
311
self.build_tree_contents([('u1/hosts', 'initial contents')])
384
self.build_tree_contents([('u1/hosts', 'initial contents\n')])
313
386
self.run_bzr('commit -m add-hosts u1')
315
388
u2 = trunk.branch.create_checkout('u2')
316
self.build_tree_contents([('u2/hosts', 'altered in u2')])
389
self.build_tree_contents([('u2/hosts', 'altered in u2\n')])
317
390
self.run_bzr('commit -m checkin-from-u2 u2')
319
392
# make an offline commits
320
self.build_tree_contents([('u1/hosts', 'first offline change in u1')])
393
self.build_tree_contents([('u1/hosts', 'first offline change in u1\n')])
321
394
self.run_bzr('commit -m checkin-offline --local u1')
323
396
# now try to pull in online work from u2, and then commit our offline
324
397
# work as a merge
325
398
# retcode 1 as we expect a text conflict
326
399
self.run_bzr('update u1', retcode=1)
400
self.assertFileEqual('''\
402
first offline change in u1
327
409
self.run_bzr('resolved u1/hosts')
328
410
# add a text change here to represent resolving the merge conflicts in
329
411
# favour of a new version of the file not identical to either the u1
331
413
self.build_tree_contents([('u1/hosts', 'merge resolution\n')])
332
414
self.run_bzr('commit -m checkin-merge-of-the-offline-work-from-u1 u1')
416
def test_commit_exclude_excludes_modified_files(self):
417
"""Commit -x foo should ignore changes to foo."""
418
tree = self.make_branch_and_tree('.')
419
self.build_tree(['a', 'b', 'c'])
420
tree.smart_add(['.'])
421
out, err = self.run_bzr(['commit', '-m', 'test', '-x', 'b'])
422
self.assertFalse('added b' in out)
423
self.assertFalse('added b' in err)
424
# If b was excluded it will still be 'added' in status.
425
out, err = self.run_bzr(['added'])
426
self.assertEqual('b\n', out)
427
self.assertEqual('', err)
429
def test_commit_exclude_twice_uses_both_rules(self):
430
"""Commit -x foo -x bar should ignore changes to foo and bar."""
431
tree = self.make_branch_and_tree('.')
432
self.build_tree(['a', 'b', 'c'])
433
tree.smart_add(['.'])
434
out, err = self.run_bzr(['commit', '-m', 'test', '-x', 'b', '-x', 'c'])
435
self.assertFalse('added b' in out)
436
self.assertFalse('added c' in out)
437
self.assertFalse('added b' in err)
438
self.assertFalse('added c' in err)
439
# If b was excluded it will still be 'added' in status.
440
out, err = self.run_bzr(['added'])
441
self.assertTrue('b\n' in out)
442
self.assertTrue('c\n' in out)
443
self.assertEqual('', err)
334
445
def test_commit_respects_spec_for_removals(self):
335
446
"""Commit with a file spec should only commit removals that match"""
336
447
t = self.make_branch_and_tree('.')
520
634
tree = self.make_branch_and_tree('tree')
521
635
self.build_tree(['tree/hello.txt'])
522
636
tree.add('hello.txt')
523
self.run_bzr("commit -m hello --author='John Doe <jdoe@example.com>' "
637
self.run_bzr(["commit", '-m', 'hello',
638
'--author', u'John D\xf6 <jdoe@example.com>',
525
640
last_rev = tree.branch.repository.get_revision(tree.last_revision())
526
641
properties = last_rev.properties
527
self.assertEqual('John Doe <jdoe@example.com>', properties['author'])
642
self.assertEqual(u'John D\xf6 <jdoe@example.com>', properties['authors'])
529
644
def test_author_no_email(self):
530
645
"""Author's name without an email address is allowed, too."""
535
650
"tree/hello.txt")
536
651
last_rev = tree.branch.repository.get_revision(tree.last_revision())
537
652
properties = last_rev.properties
538
self.assertEqual('John Doe', properties['author'])
653
self.assertEqual('John Doe', properties['authors'])
655
def test_multiple_authors(self):
656
"""Multiple authors can be specyfied, and all are stored."""
657
tree = self.make_branch_and_tree('tree')
658
self.build_tree(['tree/hello.txt'])
659
tree.add('hello.txt')
660
out, err = self.run_bzr("commit -m hello --author='John Doe' "
661
"--author='Jane Rey' tree/hello.txt")
662
last_rev = tree.branch.repository.get_revision(tree.last_revision())
663
properties = last_rev.properties
664
self.assertEqual('John Doe\nJane Rey', properties['authors'])
666
def test_commit_time(self):
667
tree = self.make_branch_and_tree('tree')
668
self.build_tree(['tree/hello.txt'])
669
tree.add('hello.txt')
670
out, err = self.run_bzr("commit -m hello "
671
"--commit-time='2009-10-10 08:00:00 +0100' tree/hello.txt")
672
last_rev = tree.branch.repository.get_revision(tree.last_revision())
674
'Sat 2009-10-10 08:00:00 +0100',
675
osutils.format_date(last_rev.timestamp, last_rev.timezone))
677
def test_commit_time_bad_time(self):
678
tree = self.make_branch_and_tree('tree')
679
self.build_tree(['tree/hello.txt'])
680
tree.add('hello.txt')
681
out, err = self.run_bzr("commit -m hello "
682
"--commit-time='NOT A TIME' tree/hello.txt", retcode=3)
683
self.assertStartsWith(
684
err, "bzr: ERROR: Could not parse --commit-time:")
540
686
def test_partial_commit_with_renames_in_tree(self):
541
687
# this test illustrates bug #140419
567
713
self.assertContainsRe(err,
568
714
r'^bzr: ERROR: Cannot lock.*readonly transport')
716
def setup_editor(self):
717
# Test that commit template hooks work
718
if sys.platform == "win32":
719
f = file('fed.bat', 'w')
720
f.write('@rem dummy fed')
722
osutils.set_or_unset_env('BZR_EDITOR', "fed.bat")
724
f = file('fed.sh', 'wb')
725
f.write('#!/bin/sh\n')
727
os.chmod('fed.sh', 0755)
728
osutils.set_or_unset_env('BZR_EDITOR', "./fed.sh")
730
def setup_commit_with_template(self):
732
msgeditor.hooks.install_named_hook("commit_message_template",
733
lambda commit_obj, msg: "save me some typing\n", None)
734
tree = self.make_branch_and_tree('tree')
735
self.build_tree(['tree/hello.txt'])
736
tree.add('hello.txt')
739
def test_commit_hook_template_accepted(self):
740
tree = self.setup_commit_with_template()
741
out, err = self.run_bzr("commit tree/hello.txt", stdin="y\n")
742
last_rev = tree.branch.repository.get_revision(tree.last_revision())
743
self.assertEqual('save me some typing\n', last_rev.message)
745
def test_commit_hook_template_rejected(self):
746
tree = self.setup_commit_with_template()
747
expected = tree.last_revision()
748
out, err = self.run_bzr_error(["empty commit message"],
749
"commit tree/hello.txt", stdin="n\n")
750
self.assertEqual(expected, tree.last_revision())
752
def test_commit_without_username(self):
753
"""Ensure commit error if username is not set.
755
self.run_bzr(['init', 'foo'])
757
open('foo.txt', 'w').write('hello')
758
self.run_bzr(['add'])
759
osutils.set_or_unset_env('EMAIL', None)
760
osutils.set_or_unset_env('BZR_EMAIL', None)
761
out, err = self.run_bzr(['commit', '-m', 'initial'], 3)
762
self.assertContainsRe(err, 'Unable to determine your name')
764
def test_commit_recursive_checkout(self):
765
"""Ensure that a commit to a recursive checkout fails cleanly.
767
self.run_bzr(['init', 'test_branch'])
768
self.run_bzr(['checkout', 'test_branch', 'test_checkout'])
769
os.chdir('test_checkout')
770
self.run_bzr(['bind', '.']) # bind to self
771
open('foo.txt', 'w').write('hello')
772
self.run_bzr(['add'])
773
out, err = self.run_bzr(['commit', '-m', 'addedfoo'], 3)
774
self.assertEqual(out, '')
775
self.assertContainsRe(err,
776
'Branch.*test_checkout.*appears to be bound to itself')
added
removed
bzrlib/tests/blackbox/test_commit.py
