← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/workingtree.py

  • Committer: Canonical.com Patch Queue Manager
  • Date: 2010-09-01 08:02:42 UTC
  • mfrom: (5390.3.3 faster-revert-593560)
  • Revision ID: pqm@pqm.ubuntu.com-20100901080242-esg62ody4frwmy66
(spiv) Avoid repeatedly calling self.target.all_file_ids() in
 InterTree.iter_changes. (Andrew Bennetts)

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/workingtree.py
1
 
# Copyright (C) 2005, 2006, 2007, 2008, 2009 Canonical Ltd
 
1
# Copyright (C) 2005-2010 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
29
29
WorkingTree.open(dir).
30
30
"""
31
31
 
32
 
# TODO: Give the workingtree sole responsibility for the working inventory;
33
 
# remove the variable and references to it from the branch.  This may require
34
 
# updating the commit code so as to update the inventory within the working
35
 
# copy, and making sure there's only one WorkingTree for any directory on disk.
36
 
# At the moment they may alias the inventory and have old copies of it in
37
 
# memory.  (Now done? -- mbp 20060309)
38
32
 
39
33
from cStringIO import StringIO
40
34
import os
55
49
    branch,
56
50
    bzrdir,
57
51
    conflicts as _mod_conflicts,
 
52
    controldir,
58
53
    errors,
59
54
    generate_ids,
60
55
    globbing,
65
60
    merge,
66
61
    revision as _mod_revision,
67
62
    revisiontree,
68
 
    textui,
69
63
    trace,
70
64
    transform,
 
65
    transport,
71
66
    ui,
72
67
    views,
73
68
    xml5,
74
69
    xml7,
75
70
    )
76
 
import bzrlib.branch
77
 
from bzrlib.transport import get_transport
78
71
from bzrlib.workingtree_4 import (
79
72
    WorkingTreeFormat4,
80
73
    WorkingTreeFormat5,
84
77
 
85
78
from bzrlib import symbol_versioning
86
79
from bzrlib.decorators import needs_read_lock, needs_write_lock
 
80
from bzrlib.lock import LogicalLockResult
87
81
from bzrlib.lockable_files import LockableFiles
88
82
from bzrlib.lockdir import LockDir
89
83
import bzrlib.mutabletree
102
96
from bzrlib.filters import filtered_input_file
103
97
from bzrlib.trace import mutter, note
104
98
from bzrlib.transport.local import LocalTransport
105
 
from bzrlib.progress import DummyProgress, ProgressPhase
106
99
from bzrlib.revision import CURRENT_REVISION
107
100
from bzrlib.rio import RioReader, rio_file, Stanza
108
101
from bzrlib.symbol_versioning import (
112
105
 
113
106
 
114
107
MERGE_MODIFIED_HEADER_1 = "BZR merge-modified list format 1"
 
108
# TODO: Modifying the conflict objects or their type is currently nearly
 
109
# impossible as there is no clear relationship between the working tree format
 
110
# and the conflict list file format.
115
111
CONFLICT_HEADER_1 = "BZR conflict list format 1"
116
112
 
117
113
ERROR_PATH_NOT_FOUND = 3    # WindowsError errno code, equivalent to ENOENT
172
168
        return ''
173
169
 
174
170
 
175
 
class WorkingTree(bzrlib.mutabletree.MutableTree):
 
171
class WorkingTree(bzrlib.mutabletree.MutableTree,
 
172
    controldir.ControlComponent):
176
173
    """Working copy tree.
177
174
 
178
175
    The inventory is held in the `Branch` working-inventory, and the
180
177
 
181
178
    It is possible for a `WorkingTree` to have a filename which is
182
179
    not listed in the Inventory and vice versa.
 
180
 
 
181
    :ivar basedir: The root of the tree on disk. This is a unicode path object
 
182
        (as opposed to a URL).
183
183
    """
184
184
 
185
185
    # override this to set the strategy for storing views
251
251
        self._rules_searcher = None
252
252
        self.views = self._make_views()
253
253
 
 
254
    @property
 
255
    def user_transport(self):
 
256
        return self.bzrdir.user_transport
 
257
 
 
258
    @property
 
259
    def control_transport(self):
 
260
        return self._transport
 
261
 
254
262
    def _detect_case_handling(self):
255
263
        wt_trans = self.bzrdir.get_workingtree_transport(None)
256
264
        try:
342
350
        if path is None:
343
351
            path = osutils.getcwd()
344
352
        control, relpath = bzrdir.BzrDir.open_containing(path)
345
 
 
346
353
        return control.open_workingtree(), relpath
347
354
 
348
355
    @staticmethod
 
356
    def open_containing_paths(file_list, default_directory='.',
 
357
        canonicalize=True, apply_view=True):
 
358
        """Open the WorkingTree that contains a set of paths.
 
359
 
 
360
        Fail if the paths given are not all in a single tree.
 
361
 
 
362
        This is used for the many command-line interfaces that take a list of
 
363
        any number of files and that require they all be in the same tree.
 
364
        """
 
365
        # recommended replacement for builtins.internal_tree_files
 
366
        if file_list is None or len(file_list) == 0:
 
367
            tree = WorkingTree.open_containing(default_directory)[0]
 
368
            # XXX: doesn't really belong here, and seems to have the strange
 
369
            # side effect of making it return a bunch of files, not the whole
 
370
            # tree -- mbp 20100716
 
371
            if tree.supports_views() and apply_view:
 
372
                view_files = tree.views.lookup_view()
 
373
                if view_files:
 
374
                    file_list = view_files
 
375
                    view_str = views.view_display_str(view_files)
 
376
                    note("Ignoring files outside view. View is %s" % view_str)
 
377
            return tree, file_list
 
378
        tree = WorkingTree.open_containing(file_list[0])[0]
 
379
        return tree, tree.safe_relpath_files(file_list, canonicalize,
 
380
            apply_view=apply_view)
 
381
 
 
382
    def safe_relpath_files(self, file_list, canonicalize=True, apply_view=True):
 
383
        """Convert file_list into a list of relpaths in tree.
 
384
 
 
385
        :param self: A tree to operate on.
 
386
        :param file_list: A list of user provided paths or None.
 
387
        :param apply_view: if True and a view is set, apply it or check that
 
388
            specified files are within it
 
389
        :return: A list of relative paths.
 
390
        :raises errors.PathNotChild: When a provided path is in a different self
 
391
            than self.
 
392
        """
 
393
        if file_list is None:
 
394
            return None
 
395
        if self.supports_views() and apply_view:
 
396
            view_files = self.views.lookup_view()
 
397
        else:
 
398
            view_files = []
 
399
        new_list = []
 
400
        # self.relpath exists as a "thunk" to osutils, but canonical_relpath
 
401
        # doesn't - fix that up here before we enter the loop.
 
402
        if canonicalize:
 
403
            fixer = lambda p: osutils.canonical_relpath(self.basedir, p)
 
404
        else:
 
405
            fixer = self.relpath
 
406
        for filename in file_list:
 
407
            relpath = fixer(osutils.dereference_path(filename))
 
408
            if view_files and not osutils.is_inside_any(view_files, relpath):
 
409
                raise errors.FileOutsideView(filename, view_files)
 
410
            new_list.append(relpath)
 
411
        return new_list
 
412
 
 
413
    @staticmethod
349
414
    def open_downlevel(path=None):
350
415
        """Open an unsupported working tree.
351
416
 
364
429
                return True, None
365
430
            else:
366
431
                return True, tree
367
 
        transport = get_transport(location)
368
 
        iterator = bzrdir.BzrDir.find_bzrdirs(transport, evaluate=evaluate,
 
432
        t = transport.get_transport(location)
 
433
        iterator = bzrdir.BzrDir.find_bzrdirs(t, evaluate=evaluate,
369
434
                                              list_current=list_current)
370
 
        return [t for t in iterator if t is not None]
 
435
        return [tr for tr in iterator if tr is not None]
371
436
 
372
437
    # should be deprecated - this is slow and in any case treating them as a
373
438
    # container is (we now know) bad style -- mbp 20070302
458
523
        return (file_obj, stat_value)
459
524
 
460
525
    def get_file_text(self, file_id, path=None, filtered=True):
461
 
        return self.get_file(file_id, path=path, filtered=filtered).read()
 
526
        my_file = self.get_file(file_id, path=path, filtered=filtered)
 
527
        try:
 
528
            return my_file.read()
 
529
        finally:
 
530
            my_file.close()
462
531
 
463
532
    def get_file_byname(self, filename, filtered=True):
464
533
        path = self.abspath(filename)
518
587
 
519
588
        # Now we have the parents of this content
520
589
        annotator = self.branch.repository.texts.get_annotator()
521
 
        text = self.get_file(file_id).read()
 
590
        text = self.get_file_text(file_id)
522
591
        this_key =(file_id, default_revision)
523
592
        annotator.add_special_text(this_key, file_parent_keys, text)
524
593
        annotations = [(key[-1], line)
544
613
        else:
545
614
            parents = [last_rev]
546
615
        try:
547
 
            merges_file = self._transport.get('pending-merges')
 
616
            merges_bytes = self._transport.get_bytes('pending-merges')
548
617
        except errors.NoSuchFile:
549
618
            pass
550
619
        else:
551
 
            for l in merges_file.readlines():
 
620
            for l in osutils.split_lines(merges_bytes):
552
621
                revision_id = l.rstrip('\n')
553
622
                parents.append(revision_id)
554
623
        return parents
636
705
 
637
706
    def _is_executable_from_path_and_stat_from_basis(self, path, stat_result):
638
707
        file_id = self.path2id(path)
 
708
        if file_id is None:
 
709
            # For unversioned files on win32, we just assume they are not
 
710
            # executable
 
711
            return False
639
712
        return self._inventory[file_id].executable
640
713
 
641
714
    def _is_executable_from_path_and_stat_from_stat(self, path, stat_result):
906
979
            branch.last_revision().
907
980
        """
908
981
        from bzrlib.merge import Merger, Merge3Merger
909
 
        pb = ui.ui_factory.nested_progress_bar()
910
 
        try:
911
 
            merger = Merger(self.branch, this_tree=self, pb=pb)
912
 
            merger.pp = ProgressPhase("Merge phase", 5, pb)
913
 
            merger.pp.next_phase()
914
 
            # check that there are no local alterations
915
 
            if not force and self.has_changes():
916
 
                raise errors.UncommittedChanges(self)
917
 
            if to_revision is None:
918
 
                to_revision = _mod_revision.ensure_null(branch.last_revision())
919
 
            merger.other_rev_id = to_revision
920
 
            if _mod_revision.is_null(merger.other_rev_id):
921
 
                raise errors.NoCommits(branch)
922
 
            self.branch.fetch(branch, last_revision=merger.other_rev_id)
923
 
            merger.other_basis = merger.other_rev_id
924
 
            merger.other_tree = self.branch.repository.revision_tree(
925
 
                merger.other_rev_id)
926
 
            merger.other_branch = branch
927
 
            merger.pp.next_phase()
928
 
            if from_revision is None:
929
 
                merger.find_base()
930
 
            else:
931
 
                merger.set_base_revision(from_revision, branch)
932
 
            if merger.base_rev_id == merger.other_rev_id:
933
 
                raise errors.PointlessMerge
934
 
            merger.backup_files = False
935
 
            if merge_type is None:
936
 
                merger.merge_type = Merge3Merger
937
 
            else:
938
 
                merger.merge_type = merge_type
939
 
            merger.set_interesting_files(None)
940
 
            merger.show_base = False
941
 
            merger.reprocess = False
942
 
            conflicts = merger.do_merge()
943
 
            merger.set_pending()
944
 
        finally:
945
 
            pb.finished()
 
982
        merger = Merger(self.branch, this_tree=self)
 
983
        # check that there are no local alterations
 
984
        if not force and self.has_changes():
 
985
            raise errors.UncommittedChanges(self)
 
986
        if to_revision is None:
 
987
            to_revision = _mod_revision.ensure_null(branch.last_revision())
 
988
        merger.other_rev_id = to_revision
 
989
        if _mod_revision.is_null(merger.other_rev_id):
 
990
            raise errors.NoCommits(branch)
 
991
        self.branch.fetch(branch, last_revision=merger.other_rev_id)
 
992
        merger.other_basis = merger.other_rev_id
 
993
        merger.other_tree = self.branch.repository.revision_tree(
 
994
            merger.other_rev_id)
 
995
        merger.other_branch = branch
 
996
        if from_revision is None:
 
997
            merger.find_base()
 
998
        else:
 
999
            merger.set_base_revision(from_revision, branch)
 
1000
        if merger.base_rev_id == merger.other_rev_id:
 
1001
            raise errors.PointlessMerge
 
1002
        merger.backup_files = False
 
1003
        if merge_type is None:
 
1004
            merger.merge_type = Merge3Merger
 
1005
        else:
 
1006
            merger.merge_type = merge_type
 
1007
        merger.set_interesting_files(None)
 
1008
        merger.show_base = False
 
1009
        merger.reprocess = False
 
1010
        conflicts = merger.do_merge()
 
1011
        merger.set_pending()
946
1012
        return conflicts
947
1013
 
948
1014
    @needs_read_lock
1095
1161
        tree_transport = self.bzrdir.root_transport.clone(sub_path)
1096
1162
        if tree_transport.base != branch_transport.base:
1097
1163
            tree_bzrdir = format.initialize_on_transport(tree_transport)
1098
 
            branch.BranchReferenceFormat().initialize(tree_bzrdir, new_branch)
 
1164
            branch.BranchReferenceFormat().initialize(tree_bzrdir,
 
1165
                target_branch=new_branch)
1099
1166
        else:
1100
1167
            tree_bzrdir = branch_bzrdir
1101
1168
        wt = tree_bzrdir.create_workingtree(_mod_revision.NULL_REVISION)
1139
1206
        This does not include files that have been deleted in this
1140
1207
        tree. Skips the control directory.
1141
1208
 
1142
 
        :param include_root: if True, do not return an entry for the root
 
1209
        :param include_root: if True, return an entry for the root
1143
1210
        :param from_dir: start from this directory or None for the root
1144
1211
        :param recursive: whether to recurse into subdirectories or not
1145
1212
        """
1200
1267
                # absolute path
1201
1268
                fap = from_dir_abspath + '/' + f
1202
1269
 
1203
 
                f_ie = inv.get_child(from_dir_id, f)
 
1270
                dir_ie = inv[from_dir_id]
 
1271
                if dir_ie.kind == 'directory':
 
1272
                    f_ie = dir_ie.children.get(f)
 
1273
                else:
 
1274
                    f_ie = None
1204
1275
                if f_ie:
1205
1276
                    c = 'V'
1206
1277
                elif self.is_ignored(fp[1:]):
1207
1278
                    c = 'I'
1208
1279
                else:
1209
 
                    # we may not have found this file, because of a unicode issue
 
1280
                    # we may not have found this file, because of a unicode
 
1281
                    # issue, or because the directory was actually a symlink.
1210
1282
                    f_norm, can_access = osutils.normalized_filename(f)
1211
1283
                    if f == f_norm or not can_access:
1212
1284
                        # No change, so treat this file normally
1255
1327
                stack.pop()
1256
1328
 
1257
1329
    @needs_tree_write_lock
1258
 
    def move(self, from_paths, to_dir=None, after=False, **kwargs):
 
1330
    def move(self, from_paths, to_dir=None, after=False):
1259
1331
        """Rename files.
1260
1332
 
1261
1333
        to_dir must exist in the inventory.
1295
1367
 
1296
1368
        # check for deprecated use of signature
1297
1369
        if to_dir is None:
1298
 
            to_dir = kwargs.get('to_name', None)
1299
 
            if to_dir is None:
1300
 
                raise TypeError('You must supply a target directory')
1301
 
            else:
1302
 
                symbol_versioning.warn('The parameter to_name was deprecated'
1303
 
                                       ' in version 0.13. Use to_dir instead',
1304
 
                                       DeprecationWarning)
1305
 
 
 
1370
            raise TypeError('You must supply a target directory')
1306
1371
        # check destination directory
1307
1372
        if isinstance(from_paths, basestring):
1308
1373
            raise ValueError()
1599
1664
    @needs_write_lock
1600
1665
    def pull(self, source, overwrite=False, stop_revision=None,
1601
1666
             change_reporter=None, possible_transports=None, local=False):
1602
 
        top_pb = ui.ui_factory.nested_progress_bar()
1603
1667
        source.lock_read()
1604
1668
        try:
1605
 
            pp = ProgressPhase("Pull phase", 2, top_pb)
1606
 
            pp.next_phase()
1607
1669
            old_revision_info = self.branch.last_revision_info()
1608
1670
            basis_tree = self.basis_tree()
1609
1671
            count = self.branch.pull(source, overwrite, stop_revision,
1611
1673
                                     local=local)
1612
1674
            new_revision_info = self.branch.last_revision_info()
1613
1675
            if new_revision_info != old_revision_info:
1614
 
                pp.next_phase()
1615
1676
                repository = self.branch.repository
1616
 
                pb = ui.ui_factory.nested_progress_bar()
1617
1677
                basis_tree.lock_read()
1618
1678
                try:
1619
1679
                    new_basis_tree = self.branch.basis_tree()
1622
1682
                                new_basis_tree,
1623
1683
                                basis_tree,
1624
1684
                                this_tree=self,
1625
 
                                pb=pb,
 
1685
                                pb=None,
1626
1686
                                change_reporter=change_reporter)
1627
 
                    if (basis_tree.inventory.root is None and
1628
 
                        new_basis_tree.inventory.root is not None):
1629
 
                        self.set_root_id(new_basis_tree.get_root_id())
 
1687
                    basis_root_id = basis_tree.get_root_id()
 
1688
                    new_root_id = new_basis_tree.get_root_id()
 
1689
                    if basis_root_id != new_root_id:
 
1690
                        self.set_root_id(new_root_id)
1630
1691
                finally:
1631
 
                    pb.finished()
1632
1692
                    basis_tree.unlock()
1633
1693
                # TODO - dedup parents list with things merged by pull ?
1634
1694
                # reuse the revisiontree we merged against to set the new
1647
1707
            return count
1648
1708
        finally:
1649
1709
            source.unlock()
1650
 
            top_pb.finished()
1651
1710
 
1652
1711
    @needs_write_lock
1653
1712
    def put_file_bytes_non_atomic(self, file_id, bytes):
1738
1797
        r"""Check whether the filename matches an ignore pattern.
1739
1798
 
1740
1799
        Patterns containing '/' or '\' need to match the whole path;
1741
 
        others match against only the last component.
 
1800
        others match against only the last component.  Patterns starting
 
1801
        with '!' are ignore exceptions.  Exceptions take precedence
 
1802
        over regular patterns and cause the filename to not be ignored.
1742
1803
 
1743
1804
        If the file is ignored, returns the pattern which caused it to
1744
1805
        be ignored, otherwise None.  So this can simply be used as a
1745
1806
        boolean if desired."""
1746
1807
        if getattr(self, '_ignoreglobster', None) is None:
1747
 
            self._ignoreglobster = globbing.Globster(self.get_ignore_list())
 
1808
            self._ignoreglobster = globbing.ExceptionGlobster(self.get_ignore_list())
1748
1809
        return self._ignoreglobster.match(filename)
1749
1810
 
1750
1811
    def kind(self, file_id):
1800
1861
            raise errors.ObjectNotLocked(self)
1801
1862
 
1802
1863
    def lock_read(self):
1803
 
        """See Branch.lock_read, and WorkingTree.unlock."""
 
1864
        """Lock the tree for reading.
 
1865
 
 
1866
        This also locks the branch, and can be unlocked via self.unlock().
 
1867
 
 
1868
        :return: A bzrlib.lock.LogicalLockResult.
 
1869
        """
1804
1870
        if not self.is_locked():
1805
1871
            self._reset_data()
1806
1872
        self.branch.lock_read()
1807
1873
        try:
1808
 
            return self._control_files.lock_read()
 
1874
            self._control_files.lock_read()
 
1875
            return LogicalLockResult(self.unlock)
1809
1876
        except:
1810
1877
            self.branch.unlock()
1811
1878
            raise
1812
1879
 
1813
1880
    def lock_tree_write(self):
1814
 
        """See MutableTree.lock_tree_write, and WorkingTree.unlock."""
 
1881
        """See MutableTree.lock_tree_write, and WorkingTree.unlock.
 
1882
 
 
1883
        :return: A bzrlib.lock.LogicalLockResult.
 
1884
        """
1815
1885
        if not self.is_locked():
1816
1886
            self._reset_data()
1817
1887
        self.branch.lock_read()
1818
1888
        try:
1819
 
            return self._control_files.lock_write()
 
1889
            self._control_files.lock_write()
 
1890
            return LogicalLockResult(self.unlock)
1820
1891
        except:
1821
1892
            self.branch.unlock()
1822
1893
            raise
1823
1894
 
1824
1895
    def lock_write(self):
1825
 
        """See MutableTree.lock_write, and WorkingTree.unlock."""
 
1896
        """See MutableTree.lock_write, and WorkingTree.unlock.
 
1897
 
 
1898
        :return: A bzrlib.lock.LogicalLockResult.
 
1899
        """
1826
1900
        if not self.is_locked():
1827
1901
            self._reset_data()
1828
1902
        self.branch.lock_write()
1829
1903
        try:
1830
 
            return self._control_files.lock_write()
 
1904
            self._control_files.lock_write()
 
1905
            return LogicalLockResult(self.unlock)
1831
1906
        except:
1832
1907
            self.branch.unlock()
1833
1908
            raise
1841
1916
    def _reset_data(self):
1842
1917
        """Reset transient data that cannot be revalidated."""
1843
1918
        self._inventory_is_modified = False
1844
 
        result = self._deserialize(self._transport.get('inventory'))
 
1919
        f = self._transport.get('inventory')
 
1920
        try:
 
1921
            result = self._deserialize(f)
 
1922
        finally:
 
1923
            f.close()
1845
1924
        self._set_inventory(result, dirty=False)
1846
1925
 
1847
1926
    @needs_tree_write_lock
1894
1973
            # revision_id is set. We must check for this full string, because a
1895
1974
            # root node id can legitimately look like 'revision_id' but cannot
1896
1975
            # contain a '"'.
1897
 
            xml = self.branch.repository.get_inventory_xml(new_revision)
 
1976
            xml = self.branch.repository._get_inventory_xml(new_revision)
1898
1977
            firstline = xml.split('\n', 1)[0]
1899
1978
            if (not 'revision_id="' in firstline or
1900
1979
                'format="7"' not in firstline):
1923
2002
        # binary.
1924
2003
        if self._inventory_is_modified:
1925
2004
            raise errors.InventoryModified(self)
1926
 
        result = self._deserialize(self._transport.get('inventory'))
 
2005
        f = self._transport.get('inventory')
 
2006
        try:
 
2007
            result = self._deserialize(f)
 
2008
        finally:
 
2009
            f.close()
1927
2010
        self._set_inventory(result, dirty=False)
1928
2011
        return result
1929
2012
 
1942
2025
 
1943
2026
        inv_delta = []
1944
2027
 
1945
 
        new_files=set()
 
2028
        all_files = set() # specified and nested files 
1946
2029
        unknown_nested_files=set()
 
2030
        if to_file is None:
 
2031
            to_file = sys.stdout
 
2032
 
 
2033
        files_to_backup = []
1947
2034
 
1948
2035
        def recurse_directory_to_add_files(directory):
1949
2036
            # Recurse directory and add all files
1950
2037
            # so we can check if they have changed.
1951
 
            for parent_info, file_infos in\
1952
 
                self.walkdirs(directory):
 
2038
            for parent_info, file_infos in self.walkdirs(directory):
1953
2039
                for relpath, basename, kind, lstat, fileid, kind in file_infos:
1954
2040
                    # Is it versioned or ignored?
1955
 
                    if self.path2id(relpath) or self.is_ignored(relpath):
 
2041
                    if self.path2id(relpath):
1956
2042
                        # Add nested content for deletion.
1957
 
                        new_files.add(relpath)
 
2043
                        all_files.add(relpath)
1958
2044
                    else:
1959
 
                        # Files which are not versioned and not ignored
 
2045
                        # Files which are not versioned
1960
2046
                        # should be treated as unknown.
1961
 
                        unknown_nested_files.add((relpath, None, kind))
 
2047
                        files_to_backup.append(relpath)
1962
2048
 
1963
2049
        for filename in files:
1964
2050
            # Get file name into canonical form.
1965
2051
            abspath = self.abspath(filename)
1966
2052
            filename = self.relpath(abspath)
1967
2053
            if len(filename) > 0:
1968
 
                new_files.add(filename)
 
2054
                all_files.add(filename)
1969
2055
                recurse_directory_to_add_files(filename)
1970
2056
 
1971
 
        files = list(new_files)
 
2057
        files = list(all_files)
1972
2058
 
1973
2059
        if len(files) == 0:
1974
2060
            return # nothing to do
1978
2064
 
1979
2065
        # Bail out if we are going to delete files we shouldn't
1980
2066
        if not keep_files and not force:
1981
 
            has_changed_files = len(unknown_nested_files) > 0
1982
 
            if not has_changed_files:
1983
 
                for (file_id, path, content_change, versioned, parent_id, name,
1984
 
                     kind, executable) in self.iter_changes(self.basis_tree(),
1985
 
                         include_unchanged=True, require_versioned=False,
1986
 
                         want_unversioned=True, specific_files=files):
1987
 
                    if versioned == (False, False):
1988
 
                        # The record is unknown ...
1989
 
                        if not self.is_ignored(path[1]):
1990
 
                            # ... but not ignored
1991
 
                            has_changed_files = True
1992
 
                            break
1993
 
                    elif content_change and (kind[1] is not None):
1994
 
                        # Versioned and changed, but not deleted
1995
 
                        has_changed_files = True
1996
 
                        break
 
2067
            for (file_id, path, content_change, versioned, parent_id, name,
 
2068
                 kind, executable) in self.iter_changes(self.basis_tree(),
 
2069
                     include_unchanged=True, require_versioned=False,
 
2070
                     want_unversioned=True, specific_files=files):
 
2071
                if versioned[0] == False:
 
2072
                    # The record is unknown or newly added
 
2073
                    files_to_backup.append(path[1])
 
2074
                elif (content_change and (kind[1] is not None) and
 
2075
                        osutils.is_inside_any(files, path[1])):
 
2076
                    # Versioned and changed, but not deleted, and still
 
2077
                    # in one of the dirs to be deleted.
 
2078
                    files_to_backup.append(path[1])
1997
2079
 
1998
 
            if has_changed_files:
1999
 
                # Make delta show ALL applicable changes in error message.
2000
 
                tree_delta = self.changes_from(self.basis_tree(),
2001
 
                    require_versioned=False, want_unversioned=True,
2002
 
                    specific_files=files)
2003
 
                for unknown_file in unknown_nested_files:
2004
 
                    if unknown_file not in tree_delta.unversioned:
2005
 
                        tree_delta.unversioned.extend((unknown_file,))
2006
 
                raise errors.BzrRemoveChangedFilesError(tree_delta)
 
2080
        def backup(file_to_backup):
 
2081
            backup_name = self.bzrdir.generate_backup_name(file_to_backup)
 
2082
            osutils.rename(abs_path, self.abspath(backup_name))
 
2083
            return "removed %s (but kept a copy: %s)" % (file_to_backup, backup_name)
2007
2084
 
2008
2085
        # Build inv_delta and delete files where applicable,
2009
2086
        # do this before any modifications to inventory.
2019
2096
                        new_status = 'I'
2020
2097
                    else:
2021
2098
                        new_status = '?'
2022
 
                    textui.show_status(new_status, self.kind(fid), f,
2023
 
                                       to_file=to_file)
 
2099
                    # XXX: Really should be a more abstract reporter interface
 
2100
                    kind_ch = osutils.kind_marker(self.kind(fid))
 
2101
                    to_file.write(new_status + '       ' + f + kind_ch + '\n')
2024
2102
                # Unversion file
2025
2103
                inv_delta.append((f, None, fid, None))
2026
2104
                message = "removed %s" % (f,)
2032
2110
                        len(os.listdir(abs_path)) > 0):
2033
2111
                        if force:
2034
2112
                            osutils.rmtree(abs_path)
 
2113
                            message = "deleted %s" % (f,)
2035
2114
                        else:
2036
 
                            message = "%s is not an empty directory "\
2037
 
                                "and won't be deleted." % (f,)
 
2115
                            message = backup(f)
2038
2116
                    else:
2039
 
                        osutils.delete_any(abs_path)
2040
 
                        message = "deleted %s" % (f,)
 
2117
                        if f in files_to_backup:
 
2118
                            message = backup(f)
 
2119
                        else:
 
2120
                            osutils.delete_any(abs_path)
 
2121
                            message = "deleted %s" % (f,)
2041
2122
                elif message is not None:
2042
2123
                    # Only care if we haven't done anything yet.
2043
2124
                    message = "%s does not exist." % (f,)
2049
2130
 
2050
2131
    @needs_tree_write_lock
2051
2132
    def revert(self, filenames=None, old_tree=None, backups=True,
2052
 
               pb=DummyProgress(), report_changes=False):
 
2133
               pb=None, report_changes=False):
2053
2134
        from bzrlib.conflicts import resolve
2054
2135
        if filenames == []:
2055
2136
            filenames = None
2177
2258
        """
2178
2259
        raise NotImplementedError(self.unlock)
2179
2260
 
2180
 
    def update(self, change_reporter=None, possible_transports=None):
 
2261
    _marker = object()
 
2262
 
 
2263
    def update(self, change_reporter=None, possible_transports=None,
 
2264
               revision=None, old_tip=_marker):
2181
2265
        """Update a working tree along its branch.
2182
2266
 
2183
2267
        This will update the branch if its bound too, which means we have
2201
2285
        - Merge current state -> basis tree of the master w.r.t. the old tree
2202
2286
          basis.
2203
2287
        - Do a 'normal' merge of the old branch basis if it is relevant.
 
2288
 
 
2289
        :param revision: The target revision to update to. Must be in the
 
2290
            revision history.
 
2291
        :param old_tip: If branch.update() has already been run, the value it
 
2292
            returned (old tip of the branch or None). _marker is used
 
2293
            otherwise.
2204
2294
        """
2205
2295
        if self.branch.get_bound_location() is not None:
2206
2296
            self.lock_write()
2207
 
            update_branch = True
 
2297
            update_branch = (old_tip is self._marker)
2208
2298
        else:
2209
2299
            self.lock_tree_write()
2210
2300
            update_branch = False
2212
2302
            if update_branch:
2213
2303
                old_tip = self.branch.update(possible_transports)
2214
2304
            else:
2215
 
                old_tip = None
2216
 
            return self._update_tree(old_tip, change_reporter)
 
2305
                if old_tip is self._marker:
 
2306
                    old_tip = None
 
2307
            return self._update_tree(old_tip, change_reporter, revision)
2217
2308
        finally:
2218
2309
            self.unlock()
2219
2310
 
2220
2311
    @needs_tree_write_lock
2221
 
    def _update_tree(self, old_tip=None, change_reporter=None):
 
2312
    def _update_tree(self, old_tip=None, change_reporter=None, revision=None):
2222
2313
        """Update a tree to the master branch.
2223
2314
 
2224
2315
        :param old_tip: if supplied, the previous tip revision the branch,
2234
2325
        # We MUST save it even if an error occurs, because otherwise the users
2235
2326
        # local work is unreferenced and will appear to have been lost.
2236
2327
        #
2237
 
        result = 0
 
2328
        nb_conflicts = 0
2238
2329
        try:
2239
2330
            last_rev = self.get_parent_ids()[0]
2240
2331
        except IndexError:
2241
2332
            last_rev = _mod_revision.NULL_REVISION
2242
 
        if last_rev != _mod_revision.ensure_null(self.branch.last_revision()):
2243
 
            # merge tree state up to new branch tip.
 
2333
        if revision is None:
 
2334
            revision = self.branch.last_revision()
 
2335
 
 
2336
        old_tip = old_tip or _mod_revision.NULL_REVISION
 
2337
 
 
2338
        if not _mod_revision.is_null(old_tip) and old_tip != last_rev:
 
2339
            # the branch we are bound to was updated
 
2340
            # merge those changes in first
 
2341
            base_tree  = self.basis_tree()
 
2342
            other_tree = self.branch.repository.revision_tree(old_tip)
 
2343
            nb_conflicts = merge.merge_inner(self.branch, other_tree,
 
2344
                                             base_tree, this_tree=self,
 
2345
                                             change_reporter=change_reporter)
 
2346
            if nb_conflicts:
 
2347
                self.add_parent_tree((old_tip, other_tree))
 
2348
                trace.note('Rerun update after fixing the conflicts.')
 
2349
                return nb_conflicts
 
2350
 
 
2351
        if last_rev != _mod_revision.ensure_null(revision):
 
2352
            # the working tree is up to date with the branch
 
2353
            # we can merge the specified revision from master
 
2354
            to_tree = self.branch.repository.revision_tree(revision)
 
2355
            to_root_id = to_tree.get_root_id()
 
2356
 
2244
2357
            basis = self.basis_tree()
2245
2358
            basis.lock_read()
2246
2359
            try:
2247
 
                to_tree = self.branch.basis_tree()
2248
 
                if basis.inventory.root is None:
2249
 
                    self.set_root_id(to_tree.get_root_id())
 
2360
                if (basis.inventory.root is None
 
2361
                    or basis.inventory.root.file_id != to_root_id):
 
2362
                    self.set_root_id(to_root_id)
2250
2363
                    self.flush()
2251
 
                result += merge.merge_inner(
2252
 
                                      self.branch,
2253
 
                                      to_tree,
2254
 
                                      basis,
2255
 
                                      this_tree=self,
2256
 
                                      change_reporter=change_reporter)
2257
2364
            finally:
2258
2365
                basis.unlock()
 
2366
 
 
2367
            # determine the branch point
 
2368
            graph = self.branch.repository.get_graph()
 
2369
            base_rev_id = graph.find_unique_lca(self.branch.last_revision(),
 
2370
                                                last_rev)
 
2371
            base_tree = self.branch.repository.revision_tree(base_rev_id)
 
2372
 
 
2373
            nb_conflicts = merge.merge_inner(self.branch, to_tree, base_tree,
 
2374
                                             this_tree=self,
 
2375
                                             change_reporter=change_reporter)
 
2376
            self.set_last_revision(revision)
2259
2377
            # TODO - dedup parents list with things merged by pull ?
2260
2378
            # reuse the tree we've updated to to set the basis:
2261
 
            parent_trees = [(self.branch.last_revision(), to_tree)]
 
2379
            parent_trees = [(revision, to_tree)]
2262
2380
            merges = self.get_parent_ids()[1:]
2263
2381
            # Ideally we ask the tree for the trees here, that way the working
2264
2382
            # tree can decide whether to give us the entire tree or give us a
2268
2386
            for parent in merges:
2269
2387
                parent_trees.append(
2270
2388
                    (parent, self.branch.repository.revision_tree(parent)))
2271
 
            if (old_tip is not None and not _mod_revision.is_null(old_tip)):
 
2389
            if not _mod_revision.is_null(old_tip):
2272
2390
                parent_trees.append(
2273
2391
                    (old_tip, self.branch.repository.revision_tree(old_tip)))
2274
2392
            self.set_parent_trees(parent_trees)
2275
2393
            last_rev = parent_trees[0][0]
2276
 
        else:
2277
 
            # the working tree had the same last-revision as the master
2278
 
            # branch did. We may still have pivot local work from the local
2279
 
            # branch into old_tip:
2280
 
            if (old_tip is not None and not _mod_revision.is_null(old_tip)):
2281
 
                self.add_parent_tree_id(old_tip)
2282
 
        if (old_tip is not None and not _mod_revision.is_null(old_tip)
2283
 
            and old_tip != last_rev):
2284
 
            # our last revision was not the prior branch last revision
2285
 
            # and we have converted that last revision to a pending merge.
2286
 
            # base is somewhere between the branch tip now
2287
 
            # and the now pending merge
2288
 
 
2289
 
            # Since we just modified the working tree and inventory, flush out
2290
 
            # the current state, before we modify it again.
2291
 
            # TODO: jam 20070214 WorkingTree3 doesn't require this, dirstate
2292
 
            #       requires it only because TreeTransform directly munges the
2293
 
            #       inventory and calls tree._write_inventory(). Ultimately we
2294
 
            #       should be able to remove this extra flush.
2295
 
            self.flush()
2296
 
            graph = self.branch.repository.get_graph()
2297
 
            base_rev_id = graph.find_unique_lca(self.branch.last_revision(),
2298
 
                                                old_tip)
2299
 
            base_tree = self.branch.repository.revision_tree(base_rev_id)
2300
 
            other_tree = self.branch.repository.revision_tree(old_tip)
2301
 
            result += merge.merge_inner(
2302
 
                                  self.branch,
2303
 
                                  other_tree,
2304
 
                                  base_tree,
2305
 
                                  this_tree=self,
2306
 
                                  change_reporter=change_reporter)
2307
 
        return result
 
2394
        return nb_conflicts
2308
2395
 
2309
2396
    def _write_hashcache_if_dirty(self):
2310
2397
        """Write out the hashcache if it is dirty."""
2580
2667
        """
2581
2668
        return
2582
2669
 
2583
 
    @needs_read_lock
2584
2670
    def _get_rules_searcher(self, default_searcher):
2585
2671
        """See Tree._get_rules_searcher."""
2586
2672
        if self._rules_searcher is None:
2622
2708
 
2623
2709
        In Format2 WorkingTrees we have a single lock for the branch and tree
2624
2710
        so lock_tree_write() degrades to lock_write().
 
2711
 
 
2712
        :return: An object with an unlock method which will release the lock
 
2713
            obtained.
2625
2714
        """
2626
2715
        self.branch.lock_write()
2627
2716
        try:
2628
 
            return self._control_files.lock_write()
 
2717
            self._control_files.lock_write()
 
2718
            return self
2629
2719
        except:
2630
2720
            self.branch.unlock()
2631
2721
            raise
2765
2855
        """Return the format for the working tree object in a_bzrdir."""
2766
2856
        try:
2767
2857
            transport = a_bzrdir.get_workingtree_transport(None)
2768
 
            format_string = transport.get("format").read()
 
2858
            format_string = transport.get_bytes("format")
2769
2859
            return klass._formats[format_string]
2770
2860
        except errors.NoSuchFile:
2771
2861
            raise errors.NoWorkingTree(base=transport.base)