24
24
from bzrlib import (
27
from bzrlib.branch import Branch
28
31
from bzrlib.bzrdir import BzrDir
29
from bzrlib.errors import BzrCommandError
30
from bzrlib.tests.blackbox import ExternalBase
31
from bzrlib.workingtree import WorkingTree
34
class TestCommit(ExternalBase):
32
from bzrlib.tests import (
36
from bzrlib.tests import TestCaseWithTransport
39
class TestCommit(TestCaseWithTransport):
36
41
def test_05_empty_commit(self):
37
42
"""Commit of tree with no versioned files should fail"""
38
43
# If forced, it should succeed, but this is not tested here.
44
self.make_branch_and_tree('.')
40
45
self.build_tree(['hello.txt'])
41
46
out,err = self.run_bzr('commit -m empty', retcode=3)
42
47
self.assertEqual('', out)
43
self.assertStartsWith(err, 'bzr: ERROR: no changes to commit.'
44
' use --unchanged to commit anyhow\n')
48
self.assertContainsRe(err, 'bzr: ERROR: No changes to commit\.'
49
' Use --unchanged to commit anyhow.\n')
46
51
def test_commit_success(self):
47
52
"""Successful commit should not leave behind a bzr-commit-* file"""
53
self.make_branch_and_tree('.')
49
54
self.run_bzr('commit --unchanged -m message')
50
55
self.assertEqual('', self.run_bzr('unknowns')[0])
56
61
def test_commit_with_path(self):
57
62
"""Commit tree with path of root specified"""
58
self.run_bzr('init a')
63
a_tree = self.make_branch_and_tree('a')
59
64
self.build_tree(['a/a_file'])
60
self.run_bzr('add a/a_file')
61
66
self.run_bzr(['commit', '-m', 'first commit', 'a'])
63
self.run_bzr('branch a b')
68
b_tree = a_tree.bzrdir.sprout('b').open_workingtree()
64
69
self.build_tree_contents([('b/a_file', 'changes in b')])
65
70
self.run_bzr(['commit', '-m', 'first commit in b', 'b'])
67
72
self.build_tree_contents([('a/a_file', 'new contents')])
68
73
self.run_bzr(['commit', '-m', 'change in a', 'a'])
71
self.run_bzr('merge ../a', retcode=1) # will conflict
75
b_tree.merge_from_branch(a_tree.branch)
76
self.assertEqual(len(b_tree.conflicts()), 1)
73
77
self.run_bzr('resolved b/a_file')
74
78
self.run_bzr(['commit', '-m', 'merge into b', 'b'])
77
81
def test_10_verbose_commit(self):
78
82
"""Add one file and examine verbose commit output"""
83
tree = self.make_branch_and_tree('.')
80
84
self.build_tree(['hello.txt'])
81
self.run_bzr("add hello.txt")
82
86
out,err = self.run_bzr('commit -m added')
83
87
self.assertEqual('', out)
84
self.assertEqual('added hello.txt\n'
85
'Committed revision 1.\n',
88
self.assertContainsRe(err, '^Committing to: .*\n'
90
'Committed revision 1.\n$',)
88
92
def prepare_simple_history(self):
89
93
"""Prepare and return a working tree with one commit of one file"""
100
104
self.build_tree_contents([('hello.txt', 'new contents')])
101
105
out, err = self.run_bzr('commit -m modified')
102
106
self.assertEqual('', out)
103
self.assertEqual('modified hello.txt\n'
104
'Committed revision 2.\n',
107
self.assertContainsRe(err, '^Committing to: .*\n'
108
'modified hello\.txt\n'
109
'Committed revision 2\.\n$')
111
def test_unicode_commit_message_is_filename(self):
112
"""Unicode commit message same as a filename (Bug #563646).
114
file_name = u'\N{euro sign}'
115
self.run_bzr(['init'])
116
open(file_name, 'w').write('hello world')
117
self.run_bzr(['add'])
118
out, err = self.run_bzr(['commit', '-m', file_name])
119
reflags = re.MULTILINE|re.DOTALL|re.UNICODE
120
te = osutils.get_terminal_encoding()
121
self.assertContainsRe(err.decode(te),
122
u'The commit message is a file name:',
125
# Run same test with a filename that causes encode
126
# error for the terminal encoding. We do this
127
# by forcing terminal encoding of ascii for
128
# osutils.get_terminal_encoding which is used
129
# by ui.text.show_warning
130
default_get_terminal_enc = osutils.get_terminal_encoding
132
osutils.get_terminal_encoding = lambda trace=None: 'ascii'
133
file_name = u'foo\u1234'
134
open(file_name, 'w').write('hello world')
135
self.run_bzr(['add'])
136
out, err = self.run_bzr(['commit', '-m', file_name])
137
reflags = re.MULTILINE|re.DOTALL|re.UNICODE
138
te = osutils.get_terminal_encoding()
139
self.assertContainsRe(err.decode(te, 'replace'),
140
u'The commit message is a file name:',
143
osutils.get_terminal_encoding = default_get_terminal_enc
145
def test_warn_about_forgotten_commit_message(self):
146
"""Test that the lack of -m parameter is caught"""
147
wt = self.make_branch_and_tree('.')
148
self.build_tree(['one', 'two'])
150
out, err = self.run_bzr('commit -m one two')
151
self.assertContainsRe(err, "The commit message is a file name")
107
153
def test_verbose_commit_renamed(self):
108
154
# Verbose commit of renamed file should say so
135
184
wt.add(['hello.txt'])
136
185
out,err = self.run_bzr('commit -m added')
137
186
self.assertEqual('', out)
138
self.assertEqual('added hello.txt\n'
139
'Committed revision 1.\n',
187
self.assertContainsRe(err, '^Committing to: .*\n'
189
'Committed revision 1\.\n$')
142
191
def test_verbose_commit_with_unchanged(self):
143
192
"""Unchanged files should not be listed by default in verbose output"""
193
tree = self.make_branch_and_tree('.')
145
194
self.build_tree(['hello.txt', 'unchanged.txt'])
146
self.run_bzr('add unchanged.txt')
195
tree.add('unchanged.txt')
147
196
self.run_bzr('commit -m unchanged unchanged.txt')
148
self.run_bzr("add hello.txt")
197
tree.add("hello.txt")
149
198
out,err = self.run_bzr('commit -m added')
150
199
self.assertEqual('', out)
151
self.assertEqual('added hello.txt\n'
152
'Committed revision 2.\n',
200
self.assertContainsRe(err, '^Committing to: .*\n'
202
'Committed revision 2\.$\n')
204
def test_verbose_commit_includes_master_location(self):
205
"""Location of master is displayed when committing to bound branch"""
206
a_tree = self.make_branch_and_tree('a')
207
self.build_tree(['a/b'])
209
a_tree.commit(message='Initial message')
211
b_tree = a_tree.branch.create_checkout('b')
212
expected = "%s/" % (osutils.abspath('a'), )
213
out, err = self.run_bzr('commit -m blah --unchanged', working_dir='b')
214
self.assertEqual(err, 'Committing to: %s\n'
215
'Committed revision 2.\n' % expected)
217
def test_commit_sanitizes_CR_in_message(self):
218
# See bug #433779, basically Emacs likes to pass '\r\n' style line
219
# endings to 'bzr commit -m ""' which breaks because we don't allow
220
# '\r' in commit messages. (Mostly because of issues where XML style
221
# formats arbitrarily strip it out of the data while parsing.)
222
# To make life easier for users, we just always translate '\r\n' =>
223
# '\n'. And '\r' => '\n'.
224
a_tree = self.make_branch_and_tree('a')
225
self.build_tree(['a/b'])
227
self.run_bzr(['commit',
228
'-m', 'a string\r\n\r\nwith mixed\r\rendings\n'],
230
rev_id = a_tree.branch.last_revision()
231
rev = a_tree.branch.repository.get_revision(rev_id)
232
self.assertEqualDiff('a string\n\nwith mixed\n\nendings\n',
155
235
def test_commit_merge_reports_all_modified_files(self):
156
236
# the commit command should show all the files that are shown by
203
284
this_tree.merge_from_branch(other_tree.branch)
205
286
out,err = self.run_bzr('commit -m added')
207
287
self.assertEqual('', out)
208
self.assertEqualDiff(
209
'modified filetomodify\n'
212
'renamed dirtorename => renameddir\n'
213
'renamed dirtoreparent => renameddir/reparenteddir\n'
214
'renamed filetoreparent => renameddir/reparentedfile\n'
215
'renamed filetorename => renamedfile\n'
216
'deleted dirtoremove\n'
217
'deleted filetoremove\n'
218
'Committed revision 2.\n',
288
self.assertEqual(set([
289
'Committing to: %s/' % osutils.getcwd(),
290
'modified filetomodify',
293
'renamed dirtorename => renameddir',
294
'renamed filetorename => renamedfile',
295
'renamed dirtoreparent => renameddir/reparenteddir',
296
'renamed filetoreparent => renameddir/reparentedfile',
297
'deleted dirtoremove',
298
'deleted filetoremove',
299
'Committed revision 2.',
301
]), set(err.split('\n')))
221
303
def test_empty_commit_message(self):
223
file('foo.c', 'wt').write('int main() {}')
224
self.run_bzr('add foo.c')
304
tree = self.make_branch_and_tree('.')
305
self.build_tree_contents([('foo.c', 'int main() {}')])
225
307
self.run_bzr('commit -m ""', retcode=3)
227
309
def test_unsupported_encoding_commit_message(self):
310
if sys.platform == 'win32':
311
raise tests.TestNotApplicable('Win32 parses arguments directly'
312
' as Unicode, so we can\'t pass invalid non-ascii')
228
313
tree = self.make_branch_and_tree('.')
229
314
self.build_tree_contents([('foo.c', 'int main() {}')])
230
315
tree.add('foo.c')
231
out,err = self.run_bzr_subprocess('commit -m "\xff"', retcode=1,
232
env_changes={'LANG': 'C'})
316
# LANG env variable has no effect on Windows
317
# but some characters anyway cannot be represented
318
# in default user encoding
319
char = probe_bad_non_ascii(osutils.get_user_encoding())
321
raise TestSkipped('Cannot find suitable non-ascii character'
322
'for user_encoding (%s)' % osutils.get_user_encoding())
323
out,err = self.run_bzr_subprocess('commit -m "%s"' % char,
325
env_changes={'LANG': 'C'})
233
326
self.assertContainsRe(err, r'bzrlib.errors.BzrError: Parameter.*is '
234
327
'unsupported by the current encoding.')
236
329
def test_other_branch_commit(self):
237
330
# this branch is to ensure consistent behaviour, whether we're run
238
331
# inside a branch, or not.
239
os.mkdir('empty_branch')
240
os.chdir('empty_branch')
245
file('foo.c', 'wt').write('int main() {}')
246
file('bar.c', 'wt').write('int main() {}')
248
self.run_bzr('add branch/foo.c')
249
self.run_bzr('add branch')
332
outer_tree = self.make_branch_and_tree('.')
333
inner_tree = self.make_branch_and_tree('branch')
334
self.build_tree_contents([
335
('branch/foo.c', 'int main() {}'),
336
('branch/bar.c', 'int main() {}')])
337
inner_tree.add(['foo.c', 'bar.c'])
250
338
# can't commit files in different trees; sane error
251
339
self.run_bzr('commit -m newstuff branch/foo.c .', retcode=3)
340
# can commit to branch - records foo.c only
252
341
self.run_bzr('commit -m newstuff branch/foo.c')
342
# can commit to branch - records bar.c
253
343
self.run_bzr('commit -m newstuff branch')
254
self.run_bzr('commit -m newstuff branch', retcode=3)
345
self.run_bzr_error(["No changes to commit"], 'commit -m newstuff branch')
256
347
def test_out_of_date_tree_commit(self):
257
348
# check we get an error code and a clear message committing with an out
258
349
# of date checkout
259
self.make_branch_and_tree('branch')
350
tree = self.make_branch_and_tree('branch')
260
351
# make a checkout
261
self.run_bzr('checkout --lightweight branch checkout')
352
checkout = tree.branch.create_checkout('checkout', lightweight=True)
262
353
# commit to the original branch to make the checkout out of date
263
self.run_bzr('commit --unchanged -m message branch')
354
tree.commit('message branch', allow_pointless=True)
264
355
# now commit to the checkout should emit
265
356
# ERROR: Out of date with the branch, 'bzr update' is suggested
266
357
output = self.run_bzr('commit --unchanged -m checkout_message '
267
358
'checkout', retcode=3)
268
359
self.assertEqual(output,
270
"bzr: ERROR: Working tree is out of date, please run "
361
"bzr: ERROR: Working tree is out of date, please "
362
"run 'bzr update'.\n"))
273
364
def test_local_commit_unbound(self):
274
365
# a --local commit on an unbound branch is an error
281
372
def test_commit_a_text_merge_in_a_checkout(self):
282
373
# checkouts perform multiple actions in a transaction across bond
283
374
# branches and their master, and have been observed to fail in the
284
# past. This is a user story reported to fail in bug #43959 where
375
# past. This is a user story reported to fail in bug #43959 where
285
376
# a merge done in a checkout (using the update command) failed to
286
377
# commit correctly.
287
self.run_bzr('init trunk')
378
trunk = self.make_branch_and_tree('trunk')
289
self.run_bzr('checkout trunk u1')
290
self.build_tree_contents([('u1/hosts', 'initial contents')])
291
self.run_bzr('add u1/hosts')
380
u1 = trunk.branch.create_checkout('u1')
381
self.build_tree_contents([('u1/hosts', 'initial contents\n')])
292
383
self.run_bzr('commit -m add-hosts u1')
294
self.run_bzr('checkout trunk u2')
295
self.build_tree_contents([('u2/hosts', 'altered in u2')])
385
u2 = trunk.branch.create_checkout('u2')
386
self.build_tree_contents([('u2/hosts', 'altered in u2\n')])
296
387
self.run_bzr('commit -m checkin-from-u2 u2')
298
389
# make an offline commits
299
self.build_tree_contents([('u1/hosts', 'first offline change in u1')])
390
self.build_tree_contents([('u1/hosts', 'first offline change in u1\n')])
300
391
self.run_bzr('commit -m checkin-offline --local u1')
302
393
# now try to pull in online work from u2, and then commit our offline
303
394
# work as a merge
304
395
# retcode 1 as we expect a text conflict
305
396
self.run_bzr('update u1', retcode=1)
397
self.assertFileEqual('''\
399
first offline change in u1
306
406
self.run_bzr('resolved u1/hosts')
307
407
# add a text change here to represent resolving the merge conflicts in
308
408
# favour of a new version of the file not identical to either the u1
310
410
self.build_tree_contents([('u1/hosts', 'merge resolution\n')])
311
411
self.run_bzr('commit -m checkin-merge-of-the-offline-work-from-u1 u1')
413
def test_commit_exclude_excludes_modified_files(self):
414
"""Commit -x foo should ignore changes to foo."""
415
tree = self.make_branch_and_tree('.')
416
self.build_tree(['a', 'b', 'c'])
417
tree.smart_add(['.'])
418
out, err = self.run_bzr(['commit', '-m', 'test', '-x', 'b'])
419
self.assertFalse('added b' in out)
420
self.assertFalse('added b' in err)
421
# If b was excluded it will still be 'added' in status.
422
out, err = self.run_bzr(['added'])
423
self.assertEqual('b\n', out)
424
self.assertEqual('', err)
426
def test_commit_exclude_twice_uses_both_rules(self):
427
"""Commit -x foo -x bar should ignore changes to foo and bar."""
428
tree = self.make_branch_and_tree('.')
429
self.build_tree(['a', 'b', 'c'])
430
tree.smart_add(['.'])
431
out, err = self.run_bzr(['commit', '-m', 'test', '-x', 'b', '-x', 'c'])
432
self.assertFalse('added b' in out)
433
self.assertFalse('added c' in out)
434
self.assertFalse('added b' in err)
435
self.assertFalse('added c' in err)
436
# If b was excluded it will still be 'added' in status.
437
out, err = self.run_bzr(['added'])
438
self.assertTrue('b\n' in out)
439
self.assertTrue('c\n' in out)
440
self.assertEqual('', err)
313
442
def test_commit_respects_spec_for_removals(self):
314
443
"""Commit with a file spec should only commit removals that match"""
315
444
t = self.make_branch_and_tree('.')
512
647
"tree/hello.txt")
513
648
last_rev = tree.branch.repository.get_revision(tree.last_revision())
514
649
properties = last_rev.properties
515
self.assertEqual('John Doe', properties['author'])
650
self.assertEqual('John Doe', properties['authors'])
652
def test_multiple_authors(self):
653
"""Multiple authors can be specyfied, and all are stored."""
654
tree = self.make_branch_and_tree('tree')
655
self.build_tree(['tree/hello.txt'])
656
tree.add('hello.txt')
657
out, err = self.run_bzr("commit -m hello --author='John Doe' "
658
"--author='Jane Rey' tree/hello.txt")
659
last_rev = tree.branch.repository.get_revision(tree.last_revision())
660
properties = last_rev.properties
661
self.assertEqual('John Doe\nJane Rey', properties['authors'])
663
def test_commit_time(self):
664
tree = self.make_branch_and_tree('tree')
665
self.build_tree(['tree/hello.txt'])
666
tree.add('hello.txt')
667
out, err = self.run_bzr("commit -m hello "
668
"--commit-time='2009-10-10 08:00:00 +0100' tree/hello.txt")
669
last_rev = tree.branch.repository.get_revision(tree.last_revision())
671
'Sat 2009-10-10 08:00:00 +0100',
672
osutils.format_date(last_rev.timestamp, last_rev.timezone))
674
def test_commit_time_bad_time(self):
675
tree = self.make_branch_and_tree('tree')
676
self.build_tree(['tree/hello.txt'])
677
tree.add('hello.txt')
678
out, err = self.run_bzr("commit -m hello "
679
"--commit-time='NOT A TIME' tree/hello.txt", retcode=3)
680
self.assertStartsWith(
681
err, "bzr: ERROR: Could not parse --commit-time:")
683
def test_partial_commit_with_renames_in_tree(self):
684
# this test illustrates bug #140419
685
t = self.make_branch_and_tree('.')
686
self.build_tree(['dir/', 'dir/a', 'test'])
687
t.add(['dir/', 'dir/a', 'test'])
688
t.commit('initial commit')
689
# important part: file dir/a should change parent
690
# and should appear before old parent
691
# then during partial commit we have error
692
# parent_id {dir-XXX} not in inventory
693
t.rename_one('dir/a', 'a')
694
self.build_tree_contents([('test', 'changes in test')])
696
out, err = self.run_bzr('commit test -m "partial commit"')
697
self.assertEquals('', out)
698
self.assertContainsRe(err, r'modified test\nCommitted revision 2.')
700
def test_commit_readonly_checkout(self):
701
# https://bugs.launchpad.net/bzr/+bug/129701
702
# "UnlockableTransport error trying to commit in checkout of readonly
704
self.make_branch('master')
705
master = BzrDir.open_from_transport(
706
self.get_readonly_transport('master')).open_branch()
707
master.create_checkout('checkout')
708
out, err = self.run_bzr(['commit', '--unchanged', '-mfoo', 'checkout'],
710
self.assertContainsRe(err,
711
r'^bzr: ERROR: Cannot lock.*readonly transport')
713
def setup_editor(self):
714
# Test that commit template hooks work
715
if sys.platform == "win32":
716
f = file('fed.bat', 'w')
717
f.write('@rem dummy fed')
719
osutils.set_or_unset_env('BZR_EDITOR', "fed.bat")
721
f = file('fed.sh', 'wb')
722
f.write('#!/bin/sh\n')
724
os.chmod('fed.sh', 0755)
725
osutils.set_or_unset_env('BZR_EDITOR', "./fed.sh")
727
def setup_commit_with_template(self):
729
msgeditor.hooks.install_named_hook("commit_message_template",
730
lambda commit_obj, msg: "save me some typing\n", None)
731
tree = self.make_branch_and_tree('tree')
732
self.build_tree(['tree/hello.txt'])
733
tree.add('hello.txt')
736
def test_commit_hook_template_accepted(self):
737
tree = self.setup_commit_with_template()
738
out, err = self.run_bzr("commit tree/hello.txt", stdin="y\n")
739
last_rev = tree.branch.repository.get_revision(tree.last_revision())
740
self.assertEqual('save me some typing\n', last_rev.message)
742
def test_commit_hook_template_rejected(self):
743
tree = self.setup_commit_with_template()
744
expected = tree.last_revision()
745
out, err = self.run_bzr_error(["empty commit message"],
746
"commit tree/hello.txt", stdin="n\n")
747
self.assertEqual(expected, tree.last_revision())
749
def test_commit_without_username(self):
750
"""Ensure commit error if username is not set.
752
self.run_bzr(['init', 'foo'])
754
open('foo.txt', 'w').write('hello')
755
self.run_bzr(['add'])
756
osutils.set_or_unset_env('EMAIL', None)
757
osutils.set_or_unset_env('BZR_EMAIL', None)
758
out, err = self.run_bzr(['commit', '-m', 'initial'], 3)
759
self.assertContainsRe(err, 'Unable to determine your name')
added
removed
bzrlib/tests/blackbox/test_commit.py
