~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_http.py

  • Committer: Robert Collins
  • Date: 2010-05-06 07:48:22 UTC
  • mto: This revision was merged to the branch mainline in revision 5223.
  • Revision ID: robertc@robertcollins.net-20100506074822-0bsgf2j4h8jx0xkk
Added ``bzrlib.tests.matchers`` as a place to put matchers, along with
our first in-tree matcher. See the module docstring for details.
(Robert Collins)

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2011 Canonical Ltd
 
1
# Copyright (C) 2005-2010 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
23
23
# TODO: Should be renamed to bzrlib.transport.http.tests?
24
24
# TODO: What about renaming to bzrlib.tests.transport.http ?
25
25
 
 
26
from cStringIO import StringIO
26
27
import httplib
 
28
import os
 
29
import select
27
30
import SimpleHTTPServer
28
31
import socket
29
32
import sys
32
35
import bzrlib
33
36
from bzrlib import (
34
37
    bzrdir,
35
 
    cethread,
36
38
    config,
37
39
    errors,
38
40
    osutils,
40
42
    tests,
41
43
    transport,
42
44
    ui,
 
45
    urlutils,
 
46
    )
 
47
from bzrlib.symbol_versioning import (
 
48
    deprecated_in,
43
49
    )
44
50
from bzrlib.tests import (
45
51
    features,
46
52
    http_server,
47
53
    http_utils,
48
 
    test_server,
49
 
    )
50
 
from bzrlib.tests.scenarios import (
51
 
    load_tests_apply_scenarios,
52
 
    multiply_scenarios,
53
54
    )
54
55
from bzrlib.transport import (
55
56
    http,
65
66
    from bzrlib.transport.http._pycurl import PyCurlTransport
66
67
 
67
68
 
68
 
load_tests = load_tests_apply_scenarios
69
 
 
70
 
 
71
 
def vary_by_http_client_implementation():
72
 
    """Test the two libraries we can use, pycurl and urllib."""
 
69
def load_tests(standard_tests, module, loader):
 
70
    """Multiply tests for http clients and protocol versions."""
 
71
    result = loader.suiteClass()
 
72
 
 
73
    # one for each transport implementation
 
74
    t_tests, remaining_tests = tests.split_suite_by_condition(
 
75
        standard_tests, tests.condition_isinstance((
 
76
                TestHttpTransportRegistration,
 
77
                TestHttpTransportUrls,
 
78
                Test_redirected_to,
 
79
                )))
73
80
    transport_scenarios = [
74
81
        ('urllib', dict(_transport=_urllib.HttpTransport_urllib,
75
82
                        _server=http_server.HttpServer_urllib,
76
 
                        _url_protocol='http+urllib',)),
 
83
                        _qualified_prefix='http+urllib',)),
77
84
        ]
78
85
    if features.pycurl.available():
79
86
        transport_scenarios.append(
80
87
            ('pycurl', dict(_transport=PyCurlTransport,
81
88
                            _server=http_server.HttpServer_PyCurl,
82
 
                            _url_protocol='http+pycurl',)))
83
 
    return transport_scenarios
84
 
 
85
 
 
86
 
def vary_by_http_protocol_version():
87
 
    """Test on http/1.0 and 1.1"""
88
 
    return [
89
 
        ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
90
 
        ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
91
 
        ]
92
 
 
93
 
 
94
 
def vary_by_http_proxy_auth_scheme():
95
 
    return [
 
89
                            _qualified_prefix='http+pycurl',)))
 
90
    tests.multiply_tests(t_tests, transport_scenarios, result)
 
91
 
 
92
    # each implementation tested with each HTTP version
 
93
    tp_tests, remaining_tests = tests.split_suite_by_condition(
 
94
        remaining_tests, tests.condition_isinstance((
 
95
                SmartHTTPTunnellingTest,
 
96
                TestDoCatchRedirections,
 
97
                TestHTTPConnections,
 
98
                TestHTTPRedirections,
 
99
                TestHTTPSilentRedirections,
 
100
                TestLimitedRangeRequestServer,
 
101
                TestPost,
 
102
                TestProxyHttpServer,
 
103
                TestRanges,
 
104
                TestSpecificRequestHandler,
 
105
                )))
 
106
    protocol_scenarios = [
 
107
            ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
 
108
            ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
 
109
            ]
 
110
    tp_scenarios = tests.multiply_scenarios(transport_scenarios,
 
111
                                            protocol_scenarios)
 
112
    tests.multiply_tests(tp_tests, tp_scenarios, result)
 
113
 
 
114
    # proxy auth: each auth scheme on all http versions on all implementations.
 
115
    tppa_tests, remaining_tests = tests.split_suite_by_condition(
 
116
        remaining_tests, tests.condition_isinstance((
 
117
                TestProxyAuth,
 
118
                )))
 
119
    proxy_auth_scheme_scenarios = [
96
120
        ('basic', dict(_auth_server=http_utils.ProxyBasicAuthServer)),
97
121
        ('digest', dict(_auth_server=http_utils.ProxyDigestAuthServer)),
98
122
        ('basicdigest',
99
 
            dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
 
123
         dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
100
124
        ]
101
 
 
102
 
 
103
 
def vary_by_http_auth_scheme():
104
 
    return [
 
125
    tppa_scenarios = tests.multiply_scenarios(tp_scenarios,
 
126
                                              proxy_auth_scheme_scenarios)
 
127
    tests.multiply_tests(tppa_tests, tppa_scenarios, result)
 
128
 
 
129
    # auth: each auth scheme on all http versions on all implementations.
 
130
    tpa_tests, remaining_tests = tests.split_suite_by_condition(
 
131
        remaining_tests, tests.condition_isinstance((
 
132
                TestAuth,
 
133
                )))
 
134
    auth_scheme_scenarios = [
105
135
        ('basic', dict(_auth_server=http_utils.HTTPBasicAuthServer)),
106
136
        ('digest', dict(_auth_server=http_utils.HTTPDigestAuthServer)),
107
137
        ('basicdigest',
108
 
            dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
 
138
         dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
109
139
        ]
110
 
 
111
 
 
112
 
def vary_by_http_activity():
 
140
    tpa_scenarios = tests.multiply_scenarios(tp_scenarios,
 
141
                                             auth_scheme_scenarios)
 
142
    tests.multiply_tests(tpa_tests, tpa_scenarios, result)
 
143
 
 
144
    # activity: on all http[s] versions on all implementations
 
145
    tpact_tests, remaining_tests = tests.split_suite_by_condition(
 
146
        remaining_tests, tests.condition_isinstance((
 
147
                TestActivity,
 
148
                )))
113
149
    activity_scenarios = [
114
150
        ('urllib,http', dict(_activity_server=ActivityHTTPServer,
115
 
                            _transport=_urllib.HttpTransport_urllib,)),
 
151
                             _transport=_urllib.HttpTransport_urllib,)),
116
152
        ]
117
153
    if tests.HTTPSServerFeature.available():
118
154
        activity_scenarios.append(
119
155
            ('urllib,https', dict(_activity_server=ActivityHTTPSServer,
120
 
                                _transport=_urllib.HttpTransport_urllib,)),)
 
156
                                  _transport=_urllib.HttpTransport_urllib,)),)
121
157
    if features.pycurl.available():
122
158
        activity_scenarios.append(
123
159
            ('pycurl,http', dict(_activity_server=ActivityHTTPServer,
124
 
                                _transport=PyCurlTransport,)),)
 
160
                                 _transport=PyCurlTransport,)),)
125
161
        if tests.HTTPSServerFeature.available():
126
162
            from bzrlib.tests import (
127
163
                ssl_certs,
139
175
 
140
176
            activity_scenarios.append(
141
177
                ('pycurl,https', dict(_activity_server=ActivityHTTPSServer,
142
 
                                    _transport=HTTPS_pycurl_transport,)),)
143
 
    return activity_scenarios
 
178
                                      _transport=HTTPS_pycurl_transport,)),)
 
179
 
 
180
    tpact_scenarios = tests.multiply_scenarios(activity_scenarios,
 
181
                                               protocol_scenarios)
 
182
    tests.multiply_tests(tpact_tests, tpact_scenarios, result)
 
183
 
 
184
    # No parametrization for the remaining tests
 
185
    result.addTests(remaining_tests)
 
186
 
 
187
    return result
144
188
 
145
189
 
146
190
class FakeManager(object):
179
223
        self._sock.bind(('127.0.0.1', 0))
180
224
        self.host, self.port = self._sock.getsockname()
181
225
        self._ready = threading.Event()
182
 
        self._thread = test_server.TestThread(
183
 
            sync_event=self._ready, target=self._accept_read_and_reply)
 
226
        self._thread = threading.Thread(target=self._accept_read_and_reply)
 
227
        self._thread.setDaemon(True)
184
228
        self._thread.start()
185
 
        if 'threads' in tests.selftest_debug_flags:
186
 
            sys.stderr.write('Thread started: %s\n' % (self._thread.ident,))
187
 
        self._ready.wait()
 
229
        self._ready.wait(5)
188
230
 
189
231
    def _accept_read_and_reply(self):
190
232
        self._sock.listen(1)
191
233
        self._ready.set()
192
 
        conn, address = self._sock.accept()
193
 
        if self._expect_body_tail is not None:
 
234
        self._sock.settimeout(5)
 
235
        try:
 
236
            conn, address = self._sock.accept()
 
237
            # On win32, the accepted connection will be non-blocking to start
 
238
            # with because we're using settimeout.
 
239
            conn.setblocking(True)
194
240
            while not self.received_bytes.endswith(self._expect_body_tail):
195
241
                self.received_bytes += conn.recv(4096)
196
242
            conn.sendall('HTTP/1.1 200 OK\r\n')
197
 
        try:
 
243
        except socket.timeout:
 
244
            # Make sure the client isn't stuck waiting for us to e.g. accept.
198
245
            self._sock.close()
199
246
        except socket.error:
200
247
            # The client may have already closed the socket.
202
249
 
203
250
    def stop_server(self):
204
251
        try:
205
 
            # Issue a fake connection to wake up the server and allow it to
206
 
            # finish quickly
207
 
            fake_conn = osutils.connect_socket((self.host, self.port))
208
 
            fake_conn.close()
 
252
            self._sock.close()
209
253
        except socket.error:
210
254
            # We might have already closed it.  We don't care.
211
255
            pass
212
256
        self.host = None
213
257
        self.port = None
214
 
        self._thread.join()
215
 
        if 'threads' in tests.selftest_debug_flags:
216
 
            sys.stderr.write('Thread  joined: %s\n' % (self._thread.ident,))
217
258
 
218
259
 
219
260
class TestAuthHeader(tests.TestCase):
263
304
 
264
305
            protocol_version = 'HTTP/0.1'
265
306
 
266
 
        self.assertRaises(httplib.UnknownProtocol,
267
 
                          http_server.HttpServer, BogusRequestHandler)
 
307
        server = http_server.HttpServer(BogusRequestHandler)
 
308
        try:
 
309
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
 
310
        except:
 
311
            server.stop_server()
 
312
            self.fail('HTTP Server creation did not raise UnknownProtocol')
268
313
 
269
314
    def test_force_invalid_protocol(self):
270
 
        self.assertRaises(httplib.UnknownProtocol,
271
 
                          http_server.HttpServer, protocol_version='HTTP/0.1')
 
315
        server = http_server.HttpServer(protocol_version='HTTP/0.1')
 
316
        try:
 
317
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
 
318
        except:
 
319
            server.stop_server()
 
320
            self.fail('HTTP Server creation did not raise UnknownProtocol')
272
321
 
273
322
    def test_server_start_and_stop(self):
274
323
        server = http_server.HttpServer()
275
 
        self.addCleanup(server.stop_server)
276
324
        server.start_server()
277
 
        self.assertTrue(server.server is not None)
278
 
        self.assertTrue(server.server.serving is not None)
279
 
        self.assertTrue(server.server.serving)
 
325
        try:
 
326
            self.assertTrue(server._http_running)
 
327
        finally:
 
328
            server.stop_server()
 
329
        self.assertFalse(server._http_running)
280
330
 
281
331
    def test_create_http_server_one_zero(self):
282
332
        class RequestHandlerOneZero(http_server.TestingHTTPRequestHandler):
285
335
 
286
336
        server = http_server.HttpServer(RequestHandlerOneZero)
287
337
        self.start_server(server)
288
 
        self.assertIsInstance(server.server, http_server.TestingHTTPServer)
 
338
        self.assertIsInstance(server._httpd, http_server.TestingHTTPServer)
289
339
 
290
340
    def test_create_http_server_one_one(self):
291
341
        class RequestHandlerOneOne(http_server.TestingHTTPRequestHandler):
294
344
 
295
345
        server = http_server.HttpServer(RequestHandlerOneOne)
296
346
        self.start_server(server)
297
 
        self.assertIsInstance(server.server,
 
347
        self.assertIsInstance(server._httpd,
298
348
                              http_server.TestingThreadingHTTPServer)
299
349
 
300
350
    def test_create_http_server_force_one_one(self):
305
355
        server = http_server.HttpServer(RequestHandlerOneZero,
306
356
                                        protocol_version='HTTP/1.1')
307
357
        self.start_server(server)
308
 
        self.assertIsInstance(server.server,
 
358
        self.assertIsInstance(server._httpd,
309
359
                              http_server.TestingThreadingHTTPServer)
310
360
 
311
361
    def test_create_http_server_force_one_zero(self):
316
366
        server = http_server.HttpServer(RequestHandlerOneOne,
317
367
                                        protocol_version='HTTP/1.0')
318
368
        self.start_server(server)
319
 
        self.assertIsInstance(server.server,
 
369
        self.assertIsInstance(server._httpd,
320
370
                              http_server.TestingHTTPServer)
321
371
 
322
372
 
351
401
class TestHttpTransportUrls(tests.TestCase):
352
402
    """Test the http urls."""
353
403
 
354
 
    scenarios = vary_by_http_client_implementation()
355
 
 
356
404
    def test_abs_url(self):
357
405
        """Construction of absolute http URLs"""
358
 
        t = self._transport('http://example.com/bzr/bzr.dev/')
 
406
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
359
407
        eq = self.assertEqualDiff
360
 
        eq(t.abspath('.'), 'http://example.com/bzr/bzr.dev')
361
 
        eq(t.abspath('foo/bar'), 'http://example.com/bzr/bzr.dev/foo/bar')
362
 
        eq(t.abspath('.bzr'), 'http://example.com/bzr/bzr.dev/.bzr')
 
408
        eq(t.abspath('.'), 'http://bazaar-vcs.org/bzr/bzr.dev')
 
409
        eq(t.abspath('foo/bar'), 'http://bazaar-vcs.org/bzr/bzr.dev/foo/bar')
 
410
        eq(t.abspath('.bzr'), 'http://bazaar-vcs.org/bzr/bzr.dev/.bzr')
363
411
        eq(t.abspath('.bzr/1//2/./3'),
364
 
           'http://example.com/bzr/bzr.dev/.bzr/1/2/3')
 
412
           'http://bazaar-vcs.org/bzr/bzr.dev/.bzr/1/2/3')
365
413
 
366
414
    def test_invalid_http_urls(self):
367
415
        """Trap invalid construction of urls"""
368
 
        self._transport('http://example.com/bzr/bzr.dev/')
 
416
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
369
417
        self.assertRaises(errors.InvalidURL,
370
418
                          self._transport,
371
 
                          'http://http://example.com/bzr/bzr.dev/')
 
419
                          'http://http://bazaar-vcs.org/bzr/bzr.dev/')
372
420
 
373
421
    def test_http_root_urls(self):
374
422
        """Construction of URLs from server root"""
375
 
        t = self._transport('http://example.com/')
 
423
        t = self._transport('http://bzr.ozlabs.org/')
376
424
        eq = self.assertEqualDiff
377
425
        eq(t.abspath('.bzr/tree-version'),
378
 
           'http://example.com/.bzr/tree-version')
 
426
           'http://bzr.ozlabs.org/.bzr/tree-version')
379
427
 
380
428
    def test_http_impl_urls(self):
381
429
        """There are servers which ask for particular clients to connect"""
383
431
        server.start_server()
384
432
        try:
385
433
            url = server.get_url()
386
 
            self.assertTrue(url.startswith('%s://' % self._url_protocol))
 
434
            self.assertTrue(url.startswith('%s://' % self._qualified_prefix))
387
435
        finally:
388
436
            server.stop_server()
389
437
 
427
475
class TestHTTPConnections(http_utils.TestCaseWithWebserver):
428
476
    """Test the http connections."""
429
477
 
430
 
    scenarios = multiply_scenarios(
431
 
        vary_by_http_client_implementation(), 
432
 
        vary_by_http_protocol_version(),
433
 
        )
434
 
 
435
478
    def setUp(self):
436
479
        http_utils.TestCaseWithWebserver.setUp(self)
437
480
        self.build_tree(['foo/', 'foo/bar'], line_endings='binary',
439
482
 
440
483
    def test_http_has(self):
441
484
        server = self.get_readonly_server()
442
 
        t = self.get_readonly_transport()
 
485
        t = self._transport(server.get_url())
443
486
        self.assertEqual(t.has('foo/bar'), True)
444
487
        self.assertEqual(len(server.logs), 1)
445
488
        self.assertContainsRe(server.logs[0],
447
490
 
448
491
    def test_http_has_not_found(self):
449
492
        server = self.get_readonly_server()
450
 
        t = self.get_readonly_transport()
 
493
        t = self._transport(server.get_url())
451
494
        self.assertEqual(t.has('not-found'), False)
452
495
        self.assertContainsRe(server.logs[1],
453
496
            r'"HEAD /not-found HTTP/1.." 404 - "-" "bzr/')
454
497
 
455
498
    def test_http_get(self):
456
499
        server = self.get_readonly_server()
457
 
        t = self.get_readonly_transport()
 
500
        t = self._transport(server.get_url())
458
501
        fp = t.get('foo/bar')
459
502
        self.assertEqualDiff(
460
503
            fp.read(),
482
525
class TestHttpTransportRegistration(tests.TestCase):
483
526
    """Test registrations of various http implementations"""
484
527
 
485
 
    scenarios = vary_by_http_client_implementation()
486
 
 
487
528
    def test_http_registered(self):
488
 
        t = transport.get_transport('%s://foo.com/' % self._url_protocol)
 
529
        t = transport.get_transport('%s://foo.com/' % self._qualified_prefix)
489
530
        self.assertIsInstance(t, transport.Transport)
490
531
        self.assertIsInstance(t, self._transport)
491
532
 
492
533
 
493
534
class TestPost(tests.TestCase):
494
535
 
495
 
    scenarios = multiply_scenarios(
496
 
        vary_by_http_client_implementation(), 
497
 
        vary_by_http_protocol_version(),
498
 
        )
499
 
 
500
536
    def test_post_body_is_received(self):
501
537
        server = RecordingServer(expect_body_tail='end-of-body',
502
 
                                 scheme=self._url_protocol)
 
538
            scheme=self._qualified_prefix)
503
539
        self.start_server(server)
504
540
        url = server.get_url()
505
 
        # FIXME: needs a cleanup -- vila 20100611
506
 
        http_transport = transport.get_transport(url)
 
541
        http_transport = self._transport(url)
507
542
        code, response = http_transport._post('abc def end-of-body')
508
543
        self.assertTrue(
509
544
            server.received_bytes.startswith('POST /.bzr/smart HTTP/1.'))
510
545
        self.assertTrue('content-length: 19\r' in server.received_bytes.lower())
511
 
        self.assertTrue('content-type: application/octet-stream\r'
512
 
                        in server.received_bytes.lower())
513
546
        # The transport should not be assuming that the server can accept
514
547
        # chunked encoding the first time it connects, because HTTP/1.1, so we
515
548
        # check for the literal string.
551
584
    Daughter classes are expected to override _req_handler_class
552
585
    """
553
586
 
554
 
    scenarios = multiply_scenarios(
555
 
        vary_by_http_client_implementation(), 
556
 
        vary_by_http_protocol_version(),
557
 
        )
558
 
 
559
587
    # Provide a useful default
560
588
    _req_handler_class = http_server.TestingHTTPRequestHandler
561
589
 
562
590
    def create_transport_readonly_server(self):
563
 
        server = http_server.HttpServer(self._req_handler_class,
564
 
                                        protocol_version=self._protocol_version)
565
 
        server._url_protocol = self._url_protocol
566
 
        return server
 
591
        return http_server.HttpServer(self._req_handler_class,
 
592
                                      protocol_version=self._protocol_version)
567
593
 
568
594
    def _testing_pycurl(self):
569
595
        # TODO: This is duplicated for lots of the classes in this file
574
600
class WallRequestHandler(http_server.TestingHTTPRequestHandler):
575
601
    """Whatever request comes in, close the connection"""
576
602
 
577
 
    def _handle_one_request(self):
 
603
    def handle_one_request(self):
578
604
        """Handle a single HTTP request, by abruptly closing the connection"""
579
605
        self.close_connection = 1
580
606
 
585
611
    _req_handler_class = WallRequestHandler
586
612
 
587
613
    def test_http_has(self):
588
 
        t = self.get_readonly_transport()
 
614
        server = self.get_readonly_server()
 
615
        t = self._transport(server.get_url())
589
616
        # Unfortunately httplib (see HTTPResponse._read_status
590
617
        # for details) make no distinction between a closed
591
618
        # socket and badly formatted status line, so we can't
597
624
                          t.has, 'foo/bar')
598
625
 
599
626
    def test_http_get(self):
600
 
        t = self.get_readonly_transport()
 
627
        server = self.get_readonly_server()
 
628
        t = self._transport(server.get_url())
601
629
        self.assertRaises((errors.ConnectionError, errors.ConnectionReset,
602
630
                           errors.InvalidHttpResponse),
603
631
                          t.get, 'foo/bar')
620
648
    _req_handler_class = BadStatusRequestHandler
621
649
 
622
650
    def test_http_has(self):
623
 
        t = self.get_readonly_transport()
 
651
        server = self.get_readonly_server()
 
652
        t = self._transport(server.get_url())
624
653
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
625
654
 
626
655
    def test_http_get(self):
627
 
        t = self.get_readonly_transport()
 
656
        server = self.get_readonly_server()
 
657
        t = self._transport(server.get_url())
628
658
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
629
659
 
630
660
 
635
665
        """Fakes handling a single HTTP request, returns a bad status"""
636
666
        ignored = http_server.TestingHTTPRequestHandler.parse_request(self)
637
667
        self.wfile.write("Invalid status line\r\n")
638
 
        # If we don't close the connection pycurl will hang. Since this is a
639
 
        # stress test we don't *have* to respect the protocol, but we don't
640
 
        # have to sabotage it too much either.
641
 
        self.close_connection = True
642
668
        return False
643
669
 
644
670
 
650
676
 
651
677
    _req_handler_class = InvalidStatusRequestHandler
652
678
 
 
679
    def test_http_has(self):
 
680
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
 
681
            raise tests.KnownFailure(
 
682
                'pycurl hangs if the server send back garbage')
 
683
        super(TestInvalidStatusServer, self).test_http_has()
 
684
 
 
685
    def test_http_get(self):
 
686
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
 
687
            raise tests.KnownFailure(
 
688
                'pycurl hangs if the server send back garbage')
 
689
        super(TestInvalidStatusServer, self).test_http_get()
 
690
 
653
691
 
654
692
class BadProtocolRequestHandler(http_server.TestingHTTPRequestHandler):
655
693
    """Whatever request comes in, returns a bad protocol version"""
677
715
        super(TestBadProtocolServer, self).setUp()
678
716
 
679
717
    def test_http_has(self):
680
 
        t = self.get_readonly_transport()
 
718
        server = self.get_readonly_server()
 
719
        t = self._transport(server.get_url())
681
720
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
682
721
 
683
722
    def test_http_get(self):
684
 
        t = self.get_readonly_transport()
 
723
        server = self.get_readonly_server()
 
724
        t = self._transport(server.get_url())
685
725
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
686
726
 
687
727
 
701
741
    _req_handler_class = ForbiddenRequestHandler
702
742
 
703
743
    def test_http_has(self):
704
 
        t = self.get_readonly_transport()
 
744
        server = self.get_readonly_server()
 
745
        t = self._transport(server.get_url())
705
746
        self.assertRaises(errors.TransportError, t.has, 'foo/bar')
706
747
 
707
748
    def test_http_get(self):
708
 
        t = self.get_readonly_transport()
 
749
        server = self.get_readonly_server()
 
750
        t = self._transport(server.get_url())
709
751
        self.assertRaises(errors.TransportError, t.get, 'foo/bar')
710
752
 
711
753
 
750
792
        self.build_tree_contents([('a', '0123456789')],)
751
793
 
752
794
    def test_readv(self):
753
 
        t = self.get_readonly_transport()
 
795
        server = self.get_readonly_server()
 
796
        t = self._transport(server.get_url())
754
797
        l = list(t.readv('a', ((0, 1), (1, 1), (3, 2), (9, 1))))
755
798
        self.assertEqual(l[0], (0, '0'))
756
799
        self.assertEqual(l[1], (1, '1'))
758
801
        self.assertEqual(l[3], (9, '9'))
759
802
 
760
803
    def test_readv_out_of_order(self):
761
 
        t = self.get_readonly_transport()
 
804
        server = self.get_readonly_server()
 
805
        t = self._transport(server.get_url())
762
806
        l = list(t.readv('a', ((1, 1), (9, 1), (0, 1), (3, 2))))
763
807
        self.assertEqual(l[0], (1, '1'))
764
808
        self.assertEqual(l[1], (9, '9'))
766
810
        self.assertEqual(l[3], (3, '34'))
767
811
 
768
812
    def test_readv_invalid_ranges(self):
769
 
        t = self.get_readonly_transport()
 
813
        server = self.get_readonly_server()
 
814
        t = self._transport(server.get_url())
770
815
 
771
816
        # This is intentionally reading off the end of the file
772
817
        # since we are sure that it cannot get there
780
825
 
781
826
    def test_readv_multiple_get_requests(self):
782
827
        server = self.get_readonly_server()
783
 
        t = self.get_readonly_transport()
 
828
        t = self._transport(server.get_url())
784
829
        # force transport to issue multiple requests
785
830
        t._max_readv_combine = 1
786
831
        t._max_get_ranges = 1
794
839
 
795
840
    def test_readv_get_max_size(self):
796
841
        server = self.get_readonly_server()
797
 
        t = self.get_readonly_transport()
 
842
        t = self._transport(server.get_url())
798
843
        # force transport to issue multiple requests by limiting the number of
799
844
        # bytes by request. Note that this apply to coalesced offsets only, a
800
845
        # single range will keep its size even if bigger than the limit.
809
854
 
810
855
    def test_complete_readv_leave_pipe_clean(self):
811
856
        server = self.get_readonly_server()
812
 
        t = self.get_readonly_transport()
 
857
        t = self._transport(server.get_url())
813
858
        # force transport to issue multiple requests
814
859
        t._get_max_size = 2
815
 
        list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
 
860
        l = list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
816
861
        # The server should have issued 3 requests
817
862
        self.assertEqual(3, server.GET_request_nb)
818
863
        self.assertEqual('0123456789', t.get_bytes('a'))
820
865
 
821
866
    def test_incomplete_readv_leave_pipe_clean(self):
822
867
        server = self.get_readonly_server()
823
 
        t = self.get_readonly_transport()
 
868
        t = self._transport(server.get_url())
824
869
        # force transport to issue multiple requests
825
870
        t._get_max_size = 2
826
871
        # Don't collapse readv results into a list so that we leave unread
895
940
    def get_multiple_ranges(self, file, file_size, ranges):
896
941
        self.send_response(206)
897
942
        self.send_header('Accept-Ranges', 'bytes')
898
 
        # XXX: this is strange; the 'random' name below seems undefined and
899
 
        # yet the tests pass -- mbp 2010-10-11 bug 658773
900
943
        boundary = "%d" % random.randint(0,0x7FFFFFFF)
901
944
        self.send_header("Content-Type",
902
945
                         "multipart/byteranges; boundary=%s" % boundary)
964
1007
                return
965
1008
            self.send_range_content(file, start, end - start + 1)
966
1009
            cur += 1
967
 
        # Final boundary
 
1010
        # No final boundary
968
1011
        self.wfile.write(boundary_line)
969
1012
 
970
1013
 
978
1021
 
979
1022
    def test_readv_with_short_reads(self):
980
1023
        server = self.get_readonly_server()
981
 
        t = self.get_readonly_transport()
 
1024
        t = self._transport(server.get_url())
982
1025
        # Force separate ranges for each offset
983
1026
        t._bytes_to_read_before_seek = 0
984
1027
        ireadv = iter(t.readv('a', ((0, 1), (2, 1), (4, 2), (9, 1))))
999
1042
        # that mode
1000
1043
        self.assertEqual('single', t._range_hint)
1001
1044
 
1002
 
 
1003
1045
class LimitedRangeRequestHandler(http_server.TestingHTTPRequestHandler):
1004
1046
    """Errors out when range specifiers exceed the limit"""
1005
1047
 
1029
1071
class TestLimitedRangeRequestServer(http_utils.TestCaseWithWebserver):
1030
1072
    """Tests readv requests against a server erroring out on too much ranges."""
1031
1073
 
1032
 
    scenarios = multiply_scenarios(
1033
 
        vary_by_http_client_implementation(), 
1034
 
        vary_by_http_protocol_version(),
1035
 
        )
1036
 
 
1037
1074
    # Requests with more range specifiers will error out
1038
1075
    range_limit = 3
1039
1076
 
1041
1078
        return LimitedRangeHTTPServer(range_limit=self.range_limit,
1042
1079
                                      protocol_version=self._protocol_version)
1043
1080
 
 
1081
    def get_transport(self):
 
1082
        return self._transport(self.get_readonly_server().get_url())
 
1083
 
1044
1084
    def setUp(self):
1045
1085
        http_utils.TestCaseWithWebserver.setUp(self)
1046
1086
        # We need to manipulate ranges that correspond to real chunks in the
1050
1090
        self.build_tree_contents([('a', content)],)
1051
1091
 
1052
1092
    def test_few_ranges(self):
1053
 
        t = self.get_readonly_transport()
 
1093
        t = self.get_transport()
1054
1094
        l = list(t.readv('a', ((0, 4), (1024, 4), )))
1055
1095
        self.assertEqual(l[0], (0, '0000'))
1056
1096
        self.assertEqual(l[1], (1024, '0001'))
1057
1097
        self.assertEqual(1, self.get_readonly_server().GET_request_nb)
1058
1098
 
1059
1099
    def test_more_ranges(self):
1060
 
        t = self.get_readonly_transport()
 
1100
        t = self.get_transport()
1061
1101
        l = list(t.readv('a', ((0, 4), (1024, 4), (4096, 4), (8192, 4))))
1062
1102
        self.assertEqual(l[0], (0, '0000'))
1063
1103
        self.assertEqual(l[1], (1024, '0001'))
1074
1114
    Only the urllib implementation is tested here.
1075
1115
    """
1076
1116
 
 
1117
    def setUp(self):
 
1118
        tests.TestCase.setUp(self)
 
1119
        self._old_env = {}
 
1120
 
 
1121
    def tearDown(self):
 
1122
        self._restore_env()
 
1123
        tests.TestCase.tearDown(self)
 
1124
 
 
1125
    def _install_env(self, env):
 
1126
        for name, value in env.iteritems():
 
1127
            self._old_env[name] = osutils.set_or_unset_env(name, value)
 
1128
 
 
1129
    def _restore_env(self):
 
1130
        for name, value in self._old_env.iteritems():
 
1131
            osutils.set_or_unset_env(name, value)
 
1132
 
1077
1133
    def _proxied_request(self):
1078
1134
        handler = _urllib2_wrappers.ProxyHandler()
1079
1135
        request = _urllib2_wrappers.Request('GET','http://baz/buzzle')
1080
1136
        handler.set_proxy(request, 'http')
1081
1137
        return request
1082
1138
 
1083
 
    def assertEvaluateProxyBypass(self, expected, host, no_proxy):
1084
 
        handler = _urllib2_wrappers.ProxyHandler()
1085
 
        self.assertEquals(expected,
1086
 
                          handler.evaluate_proxy_bypass(host, no_proxy))
1087
 
 
1088
1139
    def test_empty_user(self):
1089
 
        self.overrideEnv('http_proxy', 'http://bar.com')
 
1140
        self._install_env({'http_proxy': 'http://bar.com'})
1090
1141
        request = self._proxied_request()
1091
1142
        self.assertFalse(request.headers.has_key('Proxy-authorization'))
1092
1143
 
1093
1144
    def test_invalid_proxy(self):
1094
1145
        """A proxy env variable without scheme"""
1095
 
        self.overrideEnv('http_proxy', 'host:1234')
 
1146
        self._install_env({'http_proxy': 'host:1234'})
1096
1147
        self.assertRaises(errors.InvalidURL, self._proxied_request)
1097
1148
 
1098
 
    def test_evaluate_proxy_bypass_true(self):
1099
 
        """The host is not proxied"""
1100
 
        self.assertEvaluateProxyBypass(True, 'example.com', 'example.com')
1101
 
        self.assertEvaluateProxyBypass(True, 'bzr.example.com', '*example.com')
1102
 
 
1103
 
    def test_evaluate_proxy_bypass_false(self):
1104
 
        """The host is proxied"""
1105
 
        self.assertEvaluateProxyBypass(False, 'bzr.example.com', None)
1106
 
 
1107
 
    def test_evaluate_proxy_bypass_unknown(self):
1108
 
        """The host is not explicitly proxied"""
1109
 
        self.assertEvaluateProxyBypass(None, 'example.com', 'not.example.com')
1110
 
        self.assertEvaluateProxyBypass(None, 'bzr.example.com', 'example.com')
1111
 
 
1112
 
    def test_evaluate_proxy_bypass_empty_entries(self):
1113
 
        """Ignore empty entries"""
1114
 
        self.assertEvaluateProxyBypass(None, 'example.com', '')
1115
 
        self.assertEvaluateProxyBypass(None, 'example.com', ',')
1116
 
        self.assertEvaluateProxyBypass(None, 'example.com', 'foo,,bar')
1117
 
 
1118
1149
 
1119
1150
class TestProxyHttpServer(http_utils.TestCaseWithTwoWebservers):
1120
1151
    """Tests proxy server.
1125
1156
    to the file names).
1126
1157
    """
1127
1158
 
1128
 
    scenarios = multiply_scenarios(
1129
 
        vary_by_http_client_implementation(), 
1130
 
        vary_by_http_protocol_version(),
1131
 
        )
1132
 
 
1133
1159
    # FIXME: We don't have an https server available, so we don't
1134
 
    # test https connections. --vila toolongago
 
1160
    # test https connections.
1135
1161
 
1136
1162
    def setUp(self):
1137
1163
        super(TestProxyHttpServer, self).setUp()
1138
 
        self.transport_secondary_server = http_utils.ProxyServer
1139
1164
        self.build_tree_contents([('foo', 'contents of foo\n'),
1140
1165
                                  ('foo-proxied', 'proxied contents of foo\n')])
1141
1166
        # Let's setup some attributes for tests
1142
 
        server = self.get_readonly_server()
1143
 
        self.server_host_port = '%s:%d' % (server.host, server.port)
 
1167
        self.server = self.get_readonly_server()
 
1168
        self.proxy_address = '%s:%d' % (self.server.host, self.server.port)
1144
1169
        if self._testing_pycurl():
1145
1170
            # Oh my ! pycurl does not check for the port as part of
1146
1171
            # no_proxy :-( So we just test the host part
1147
 
            self.no_proxy_host = server.host
 
1172
            self.no_proxy_host = self.server.host
1148
1173
        else:
1149
 
            self.no_proxy_host = self.server_host_port
 
1174
            self.no_proxy_host = self.proxy_address
1150
1175
        # The secondary server is the proxy
1151
 
        self.proxy_url = self.get_secondary_url()
 
1176
        self.proxy = self.get_secondary_server()
 
1177
        self.proxy_url = self.proxy.get_url()
 
1178
        self._old_env = {}
1152
1179
 
1153
1180
    def _testing_pycurl(self):
1154
1181
        # TODO: This is duplicated for lots of the classes in this file
1155
1182
        return (features.pycurl.available()
1156
1183
                and self._transport == PyCurlTransport)
1157
1184
 
1158
 
    def assertProxied(self):
1159
 
        t = self.get_readonly_transport()
1160
 
        self.assertEqual('proxied contents of foo\n', t.get('foo').read())
1161
 
 
1162
 
    def assertNotProxied(self):
1163
 
        t = self.get_readonly_transport()
1164
 
        self.assertEqual('contents of foo\n', t.get('foo').read())
 
1185
    def create_transport_secondary_server(self):
 
1186
        """Creates an http server that will serve files with
 
1187
        '-proxied' appended to their names.
 
1188
        """
 
1189
        return http_utils.ProxyServer(protocol_version=self._protocol_version)
 
1190
 
 
1191
    def _install_env(self, env):
 
1192
        for name, value in env.iteritems():
 
1193
            self._old_env[name] = osutils.set_or_unset_env(name, value)
 
1194
 
 
1195
    def _restore_env(self):
 
1196
        for name, value in self._old_env.iteritems():
 
1197
            osutils.set_or_unset_env(name, value)
 
1198
 
 
1199
    def proxied_in_env(self, env):
 
1200
        self._install_env(env)
 
1201
        url = self.server.get_url()
 
1202
        t = self._transport(url)
 
1203
        try:
 
1204
            self.assertEqual('proxied contents of foo\n', t.get('foo').read())
 
1205
        finally:
 
1206
            self._restore_env()
 
1207
 
 
1208
    def not_proxied_in_env(self, env):
 
1209
        self._install_env(env)
 
1210
        url = self.server.get_url()
 
1211
        t = self._transport(url)
 
1212
        try:
 
1213
            self.assertEqual('contents of foo\n', t.get('foo').read())
 
1214
        finally:
 
1215
            self._restore_env()
1165
1216
 
1166
1217
    def test_http_proxy(self):
1167
 
        self.overrideEnv('http_proxy', self.proxy_url)
1168
 
        self.assertProxied()
 
1218
        self.proxied_in_env({'http_proxy': self.proxy_url})
1169
1219
 
1170
1220
    def test_HTTP_PROXY(self):
1171
1221
        if self._testing_pycurl():
1174
1224
            # about. Should we ?)
1175
1225
            raise tests.TestNotApplicable(
1176
1226
                'pycurl does not check HTTP_PROXY for security reasons')
1177
 
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
1178
 
        self.assertProxied()
 
1227
        self.proxied_in_env({'HTTP_PROXY': self.proxy_url})
1179
1228
 
1180
1229
    def test_all_proxy(self):
1181
 
        self.overrideEnv('all_proxy', self.proxy_url)
1182
 
        self.assertProxied()
 
1230
        self.proxied_in_env({'all_proxy': self.proxy_url})
1183
1231
 
1184
1232
    def test_ALL_PROXY(self):
1185
 
        self.overrideEnv('ALL_PROXY', self.proxy_url)
1186
 
        self.assertProxied()
 
1233
        self.proxied_in_env({'ALL_PROXY': self.proxy_url})
1187
1234
 
1188
1235
    def test_http_proxy_with_no_proxy(self):
1189
 
        self.overrideEnv('no_proxy', self.no_proxy_host)
1190
 
        self.overrideEnv('http_proxy', self.proxy_url)
1191
 
        self.assertNotProxied()
 
1236
        self.not_proxied_in_env({'http_proxy': self.proxy_url,
 
1237
                                 'no_proxy': self.no_proxy_host})
1192
1238
 
1193
1239
    def test_HTTP_PROXY_with_NO_PROXY(self):
1194
1240
        if self._testing_pycurl():
1195
1241
            raise tests.TestNotApplicable(
1196
1242
                'pycurl does not check HTTP_PROXY for security reasons')
1197
 
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
1198
 
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
1199
 
        self.assertNotProxied()
 
1243
        self.not_proxied_in_env({'HTTP_PROXY': self.proxy_url,
 
1244
                                 'NO_PROXY': self.no_proxy_host})
1200
1245
 
1201
1246
    def test_all_proxy_with_no_proxy(self):
1202
 
        self.overrideEnv('no_proxy', self.no_proxy_host)
1203
 
        self.overrideEnv('all_proxy', self.proxy_url)
1204
 
        self.assertNotProxied()
 
1247
        self.not_proxied_in_env({'all_proxy': self.proxy_url,
 
1248
                                 'no_proxy': self.no_proxy_host})
1205
1249
 
1206
1250
    def test_ALL_PROXY_with_NO_PROXY(self):
1207
 
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
1208
 
        self.overrideEnv('ALL_PROXY', self.proxy_url)
1209
 
        self.assertNotProxied()
 
1251
        self.not_proxied_in_env({'ALL_PROXY': self.proxy_url,
 
1252
                                 'NO_PROXY': self.no_proxy_host})
1210
1253
 
1211
1254
    def test_http_proxy_without_scheme(self):
1212
 
        self.overrideEnv('http_proxy', self.server_host_port)
1213
1255
        if self._testing_pycurl():
1214
1256
            # pycurl *ignores* invalid proxy env variables. If that ever change
1215
1257
            # in the future, this test will fail indicating that pycurl do not
1216
1258
            # ignore anymore such variables.
1217
 
            self.assertNotProxied()
 
1259
            self.not_proxied_in_env({'http_proxy': self.proxy_address})
1218
1260
        else:
1219
 
            self.assertRaises(errors.InvalidURL, self.assertProxied)
 
1261
            self.assertRaises(errors.InvalidURL,
 
1262
                              self.proxied_in_env,
 
1263
                              {'http_proxy': self.proxy_address})
1220
1264
 
1221
1265
 
1222
1266
class TestRanges(http_utils.TestCaseWithWebserver):
1223
1267
    """Test the Range header in GET methods."""
1224
1268
 
1225
 
    scenarios = multiply_scenarios(
1226
 
        vary_by_http_client_implementation(), 
1227
 
        vary_by_http_protocol_version(),
1228
 
        )
1229
 
 
1230
1269
    def setUp(self):
1231
1270
        http_utils.TestCaseWithWebserver.setUp(self)
1232
1271
        self.build_tree_contents([('a', '0123456789')],)
 
1272
        server = self.get_readonly_server()
 
1273
        self.transport = self._transport(server.get_url())
1233
1274
 
1234
1275
    def create_transport_readonly_server(self):
1235
1276
        return http_server.HttpServer(protocol_version=self._protocol_version)
1236
1277
 
1237
1278
    def _file_contents(self, relpath, ranges):
1238
 
        t = self.get_readonly_transport()
1239
1279
        offsets = [ (start, end - start + 1) for start, end in ranges]
1240
 
        coalesce = t._coalesce_offsets
 
1280
        coalesce = self.transport._coalesce_offsets
1241
1281
        coalesced = list(coalesce(offsets, limit=0, fudge_factor=0))
1242
 
        code, data = t._get(relpath, coalesced)
 
1282
        code, data = self.transport._get(relpath, coalesced)
1243
1283
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1244
1284
        for start, end in ranges:
1245
1285
            data.seek(start)
1246
1286
            yield data.read(end - start + 1)
1247
1287
 
1248
1288
    def _file_tail(self, relpath, tail_amount):
1249
 
        t = self.get_readonly_transport()
1250
 
        code, data = t._get(relpath, [], tail_amount)
 
1289
        code, data = self.transport._get(relpath, [], tail_amount)
1251
1290
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1252
1291
        data.seek(-tail_amount, 2)
1253
1292
        return data.read(tail_amount)
1272
1311
class TestHTTPRedirections(http_utils.TestCaseWithRedirectedWebserver):
1273
1312
    """Test redirection between http servers."""
1274
1313
 
1275
 
    scenarios = multiply_scenarios(
1276
 
        vary_by_http_client_implementation(), 
1277
 
        vary_by_http_protocol_version(),
1278
 
        )
 
1314
    def create_transport_secondary_server(self):
 
1315
        """Create the secondary server redirecting to the primary server"""
 
1316
        new = self.get_readonly_server()
 
1317
 
 
1318
        redirecting = http_utils.HTTPServerRedirecting(
 
1319
            protocol_version=self._protocol_version)
 
1320
        redirecting.redirect_to(new.host, new.port)
 
1321
        return redirecting
1279
1322
 
1280
1323
    def setUp(self):
1281
1324
        super(TestHTTPRedirections, self).setUp()
1283
1326
                                  ('bundle',
1284
1327
                                  '# Bazaar revision bundle v0.9\n#\n')
1285
1328
                                  ],)
 
1329
        # The requests to the old server will be redirected to the new server
 
1330
        self.old_transport = self._transport(self.old_server.get_url())
1286
1331
 
1287
1332
    def test_redirected(self):
1288
 
        self.assertRaises(errors.RedirectRequested,
1289
 
                          self.get_old_transport().get, 'a')
1290
 
        self.assertEqual('0123456789', self.get_new_transport().get('a').read())
 
1333
        self.assertRaises(errors.RedirectRequested, self.old_transport.get, 'a')
 
1334
        t = self._transport(self.new_server.get_url())
 
1335
        self.assertEqual('0123456789', t.get('a').read())
 
1336
 
 
1337
    def test_read_redirected_bundle_from_url(self):
 
1338
        from bzrlib.bundle import read_bundle_from_url
 
1339
        url = self.old_transport.abspath('bundle')
 
1340
        bundle = self.applyDeprecated(deprecated_in((1, 12, 0)),
 
1341
                read_bundle_from_url, url)
 
1342
        # If read_bundle_from_url was successful we get an empty bundle
 
1343
        self.assertEqual([], bundle.revisions)
1291
1344
 
1292
1345
 
1293
1346
class RedirectedRequest(_urllib2_wrappers.Request):
1310
1363
    test.overrideAttr(_urllib2_wrappers, 'Request', RedirectedRequest)
1311
1364
 
1312
1365
 
1313
 
def cleanup_http_redirection_connections(test):
1314
 
    # Some sockets are opened but never seen by _urllib, so we trap them at
1315
 
    # the _urllib2_wrappers level to be able to clean them up.
1316
 
    def socket_disconnect(sock):
1317
 
        try:
1318
 
            sock.shutdown(socket.SHUT_RDWR)
1319
 
            sock.close()
1320
 
        except socket.error:
1321
 
            pass
1322
 
    def connect(connection):
1323
 
        test.http_connect_orig(connection)
1324
 
        test.addCleanup(socket_disconnect, connection.sock)
1325
 
    test.http_connect_orig = test.overrideAttr(
1326
 
        _urllib2_wrappers.HTTPConnection, 'connect', connect)
1327
 
    def connect(connection):
1328
 
        test.https_connect_orig(connection)
1329
 
        test.addCleanup(socket_disconnect, connection.sock)
1330
 
    test.https_connect_orig = test.overrideAttr(
1331
 
        _urllib2_wrappers.HTTPSConnection, 'connect', connect)
1332
 
 
1333
 
 
1334
1366
class TestHTTPSilentRedirections(http_utils.TestCaseWithRedirectedWebserver):
1335
1367
    """Test redirections.
1336
1368
 
1345
1377
    -- vila 20070212
1346
1378
    """
1347
1379
 
1348
 
    scenarios = multiply_scenarios(
1349
 
        vary_by_http_client_implementation(), 
1350
 
        vary_by_http_protocol_version(),
1351
 
        )
1352
 
 
1353
1380
    def setUp(self):
1354
1381
        if (features.pycurl.available()
1355
1382
            and self._transport == PyCurlTransport):
1356
1383
            raise tests.TestNotApplicable(
1357
 
                "pycurl doesn't redirect silently anymore")
 
1384
                "pycurl doesn't redirect silently annymore")
1358
1385
        super(TestHTTPSilentRedirections, self).setUp()
1359
1386
        install_redirected_request(self)
1360
 
        cleanup_http_redirection_connections(self)
1361
1387
        self.build_tree_contents([('a','a'),
1362
1388
                                  ('1/',),
1363
1389
                                  ('1/a', 'redirected once'),
1371
1397
                                  ('5/a', 'redirected 5 times'),
1372
1398
                                  ],)
1373
1399
 
 
1400
        self.old_transport = self._transport(self.old_server.get_url())
 
1401
 
 
1402
    def create_transport_secondary_server(self):
 
1403
        """Create the secondary server, redirections are defined in the tests"""
 
1404
        return http_utils.HTTPServerRedirecting(
 
1405
            protocol_version=self._protocol_version)
 
1406
 
1374
1407
    def test_one_redirection(self):
1375
 
        t = self.get_old_transport()
1376
 
        req = RedirectedRequest('GET', t._remote_path('a'))
 
1408
        t = self.old_transport
 
1409
 
 
1410
        req = RedirectedRequest('GET', t.abspath('a'))
1377
1411
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1378
1412
                                       self.new_server.port)
1379
1413
        self.old_server.redirections = \
1380
1414
            [('(.*)', r'%s/1\1' % (new_prefix), 301),]
1381
 
        self.assertEqual('redirected once', t._perform(req).read())
 
1415
        self.assertEqual('redirected once',t._perform(req).read())
1382
1416
 
1383
1417
    def test_five_redirections(self):
1384
 
        t = self.get_old_transport()
1385
 
        req = RedirectedRequest('GET', t._remote_path('a'))
 
1418
        t = self.old_transport
 
1419
 
 
1420
        req = RedirectedRequest('GET', t.abspath('a'))
1386
1421
        old_prefix = 'http://%s:%s' % (self.old_server.host,
1387
1422
                                       self.old_server.port)
1388
1423
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1394
1429
            ('/4(.*)', r'%s/5\1' % (new_prefix), 301),
1395
1430
            ('(/[^/]+)', r'%s/1\1' % (old_prefix), 301),
1396
1431
            ]
1397
 
        self.assertEqual('redirected 5 times', t._perform(req).read())
 
1432
        self.assertEqual('redirected 5 times',t._perform(req).read())
1398
1433
 
1399
1434
 
1400
1435
class TestDoCatchRedirections(http_utils.TestCaseWithRedirectedWebserver):
1401
1436
    """Test transport.do_catching_redirections."""
1402
1437
 
1403
 
    scenarios = multiply_scenarios(
1404
 
        vary_by_http_client_implementation(), 
1405
 
        vary_by_http_protocol_version(),
1406
 
        )
1407
 
 
1408
1438
    def setUp(self):
1409
1439
        super(TestDoCatchRedirections, self).setUp()
1410
1440
        self.build_tree_contents([('a', '0123456789'),],)
1411
 
        cleanup_http_redirection_connections(self)
1412
 
 
1413
 
        self.old_transport = self.get_old_transport()
1414
 
 
1415
 
    def get_a(self, t):
1416
 
        return t.get('a')
 
1441
 
 
1442
        self.old_transport = self._transport(self.old_server.get_url())
 
1443
 
 
1444
    def get_a(self, transport):
 
1445
        return transport.get('a')
1417
1446
 
1418
1447
    def test_no_redirection(self):
1419
 
        t = self.get_new_transport()
 
1448
        t = self._transport(self.new_server.get_url())
1420
1449
 
1421
1450
        # We use None for redirected so that we fail if redirected
1422
1451
        self.assertEqual('0123456789',
1426
1455
    def test_one_redirection(self):
1427
1456
        self.redirections = 0
1428
1457
 
1429
 
        def redirected(t, exception, redirection_notice):
 
1458
        def redirected(transport, exception, redirection_notice):
1430
1459
            self.redirections += 1
1431
 
            redirected_t = t._redirected_to(exception.source, exception.target)
1432
 
            return redirected_t
 
1460
            dir, file = urlutils.split(exception.target)
 
1461
            return self._transport(dir)
1433
1462
 
1434
1463
        self.assertEqual('0123456789',
1435
1464
                         transport.do_catching_redirections(
1452
1481
class TestAuth(http_utils.TestCaseWithWebserver):
1453
1482
    """Test authentication scheme"""
1454
1483
 
1455
 
    scenarios = multiply_scenarios(
1456
 
        vary_by_http_client_implementation(),
1457
 
        vary_by_http_protocol_version(),
1458
 
        vary_by_http_auth_scheme(),
1459
 
        )
1460
 
 
1461
1484
    _auth_header = 'Authorization'
1462
1485
    _password_prompt_prefix = ''
1463
1486
    _username_prompt_prefix = ''
1471
1494
                                  ('b', 'contents of b\n'),])
1472
1495
 
1473
1496
    def create_transport_readonly_server(self):
1474
 
        server = self._auth_server(protocol_version=self._protocol_version)
1475
 
        server._url_protocol = self._url_protocol
1476
 
        return server
 
1497
        return self._auth_server(protocol_version=self._protocol_version)
1477
1498
 
1478
1499
    def _testing_pycurl(self):
1479
1500
        # TODO: This is duplicated for lots of the classes in this file
1492
1513
        return url
1493
1514
 
1494
1515
    def get_user_transport(self, user, password):
1495
 
        t = transport.get_transport(self.get_user_url(user, password))
1496
 
        return t
 
1516
        return self._transport(self.get_user_url(user, password))
1497
1517
 
1498
1518
    def test_no_user(self):
1499
1519
        self.server.add_user('joe', 'foo')
1610
1630
        ui.ui_factory = tests.TestUIFactory(stdin=stdin_content,
1611
1631
                                            stderr=tests.StringIOWrapper())
1612
1632
        # Create a minimal config file with the right password
1613
 
        _setup_authentication_config(
1614
 
            scheme='http', 
1615
 
            port=self.server.port,
1616
 
            user=user,
1617
 
            password=password)
 
1633
        conf = config.AuthenticationConfig()
 
1634
        conf._get_config().update(
 
1635
            {'httptest': {'scheme': 'http', 'port': self.server.port,
 
1636
                          'user': user, 'password': password}})
 
1637
        conf._save()
1618
1638
        # Issue a request to the server to connect
1619
1639
        self.assertEqual('contents of a\n',t.get('a').read())
1620
1640
        # stdin should have  been left untouched
1622
1642
        # Only one 'Authentication Required' error should occur
1623
1643
        self.assertEqual(1, self.server.auth_required_errors)
1624
1644
 
 
1645
    def test_user_from_auth_conf(self):
 
1646
        if self._testing_pycurl():
 
1647
            raise tests.TestNotApplicable(
 
1648
                'pycurl does not support authentication.conf')
 
1649
        user = 'joe'
 
1650
        password = 'foo'
 
1651
        self.server.add_user(user, password)
 
1652
        # Create a minimal config file with the right password
 
1653
        conf = config.AuthenticationConfig()
 
1654
        conf._get_config().update(
 
1655
            {'httptest': {'scheme': 'http', 'port': self.server.port,
 
1656
                          'user': user, 'password': password}})
 
1657
        conf._save()
 
1658
        t = self.get_user_transport(None, None)
 
1659
        # Issue a request to the server to connect
 
1660
        self.assertEqual('contents of a\n', t.get('a').read())
 
1661
        # Only one 'Authentication Required' error should occur
 
1662
        self.assertEqual(1, self.server.auth_required_errors)
 
1663
 
1625
1664
    def test_changing_nonce(self):
1626
1665
        if self._auth_server not in (http_utils.HTTPDigestAuthServer,
1627
1666
                                     http_utils.ProxyDigestAuthServer):
1643
1682
        # initial 'who are you' and a second 'who are you' with the new nonce)
1644
1683
        self.assertEqual(2, self.server.auth_required_errors)
1645
1684
 
1646
 
    def test_user_from_auth_conf(self):
1647
 
        if self._testing_pycurl():
1648
 
            raise tests.TestNotApplicable(
1649
 
                'pycurl does not support authentication.conf')
1650
 
        user = 'joe'
1651
 
        password = 'foo'
1652
 
        self.server.add_user(user, password)
1653
 
        _setup_authentication_config(
1654
 
            scheme='http', 
1655
 
            port=self.server.port,
1656
 
            user=user,
1657
 
            password=password)
1658
 
        t = self.get_user_transport(None, None)
1659
 
        # Issue a request to the server to connect
1660
 
        self.assertEqual('contents of a\n', t.get('a').read())
1661
 
        # Only one 'Authentication Required' error should occur
1662
 
        self.assertEqual(1, self.server.auth_required_errors)
1663
 
 
1664
 
 
1665
 
def _setup_authentication_config(**kwargs):
1666
 
    conf = config.AuthenticationConfig()
1667
 
    conf._get_config().update({'httptest': kwargs})
1668
 
    conf._save()
1669
 
 
1670
 
 
1671
 
 
1672
 
class TestUrllib2AuthHandler(tests.TestCaseWithTransport):
1673
 
    """Unit tests for glue by which urllib2 asks us for authentication"""
1674
 
 
1675
 
    def test_get_user_password_without_port(self):
1676
 
        """We cope if urllib2 doesn't tell us the port.
1677
 
 
1678
 
        See https://bugs.launchpad.net/bzr/+bug/654684
1679
 
        """
1680
 
        user = 'joe'
1681
 
        password = 'foo'
1682
 
        _setup_authentication_config(
1683
 
            scheme='http', 
1684
 
            host='localhost',
1685
 
            user=user,
1686
 
            password=password)
1687
 
        handler = _urllib2_wrappers.HTTPAuthHandler()
1688
 
        got_pass = handler.get_user_password(dict(
1689
 
            user='joe',
1690
 
            protocol='http',
1691
 
            host='localhost',
1692
 
            path='/',
1693
 
            realm='Realm',
1694
 
            ))
1695
 
        self.assertEquals((user, password), got_pass)
1696
1685
 
1697
1686
 
1698
1687
class TestProxyAuth(TestAuth):
1699
1688
    """Test proxy authentication schemes."""
1700
1689
 
1701
 
    scenarios = multiply_scenarios(
1702
 
        vary_by_http_client_implementation(),
1703
 
        vary_by_http_protocol_version(),
1704
 
        vary_by_http_proxy_auth_scheme(),
1705
 
        )
1706
 
 
1707
1690
    _auth_header = 'Proxy-authorization'
1708
1691
    _password_prompt_prefix = 'Proxy '
1709
1692
    _username_prompt_prefix = 'Proxy '
1710
1693
 
1711
1694
    def setUp(self):
1712
1695
        super(TestProxyAuth, self).setUp()
 
1696
        self._old_env = {}
 
1697
        self.addCleanup(self._restore_env)
1713
1698
        # Override the contents to avoid false positives
1714
1699
        self.build_tree_contents([('a', 'not proxied contents of a\n'),
1715
1700
                                  ('b', 'not proxied contents of b\n'),
1718
1703
                                  ])
1719
1704
 
1720
1705
    def get_user_transport(self, user, password):
1721
 
        self.overrideEnv('all_proxy', self.get_user_url(user, password))
1722
 
        return TestAuth.get_user_transport(self, user, password)
 
1706
        self._install_env({'all_proxy': self.get_user_url(user, password)})
 
1707
        return self._transport(self.server.get_url())
 
1708
 
 
1709
    def _install_env(self, env):
 
1710
        for name, value in env.iteritems():
 
1711
            self._old_env[name] = osutils.set_or_unset_env(name, value)
 
1712
 
 
1713
    def _restore_env(self):
 
1714
        for name, value in self._old_env.iteritems():
 
1715
            osutils.set_or_unset_env(name, value)
1723
1716
 
1724
1717
    def test_empty_pass(self):
1725
1718
        if self._testing_pycurl():
1744
1737
        self.readfile = StringIO(socket_read_content)
1745
1738
        self.writefile = StringIO()
1746
1739
        self.writefile.close = lambda: None
1747
 
        self.close = lambda: None
1748
1740
 
1749
1741
    def makefile(self, mode='r', bufsize=None):
1750
1742
        if 'r' in mode:
1755
1747
 
1756
1748
class SmartHTTPTunnellingTest(tests.TestCaseWithTransport):
1757
1749
 
1758
 
    scenarios = multiply_scenarios(
1759
 
        vary_by_http_client_implementation(), 
1760
 
        vary_by_http_protocol_version(),
1761
 
        )
1762
 
 
1763
1750
    def setUp(self):
1764
1751
        super(SmartHTTPTunnellingTest, self).setUp()
1765
1752
        # We use the VFS layer as part of HTTP tunnelling tests.
1766
 
        self.overrideEnv('BZR_NO_SMART_VFS', None)
 
1753
        self._captureVar('BZR_NO_SMART_VFS', None)
1767
1754
        self.transport_readonly_server = http_utils.HTTPServerWithSmarts
1768
 
        self.http_server = self.get_readonly_server()
1769
1755
 
1770
1756
    def create_transport_readonly_server(self):
1771
 
        server = http_utils.HTTPServerWithSmarts(
 
1757
        return http_utils.HTTPServerWithSmarts(
1772
1758
            protocol_version=self._protocol_version)
1773
 
        server._url_protocol = self._url_protocol
1774
 
        return server
1775
1759
 
1776
1760
    def test_open_bzrdir(self):
1777
1761
        branch = self.make_branch('relpath')
1778
 
        url = self.http_server.get_url() + 'relpath'
 
1762
        http_server = self.get_readonly_server()
 
1763
        url = http_server.get_url() + 'relpath'
1779
1764
        bd = bzrdir.BzrDir.open(url)
1780
 
        self.addCleanup(bd.transport.disconnect)
1781
1765
        self.assertIsInstance(bd, _mod_remote.RemoteBzrDir)
1782
1766
 
1783
1767
    def test_bulk_data(self):
1785
1769
        # The 'readv' command in the smart protocol both sends and receives
1786
1770
        # bulk data, so we use that.
1787
1771
        self.build_tree(['data-file'])
1788
 
        http_transport = transport.get_transport(self.http_server.get_url())
 
1772
        http_server = self.get_readonly_server()
 
1773
        http_transport = self._transport(http_server.get_url())
1789
1774
        medium = http_transport.get_smart_medium()
1790
1775
        # Since we provide the medium, the url below will be mostly ignored
1791
1776
        # during the test, as long as the path is '/'.
1799
1784
        post_body = 'hello\n'
1800
1785
        expected_reply_body = 'ok\x012\n'
1801
1786
 
1802
 
        http_transport = transport.get_transport(self.http_server.get_url())
 
1787
        http_server = self.get_readonly_server()
 
1788
        http_transport = self._transport(http_server.get_url())
1803
1789
        medium = http_transport.get_smart_medium()
1804
1790
        response = medium.send_http_smart_request(post_body)
1805
1791
        reply_body = response.read()
1806
1792
        self.assertEqual(expected_reply_body, reply_body)
1807
1793
 
1808
1794
    def test_smart_http_server_post_request_handler(self):
1809
 
        httpd = self.http_server.server
 
1795
        httpd = self.get_readonly_server()._get_httpd()
1810
1796
 
1811
1797
        socket = SampleSocket(
1812
1798
            'POST /.bzr/smart %s \r\n' % self._protocol_version
1844
1830
 
1845
1831
    def test_probe_smart_server(self):
1846
1832
        """Test error handling against server refusing smart requests."""
1847
 
        t = self.get_readonly_transport()
 
1833
        server = self.get_readonly_server()
 
1834
        t = self._transport(server.get_url())
1848
1835
        # No need to build a valid smart request here, the server will not even
1849
1836
        # try to interpret it.
1850
1837
        self.assertRaises(errors.SmartProtocolError,
1851
1838
                          t.get_smart_medium().send_http_smart_request,
1852
1839
                          'whatever')
1853
1840
 
1854
 
 
1855
1841
class Test_redirected_to(tests.TestCase):
1856
1842
 
1857
 
    scenarios = vary_by_http_client_implementation()
1858
 
 
1859
1843
    def test_redirected_to_subdir(self):
1860
1844
        t = self._transport('http://www.example.com/foo')
1861
1845
        r = t._redirected_to('http://www.example.com/foo',
1912
1896
    line.
1913
1897
    """
1914
1898
 
1915
 
    def _handle_one_request(self):
 
1899
    def handle_one_request(self):
1916
1900
        tcs = self.server.test_case_server
1917
1901
        requestline = self.rfile.readline()
1918
1902
        headers = self.MessageClass(self.rfile, 0)
1982
1966
        # We override at class level because constructors may propagate the
1983
1967
        # bound method and render instance overriding ineffective (an
1984
1968
        # alternative would be to define a specific ui factory instead...)
1985
 
        self.overrideAttr(self._transport, '_report_activity', report_activity)
1986
 
        self.addCleanup(self.server.stop_server)
 
1969
        self.orig_report_activity = self._transport._report_activity
 
1970
        self._transport._report_activity = report_activity
 
1971
 
 
1972
    def tearDown(self):
 
1973
        self._transport._report_activity = self.orig_report_activity
 
1974
        self.server.stop_server()
 
1975
        tests.TestCase.tearDown(self)
1987
1976
 
1988
1977
    def get_transport(self):
1989
 
        t = self._transport(self.server.get_url())
1990
 
        # FIXME: Needs cleanup -- vila 20100611
1991
 
        return t
 
1978
        return self._transport(self.server.get_url())
1992
1979
 
1993
1980
    def assertActivitiesMatch(self):
1994
1981
        self.assertEqual(self.server.bytes_read,
2099
2086
'''
2100
2087
        t = self.get_transport()
2101
2088
        # We must send a single line of body bytes, see
2102
 
        # PredefinedRequestHandler._handle_one_request
 
2089
        # PredefinedRequestHandler.handle_one_request
2103
2090
        code, f = t._post('abc def end-of-body\n')
2104
2091
        self.assertEqual('lalala whatever as long as itsssss\n', f.read())
2105
2092
        self.assertActivitiesMatch()
2107
2094
 
2108
2095
class TestActivity(tests.TestCase, TestActivityMixin):
2109
2096
 
2110
 
    scenarios = multiply_scenarios(
2111
 
        vary_by_http_activity(),
2112
 
        vary_by_http_protocol_version(),
2113
 
        )
2114
 
 
2115
2097
    def setUp(self):
2116
 
        TestActivityMixin.setUp(self)
 
2098
        tests.TestCase.setUp(self)
 
2099
        self.server = self._activity_server(self._protocol_version)
 
2100
        self.server.start_server()
 
2101
        self.activities = {}
 
2102
        def report_activity(t, bytes, direction):
 
2103
            count = self.activities.get(direction, 0)
 
2104
            count += bytes
 
2105
            self.activities[direction] = count
 
2106
 
 
2107
        # We override at class level because constructors may propagate the
 
2108
        # bound method and render instance overriding ineffective (an
 
2109
        # alternative would be to define a specific ui factory instead...)
 
2110
        self.orig_report_activity = self._transport._report_activity
 
2111
        self._transport._report_activity = report_activity
 
2112
 
 
2113
    def tearDown(self):
 
2114
        self._transport._report_activity = self.orig_report_activity
 
2115
        self.server.stop_server()
 
2116
        tests.TestCase.tearDown(self)
2117
2117
 
2118
2118
 
2119
2119
class TestNoReportActivity(tests.TestCase, TestActivityMixin):
2120
2120
 
2121
 
    # Unlike TestActivity, we are really testing ReportingFileSocket and
2122
 
    # ReportingSocket, so we don't need all the parametrization. Since
2123
 
    # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
2124
 
    # test them through their use by the transport than directly (that's a
2125
 
    # bit less clean but far more simpler and effective).
2126
 
    _activity_server = ActivityHTTPServer
2127
 
    _protocol_version = 'HTTP/1.1'
2128
 
 
2129
2121
    def setUp(self):
2130
 
        self._transport =_urllib.HttpTransport_urllib
2131
 
        TestActivityMixin.setUp(self)
 
2122
        tests.TestCase.setUp(self)
 
2123
        # Unlike TestActivity, we are really testing ReportingFileSocket and
 
2124
        # ReportingSocket, so we don't need all the parametrization. Since
 
2125
        # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
 
2126
        # test them through their use by the transport than directly (that's a
 
2127
        # bit less clean but far more simpler and effective).
 
2128
        self.server = ActivityHTTPServer('HTTP/1.1')
 
2129
        self._transport=_urllib.HttpTransport_urllib
 
2130
 
 
2131
        self.server.start_server()
 
2132
 
 
2133
        # We override at class level because constructors may propagate the
 
2134
        # bound method and render instance overriding ineffective (an
 
2135
        # alternative would be to define a specific ui factory instead...)
 
2136
        self.orig_report_activity = self._transport._report_activity
 
2137
        self._transport._report_activity = None
 
2138
 
 
2139
    def tearDown(self):
 
2140
        self._transport._report_activity = self.orig_report_activity
 
2141
        self.server.stop_server()
 
2142
        tests.TestCase.tearDown(self)
2132
2143
 
2133
2144
    def assertActivitiesMatch(self):
2134
2145
        # Nothing to check here
2138
2149
class TestAuthOnRedirected(http_utils.TestCaseWithRedirectedWebserver):
2139
2150
    """Test authentication on the redirected http server."""
2140
2151
 
2141
 
    scenarios = vary_by_http_protocol_version()
2142
 
 
2143
2152
    _auth_header = 'Authorization'
2144
2153
    _password_prompt_prefix = ''
2145
2154
    _username_prompt_prefix = ''
2146
2155
    _auth_server = http_utils.HTTPBasicAuthServer
2147
2156
    _transport = _urllib.HttpTransport_urllib
2148
2157
 
 
2158
    def create_transport_readonly_server(self):
 
2159
        return self._auth_server()
 
2160
 
 
2161
    def create_transport_secondary_server(self):
 
2162
        """Create the secondary server redirecting to the primary server"""
 
2163
        new = self.get_readonly_server()
 
2164
 
 
2165
        redirecting = http_utils.HTTPServerRedirecting()
 
2166
        redirecting.redirect_to(new.host, new.port)
 
2167
        return redirecting
 
2168
 
2149
2169
    def setUp(self):
2150
2170
        super(TestAuthOnRedirected, self).setUp()
2151
2171
        self.build_tree_contents([('a','a'),
2156
2176
                                       self.new_server.port)
2157
2177
        self.old_server.redirections = [
2158
2178
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2159
 
        self.old_transport = self.get_old_transport()
 
2179
        self.old_transport = self._transport(self.old_server.get_url())
2160
2180
        self.new_server.add_user('joe', 'foo')
2161
 
        cleanup_http_redirection_connections(self)
2162
 
 
2163
 
    def create_transport_readonly_server(self):
2164
 
        server = self._auth_server(protocol_version=self._protocol_version)
2165
 
        server._url_protocol = self._url_protocol
2166
 
        return server
2167
 
 
2168
 
    def get_a(self, t):
2169
 
        return t.get('a')
 
2181
 
 
2182
    def get_a(self, transport):
 
2183
        return transport.get('a')
2170
2184
 
2171
2185
    def test_auth_on_redirected_via_do_catching_redirections(self):
2172
2186
        self.redirections = 0
2173
2187
 
2174
 
        def redirected(t, exception, redirection_notice):
 
2188
        def redirected(transport, exception, redirection_notice):
2175
2189
            self.redirections += 1
2176
 
            redirected_t = t._redirected_to(exception.source, exception.target)
2177
 
            self.addCleanup(redirected_t.disconnect)
2178
 
            return redirected_t
 
2190
            dir, file = urlutils.split(exception.target)
 
2191
            return self._transport(dir)
2179
2192
 
2180
2193
        stdout = tests.StringIOWrapper()
2181
2194
        stderr = tests.StringIOWrapper()
2202
2215
                                       self.new_server.port)
2203
2216
        self.old_server.redirections = [
2204
2217
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2205
 
        self.assertEqual('redirected once', t._perform(req).read())
 
2218
        self.assertEqual('redirected once',t._perform(req).read())
2206
2219
        # stdin should be empty
2207
2220
        self.assertEqual('', ui.ui_factory.stdin.readline())
2208
2221
        # stdout should be empty, stderr will contains the prompts