287
308
self.verbose = verbose
289
310
self.work_tree.lock_write()
311
operation.add_cleanup(self.work_tree.unlock)
312
self.parents = self.work_tree.get_parent_ids()
313
# We can use record_iter_changes IFF iter_changes is compatible with
314
# the command line parameters, and the repository has fast delta
315
# generation. See bug 347649.
316
self.use_record_iter_changes = (
318
not self.branch.repository._format.supports_tree_reference and
319
(self.branch.repository._format.fast_deltas or
320
len(self.parents) < 2))
290
321
self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
322
operation.add_cleanup(self.pb.finished)
291
323
self.basis_revid = self.work_tree.last_revision()
292
324
self.basis_tree = self.work_tree.basis_tree()
293
325
self.basis_tree.lock_read()
326
operation.add_cleanup(self.basis_tree.unlock)
327
# Cannot commit with conflicts present.
328
if len(self.work_tree.conflicts()) > 0:
329
raise ConflictsInTree
331
# Setup the bound branch variables as needed.
332
self._check_bound_branch(operation, possible_master_transports)
334
# Check that the working tree is up to date
335
old_revno, new_revno = self._check_out_of_date_tree()
337
# Complete configuration setup
338
if reporter is not None:
339
self.reporter = reporter
340
elif self.reporter is None:
341
self.reporter = self._select_reporter()
342
if self.config is None:
343
self.config = self.branch.get_config()
345
self._set_specific_file_ids()
347
# Setup the progress bar. As the number of files that need to be
348
# committed in unknown, progress is reported as stages.
349
# We keep track of entries separately though and include that
350
# information in the progress bar during the relevant stages.
351
self.pb_stage_name = ""
352
self.pb_stage_count = 0
353
self.pb_stage_total = 5
354
if self.bound_branch:
355
self.pb_stage_total += 1
356
self.pb.show_pct = False
357
self.pb.show_spinner = False
358
self.pb.show_eta = False
359
self.pb.show_count = True
360
self.pb.show_bar = True
362
self._gather_parents()
363
# After a merge, a selected file commit is not supported.
364
# See 'bzr help merge' for an explanation as to why.
365
if len(self.parents) > 1 and self.specific_files is not None:
366
raise errors.CannotCommitSelectedFileMerge(self.specific_files)
367
# Excludes are a form of selected file commit.
368
if len(self.parents) > 1 and self.exclude:
369
raise errors.CannotCommitSelectedFileMerge(self.exclude)
371
# Collect the changes
372
self._set_progress_stage("Collecting changes", counter=True)
373
self.builder = self.branch.get_commit_builder(self.parents,
374
self.config, timestamp, timezone, committer, revprops, rev_id)
295
# Cannot commit with conflicts present.
296
if len(self.work_tree.conflicts()) > 0:
297
raise ConflictsInTree
299
# Setup the bound branch variables as needed.
300
self._check_bound_branch(possible_master_transports)
302
# Check that the working tree is up to date
303
old_revno, new_revno = self._check_out_of_date_tree()
305
# Complete configuration setup
306
if reporter is not None:
307
self.reporter = reporter
308
elif self.reporter is None:
309
self.reporter = self._select_reporter()
310
if self.config is None:
311
self.config = self.branch.get_config()
313
# If provided, ensure the specified files are versioned
314
if self.specific_files is not None:
315
# Note: This routine is being called because it raises
316
# PathNotVersionedError as a side effect of finding the IDs. We
317
# later use the ids we found as input to the working tree
318
# inventory iterator, so we only consider those ids rather than
319
# examining the whole tree again.
320
# XXX: Dont we have filter_unversioned to do this more
322
self.specific_file_ids = tree.find_ids_across_trees(
323
specific_files, [self.basis_tree, self.work_tree])
325
# Setup the progress bar. As the number of files that need to be
326
# committed in unknown, progress is reported as stages.
327
# We keep track of entries separately though and include that
328
# information in the progress bar during the relevant stages.
329
self.pb_stage_name = ""
330
self.pb_stage_count = 0
331
self.pb_stage_total = 5
332
if self.bound_branch:
333
self.pb_stage_total += 1
334
self.pb.show_pct = False
335
self.pb.show_spinner = False
336
self.pb.show_eta = False
337
self.pb.show_count = True
338
self.pb.show_bar = True
340
self.basis_inv = self.basis_tree.inventory
341
self._gather_parents()
342
# After a merge, a selected file commit is not supported.
343
# See 'bzr help merge' for an explanation as to why.
344
if len(self.parents) > 1 and self.specific_files:
345
raise errors.CannotCommitSelectedFileMerge(self.specific_files)
346
# Excludes are a form of selected file commit.
347
if len(self.parents) > 1 and self.exclude:
348
raise errors.CannotCommitSelectedFileMerge(self.exclude)
350
# Collect the changes
351
self._set_progress_stage("Collecting changes",
352
entries_title="Directory")
353
self.builder = self.branch.get_commit_builder(self.parents,
354
self.config, timestamp, timezone, committer, revprops, rev_id)
357
self.builder.will_record_deletes()
358
# find the location being committed to
359
if self.bound_branch:
360
master_location = self.master_branch.base
362
master_location = self.branch.base
364
# report the start of the commit
365
self.reporter.started(new_revno, self.rev_id, master_location)
367
self._update_builder_with_changes()
368
self._report_and_accumulate_deletes()
369
self._check_pointless()
371
# TODO: Now the new inventory is known, check for conflicts.
372
# ADHB 2006-08-08: If this is done, populate_new_inv should not add
373
# weave lines, because nothing should be recorded until it is known
374
# that commit will succeed.
375
self._set_progress_stage("Saving data locally")
376
self.builder.finish_inventory()
378
# Prompt the user for a commit message if none provided
379
message = message_callback(self)
380
self.message = message
381
self._escape_commit_message()
383
# Add revision data to the local branch
384
self.rev_id = self.builder.commit(self.message)
387
mutter("aborting commit write group because of exception:")
388
trace.log_exception_quietly()
389
note("aborting commit write group: %r" % (e,))
393
self._process_pre_hooks(old_revno, new_revno)
395
# Upload revision data to the master.
396
# this will propagate merged revisions too if needed.
397
if self.bound_branch:
398
if not self.master_branch.repository.has_same_location(
399
self.branch.repository):
400
self._set_progress_stage("Uploading data to master branch")
401
self.master_branch.repository.fetch(self.branch.repository,
402
revision_id=self.rev_id)
403
# now the master has the revision data
404
# 'commit' to the master first so a timeout here causes the
405
# local branch to be out of date
406
self.master_branch.set_last_revision_info(new_revno,
409
# and now do the commit locally.
410
self.branch.set_last_revision_info(new_revno, self.rev_id)
412
# Make the working tree up to date with the branch
413
self._set_progress_stage("Updating the working tree")
414
self.work_tree.update_basis_by_delta(self.rev_id,
415
self.builder.get_basis_delta())
416
self.reporter.completed(new_revno, self.rev_id)
417
self._process_post_hooks(old_revno, new_revno)
377
self.builder.will_record_deletes()
378
# find the location being committed to
379
if self.bound_branch:
380
master_location = self.master_branch.base
382
master_location = self.branch.base
384
# report the start of the commit
385
self.reporter.started(new_revno, self.rev_id, master_location)
387
self._update_builder_with_changes()
388
self._check_pointless()
390
# TODO: Now the new inventory is known, check for conflicts.
391
# ADHB 2006-08-08: If this is done, populate_new_inv should not add
392
# weave lines, because nothing should be recorded until it is known
393
# that commit will succeed.
394
self._set_progress_stage("Saving data locally")
395
self.builder.finish_inventory()
397
# Prompt the user for a commit message if none provided
398
message = message_callback(self)
399
self.message = message
401
# Add revision data to the local branch
402
self.rev_id = self.builder.commit(self.message)
405
mutter("aborting commit write group because of exception:")
406
trace.log_exception_quietly()
407
note("aborting commit write group: %r" % (e,))
411
self._process_pre_hooks(old_revno, new_revno)
413
# Upload revision data to the master.
414
# this will propagate merged revisions too if needed.
415
if self.bound_branch:
416
self._set_progress_stage("Uploading data to master branch")
417
# 'commit' to the master first so a timeout here causes the
418
# local branch to be out of date
419
self.master_branch.import_last_revision_info(
420
self.branch.repository, new_revno, self.rev_id)
422
# and now do the commit locally.
423
self.branch.set_last_revision_info(new_revno, self.rev_id)
425
# Make the working tree be up to date with the branch. This
426
# includes automatic changes scheduled to be made to the tree, such
427
# as updating its basis and unversioning paths that were missing.
428
self.work_tree.unversion(self.deleted_ids)
429
self._set_progress_stage("Updating the working tree")
430
self.work_tree.update_basis_by_delta(self.rev_id,
431
self.builder.get_basis_delta())
432
self.reporter.completed(new_revno, self.rev_id)
433
self._process_post_hooks(old_revno, new_revno)
420
434
return self.rev_id
422
436
def _select_reporter(self):
579
590
old_revno, old_revid, new_revno, self.rev_id,
580
591
tree_delta, future_tree)
583
"""Cleanup any open locks, progress bars etc."""
584
cleanups = [self._cleanup_bound_branch,
585
self.basis_tree.unlock,
586
self.work_tree.unlock,
588
found_exception = None
589
for cleanup in cleanups:
592
# we want every cleanup to run no matter what.
593
# so we have a catchall here, but we will raise the
594
# last encountered exception up the stack: and
595
# typically this will be useful enough.
598
if found_exception is not None:
599
# don't do a plan raise, because the last exception may have been
600
# trashed, e is our sure-to-work exception even though it loses the
601
# full traceback. XXX: RBC 20060421 perhaps we could check the
602
# exc_info and if its the same one do a plain raise otherwise
603
# 'raise e' as we do now.
606
def _cleanup_bound_branch(self):
607
"""Executed at the end of a try/finally to cleanup a bound branch.
609
If the branch wasn't bound, this is a no-op.
610
If it was, it resents self.branch to the local branch, instead
613
if not self.bound_branch:
615
if self.master_locked:
616
self.master_branch.unlock()
618
def _escape_commit_message(self):
619
"""Replace xml-incompatible control characters."""
620
# FIXME: RBC 20060419 this should be done by the revision
621
# serialiser not by commit. Then we can also add an unescaper
622
# in the deserializer and start roundtripping revision messages
623
# precisely. See repository_implementations/test_repository.py
625
# Python strings can include characters that can't be
626
# represented in well-formed XML; escape characters that
627
# aren't listed in the XML specification
628
# (http://www.w3.org/TR/REC-xml/#NT-Char).
629
self.message, escape_count = re.subn(
630
u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
631
lambda match: match.group(0).encode('unicode_escape'),
634
self.reporter.escaped(escape_count, self.message)
636
593
def _gather_parents(self):
637
594
"""Record the parents of a merge for merge detection."""
638
# TODO: Make sure that this list doesn't contain duplicate
595
# TODO: Make sure that this list doesn't contain duplicate
639
596
# entries and the order is preserved when doing this.
640
self.parents = self.work_tree.get_parent_ids()
597
if self.use_record_iter_changes:
599
self.basis_inv = self.basis_tree.inventory
641
600
self.parent_invs = [self.basis_inv]
642
601
for revision in self.parents[1:]:
643
602
if self.branch.repository.has_revision(revision):
650
609
def _update_builder_with_changes(self):
651
610
"""Update the commit builder with the data about what has changed.
653
# Build the revision inventory.
655
# This starts by creating a new empty inventory. Depending on
656
# which files are selected for commit, and what is present in the
657
# current tree, the new inventory is populated. inventory entries
658
# which are candidates for modification have their revision set to
659
# None; inventory entries that are carried over untouched have their
660
# revision set to their prior value.
662
# ESEPARATIONOFCONCERNS: this function is diffing and using the diff
663
# results to create a new inventory at the same time, which results
664
# in bugs like #46635. Any reason not to use/enhance Tree.changes_from?
667
612
exclude = self.exclude
668
specific_files = self.specific_files or []
613
specific_files = self.specific_files
669
614
mutter("Selecting files for commit with filter %s", specific_files)
671
# Build the new inventory
672
self._populate_from_inventory()
617
if self.use_record_iter_changes:
618
iter_changes = self.work_tree.iter_changes(self.basis_tree,
619
specific_files=specific_files)
620
iter_changes = self._filter_iter_changes(iter_changes)
621
for file_id, path, fs_hash in self.builder.record_iter_changes(
622
self.work_tree, self.basis_revid, iter_changes):
623
self.work_tree._observed_sha1(file_id, path, fs_hash)
625
# Build the new inventory
626
self._populate_from_inventory()
627
self._record_unselected()
628
self._report_and_accumulate_deletes()
630
def _filter_iter_changes(self, iter_changes):
631
"""Process iter_changes.
633
This method reports on the changes in iter_changes to the user, and
634
converts 'missing' entries in the iter_changes iterator to 'deleted'
635
entries. 'missing' entries have their
637
:param iter_changes: An iter_changes to process.
638
:return: A generator of changes.
640
reporter = self.reporter
641
report_changes = reporter.is_verbose()
643
for change in iter_changes:
645
old_path = change[1][0]
646
new_path = change[1][1]
647
versioned = change[3][1]
649
versioned = change[3][1]
650
if kind is None and versioned:
653
reporter.missing(new_path)
654
deleted_ids.append(change[0])
655
# Reset the new path (None) and new versioned flag (False)
656
change = (change[0], (change[1][0], None), change[2],
657
(change[3][0], False)) + change[4:]
658
elif kind == 'tree-reference':
659
if self.recursive == 'down':
660
self._commit_nested_tree(change[0], change[1][1])
661
if change[3][0] or change[3][1]:
665
reporter.deleted(old_path)
666
elif old_path is None:
667
reporter.snapshot_change('added', new_path)
668
elif old_path != new_path:
669
reporter.renamed('renamed', old_path, new_path)
672
self.work_tree.branch.repository._format.rich_root_data):
673
# Don't report on changes to '' in non rich root
675
reporter.snapshot_change('modified', new_path)
676
self._next_progress_entry()
677
# Unversion IDs that were found to be deleted
678
self.deleted_ids = deleted_ids
680
def _record_unselected(self):
674
681
# If specific files are selected, then all un-selected files must be
675
682
# recorded in their previous state. For more details, see
676
683
# https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
677
if specific_files or exclude:
684
if self.specific_files or self.exclude:
685
specific_files = self.specific_files or []
678
686
for path, old_ie in self.basis_inv.iter_entries():
679
687
if old_ie.file_id in self.builder.new_inventory:
680
688
# already added - skip.
682
690
if (is_inside_any(specific_files, path)
683
and not is_inside_any(exclude, path)):
691
and not is_inside_any(self.exclude, path)):
684
692
# was inside the selected path, and not excluded - if not
685
693
# present it has been deleted so skip.
687
695
# From here down it was either not selected, or was excluded:
688
if old_ie.kind == 'directory':
689
self._next_progress_entry()
690
696
# We preserve the entry unaltered.
691
697
ie = old_ie.copy()
692
698
# Note: specific file commits after a merge are currently
added
removed
bzrlib/commit.py
