← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_merge.py

  • Committer: Canonical.com Patch Queue Manager
  • Date: 2010-02-03 10:06:19 UTC
  • mfrom: (4999.3.2 apport)
  • Revision ID: pqm@pqm.ubuntu.com-20100203100619-f76bo5y5bd5c14wk
(mbp) use apport to send bugs, not just store them

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_merge.py
1
 
# Copyright (C) 2005-2012 Canonical Ltd
 
1
# Copyright (C) 2005-2010 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
18
18
from StringIO import StringIO
19
19
 
20
20
from bzrlib import (
21
 
    branch as _mod_branch,
22
 
    cleanup,
23
21
    conflicts,
24
22
    errors,
25
 
    inventory,
26
23
    knit,
27
24
    memorytree,
28
25
    merge as _mod_merge,
29
26
    option,
30
 
    revision as _mod_revision,
 
27
    progress,
31
28
    tests,
32
29
    transform,
33
30
    versionedfile,
35
32
from bzrlib.conflicts import ConflictList, TextConflict
36
33
from bzrlib.errors import UnrelatedBranches, NoCommits
37
34
from bzrlib.merge import transform_tree, merge_inner, _PlanMerge
38
 
from bzrlib.osutils import basename, pathjoin, file_kind
 
35
from bzrlib.osutils import pathjoin, file_kind
39
36
from bzrlib.tests import (
40
 
    features,
41
37
    TestCaseWithMemoryTransport,
42
38
    TestCaseWithTransport,
43
39
    test_merge_core,
83
79
        tip = wt1.commit('empty commit')
84
80
        wt2 = self.make_branch_and_tree('branch2')
85
81
        wt2.pull(wt1.branch)
86
 
        with file('branch1/foo', 'wb') as f:
87
 
            f.write('foo')
88
 
        with file('branch1/bar', 'wb') as f:
89
 
            f.write('bar')
 
82
        file('branch1/foo', 'wb').write('foo')
 
83
        file('branch1/bar', 'wb').write('bar')
90
84
        wt1.add('foo')
91
85
        wt1.add('bar')
92
86
        wt1.commit('add foobar')
93
 
        self.run_bzr('merge ../branch1/baz', retcode=3, working_dir='branch2')
94
 
        self.run_bzr('merge ../branch1/foo', working_dir='branch2')
95
 
        self.assertPathExists('branch2/foo')
96
 
        self.assertPathDoesNotExist('branch2/bar')
97
 
        wt2 = WorkingTree.open('branch2')
 
87
        os.chdir('branch2')
 
88
        self.run_bzr('merge ../branch1/baz', retcode=3)
 
89
        self.run_bzr('merge ../branch1/foo')
 
90
        self.failUnlessExists('foo')
 
91
        self.failIfExists('bar')
 
92
        wt2 = WorkingTree.open('.') # opens branch2
98
93
        self.assertEqual([tip], wt2.get_parent_ids())
99
94
 
100
95
    def test_pending_with_null(self):
123
118
        finally:
124
119
            wt1.unlock()
125
120
 
126
 
    def test_merge_into_null_tree(self):
127
 
        wt = self.make_branch_and_tree('tree')
128
 
        null_tree = wt.basis_tree()
129
 
        self.build_tree(['tree/file'])
130
 
        wt.add('file')
131
 
        wt.commit('tree with root')
132
 
        merger = _mod_merge.Merge3Merger(null_tree, null_tree, null_tree, wt,
133
 
                                         this_branch=wt.branch,
134
 
                                         do_merge=False)
135
 
        with merger.make_preview_transform() as tt:
136
 
            self.assertEqual([], tt.find_conflicts())
137
 
            preview = tt.get_preview_tree()
138
 
            self.assertEqual(wt.get_root_id(), preview.get_root_id())
139
 
 
140
 
    def test_merge_unrelated_retains_root(self):
141
 
        wt = self.make_branch_and_tree('tree')
142
 
        other_tree = self.make_branch_and_tree('other')
143
 
        self.addCleanup(other_tree.lock_read().unlock)
144
 
        merger = _mod_merge.Merge3Merger(wt, wt, wt.basis_tree(), other_tree,
145
 
                                         this_branch=wt.branch,
146
 
                                         do_merge=False)
147
 
        with transform.TransformPreview(wt) as merger.tt:
148
 
            merger._compute_transform()
149
 
            new_root_id = merger.tt.final_file_id(merger.tt.root)
150
 
            self.assertEqual(wt.get_root_id(), new_root_id)
151
 
 
152
121
    def test_create_rename(self):
153
122
        """Rename an inventory entry while creating the file"""
154
123
        tree =self.make_branch_and_tree('.')
155
 
        with file('name1', 'wb') as f: f.write('Hello')
 
124
        file('name1', 'wb').write('Hello')
156
125
        tree.add('name1')
157
126
        tree.commit(message="hello")
158
127
        tree.rename_one('name1', 'name2')
165
134
        os.mkdir('dirname1')
166
135
        tree.add('dirname1')
167
136
        filename = pathjoin('dirname1', 'name1')
168
 
        with file(filename, 'wb') as f: f.write('Hello')
 
137
        file(filename, 'wb').write('Hello')
169
138
        tree.add(filename)
170
139
        tree.commit(message="hello")
171
140
        filename2 = pathjoin('dirname1', 'name2')
185
154
        log = StringIO()
186
155
        merge_inner(tree_b.branch, tree_a, tree_b.basis_tree(),
187
156
                    this_tree=tree_b, ignore_zero=True)
188
 
        self.assertTrue('All changes applied successfully.\n' not in
 
157
        self.failUnless('All changes applied successfully.\n' not in
189
158
            self.get_log())
190
159
        tree_b.revert()
191
160
        merge_inner(tree_b.branch, tree_a, tree_b.basis_tree(),
192
161
                    this_tree=tree_b, ignore_zero=False)
193
 
        self.assertTrue('All changes applied successfully.\n' in self.get_log())
 
162
        self.failUnless('All changes applied successfully.\n' in self.get_log())
194
163
 
195
164
    def test_merge_inner_conflicts(self):
196
165
        tree_a = self.make_branch_and_tree('a')
227
196
 
228
197
    def test_nested_merge(self):
229
198
        tree = self.make_branch_and_tree('tree',
230
 
            format='development-subtree')
 
199
            format='dirstate-with-subtree')
231
200
        sub_tree = self.make_branch_and_tree('tree/sub-tree',
232
 
            format='development-subtree')
 
201
            format='dirstate-with-subtree')
233
202
        sub_tree.set_root_id('sub-tree-root')
234
203
        self.build_tree_contents([('tree/sub-tree/file', 'text1')])
235
204
        sub_tree.add('file')
326
295
        tree_a.commit('commit 2')
327
296
        tree_b = tree_a.bzrdir.sprout('b').open_workingtree()
328
297
        tree_b.rename_one('file_1', 'renamed')
329
 
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b)
 
298
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b,
 
299
                                                    progress.DummyProgress())
330
300
        merger.merge_type = _mod_merge.Merge3Merger
331
301
        merger.do_merge()
332
302
        self.assertEqual(tree_a.get_parent_ids(), [tree_b.last_revision()])
340
310
        tree_a.commit('commit 2')
341
311
        tree_b = tree_a.bzrdir.sprout('b').open_workingtree()
342
312
        tree_b.rename_one('file_1', 'renamed')
343
 
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b)
 
313
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b,
 
314
                                                    progress.DummyProgress())
344
315
        merger.merge_type = _mod_merge.WeaveMerger
345
316
        merger.do_merge()
346
317
        self.assertEqual(tree_a.get_parent_ids(), [tree_b.last_revision()])
347
318
 
 
319
    def test_Merger_defaults_to_DummyProgress(self):
 
320
        branch = self.make_branch('branch')
 
321
        merger = _mod_merge.Merger(branch, pb=None)
 
322
        self.assertIsInstance(merger._pb, progress.DummyProgress)
 
323
 
348
324
    def prepare_cherrypick(self):
349
325
        """Prepare a pair of trees for cherrypicking tests.
350
326
 
371
347
 
372
348
    def test_weave_cherrypick(self):
373
349
        this_tree, other_tree = self.prepare_cherrypick()
374
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
350
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
375
351
            this_tree, 'rev3b', 'rev2b', other_tree.branch)
376
352
        merger.merge_type = _mod_merge.WeaveMerger
377
353
        merger.do_merge()
379
355
 
380
356
    def test_weave_cannot_reverse_cherrypick(self):
381
357
        this_tree, other_tree = self.prepare_cherrypick()
382
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
358
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
383
359
            this_tree, 'rev2b', 'rev3b', other_tree.branch)
384
360
        merger.merge_type = _mod_merge.WeaveMerger
385
361
        self.assertRaises(errors.CannotReverseCherrypick, merger.do_merge)
386
362
 
387
363
    def test_merge3_can_reverse_cherrypick(self):
388
364
        this_tree, other_tree = self.prepare_cherrypick()
389
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
365
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
390
366
            this_tree, 'rev2b', 'rev3b', other_tree.branch)
391
367
        merger.merge_type = _mod_merge.Merge3Merger
392
368
        merger.do_merge()
404
380
        this_tree.lock_write()
405
381
        self.addCleanup(this_tree.unlock)
406
382
 
407
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
383
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
408
384
            this_tree, 'rev3b', 'rev2b', other_tree.branch)
409
385
        merger.merge_type = _mod_merge.Merge3Merger
410
386
        merger.do_merge()
415
391
                             '>>>>>>> MERGE-SOURCE\n',
416
392
                             'this/file')
417
393
 
418
 
    def test_merge_reverse_revision_range(self):
419
 
        tree = self.make_branch_and_tree(".")
420
 
        tree.lock_write()
421
 
        self.addCleanup(tree.unlock)
422
 
        self.build_tree(['a'])
423
 
        tree.add('a')
424
 
        first_rev = tree.commit("added a")
425
 
        merger = _mod_merge.Merger.from_revision_ids(None, tree,
426
 
                                          _mod_revision.NULL_REVISION,
427
 
                                          first_rev)
428
 
        merger.merge_type = _mod_merge.Merge3Merger
429
 
        merger.interesting_files = 'a'
430
 
        conflict_count = merger.do_merge()
431
 
        self.assertEqual(0, conflict_count)
432
 
 
433
 
        self.assertPathDoesNotExist("a")
434
 
        tree.revert()
435
 
        self.assertPathExists("a")
436
 
 
437
394
    def test_make_merger(self):
438
395
        this_tree = self.make_branch_and_tree('this')
439
396
        this_tree.commit('rev1', rev_id='rev1')
442
399
        other_tree.commit('rev2', rev_id='rev2b')
443
400
        this_tree.lock_write()
444
401
        self.addCleanup(this_tree.unlock)
445
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
402
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress,
446
403
            this_tree, 'rev2b', other_branch=other_tree.branch)
447
404
        merger.merge_type = _mod_merge.Merge3Merger
448
405
        tree_merger = merger.make_merger()
449
406
        self.assertIs(_mod_merge.Merge3Merger, tree_merger.__class__)
450
 
        self.assertEqual('rev2b',
451
 
            tree_merger.other_tree.get_revision_id())
452
 
        self.assertEqual('rev1',
453
 
            tree_merger.base_tree.get_revision_id())
454
 
        self.assertEqual(other_tree.branch, tree_merger.other_branch)
 
407
        self.assertEqual('rev2b', tree_merger.other_tree.get_revision_id())
 
408
        self.assertEqual('rev1', tree_merger.base_tree.get_revision_id())
455
409
 
456
410
    def test_make_preview_transform(self):
457
411
        this_tree = self.make_branch_and_tree('this')
465
419
        other_tree.commit('rev2', rev_id='rev2b')
466
420
        this_tree.lock_write()
467
421
        self.addCleanup(this_tree.unlock)
468
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
422
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
469
423
            this_tree, 'rev2b', other_branch=other_tree.branch)
470
424
        merger.merge_type = _mod_merge.Merge3Merger
471
425
        tree_merger = merger.make_merger()
495
449
        other_tree.commit('rev2', rev_id='rev2b')
496
450
        this_tree.lock_write()
497
451
        self.addCleanup(this_tree.unlock)
498
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
452
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
499
453
            this_tree, 'rev2b', other_branch=other_tree.branch)
500
454
        merger.merge_type = _mod_merge.Merge3Merger
501
455
        tree_merger = merger.make_merger()
506
460
        finally:
507
461
            tree_file.close()
508
462
 
509
 
    def test_merge_require_tree_root(self):
510
 
        tree = self.make_branch_and_tree(".")
511
 
        tree.lock_write()
512
 
        self.addCleanup(tree.unlock)
513
 
        self.build_tree(['a'])
514
 
        tree.add('a')
515
 
        first_rev = tree.commit("added a")
516
 
        old_root_id = tree.get_root_id()
517
 
        merger = _mod_merge.Merger.from_revision_ids(None, tree,
518
 
                                          _mod_revision.NULL_REVISION,
519
 
                                          first_rev)
520
 
        merger.merge_type = _mod_merge.Merge3Merger
521
 
        conflict_count = merger.do_merge()
522
 
        self.assertEqual(0, conflict_count)
523
 
        self.assertEquals(set([old_root_id]), tree.all_file_ids())
524
 
        tree.set_parent_ids([])
525
 
 
526
463
    def test_merge_add_into_deleted_root(self):
527
464
        # Yes, people actually do this.  And report bugs if it breaks.
528
465
        source = self.make_branch_and_tree('source', format='rich-root-pack')
1268
1205
        mem_tree = memorytree.MemoryTree.create_on_branch(builder.get_branch())
1269
1206
        mem_tree.lock_write()
1270
1207
        self.addCleanup(mem_tree.unlock)
1271
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
1208
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
1272
1209
            mem_tree, other_revision_id)
1273
1210
        merger.set_interesting_files(interesting_files)
1274
1211
        # It seems there is no matching function for set_interesting_ids
1337
1274
        self.assertEqual(['B-id', 'C-id', 'F-id'],
1338
1275
                         [t.get_revision_id() for t in merger._lca_trees])
1339
1276
 
1340
 
    def test_find_base_new_root_criss_cross(self):
1341
 
        # A   B
1342
 
        # |\ /|
1343
 
        # | X |
1344
 
        # |/ \|
1345
 
        # C   D
1346
 
        
1347
 
        builder = self.get_builder()
1348
 
        builder.build_snapshot('A-id', None,
1349
 
            [('add', ('', None, 'directory', None))])
1350
 
        builder.build_snapshot('B-id', [],
1351
 
            [('add', ('', None, 'directory', None))])
1352
 
        builder.build_snapshot('D-id', ['A-id', 'B-id'], [])
1353
 
        builder.build_snapshot('C-id', ['A-id', 'B-id'], [])
1354
 
        merger = self.make_Merger(builder, 'D-id')
1355
 
        self.assertEqual('A-id', merger.base_rev_id)
1356
 
        self.assertTrue(merger._is_criss_cross)
1357
 
        self.assertEqual(['A-id', 'B-id'], [t.get_revision_id()
1358
 
                                            for t in merger._lca_trees])
1359
 
 
1360
1277
    def test_no_criss_cross_passed_to_merge_type(self):
1361
1278
        class LCATreesMerger(LoggingMerger):
1362
1279
            supports_lca_trees = True
1894
1811
        builder.build_snapshot('C-id', ['A-id'], [])
1895
1812
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1896
1813
            [('unversion', 'a-id'),
1897
 
             ('flush', None),
1898
1814
             ('add', (u'a', 'a-id', 'directory', None))])
1899
1815
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1900
1816
        merge_obj = self.make_merge_obj(builder, 'E-id')
1918
1834
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
1919
1835
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
1920
1836
            [('unversion', 'a-id'),
1921
 
             ('flush', None),
1922
1837
             ('add', (u'a', 'a-id', 'directory', None))])
1923
1838
        merge_obj = self.make_merge_obj(builder, 'E-id')
1924
1839
        entries = list(merge_obj._entries_lca())
2070
1985
 
2071
1986
    def do_merge(self, builder, other_revision_id):
2072
1987
        wt = self.get_wt_from_builder(builder)
2073
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
1988
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2074
1989
            wt, other_revision_id)
2075
1990
        merger.merge_type = _mod_merge.Merge3Merger
2076
1991
        return wt, merger.do_merge()
2187
2102
        self.assertTrue(wt.is_executable('foo-id'))
2188
2103
 
2189
2104
    def test_create_symlink(self):
2190
 
        self.requireFeature(features.SymlinkFeature)
 
2105
        self.requireFeature(tests.SymlinkFeature)
2191
2106
        #   A
2192
2107
        #  / \
2193
2108
        # B   C
2252
2167
                             wt.get_file_text('foo-id'))
2253
2168
 
2254
2169
    def test_modified_symlink(self):
2255
 
        self.requireFeature(features.SymlinkFeature)
 
2170
        self.requireFeature(tests.SymlinkFeature)
2256
2171
        #   A       Create symlink foo => bar
2257
2172
        #  / \
2258
2173
        # B   C     B relinks foo => baz
2297
2212
        self.assertEqual('bing', wt.get_symlink_target('foo-id'))
2298
2213
 
2299
2214
    def test_renamed_symlink(self):
2300
 
        self.requireFeature(features.SymlinkFeature)
 
2215
        self.requireFeature(tests.SymlinkFeature)
2301
2216
        #   A       Create symlink foo => bar
2302
2217
        #  / \
2303
2218
        # B   C     B renames foo => barry
2336
2251
        wt.commit('D merges B & C', rev_id='D-id')
2337
2252
        self.assertEqual('barry', wt.id2path('foo-id'))
2338
2253
        # Check the output of the Merger object directly
2339
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2254
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2340
2255
            wt, 'F-id')
2341
2256
        merger.merge_type = _mod_merge.Merge3Merger
2342
2257
        merge_obj = merger.make_merger()
2353
2268
        self.assertEqual('blah', wt.id2path('foo-id'))
2354
2269
 
2355
2270
    def test_symlink_no_content_change(self):
2356
 
        self.requireFeature(features.SymlinkFeature)
 
2271
        self.requireFeature(tests.SymlinkFeature)
2357
2272
        #   A       Create symlink foo => bar
2358
2273
        #  / \
2359
2274
        # B   C     B relinks foo => baz
2392
2307
        wt.commit('F foo => bing', rev_id='F-id')
2393
2308
 
2394
2309
        # Check the output of the Merger object directly
2395
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2310
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2396
2311
            wt, 'E-id')
2397
2312
        merger.merge_type = _mod_merge.Merge3Merger
2398
2313
        merge_obj = merger.make_merger()
2404
2319
        self.assertEqual('bing', wt.get_symlink_target('foo-id'))
2405
2320
 
2406
2321
    def test_symlink_this_changed_kind(self):
2407
 
        self.requireFeature(features.SymlinkFeature)
 
2322
        self.requireFeature(tests.SymlinkFeature)
2408
2323
        #   A       Nothing
2409
2324
        #  / \
2410
2325
        # B   C     B creates symlink foo => bar
2443
2358
        list(wt.iter_changes(wt.basis_tree()))
2444
2359
        wt.commit('D merges B & C, makes it a file', rev_id='D-id')
2445
2360
 
2446
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2361
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2447
2362
            wt, 'E-id')
2448
2363
        merger.merge_type = _mod_merge.Merge3Merger
2449
2364
        merge_obj = merger.make_merger()
2457
2372
 
2458
2373
    def test_symlink_all_wt(self):
2459
2374
        """Check behavior if all trees are Working Trees."""
2460
 
        self.requireFeature(features.SymlinkFeature)
 
2375
        self.requireFeature(tests.SymlinkFeature)
2461
2376
        # The big issue is that entry.symlink_target is None for WorkingTrees.
2462
2377
        # So we need to make sure we handle that case correctly.
2463
2378
        #   A   foo => bar
2634
2549
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2635
2550
        # 'tree-reference'
2636
2551
        wt = self.make_branch_and_tree('tree',
2637
 
            format='development-subtree')
 
2552
            format='dirstate-with-subtree')
2638
2553
        wt.lock_write()
2639
2554
        self.addCleanup(wt.unlock)
2640
2555
        sub_tree = self.make_branch_and_tree('tree/sub-tree',
2641
 
            format='development-subtree')
 
2556
            format='dirstate-with-subtree')
2642
2557
        wt.set_root_id('a-root-id')
2643
2558
        sub_tree.set_root_id('sub-tree-root')
2644
2559
        self.build_tree_contents([('tree/sub-tree/file', 'text1')])
2658
2573
        wt.branch.set_last_revision_info(2, 'B-id')
2659
2574
        wt.commit('D', rev_id='D-id', recursive=None)
2660
2575
 
2661
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2576
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2662
2577
            wt, 'E-id')
2663
2578
        merger.merge_type = _mod_merge.Merge3Merger
2664
2579
        merge_obj = merger.make_merger()
2669
2584
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2670
2585
        # 'tree-reference'
2671
2586
        wt = self.make_branch_and_tree('tree',
2672
 
            format='development-subtree')
 
2587
            format='dirstate-with-subtree')
2673
2588
        wt.lock_write()
2674
2589
        self.addCleanup(wt.unlock)
2675
2590
        sub_tree = self.make_branch_and_tree('tree/sub',
2676
 
            format='development-subtree')
 
2591
            format='dirstate-with-subtree')
2677
2592
        wt.set_root_id('a-root-id')
2678
2593
        sub_tree.set_root_id('sub-tree-root')
2679
2594
        self.build_tree_contents([('tree/sub/file', 'text1')])
2695
2610
        wt.branch.set_last_revision_info(2, 'B-id')
2696
2611
        wt.commit('D', rev_id='D-id', recursive=None)
2697
2612
 
2698
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2613
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2699
2614
            wt, 'E-id')
2700
2615
        merger.merge_type = _mod_merge.Merge3Merger
2701
2616
        merge_obj = merger.make_merger()
2708
2623
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2709
2624
        # 'tree-reference'
2710
2625
        wt = self.make_branch_and_tree('tree',
2711
 
            format='development-subtree')
 
2626
            format='dirstate-with-subtree')
2712
2627
        wt.lock_write()
2713
2628
        self.addCleanup(wt.unlock)
2714
2629
        sub_tree = self.make_branch_and_tree('tree/sub',
2715
 
            format='development-subtree')
 
2630
            format='dirstate-with-subtree')
2716
2631
        wt.set_root_id('a-root-id')
2717
2632
        sub_tree.set_root_id('sub-tree-root')
2718
2633
        self.build_tree_contents([('tree/sub/file', 'text1')])
2735
2650
        wt.branch.set_last_revision_info(2, 'B-id')
2736
2651
        wt.commit('D', rev_id='D-id', recursive=None)
2737
2652
 
2738
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2653
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2739
2654
            wt, 'E-id')
2740
2655
        merger.merge_type = _mod_merge.Merge3Merger
2741
2656
        merge_obj = merger.make_merger()
2751
2666
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2752
2667
        # 'tree-reference'
2753
2668
        wt = self.make_branch_and_tree('tree',
2754
 
            format='development-subtree')
 
2669
            format='dirstate-with-subtree')
2755
2670
        wt.lock_write()
2756
2671
        self.addCleanup(wt.unlock)
2757
2672
        sub_tree = self.make_branch_and_tree('tree/sub',
2758
 
            format='development-subtree')
 
2673
            format='dirstate-with-subtree')
2759
2674
        wt.set_root_id('a-root-id')
2760
2675
        sub_tree.set_root_id('sub-tree-root')
2761
2676
        self.build_tree_contents([('tree/sub/file', 'text1')])
2780
2695
        wt.branch.set_last_revision_info(2, 'B-id')
2781
2696
        wt.commit('D', rev_id='D-id', recursive=None)
2782
2697
 
2783
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2698
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2784
2699
            wt, 'E-id')
2785
2700
        merger.merge_type = _mod_merge.Merge3Merger
2786
2701
        merge_obj = merger.make_merger()
2932
2847
 
2933
2848
    def get_merger_factory(self):
2934
2849
        # Allows  the inner methods to access the test attributes
2935
 
        calls = self.calls
 
2850
        test = self
2936
2851
 
2937
2852
        class FooMerger(_mod_merge.ConfigurableFileMerger):
2938
2853
            name_prefix = "foo"
2939
2854
            default_files = ['bar']
2940
2855
 
2941
2856
            def merge_text(self, params):
2942
 
                calls.append('merge_text')
 
2857
                test.calls.append('merge_text')
2943
2858
                return ('not_applicable', None)
2944
2859
 
2945
2860
        def factory(merger):
2979
2894
                        base=False, other=False)
2980
2895
        return builder
2981
2896
 
2982
 
    def test_uses_this_branch(self):
2983
 
        builder = self.make_text_conflict()
2984
 
        tt = builder.make_preview_transform()
2985
 
        self.addCleanup(tt.finalize)
2986
 
 
2987
2897
    def test_affected_files_cached(self):
2988
2898
        """Ensures that the config variable is cached"""
2989
2899
        builder = self.make_text_conflict()
3009
2919
        conflicts = builder.merge()
3010
2920
        # The hook should not call the merge_text() method
3011
2921
        self.assertEqual([], self.calls)
3012
 
 
3013
 
 
3014
 
class TestMergeIntoBase(tests.TestCaseWithTransport):
3015
 
 
3016
 
    def setup_simple_branch(self, relpath, shape=None, root_id=None):
3017
 
        """One commit, containing tree specified by optional shape.
3018
 
        
3019
 
        Default is empty tree (just root entry).
3020
 
        """
3021
 
        if root_id is None:
3022
 
            root_id = '%s-root-id' % (relpath,)
3023
 
        wt = self.make_branch_and_tree(relpath)
3024
 
        wt.set_root_id(root_id)
3025
 
        if shape is not None:
3026
 
            adjusted_shape = [relpath + '/' + elem for elem in shape]
3027
 
            self.build_tree(adjusted_shape)
3028
 
            ids = ['%s-%s-id' % (relpath, basename(elem.rstrip('/')))
3029
 
                   for elem in shape]
3030
 
            wt.add(shape, ids=ids)
3031
 
        rev_id = 'r1-%s' % (relpath,)
3032
 
        wt.commit("Initial commit of %s" % (relpath,), rev_id=rev_id)
3033
 
        self.assertEqual(root_id, wt.path2id(''))
3034
 
        return wt
3035
 
 
3036
 
    def setup_two_branches(self, custom_root_ids=True):
3037
 
        """Setup 2 branches, one will be a library, the other a project."""
3038
 
        if custom_root_ids:
3039
 
            root_id = None
3040
 
        else:
3041
 
            root_id = inventory.ROOT_ID
3042
 
        project_wt = self.setup_simple_branch(
3043
 
            'project', ['README', 'dir/', 'dir/file.c'],
3044
 
            root_id)
3045
 
        lib_wt = self.setup_simple_branch(
3046
 
            'lib1', ['README', 'Makefile', 'foo.c'], root_id)
3047
 
 
3048
 
        return project_wt, lib_wt
3049
 
 
3050
 
    def do_merge_into(self, location, merge_as):
3051
 
        """Helper for using MergeIntoMerger.
3052
 
        
3053
 
        :param location: location of directory to merge from, either the
3054
 
            location of a branch or of a path inside a branch.
3055
 
        :param merge_as: the path in a tree to add the new directory as.
3056
 
        :returns: the conflicts from 'do_merge'.
3057
 
        """
3058
 
        operation = cleanup.OperationWithCleanups(self._merge_into)
3059
 
        return operation.run(location, merge_as)
3060
 
 
3061
 
    def _merge_into(self, op, location, merge_as):
3062
 
        # Open and lock the various tree and branch objects
3063
 
        wt, subdir_relpath = WorkingTree.open_containing(merge_as)
3064
 
        op.add_cleanup(wt.lock_write().unlock)
3065
 
        branch_to_merge, subdir_to_merge = _mod_branch.Branch.open_containing(
3066
 
            location)
3067
 
        op.add_cleanup(branch_to_merge.lock_read().unlock)
3068
 
        other_tree = branch_to_merge.basis_tree()
3069
 
        op.add_cleanup(other_tree.lock_read().unlock)
3070
 
        # Perform the merge
3071
 
        merger = _mod_merge.MergeIntoMerger(this_tree=wt, other_tree=other_tree,
3072
 
            other_branch=branch_to_merge, target_subdir=subdir_relpath,
3073
 
            source_subpath=subdir_to_merge)
3074
 
        merger.set_base_revision(_mod_revision.NULL_REVISION, branch_to_merge)
3075
 
        conflicts = merger.do_merge()
3076
 
        merger.set_pending()
3077
 
        return conflicts
3078
 
 
3079
 
    def assertTreeEntriesEqual(self, expected_entries, tree):
3080
 
        """Assert that 'tree' contains the expected inventory entries.
3081
 
 
3082
 
        :param expected_entries: sequence of (path, file-id) pairs.
3083
 
        """
3084
 
        files = [(path, ie.file_id) for path, ie in tree.iter_entries_by_dir()]
3085
 
        self.assertEqual(expected_entries, files)
3086
 
 
3087
 
 
3088
 
class TestMergeInto(TestMergeIntoBase):
3089
 
 
3090
 
    def test_newdir_with_unique_roots(self):
3091
 
        """Merge a branch with a unique root into a new directory."""
3092
 
        project_wt, lib_wt = self.setup_two_branches()
3093
 
        self.do_merge_into('lib1', 'project/lib1')
3094
 
        project_wt.lock_read()
3095
 
        self.addCleanup(project_wt.unlock)
3096
 
        # The r1-lib1 revision should be merged into this one
3097
 
        self.assertEqual(['r1-project', 'r1-lib1'], project_wt.get_parent_ids())
3098
 
        self.assertTreeEntriesEqual(
3099
 
            [('', 'project-root-id'),
3100
 
             ('README', 'project-README-id'),
3101
 
             ('dir', 'project-dir-id'),
3102
 
             ('lib1', 'lib1-root-id'),
3103
 
             ('dir/file.c', 'project-file.c-id'),
3104
 
             ('lib1/Makefile', 'lib1-Makefile-id'),
3105
 
             ('lib1/README', 'lib1-README-id'),
3106
 
             ('lib1/foo.c', 'lib1-foo.c-id'),
3107
 
            ], project_wt)
3108
 
 
3109
 
    def test_subdir(self):
3110
 
        """Merge a branch into a subdirectory of an existing directory."""
3111
 
        project_wt, lib_wt = self.setup_two_branches()
3112
 
        self.do_merge_into('lib1', 'project/dir/lib1')
3113
 
        project_wt.lock_read()
3114
 
        self.addCleanup(project_wt.unlock)
3115
 
        # The r1-lib1 revision should be merged into this one
3116
 
        self.assertEqual(['r1-project', 'r1-lib1'], project_wt.get_parent_ids())
3117
 
        self.assertTreeEntriesEqual(
3118
 
            [('', 'project-root-id'),
3119
 
             ('README', 'project-README-id'),
3120
 
             ('dir', 'project-dir-id'),
3121
 
             ('dir/file.c', 'project-file.c-id'),
3122
 
             ('dir/lib1', 'lib1-root-id'),
3123
 
             ('dir/lib1/Makefile', 'lib1-Makefile-id'),
3124
 
             ('dir/lib1/README', 'lib1-README-id'),
3125
 
             ('dir/lib1/foo.c', 'lib1-foo.c-id'),
3126
 
            ], project_wt)
3127
 
 
3128
 
    def test_newdir_with_repeat_roots(self):
3129
 
        """If the file-id of the dir to be merged already exists a new ID will
3130
 
        be allocated to let the merge happen.
3131
 
        """
3132
 
        project_wt, lib_wt = self.setup_two_branches(custom_root_ids=False)
3133
 
        root_id = project_wt.path2id('')
3134
 
        self.do_merge_into('lib1', 'project/lib1')
3135
 
        project_wt.lock_read()
3136
 
        self.addCleanup(project_wt.unlock)
3137
 
        # The r1-lib1 revision should be merged into this one
3138
 
        self.assertEqual(['r1-project', 'r1-lib1'], project_wt.get_parent_ids())
3139
 
        new_lib1_id = project_wt.path2id('lib1')
3140
 
        self.assertNotEqual(None, new_lib1_id)
3141
 
        self.assertTreeEntriesEqual(
3142
 
            [('', root_id),
3143
 
             ('README', 'project-README-id'),
3144
 
             ('dir', 'project-dir-id'),
3145
 
             ('lib1', new_lib1_id),
3146
 
             ('dir/file.c', 'project-file.c-id'),
3147
 
             ('lib1/Makefile', 'lib1-Makefile-id'),
3148
 
             ('lib1/README', 'lib1-README-id'),
3149
 
             ('lib1/foo.c', 'lib1-foo.c-id'),
3150
 
            ], project_wt)
3151
 
 
3152
 
    def test_name_conflict(self):
3153
 
        """When the target directory name already exists a conflict is
3154
 
        generated and the original directory is renamed to foo.moved.
3155
 
        """
3156
 
        dest_wt = self.setup_simple_branch('dest', ['dir/', 'dir/file.txt'])
3157
 
        src_wt = self.setup_simple_branch('src', ['README'])
3158
 
        conflicts = self.do_merge_into('src', 'dest/dir')
3159
 
        self.assertEqual(1, conflicts)
3160
 
        dest_wt.lock_read()
3161
 
        self.addCleanup(dest_wt.unlock)
3162
 
        # The r1-lib1 revision should be merged into this one
3163
 
        self.assertEqual(['r1-dest', 'r1-src'], dest_wt.get_parent_ids())
3164
 
        self.assertTreeEntriesEqual(
3165
 
            [('', 'dest-root-id'),
3166
 
             ('dir', 'src-root-id'),
3167
 
             ('dir.moved', 'dest-dir-id'),
3168
 
             ('dir/README', 'src-README-id'),
3169
 
             ('dir.moved/file.txt', 'dest-file.txt-id'),
3170
 
            ], dest_wt)
3171
 
 
3172
 
    def test_file_id_conflict(self):
3173
 
        """A conflict is generated if the merge-into adds a file (or other
3174
 
        inventory entry) with a file-id that already exists in the target tree.
3175
 
        """
3176
 
        dest_wt = self.setup_simple_branch('dest', ['file.txt'])
3177
 
        # Make a second tree with a file-id that will clash with file.txt in
3178
 
        # dest.
3179
 
        src_wt = self.make_branch_and_tree('src')
3180
 
        self.build_tree(['src/README'])
3181
 
        src_wt.add(['README'], ids=['dest-file.txt-id'])
3182
 
        src_wt.commit("Rev 1 of src.", rev_id='r1-src')
3183
 
        conflicts = self.do_merge_into('src', 'dest/dir')
3184
 
        # This is an edge case that shouldn't happen to users very often.  So
3185
 
        # we don't care really about the exact presentation of the conflict,
3186
 
        # just that there is one.
3187
 
        self.assertEqual(1, conflicts)
3188
 
 
3189
 
    def test_only_subdir(self):
3190
 
        """When the location points to just part of a tree, merge just that
3191
 
        subtree.
3192
 
        """
3193
 
        dest_wt = self.setup_simple_branch('dest')
3194
 
        src_wt = self.setup_simple_branch(
3195
 
            'src', ['hello.txt', 'dir/', 'dir/foo.c'])
3196
 
        conflicts = self.do_merge_into('src/dir', 'dest/dir')
3197
 
        dest_wt.lock_read()
3198
 
        self.addCleanup(dest_wt.unlock)
3199
 
        # The r1-lib1 revision should NOT be merged into this one (this is a
3200
 
        # partial merge).
3201
 
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
3202
 
        self.assertTreeEntriesEqual(
3203
 
            [('', 'dest-root-id'),
3204
 
             ('dir', 'src-dir-id'),
3205
 
             ('dir/foo.c', 'src-foo.c-id'),
3206
 
            ], dest_wt)
3207
 
 
3208
 
    def test_only_file(self):
3209
 
        """An edge case: merge just one file, not a whole dir."""
3210
 
        dest_wt = self.setup_simple_branch('dest')
3211
 
        two_file_wt = self.setup_simple_branch(
3212
 
            'two-file', ['file1.txt', 'file2.txt'])
3213
 
        conflicts = self.do_merge_into('two-file/file1.txt', 'dest/file1.txt')
3214
 
        dest_wt.lock_read()
3215
 
        self.addCleanup(dest_wt.unlock)
3216
 
        # The r1-lib1 revision should NOT be merged into this one
3217
 
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
3218
 
        self.assertTreeEntriesEqual(
3219
 
            [('', 'dest-root-id'), ('file1.txt', 'two-file-file1.txt-id')],
3220
 
            dest_wt)
3221
 
 
3222
 
    def test_no_such_source_path(self):
3223
 
        """PathNotInTree is raised if the specified path in the source tree
3224
 
        does not exist.
3225
 
        """
3226
 
        dest_wt = self.setup_simple_branch('dest')
3227
 
        two_file_wt = self.setup_simple_branch('src', ['dir/'])
3228
 
        self.assertRaises(_mod_merge.PathNotInTree, self.do_merge_into,
3229
 
            'src/no-such-dir', 'dest/foo')
3230
 
        dest_wt.lock_read()
3231
 
        self.addCleanup(dest_wt.unlock)
3232
 
        # The dest tree is unmodified.
3233
 
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
3234
 
        self.assertTreeEntriesEqual([('', 'dest-root-id')], dest_wt)
3235
 
 
3236
 
    def test_no_such_target_path(self):
3237
 
        """PathNotInTree is also raised if the specified path in the target
3238
 
        tree does not exist.
3239
 
        """
3240
 
        dest_wt = self.setup_simple_branch('dest')
3241
 
        two_file_wt = self.setup_simple_branch('src', ['file.txt'])
3242
 
        self.assertRaises(_mod_merge.PathNotInTree, self.do_merge_into,
3243
 
            'src', 'dest/no-such-dir/foo')
3244
 
        dest_wt.lock_read()
3245
 
        self.addCleanup(dest_wt.unlock)
3246
 
        # The dest tree is unmodified.
3247
 
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
3248
 
        self.assertTreeEntriesEqual([('', 'dest-root-id')], dest_wt)
3249
 
 
3250
 
 
3251
 
class TestMergeHooks(TestCaseWithTransport):
3252
 
 
3253
 
    def setUp(self):
3254
 
        super(TestMergeHooks, self).setUp()
3255
 
        self.tree_a = self.make_branch_and_tree('tree_a')
3256
 
        self.build_tree_contents([('tree_a/file', 'content_1')])
3257
 
        self.tree_a.add('file', 'file-id')
3258
 
        self.tree_a.commit('added file')
3259
 
 
3260
 
        self.tree_b = self.tree_a.bzrdir.sprout('tree_b').open_workingtree()
3261
 
        self.build_tree_contents([('tree_b/file', 'content_2')])
3262
 
        self.tree_b.commit('modify file')
3263
 
 
3264
 
    def test_pre_merge_hook_inject_different_tree(self):
3265
 
        tree_c = self.tree_b.bzrdir.sprout('tree_c').open_workingtree()
3266
 
        self.build_tree_contents([('tree_c/file', 'content_3')])
3267
 
        tree_c.commit("more content")
3268
 
        calls = []
3269
 
        def factory(merger):
3270
 
            self.assertIsInstance(merger, _mod_merge.Merge3Merger)
3271
 
            merger.other_tree = tree_c
3272
 
            calls.append(merger)
3273
 
        _mod_merge.Merger.hooks.install_named_hook('pre_merge',
3274
 
                                                   factory, 'test factory')
3275
 
        self.tree_a.merge_from_branch(self.tree_b.branch)
3276
 
 
3277
 
        self.assertFileEqual("content_3", 'tree_a/file')
3278
 
        self.assertLength(1, calls)
3279
 
 
3280
 
    def test_post_merge_hook_called(self):
3281
 
        calls = []
3282
 
        def factory(merger):
3283
 
            self.assertIsInstance(merger, _mod_merge.Merge3Merger)
3284
 
            calls.append(merger)
3285
 
        _mod_merge.Merger.hooks.install_named_hook('post_merge',
3286
 
                                                   factory, 'test factory')
3287
 
 
3288
 
        self.tree_a.merge_from_branch(self.tree_b.branch)
3289
 
 
3290
 
        self.assertFileEqual("content_2", 'tree_a/file')
3291
 
        self.assertLength(1, calls)