← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_symbol_versioning.py

  • Committer: Vincent Ladeuil
  • Date: 2010-01-25 15:55:48 UTC
  • mto: (4985.1.4 add-attr-cleanup)
  • mto: This revision was merged to the branch mainline in revision 4988.
  • Revision ID: v.ladeuil+lp@free.fr-20100125155548-0l352pujvt5bzl5e
Deploy addAttrCleanup on the whole test suite.

Several use case worth mentioning:

- setting a module or any other object attribute is the majority
by far. In some cases the setting itself is deferred but most of
the time we want to set at the same time we add the cleanup.

- there multiple occurrences of protecting hooks or ui factory
which are now useless (the test framework takes care of that now),

- there was some lambda uses that can now be avoided.

That first cleanup already simplifies things a lot.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_symbol_versioning.py
76
76
        expected_warning = (
77
77
            "bzrlib.tests.test_symbol_versioning."
78
78
            "deprecated_static "
79
 
            "was deprecated in version 0.7.", DeprecationWarning, 2)
 
79
            "was deprecated in version 0.7.0.", DeprecationWarning, 2)
80
80
        expected_docstring = (
81
81
            'Deprecated static.\n'
82
82
            '\n'
83
 
            'This function was deprecated in version 0.7.\n'
 
83
            'This function was deprecated in version 0.7.0.\n'
84
84
            )
85
85
        self.check_deprecated_callable(
86
86
            expected_warning, expected_docstring,
92
92
        expected_warning = (
93
93
            "bzrlib.tests.test_symbol_versioning."
94
94
            "TestDeprecationWarnings.deprecated_method "
95
 
            "was deprecated in version 0.7.", DeprecationWarning, 2)
96
 
        expected_docstring = ('Deprecated method docstring.\n'
97
 
                              '\n'
98
 
                              '        This might explain stuff.\n'
99
 
                              '        \n'
100
 
                              '        This method was deprecated in version 0.7.\n'
101
 
                              '        ')
 
95
            "was deprecated in version 0.7.0.", DeprecationWarning, 2)
 
96
        expected_docstring = (
 
97
            'Deprecated method docstring.\n'
 
98
            '\n'
 
99
            '        This might explain stuff.\n'
 
100
            '        \n'
 
101
            '        This method was deprecated in version 0.7.0.\n'
 
102
            '        ')
102
103
        self.check_deprecated_callable(expected_warning, expected_docstring,
103
104
                                       "deprecated_method",
104
105
                                       "bzrlib.tests.test_symbol_versioning",
107
108
    def test_deprecated_function(self):
108
109
        expected_warning = (
109
110
            "bzrlib.tests.test_symbol_versioning.sample_deprecated_function "
110
 
            "was deprecated in version 0.7.", DeprecationWarning, 2)
 
111
            "was deprecated in version 0.7.0.", DeprecationWarning, 2)
111
112
        expected_docstring = ('Deprecated function docstring.\n'
112
113
                              '\n'
113
 
                              'This function was deprecated in version 0.7.\n'
 
114
                              'This function was deprecated in version 0.7.0.\n'
114
115
                              )
115
116
        self.check_deprecated_callable(expected_warning, expected_docstring,
116
117
                                       "sample_deprecated_function",
119
120
 
120
121
    def test_deprecated_list(self):
121
122
        expected_warning = (
122
 
            "Modifying a_deprecated_list was deprecated in version 0.9."
 
123
            "Modifying a_deprecated_list was deprecated in version 0.9.0."
123
124
            " Don't use me", DeprecationWarning, 3)
124
125
        old_warning_method = symbol_versioning.warn
125
126
        try:
157
158
 
158
159
    def test_deprecated_dict(self):
159
160
        expected_warning = (
160
 
            "access to a_deprecated_dict was deprecated in version 0.14."
 
161
            "access to a_deprecated_dict was deprecated in version 0.14.0."
161
162
            " Pull the other one!", DeprecationWarning, 2)
162
163
        old_warning_method = symbol_versioning.warn
163
164
        try:
205
206
        """We can get a deprecation string for a method or function."""
206
207
        self.assertEqual('bzrlib.tests.test_symbol_versioning.'
207
208
            'TestDeprecationWarnings.test_deprecation_string was deprecated in '
208
 
            'version 0.11.',
 
209
            'version 0.11.0.',
209
210
            symbol_versioning.deprecation_string(
210
211
            self.test_deprecation_string,
211
212
            deprecated_in((0, 11, 0))))
212
213
        self.assertEqual('bzrlib.symbol_versioning.deprecated_function was '
213
 
            'deprecated in version 0.11.',
 
214
            'deprecated in version 0.11.0.',
214
215
            symbol_versioning.deprecation_string(
215
216
                symbol_versioning.deprecated_function,
216
217
                deprecated_in((0, 11, 0))))
223
224
        existing_filters = list(warnings.filters)
224
225
        def restore():
225
226
            warnings.filters[:] = existing_filters
 
227
        # XXX: Can we address that ? -- vila 100124
226
228
        self.addCleanup(restore)
227
229
        # Clean out the filters so we have a clean slate.
228
230
        warnings.resetwarnings()