~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_remote.py

  • Committer: John Arbash Meinel
  • Date: 2009-11-18 15:47:16 UTC
  • mto: This revision was merged to the branch mainline in revision 4810.
  • Revision ID: john@arbash-meinel.com-20091118154716-meiszr5ej7ohas3v
Move all the stat comparison and platform checkning code to assertEqualStat.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006-2013, 2016 Canonical Ltd
 
1
# Copyright (C) 2006, 2007, 2008, 2009 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
25
25
 
26
26
import bz2
27
27
from cStringIO import StringIO
28
 
import zlib
29
28
 
30
29
from bzrlib import (
31
 
    bencode,
32
30
    branch,
33
31
    bzrdir,
34
32
    config,
35
 
    controldir,
36
33
    errors,
 
34
    graph,
37
35
    inventory,
38
36
    inventory_delta,
 
37
    pack,
39
38
    remote,
40
39
    repository,
41
40
    tests,
42
 
    transport,
43
41
    treebuilder,
 
42
    urlutils,
44
43
    versionedfile,
45
 
    vf_search,
46
44
    )
47
45
from bzrlib.branch import Branch
48
 
from bzrlib.bzrdir import (
49
 
    BzrDir,
50
 
    BzrDirFormat,
51
 
    RemoteBzrProber,
52
 
    )
53
 
from bzrlib.chk_serializer import chk_bencode_serializer
 
46
from bzrlib.bzrdir import BzrDir, BzrDirFormat
54
47
from bzrlib.remote import (
55
48
    RemoteBranch,
56
49
    RemoteBranchFormat,
59
52
    RemoteRepository,
60
53
    RemoteRepositoryFormat,
61
54
    )
62
 
from bzrlib.repofmt import groupcompress_repo, knitpack_repo
63
 
from bzrlib.revision import (
64
 
    NULL_REVISION,
65
 
    Revision,
66
 
    )
67
 
from bzrlib.smart import medium, request
 
55
from bzrlib.repofmt import groupcompress_repo, pack_repo
 
56
from bzrlib.revision import NULL_REVISION
 
57
from bzrlib.smart import server, medium
68
58
from bzrlib.smart.client import _SmartClient
69
 
from bzrlib.smart.repository import (
70
 
    SmartServerRepositoryGetParentMap,
71
 
    SmartServerRepositoryGetStream_1_19,
72
 
    _stream_to_byte_stream,
73
 
    )
74
 
from bzrlib.symbol_versioning import deprecated_in
 
59
from bzrlib.smart.repository import SmartServerRepositoryGetParentMap
75
60
from bzrlib.tests import (
76
 
    test_server,
 
61
    condition_isinstance,
 
62
    split_suite_by_condition,
 
63
    multiply_tests,
77
64
    )
78
 
from bzrlib.tests.scenarios import load_tests_apply_scenarios
 
65
from bzrlib.transport import get_transport
79
66
from bzrlib.transport.memory import MemoryTransport
80
67
from bzrlib.transport.remote import (
81
68
    RemoteTransport,
82
69
    RemoteSSHTransport,
83
70
    RemoteTCPTransport,
84
 
    )
85
 
 
86
 
 
87
 
load_tests = load_tests_apply_scenarios
88
 
 
89
 
 
90
 
class BasicRemoteObjectTests(tests.TestCaseWithTransport):
91
 
 
92
 
    scenarios = [
 
71
)
 
72
 
 
73
def load_tests(standard_tests, module, loader):
 
74
    to_adapt, result = split_suite_by_condition(
 
75
        standard_tests, condition_isinstance(BasicRemoteObjectTests))
 
76
    smart_server_version_scenarios = [
93
77
        ('HPSS-v2',
94
 
            {'transport_server': test_server.SmartTCPServer_for_testing_v2_only}),
 
78
            {'transport_server': server.SmartTCPServer_for_testing_v2_only}),
95
79
        ('HPSS-v3',
96
 
            {'transport_server': test_server.SmartTCPServer_for_testing})]
97
 
 
 
80
            {'transport_server': server.SmartTCPServer_for_testing})]
 
81
    return multiply_tests(to_adapt, smart_server_version_scenarios, result)
 
82
 
 
83
 
 
84
class BasicRemoteObjectTests(tests.TestCaseWithTransport):
98
85
 
99
86
    def setUp(self):
100
87
        super(BasicRemoteObjectTests, self).setUp()
101
88
        self.transport = self.get_transport()
102
89
        # make a branch that can be opened over the smart transport
103
90
        self.local_wt = BzrDir.create_standalone_workingtree('.')
104
 
        self.addCleanup(self.transport.disconnect)
 
91
 
 
92
    def tearDown(self):
 
93
        self.transport.disconnect()
 
94
        tests.TestCaseWithTransport.tearDown(self)
105
95
 
106
96
    def test_create_remote_bzrdir(self):
107
 
        b = remote.RemoteBzrDir(self.transport, RemoteBzrDirFormat())
 
97
        b = remote.RemoteBzrDir(self.transport, remote.RemoteBzrDirFormat())
108
98
        self.assertIsInstance(b, BzrDir)
109
99
 
110
100
    def test_open_remote_branch(self):
111
101
        # open a standalone branch in the working directory
112
 
        b = remote.RemoteBzrDir(self.transport, RemoteBzrDirFormat())
 
102
        b = remote.RemoteBzrDir(self.transport, remote.RemoteBzrDirFormat())
113
103
        branch = b.open_branch()
114
104
        self.assertIsInstance(branch, Branch)
115
105
 
121
111
        self.local_wt.commit(message='test commit', rev_id=revid)
122
112
        self.assertTrue(repo.has_revision(revid))
123
113
 
 
114
    def test_remote_branch_revision_history(self):
 
115
        b = BzrDir.open_from_transport(self.transport).open_branch()
 
116
        self.assertEqual([], b.revision_history())
 
117
        r1 = self.local_wt.commit('1st commit')
 
118
        r2 = self.local_wt.commit('1st commit', rev_id=u'\xc8'.encode('utf8'))
 
119
        self.assertEqual([r1, r2], b.revision_history())
 
120
 
124
121
    def test_find_correct_format(self):
125
122
        """Should open a RemoteBzrDir over a RemoteTransport"""
126
123
        fmt = BzrDirFormat.find_format(self.transport)
127
 
        self.assertTrue(bzrdir.RemoteBzrProber
128
 
                        in controldir.ControlDirFormat._server_probers)
129
 
        self.assertIsInstance(fmt, RemoteBzrDirFormat)
 
124
        self.assertTrue(RemoteBzrDirFormat
 
125
                        in BzrDirFormat._control_server_formats)
 
126
        self.assertIsInstance(fmt, remote.RemoteBzrDirFormat)
130
127
 
131
128
    def test_open_detected_smart_format(self):
132
129
        fmt = BzrDirFormat.find_format(self.transport)
137
134
        b = BzrDir.open_from_transport(self.transport).open_branch()
138
135
        self.assertStartsWith(str(b), 'RemoteBranch(')
139
136
 
140
 
    def test_remote_bzrdir_repr(self):
141
 
        b = BzrDir.open_from_transport(self.transport)
142
 
        self.assertStartsWith(str(b), 'RemoteBzrDir(')
143
 
 
144
137
    def test_remote_branch_format_supports_stacking(self):
145
138
        t = self.transport
146
139
        self.make_branch('unstackable', format='pack-0.92')
166
159
    def test_remote_branch_set_append_revisions_only(self):
167
160
        # Make a format 1.9 branch, which supports append_revisions_only
168
161
        branch = self.make_branch('branch', format='1.9')
 
162
        config = branch.get_config()
169
163
        branch.set_append_revisions_only(True)
170
 
        config = branch.get_config_stack()
171
164
        self.assertEqual(
172
 
            True, config.get('append_revisions_only'))
 
165
            'True', config.get_user_option('append_revisions_only'))
173
166
        branch.set_append_revisions_only(False)
174
 
        config = branch.get_config_stack()
175
167
        self.assertEqual(
176
 
            False, config.get('append_revisions_only'))
 
168
            'False', config.get_user_option('append_revisions_only'))
177
169
 
178
170
    def test_remote_branch_set_append_revisions_only_upgrade_reqd(self):
179
171
        branch = self.make_branch('branch', format='knit')
 
172
        config = branch.get_config()
180
173
        self.assertRaises(
181
174
            errors.UpgradeRequired, branch.set_append_revisions_only, True)
182
175
 
340
333
class TestRemote(tests.TestCaseWithMemoryTransport):
341
334
 
342
335
    def get_branch_format(self):
343
 
        reference_bzrdir_format = controldir.format_registry.get('default')()
 
336
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
344
337
        return reference_bzrdir_format.get_branch_format()
345
338
 
346
339
    def get_repo_format(self):
347
 
        reference_bzrdir_format = controldir.format_registry.get('default')()
 
340
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
348
341
        return reference_bzrdir_format.repository_format
349
342
 
350
343
    def assertFinished(self, fake_client):
361
354
        a given client_base and transport_base.
362
355
        """
363
356
        client_medium = medium.SmartClientMedium(client_base)
364
 
        t = transport.get_transport(transport_base)
365
 
        result = client_medium.remote_path_from_transport(t)
 
357
        transport = get_transport(transport_base)
 
358
        result = client_medium.remote_path_from_transport(transport)
366
359
        self.assertEqual(expected, result)
367
360
 
368
361
    def test_remote_path_from_transport(self):
379
372
        a given transport_base and relpath of that transport.  (Note that
380
373
        HttpTransportBase is a subclass of SmartClientMedium)
381
374
        """
382
 
        base_transport = transport.get_transport(transport_base)
 
375
        base_transport = get_transport(transport_base)
383
376
        client_medium = base_transport.get_smart_medium()
384
377
        cloned_transport = base_transport.clone(relpath)
385
378
        result = client_medium.remote_path_from_transport(cloned_transport)
420
413
        # Calling _remember_remote_is_before again with a lower value works.
421
414
        client_medium._remember_remote_is_before((1, 5))
422
415
        self.assertTrue(client_medium._is_remote_before((1, 5)))
423
 
        # If you call _remember_remote_is_before with a higher value it logs a
424
 
        # warning, and continues to remember the lower value.
425
 
        self.assertNotContainsRe(self.get_log(), '_remember_remote_is_before')
426
 
        client_medium._remember_remote_is_before((1, 9))
427
 
        self.assertContainsRe(self.get_log(), '_remember_remote_is_before')
428
 
        self.assertTrue(client_medium._is_remote_before((1, 5)))
 
416
        # You cannot call _remember_remote_is_before with a larger value.
 
417
        self.assertRaises(
 
418
            AssertionError, client_medium._remember_remote_is_before, (1, 9))
429
419
 
430
420
 
431
421
class TestBzrDirCloningMetaDir(TestRemote):
450
440
            'BzrDir.cloning_metadir', ('quack/', 'False'),
451
441
            'error', ('BranchReference',)),
452
442
        client.add_expected_call(
453
 
            'BzrDir.open_branchV3', ('quack/',),
 
443
            'BzrDir.open_branchV2', ('quack/',),
454
444
            'success', ('ref', self.get_url('referenced'))),
455
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
445
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
456
446
            _client=client)
457
447
        result = a_bzrdir.cloning_metadir()
458
448
        # We should have got a control dir matching the referenced branch.
466
456
        transport = transport.clone('quack')
467
457
        self.make_bzrdir('quack')
468
458
        client = FakeClient(transport.base)
469
 
        reference_bzrdir_format = controldir.format_registry.get('default')()
 
459
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
470
460
        control_name = reference_bzrdir_format.network_name()
471
461
        client.add_expected_call(
472
462
            'BzrDir.cloning_metadir', ('quack/', 'False'),
473
463
            'success', (control_name, '', ('branch', ''))),
474
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
464
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
475
465
            _client=client)
476
466
        result = a_bzrdir.cloning_metadir()
477
467
        # We should have got a reference control dir with default branch and
482
472
        self.assertEqual(None, result._branch_format)
483
473
        self.assertFinished(client)
484
474
 
485
 
    def test_unknown(self):
486
 
        transport = self.get_transport('quack')
487
 
        referenced = self.make_branch('referenced')
488
 
        expected = referenced.bzrdir.cloning_metadir()
489
 
        client = FakeClient(transport.base)
490
 
        client.add_expected_call(
491
 
            'BzrDir.cloning_metadir', ('quack/', 'False'),
492
 
            'success', ('unknown', 'unknown', ('branch', ''))),
493
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
494
 
            _client=client)
495
 
        self.assertRaises(errors.UnknownFormatError, a_bzrdir.cloning_metadir)
496
 
 
497
 
 
498
 
class TestBzrDirCheckoutMetaDir(TestRemote):
499
 
 
500
 
    def test__get_checkout_format(self):
501
 
        transport = MemoryTransport()
502
 
        client = FakeClient(transport.base)
503
 
        reference_bzrdir_format = controldir.format_registry.get('default')()
504
 
        control_name = reference_bzrdir_format.network_name()
505
 
        client.add_expected_call(
506
 
            'BzrDir.checkout_metadir', ('quack/', ),
507
 
            'success', (control_name, '', ''))
508
 
        transport.mkdir('quack')
509
 
        transport = transport.clone('quack')
510
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
511
 
            _client=client)
512
 
        result = a_bzrdir.checkout_metadir()
513
 
        # We should have got a reference control dir with default branch and
514
 
        # repository formats.
515
 
        self.assertEqual(bzrdir.BzrDirMetaFormat1, type(result))
516
 
        self.assertEqual(None, result._repository_format)
517
 
        self.assertEqual(None, result._branch_format)
518
 
        self.assertFinished(client)
519
 
 
520
 
    def test_unknown_format(self):
521
 
        transport = MemoryTransport()
522
 
        client = FakeClient(transport.base)
523
 
        client.add_expected_call(
524
 
            'BzrDir.checkout_metadir', ('quack/',),
525
 
            'success', ('dontknow', '', ''))
526
 
        transport.mkdir('quack')
527
 
        transport = transport.clone('quack')
528
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
529
 
            _client=client)
530
 
        self.assertRaises(errors.UnknownFormatError,
531
 
            a_bzrdir.checkout_metadir)
532
 
        self.assertFinished(client)
533
 
 
534
 
 
535
 
class TestBzrDirGetBranches(TestRemote):
536
 
 
537
 
    def test_get_branches(self):
538
 
        transport = MemoryTransport()
539
 
        client = FakeClient(transport.base)
540
 
        reference_bzrdir_format = controldir.format_registry.get('default')()
541
 
        branch_name = reference_bzrdir_format.get_branch_format().network_name()
542
 
        client.add_success_response_with_body(
543
 
            bencode.bencode({
544
 
                "foo": ("branch", branch_name),
545
 
                "": ("branch", branch_name)}), "success")
546
 
        client.add_success_response(
547
 
            'ok', '', 'no', 'no', 'no',
548
 
                reference_bzrdir_format.repository_format.network_name())
549
 
        client.add_error_response('NotStacked')
550
 
        client.add_success_response(
551
 
            'ok', '', 'no', 'no', 'no',
552
 
                reference_bzrdir_format.repository_format.network_name())
553
 
        client.add_error_response('NotStacked')
554
 
        transport.mkdir('quack')
555
 
        transport = transport.clone('quack')
556
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
557
 
            _client=client)
558
 
        result = a_bzrdir.get_branches()
559
 
        self.assertEqual(set(["", "foo"]), set(result.keys()))
560
 
        self.assertEqual(
561
 
            [('call_expecting_body', 'BzrDir.get_branches', ('quack/',)),
562
 
             ('call', 'BzrDir.find_repositoryV3', ('quack/', )),
563
 
             ('call', 'Branch.get_stacked_on_url', ('quack/', )),
564
 
             ('call', 'BzrDir.find_repositoryV3', ('quack/', )),
565
 
             ('call', 'Branch.get_stacked_on_url', ('quack/', ))],
566
 
            client._calls)
567
 
 
568
 
 
569
 
class TestBzrDirDestroyBranch(TestRemote):
570
 
 
571
 
    def test_destroy_default(self):
572
 
        transport = self.get_transport('quack')
573
 
        referenced = self.make_branch('referenced')
574
 
        client = FakeClient(transport.base)
575
 
        client.add_expected_call(
576
 
            'BzrDir.destroy_branch', ('quack/', ),
577
 
            'success', ('ok',)),
578
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
579
 
            _client=client)
580
 
        a_bzrdir.destroy_branch()
581
 
        self.assertFinished(client)
582
 
 
583
 
 
584
 
class TestBzrDirHasWorkingTree(TestRemote):
585
 
 
586
 
    def test_has_workingtree(self):
587
 
        transport = self.get_transport('quack')
588
 
        client = FakeClient(transport.base)
589
 
        client.add_expected_call(
590
 
            'BzrDir.has_workingtree', ('quack/',),
591
 
            'success', ('yes',)),
592
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
593
 
            _client=client)
594
 
        self.assertTrue(a_bzrdir.has_workingtree())
595
 
        self.assertFinished(client)
596
 
 
597
 
    def test_no_workingtree(self):
598
 
        transport = self.get_transport('quack')
599
 
        client = FakeClient(transport.base)
600
 
        client.add_expected_call(
601
 
            'BzrDir.has_workingtree', ('quack/',),
602
 
            'success', ('no',)),
603
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
604
 
            _client=client)
605
 
        self.assertFalse(a_bzrdir.has_workingtree())
606
 
        self.assertFinished(client)
607
 
 
608
 
 
609
 
class TestBzrDirDestroyRepository(TestRemote):
610
 
 
611
 
    def test_destroy_repository(self):
612
 
        transport = self.get_transport('quack')
613
 
        client = FakeClient(transport.base)
614
 
        client.add_expected_call(
615
 
            'BzrDir.destroy_repository', ('quack/',),
616
 
            'success', ('ok',)),
617
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
618
 
            _client=client)
619
 
        a_bzrdir.destroy_repository()
620
 
        self.assertFinished(client)
621
 
 
622
475
 
623
476
class TestBzrDirOpen(TestRemote):
624
477
 
634
487
        client.add_expected_call(
635
488
            'BzrDir.open_2.1', ('quack/',), 'success', ('no',))
636
489
        self.assertRaises(errors.NotBranchError, RemoteBzrDir, transport,
637
 
                RemoteBzrDirFormat(), _client=client, _force_probe=True)
 
490
                remote.RemoteBzrDirFormat(), _client=client, _force_probe=True)
638
491
        self.assertFinished(client)
639
492
 
640
493
    def test_present_without_workingtree(self):
641
494
        client, transport = self.make_fake_client_and_transport()
642
495
        client.add_expected_call(
643
496
            'BzrDir.open_2.1', ('quack/',), 'success', ('yes', 'no'))
644
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
497
        bd = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
645
498
            _client=client, _force_probe=True)
646
499
        self.assertIsInstance(bd, RemoteBzrDir)
647
500
        self.assertFalse(bd.has_workingtree())
652
505
        client, transport = self.make_fake_client_and_transport()
653
506
        client.add_expected_call(
654
507
            'BzrDir.open_2.1', ('quack/',), 'success', ('yes', 'yes'))
655
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
508
        bd = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
656
509
            _client=client, _force_probe=True)
657
510
        self.assertIsInstance(bd, RemoteBzrDir)
658
511
        self.assertTrue(bd.has_workingtree())
665
518
            'BzrDir.open_2.1', ('quack/',), 'unknown', ('BzrDir.open_2.1',))
666
519
        client.add_expected_call(
667
520
            'BzrDir.open', ('quack/',), 'success', ('yes',))
668
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
669
 
            _client=client, _force_probe=True)
670
 
        self.assertIsInstance(bd, RemoteBzrDir)
671
 
        self.assertFinished(client)
672
 
 
673
 
    def test_backwards_compat_hpss_v2(self):
674
 
        client, transport = self.make_fake_client_and_transport()
675
 
        # Monkey-patch fake client to simulate real-world behaviour with v2
676
 
        # server: upon first RPC call detect the protocol version, and because
677
 
        # the version is 2 also do _remember_remote_is_before((1, 6)) before
678
 
        # continuing with the RPC.
679
 
        orig_check_call = client._check_call
680
 
        def check_call(method, args):
681
 
            client._medium._protocol_version = 2
682
 
            client._medium._remember_remote_is_before((1, 6))
683
 
            client._check_call = orig_check_call
684
 
            client._check_call(method, args)
685
 
        client._check_call = check_call
686
 
        client.add_expected_call(
687
 
            'BzrDir.open_2.1', ('quack/',), 'unknown', ('BzrDir.open_2.1',))
688
 
        client.add_expected_call(
689
 
            'BzrDir.open', ('quack/',), 'success', ('yes',))
690
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
521
        bd = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
691
522
            _client=client, _force_probe=True)
692
523
        self.assertIsInstance(bd, RemoteBzrDir)
693
524
        self.assertFinished(client)
700
531
        self.make_branch('.')
701
532
        a_dir = BzrDir.open(self.get_url('.'))
702
533
        self.reset_smart_call_log()
703
 
        verb = 'BzrDir.open_branchV3'
 
534
        verb = 'BzrDir.open_branchV2'
704
535
        self.disable_verb(verb)
705
536
        format = a_dir.open_branch()
706
537
        call_count = len([call for call in self.hpss_calls if
716
547
        transport = transport.clone('quack')
717
548
        client = FakeClient(transport.base)
718
549
        client.add_expected_call(
719
 
            'BzrDir.open_branchV3', ('quack/',),
 
550
            'BzrDir.open_branchV2', ('quack/',),
720
551
            'success', ('branch', branch_network_name))
721
552
        client.add_expected_call(
722
553
            'BzrDir.find_repositoryV3', ('quack/',),
724
555
        client.add_expected_call(
725
556
            'Branch.get_stacked_on_url', ('quack/',),
726
557
            'error', ('NotStacked',))
727
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
558
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
728
559
            _client=client)
729
560
        result = bzrdir.open_branch()
730
561
        self.assertIsInstance(result, RemoteBranch)
737
568
        transport = transport.clone('quack')
738
569
        client = FakeClient(transport.base)
739
570
        client.add_error_response('nobranch')
740
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
571
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
741
572
            _client=client)
742
573
        self.assertRaises(errors.NotBranchError, bzrdir.open_branch)
743
574
        self.assertEqual(
744
 
            [('call', 'BzrDir.open_branchV3', ('quack/',))],
 
575
            [('call', 'BzrDir.open_branchV2', ('quack/',))],
745
576
            client._calls)
746
577
 
747
578
    def test__get_tree_branch(self):
748
579
        # _get_tree_branch is a form of open_branch, but it should only ask for
749
580
        # branch opening, not any other network requests.
750
581
        calls = []
751
 
        def open_branch(name=None, possible_transports=None):
 
582
        def open_branch():
752
583
            calls.append("Called")
753
584
            return "a-branch"
754
585
        transport = MemoryTransport()
755
586
        # no requests on the network - catches other api calls being made.
756
587
        client = FakeClient(transport.base)
757
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
588
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
758
589
            _client=client)
759
590
        # patch the open_branch call to record that it was called.
760
591
        bzrdir.open_branch = open_branch
771
602
        network_name = reference_format.network_name()
772
603
        branch_network_name = self.get_branch_format().network_name()
773
604
        client.add_expected_call(
774
 
            'BzrDir.open_branchV3', ('~hello/',),
 
605
            'BzrDir.open_branchV2', ('~hello/',),
775
606
            'success', ('branch', branch_network_name))
776
607
        client.add_expected_call(
777
608
            'BzrDir.find_repositoryV3', ('~hello/',),
779
610
        client.add_expected_call(
780
611
            'Branch.get_stacked_on_url', ('~hello/',),
781
612
            'error', ('NotStacked',))
782
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
613
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
783
614
            _client=client)
784
615
        result = bzrdir.open_branch()
785
616
        self.assertFinished(client)
802
633
        client.add_success_response(
803
634
            'ok', '', rich_response, subtree_response, external_lookup,
804
635
            network_name)
805
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
636
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
806
637
            _client=client)
807
638
        result = bzrdir.open_repository()
808
639
        self.assertEqual(
825
656
        old.
826
657
        """
827
658
        self.assertRaises(errors.NotBranchError,
828
 
            RemoteBzrProber.probe_transport, OldServerTransport())
 
659
            RemoteBzrDirFormat.probe_transport, OldServerTransport())
829
660
 
830
661
 
831
662
class TestBzrDirCreateBranch(TestRemote):
845
676
        transport = transport.clone('quack')
846
677
        self.make_repository('quack')
847
678
        client = FakeClient(transport.base)
848
 
        reference_bzrdir_format = controldir.format_registry.get('default')()
 
679
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
849
680
        reference_format = reference_bzrdir_format.get_branch_format()
850
681
        network_name = reference_format.network_name()
851
682
        reference_repo_fmt = reference_bzrdir_format.repository_format
854
685
            'BzrDir.create_branch', ('quack/', network_name),
855
686
            'success', ('ok', network_name, '', 'no', 'no', 'yes',
856
687
            reference_repo_name))
857
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
688
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
858
689
            _client=client)
859
690
        branch = a_bzrdir.create_branch()
860
691
        # We should have got a remote branch
863
694
        format = branch._format
864
695
        self.assertEqual(network_name, format.network_name())
865
696
 
866
 
    def test_already_open_repo_and_reused_medium(self):
867
 
        """Bug 726584: create_branch(..., repository=repo) should work
868
 
        regardless of what the smart medium's base URL is.
869
 
        """
870
 
        self.transport_server = test_server.SmartTCPServer_for_testing
871
 
        transport = self.get_transport('.')
872
 
        repo = self.make_repository('quack')
873
 
        # Client's medium rooted a transport root (not at the bzrdir)
874
 
        client = FakeClient(transport.base)
875
 
        transport = transport.clone('quack')
876
 
        reference_bzrdir_format = controldir.format_registry.get('default')()
877
 
        reference_format = reference_bzrdir_format.get_branch_format()
878
 
        network_name = reference_format.network_name()
879
 
        reference_repo_fmt = reference_bzrdir_format.repository_format
880
 
        reference_repo_name = reference_repo_fmt.network_name()
881
 
        client.add_expected_call(
882
 
            'BzrDir.create_branch', ('extra/quack/', network_name),
883
 
            'success', ('ok', network_name, '', 'no', 'no', 'yes',
884
 
            reference_repo_name))
885
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
886
 
            _client=client)
887
 
        branch = a_bzrdir.create_branch(repository=repo)
888
 
        # We should have got a remote branch
889
 
        self.assertIsInstance(branch, remote.RemoteBranch)
890
 
        # its format should have the settings from the response
891
 
        format = branch._format
892
 
        self.assertEqual(network_name, format.network_name())
893
 
 
894
697
 
895
698
class TestBzrDirCreateRepository(TestRemote):
896
699
 
909
712
        transport = transport.clone('quack')
910
713
        self.make_bzrdir('quack')
911
714
        client = FakeClient(transport.base)
912
 
        reference_bzrdir_format = controldir.format_registry.get('default')()
 
715
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
913
716
        reference_format = reference_bzrdir_format.repository_format
914
717
        network_name = reference_format.network_name()
915
718
        client.add_expected_call(
917
720
                'Bazaar repository format 2a (needs bzr 1.16 or later)\n',
918
721
                'False'),
919
722
            'success', ('ok', 'yes', 'yes', 'yes', network_name))
920
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
723
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
921
724
            _client=client)
922
725
        repo = a_bzrdir.create_repository()
923
726
        # We should have got a remote repository
946
749
        # name.
947
750
        client.add_success_response_with_body(
948
751
            "Bazaar-NG meta directory, format 1\n", 'ok')
949
 
        client.add_success_response('stat', '0', '65535')
950
752
        client.add_success_response_with_body(
951
753
            reference_format.get_format_string(), 'ok')
952
754
        # PackRepository wants to do a stat
953
755
        client.add_success_response('stat', '0', '65535')
954
756
        remote_transport = RemoteTransport(server_url + 'quack/', medium=False,
955
757
            _client=client)
956
 
        bzrdir = RemoteBzrDir(remote_transport, RemoteBzrDirFormat(),
 
758
        bzrdir = RemoteBzrDir(remote_transport, remote.RemoteBzrDirFormat(),
957
759
            _client=client)
958
760
        repo = bzrdir.open_repository()
959
761
        self.assertEqual(
961
763
             ('call', 'BzrDir.find_repositoryV2', ('quack/',)),
962
764
             ('call', 'BzrDir.find_repository', ('quack/',)),
963
765
             ('call_expecting_body', 'get', ('/quack/.bzr/branch-format',)),
964
 
             ('call', 'stat', ('/quack/.bzr',)),
965
766
             ('call_expecting_body', 'get', ('/quack/.bzr/repository/format',)),
966
767
             ('call', 'stat', ('/quack/.bzr/repository',)),
967
768
             ],
981
782
        # name.
982
783
        client.add_success_response_with_body(
983
784
            "Bazaar-NG meta directory, format 1\n", 'ok')
984
 
        client.add_success_response('stat', '0', '65535')
985
785
        client.add_success_response_with_body(
986
786
            reference_format.get_format_string(), 'ok')
987
787
        # PackRepository wants to do a stat
988
788
        client.add_success_response('stat', '0', '65535')
989
789
        remote_transport = RemoteTransport(server_url + 'quack/', medium=False,
990
790
            _client=client)
991
 
        bzrdir = RemoteBzrDir(remote_transport, RemoteBzrDirFormat(),
 
791
        bzrdir = RemoteBzrDir(remote_transport, remote.RemoteBzrDirFormat(),
992
792
            _client=client)
993
793
        repo = bzrdir.open_repository()
994
794
        self.assertEqual(
995
795
            [('call', 'BzrDir.find_repositoryV3', ('quack/',)),
996
796
             ('call', 'BzrDir.find_repositoryV2', ('quack/',)),
997
797
             ('call_expecting_body', 'get', ('/quack/.bzr/branch-format',)),
998
 
             ('call', 'stat', ('/quack/.bzr',)),
999
798
             ('call_expecting_body', 'get', ('/quack/.bzr/repository/format',)),
1000
799
             ('call', 'stat', ('/quack/.bzr/repository',)),
1001
800
             ],
1010
809
        transport = transport.clone('quack')
1011
810
        client = FakeClient(transport.base)
1012
811
        client.add_success_response('ok', '', 'no', 'no', 'no', network_name)
1013
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
812
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
1014
813
            _client=client)
1015
814
        repo = bzrdir.open_repository()
1016
815
        self.assertEqual(
1023
822
 
1024
823
    def test_success(self):
1025
824
        """Simple test for typical successful call."""
1026
 
        fmt = RemoteBzrDirFormat()
 
825
        fmt = bzrdir.RemoteBzrDirFormat()
1027
826
        default_format_name = BzrDirFormat.get_default_format().network_name()
1028
827
        transport = self.get_transport()
1029
828
        client = FakeClient(transport.base)
1045
844
        """Error responses are translated, e.g. 'PermissionDenied' raises the
1046
845
        corresponding error from the client.
1047
846
        """
1048
 
        fmt = RemoteBzrDirFormat()
 
847
        fmt = bzrdir.RemoteBzrDirFormat()
1049
848
        default_format_name = BzrDirFormat.get_default_format().network_name()
1050
849
        transport = self.get_transport()
1051
850
        client = FakeClient(transport.base)
1069
868
        """Integration test for error translation."""
1070
869
        transport = self.make_smart_server('foo')
1071
870
        transport = transport.clone('no-such-path')
1072
 
        fmt = RemoteBzrDirFormat()
 
871
        fmt = bzrdir.RemoteBzrDirFormat()
1073
872
        err = self.assertRaises(errors.NoSuchFile,
1074
873
            fmt.initialize_on_transport_ex, transport, create_prefix=False)
1075
874
 
1106
905
 
1107
906
    def make_remote_bzrdir(self, transport, client):
1108
907
        """Make a RemotebzrDir using 'client' as the _client."""
1109
 
        return RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
908
        return RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
1110
909
            _client=client)
1111
910
 
1112
911
 
1138
937
        return RemoteBranch(bzrdir, repo, _client=client, format=format)
1139
938
 
1140
939
 
1141
 
class TestBranchBreakLock(RemoteBranchTestCase):
1142
 
 
1143
 
    def test_break_lock(self):
1144
 
        transport_path = 'quack'
1145
 
        transport = MemoryTransport()
1146
 
        client = FakeClient(transport.base)
1147
 
        client.add_expected_call(
1148
 
            'Branch.get_stacked_on_url', ('quack/',),
1149
 
            'error', ('NotStacked',))
1150
 
        client.add_expected_call(
1151
 
            'Branch.break_lock', ('quack/',),
1152
 
            'success', ('ok',))
1153
 
        transport.mkdir('quack')
1154
 
        transport = transport.clone('quack')
1155
 
        branch = self.make_remote_branch(transport, client)
1156
 
        branch.break_lock()
1157
 
        self.assertFinished(client)
1158
 
 
1159
 
 
1160
 
class TestBranchGetPhysicalLockStatus(RemoteBranchTestCase):
1161
 
 
1162
 
    def test_get_physical_lock_status_yes(self):
1163
 
        transport = MemoryTransport()
1164
 
        client = FakeClient(transport.base)
1165
 
        client.add_expected_call(
1166
 
            'Branch.get_stacked_on_url', ('quack/',),
1167
 
            'error', ('NotStacked',))
1168
 
        client.add_expected_call(
1169
 
            'Branch.get_physical_lock_status', ('quack/',),
1170
 
            'success', ('yes',))
1171
 
        transport.mkdir('quack')
1172
 
        transport = transport.clone('quack')
1173
 
        branch = self.make_remote_branch(transport, client)
1174
 
        result = branch.get_physical_lock_status()
1175
 
        self.assertFinished(client)
1176
 
        self.assertEqual(True, result)
1177
 
 
1178
 
    def test_get_physical_lock_status_no(self):
1179
 
        transport = MemoryTransport()
1180
 
        client = FakeClient(transport.base)
1181
 
        client.add_expected_call(
1182
 
            'Branch.get_stacked_on_url', ('quack/',),
1183
 
            'error', ('NotStacked',))
1184
 
        client.add_expected_call(
1185
 
            'Branch.get_physical_lock_status', ('quack/',),
1186
 
            'success', ('no',))
1187
 
        transport.mkdir('quack')
1188
 
        transport = transport.clone('quack')
1189
 
        branch = self.make_remote_branch(transport, client)
1190
 
        result = branch.get_physical_lock_status()
1191
 
        self.assertFinished(client)
1192
 
        self.assertEqual(False, result)
1193
 
 
1194
 
 
1195
940
class TestBranchGetParent(RemoteBranchTestCase):
1196
941
 
1197
942
    def test_no_parent(self):
1287
1032
        verb = 'Branch.set_parent_location'
1288
1033
        self.disable_verb(verb)
1289
1034
        branch.set_parent('http://foo/')
1290
 
        self.assertLength(14, self.hpss_calls)
 
1035
        self.assertLength(12, self.hpss_calls)
1291
1036
 
1292
1037
 
1293
1038
class TestBranchGetTagsBytes(RemoteBranchTestCase):
1368
1113
            [('set_tags_bytes', 'tags bytes')] * 2, real_branch.calls)
1369
1114
 
1370
1115
 
1371
 
class TestBranchHeadsToFetch(RemoteBranchTestCase):
1372
 
 
1373
 
    def test_uses_last_revision_info_and_tags_by_default(self):
1374
 
        transport = MemoryTransport()
1375
 
        client = FakeClient(transport.base)
1376
 
        client.add_expected_call(
1377
 
            'Branch.get_stacked_on_url', ('quack/',),
1378
 
            'error', ('NotStacked',))
1379
 
        client.add_expected_call(
1380
 
            'Branch.last_revision_info', ('quack/',),
1381
 
            'success', ('ok', '1', 'rev-tip'))
1382
 
        client.add_expected_call(
1383
 
            'Branch.get_config_file', ('quack/',),
1384
 
            'success', ('ok',), '')
1385
 
        transport.mkdir('quack')
1386
 
        transport = transport.clone('quack')
1387
 
        branch = self.make_remote_branch(transport, client)
1388
 
        result = branch.heads_to_fetch()
1389
 
        self.assertFinished(client)
1390
 
        self.assertEqual((set(['rev-tip']), set()), result)
1391
 
 
1392
 
    def test_uses_last_revision_info_and_tags_when_set(self):
1393
 
        transport = MemoryTransport()
1394
 
        client = FakeClient(transport.base)
1395
 
        client.add_expected_call(
1396
 
            'Branch.get_stacked_on_url', ('quack/',),
1397
 
            'error', ('NotStacked',))
1398
 
        client.add_expected_call(
1399
 
            'Branch.last_revision_info', ('quack/',),
1400
 
            'success', ('ok', '1', 'rev-tip'))
1401
 
        client.add_expected_call(
1402
 
            'Branch.get_config_file', ('quack/',),
1403
 
            'success', ('ok',), 'branch.fetch_tags = True')
1404
 
        # XXX: this will break if the default format's serialization of tags
1405
 
        # changes, or if the RPC for fetching tags changes from get_tags_bytes.
1406
 
        client.add_expected_call(
1407
 
            'Branch.get_tags_bytes', ('quack/',),
1408
 
            'success', ('d5:tag-17:rev-foo5:tag-27:rev-bare',))
1409
 
        transport.mkdir('quack')
1410
 
        transport = transport.clone('quack')
1411
 
        branch = self.make_remote_branch(transport, client)
1412
 
        result = branch.heads_to_fetch()
1413
 
        self.assertFinished(client)
1414
 
        self.assertEqual(
1415
 
            (set(['rev-tip']), set(['rev-foo', 'rev-bar'])), result)
1416
 
 
1417
 
    def test_uses_rpc_for_formats_with_non_default_heads_to_fetch(self):
1418
 
        transport = MemoryTransport()
1419
 
        client = FakeClient(transport.base)
1420
 
        client.add_expected_call(
1421
 
            'Branch.get_stacked_on_url', ('quack/',),
1422
 
            'error', ('NotStacked',))
1423
 
        client.add_expected_call(
1424
 
            'Branch.heads_to_fetch', ('quack/',),
1425
 
            'success', (['tip'], ['tagged-1', 'tagged-2']))
1426
 
        transport.mkdir('quack')
1427
 
        transport = transport.clone('quack')
1428
 
        branch = self.make_remote_branch(transport, client)
1429
 
        branch._format._use_default_local_heads_to_fetch = lambda: False
1430
 
        result = branch.heads_to_fetch()
1431
 
        self.assertFinished(client)
1432
 
        self.assertEqual((set(['tip']), set(['tagged-1', 'tagged-2'])), result)
1433
 
 
1434
 
    def make_branch_with_tags(self):
1435
 
        self.setup_smart_server_with_call_log()
1436
 
        # Make a branch with a single revision.
1437
 
        builder = self.make_branch_builder('foo')
1438
 
        builder.start_series()
1439
 
        builder.build_snapshot('tip', None, [
1440
 
            ('add', ('', 'root-id', 'directory', ''))])
1441
 
        builder.finish_series()
1442
 
        branch = builder.get_branch()
1443
 
        # Add two tags to that branch
1444
 
        branch.tags.set_tag('tag-1', 'rev-1')
1445
 
        branch.tags.set_tag('tag-2', 'rev-2')
1446
 
        return branch
1447
 
 
1448
 
    def test_backwards_compatible(self):
1449
 
        br = self.make_branch_with_tags()
1450
 
        br.get_config_stack().set('branch.fetch_tags', True)
1451
 
        self.addCleanup(br.lock_read().unlock)
1452
 
        # Disable the heads_to_fetch verb
1453
 
        verb = 'Branch.heads_to_fetch'
1454
 
        self.disable_verb(verb)
1455
 
        self.reset_smart_call_log()
1456
 
        result = br.heads_to_fetch()
1457
 
        self.assertEqual((set(['tip']), set(['rev-1', 'rev-2'])), result)
1458
 
        self.assertEqual(
1459
 
            ['Branch.last_revision_info', 'Branch.get_tags_bytes'],
1460
 
            [call.call.method for call in self.hpss_calls])
1461
 
 
1462
 
    def test_backwards_compatible_no_tags(self):
1463
 
        br = self.make_branch_with_tags()
1464
 
        br.get_config_stack().set('branch.fetch_tags', False)
1465
 
        self.addCleanup(br.lock_read().unlock)
1466
 
        # Disable the heads_to_fetch verb
1467
 
        verb = 'Branch.heads_to_fetch'
1468
 
        self.disable_verb(verb)
1469
 
        self.reset_smart_call_log()
1470
 
        result = br.heads_to_fetch()
1471
 
        self.assertEqual((set(['tip']), set()), result)
1472
 
        self.assertEqual(
1473
 
            ['Branch.last_revision_info'],
1474
 
            [call.call.method for call in self.hpss_calls])
1475
 
 
1476
 
 
1477
1116
class TestBranchLastRevisionInfo(RemoteBranchTestCase):
1478
1117
 
1479
1118
    def test_empty_branch(self):
1534
1173
        client.add_expected_call(
1535
1174
            'Branch.get_stacked_on_url', ('stacked/',),
1536
1175
            'success', ('ok', vfs_url))
1537
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
1176
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
1538
1177
            _client=client)
1539
1178
        repo_fmt = remote.RemoteRepositoryFormat()
1540
1179
        repo_fmt._custom_format = stacked_branch.repository._format
1551
1190
        client = FakeClient(self.get_url())
1552
1191
        branch_network_name = self.get_branch_format().network_name()
1553
1192
        client.add_expected_call(
1554
 
            'BzrDir.open_branchV3', ('stacked/',),
 
1193
            'BzrDir.open_branchV2', ('stacked/',),
1555
1194
            'success', ('branch', branch_network_name))
1556
1195
        client.add_expected_call(
1557
1196
            'BzrDir.find_repositoryV3', ('stacked/',),
1567
1206
        # this will also do vfs access, but that goes direct to the transport
1568
1207
        # and isn't seen by the FakeClient.
1569
1208
        bzrdir = RemoteBzrDir(self.get_transport('stacked'),
1570
 
            RemoteBzrDirFormat(), _client=client)
 
1209
            remote.RemoteBzrDirFormat(), _client=client)
1571
1210
        branch = bzrdir.open_branch()
1572
1211
        result = branch.get_stacked_on_url()
1573
1212
        self.assertEqual('../base', result)
1579
1218
            len(branch.repository._real_repository._fallback_repositories))
1580
1219
 
1581
1220
    def test_get_stacked_on_real_branch(self):
1582
 
        base_branch = self.make_branch('base')
1583
 
        stacked_branch = self.make_branch('stacked')
 
1221
        base_branch = self.make_branch('base', format='1.6')
 
1222
        stacked_branch = self.make_branch('stacked', format='1.6')
1584
1223
        stacked_branch.set_stacked_on_url('../base')
1585
1224
        reference_format = self.get_repo_format()
1586
1225
        network_name = reference_format.network_name()
1587
1226
        client = FakeClient(self.get_url())
1588
1227
        branch_network_name = self.get_branch_format().network_name()
1589
1228
        client.add_expected_call(
1590
 
            'BzrDir.open_branchV3', ('stacked/',),
 
1229
            'BzrDir.open_branchV2', ('stacked/',),
1591
1230
            'success', ('branch', branch_network_name))
1592
1231
        client.add_expected_call(
1593
1232
            'BzrDir.find_repositoryV3', ('stacked/',),
1594
 
            'success', ('ok', '', 'yes', 'no', 'yes', network_name))
 
1233
            'success', ('ok', '', 'no', 'no', 'yes', network_name))
1595
1234
        # called twice, once from constructor and then again by us
1596
1235
        client.add_expected_call(
1597
1236
            'Branch.get_stacked_on_url', ('stacked/',),
1600
1239
            'Branch.get_stacked_on_url', ('stacked/',),
1601
1240
            'success', ('ok', '../base'))
1602
1241
        bzrdir = RemoteBzrDir(self.get_transport('stacked'),
1603
 
            RemoteBzrDirFormat(), _client=client)
 
1242
            remote.RemoteBzrDirFormat(), _client=client)
1604
1243
        branch = bzrdir.open_branch()
1605
1244
        result = branch.get_stacked_on_url()
1606
1245
        self.assertEqual('../base', result)
1614
1253
class TestBranchSetLastRevision(RemoteBranchTestCase):
1615
1254
 
1616
1255
    def test_set_empty(self):
1617
 
        # _set_last_revision_info('null:') is translated to calling
 
1256
        # set_revision_history([]) is translated to calling
1618
1257
        # Branch.set_last_revision(path, '') on the wire.
1619
1258
        transport = MemoryTransport()
1620
1259
        transport.mkdir('branch')
1638
1277
            'Branch.unlock', ('branch/', 'branch token', 'repo token'),
1639
1278
            'success', ('ok',))
1640
1279
        branch = self.make_remote_branch(transport, client)
 
1280
        # This is a hack to work around the problem that RemoteBranch currently
 
1281
        # unnecessarily invokes _ensure_real upon a call to lock_write.
 
1282
        branch._ensure_real = lambda: None
1641
1283
        branch.lock_write()
1642
 
        result = branch._set_last_revision(NULL_REVISION)
 
1284
        result = branch.set_revision_history([])
1643
1285
        branch.unlock()
1644
1286
        self.assertEqual(None, result)
1645
1287
        self.assertFinished(client)
1646
1288
 
1647
1289
    def test_set_nonempty(self):
1648
 
        # set_last_revision_info(N, rev-idN) is translated to calling
 
1290
        # set_revision_history([rev-id1, ..., rev-idN]) is translated to calling
1649
1291
        # Branch.set_last_revision(path, rev-idN) on the wire.
1650
1292
        transport = MemoryTransport()
1651
1293
        transport.mkdir('branch')
1672
1314
            'Branch.unlock', ('branch/', 'branch token', 'repo token'),
1673
1315
            'success', ('ok',))
1674
1316
        branch = self.make_remote_branch(transport, client)
 
1317
        # This is a hack to work around the problem that RemoteBranch currently
 
1318
        # unnecessarily invokes _ensure_real upon a call to lock_write.
 
1319
        branch._ensure_real = lambda: None
1675
1320
        # Lock the branch, reset the record of remote calls.
1676
1321
        branch.lock_write()
1677
 
        result = branch._set_last_revision('rev-id2')
 
1322
        result = branch.set_revision_history(['rev-id1', 'rev-id2'])
1678
1323
        branch.unlock()
1679
1324
        self.assertEqual(None, result)
1680
1325
        self.assertFinished(client)
1710
1355
        branch = self.make_remote_branch(transport, client)
1711
1356
        branch.lock_write()
1712
1357
        self.assertRaises(
1713
 
            errors.NoSuchRevision, branch._set_last_revision, 'rev-id')
 
1358
            errors.NoSuchRevision, branch.set_revision_history, ['rev-id'])
1714
1359
        branch.unlock()
1715
1360
        self.assertFinished(client)
1716
1361
 
1744
1389
            'Branch.unlock', ('branch/', 'branch token', 'repo token'),
1745
1390
            'success', ('ok',))
1746
1391
        branch = self.make_remote_branch(transport, client)
 
1392
        branch._ensure_real = lambda: None
1747
1393
        branch.lock_write()
1748
1394
        # The 'TipChangeRejected' error response triggered by calling
1749
 
        # set_last_revision_info causes a TipChangeRejected exception.
 
1395
        # set_revision_history causes a TipChangeRejected exception.
1750
1396
        err = self.assertRaises(
1751
 
            errors.TipChangeRejected,
1752
 
            branch._set_last_revision, 'rev-id')
 
1397
            errors.TipChangeRejected, branch.set_revision_history, ['rev-id'])
1753
1398
        # The UTF-8 message from the response has been decoded into a unicode
1754
1399
        # object.
1755
1400
        self.assertIsInstance(err.msg, unicode)
1943
1588
    def test_get_multi_line_branch_conf(self):
1944
1589
        # Make sure that multiple-line branch.conf files are supported
1945
1590
        #
1946
 
        # https://bugs.launchpad.net/bzr/+bug/354075
 
1591
        # https://bugs.edge.launchpad.net/bzr/+bug/354075
1947
1592
        client = FakeClient()
1948
1593
        client.add_expected_call(
1949
1594
            'Branch.get_stacked_on_url', ('memory:///',),
1977
1622
        branch.unlock()
1978
1623
        self.assertFinished(client)
1979
1624
 
1980
 
    def test_set_option_with_dict(self):
1981
 
        client = FakeClient()
1982
 
        client.add_expected_call(
1983
 
            'Branch.get_stacked_on_url', ('memory:///',),
1984
 
            'error', ('NotStacked',),)
1985
 
        client.add_expected_call(
1986
 
            'Branch.lock_write', ('memory:///', '', ''),
1987
 
            'success', ('ok', 'branch token', 'repo token'))
1988
 
        encoded_dict_value = 'd5:ascii1:a11:unicode \xe2\x8c\x9a3:\xe2\x80\xbde'
1989
 
        client.add_expected_call(
1990
 
            'Branch.set_config_option_dict', ('memory:///', 'branch token',
1991
 
            'repo token', encoded_dict_value, 'foo', ''),
1992
 
            'success', ())
1993
 
        client.add_expected_call(
1994
 
            'Branch.unlock', ('memory:///', 'branch token', 'repo token'),
1995
 
            'success', ('ok',))
1996
 
        transport = MemoryTransport()
1997
 
        branch = self.make_remote_branch(transport, client)
1998
 
        branch.lock_write()
1999
 
        config = branch._get_config()
2000
 
        config.set_option(
2001
 
            {'ascii': 'a', u'unicode \N{WATCH}': u'\N{INTERROBANG}'},
2002
 
            'foo')
2003
 
        branch.unlock()
2004
 
        self.assertFinished(client)
2005
 
 
2006
1625
    def test_backwards_compat_set_option(self):
2007
1626
        self.setup_smart_server_with_call_log()
2008
1627
        branch = self.make_branch('.')
2012
1631
        self.addCleanup(branch.unlock)
2013
1632
        self.reset_smart_call_log()
2014
1633
        branch._get_config().set_option('value', 'name')
2015
 
        self.assertLength(11, self.hpss_calls)
 
1634
        self.assertLength(10, self.hpss_calls)
2016
1635
        self.assertEqual('value', branch._get_config().get_option('name'))
2017
1636
 
2018
 
    def test_backwards_compat_set_option_with_dict(self):
2019
 
        self.setup_smart_server_with_call_log()
2020
 
        branch = self.make_branch('.')
2021
 
        verb = 'Branch.set_config_option_dict'
2022
 
        self.disable_verb(verb)
2023
 
        branch.lock_write()
2024
 
        self.addCleanup(branch.unlock)
2025
 
        self.reset_smart_call_log()
2026
 
        config = branch._get_config()
2027
 
        value_dict = {'ascii': 'a', u'unicode \N{WATCH}': u'\N{INTERROBANG}'}
2028
 
        config.set_option(value_dict, 'name')
2029
 
        self.assertLength(11, self.hpss_calls)
2030
 
        self.assertEqual(value_dict, branch._get_config().get_option('name'))
2031
 
 
2032
 
 
2033
 
class TestBranchGetPutConfigStore(RemoteBranchTestCase):
2034
 
 
2035
 
    def test_get_branch_conf(self):
2036
 
        # in an empty branch we decode the response properly
2037
 
        client = FakeClient()
2038
 
        client.add_expected_call(
2039
 
            'Branch.get_stacked_on_url', ('memory:///',),
2040
 
            'error', ('NotStacked',),)
2041
 
        client.add_success_response_with_body('# config file body', 'ok')
2042
 
        transport = MemoryTransport()
2043
 
        branch = self.make_remote_branch(transport, client)
2044
 
        config = branch.get_config_stack()
2045
 
        config.get("email")
2046
 
        config.get("log_format")
2047
 
        self.assertEqual(
2048
 
            [('call', 'Branch.get_stacked_on_url', ('memory:///',)),
2049
 
             ('call_expecting_body', 'Branch.get_config_file', ('memory:///',))],
2050
 
            client._calls)
2051
 
 
2052
 
    def test_set_branch_conf(self):
2053
 
        client = FakeClient()
2054
 
        client.add_expected_call(
2055
 
            'Branch.get_stacked_on_url', ('memory:///',),
2056
 
            'error', ('NotStacked',),)
2057
 
        client.add_expected_call(
2058
 
            'Branch.lock_write', ('memory:///', '', ''),
2059
 
            'success', ('ok', 'branch token', 'repo token'))
2060
 
        client.add_expected_call(
2061
 
            'Branch.get_config_file', ('memory:///', ),
2062
 
            'success', ('ok', ), "# line 1\n")
2063
 
        client.add_expected_call(
2064
 
            'Branch.get_config_file', ('memory:///', ),
2065
 
            'success', ('ok', ), "# line 1\n")
2066
 
        client.add_expected_call(
2067
 
            'Branch.put_config_file', ('memory:///', 'branch token',
2068
 
            'repo token'),
2069
 
            'success', ('ok',))
2070
 
        client.add_expected_call(
2071
 
            'Branch.unlock', ('memory:///', 'branch token', 'repo token'),
2072
 
            'success', ('ok',))
2073
 
        transport = MemoryTransport()
2074
 
        branch = self.make_remote_branch(transport, client)
2075
 
        branch.lock_write()
2076
 
        config = branch.get_config_stack()
2077
 
        config.set('email', 'The Dude <lebowski@example.com>')
2078
 
        branch.unlock()
2079
 
        self.assertFinished(client)
2080
 
        self.assertEqual(
2081
 
            [('call', 'Branch.get_stacked_on_url', ('memory:///',)),
2082
 
             ('call', 'Branch.lock_write', ('memory:///', '', '')),
2083
 
             ('call_expecting_body', 'Branch.get_config_file', ('memory:///',)),
2084
 
             ('call_expecting_body', 'Branch.get_config_file', ('memory:///',)),
2085
 
             ('call_with_body_bytes_expecting_body', 'Branch.put_config_file',
2086
 
                 ('memory:///', 'branch token', 'repo token'),
2087
 
                 '# line 1\nemail = The Dude <lebowski@example.com>\n'),
2088
 
             ('call', 'Branch.unlock', ('memory:///', 'branch token', 'repo token'))],
2089
 
            client._calls)
2090
 
 
2091
1637
 
2092
1638
class TestBranchLockWrite(RemoteBranchTestCase):
2093
1639
 
2107
1653
        self.assertFinished(client)
2108
1654
 
2109
1655
 
2110
 
class TestBranchRevisionIdToRevno(RemoteBranchTestCase):
2111
 
 
2112
 
    def test_simple(self):
2113
 
        transport = MemoryTransport()
2114
 
        client = FakeClient(transport.base)
2115
 
        client.add_expected_call(
2116
 
            'Branch.get_stacked_on_url', ('quack/',),
2117
 
            'error', ('NotStacked',),)
2118
 
        client.add_expected_call(
2119
 
            'Branch.revision_id_to_revno', ('quack/', 'null:'),
2120
 
            'success', ('ok', '0',),)
2121
 
        client.add_expected_call(
2122
 
            'Branch.revision_id_to_revno', ('quack/', 'unknown'),
2123
 
            'error', ('NoSuchRevision', 'unknown',),)
2124
 
        transport.mkdir('quack')
2125
 
        transport = transport.clone('quack')
2126
 
        branch = self.make_remote_branch(transport, client)
2127
 
        self.assertEqual(0, branch.revision_id_to_revno('null:'))
2128
 
        self.assertRaises(errors.NoSuchRevision,
2129
 
            branch.revision_id_to_revno, 'unknown')
2130
 
        self.assertFinished(client)
2131
 
 
2132
 
    def test_dotted(self):
2133
 
        transport = MemoryTransport()
2134
 
        client = FakeClient(transport.base)
2135
 
        client.add_expected_call(
2136
 
            'Branch.get_stacked_on_url', ('quack/',),
2137
 
            'error', ('NotStacked',),)
2138
 
        client.add_expected_call(
2139
 
            'Branch.revision_id_to_revno', ('quack/', 'null:'),
2140
 
            'success', ('ok', '0',),)
2141
 
        client.add_expected_call(
2142
 
            'Branch.revision_id_to_revno', ('quack/', 'unknown'),
2143
 
            'error', ('NoSuchRevision', 'unknown',),)
2144
 
        transport.mkdir('quack')
2145
 
        transport = transport.clone('quack')
2146
 
        branch = self.make_remote_branch(transport, client)
2147
 
        self.assertEqual((0, ), branch.revision_id_to_dotted_revno('null:'))
2148
 
        self.assertRaises(errors.NoSuchRevision,
2149
 
            branch.revision_id_to_dotted_revno, 'unknown')
2150
 
        self.assertFinished(client)
2151
 
 
2152
 
    def test_dotted_no_smart_verb(self):
2153
 
        self.setup_smart_server_with_call_log()
2154
 
        branch = self.make_branch('.')
2155
 
        self.disable_verb('Branch.revision_id_to_revno')
2156
 
        self.reset_smart_call_log()
2157
 
        self.assertEqual((0, ),
2158
 
            branch.revision_id_to_dotted_revno('null:'))
2159
 
        self.assertLength(8, self.hpss_calls)
2160
 
 
2161
 
 
2162
1656
class TestBzrDirGetSetConfig(RemoteBzrDirTestCase):
2163
1657
 
2164
1658
    def test__get_config(self):
2178
1672
        self.reset_smart_call_log()
2179
1673
        config = bzrdir.get_config()
2180
1674
        config.set_default_stack_on('/')
2181
 
        self.assertLength(4, self.hpss_calls)
 
1675
        self.assertLength(3, self.hpss_calls)
2182
1676
 
2183
1677
    def test_backwards_compat_get_option(self):
2184
1678
        self.setup_smart_server_with_call_log()
2188
1682
        self.reset_smart_call_log()
2189
1683
        self.assertEqual(None,
2190
1684
            bzrdir._get_config().get_option('default_stack_on'))
2191
 
        self.assertLength(4, self.hpss_calls)
 
1685
        self.assertLength(3, self.hpss_calls)
2192
1686
 
2193
1687
 
2194
1688
class TestTransportIsReadonly(tests.TestCase):
2281
1775
        client = FakeClient(transport.base)
2282
1776
        transport = transport.clone(transport_path)
2283
1777
        # we do not want bzrdir to make any remote calls
2284
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
1778
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
2285
1779
            _client=False)
2286
1780
        repo = RemoteRepository(bzrdir, None, _client=client)
2287
1781
        return repo, client
2295
1789
 
2296
1790
    def test_get_format_description(self):
2297
1791
        remote_format = RemoteBranchFormat()
2298
 
        real_format = branch.format_registry.get_default()
 
1792
        real_format = branch.BranchFormat.get_default_format()
2299
1793
        remote_format._network_name = real_format.network_name()
2300
1794
        self.assertEqual(remoted_description(real_format),
2301
1795
            remote_format.get_format_description())
2304
1798
class TestRepositoryFormat(TestRemoteRepository):
2305
1799
 
2306
1800
    def test_fast_delta(self):
2307
 
        true_name = groupcompress_repo.RepositoryFormat2a().network_name()
 
1801
        true_name = groupcompress_repo.RepositoryFormatCHK1().network_name()
2308
1802
        true_format = RemoteRepositoryFormat()
2309
1803
        true_format._network_name = true_name
2310
1804
        self.assertEqual(True, true_format.fast_deltas)
2311
 
        false_name = knitpack_repo.RepositoryFormatKnitPack1().network_name()
 
1805
        false_name = pack_repo.RepositoryFormatKnitPack1().network_name()
2312
1806
        false_format = RemoteRepositoryFormat()
2313
1807
        false_format._network_name = false_name
2314
1808
        self.assertEqual(False, false_format.fast_deltas)
2315
1809
 
2316
1810
    def test_get_format_description(self):
2317
1811
        remote_repo_format = RemoteRepositoryFormat()
2318
 
        real_format = repository.format_registry.get_default()
 
1812
        real_format = repository.RepositoryFormat.get_default_format()
2319
1813
        remote_repo_format._network_name = real_format.network_name()
2320
1814
        self.assertEqual(remoted_description(real_format),
2321
1815
            remote_repo_format.get_format_description())
2322
1816
 
2323
1817
 
2324
 
class TestRepositoryAllRevisionIds(TestRemoteRepository):
2325
 
 
2326
 
    def test_empty(self):
2327
 
        transport_path = 'quack'
2328
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2329
 
        client.add_success_response_with_body('', 'ok')
2330
 
        self.assertEqual([], repo.all_revision_ids())
2331
 
        self.assertEqual(
2332
 
            [('call_expecting_body', 'Repository.all_revision_ids',
2333
 
             ('quack/',))],
2334
 
            client._calls)
2335
 
 
2336
 
    def test_with_some_content(self):
2337
 
        transport_path = 'quack'
2338
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2339
 
        client.add_success_response_with_body(
2340
 
            'rev1\nrev2\nanotherrev\n', 'ok')
2341
 
        self.assertEqual(["rev1", "rev2", "anotherrev"],
2342
 
            repo.all_revision_ids())
2343
 
        self.assertEqual(
2344
 
            [('call_expecting_body', 'Repository.all_revision_ids',
2345
 
             ('quack/',))],
2346
 
            client._calls)
2347
 
 
2348
 
 
2349
1818
class TestRepositoryGatherStats(TestRemoteRepository):
2350
1819
 
2351
1820
    def test_revid_none(self):
2404
1873
                         result)
2405
1874
 
2406
1875
 
2407
 
class TestRepositoryBreakLock(TestRemoteRepository):
2408
 
 
2409
 
    def test_break_lock(self):
2410
 
        transport_path = 'quack'
2411
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2412
 
        client.add_success_response('ok')
2413
 
        repo.break_lock()
2414
 
        self.assertEqual(
2415
 
            [('call', 'Repository.break_lock', ('quack/',))],
2416
 
            client._calls)
2417
 
 
2418
 
 
2419
 
class TestRepositoryGetSerializerFormat(TestRemoteRepository):
2420
 
 
2421
 
    def test_get_serializer_format(self):
2422
 
        transport_path = 'hill'
2423
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2424
 
        client.add_success_response('ok', '7')
2425
 
        self.assertEqual('7', repo.get_serializer_format())
2426
 
        self.assertEqual(
2427
 
            [('call', 'VersionedFileRepository.get_serializer_format',
2428
 
              ('hill/', ))],
2429
 
            client._calls)
2430
 
 
2431
 
 
2432
 
class TestRepositoryReconcile(TestRemoteRepository):
2433
 
 
2434
 
    def test_reconcile(self):
2435
 
        transport_path = 'hill'
2436
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2437
 
        body = ("garbage_inventories: 2\n"
2438
 
                "inconsistent_parents: 3\n")
2439
 
        client.add_expected_call(
2440
 
            'Repository.lock_write', ('hill/', ''),
2441
 
            'success', ('ok', 'a token'))
2442
 
        client.add_success_response_with_body(body, 'ok')
2443
 
        reconciler = repo.reconcile()
2444
 
        self.assertEqual(
2445
 
            [('call', 'Repository.lock_write', ('hill/', '')),
2446
 
             ('call_expecting_body', 'Repository.reconcile',
2447
 
                ('hill/', 'a token'))],
2448
 
            client._calls)
2449
 
        self.assertEqual(2, reconciler.garbage_inventories)
2450
 
        self.assertEqual(3, reconciler.inconsistent_parents)
2451
 
 
2452
 
 
2453
 
class TestRepositoryGetRevisionSignatureText(TestRemoteRepository):
2454
 
 
2455
 
    def test_text(self):
2456
 
        # ('ok',), body with signature text
2457
 
        transport_path = 'quack'
2458
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2459
 
        client.add_success_response_with_body(
2460
 
            'THETEXT', 'ok')
2461
 
        self.assertEqual("THETEXT", repo.get_signature_text("revid"))
2462
 
        self.assertEqual(
2463
 
            [('call_expecting_body', 'Repository.get_revision_signature_text',
2464
 
             ('quack/', 'revid'))],
2465
 
            client._calls)
2466
 
 
2467
 
    def test_no_signature(self):
2468
 
        transport_path = 'quick'
2469
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2470
 
        client.add_error_response('nosuchrevision', 'unknown')
2471
 
        self.assertRaises(errors.NoSuchRevision, repo.get_signature_text,
2472
 
                "unknown")
2473
 
        self.assertEqual(
2474
 
            [('call_expecting_body', 'Repository.get_revision_signature_text',
2475
 
              ('quick/', 'unknown'))],
2476
 
            client._calls)
2477
 
 
2478
 
 
2479
1876
class TestRepositoryGetGraph(TestRemoteRepository):
2480
1877
 
2481
1878
    def test_get_graph(self):
2486
1883
        self.assertNotEqual(graph._parents_provider, repo)
2487
1884
 
2488
1885
 
2489
 
class TestRepositoryAddSignatureText(TestRemoteRepository):
2490
 
 
2491
 
    def test_add_signature_text(self):
2492
 
        transport_path = 'quack'
2493
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2494
 
        client.add_expected_call(
2495
 
            'Repository.lock_write', ('quack/', ''),
2496
 
            'success', ('ok', 'a token'))
2497
 
        client.add_expected_call(
2498
 
            'Repository.start_write_group', ('quack/', 'a token'),
2499
 
            'success', ('ok', ('token1', )))
2500
 
        client.add_expected_call(
2501
 
            'Repository.add_signature_text', ('quack/', 'a token', 'rev1',
2502
 
                'token1'),
2503
 
            'success', ('ok', ), None)
2504
 
        repo.lock_write()
2505
 
        repo.start_write_group()
2506
 
        self.assertIs(None,
2507
 
            repo.add_signature_text("rev1", "every bloody emperor"))
2508
 
        self.assertEqual(
2509
 
            ('call_with_body_bytes_expecting_body',
2510
 
              'Repository.add_signature_text',
2511
 
                ('quack/', 'a token', 'rev1', 'token1'),
2512
 
              'every bloody emperor'),
2513
 
            client._calls[-1])
2514
 
 
2515
 
 
2516
1886
class TestRepositoryGetParentMap(TestRemoteRepository):
2517
1887
 
2518
1888
    def test_get_parent_map_caching(self):
2568
1938
        parents = repo.get_parent_map([rev_id])
2569
1939
        self.assertEqual(
2570
1940
            [('call_with_body_bytes_expecting_body',
2571
 
              'Repository.get_parent_map',
2572
 
              ('quack/', 'include-missing:', rev_id), '\n\n0'),
 
1941
              'Repository.get_parent_map', ('quack/', 'include-missing:',
 
1942
              rev_id), '\n\n0'),
2573
1943
             ('disconnect medium',),
2574
1944
             ('call_expecting_body', 'Repository.get_revision_graph',
2575
1945
              ('quack/', ''))],
2634
2004
        self.assertLength(1, self.hpss_calls)
2635
2005
 
2636
2006
    def disableExtraResults(self):
2637
 
        self.overrideAttr(SmartServerRepositoryGetParentMap,
2638
 
                          'no_extra_results', True)
 
2007
        old_flag = SmartServerRepositoryGetParentMap.no_extra_results
 
2008
        SmartServerRepositoryGetParentMap.no_extra_results = True
 
2009
        def reset_values():
 
2010
            SmartServerRepositoryGetParentMap.no_extra_results = old_flag
 
2011
        self.addCleanup(reset_values)
2639
2012
 
2640
2013
    def test_null_cached_missing_and_stop_key(self):
2641
2014
        self.setup_smart_server_with_call_log()
2695
2068
        self.assertEqual({}, repo.get_parent_map(['non-existant']))
2696
2069
        self.assertLength(0, self.hpss_calls)
2697
2070
 
2698
 
    def test_exposes_get_cached_parent_map(self):
2699
 
        """RemoteRepository exposes get_cached_parent_map from
2700
 
        _unstacked_provider
2701
 
        """
2702
 
        r1 = u'\u0e33'.encode('utf8')
2703
 
        r2 = u'\u0dab'.encode('utf8')
2704
 
        lines = [' '.join([r2, r1]), r1]
2705
 
        encoded_body = bz2.compress('\n'.join(lines))
2706
 
 
2707
 
        transport_path = 'quack'
2708
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2709
 
        client.add_success_response_with_body(encoded_body, 'ok')
2710
 
        repo.lock_read()
2711
 
        # get_cached_parent_map should *not* trigger an RPC
2712
 
        self.assertEqual({}, repo.get_cached_parent_map([r1]))
2713
 
        self.assertEqual([], client._calls)
2714
 
        self.assertEqual({r2: (r1,)}, repo.get_parent_map([r2]))
2715
 
        self.assertEqual({r1: (NULL_REVISION,)},
2716
 
            repo.get_cached_parent_map([r1]))
2717
 
        self.assertEqual(
2718
 
            [('call_with_body_bytes_expecting_body',
2719
 
              'Repository.get_parent_map', ('quack/', 'include-missing:', r2),
2720
 
              '\n\n0')],
2721
 
            client._calls)
2722
 
        repo.unlock()
2723
 
 
2724
2071
 
2725
2072
class TestGetParentMapAllowsNew(tests.TestCaseWithTransport):
2726
2073
 
2727
2074
    def test_allows_new_revisions(self):
2728
2075
        """get_parent_map's results can be updated by commit."""
2729
 
        smart_server = test_server.SmartTCPServer_for_testing()
 
2076
        smart_server = server.SmartTCPServer_for_testing()
2730
2077
        self.start_server(smart_server)
2731
2078
        self.make_branch('branch')
2732
2079
        branch = Branch.open(smart_server.get_url() + '/branch')
2741
2088
        self.assertEqual({'rev1': ('null:',)}, graph.get_parent_map(['rev1']))
2742
2089
 
2743
2090
 
2744
 
class TestRepositoryGetRevisions(TestRemoteRepository):
2745
 
 
2746
 
    def test_hpss_missing_revision(self):
2747
 
        transport_path = 'quack'
2748
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2749
 
        client.add_success_response_with_body(
2750
 
            '', 'ok', '10')
2751
 
        self.assertRaises(errors.NoSuchRevision, repo.get_revisions,
2752
 
            ['somerev1', 'anotherrev2'])
2753
 
        self.assertEqual(
2754
 
            [('call_with_body_bytes_expecting_body', 'Repository.iter_revisions',
2755
 
             ('quack/', ), "somerev1\nanotherrev2")],
2756
 
            client._calls)
2757
 
 
2758
 
    def test_hpss_get_single_revision(self):
2759
 
        transport_path = 'quack'
2760
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2761
 
        somerev1 = Revision("somerev1")
2762
 
        somerev1.committer = "Joe Committer <joe@example.com>"
2763
 
        somerev1.timestamp = 1321828927
2764
 
        somerev1.timezone = -60
2765
 
        somerev1.inventory_sha1 = "691b39be74c67b1212a75fcb19c433aaed903c2b"
2766
 
        somerev1.message = "Message"
2767
 
        body = zlib.compress(chk_bencode_serializer.write_revision_to_string(
2768
 
            somerev1))
2769
 
        # Split up body into two bits to make sure the zlib compression object
2770
 
        # gets data fed twice.
2771
 
        client.add_success_response_with_body(
2772
 
                [body[:10], body[10:]], 'ok', '10')
2773
 
        revs = repo.get_revisions(['somerev1'])
2774
 
        self.assertEqual(revs, [somerev1])
2775
 
        self.assertEqual(
2776
 
            [('call_with_body_bytes_expecting_body', 'Repository.iter_revisions',
2777
 
             ('quack/', ), "somerev1")],
2778
 
            client._calls)
2779
 
 
2780
 
 
2781
2091
class TestRepositoryGetRevisionGraph(TestRemoteRepository):
2782
2092
 
2783
2093
    def test_null_revision(self):
2879
2189
        """
2880
2190
        # Make a repo with a fallback repo, both using a FakeClient.
2881
2191
        format = remote.response_tuple_to_repo_format(
2882
 
            ('yes', 'no', 'yes', self.get_repo_format().network_name()))
 
2192
            ('yes', 'no', 'yes', 'fake-network-name'))
2883
2193
        repo, client = self.setup_fake_client_and_repository('quack')
2884
2194
        repo._format = format
2885
2195
        fallback_repo, ignored = self.setup_fake_client_and_repository(
2886
2196
            'fallback')
2887
2197
        fallback_repo._client = client
2888
 
        fallback_repo._format = format
2889
2198
        repo.add_fallback_repository(fallback_repo)
2890
2199
        # First the client should ask the primary repo
2891
2200
        client.add_expected_call(
2920
2229
        self.setup_smart_server_with_call_log()
2921
2230
        tree = self.make_branch_and_memory_tree('.')
2922
2231
        tree.lock_write()
2923
 
        tree.add('')
2924
2232
        rev1 = tree.commit('First')
2925
2233
        rev2 = tree.commit('Second')
2926
2234
        tree.unlock()
2934
2242
                              call.call.method == verb])
2935
2243
 
2936
2244
 
2937
 
class TestRepositoryHasSignatureForRevisionId(TestRemoteRepository):
2938
 
 
2939
 
    def test_has_signature_for_revision_id(self):
2940
 
        # ('yes', ) for Repository.has_signature_for_revision_id -> 'True'.
2941
 
        transport_path = 'quack'
2942
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2943
 
        client.add_success_response('yes')
2944
 
        result = repo.has_signature_for_revision_id('A')
2945
 
        self.assertEqual(
2946
 
            [('call', 'Repository.has_signature_for_revision_id',
2947
 
              ('quack/', 'A'))],
2948
 
            client._calls)
2949
 
        self.assertEqual(True, result)
2950
 
 
2951
 
    def test_is_not_shared(self):
2952
 
        # ('no', ) for Repository.has_signature_for_revision_id -> 'False'.
2953
 
        transport_path = 'qwack'
2954
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2955
 
        client.add_success_response('no')
2956
 
        result = repo.has_signature_for_revision_id('A')
2957
 
        self.assertEqual(
2958
 
            [('call', 'Repository.has_signature_for_revision_id',
2959
 
              ('qwack/', 'A'))],
2960
 
            client._calls)
2961
 
        self.assertEqual(False, result)
2962
 
 
2963
 
 
2964
 
class TestRepositoryPhysicalLockStatus(TestRemoteRepository):
2965
 
 
2966
 
    def test_get_physical_lock_status_yes(self):
2967
 
        transport_path = 'qwack'
2968
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2969
 
        client.add_success_response('yes')
2970
 
        result = repo.get_physical_lock_status()
2971
 
        self.assertEqual(
2972
 
            [('call', 'Repository.get_physical_lock_status',
2973
 
              ('qwack/', ))],
2974
 
            client._calls)
2975
 
        self.assertEqual(True, result)
2976
 
 
2977
 
    def test_get_physical_lock_status_no(self):
2978
 
        transport_path = 'qwack'
2979
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2980
 
        client.add_success_response('no')
2981
 
        result = repo.get_physical_lock_status()
2982
 
        self.assertEqual(
2983
 
            [('call', 'Repository.get_physical_lock_status',
2984
 
              ('qwack/', ))],
2985
 
            client._calls)
2986
 
        self.assertEqual(False, result)
2987
 
 
2988
 
 
2989
2245
class TestRepositoryIsShared(TestRemoteRepository):
2990
2246
 
2991
2247
    def test_is_shared(self):
3011
2267
        self.assertEqual(False, result)
3012
2268
 
3013
2269
 
3014
 
class TestRepositoryMakeWorkingTrees(TestRemoteRepository):
3015
 
 
3016
 
    def test_make_working_trees(self):
3017
 
        # ('yes', ) for Repository.make_working_trees -> 'True'.
3018
 
        transport_path = 'quack'
3019
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
3020
 
        client.add_success_response('yes')
3021
 
        result = repo.make_working_trees()
3022
 
        self.assertEqual(
3023
 
            [('call', 'Repository.make_working_trees', ('quack/',))],
3024
 
            client._calls)
3025
 
        self.assertEqual(True, result)
3026
 
 
3027
 
    def test_no_working_trees(self):
3028
 
        # ('no', ) for Repository.make_working_trees -> 'False'.
3029
 
        transport_path = 'qwack'
3030
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
3031
 
        client.add_success_response('no')
3032
 
        result = repo.make_working_trees()
3033
 
        self.assertEqual(
3034
 
            [('call', 'Repository.make_working_trees', ('qwack/',))],
3035
 
            client._calls)
3036
 
        self.assertEqual(False, result)
3037
 
 
3038
 
 
3039
2270
class TestRepositoryLockWrite(TestRemoteRepository):
3040
2271
 
3041
2272
    def test_lock_write(self):
3042
2273
        transport_path = 'quack'
3043
2274
        repo, client = self.setup_fake_client_and_repository(transport_path)
3044
2275
        client.add_success_response('ok', 'a token')
3045
 
        token = repo.lock_write().repository_token
 
2276
        result = repo.lock_write()
3046
2277
        self.assertEqual(
3047
2278
            [('call', 'Repository.lock_write', ('quack/', ''))],
3048
2279
            client._calls)
3049
 
        self.assertEqual('a token', token)
 
2280
        self.assertEqual('a token', result)
3050
2281
 
3051
2282
    def test_lock_write_already_locked(self):
3052
2283
        transport_path = 'quack'
3067
2298
            client._calls)
3068
2299
 
3069
2300
 
3070
 
class TestRepositoryWriteGroups(TestRemoteRepository):
3071
 
 
3072
 
    def test_start_write_group(self):
3073
 
        transport_path = 'quack'
3074
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
3075
 
        client.add_expected_call(
3076
 
            'Repository.lock_write', ('quack/', ''),
3077
 
            'success', ('ok', 'a token'))
3078
 
        client.add_expected_call(
3079
 
            'Repository.start_write_group', ('quack/', 'a token'),
3080
 
            'success', ('ok', ('token1', )))
3081
 
        repo.lock_write()
3082
 
        repo.start_write_group()
3083
 
 
3084
 
    def test_start_write_group_unsuspendable(self):
3085
 
        # Some repositories do not support suspending write
3086
 
        # groups. For those, fall back to the "real" repository.
3087
 
        transport_path = 'quack'
3088
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
3089
 
        def stub_ensure_real():
3090
 
            client._calls.append(('_ensure_real',))
3091
 
            repo._real_repository = _StubRealPackRepository(client._calls)
3092
 
        repo._ensure_real = stub_ensure_real
3093
 
        client.add_expected_call(
3094
 
            'Repository.lock_write', ('quack/', ''),
3095
 
            'success', ('ok', 'a token'))
3096
 
        client.add_expected_call(
3097
 
            'Repository.start_write_group', ('quack/', 'a token'),
3098
 
            'error', ('UnsuspendableWriteGroup',))
3099
 
        repo.lock_write()
3100
 
        repo.start_write_group()
3101
 
        self.assertEqual(client._calls[-2:], [ 
3102
 
            ('_ensure_real',),
3103
 
            ('start_write_group',)])
3104
 
 
3105
 
    def test_commit_write_group(self):
3106
 
        transport_path = 'quack'
3107
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
3108
 
        client.add_expected_call(
3109
 
            'Repository.lock_write', ('quack/', ''),
3110
 
            'success', ('ok', 'a token'))
3111
 
        client.add_expected_call(
3112
 
            'Repository.start_write_group', ('quack/', 'a token'),
3113
 
            'success', ('ok', ['token1']))
3114
 
        client.add_expected_call(
3115
 
            'Repository.commit_write_group', ('quack/', 'a token', ['token1']),
3116
 
            'success', ('ok',))
3117
 
        repo.lock_write()
3118
 
        repo.start_write_group()
3119
 
        repo.commit_write_group()
3120
 
 
3121
 
    def test_abort_write_group(self):
3122
 
        transport_path = 'quack'
3123
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
3124
 
        client.add_expected_call(
3125
 
            'Repository.lock_write', ('quack/', ''),
3126
 
            'success', ('ok', 'a token'))
3127
 
        client.add_expected_call(
3128
 
            'Repository.start_write_group', ('quack/', 'a token'),
3129
 
            'success', ('ok', ['token1']))
3130
 
        client.add_expected_call(
3131
 
            'Repository.abort_write_group', ('quack/', 'a token', ['token1']),
3132
 
            'success', ('ok',))
3133
 
        repo.lock_write()
3134
 
        repo.start_write_group()
3135
 
        repo.abort_write_group(False)
3136
 
 
3137
 
    def test_suspend_write_group(self):
3138
 
        transport_path = 'quack'
3139
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
3140
 
        self.assertEqual([], repo.suspend_write_group())
3141
 
 
3142
 
    def test_resume_write_group(self):
3143
 
        transport_path = 'quack'
3144
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
3145
 
        client.add_expected_call(
3146
 
            'Repository.lock_write', ('quack/', ''),
3147
 
            'success', ('ok', 'a token'))
3148
 
        client.add_expected_call(
3149
 
            'Repository.check_write_group', ('quack/', 'a token', ['token1']),
3150
 
            'success', ('ok',))
3151
 
        repo.lock_write()
3152
 
        repo.resume_write_group(['token1'])
3153
 
 
3154
 
 
3155
2301
class TestRepositorySetMakeWorkingTrees(TestRemoteRepository):
3156
2302
 
3157
2303
    def test_backwards_compat(self):
3216
2362
        self.assertEqual([], client._calls)
3217
2363
 
3218
2364
 
3219
 
class TestRepositoryIterFilesBytes(TestRemoteRepository):
3220
 
    """Test Repository.iter_file_bytes."""
3221
 
 
3222
 
    def test_single(self):
3223
 
        transport_path = 'quack'
3224
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
3225
 
        client.add_expected_call(
3226
 
            'Repository.iter_files_bytes', ('quack/', ),
3227
 
            'success', ('ok',), iter(["ok\x000", "\n", zlib.compress("mydata" * 10)]))
3228
 
        for (identifier, byte_stream) in repo.iter_files_bytes([("somefile",
3229
 
                "somerev", "myid")]):
3230
 
            self.assertEqual("myid", identifier)
3231
 
            self.assertEqual("".join(byte_stream), "mydata" * 10)
3232
 
 
3233
 
    def test_missing(self):
3234
 
        transport_path = 'quack'
3235
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
3236
 
        client.add_expected_call(
3237
 
            'Repository.iter_files_bytes',
3238
 
                ('quack/', ),
3239
 
            'error', ('RevisionNotPresent', 'somefile', 'somerev'),
3240
 
            iter(["absent\0somefile\0somerev\n"]))
3241
 
        self.assertRaises(errors.RevisionNotPresent, list,
3242
 
                repo.iter_files_bytes(
3243
 
                [("somefile", "somerev", "myid")]))
3244
 
 
3245
 
 
3246
2365
class TestRepositoryInsertStreamBase(TestRemoteRepository):
3247
2366
    """Base class for Repository.insert_stream and .insert_stream_1.19
3248
2367
    tests.
3255
2374
        the client is finished.
3256
2375
        """
3257
2376
        sink = repo._get_sink()
3258
 
        fmt = repository.format_registry.get_default()
 
2377
        fmt = repository.RepositoryFormat.get_default_format()
3259
2378
        resume_tokens, missing_keys = sink.insert_stream([], fmt, [])
3260
2379
        self.assertEqual([], resume_tokens)
3261
2380
        self.assertEqual(set(), missing_keys)
3270
2389
    """
3271
2390
 
3272
2391
    def setUp(self):
3273
 
        super(TestRepositoryInsertStream, self).setUp()
 
2392
        TestRemoteRepository.setUp(self)
3274
2393
        self.disable_verb('Repository.insert_stream_1.19')
3275
2394
 
3276
2395
    def test_unlocked_repo(self):
3361
2480
                return True
3362
2481
        repo._real_repository = FakeRealRepository()
3363
2482
        sink = repo._get_sink()
3364
 
        fmt = repository.format_registry.get_default()
 
2483
        fmt = repository.RepositoryFormat.get_default_format()
3365
2484
        stream = self.make_stream_with_inv_deltas(fmt)
3366
2485
        resume_tokens, missing_keys = sink.insert_stream(stream, fmt, [])
3367
2486
        # Every record from the first inventory delta should have been sent to
3502
2621
    """RemoteRepository.copy_content_into optimizations"""
3503
2622
 
3504
2623
    def test_copy_content_remote_to_local(self):
3505
 
        self.transport_server = test_server.SmartTCPServer_for_testing
 
2624
        self.transport_server = server.SmartTCPServer_for_testing
3506
2625
        src_repo = self.make_repository('repo1')
3507
2626
        src_repo = repository.Repository.open(self.get_url('repo1'))
3508
2627
        # At the moment the tarball-based copy_content_into can't write back
3523
2642
        self.calls = calls
3524
2643
        self._pack_collection = _StubPackCollection(calls)
3525
2644
 
3526
 
    def start_write_group(self):
3527
 
        self.calls.append(('start_write_group',))
3528
 
 
3529
2645
    def is_in_write_group(self):
3530
2646
        return False
3531
2647
 
3590
2706
             ('pack collection autopack',)],
3591
2707
            client._calls)
3592
2708
 
3593
 
    def test_oom_error_reporting(self):
3594
 
        """An out-of-memory condition on the server is reported clearly"""
3595
 
        transport_path = 'quack'
3596
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
3597
 
        client.add_expected_call(
3598
 
            'PackRepository.autopack', ('quack/',),
3599
 
            'error', ('MemoryError',))
3600
 
        err = self.assertRaises(errors.BzrError, repo.autopack)
3601
 
        self.assertContainsRe(str(err), "^remote server out of mem")
3602
 
 
3603
2709
 
3604
2710
class TestErrorTranslationBase(tests.TestCaseWithMemoryTransport):
3605
2711
    """Base class for unit tests for bzrlib.remote._translate_error."""
3669
2775
        expected_error = errors.NotBranchError(path=bzrdir.root_transport.base)
3670
2776
        self.assertEqual(expected_error, translated_error)
3671
2777
 
3672
 
    def test_nobranch_one_arg(self):
3673
 
        bzrdir = self.make_bzrdir('')
3674
 
        translated_error = self.translateTuple(
3675
 
            ('nobranch', 'extra detail'), bzrdir=bzrdir)
3676
 
        expected_error = errors.NotBranchError(
3677
 
            path=bzrdir.root_transport.base,
3678
 
            detail='extra detail')
3679
 
        self.assertEqual(expected_error, translated_error)
3680
 
 
3681
 
    def test_norepository(self):
3682
 
        bzrdir = self.make_bzrdir('')
3683
 
        translated_error = self.translateTuple(('norepository',),
3684
 
            bzrdir=bzrdir)
3685
 
        expected_error = errors.NoRepositoryPresent(bzrdir)
3686
 
        self.assertEqual(expected_error, translated_error)
3687
 
 
3688
2778
    def test_LockContention(self):
3689
2779
        translated_error = self.translateTuple(('LockContention',))
3690
2780
        expected_error = errors.LockContention('(remote lock)')
3718
2808
        expected_error = errors.DivergedBranches(branch, other_branch)
3719
2809
        self.assertEqual(expected_error, translated_error)
3720
2810
 
3721
 
    def test_NotStacked(self):
3722
 
        branch = self.make_branch('')
3723
 
        translated_error = self.translateTuple(('NotStacked',), branch=branch)
3724
 
        expected_error = errors.NotStacked(branch)
3725
 
        self.assertEqual(expected_error, translated_error)
3726
 
 
3727
2811
    def test_ReadError_no_args(self):
3728
2812
        path = 'a path'
3729
2813
        translated_error = self.translateTuple(('ReadError',), path=path)
3745
2829
 
3746
2830
    def test_PermissionDenied_no_args(self):
3747
2831
        path = 'a path'
3748
 
        translated_error = self.translateTuple(('PermissionDenied',),
3749
 
            path=path)
 
2832
        translated_error = self.translateTuple(('PermissionDenied',), path=path)
3750
2833
        expected_error = errors.PermissionDenied(path)
3751
2834
        self.assertEqual(expected_error, translated_error)
3752
2835
 
3775
2858
        expected_error = errors.PermissionDenied(path, extra)
3776
2859
        self.assertEqual(expected_error, translated_error)
3777
2860
 
3778
 
    # GZ 2011-03-02: TODO test for PermissionDenied with non-ascii 'extra'
3779
 
 
3780
 
    def test_NoSuchFile_context_path(self):
3781
 
        local_path = "local path"
3782
 
        translated_error = self.translateTuple(('ReadError', "remote path"),
3783
 
            path=local_path)
3784
 
        expected_error = errors.ReadError(local_path)
3785
 
        self.assertEqual(expected_error, translated_error)
3786
 
 
3787
 
    def test_NoSuchFile_without_context(self):
3788
 
        remote_path = "remote path"
3789
 
        translated_error = self.translateTuple(('ReadError', remote_path))
3790
 
        expected_error = errors.ReadError(remote_path)
3791
 
        self.assertEqual(expected_error, translated_error)
3792
 
 
3793
 
    def test_ReadOnlyError(self):
3794
 
        translated_error = self.translateTuple(('ReadOnlyError',))
3795
 
        expected_error = errors.TransportNotPossible("readonly transport")
3796
 
        self.assertEqual(expected_error, translated_error)
3797
 
 
3798
 
    def test_MemoryError(self):
3799
 
        translated_error = self.translateTuple(('MemoryError',))
3800
 
        self.assertStartsWith(str(translated_error),
3801
 
            "remote server out of memory")
3802
 
 
3803
 
    def test_generic_IndexError_no_classname(self):
3804
 
        err = errors.ErrorFromSmartServer(('error', "list index out of range"))
3805
 
        translated_error = self.translateErrorFromSmartServer(err)
3806
 
        expected_error = errors.UnknownErrorFromSmartServer(err)
3807
 
        self.assertEqual(expected_error, translated_error)
3808
 
 
3809
 
    # GZ 2011-03-02: TODO test generic non-ascii error string
3810
 
 
3811
 
    def test_generic_KeyError(self):
3812
 
        err = errors.ErrorFromSmartServer(('error', 'KeyError', "1"))
3813
 
        translated_error = self.translateErrorFromSmartServer(err)
3814
 
        expected_error = errors.UnknownErrorFromSmartServer(err)
3815
 
        self.assertEqual(expected_error, translated_error)
3816
 
 
3817
2861
 
3818
2862
class TestErrorTranslationRobustness(TestErrorTranslationBase):
3819
2863
    """Unit tests for bzrlib.remote._translate_error's robustness.
3849
2893
        # In addition to re-raising ErrorFromSmartServer, some debug info has
3850
2894
        # been muttered to the log file for developer to look at.
3851
2895
        self.assertContainsRe(
3852
 
            self.get_log(),
 
2896
            self._get_log(keep_log_file=True),
3853
2897
            "Missing key 'branch' in context")
3854
2898
 
3855
2899
    def test_path_missing(self):
3863
2907
        self.assertEqual(server_error, translated_error)
3864
2908
        # In addition to re-raising ErrorFromSmartServer, some debug info has
3865
2909
        # been muttered to the log file for developer to look at.
3866
 
        self.assertContainsRe(self.get_log(), "Missing key 'path' in context")
 
2910
        self.assertContainsRe(
 
2911
            self._get_log(keep_log_file=True), "Missing key 'path' in context")
3867
2912
 
3868
2913
 
3869
2914
class TestStacking(tests.TestCaseWithTransport):
3887
2932
        stacked_branch = self.make_branch('stacked', format='1.9')
3888
2933
        stacked_branch.set_stacked_on_url('../base')
3889
2934
        # start a server looking at this
3890
 
        smart_server = test_server.SmartTCPServer_for_testing()
 
2935
        smart_server = server.SmartTCPServer_for_testing()
3891
2936
        self.start_server(smart_server)
3892
2937
        remote_bzrdir = BzrDir.open(smart_server.get_url() + '/stacked')
3893
2938
        # can get its branch and repository
3955
3000
        :result: The revision ids in the stream, in the order seen,
3956
3001
            the topological order of revisions in the source.
3957
3002
        """
3958
 
        unordered_format = controldir.format_registry.get(format)()
 
3003
        unordered_format = bzrdir.format_registry.get(format)()
3959
3004
        target_repository_format = unordered_format.repository_format
3960
3005
        # Cross check
3961
3006
        self.assertEqual(order, target_repository_format._fetch_order)
3964
3009
        _, stacked = branch_factory()
3965
3010
        source = stacked.repository._get_source(target_repository_format)
3966
3011
        tip = stacked.last_revision()
3967
 
        stacked.repository._ensure_real()
3968
 
        graph = stacked.repository.get_graph()
3969
 
        revs = [r for (r,ps) in graph.iter_ancestry([tip])
3970
 
                if r != NULL_REVISION]
3971
 
        revs.reverse()
3972
 
        search = vf_search.PendingAncestryResult([tip], stacked.repository)
 
3012
        revs = stacked.repository.get_ancestry(tip)
 
3013
        search = graph.PendingAncestryResult([tip], stacked.repository)
3973
3014
        self.reset_smart_call_log()
3974
3015
        stream = source.get_stream(search)
 
3016
        if None in revs:
 
3017
            revs.remove(None)
3975
3018
        # We trust that if a revision is in the stream the rest of the new
3976
3019
        # content for it is too, as per our main fetch tests; here we are
3977
3020
        # checking that the revisions are actually included at all, and their
3999
3042
            local_tree.commit('more local changes are better')
4000
3043
            branch = Branch.open(self.get_url('tree3'))
4001
3044
            branch.lock_read()
4002
 
            self.addCleanup(branch.unlock)
4003
3045
            return None, branch
4004
3046
        rev_ord, expected_revs = self.get_ordered_revs('1.9', 'unordered',
4005
3047
            branch_factory=make_stacked_stacked)
4016
3058
        self.assertEqual(expected_revs, rev_ord)
4017
3059
        # Getting topological sort requires VFS calls still - one of which is
4018
3060
        # pushing up from the bound branch.
4019
 
        self.assertLength(14, self.hpss_calls)
 
3061
        self.assertLength(13, self.hpss_calls)
4020
3062
 
4021
3063
    def test_stacked_get_stream_groupcompress(self):
4022
3064
        # Repository._get_source.get_stream() from a stacked repository with
4051
3093
        super(TestRemoteBranchEffort, self).setUp()
4052
3094
        # Create a smart server that publishes whatever the backing VFS server
4053
3095
        # does.
4054
 
        self.smart_server = test_server.SmartTCPServer_for_testing()
 
3096
        self.smart_server = server.SmartTCPServer_for_testing()
4055
3097
        self.start_server(self.smart_server, self.get_server())
4056
3098
        # Log all HPSS calls into self.hpss_calls.
4057
3099
        _SmartClient.hooks.install_named_hook(
4063
3105
 
4064
3106
    def test_copy_content_into_avoids_revision_history(self):
4065
3107
        local = self.make_branch('local')
4066
 
        builder = self.make_branch_builder('remote')
4067
 
        builder.build_commit(message="Commit.")
 
3108
        remote_backing_tree = self.make_branch_and_tree('remote')
 
3109
        remote_backing_tree.commit("Commit.")
4068
3110
        remote_branch_url = self.smart_server.get_url() + 'remote'
4069
3111
        remote_branch = bzrdir.BzrDir.open(remote_branch_url).open_branch()
4070
3112
        local.repository.fetch(remote_branch.repository)
4071
3113
        self.hpss_calls = []
4072
3114
        remote_branch.copy_content_into(local)
4073
3115
        self.assertFalse('Branch.revision_history' in self.hpss_calls)
4074
 
 
4075
 
    def test_fetch_everything_needs_just_one_call(self):
4076
 
        local = self.make_branch('local')
4077
 
        builder = self.make_branch_builder('remote')
4078
 
        builder.build_commit(message="Commit.")
4079
 
        remote_branch_url = self.smart_server.get_url() + 'remote'
4080
 
        remote_branch = bzrdir.BzrDir.open(remote_branch_url).open_branch()
4081
 
        self.hpss_calls = []
4082
 
        local.repository.fetch(
4083
 
            remote_branch.repository,
4084
 
            fetch_spec=vf_search.EverythingResult(remote_branch.repository))
4085
 
        self.assertEqual(['Repository.get_stream_1.19'], self.hpss_calls)
4086
 
 
4087
 
    def override_verb(self, verb_name, verb):
4088
 
        request_handlers = request.request_handlers
4089
 
        orig_verb = request_handlers.get(verb_name)
4090
 
        orig_info = request_handlers.get_info(verb_name)
4091
 
        request_handlers.register(verb_name, verb, override_existing=True)
4092
 
        self.addCleanup(request_handlers.register, verb_name, orig_verb,
4093
 
                override_existing=True, info=orig_info)
4094
 
 
4095
 
    def test_fetch_everything_backwards_compat(self):
4096
 
        """Can fetch with EverythingResult even with pre 2.4 servers.
4097
 
        
4098
 
        Pre-2.4 do not support 'everything' searches with the
4099
 
        Repository.get_stream_1.19 verb.
4100
 
        """
4101
 
        verb_log = []
4102
 
        class OldGetStreamVerb(SmartServerRepositoryGetStream_1_19):
4103
 
            """A version of the Repository.get_stream_1.19 verb patched to
4104
 
            reject 'everything' searches the way 2.3 and earlier do.
4105
 
            """
4106
 
            def recreate_search(self, repository, search_bytes,
4107
 
                                discard_excess=False):
4108
 
                verb_log.append(search_bytes.split('\n', 1)[0])
4109
 
                if search_bytes == 'everything':
4110
 
                    return (None,
4111
 
                            request.FailedSmartServerResponse(('BadSearch',)))
4112
 
                return super(OldGetStreamVerb,
4113
 
                        self).recreate_search(repository, search_bytes,
4114
 
                            discard_excess=discard_excess)
4115
 
        self.override_verb('Repository.get_stream_1.19', OldGetStreamVerb)
4116
 
        local = self.make_branch('local')
4117
 
        builder = self.make_branch_builder('remote')
4118
 
        builder.build_commit(message="Commit.")
4119
 
        remote_branch_url = self.smart_server.get_url() + 'remote'
4120
 
        remote_branch = bzrdir.BzrDir.open(remote_branch_url).open_branch()
4121
 
        self.hpss_calls = []
4122
 
        local.repository.fetch(
4123
 
            remote_branch.repository,
4124
 
            fetch_spec=vf_search.EverythingResult(remote_branch.repository))
4125
 
        # make sure the overridden verb was used
4126
 
        self.assertLength(1, verb_log)
4127
 
        # more than one HPSS call is needed, but because it's a VFS callback
4128
 
        # its hard to predict exactly how many.
4129
 
        self.assertTrue(len(self.hpss_calls) > 1)
4130
 
 
4131
 
 
4132
 
class TestUpdateBoundBranchWithModifiedBoundLocation(
4133
 
    tests.TestCaseWithTransport):
4134
 
    """Ensure correct handling of bound_location modifications.
4135
 
 
4136
 
    This is tested against a smart server as http://pad.lv/786980 was about a
4137
 
    ReadOnlyError (write attempt during a read-only transaction) which can only
4138
 
    happen in this context.
4139
 
    """
4140
 
 
4141
 
    def setUp(self):
4142
 
        super(TestUpdateBoundBranchWithModifiedBoundLocation, self).setUp()
4143
 
        self.transport_server = test_server.SmartTCPServer_for_testing
4144
 
 
4145
 
    def make_master_and_checkout(self, master_name, checkout_name):
4146
 
        # Create the master branch and its associated checkout
4147
 
        self.master = self.make_branch_and_tree(master_name)
4148
 
        self.checkout = self.master.branch.create_checkout(checkout_name)
4149
 
        # Modify the master branch so there is something to update
4150
 
        self.master.commit('add stuff')
4151
 
        self.last_revid = self.master.commit('even more stuff')
4152
 
        self.bound_location = self.checkout.branch.get_bound_location()
4153
 
 
4154
 
    def assertUpdateSucceeds(self, new_location):
4155
 
        self.checkout.branch.set_bound_location(new_location)
4156
 
        self.checkout.update()
4157
 
        self.assertEqual(self.last_revid, self.checkout.last_revision())
4158
 
 
4159
 
    def test_without_final_slash(self):
4160
 
        self.make_master_and_checkout('master', 'checkout')
4161
 
        # For unclear reasons some users have a bound_location without a final
4162
 
        # '/', simulate that by forcing such a value
4163
 
        self.assertEndsWith(self.bound_location, '/')
4164
 
        self.assertUpdateSucceeds(self.bound_location.rstrip('/'))
4165
 
 
4166
 
    def test_plus_sign(self):
4167
 
        self.make_master_and_checkout('+master', 'checkout')
4168
 
        self.assertUpdateSucceeds(self.bound_location.replace('%2B', '+', 1))
4169
 
 
4170
 
    def test_tilda(self):
4171
 
        # Embed ~ in the middle of the path just to avoid any $HOME
4172
 
        # interpretation
4173
 
        self.make_master_and_checkout('mas~ter', 'checkout')
4174
 
        self.assertUpdateSucceeds(self.bound_location.replace('%2E', '~', 1))
4175
 
 
4176
 
 
4177
 
class TestWithCustomErrorHandler(RemoteBranchTestCase):
4178
 
 
4179
 
    def test_no_context(self):
4180
 
        class OutOfCoffee(errors.BzrError):
4181
 
            """A dummy exception for testing."""
4182
 
 
4183
 
            def __init__(self, urgency):
4184
 
                self.urgency = urgency
4185
 
        remote.no_context_error_translators.register("OutOfCoffee",
4186
 
            lambda err: OutOfCoffee(err.error_args[0]))
4187
 
        transport = MemoryTransport()
4188
 
        client = FakeClient(transport.base)
4189
 
        client.add_expected_call(
4190
 
            'Branch.get_stacked_on_url', ('quack/',),
4191
 
            'error', ('NotStacked',))
4192
 
        client.add_expected_call(
4193
 
            'Branch.last_revision_info',
4194
 
            ('quack/',),
4195
 
            'error', ('OutOfCoffee', 'low'))
4196
 
        transport.mkdir('quack')
4197
 
        transport = transport.clone('quack')
4198
 
        branch = self.make_remote_branch(transport, client)
4199
 
        self.assertRaises(OutOfCoffee, branch.last_revision_info)
4200
 
        self.assertFinished(client)
4201
 
 
4202
 
    def test_with_context(self):
4203
 
        class OutOfTea(errors.BzrError):
4204
 
            def __init__(self, branch, urgency):
4205
 
                self.branch = branch
4206
 
                self.urgency = urgency
4207
 
        remote.error_translators.register("OutOfTea",
4208
 
            lambda err, find, path: OutOfTea(err.error_args[0],
4209
 
                find("branch")))
4210
 
        transport = MemoryTransport()
4211
 
        client = FakeClient(transport.base)
4212
 
        client.add_expected_call(
4213
 
            'Branch.get_stacked_on_url', ('quack/',),
4214
 
            'error', ('NotStacked',))
4215
 
        client.add_expected_call(
4216
 
            'Branch.last_revision_info',
4217
 
            ('quack/',),
4218
 
            'error', ('OutOfTea', 'low'))
4219
 
        transport.mkdir('quack')
4220
 
        transport = transport.clone('quack')
4221
 
        branch = self.make_remote_branch(transport, client)
4222
 
        self.assertRaises(OutOfTea, branch.last_revision_info)
4223
 
        self.assertFinished(client)
4224
 
 
4225
 
 
4226
 
class TestRepositoryPack(TestRemoteRepository):
4227
 
 
4228
 
    def test_pack(self):
4229
 
        transport_path = 'quack'
4230
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
4231
 
        client.add_expected_call(
4232
 
            'Repository.lock_write', ('quack/', ''),
4233
 
            'success', ('ok', 'token'))
4234
 
        client.add_expected_call(
4235
 
            'Repository.pack', ('quack/', 'token', 'False'),
4236
 
            'success', ('ok',), )
4237
 
        client.add_expected_call(
4238
 
            'Repository.unlock', ('quack/', 'token'),
4239
 
            'success', ('ok', ))
4240
 
        repo.pack()
4241
 
 
4242
 
    def test_pack_with_hint(self):
4243
 
        transport_path = 'quack'
4244
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
4245
 
        client.add_expected_call(
4246
 
            'Repository.lock_write', ('quack/', ''),
4247
 
            'success', ('ok', 'token'))
4248
 
        client.add_expected_call(
4249
 
            'Repository.pack', ('quack/', 'token', 'False'),
4250
 
            'success', ('ok',), )
4251
 
        client.add_expected_call(
4252
 
            'Repository.unlock', ('quack/', 'token', 'False'),
4253
 
            'success', ('ok', ))
4254
 
        repo.pack(['hinta', 'hintb'])
4255
 
 
4256
 
 
4257
 
class TestRepositoryIterInventories(TestRemoteRepository):
4258
 
    """Test Repository.iter_inventories."""
4259
 
 
4260
 
    def _serialize_inv_delta(self, old_name, new_name, delta):
4261
 
        serializer = inventory_delta.InventoryDeltaSerializer(True, False)
4262
 
        return "".join(serializer.delta_to_lines(old_name, new_name, delta))
4263
 
 
4264
 
    def test_single_empty(self):
4265
 
        transport_path = 'quack'
4266
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
4267
 
        fmt = controldir.format_registry.get('2a')().repository_format
4268
 
        repo._format = fmt
4269
 
        stream = [('inventory-deltas', [
4270
 
            versionedfile.FulltextContentFactory('somerevid', None, None,
4271
 
                self._serialize_inv_delta('null:', 'somerevid', []))])]
4272
 
        client.add_expected_call(
4273
 
            'VersionedFileRepository.get_inventories', ('quack/', 'unordered'),
4274
 
            'success', ('ok', ),
4275
 
            _stream_to_byte_stream(stream, fmt))
4276
 
        ret = list(repo.iter_inventories(["somerevid"]))
4277
 
        self.assertLength(1, ret)
4278
 
        inv = ret[0]
4279
 
        self.assertEqual("somerevid", inv.revision_id)
4280
 
 
4281
 
    def test_empty(self):
4282
 
        transport_path = 'quack'
4283
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
4284
 
        ret = list(repo.iter_inventories([]))
4285
 
        self.assertEqual(ret, [])
4286
 
 
4287
 
    def test_missing(self):
4288
 
        transport_path = 'quack'
4289
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
4290
 
        client.add_expected_call(
4291
 
            'VersionedFileRepository.get_inventories', ('quack/', 'unordered'),
4292
 
            'success', ('ok', ), iter([]))
4293
 
        self.assertRaises(errors.NoSuchRevision, list, repo.iter_inventories(
4294
 
            ["somerevid"]))