← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_btree_index.py

  • Committer: Robert Collins
  • Date: 2009-12-16 22:29:31 UTC
  • mto: This revision was merged to the branch mainline in revision 4920.
  • Revision ID: robertc@robertcollins.net-20091216222931-wbbn5ey4mwmpatwd
Review feedback.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_btree_index.py
1
 
# Copyright (C) 2008-2011 Canonical Ltd
 
1
# Copyright (C) 2008, 2009 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
27
27
    lru_cache,
28
28
    osutils,
29
29
    tests,
30
 
    transport,
31
30
    )
32
31
from bzrlib.tests import (
33
32
    TestCaseWithTransport,
34
 
    scenarios,
35
 
    )
36
 
from bzrlib.tests import (
37
 
    features,
38
 
    )
39
 
 
40
 
 
41
 
load_tests = scenarios.load_tests_apply_scenarios
42
 
 
43
 
 
44
 
def btreeparser_scenarios():
 
33
    condition_isinstance,
 
34
    multiply_tests,
 
35
    split_suite_by_condition,
 
36
    )
 
37
from bzrlib.transport import get_transport
 
38
 
 
39
 
 
40
def load_tests(standard_tests, module, loader):
 
41
    # parameterise the TestBTreeNodes tests
 
42
    node_tests, others = split_suite_by_condition(standard_tests,
 
43
        condition_isinstance(TestBTreeNodes))
45
44
    import bzrlib._btree_serializer_py as py_module
46
45
    scenarios = [('python', {'parse_btree': py_module})]
47
 
    if compiled_btreeparser_feature.available():
48
 
        scenarios.append(('C', 
49
 
            {'parse_btree': compiled_btreeparser_feature.module}))
50
 
    return scenarios
51
 
 
52
 
 
53
 
compiled_btreeparser_feature = features.ModuleAvailableFeature(
54
 
    'bzrlib._btree_serializer_pyx')
 
46
    if CompiledBtreeParserFeature.available():
 
47
        # Is there a way to do this that gets missing feature failures rather
 
48
        # than no indication to the user?
 
49
        import bzrlib._btree_serializer_pyx as c_module
 
50
        scenarios.append(('C', {'parse_btree': c_module}))
 
51
    return multiply_tests(node_tests, scenarios, others)
 
52
 
 
53
 
 
54
class _CompiledBtreeParserFeature(tests.Feature):
 
55
    def _probe(self):
 
56
        try:
 
57
            import bzrlib._btree_serializer_pyx
 
58
        except ImportError:
 
59
            return False
 
60
        return True
 
61
 
 
62
    def feature_name(self):
 
63
        return 'bzrlib._btree_serializer_pyx'
 
64
 
 
65
CompiledBtreeParserFeature = _CompiledBtreeParserFeature()
55
66
 
56
67
 
57
68
class BTreeTestCase(TestCaseWithTransport):
60
71
 
61
72
    def setUp(self):
62
73
        TestCaseWithTransport.setUp(self)
63
 
        self.overrideAttr(btree_index, '_RESERVED_HEADER_BYTES', 100)
 
74
        self._original_header = btree_index._RESERVED_HEADER_BYTES
 
75
        def restore():
 
76
            btree_index._RESERVED_HEADER_BYTES = self._original_header
 
77
        self.addCleanup(restore)
 
78
        btree_index._RESERVED_HEADER_BYTES = 100
64
79
 
65
80
    def make_nodes(self, count, key_elements, reference_lists):
66
81
        """Generate count*key_elements sample nodes."""
100
115
 
101
116
    def shrink_page_size(self):
102
117
        """Shrink the default page size so that less fits in a page."""
103
 
        self.overrideAttr(btree_index, '_PAGE_SIZE')
 
118
        old_page_size = btree_index._PAGE_SIZE
 
119
        def cleanup():
 
120
            btree_index._PAGE_SIZE = old_page_size
 
121
        self.addCleanup(cleanup)
104
122
        btree_index._PAGE_SIZE = 2048
105
123
 
106
124
 
217
235
        leaf1_bytes = zlib.decompress(leaf1)
218
236
        sorted_node_keys = sorted(node[0] for node in nodes)
219
237
        node = btree_index._LeafNode(leaf1_bytes, 1, 0)
220
 
        self.assertEqual(231, len(node))
221
 
        self.assertEqual(sorted_node_keys[:231], node.all_keys())
 
238
        self.assertEqual(231, len(node.keys))
 
239
        self.assertEqual(sorted_node_keys[:231], sorted(node.keys))
222
240
        leaf2_bytes = zlib.decompress(leaf2)
223
241
        node = btree_index._LeafNode(leaf2_bytes, 1, 0)
224
 
        self.assertEqual(400 - 231, len(node))
225
 
        self.assertEqual(sorted_node_keys[231:], node.all_keys())
 
242
        self.assertEqual(400 - 231, len(node.keys))
 
243
        self.assertEqual(sorted_node_keys[231:], sorted(node.keys))
226
244
 
227
245
    def test_last_page_rounded_1_layer(self):
228
246
        builder = btree_index.BTreeBuilder(key_elements=1, reference_lists=0)
242
260
        leaf2 = content[74:]
243
261
        leaf2_bytes = zlib.decompress(leaf2)
244
262
        node = btree_index._LeafNode(leaf2_bytes, 1, 0)
245
 
        self.assertEqual(10, len(node))
 
263
        self.assertEqual(10, len(node.keys))
246
264
        sorted_node_keys = sorted(node[0] for node in nodes)
247
 
        self.assertEqual(sorted_node_keys, node.all_keys())
 
265
        self.assertEqual(sorted_node_keys, sorted(node.keys))
248
266
 
249
267
    def test_last_page_not_rounded_2_layer(self):
250
268
        builder = btree_index.BTreeBuilder(key_elements=1, reference_lists=0)
264
282
        leaf2 = content[8192:]
265
283
        leaf2_bytes = zlib.decompress(leaf2)
266
284
        node = btree_index._LeafNode(leaf2_bytes, 1, 0)
267
 
        self.assertEqual(400 - 231, len(node))
 
285
        self.assertEqual(400 - 231, len(node.keys))
268
286
        sorted_node_keys = sorted(node[0] for node in nodes)
269
 
        self.assertEqual(sorted_node_keys[231:], node.all_keys())
 
287
        self.assertEqual(sorted_node_keys[231:], sorted(node.keys))
270
288
 
271
289
    def test_three_level_tree_details(self):
272
290
        # The left most pointer in the second internal node in a row should
281
299
 
282
300
        for node in nodes:
283
301
            builder.add_node(*node)
284
 
        t = transport.get_transport('trace+' + self.get_url(''))
285
 
        size = t.put_file('index', self.time(builder.finish))
 
302
        transport = get_transport('trace+' + self.get_url(''))
 
303
        size = transport.put_file('index', self.time(builder.finish))
286
304
        del builder
287
 
        index = btree_index.BTreeGraphIndex(t, 'index', size)
 
305
        index = btree_index.BTreeGraphIndex(transport, 'index', size)
288
306
        # Seed the metadata, we're using internal calls now.
289
307
        index.key_count()
290
308
        self.assertEqual(3, len(index._row_lengths),
303
321
        # in the second node it points at
304
322
        pos = index._row_offsets[2] + internal_node2.offset + 1
305
323
        leaf = index._get_leaf_nodes([pos])[pos]
306
 
        self.assertTrue(internal_node2.keys[0] in leaf)
 
324
        self.assertTrue(internal_node2.keys[0] in leaf.keys)
307
325
 
308
326
    def test_2_leaves_2_2(self):
309
327
        builder = btree_index.BTreeBuilder(key_elements=2, reference_lists=2)
410
428
        self.assertEqual(None, builder._backing_indices[2])
411
429
        self.assertEqual(16, builder._backing_indices[3].key_count())
412
430
        # Now finish, and check we got a correctly ordered tree
413
 
        t = self.get_transport('')
414
 
        size = t.put_file('index', builder.finish())
415
 
        index = btree_index.BTreeGraphIndex(t, 'index', size)
 
431
        transport = self.get_transport('')
 
432
        size = transport.put_file('index', builder.finish())
 
433
        index = btree_index.BTreeGraphIndex(transport, 'index', size)
416
434
        nodes = list(index.iter_all_entries())
417
435
        self.assertEqual(sorted(nodes), nodes)
418
436
        self.assertEqual(16, len(nodes))
608
626
        for key, value, references in nodes:
609
627
            builder.add_node(key, value, references)
610
628
        stream = builder.finish()
611
 
        trans = transport.get_transport('trace+' + self.get_url())
 
629
        trans = get_transport('trace+' + self.get_url())
612
630
        size = trans.put_file('index', stream)
613
631
        return btree_index.BTreeGraphIndex(trans, 'index', size)
614
632
 
615
 
    def make_index_with_offset(self, ref_lists=1, key_elements=1, nodes=[],
616
 
                               offset=0):
617
 
        builder = btree_index.BTreeBuilder(key_elements=key_elements,
618
 
                                           reference_lists=ref_lists)
619
 
        builder.add_nodes(nodes)
620
 
        transport = self.get_transport('')
621
 
        # NamedTemporaryFile dies on builder.finish().read(). weird.
622
 
        temp_file = builder.finish()
623
 
        content = temp_file.read()
624
 
        del temp_file
625
 
        size = len(content)
626
 
        transport.put_bytes('index', (' '*offset)+content)
627
 
        return btree_index.BTreeGraphIndex(transport, 'index', size=size,
628
 
                                           offset=offset)
629
 
 
630
633
    def test_clear_cache(self):
631
634
        nodes = self.make_nodes(160, 2, 2)
632
635
        index = self.make_index(ref_lists=2, key_elements=2, nodes=nodes)
649
652
        self.assertEqual(0, len(index._leaf_node_cache))
650
653
 
651
654
    def test_trivial_constructor(self):
652
 
        t = transport.get_transport('trace+' + self.get_url(''))
653
 
        index = btree_index.BTreeGraphIndex(t, 'index', None)
 
655
        transport = get_transport('trace+' + self.get_url(''))
 
656
        index = btree_index.BTreeGraphIndex(transport, 'index', None)
654
657
        # Checks the page size at load, but that isn't logged yet.
655
 
        self.assertEqual([], t._activity)
 
658
        self.assertEqual([], transport._activity)
656
659
 
657
660
    def test_with_size_constructor(self):
658
 
        t = transport.get_transport('trace+' + self.get_url(''))
659
 
        index = btree_index.BTreeGraphIndex(t, 'index', 1)
 
661
        transport = get_transport('trace+' + self.get_url(''))
 
662
        index = btree_index.BTreeGraphIndex(transport, 'index', 1)
660
663
        # Checks the page size at load, but that isn't logged yet.
661
 
        self.assertEqual([], t._activity)
 
664
        self.assertEqual([], transport._activity)
662
665
 
663
666
    def test_empty_key_count_no_size(self):
664
667
        builder = btree_index.BTreeBuilder(key_elements=1, reference_lists=0)
665
 
        t = transport.get_transport('trace+' + self.get_url(''))
666
 
        t.put_file('index', builder.finish())
667
 
        index = btree_index.BTreeGraphIndex(t, 'index', None)
668
 
        del t._activity[:]
669
 
        self.assertEqual([], t._activity)
 
668
        transport = get_transport('trace+' + self.get_url(''))
 
669
        transport.put_file('index', builder.finish())
 
670
        index = btree_index.BTreeGraphIndex(transport, 'index', None)
 
671
        del transport._activity[:]
 
672
        self.assertEqual([], transport._activity)
670
673
        self.assertEqual(0, index.key_count())
671
674
        # The entire index should have been requested (as we generally have the
672
675
        # size available, and doing many small readvs is inappropriate).
673
676
        # We can't tell how much was actually read here, but - check the code.
674
 
        self.assertEqual([('get', 'index')], t._activity)
 
677
        self.assertEqual([('get', 'index')], transport._activity)
675
678
 
676
679
    def test_empty_key_count(self):
677
680
        builder = btree_index.BTreeBuilder(key_elements=1, reference_lists=0)
678
 
        t = transport.get_transport('trace+' + self.get_url(''))
679
 
        size = t.put_file('index', builder.finish())
 
681
        transport = get_transport('trace+' + self.get_url(''))
 
682
        size = transport.put_file('index', builder.finish())
680
683
        self.assertEqual(72, size)
681
 
        index = btree_index.BTreeGraphIndex(t, 'index', size)
682
 
        del t._activity[:]
683
 
        self.assertEqual([], t._activity)
 
684
        index = btree_index.BTreeGraphIndex(transport, 'index', size)
 
685
        del transport._activity[:]
 
686
        self.assertEqual([], transport._activity)
684
687
        self.assertEqual(0, index.key_count())
685
688
        # The entire index should have been read, as 4K > size
686
689
        self.assertEqual([('readv', 'index', [(0, 72)], False, None)],
687
 
                         t._activity)
 
690
            transport._activity)
688
691
 
689
692
    def test_non_empty_key_count_2_2(self):
690
693
        builder = btree_index.BTreeBuilder(key_elements=2, reference_lists=2)
691
694
        nodes = self.make_nodes(35, 2, 2)
692
695
        for node in nodes:
693
696
            builder.add_node(*node)
694
 
        t = transport.get_transport('trace+' + self.get_url(''))
695
 
        size = t.put_file('index', builder.finish())
696
 
        index = btree_index.BTreeGraphIndex(t, 'index', size)
697
 
        del t._activity[:]
698
 
        self.assertEqual([], t._activity)
 
697
        transport = get_transport('trace+' + self.get_url(''))
 
698
        size = transport.put_file('index', builder.finish())
 
699
        index = btree_index.BTreeGraphIndex(transport, 'index', size)
 
700
        del transport._activity[:]
 
701
        self.assertEqual([], transport._activity)
699
702
        self.assertEqual(70, index.key_count())
700
703
        # The entire index should have been read, as it is one page long.
701
704
        self.assertEqual([('readv', 'index', [(0, size)], False, None)],
702
 
            t._activity)
 
705
            transport._activity)
703
706
        self.assertEqual(1173, size)
704
707
 
705
 
    def test_with_offset_no_size(self):
706
 
        index = self.make_index_with_offset(key_elements=1, ref_lists=1,
707
 
                                            offset=1234,
708
 
                                            nodes=self.make_nodes(200, 1, 1))
709
 
        index._size = None # throw away the size info
710
 
        self.assertEqual(200, index.key_count())
711
 
 
712
 
    def test_with_small_offset(self):
713
 
        index = self.make_index_with_offset(key_elements=1, ref_lists=1,
714
 
                                            offset=1234,
715
 
                                            nodes=self.make_nodes(200, 1, 1))
716
 
        self.assertEqual(200, index.key_count())
717
 
 
718
 
    def test_with_large_offset(self):
719
 
        index = self.make_index_with_offset(key_elements=1, ref_lists=1,
720
 
                                            offset=123456,
721
 
                                            nodes=self.make_nodes(200, 1, 1))
722
 
        self.assertEqual(200, index.key_count())
723
 
 
724
708
    def test__read_nodes_no_size_one_page_reads_once(self):
725
709
        self.make_index(nodes=[(('key',), 'value', ())])
726
 
        trans = transport.get_transport('trace+' + self.get_url())
 
710
        trans = get_transport('trace+' + self.get_url())
727
711
        index = btree_index.BTreeGraphIndex(trans, 'index', None)
728
712
        del trans._activity[:]
729
713
        nodes = dict(index._read_nodes([0]))
730
714
        self.assertEqual([0], nodes.keys())
731
715
        node = nodes[0]
732
 
        self.assertEqual([('key',)], node.all_keys())
 
716
        self.assertEqual([('key',)], node.keys.keys())
733
717
        self.assertEqual([('get', 'index')], trans._activity)
734
718
 
735
719
    def test__read_nodes_no_size_multiple_pages(self):
737
721
        index.key_count()
738
722
        num_pages = index._row_offsets[-1]
739
723
        # Reopen with a traced transport and no size
740
 
        trans = transport.get_transport('trace+' + self.get_url())
 
724
        trans = get_transport('trace+' + self.get_url())
741
725
        index = btree_index.BTreeGraphIndex(trans, 'index', None)
742
726
        del trans._activity[:]
743
727
        nodes = dict(index._read_nodes([0]))
748
732
        nodes = self.make_nodes(160, 2, 2)
749
733
        for node in nodes:
750
734
            builder.add_node(*node)
751
 
        t = transport.get_transport('trace+' + self.get_url(''))
752
 
        size = t.put_file('index', builder.finish())
 
735
        transport = get_transport('trace+' + self.get_url(''))
 
736
        size = transport.put_file('index', builder.finish())
753
737
        self.assertEqual(17692, size)
754
 
        index = btree_index.BTreeGraphIndex(t, 'index', size)
755
 
        del t._activity[:]
756
 
        self.assertEqual([], t._activity)
 
738
        index = btree_index.BTreeGraphIndex(transport, 'index', size)
 
739
        del transport._activity[:]
 
740
        self.assertEqual([], transport._activity)
757
741
        self.assertEqual(320, index.key_count())
758
742
        # The entire index should not have been read.
759
743
        self.assertEqual([('readv', 'index', [(0, 4096)], False, None)],
760
 
                         t._activity)
 
744
            transport._activity)
761
745
 
762
746
    def test_validate_one_page(self):
763
747
        builder = btree_index.BTreeBuilder(key_elements=2, reference_lists=2)
764
748
        nodes = self.make_nodes(45, 2, 2)
765
749
        for node in nodes:
766
750
            builder.add_node(*node)
767
 
        t = transport.get_transport('trace+' + self.get_url(''))
768
 
        size = t.put_file('index', builder.finish())
769
 
        index = btree_index.BTreeGraphIndex(t, 'index', size)
770
 
        del t._activity[:]
771
 
        self.assertEqual([], t._activity)
 
751
        transport = get_transport('trace+' + self.get_url(''))
 
752
        size = transport.put_file('index', builder.finish())
 
753
        index = btree_index.BTreeGraphIndex(transport, 'index', size)
 
754
        del transport._activity[:]
 
755
        self.assertEqual([], transport._activity)
772
756
        index.validate()
773
757
        # The entire index should have been read linearly.
774
758
        self.assertEqual([('readv', 'index', [(0, size)], False, None)],
775
 
                         t._activity)
 
759
            transport._activity)
776
760
        self.assertEqual(1488, size)
777
761
 
778
762
    def test_validate_two_pages(self):
780
764
        nodes = self.make_nodes(80, 2, 2)
781
765
        for node in nodes:
782
766
            builder.add_node(*node)
783
 
        t = transport.get_transport('trace+' + self.get_url(''))
784
 
        size = t.put_file('index', builder.finish())
 
767
        transport = get_transport('trace+' + self.get_url(''))
 
768
        size = transport.put_file('index', builder.finish())
785
769
        # Root page, 2 leaf pages
786
770
        self.assertEqual(9339, size)
787
 
        index = btree_index.BTreeGraphIndex(t, 'index', size)
788
 
        del t._activity[:]
789
 
        self.assertEqual([], t._activity)
 
771
        index = btree_index.BTreeGraphIndex(transport, 'index', size)
 
772
        del transport._activity[:]
 
773
        self.assertEqual([], transport._activity)
790
774
        index.validate()
791
775
        # The entire index should have been read linearly.
792
 
        self.assertEqual(
793
 
            [('readv', 'index', [(0, 4096)], False, None),
794
 
             ('readv', 'index', [(4096, 4096), (8192, 1147)], False, None)],
795
 
            t._activity)
 
776
        self.assertEqual([('readv', 'index', [(0, 4096)], False, None),
 
777
            ('readv', 'index', [(4096, 4096), (8192, 1147)], False, None)],
 
778
            transport._activity)
796
779
        # XXX: TODO: write some badly-ordered nodes, and some pointers-to-wrong
797
780
        # node and make validate find them.
798
781
 
799
782
    def test_eq_ne(self):
800
783
        # two indices are equal when constructed with the same parameters:
801
 
        t1 = transport.get_transport('trace+' + self.get_url(''))
802
 
        t2 = self.get_transport()
803
 
        self.assertTrue(
804
 
            btree_index.BTreeGraphIndex(t1, 'index', None) ==
805
 
            btree_index.BTreeGraphIndex(t1, 'index', None))
806
 
        self.assertTrue(
807
 
            btree_index.BTreeGraphIndex(t1, 'index', 20) ==
808
 
            btree_index.BTreeGraphIndex(t1, 'index', 20))
809
 
        self.assertFalse(
810
 
            btree_index.BTreeGraphIndex(t1, 'index', 20) ==
811
 
            btree_index.BTreeGraphIndex(t2, 'index', 20))
812
 
        self.assertFalse(
813
 
            btree_index.BTreeGraphIndex(t1, 'inde1', 20) ==
814
 
            btree_index.BTreeGraphIndex(t1, 'inde2', 20))
815
 
        self.assertFalse(
816
 
            btree_index.BTreeGraphIndex(t1, 'index', 10) ==
817
 
            btree_index.BTreeGraphIndex(t1, 'index', 20))
818
 
        self.assertFalse(
819
 
            btree_index.BTreeGraphIndex(t1, 'index', None) !=
820
 
            btree_index.BTreeGraphIndex(t1, 'index', None))
821
 
        self.assertFalse(
822
 
            btree_index.BTreeGraphIndex(t1, 'index', 20) !=
823
 
            btree_index.BTreeGraphIndex(t1, 'index', 20))
824
 
        self.assertTrue(
825
 
            btree_index.BTreeGraphIndex(t1, 'index', 20) !=
826
 
            btree_index.BTreeGraphIndex(t2, 'index', 20))
827
 
        self.assertTrue(
828
 
            btree_index.BTreeGraphIndex(t1, 'inde1', 20) !=
829
 
            btree_index.BTreeGraphIndex(t1, 'inde2', 20))
830
 
        self.assertTrue(
831
 
            btree_index.BTreeGraphIndex(t1, 'index', 10) !=
832
 
            btree_index.BTreeGraphIndex(t1, 'index', 20))
 
784
        transport1 = get_transport('trace+' + self.get_url(''))
 
785
        transport2 = get_transport(self.get_url(''))
 
786
        self.assertTrue(
 
787
            btree_index.BTreeGraphIndex(transport1, 'index', None) ==
 
788
            btree_index.BTreeGraphIndex(transport1, 'index', None))
 
789
        self.assertTrue(
 
790
            btree_index.BTreeGraphIndex(transport1, 'index', 20) ==
 
791
            btree_index.BTreeGraphIndex(transport1, 'index', 20))
 
792
        self.assertFalse(
 
793
            btree_index.BTreeGraphIndex(transport1, 'index', 20) ==
 
794
            btree_index.BTreeGraphIndex(transport2, 'index', 20))
 
795
        self.assertFalse(
 
796
            btree_index.BTreeGraphIndex(transport1, 'inde1', 20) ==
 
797
            btree_index.BTreeGraphIndex(transport1, 'inde2', 20))
 
798
        self.assertFalse(
 
799
            btree_index.BTreeGraphIndex(transport1, 'index', 10) ==
 
800
            btree_index.BTreeGraphIndex(transport1, 'index', 20))
 
801
        self.assertFalse(
 
802
            btree_index.BTreeGraphIndex(transport1, 'index', None) !=
 
803
            btree_index.BTreeGraphIndex(transport1, 'index', None))
 
804
        self.assertFalse(
 
805
            btree_index.BTreeGraphIndex(transport1, 'index', 20) !=
 
806
            btree_index.BTreeGraphIndex(transport1, 'index', 20))
 
807
        self.assertTrue(
 
808
            btree_index.BTreeGraphIndex(transport1, 'index', 20) !=
 
809
            btree_index.BTreeGraphIndex(transport2, 'index', 20))
 
810
        self.assertTrue(
 
811
            btree_index.BTreeGraphIndex(transport1, 'inde1', 20) !=
 
812
            btree_index.BTreeGraphIndex(transport1, 'inde2', 20))
 
813
        self.assertTrue(
 
814
            btree_index.BTreeGraphIndex(transport1, 'index', 10) !=
 
815
            btree_index.BTreeGraphIndex(transport1, 'index', 20))
833
816
 
834
817
    def test_iter_all_only_root_no_size(self):
835
818
        self.make_index(nodes=[(('key',), 'value', ())])
836
 
        t = transport.get_transport('trace+' + self.get_url(''))
837
 
        index = btree_index.BTreeGraphIndex(t, 'index', None)
838
 
        del t._activity[:]
 
819
        trans = get_transport('trace+' + self.get_url(''))
 
820
        index = btree_index.BTreeGraphIndex(trans, 'index', None)
 
821
        del trans._activity[:]
839
822
        self.assertEqual([(('key',), 'value')],
840
823
                         [x[1:] for x in index.iter_all_entries()])
841
 
        self.assertEqual([('get', 'index')], t._activity)
 
824
        self.assertEqual([('get', 'index')], trans._activity)
842
825
 
843
826
    def test_iter_all_entries_reads(self):
844
827
        # iterating all entries reads the header, then does a linear
850
833
        nodes = self.make_nodes(10000, 2, 2)
851
834
        for node in nodes:
852
835
            builder.add_node(*node)
853
 
        t = transport.get_transport('trace+' + self.get_url(''))
854
 
        size = t.put_file('index', builder.finish())
 
836
        transport = get_transport('trace+' + self.get_url(''))
 
837
        size = transport.put_file('index', builder.finish())
855
838
        self.assertEqual(1303220, size, 'number of expected bytes in the'
856
839
                                        ' output changed')
857
840
        page_size = btree_index._PAGE_SIZE
858
841
        del builder
859
 
        index = btree_index.BTreeGraphIndex(t, 'index', size)
860
 
        del t._activity[:]
861
 
        self.assertEqual([], t._activity)
 
842
        index = btree_index.BTreeGraphIndex(transport, 'index', size)
 
843
        del transport._activity[:]
 
844
        self.assertEqual([], transport._activity)
862
845
        found_nodes = self.time(list, index.iter_all_entries())
863
846
        bare_nodes = []
864
847
        for node in found_nodes:
885
868
        readv_request[-1] = (readv_request[-1][0], 1303220 % page_size)
886
869
        expected = [('readv', 'index', [(0, page_size)], False, None),
887
870
             ('readv',  'index', readv_request, False, None)]
888
 
        if expected != t._activity:
 
871
        if expected != transport._activity:
889
872
            self.assertEqualDiff(pprint.pformat(expected),
890
873
                                 pprint.pformat(transport._activity))
891
874
 
905
888
        nodes = self.make_nodes(160, 2, 2)
906
889
        for node in nodes:
907
890
            builder.add_node(*node)
908
 
        t = transport.get_transport('trace+' + self.get_url(''))
909
 
        size = t.put_file('index', builder.finish())
 
891
        transport = get_transport('trace+' + self.get_url(''))
 
892
        size = transport.put_file('index', builder.finish())
910
893
        del builder
911
 
        index = btree_index.BTreeGraphIndex(t, 'index', size)
912
 
        del t._activity[:]
913
 
        self.assertEqual([], t._activity)
 
894
        index = btree_index.BTreeGraphIndex(transport, 'index', size)
 
895
        del transport._activity[:]
 
896
        self.assertEqual([], transport._activity)
914
897
        # search for one key
915
898
        found_nodes = list(index.iter_entries([nodes[30][0]]))
916
899
        bare_nodes = []
924
907
        # Should have read the root node, then one leaf page:
925
908
        self.assertEqual([('readv', 'index', [(0, 4096)], False, None),
926
909
             ('readv',  'index', [(8192, 4096), ], False, None)],
927
 
            t._activity)
 
910
            transport._activity)
928
911
 
929
912
    def test_iter_key_prefix_1_element_key_None(self):
930
913
        index = self.make_index()
1113
1096
        min_l2_key = l2.min_key
1114
1097
        max_l1_key = l1.max_key
1115
1098
        self.assertTrue(max_l1_key < min_l2_key)
1116
 
        parents_min_l2_key = l2[min_l2_key][1][0]
 
1099
        parents_min_l2_key = l2.keys[min_l2_key][1][0]
1117
1100
        self.assertEqual((l1.max_key,), parents_min_l2_key)
1118
1101
        # Now, whatever key we select that would fall on the second page,
1119
1102
        # should give us all the parents until the page break
1132
1115
        parent_map = {}
1133
1116
        search_keys = index._find_ancestors([max_l1_key], 0, parent_map,
1134
1117
                                            missing_keys)
1135
 
        self.assertEqual(l1.all_keys(), sorted(parent_map))
 
1118
        self.assertEqual(sorted(l1.keys), sorted(parent_map))
1136
1119
        self.assertEqual(set(), missing_keys)
1137
1120
        self.assertEqual(set(), search_keys)
1138
1121
 
1154
1137
        for node in nodes:
1155
1138
            builder.add_node(*node)
1156
1139
        stream = builder.finish()
1157
 
        trans = self.get_transport()
 
1140
        trans = get_transport(self.get_url())
1158
1141
        size = trans.put_file('index', stream)
1159
1142
        index = btree_index.BTreeGraphIndex(trans, 'index', size)
1160
1143
        self.assertEqual(500, index.key_count())
1186
1169
 
1187
1170
class TestBTreeNodes(BTreeTestCase):
1188
1171
 
1189
 
    scenarios = btreeparser_scenarios()
 
1172
    def restore_parser(self):
 
1173
        btree_index._btree_serializer = self.saved_parser
1190
1174
 
1191
1175
    def setUp(self):
1192
1176
        BTreeTestCase.setUp(self)
1193
 
        self.overrideAttr(btree_index, '_btree_serializer', self.parse_btree)
 
1177
        self.saved_parser = btree_index._btree_serializer
 
1178
        self.addCleanup(self.restore_parser)
 
1179
        btree_index._btree_serializer = self.parse_btree
1194
1180
 
1195
1181
    def test_LeafNode_1_0(self):
1196
1182
        node_bytes = ("type=leaf\n"
1208
1194
            ("2222222222222222222222222222222222222222",): ("value:2", ()),
1209
1195
            ("3333333333333333333333333333333333333333",): ("value:3", ()),
1210
1196
            ("4444444444444444444444444444444444444444",): ("value:4", ()),
1211
 
            }, dict(node.all_items()))
 
1197
            }, node.keys)
1212
1198
 
1213
1199
    def test_LeafNode_2_2(self):
1214
1200
        node_bytes = ("type=leaf\n"
1228
1214
            ('11', '33'): ('value:3',
1229
1215
                ((('11', 'ref22'),), (('11', 'ref22'), ('11', 'ref22')))),
1230
1216
            ('11', '44'): ('value:4', ((), (('11', 'ref00'),)))
1231
 
            }, dict(node.all_items()))
 
1217
            }, node.keys)
1232
1218
 
1233
1219
    def test_InternalNode_1(self):
1234
1220
        node_bytes = ("type=internal\n"
1269
1255
            ('11', '33'): ('value:3',
1270
1256
                ((('11', 'ref22'),), (('11', 'ref22'), ('11', 'ref22')))),
1271
1257
            ('11', '44'): ('value:4', ((), (('11', 'ref00'),)))
1272
 
            }, dict(node.all_items()))
 
1258
            }, node.keys)
1273
1259
 
1274
1260
    def assertFlattened(self, expected, key, value, refs):
1275
1261
        flat_key, flat_line = self.parse_btree._flatten_node(
1307
1293
    def test_exists(self):
1308
1294
        # This is just to let the user know if they don't have the feature
1309
1295
        # available
1310
 
        self.requireFeature(compiled_btreeparser_feature)
 
1296
        self.requireFeature(CompiledBtreeParserFeature)
1311
1297
 
1312
1298
 
1313
1299
class TestMultiBisectRight(tests.TestCase):
1353
1339
        This doesn't actually create anything on disk, it just primes a
1354
1340
        BTreeGraphIndex with the recommended information.
1355
1341
        """
1356
 
        index = btree_index.BTreeGraphIndex(
1357
 
            transport.get_transport('memory:///'), 'test-index', size=size)
 
1342
        index = btree_index.BTreeGraphIndex(get_transport('memory:///'),
 
1343
                                            'test-index', size=size)
1358
1344
        if recommended_pages is not None:
1359
1345
            index._recommended_pages = recommended_pages
1360
1346
        return index