~bzr-pqm/bzr/bzr.dev

Viewing all changes in revision 4725.3.1.

  • Committer: Vincent Ladeuil
  • Date: 2009-10-05 14:29:46 UTC
  • mto: (4728.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 4729.
  • Revision ID: v.ladeuil+lp@free.fr-20091005142946-26vzznan0kgxlq11
Fix test failure and clean up ftp APPE.

* bzrlib/transport/ftp/__init__.py:
(FtpTransport._try_append): Bad usage of the library and mixed
dialogs left the connection is ASCII mode at the wrong time.
(FtpTransport._try_append, FtpTransport._fallback_append): Use a
file-like object instead of a str parametre to avoid useless
buffering.
(FtpTransport.append_file): Don't read the whole text to append,
leave the called functions handled that instead.

* bzrlib/tests/ftp_server/pyftpdlib_based.py:
(FTPTestServer._run_server): Don't let spurious EBADF pollute the
test outputs, they are rare but it's useless to report them.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: