← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_symbol_versioning.py

  • Committer: Robert Collins
  • Date: 2009-09-07 03:08:30 UTC
  • mto: This revision was merged to the branch mainline in revision 4690.
  • Revision ID: robertc@robertcollins.net-20090907030830-rf59kt28d550eauj
Milestones language tightning, internal consistency.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_symbol_versioning.py
1
 
# Copyright (C) 2006 by Canonical Ltd
2
 
#   Authors: Robert Collins <robert.collins@canonical.com>
 
1
# Copyright (C) 2006, 2007, 2009 Canonical Ltd
3
2
#
4
3
# This program is free software; you can redistribute it and/or modify
5
4
# it under the terms of the GNU General Public License as published by
13
12
#
14
13
# You should have received a copy of the GNU General Public License
15
14
# along with this program; if not, write to the Free Software
16
 
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
17
16
 
18
17
"""Symbol versioning tests."""
19
18
 
20
 
import bzrlib.symbol_versioning as symbol_versioning
 
19
import warnings
 
20
 
 
21
from bzrlib import symbol_versioning
 
22
from bzrlib.symbol_versioning import (
 
23
    deprecated_function,
 
24
    deprecated_in,
 
25
    deprecated_list,
 
26
    deprecated_method,
 
27
    )
21
28
from bzrlib.tests import TestCase
22
29
 
23
30
 
24
 
@symbol_versioning.deprecated_function(symbol_versioning.zero_seven)
25
 
def deprecated_function():
 
31
@deprecated_function(deprecated_in((0, 7, 0)))
 
32
def sample_deprecated_function():
26
33
    """Deprecated function docstring."""
27
34
    return 1
28
35
 
29
36
 
 
37
a_deprecated_list = symbol_versioning.deprecated_list(deprecated_in((0, 9, 0)),
 
38
    'a_deprecated_list', ['one'], extra="Don't use me")
 
39
 
 
40
 
 
41
a_deprecated_dict = symbol_versioning.DeprecatedDict(
 
42
    deprecated_in((0, 14, 0)),
 
43
    'a_deprecated_dict',
 
44
    dict(a=42),
 
45
    advice='Pull the other one!',
 
46
    )
 
47
 
 
48
 
30
49
class TestDeprecationWarnings(TestCase):
31
50
 
32
51
    def capture_warning(self, message, category, stacklevel=None):
36
55
        super(TestDeprecationWarnings, self).setUp()
37
56
        self._warnings = []
38
57
    
39
 
    @symbol_versioning.deprecated_method(symbol_versioning.zero_seven)
 
58
    @deprecated_method(deprecated_in((0, 7, 0)))
40
59
    def deprecated_method(self):
41
60
        """Deprecated method docstring.
42
 
        
 
61
 
43
62
        This might explain stuff.
44
63
        """
45
64
        return 1
46
65
 
 
66
    @staticmethod
 
67
    @deprecated_function(deprecated_in((0, 7, 0)))
 
68
    def deprecated_static():
 
69
        """Deprecated static."""
 
70
        return 1
 
71
 
 
72
    def test_deprecated_static(self):
 
73
        # XXX: The results are not quite right because the class name is not
 
74
        # shown - however it is enough to give people a good indication of
 
75
        # where the problem is.
 
76
        expected_warning = (
 
77
            "bzrlib.tests.test_symbol_versioning."
 
78
            "deprecated_static "
 
79
            "was deprecated in version 0.7.", DeprecationWarning, 2)
 
80
        expected_docstring = (
 
81
            'Deprecated static.\n'
 
82
            '\n'
 
83
            'This function was deprecated in version 0.7.\n'
 
84
            )
 
85
        self.check_deprecated_callable(
 
86
            expected_warning, expected_docstring,
 
87
            "deprecated_static",
 
88
            "bzrlib.tests.test_symbol_versioning",
 
89
            self.deprecated_static)
 
90
 
47
91
    def test_deprecated_method(self):
48
92
        expected_warning = (
49
93
            "bzrlib.tests.test_symbol_versioning."
50
94
            "TestDeprecationWarnings.deprecated_method "
51
95
            "was deprecated in version 0.7.", DeprecationWarning, 2)
52
96
        expected_docstring = ('Deprecated method docstring.\n'
53
 
                              '        \n'
 
97
                              '\n'
54
98
                              '        This might explain stuff.\n'
55
99
                              '        \n'
56
100
                              '        This method was deprecated in version 0.7.\n'
62
106
 
63
107
    def test_deprecated_function(self):
64
108
        expected_warning = (
65
 
            "bzrlib.tests.test_symbol_versioning.deprecated_function "
 
109
            "bzrlib.tests.test_symbol_versioning.sample_deprecated_function "
66
110
            "was deprecated in version 0.7.", DeprecationWarning, 2)
67
111
        expected_docstring = ('Deprecated function docstring.\n'
68
112
                              '\n'
69
113
                              'This function was deprecated in version 0.7.\n'
70
114
                              )
71
115
        self.check_deprecated_callable(expected_warning, expected_docstring,
72
 
                                       "deprecated_function",
 
116
                                       "sample_deprecated_function",
73
117
                                       "bzrlib.tests.test_symbol_versioning",
74
 
                                       deprecated_function)
 
118
                                       sample_deprecated_function)
 
119
 
 
120
    def test_deprecated_list(self):
 
121
        expected_warning = (
 
122
            "Modifying a_deprecated_list was deprecated in version 0.9."
 
123
            " Don't use me", DeprecationWarning, 3)
 
124
        old_warning_method = symbol_versioning.warn
 
125
        try:
 
126
            symbol_versioning.set_warning_method(self.capture_warning)
 
127
            self.assertEqual(['one'], a_deprecated_list)
 
128
            self.assertEqual([], self._warnings)
 
129
 
 
130
            a_deprecated_list.append('foo')
 
131
            self.assertEqual([expected_warning], self._warnings)
 
132
            self.assertEqual(['one', 'foo'], a_deprecated_list)
 
133
 
 
134
            a_deprecated_list.extend(['bar', 'baz'])
 
135
            self.assertEqual([expected_warning]*2, self._warnings)
 
136
            self.assertEqual(['one', 'foo', 'bar', 'baz'], a_deprecated_list)
 
137
 
 
138
            a_deprecated_list.insert(1, 'xxx')
 
139
            self.assertEqual([expected_warning]*3, self._warnings)
 
140
            self.assertEqual(['one', 'xxx', 'foo', 'bar', 'baz'], a_deprecated_list)
 
141
 
 
142
            a_deprecated_list.remove('foo')
 
143
            self.assertEqual([expected_warning]*4, self._warnings)
 
144
            self.assertEqual(['one', 'xxx', 'bar', 'baz'], a_deprecated_list)
 
145
 
 
146
            val = a_deprecated_list.pop()
 
147
            self.assertEqual([expected_warning]*5, self._warnings)
 
148
            self.assertEqual('baz', val)
 
149
            self.assertEqual(['one', 'xxx', 'bar'], a_deprecated_list)
 
150
 
 
151
            val = a_deprecated_list.pop(1)
 
152
            self.assertEqual([expected_warning]*6, self._warnings)
 
153
            self.assertEqual('xxx', val)
 
154
            self.assertEqual(['one', 'bar'], a_deprecated_list)
 
155
        finally:
 
156
            symbol_versioning.set_warning_method(old_warning_method)
 
157
 
 
158
    def test_deprecated_dict(self):
 
159
        expected_warning = (
 
160
            "access to a_deprecated_dict was deprecated in version 0.14."
 
161
            " Pull the other one!", DeprecationWarning, 2)
 
162
        old_warning_method = symbol_versioning.warn
 
163
        try:
 
164
            symbol_versioning.set_warning_method(self.capture_warning)
 
165
            self.assertEqual(len(a_deprecated_dict), 1)
 
166
            self.assertEqual([expected_warning], self._warnings)
 
167
 
 
168
            a_deprecated_dict['b'] = 42
 
169
            self.assertEqual(a_deprecated_dict['b'], 42)
 
170
            self.assertTrue('b' in a_deprecated_dict)
 
171
            del a_deprecated_dict['b']
 
172
            self.assertFalse('b' in a_deprecated_dict)
 
173
            self.assertEqual([expected_warning] * 6, self._warnings)
 
174
        finally:
 
175
            symbol_versioning.set_warning_method(old_warning_method)
 
176
 
75
177
 
76
178
    def check_deprecated_callable(self, expected_warning, expected_docstring,
77
179
                                  expected_name, expected_module,
90
192
            self.assertTrue(deprecated_callable.is_deprecated)
91
193
        finally:
92
194
            symbol_versioning.set_warning_method(old_warning_method)
93
 
    
 
195
 
94
196
    def test_deprecated_passed(self):
95
197
        self.assertEqual(True, symbol_versioning.deprecated_passed(None))
96
198
        self.assertEqual(True, symbol_versioning.deprecated_passed(True))
98
200
        self.assertEqual(False,
99
201
                         symbol_versioning.deprecated_passed(
100
202
                            symbol_versioning.DEPRECATED_PARAMETER))
 
203
 
 
204
    def test_deprecation_string(self):
 
205
        """We can get a deprecation string for a method or function."""
 
206
        self.assertEqual('bzrlib.tests.test_symbol_versioning.'
 
207
            'TestDeprecationWarnings.test_deprecation_string was deprecated in '
 
208
            'version 0.11.',
 
209
            symbol_versioning.deprecation_string(
 
210
            self.test_deprecation_string,
 
211
            deprecated_in((0, 11, 0))))
 
212
        self.assertEqual('bzrlib.symbol_versioning.deprecated_function was '
 
213
            'deprecated in version 0.11.',
 
214
            symbol_versioning.deprecation_string(
 
215
                symbol_versioning.deprecated_function,
 
216
                deprecated_in((0, 11, 0))))
 
217
 
 
218
 
 
219
class TestSuppressAndActivate(TestCase):
 
220
 
 
221
    def setUp(self):
 
222
        TestCase.setUp(self)
 
223
        existing_filters = list(warnings.filters)
 
224
        def restore():
 
225
            warnings.filters[:] = existing_filters
 
226
        self.addCleanup(restore)
 
227
        # Clean out the filters so we have a clean slate.
 
228
        warnings.resetwarnings()
 
229
 
 
230
    def assertFirstWarning(self, action, category):
 
231
        """Test the first warning in the filters is correct"""
 
232
        first = warnings.filters[0]
 
233
        self.assertEqual((action, category), (first[0], first[2]))
 
234
 
 
235
    def test_suppress_deprecation_warnings(self):
 
236
        """suppress_deprecation_warnings sets DeprecationWarning to ignored."""
 
237
        symbol_versioning.suppress_deprecation_warnings()
 
238
        self.assertFirstWarning('ignore', DeprecationWarning)
 
239
 
 
240
    def test_suppress_deprecation_with_warning_filter(self):
 
241
        """don't suppress if we already have a filter"""
 
242
        warnings.filterwarnings('error', category=Warning)
 
243
        self.assertFirstWarning('error', Warning)
 
244
        self.assertEqual(1, len(warnings.filters))
 
245
        symbol_versioning.suppress_deprecation_warnings(override=False)
 
246
        self.assertFirstWarning('error', Warning)
 
247
        self.assertEqual(1, len(warnings.filters))
 
248
 
 
249
    def test_suppress_deprecation_with_filter(self):
 
250
        """don't suppress if we already have a filter"""
 
251
        warnings.filterwarnings('error', category=DeprecationWarning)
 
252
        self.assertFirstWarning('error', DeprecationWarning)
 
253
        self.assertEqual(1, len(warnings.filters))
 
254
        symbol_versioning.suppress_deprecation_warnings(override=False)
 
255
        self.assertFirstWarning('error', DeprecationWarning)
 
256
        self.assertEqual(1, len(warnings.filters))
 
257
        symbol_versioning.suppress_deprecation_warnings(override=True)
 
258
        self.assertFirstWarning('ignore', DeprecationWarning)
 
259
        self.assertEqual(2, len(warnings.filters))
 
260
 
 
261
    def test_activate_deprecation_no_error(self):
 
262
        # First nuke the filters, so we know it is clean
 
263
        symbol_versioning.activate_deprecation_warnings()
 
264
        self.assertFirstWarning('default', DeprecationWarning)
 
265
 
 
266
    def test_activate_deprecation_with_error(self):
 
267
        # First nuke the filters, so we know it is clean
 
268
        # Add a warning == error rule
 
269
        warnings.filterwarnings('error', category=Warning)
 
270
        self.assertFirstWarning('error', Warning)
 
271
        self.assertEqual(1, len(warnings.filters))
 
272
        symbol_versioning.activate_deprecation_warnings(override=False)
 
273
        # There should not be a new warning
 
274
        self.assertFirstWarning('error', Warning)
 
275
        self.assertEqual(1, len(warnings.filters))
 
276
 
 
277
    def test_activate_deprecation_with_DW_error(self):
 
278
        # First nuke the filters, so we know it is clean
 
279
        # Add a warning == error rule
 
280
        warnings.filterwarnings('error', category=DeprecationWarning)
 
281
        self.assertFirstWarning('error', DeprecationWarning)
 
282
        self.assertEqual(1, len(warnings.filters))
 
283
        symbol_versioning.activate_deprecation_warnings(override=False)
 
284
        # There should not be a new warning
 
285
        self.assertFirstWarning('error', DeprecationWarning)
 
286
        self.assertEqual(1, len(warnings.filters))
 
287
        symbol_versioning.activate_deprecation_warnings(override=True)
 
288
        self.assertFirstWarning('default', DeprecationWarning)
 
289
        self.assertEqual(2, len(warnings.filters))