50
61
# add that on top of the primitives, once we have all three written
65
def deprecation_string(a_callable, deprecation_version):
66
"""Generate an automatic deprecation string for a_callable.
68
:param a_callable: The callable to substitute into deprecation_version.
69
:param deprecation_version: A deprecation format warning string. This should
70
have a single %s operator in it. a_callable will be turned into a nice
71
python symbol and then substituted into deprecation_version.
73
# We also want to handle old-style classes, in particular exception, and
74
# they don't have an im_class attribute.
75
if getattr(a_callable, 'im_class', None) is None:
76
symbol = "%s.%s" % (a_callable.__module__,
79
symbol = "%s.%s.%s" % (a_callable.im_class.__module__,
80
a_callable.im_class.__name__,
83
return deprecation_version % symbol
53
86
def deprecated_function(deprecation_version):
54
87
"""Decorate a function so that use of it will trigger a warning."""
56
89
def function_decorator(callable):
57
90
"""This is the function python calls to perform the decoration."""
59
92
def decorated_function(*args, **kwargs):
60
93
"""This is the decorated function."""
61
symbol = "%s.%s" % (callable.__module__,
64
warn(deprecation_version % symbol, DeprecationWarning, stacklevel=2)
94
from bzrlib import trace
95
trace.mutter_callsite(4, "Deprecated function called")
96
warn(deprecation_string(callable, deprecation_version),
97
DeprecationWarning, stacklevel=2)
65
98
return callable(*args, **kwargs)
66
99
_populate_decorated(callable, deprecation_version, "function",
67
100
decorated_function)
72
105
def deprecated_method(deprecation_version):
73
106
"""Decorate a method so that use of it will trigger a warning.
108
To deprecate a static or class method, use
75
114
To deprecate an entire class, decorate __init__.
78
117
def method_decorator(callable):
79
118
"""This is the function python calls to perform the decoration."""
81
120
def decorated_method(self, *args, **kwargs):
82
121
"""This is the decorated method."""
83
symbol = "%s.%s.%s" % (self.__class__.__module__,
84
self.__class__.__name__,
122
from bzrlib import trace
123
if callable.__name__ == '__init__':
124
symbol = "%s.%s" % (self.__class__.__module__,
125
self.__class__.__name__,
128
symbol = "%s.%s.%s" % (self.__class__.__module__,
129
self.__class__.__name__,
132
trace.mutter_callsite(4, "Deprecated method called")
87
133
warn(deprecation_version % symbol, DeprecationWarning, stacklevel=2)
88
134
return callable(self, *args, **kwargs)
89
135
_populate_decorated(callable, deprecation_version, "method",
140
189
decorated_callable.__module__ = callable.__module__
141
190
decorated_callable.__name__ = callable.__name__
142
191
decorated_callable.is_deprecated = True
194
def _dict_deprecation_wrapper(wrapped_method):
195
"""Returns a closure that emits a warning and calls the superclass"""
196
def cb(dep_dict, *args, **kwargs):
197
msg = 'access to %s' % (dep_dict._variable_name, )
198
msg = dep_dict._deprecation_version % (msg,)
200
msg += ' ' + dep_dict._advice
201
warn(msg, DeprecationWarning, stacklevel=2)
202
return wrapped_method(dep_dict, *args, **kwargs)
206
class DeprecatedDict(dict):
207
"""A dictionary that complains when read or written."""
217
"""Create a dict that warns when read or modified.
219
:param deprecation_version: string for the warning format to raise,
220
typically from deprecated_in()
221
:param initial_value: The contents of the dict
222
:param variable_name: This allows better warnings to be printed
223
:param advice: String of advice on what callers should do instead
224
of using this variable.
226
self._deprecation_version = deprecation_version
227
self._variable_name = variable_name
228
self._advice = advice
229
dict.__init__(self, initial_value)
231
# This isn't every possible method but it should trap anyone using the
232
# dict -- add more if desired
233
__len__ = _dict_deprecation_wrapper(dict.__len__)
234
__getitem__ = _dict_deprecation_wrapper(dict.__getitem__)
235
__setitem__ = _dict_deprecation_wrapper(dict.__setitem__)
236
__delitem__ = _dict_deprecation_wrapper(dict.__delitem__)
237
keys = _dict_deprecation_wrapper(dict.keys)
238
__contains__ = _dict_deprecation_wrapper(dict.__contains__)
241
def deprecated_list(deprecation_version, variable_name,
242
initial_value, extra=None):
243
"""Create a list that warns when modified
245
:param deprecation_version: string for the warning format to raise,
246
typically from deprecated_in()
247
:param initial_value: The contents of the list
248
:param variable_name: This allows better warnings to be printed
249
:param extra: Extra info to print when printing a warning
252
subst_text = 'Modifying %s' % (variable_name,)
253
msg = deprecation_version % (subst_text,)
257
class _DeprecatedList(list):
258
__doc__ = list.__doc__ + msg
262
def _warn_deprecated(self, func, *args, **kwargs):
263
warn(msg, DeprecationWarning, stacklevel=3)
264
return func(self, *args, **kwargs)
266
def append(self, obj):
267
"""appending to %s is deprecated""" % (variable_name,)
268
return self._warn_deprecated(list.append, obj)
270
def insert(self, index, obj):
271
"""inserting to %s is deprecated""" % (variable_name,)
272
return self._warn_deprecated(list.insert, index, obj)
274
def extend(self, iterable):
275
"""extending %s is deprecated""" % (variable_name,)
276
return self._warn_deprecated(list.extend, iterable)
278
def remove(self, value):
279
"""removing from %s is deprecated""" % (variable_name,)
280
return self._warn_deprecated(list.remove, value)
282
def pop(self, index=None):
283
"""pop'ing from %s is deprecated""" % (variable_name,)
285
return self._warn_deprecated(list.pop, index)
288
return self._warn_deprecated(list.pop)
290
return _DeprecatedList(initial_value)
293
def _check_for_filter(error_only):
294
"""Check if there is already a filter for deprecation warnings.
296
:param error_only: Only match an 'error' filter
297
:return: True if a filter is found, False otherwise
300
for filter in warnings.filters:
301
if issubclass(DeprecationWarning, filter[2]):
302
# This filter will effect DeprecationWarning
303
if not error_only or filter[0] == 'error':
308
def suppress_deprecation_warnings(override=True):
309
"""Call this function to suppress all deprecation warnings.
311
When this is a final release version, we don't want to annoy users with
312
lots of deprecation warnings. We only want the deprecation warnings when
313
running a dev or release candidate.
315
:param override: If True, always set the ignore, if False, only set the
316
ignore if there isn't already a filter.
319
if not override and _check_for_filter(error_only=False):
320
# If there is already a filter effecting suppress_deprecation_warnings,
323
warnings.filterwarnings('ignore', category=DeprecationWarning)
326
def activate_deprecation_warnings(override=True):
327
"""Call this function to activate deprecation warnings.
329
When running in a 'final' release we suppress deprecation warnings.
330
However, the test suite wants to see them. So when running selftest, we
331
re-enable the deprecation warnings.
333
Note: warnings that have already been issued under 'ignore' will not be
334
reported after this point. The 'warnings' module has already marked them as
335
handled, so they don't get issued again.
337
:param override: If False, only add a filter if there isn't an error filter
338
already. (This slightly differs from suppress_deprecation_warnings, in
339
because it always overrides everything but -Werror).
342
if not override and _check_for_filter(error_only=True):
343
# DeprecationWarnings are already turned into errors, don't downgrade
346
warnings.filterwarnings('default', category=DeprecationWarning)
added
removed
bzrlib/symbol_versioning.py
