~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_log.py

  • Committer: Ian Clatworthy
  • Date: 2009-09-09 11:43:10 UTC
  • mto: (4634.37.2 prepare-2.0)
  • mto: This revision was merged to the branch mainline in revision 4689.
  • Revision ID: ian.clatworthy@canonical.com-20090909114310-glw7tv76i5gnx9pt
put rules back in Makefile supporting plain-style docs

Show diffs side-by-side

added added

removed removed

Lines of Context:
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
17
import os
18
18
from cStringIO import StringIO
19
19
 
20
 
from bzrlib import log
21
 
from bzrlib.tests import TestCase, TestCaseWithTransport
22
 
from bzrlib.log import (show_log,
23
 
                        get_view_revisions,
24
 
                        LogRevision,
25
 
                        LogFormatter,
26
 
                        LongLogFormatter,
27
 
                        ShortLogFormatter,
28
 
                        LineLogFormatter)
29
 
from bzrlib.branch import Branch
30
 
from bzrlib.errors import InvalidRevisionNumber
31
 
from bzrlib.revision import Revision
32
 
 
33
 
 
34
 
class LogCatcher(LogFormatter):
35
 
    """Pull log messages into list rather than displaying them.
36
 
 
37
 
    For ease of testing we save log messages here rather than actually
38
 
    formatting them, so that we can precisely check the result without
39
 
    being too dependent on the exact formatting.
40
 
 
41
 
    We should also test the LogFormatter.
 
20
from bzrlib import (
 
21
    errors,
 
22
    log,
 
23
    registry,
 
24
    revision,
 
25
    revisionspec,
 
26
    tests,
 
27
    )
 
28
 
 
29
 
 
30
class TestCaseWithoutPropsHandler(tests.TestCaseWithTransport):
 
31
 
 
32
    def setUp(self):
 
33
        super(TestCaseWithoutPropsHandler, self).setUp()
 
34
        # keep a reference to the "current" custom prop. handler registry
 
35
        self.properties_handler_registry = log.properties_handler_registry
 
36
        # Use a clean registry for log
 
37
        log.properties_handler_registry = registry.Registry()
 
38
 
 
39
        def restore():
 
40
            log.properties_handler_registry = self.properties_handler_registry
 
41
        self.addCleanup(restore)
 
42
 
 
43
 
 
44
class LogCatcher(log.LogFormatter):
 
45
    """Pull log messages into a list rather than displaying them.
 
46
 
 
47
    To simplify testing we save logged revisions here rather than actually
 
48
    formatting anything, so that we can precisely check the result without
 
49
    being dependent on the formatting.
42
50
    """
43
51
 
44
52
    supports_delta = True
45
53
 
46
54
    def __init__(self):
47
55
        super(LogCatcher, self).__init__(to_file=None)
48
 
        self.logs = []
 
56
        self.revisions = []
49
57
 
50
58
    def log_revision(self, revision):
51
 
        self.logs.append(revision)
52
 
 
53
 
 
54
 
class TestShowLog(TestCaseWithTransport):
 
59
        self.revisions.append(revision)
 
60
 
 
61
 
 
62
class TestShowLog(tests.TestCaseWithTransport):
55
63
 
56
64
    def checkDelta(self, delta, **kw):
57
 
        """Check the filenames touched by a delta are as expected."""
 
65
        """Check the filenames touched by a delta are as expected.
 
66
 
 
67
        Caller only have to pass in the list of files for each part, all
 
68
        unspecified parts are considered empty (and checked as such).
 
69
        """
58
70
        for n in 'added', 'removed', 'renamed', 'modified', 'unchanged':
 
71
            # By default we expect an empty list
59
72
            expected = kw.get(n, [])
60
73
            # strip out only the path components
61
74
            got = [x[0] for x in getattr(delta, n)]
62
 
            self.assertEquals(expected, got)
 
75
            self.assertEqual(expected, got)
 
76
 
 
77
    def assertInvalidRevisonNumber(self, br, start, end):
 
78
        lf = LogCatcher()
 
79
        self.assertRaises(errors.InvalidRevisionNumber,
 
80
                          log.show_log, br, lf,
 
81
                          start_revision=start, end_revision=end)
63
82
 
64
83
    def test_cur_revno(self):
65
84
        wt = self.make_branch_and_tree('.')
67
86
 
68
87
        lf = LogCatcher()
69
88
        wt.commit('empty commit')
70
 
        show_log(b, lf, verbose=True, start_revision=1, end_revision=1)
71
 
        self.assertRaises(InvalidRevisionNumber, show_log, b, lf,
72
 
                          start_revision=2, end_revision=1) 
73
 
        self.assertRaises(InvalidRevisionNumber, show_log, b, lf,
74
 
                          start_revision=1, end_revision=2) 
75
 
        self.assertRaises(InvalidRevisionNumber, show_log, b, lf,
76
 
                          start_revision=0, end_revision=2) 
77
 
        self.assertRaises(InvalidRevisionNumber, show_log, b, lf,
78
 
                          start_revision=1, end_revision=0) 
79
 
        self.assertRaises(InvalidRevisionNumber, show_log, b, lf,
80
 
                          start_revision=-1, end_revision=1) 
81
 
        self.assertRaises(InvalidRevisionNumber, show_log, b, lf,
82
 
                          start_revision=1, end_revision=-1) 
83
 
 
84
 
    def test_simple_log(self):
85
 
        eq = self.assertEquals
86
 
        
 
89
        log.show_log(b, lf, verbose=True, start_revision=1, end_revision=1)
 
90
 
 
91
        # Since there is a single revision in the branch all the combinations
 
92
        # below should fail.
 
93
        self.assertInvalidRevisonNumber(b, 2, 1)
 
94
        self.assertInvalidRevisonNumber(b, 1, 2)
 
95
        self.assertInvalidRevisonNumber(b, 0, 2)
 
96
        self.assertInvalidRevisonNumber(b, 1, 0)
 
97
        self.assertInvalidRevisonNumber(b, -1, 1)
 
98
        self.assertInvalidRevisonNumber(b, 1, -1)
 
99
 
 
100
    def test_empty_branch(self):
87
101
        wt = self.make_branch_and_tree('.')
88
 
        b = wt.branch
89
102
 
90
103
        lf = LogCatcher()
91
 
        show_log(b, lf)
 
104
        log.show_log(wt.branch, lf)
92
105
        # no entries yet
93
 
        eq(lf.logs, [])
 
106
        self.assertEqual([], lf.revisions)
 
107
 
 
108
    def test_empty_commit(self):
 
109
        wt = self.make_branch_and_tree('.')
94
110
 
95
111
        wt.commit('empty commit')
96
112
        lf = LogCatcher()
97
 
        show_log(b, lf, verbose=True)
98
 
        eq(len(lf.logs), 1)
99
 
        eq(lf.logs[0].revno, '1')
100
 
        eq(lf.logs[0].rev.message, 'empty commit')
101
 
        d = lf.logs[0].delta
102
 
        self.log('log delta: %r' % d)
103
 
        self.checkDelta(d)
 
113
        log.show_log(wt.branch, lf, verbose=True)
 
114
        revs = lf.revisions
 
115
        self.assertEqual(1, len(revs))
 
116
        self.assertEqual('1', revs[0].revno)
 
117
        self.assertEqual('empty commit', revs[0].rev.message)
 
118
        self.checkDelta(revs[0].delta)
104
119
 
 
120
    def test_simple_commit(self):
 
121
        wt = self.make_branch_and_tree('.')
 
122
        wt.commit('empty commit')
105
123
        self.build_tree(['hello'])
106
124
        wt.add('hello')
107
125
        wt.commit('add one file',
108
126
                  committer=u'\u013d\xf3r\xe9m \xcdp\u0161\xfam '
109
127
                            u'<test@example.com>')
110
 
 
111
 
        lf = self.make_utf8_encoded_stringio()
112
 
        # log using regular thing
113
 
        show_log(b, LongLogFormatter(lf))
114
 
        lf.seek(0)
115
 
        for l in lf.readlines():
116
 
            self.log(l)
117
 
 
118
 
        # get log as data structure
119
128
        lf = LogCatcher()
120
 
        show_log(b, lf, verbose=True)
121
 
        eq(len(lf.logs), 2)
122
 
        self.log('log entries:')
123
 
        for logentry in lf.logs:
124
 
            self.log('%4s %s' % (logentry.revno, logentry.rev.message))
125
 
        
 
129
        log.show_log(wt.branch, lf, verbose=True)
 
130
        self.assertEqual(2, len(lf.revisions))
126
131
        # first one is most recent
127
 
        logentry = lf.logs[0]
128
 
        eq(logentry.revno, '2')
129
 
        eq(logentry.rev.message, 'add one file')
130
 
        d = logentry.delta
131
 
        self.log('log 2 delta: %r' % d)
132
 
        self.checkDelta(d, added=['hello'])
133
 
        
134
 
        # commit a log message with control characters
135
 
        msg = "All 8-bit chars: " +  ''.join([unichr(x) for x in range(256)])
136
 
        self.log("original commit message: %r", msg)
 
132
        log_entry = lf.revisions[0]
 
133
        self.assertEqual('2', log_entry.revno)
 
134
        self.assertEqual('add one file', log_entry.rev.message)
 
135
        self.checkDelta(log_entry.delta, added=['hello'])
 
136
 
 
137
    def test_commit_message_with_control_chars(self):
 
138
        wt = self.make_branch_and_tree('.')
 
139
        msg = u"All 8-bit chars: " +  ''.join([unichr(x) for x in range(256)])
 
140
        msg = msg.replace(u'\r', u'\n')
137
141
        wt.commit(msg)
138
142
        lf = LogCatcher()
139
 
        show_log(b, lf, verbose=True)
140
 
        committed_msg = lf.logs[0].rev.message
141
 
        self.log("escaped commit message: %r", committed_msg)
142
 
        self.assert_(msg != committed_msg)
143
 
        self.assert_(len(committed_msg) > len(msg))
 
143
        log.show_log(wt.branch, lf, verbose=True)
 
144
        committed_msg = lf.revisions[0].rev.message
 
145
        if wt.branch.repository._serializer.squashes_xml_invalid_characters:
 
146
            self.assertNotEqual(msg, committed_msg)
 
147
            self.assertTrue(len(committed_msg) > len(msg))
 
148
        else:
 
149
            self.assertEqual(msg, committed_msg)
144
150
 
145
 
        # Check that log message with only XML-valid characters isn't
 
151
    def test_commit_message_without_control_chars(self):
 
152
        wt = self.make_branch_and_tree('.')
146
153
        # escaped.  As ElementTree apparently does some kind of
147
154
        # newline conversion, neither LF (\x0A) nor CR (\x0D) are
148
155
        # included in the test commit message, even though they are
149
156
        # valid XML 1.0 characters.
150
157
        msg = "\x09" + ''.join([unichr(x) for x in range(0x20, 256)])
151
 
        self.log("original commit message: %r", msg)
152
158
        wt.commit(msg)
153
159
        lf = LogCatcher()
154
 
        show_log(b, lf, verbose=True)
155
 
        committed_msg = lf.logs[0].rev.message
156
 
        self.log("escaped commit message: %r", committed_msg)
157
 
        self.assert_(msg == committed_msg)
 
160
        log.show_log(wt.branch, lf, verbose=True)
 
161
        committed_msg = lf.revisions[0].rev.message
 
162
        self.assertEqual(msg, committed_msg)
158
163
 
159
164
    def test_deltas_in_merge_revisions(self):
160
165
        """Check deltas created for both mainline and merge revisions"""
161
 
        eq = self.assertEquals
162
166
        wt = self.make_branch_and_tree('parent')
163
167
        self.build_tree(['parent/file1', 'parent/file2', 'parent/file3'])
164
168
        wt.add('file1')
166
170
        wt.commit(message='add file1 and file2')
167
171
        self.run_bzr('branch parent child')
168
172
        os.unlink('child/file1')
169
 
        print >> file('child/file2', 'wb'), 'hello'
 
173
        file('child/file2', 'wb').write('hello\n')
170
174
        self.run_bzr(['commit', '-m', 'remove file1 and modify file2',
171
175
            'child'])
172
176
        os.chdir('parent')
176
180
        b = wt.branch
177
181
        lf = LogCatcher()
178
182
        lf.supports_merge_revisions = True
179
 
        show_log(b, lf, verbose=True)
180
 
        eq(len(lf.logs),3)
181
 
        logentry = lf.logs[0]
182
 
        eq(logentry.revno, '2')
183
 
        eq(logentry.rev.message, 'merge child branch')
184
 
        d = logentry.delta
185
 
        self.checkDelta(d, removed=['file1'], modified=['file2'])
186
 
        logentry = lf.logs[1]
187
 
        eq(logentry.revno, '1.1.1')
188
 
        eq(logentry.rev.message, 'remove file1 and modify file2')
189
 
        d = logentry.delta
190
 
        self.checkDelta(d, removed=['file1'], modified=['file2'])
191
 
        logentry = lf.logs[2]
192
 
        eq(logentry.revno, '1')
193
 
        eq(logentry.rev.message, 'add file1 and file2')
194
 
        d = logentry.delta
195
 
        self.checkDelta(d, added=['file1', 'file2'])
 
183
        log.show_log(b, lf, verbose=True)
 
184
 
 
185
        revs = lf.revisions
 
186
        self.assertEqual(3, len(revs))
 
187
 
 
188
        logentry = revs[0]
 
189
        self.assertEqual('2', logentry.revno)
 
190
        self.assertEqual('merge child branch', logentry.rev.message)
 
191
        self.checkDelta(logentry.delta, removed=['file1'], modified=['file2'])
 
192
 
 
193
        logentry = revs[1]
 
194
        self.assertEqual('1.1.1', logentry.revno)
 
195
        self.assertEqual('remove file1 and modify file2', logentry.rev.message)
 
196
        self.checkDelta(logentry.delta, removed=['file1'], modified=['file2'])
 
197
 
 
198
        logentry = revs[2]
 
199
        self.assertEqual('1', logentry.revno)
 
200
        self.assertEqual('add file1 and file2', logentry.rev.message)
 
201
        self.checkDelta(logentry.delta, added=['file1', 'file2'])
196
202
 
197
203
 
198
204
def make_commits_with_trailing_newlines(wt):
199
 
    """Helper method for LogFormatter tests"""    
 
205
    """Helper method for LogFormatter tests"""
200
206
    b = wt.branch
201
207
    b.nick='test'
202
208
    open('a', 'wb').write('hello moto\n')
209
215
    wt.commit('multiline\nlog\nmessage\n', rev_id='a2',
210
216
              timestamp=1132586842.411175966, timezone=-6*3600,
211
217
              committer='Joe Foo <joe@foo.com>',
212
 
              author='Joe Bar <joe@bar.com>')
 
218
              authors=['Joe Bar <joe@bar.com>'])
213
219
 
214
220
    open('c', 'wb').write('just another manic monday\n')
215
221
    wt.add('c')
219
225
    return b
220
226
 
221
227
 
222
 
class TestShortLogFormatter(TestCaseWithTransport):
 
228
def normalize_log(log):
 
229
    """Replaces the variable lines of logs with fixed lines"""
 
230
    author = 'author: Dolor Sit <test@example.com>'
 
231
    committer = 'committer: Lorem Ipsum <test@example.com>'
 
232
    lines = log.splitlines(True)
 
233
    for idx,line in enumerate(lines):
 
234
        stripped_line = line.lstrip()
 
235
        indent = ' ' * (len(line) - len(stripped_line))
 
236
        if stripped_line.startswith('author:'):
 
237
            lines[idx] = indent + author + '\n'
 
238
        elif stripped_line.startswith('committer:'):
 
239
            lines[idx] = indent + committer + '\n'
 
240
        elif stripped_line.startswith('timestamp:'):
 
241
            lines[idx] = indent + 'timestamp: Just now\n'
 
242
    return ''.join(lines)
 
243
 
 
244
 
 
245
class TestShortLogFormatter(tests.TestCaseWithTransport):
223
246
 
224
247
    def test_trailing_newlines(self):
225
248
        wt = self.make_branch_and_tree('.')
226
249
        b = make_commits_with_trailing_newlines(wt)
227
250
        sio = self.make_utf8_encoded_stringio()
228
 
        lf = ShortLogFormatter(to_file=sio)
229
 
        show_log(b, lf)
230
 
        self.assertEquals(sio.getvalue(), """\
 
251
        lf = log.ShortLogFormatter(to_file=sio)
 
252
        log.show_log(b, lf)
 
253
        self.assertEqualDiff("""\
231
254
    3 Joe Foo\t2005-11-21
232
255
      single line with trailing newline
233
256
 
239
262
    1 Joe Foo\t2005-11-21
240
263
      simple log message
241
264
 
242
 
""")
243
 
 
244
 
 
245
 
class TestLongLogFormatter(TestCaseWithTransport):
246
 
 
247
 
    def normalize_log(self,log):
248
 
        """Replaces the variable lines of logs with fixed lines"""
249
 
        author = 'author: Dolor Sit <test@example.com>'
250
 
        committer = 'committer: Lorem Ipsum <test@example.com>'
251
 
        lines = log.splitlines(True)
252
 
        for idx,line in enumerate(lines):
253
 
            stripped_line = line.lstrip()
254
 
            indent = ' ' * (len(line) - len(stripped_line))
255
 
            if stripped_line.startswith('author:'):
256
 
                lines[idx] = indent + author + '\n'
257
 
            elif stripped_line.startswith('committer:'):
258
 
                lines[idx] = indent + committer + '\n'
259
 
            elif stripped_line.startswith('timestamp:'):
260
 
                lines[idx] = indent + 'timestamp: Just now\n'
261
 
        return ''.join(lines)
 
265
""",
 
266
                             sio.getvalue())
 
267
 
 
268
    def _prepare_tree_with_merges(self, with_tags=False):
 
269
        wt = self.make_branch_and_memory_tree('.')
 
270
        wt.lock_write()
 
271
        self.addCleanup(wt.unlock)
 
272
        wt.add('')
 
273
        wt.commit('rev-1', rev_id='rev-1',
 
274
                  timestamp=1132586655, timezone=36000,
 
275
                  committer='Joe Foo <joe@foo.com>')
 
276
        wt.commit('rev-merged', rev_id='rev-2a',
 
277
                  timestamp=1132586700, timezone=36000,
 
278
                  committer='Joe Foo <joe@foo.com>')
 
279
        wt.set_parent_ids(['rev-1', 'rev-2a'])
 
280
        wt.branch.set_last_revision_info(1, 'rev-1')
 
281
        wt.commit('rev-2', rev_id='rev-2b',
 
282
                  timestamp=1132586800, timezone=36000,
 
283
                  committer='Joe Foo <joe@foo.com>')
 
284
        if with_tags:
 
285
            branch = wt.branch
 
286
            branch.tags.set_tag('v0.2', 'rev-2b')
 
287
            wt.commit('rev-3', rev_id='rev-3',
 
288
                      timestamp=1132586900, timezone=36000,
 
289
                      committer='Jane Foo <jane@foo.com>')
 
290
            branch.tags.set_tag('v1.0rc1', 'rev-3')
 
291
            branch.tags.set_tag('v1.0', 'rev-3')
 
292
        return wt
 
293
 
 
294
    def test_short_log_with_merges(self):
 
295
        wt = self._prepare_tree_with_merges()
 
296
        logfile = self.make_utf8_encoded_stringio()
 
297
        formatter = log.ShortLogFormatter(to_file=logfile)
 
298
        log.show_log(wt.branch, formatter)
 
299
        self.assertEqualDiff("""\
 
300
    2 Joe Foo\t2005-11-22 [merge]
 
301
      rev-2
 
302
 
 
303
    1 Joe Foo\t2005-11-22
 
304
      rev-1
 
305
 
 
306
""",
 
307
                             logfile.getvalue())
 
308
 
 
309
    def test_short_log_with_merges_and_advice(self):
 
310
        wt = self._prepare_tree_with_merges()
 
311
        logfile = self.make_utf8_encoded_stringio()
 
312
        formatter = log.ShortLogFormatter(to_file=logfile,
 
313
            show_advice=True)
 
314
        log.show_log(wt.branch, formatter)
 
315
        self.assertEqualDiff("""\
 
316
    2 Joe Foo\t2005-11-22 [merge]
 
317
      rev-2
 
318
 
 
319
    1 Joe Foo\t2005-11-22
 
320
      rev-1
 
321
 
 
322
Use --include-merges or -n0 to see merged revisions.
 
323
""",
 
324
                             logfile.getvalue())
 
325
 
 
326
    def test_short_log_with_merges_and_range(self):
 
327
        wt = self.make_branch_and_memory_tree('.')
 
328
        wt.lock_write()
 
329
        self.addCleanup(wt.unlock)
 
330
        wt.add('')
 
331
        wt.commit('rev-1', rev_id='rev-1',
 
332
                  timestamp=1132586655, timezone=36000,
 
333
                  committer='Joe Foo <joe@foo.com>')
 
334
        wt.commit('rev-merged', rev_id='rev-2a',
 
335
                  timestamp=1132586700, timezone=36000,
 
336
                  committer='Joe Foo <joe@foo.com>')
 
337
        wt.branch.set_last_revision_info(1, 'rev-1')
 
338
        wt.set_parent_ids(['rev-1', 'rev-2a'])
 
339
        wt.commit('rev-2b', rev_id='rev-2b',
 
340
                  timestamp=1132586800, timezone=36000,
 
341
                  committer='Joe Foo <joe@foo.com>')
 
342
        wt.commit('rev-3a', rev_id='rev-3a',
 
343
                  timestamp=1132586800, timezone=36000,
 
344
                  committer='Joe Foo <joe@foo.com>')
 
345
        wt.branch.set_last_revision_info(2, 'rev-2b')
 
346
        wt.set_parent_ids(['rev-2b', 'rev-3a'])
 
347
        wt.commit('rev-3b', rev_id='rev-3b',
 
348
                  timestamp=1132586800, timezone=36000,
 
349
                  committer='Joe Foo <joe@foo.com>')
 
350
        logfile = self.make_utf8_encoded_stringio()
 
351
        formatter = log.ShortLogFormatter(to_file=logfile)
 
352
        log.show_log(wt.branch, formatter,
 
353
            start_revision=2, end_revision=3)
 
354
        self.assertEqualDiff("""\
 
355
    3 Joe Foo\t2005-11-22 [merge]
 
356
      rev-3b
 
357
 
 
358
    2 Joe Foo\t2005-11-22 [merge]
 
359
      rev-2b
 
360
 
 
361
""",
 
362
                             logfile.getvalue())
 
363
 
 
364
    def test_short_log_with_tags(self):
 
365
        wt = self._prepare_tree_with_merges(with_tags=True)
 
366
        logfile = self.make_utf8_encoded_stringio()
 
367
        formatter = log.ShortLogFormatter(to_file=logfile)
 
368
        log.show_log(wt.branch, formatter)
 
369
        self.assertEqualDiff("""\
 
370
    3 Jane Foo\t2005-11-22 {v1.0, v1.0rc1}
 
371
      rev-3
 
372
 
 
373
    2 Joe Foo\t2005-11-22 {v0.2} [merge]
 
374
      rev-2
 
375
 
 
376
    1 Joe Foo\t2005-11-22
 
377
      rev-1
 
378
 
 
379
""",
 
380
                             logfile.getvalue())
 
381
 
 
382
    def test_short_log_single_merge_revision(self):
 
383
        wt = self.make_branch_and_memory_tree('.')
 
384
        wt.lock_write()
 
385
        self.addCleanup(wt.unlock)
 
386
        wt.add('')
 
387
        wt.commit('rev-1', rev_id='rev-1',
 
388
                  timestamp=1132586655, timezone=36000,
 
389
                  committer='Joe Foo <joe@foo.com>')
 
390
        wt.commit('rev-merged', rev_id='rev-2a',
 
391
                  timestamp=1132586700, timezone=36000,
 
392
                  committer='Joe Foo <joe@foo.com>')
 
393
        wt.set_parent_ids(['rev-1', 'rev-2a'])
 
394
        wt.branch.set_last_revision_info(1, 'rev-1')
 
395
        wt.commit('rev-2', rev_id='rev-2b',
 
396
                  timestamp=1132586800, timezone=36000,
 
397
                  committer='Joe Foo <joe@foo.com>')
 
398
        logfile = self.make_utf8_encoded_stringio()
 
399
        formatter = log.ShortLogFormatter(to_file=logfile)
 
400
        revspec = revisionspec.RevisionSpec.from_string('1.1.1')
 
401
        wtb = wt.branch
 
402
        rev = revspec.in_history(wtb)
 
403
        log.show_log(wtb, formatter, start_revision=rev, end_revision=rev)
 
404
        self.assertEqualDiff("""\
 
405
      1.1.1 Joe Foo\t2005-11-22
 
406
            rev-merged
 
407
 
 
408
""",
 
409
                             logfile.getvalue())
 
410
 
 
411
 
 
412
class TestShortLogFormatterWithMergeRevisions(tests.TestCaseWithTransport):
 
413
 
 
414
    def test_short_merge_revs_log_with_merges(self):
 
415
        wt = self.make_branch_and_memory_tree('.')
 
416
        wt.lock_write()
 
417
        self.addCleanup(wt.unlock)
 
418
        wt.add('')
 
419
        wt.commit('rev-1', rev_id='rev-1',
 
420
                  timestamp=1132586655, timezone=36000,
 
421
                  committer='Joe Foo <joe@foo.com>')
 
422
        wt.commit('rev-merged', rev_id='rev-2a',
 
423
                  timestamp=1132586700, timezone=36000,
 
424
                  committer='Joe Foo <joe@foo.com>')
 
425
        wt.set_parent_ids(['rev-1', 'rev-2a'])
 
426
        wt.branch.set_last_revision_info(1, 'rev-1')
 
427
        wt.commit('rev-2', rev_id='rev-2b',
 
428
                  timestamp=1132586800, timezone=36000,
 
429
                  committer='Joe Foo <joe@foo.com>')
 
430
        logfile = self.make_utf8_encoded_stringio()
 
431
        formatter = log.ShortLogFormatter(to_file=logfile, levels=0)
 
432
        log.show_log(wt.branch, formatter)
 
433
        # Note that the 1.1.1 indenting is in fact correct given that
 
434
        # the revision numbers are right justified within 5 characters
 
435
        # for mainline revnos and 9 characters for dotted revnos.
 
436
        self.assertEqualDiff("""\
 
437
    2 Joe Foo\t2005-11-22 [merge]
 
438
      rev-2
 
439
 
 
440
          1.1.1 Joe Foo\t2005-11-22
 
441
                rev-merged
 
442
 
 
443
    1 Joe Foo\t2005-11-22
 
444
      rev-1
 
445
 
 
446
""",
 
447
                             logfile.getvalue())
 
448
 
 
449
    def test_short_merge_revs_log_single_merge_revision(self):
 
450
        wt = self.make_branch_and_memory_tree('.')
 
451
        wt.lock_write()
 
452
        self.addCleanup(wt.unlock)
 
453
        wt.add('')
 
454
        wt.commit('rev-1', rev_id='rev-1',
 
455
                  timestamp=1132586655, timezone=36000,
 
456
                  committer='Joe Foo <joe@foo.com>')
 
457
        wt.commit('rev-merged', rev_id='rev-2a',
 
458
                  timestamp=1132586700, timezone=36000,
 
459
                  committer='Joe Foo <joe@foo.com>')
 
460
        wt.set_parent_ids(['rev-1', 'rev-2a'])
 
461
        wt.branch.set_last_revision_info(1, 'rev-1')
 
462
        wt.commit('rev-2', rev_id='rev-2b',
 
463
                  timestamp=1132586800, timezone=36000,
 
464
                  committer='Joe Foo <joe@foo.com>')
 
465
        logfile = self.make_utf8_encoded_stringio()
 
466
        formatter = log.ShortLogFormatter(to_file=logfile, levels=0)
 
467
        revspec = revisionspec.RevisionSpec.from_string('1.1.1')
 
468
        wtb = wt.branch
 
469
        rev = revspec.in_history(wtb)
 
470
        log.show_log(wtb, formatter, start_revision=rev, end_revision=rev)
 
471
        self.assertEqualDiff("""\
 
472
      1.1.1 Joe Foo\t2005-11-22
 
473
            rev-merged
 
474
 
 
475
""",
 
476
                             logfile.getvalue())
 
477
 
 
478
 
 
479
class TestLongLogFormatter(TestCaseWithoutPropsHandler):
262
480
 
263
481
    def test_verbose_log(self):
264
482
        """Verbose log includes changed files
265
 
        
 
483
 
266
484
        bug #4676
267
485
        """
268
486
        wt = self.make_branch_and_tree('.')
271
489
        wt.add('a')
272
490
        # XXX: why does a longer nick show up?
273
491
        b.nick = 'test_verbose_log'
274
 
        wt.commit(message='add a', 
275
 
                  timestamp=1132711707, 
 
492
        wt.commit(message='add a',
 
493
                  timestamp=1132711707,
276
494
                  timezone=36000,
277
495
                  committer='Lorem Ipsum <test@example.com>')
278
496
        logfile = file('out.tmp', 'w+')
279
 
        formatter = LongLogFormatter(to_file=logfile)
280
 
        show_log(b, formatter, verbose=True)
 
497
        formatter = log.LongLogFormatter(to_file=logfile)
 
498
        log.show_log(b, formatter, verbose=True)
281
499
        logfile.flush()
282
500
        logfile.seek(0)
283
501
        log_contents = logfile.read()
284
 
        self.assertEqualDiff(log_contents, '''\
 
502
        self.assertEqualDiff('''\
285
503
------------------------------------------------------------
286
504
revno: 1
287
505
committer: Lorem Ipsum <test@example.com>
291
509
  add a
292
510
added:
293
511
  a
294
 
''')
 
512
''',
 
513
                             log_contents)
295
514
 
296
515
    def test_merges_are_indented_by_level(self):
297
516
        wt = self.make_branch_and_tree('parent')
309
528
        wt.commit('merge branch 1')
310
529
        b = wt.branch
311
530
        sio = self.make_utf8_encoded_stringio()
312
 
        lf = LongLogFormatter(to_file=sio)
313
 
        show_log(b, lf, verbose=True)
314
 
        log = self.normalize_log(sio.getvalue())
 
531
        lf = log.LongLogFormatter(to_file=sio, levels=0)
 
532
        log.show_log(b, lf, verbose=True)
 
533
        the_log = normalize_log(sio.getvalue())
315
534
        self.assertEqualDiff("""\
316
535
------------------------------------------------------------
317
 
revno: 2
 
536
revno: 2 [merge]
318
537
committer: Lorem Ipsum <test@example.com>
319
538
branch nick: parent
320
539
timestamp: Just now
321
540
message:
322
541
  merge branch 1
323
542
    ------------------------------------------------------------
324
 
    revno: 1.1.2
 
543
    revno: 1.1.2 [merge]
325
544
    committer: Lorem Ipsum <test@example.com>
326
545
    branch nick: child
327
546
    timestamp: Just now
328
547
    message:
329
548
      merge branch 2
330
549
        ------------------------------------------------------------
331
 
        revno: 1.1.1.1.1
 
550
        revno: 1.2.1
332
551
        committer: Lorem Ipsum <test@example.com>
333
552
        branch nick: smallerchild
334
553
        timestamp: Just now
348
567
timestamp: Just now
349
568
message:
350
569
  first post
351
 
""", log)
 
570
""",
 
571
                             the_log)
352
572
 
353
573
    def test_verbose_merge_revisions_contain_deltas(self):
354
574
        wt = self.make_branch_and_tree('parent')
357
577
        wt.commit('first post')
358
578
        self.run_bzr('branch parent child')
359
579
        os.unlink('child/f1')
360
 
        print >> file('child/f2', 'wb'), 'hello'
 
580
        file('child/f2', 'wb').write('hello\n')
361
581
        self.run_bzr(['commit', '-m', 'removed f1 and modified f2',
362
582
            'child'])
363
583
        os.chdir('parent')
365
585
        wt.commit('merge branch 1')
366
586
        b = wt.branch
367
587
        sio = self.make_utf8_encoded_stringio()
368
 
        lf = LongLogFormatter(to_file=sio)
369
 
        show_log(b, lf, verbose=True)
370
 
        log = self.normalize_log(sio.getvalue())
 
588
        lf = log.LongLogFormatter(to_file=sio, levels=0)
 
589
        log.show_log(b, lf, verbose=True)
 
590
        the_log = normalize_log(sio.getvalue())
371
591
        self.assertEqualDiff("""\
372
592
------------------------------------------------------------
373
 
revno: 2
 
593
revno: 2 [merge]
374
594
committer: Lorem Ipsum <test@example.com>
375
595
branch nick: parent
376
596
timestamp: Just now
401
621
added:
402
622
  f1
403
623
  f2
404
 
""", log)
 
624
""",
 
625
                             the_log)
405
626
 
406
627
    def test_trailing_newlines(self):
407
628
        wt = self.make_branch_and_tree('.')
408
629
        b = make_commits_with_trailing_newlines(wt)
409
630
        sio = self.make_utf8_encoded_stringio()
410
 
        lf = LongLogFormatter(to_file=sio)
411
 
        show_log(b, lf)
412
 
        self.assertEqualDiff(sio.getvalue(), """\
 
631
        lf = log.LongLogFormatter(to_file=sio)
 
632
        log.show_log(b, lf)
 
633
        self.assertEqualDiff("""\
413
634
------------------------------------------------------------
414
635
revno: 3
415
636
committer: Joe Foo <joe@foo.com>
434
655
timestamp: Mon 2005-11-21 09:24:15 -0600
435
656
message:
436
657
  simple log message
437
 
""")
 
658
""",
 
659
                             sio.getvalue())
438
660
 
439
661
    def test_author_in_log(self):
440
662
        """Log includes the author name if it's set in
449
671
                  timestamp=1132711707,
450
672
                  timezone=36000,
451
673
                  committer='Lorem Ipsum <test@example.com>',
452
 
                  author='John Doe <jdoe@example.com>')
453
 
        sio = StringIO()
454
 
        formatter = LongLogFormatter(to_file=sio)
455
 
        show_log(b, formatter)
456
 
        self.assertEqualDiff(sio.getvalue(), '''\
457
 
------------------------------------------------------------
458
 
revno: 1
459
 
author: John Doe <jdoe@example.com>
460
 
committer: Lorem Ipsum <test@example.com>
461
 
branch nick: test_author_log
462
 
timestamp: Wed 2005-11-23 12:08:27 +1000
463
 
message:
464
 
  add a
465
 
''')
466
 
 
467
 
 
468
 
 
469
 
class TestLineLogFormatter(TestCaseWithTransport):
 
674
                  authors=['John Doe <jdoe@example.com>',
 
675
                           'Jane Rey <jrey@example.com>'])
 
676
        sio = StringIO()
 
677
        formatter = log.LongLogFormatter(to_file=sio)
 
678
        log.show_log(b, formatter)
 
679
        self.assertEqualDiff('''\
 
680
------------------------------------------------------------
 
681
revno: 1
 
682
author: John Doe <jdoe@example.com>, Jane Rey <jrey@example.com>
 
683
committer: Lorem Ipsum <test@example.com>
 
684
branch nick: test_author_log
 
685
timestamp: Wed 2005-11-23 12:08:27 +1000
 
686
message:
 
687
  add a
 
688
''',
 
689
                             sio.getvalue())
 
690
 
 
691
    def test_properties_in_log(self):
 
692
        """Log includes the custom properties returned by the registered
 
693
        handlers.
 
694
        """
 
695
        wt = self.make_branch_and_tree('.')
 
696
        b = wt.branch
 
697
        self.build_tree(['a'])
 
698
        wt.add('a')
 
699
        b.nick = 'test_properties_in_log'
 
700
        wt.commit(message='add a',
 
701
                  timestamp=1132711707,
 
702
                  timezone=36000,
 
703
                  committer='Lorem Ipsum <test@example.com>',
 
704
                  authors=['John Doe <jdoe@example.com>'])
 
705
        sio = StringIO()
 
706
        formatter = log.LongLogFormatter(to_file=sio)
 
707
        try:
 
708
            def trivial_custom_prop_handler(revision):
 
709
                return {'test_prop':'test_value'}
 
710
 
 
711
            log.properties_handler_registry.register(
 
712
                'trivial_custom_prop_handler',
 
713
                trivial_custom_prop_handler)
 
714
            log.show_log(b, formatter)
 
715
        finally:
 
716
            log.properties_handler_registry.remove(
 
717
                'trivial_custom_prop_handler')
 
718
            self.assertEqualDiff('''\
 
719
------------------------------------------------------------
 
720
revno: 1
 
721
test_prop: test_value
 
722
author: John Doe <jdoe@example.com>
 
723
committer: Lorem Ipsum <test@example.com>
 
724
branch nick: test_properties_in_log
 
725
timestamp: Wed 2005-11-23 12:08:27 +1000
 
726
message:
 
727
  add a
 
728
''',
 
729
                                 sio.getvalue())
 
730
 
 
731
    def test_properties_in_short_log(self):
 
732
        """Log includes the custom properties returned by the registered
 
733
        handlers.
 
734
        """
 
735
        wt = self.make_branch_and_tree('.')
 
736
        b = wt.branch
 
737
        self.build_tree(['a'])
 
738
        wt.add('a')
 
739
        b.nick = 'test_properties_in_short_log'
 
740
        wt.commit(message='add a',
 
741
                  timestamp=1132711707,
 
742
                  timezone=36000,
 
743
                  committer='Lorem Ipsum <test@example.com>',
 
744
                  authors=['John Doe <jdoe@example.com>'])
 
745
        sio = StringIO()
 
746
        formatter = log.ShortLogFormatter(to_file=sio)
 
747
        try:
 
748
            def trivial_custom_prop_handler(revision):
 
749
                return {'test_prop':'test_value'}
 
750
 
 
751
            log.properties_handler_registry.register(
 
752
                'trivial_custom_prop_handler',
 
753
                trivial_custom_prop_handler)
 
754
            log.show_log(b, formatter)
 
755
        finally:
 
756
            log.properties_handler_registry.remove(
 
757
                'trivial_custom_prop_handler')
 
758
            self.assertEqualDiff('''\
 
759
    1 John Doe\t2005-11-23
 
760
      test_prop: test_value
 
761
      add a
 
762
 
 
763
''',
 
764
                                 sio.getvalue())
 
765
 
 
766
    def test_error_in_properties_handler(self):
 
767
        """Log includes the custom properties returned by the registered
 
768
        handlers.
 
769
        """
 
770
        wt = self.make_branch_and_tree('.')
 
771
        b = wt.branch
 
772
        self.build_tree(['a'])
 
773
        wt.add('a')
 
774
        b.nick = 'test_author_log'
 
775
        wt.commit(message='add a',
 
776
                  timestamp=1132711707,
 
777
                  timezone=36000,
 
778
                  committer='Lorem Ipsum <test@example.com>',
 
779
                  authors=['John Doe <jdoe@example.com>'],
 
780
                  revprops={'first_prop':'first_value'})
 
781
        sio = StringIO()
 
782
        formatter = log.LongLogFormatter(to_file=sio)
 
783
        try:
 
784
            def trivial_custom_prop_handler(revision):
 
785
                raise StandardError("a test error")
 
786
 
 
787
            log.properties_handler_registry.register(
 
788
                'trivial_custom_prop_handler',
 
789
                trivial_custom_prop_handler)
 
790
            self.assertRaises(StandardError, log.show_log, b, formatter,)
 
791
        finally:
 
792
            log.properties_handler_registry.remove(
 
793
                'trivial_custom_prop_handler')
 
794
 
 
795
    def test_properties_handler_bad_argument(self):
 
796
        wt = self.make_branch_and_tree('.')
 
797
        b = wt.branch
 
798
        self.build_tree(['a'])
 
799
        wt.add('a')
 
800
        b.nick = 'test_author_log'
 
801
        wt.commit(message='add a',
 
802
                  timestamp=1132711707,
 
803
                  timezone=36000,
 
804
                  committer='Lorem Ipsum <test@example.com>',
 
805
                  authors=['John Doe <jdoe@example.com>'],
 
806
                  revprops={'a_prop':'test_value'})
 
807
        sio = StringIO()
 
808
        formatter = log.LongLogFormatter(to_file=sio)
 
809
        try:
 
810
            def bad_argument_prop_handler(revision):
 
811
                return {'custom_prop_name':revision.properties['a_prop']}
 
812
 
 
813
            log.properties_handler_registry.register(
 
814
                'bad_argument_prop_handler',
 
815
                bad_argument_prop_handler)
 
816
 
 
817
            self.assertRaises(AttributeError, formatter.show_properties,
 
818
                              'a revision', '')
 
819
 
 
820
            revision = b.repository.get_revision(b.last_revision())
 
821
            formatter.show_properties(revision, '')
 
822
            self.assertEqualDiff('''custom_prop_name: test_value\n''',
 
823
                                 sio.getvalue())
 
824
        finally:
 
825
            log.properties_handler_registry.remove(
 
826
                'bad_argument_prop_handler')
 
827
 
 
828
 
 
829
class TestLongLogFormatterWithoutMergeRevisions(TestCaseWithoutPropsHandler):
 
830
 
 
831
    def test_long_verbose_log(self):
 
832
        """Verbose log includes changed files
 
833
 
 
834
        bug #4676
 
835
        """
 
836
        wt = self.make_branch_and_tree('.')
 
837
        b = wt.branch
 
838
        self.build_tree(['a'])
 
839
        wt.add('a')
 
840
        # XXX: why does a longer nick show up?
 
841
        b.nick = 'test_verbose_log'
 
842
        wt.commit(message='add a',
 
843
                  timestamp=1132711707,
 
844
                  timezone=36000,
 
845
                  committer='Lorem Ipsum <test@example.com>')
 
846
        logfile = file('out.tmp', 'w+')
 
847
        formatter = log.LongLogFormatter(to_file=logfile, levels=1)
 
848
        log.show_log(b, formatter, verbose=True)
 
849
        logfile.flush()
 
850
        logfile.seek(0)
 
851
        log_contents = logfile.read()
 
852
        self.assertEqualDiff('''\
 
853
------------------------------------------------------------
 
854
revno: 1
 
855
committer: Lorem Ipsum <test@example.com>
 
856
branch nick: test_verbose_log
 
857
timestamp: Wed 2005-11-23 12:08:27 +1000
 
858
message:
 
859
  add a
 
860
added:
 
861
  a
 
862
''',
 
863
                             log_contents)
 
864
 
 
865
    def test_long_verbose_contain_deltas(self):
 
866
        wt = self.make_branch_and_tree('parent')
 
867
        self.build_tree(['parent/f1', 'parent/f2'])
 
868
        wt.add(['f1','f2'])
 
869
        wt.commit('first post')
 
870
        self.run_bzr('branch parent child')
 
871
        os.unlink('child/f1')
 
872
        file('child/f2', 'wb').write('hello\n')
 
873
        self.run_bzr(['commit', '-m', 'removed f1 and modified f2',
 
874
            'child'])
 
875
        os.chdir('parent')
 
876
        self.run_bzr('merge ../child')
 
877
        wt.commit('merge branch 1')
 
878
        b = wt.branch
 
879
        sio = self.make_utf8_encoded_stringio()
 
880
        lf = log.LongLogFormatter(to_file=sio, levels=1)
 
881
        log.show_log(b, lf, verbose=True)
 
882
        the_log = normalize_log(sio.getvalue())
 
883
        self.assertEqualDiff("""\
 
884
------------------------------------------------------------
 
885
revno: 2 [merge]
 
886
committer: Lorem Ipsum <test@example.com>
 
887
branch nick: parent
 
888
timestamp: Just now
 
889
message:
 
890
  merge branch 1
 
891
removed:
 
892
  f1
 
893
modified:
 
894
  f2
 
895
------------------------------------------------------------
 
896
revno: 1
 
897
committer: Lorem Ipsum <test@example.com>
 
898
branch nick: parent
 
899
timestamp: Just now
 
900
message:
 
901
  first post
 
902
added:
 
903
  f1
 
904
  f2
 
905
""",
 
906
                             the_log)
 
907
 
 
908
    def test_long_trailing_newlines(self):
 
909
        wt = self.make_branch_and_tree('.')
 
910
        b = make_commits_with_trailing_newlines(wt)
 
911
        sio = self.make_utf8_encoded_stringio()
 
912
        lf = log.LongLogFormatter(to_file=sio, levels=1)
 
913
        log.show_log(b, lf)
 
914
        self.assertEqualDiff("""\
 
915
------------------------------------------------------------
 
916
revno: 3
 
917
committer: Joe Foo <joe@foo.com>
 
918
branch nick: test
 
919
timestamp: Mon 2005-11-21 09:32:56 -0600
 
920
message:
 
921
  single line with trailing newline
 
922
------------------------------------------------------------
 
923
revno: 2
 
924
author: Joe Bar <joe@bar.com>
 
925
committer: Joe Foo <joe@foo.com>
 
926
branch nick: test
 
927
timestamp: Mon 2005-11-21 09:27:22 -0600
 
928
message:
 
929
  multiline
 
930
  log
 
931
  message
 
932
------------------------------------------------------------
 
933
revno: 1
 
934
committer: Joe Foo <joe@foo.com>
 
935
branch nick: test
 
936
timestamp: Mon 2005-11-21 09:24:15 -0600
 
937
message:
 
938
  simple log message
 
939
""",
 
940
                             sio.getvalue())
 
941
 
 
942
    def test_long_author_in_log(self):
 
943
        """Log includes the author name if it's set in
 
944
        the revision properties
 
945
        """
 
946
        wt = self.make_branch_and_tree('.')
 
947
        b = wt.branch
 
948
        self.build_tree(['a'])
 
949
        wt.add('a')
 
950
        b.nick = 'test_author_log'
 
951
        wt.commit(message='add a',
 
952
                  timestamp=1132711707,
 
953
                  timezone=36000,
 
954
                  committer='Lorem Ipsum <test@example.com>',
 
955
                  authors=['John Doe <jdoe@example.com>'])
 
956
        sio = StringIO()
 
957
        formatter = log.LongLogFormatter(to_file=sio, levels=1)
 
958
        log.show_log(b, formatter)
 
959
        self.assertEqualDiff('''\
 
960
------------------------------------------------------------
 
961
revno: 1
 
962
author: John Doe <jdoe@example.com>
 
963
committer: Lorem Ipsum <test@example.com>
 
964
branch nick: test_author_log
 
965
timestamp: Wed 2005-11-23 12:08:27 +1000
 
966
message:
 
967
  add a
 
968
''',
 
969
                             sio.getvalue())
 
970
 
 
971
    def test_long_properties_in_log(self):
 
972
        """Log includes the custom properties returned by the registered
 
973
        handlers.
 
974
        """
 
975
        wt = self.make_branch_and_tree('.')
 
976
        b = wt.branch
 
977
        self.build_tree(['a'])
 
978
        wt.add('a')
 
979
        b.nick = 'test_properties_in_log'
 
980
        wt.commit(message='add a',
 
981
                  timestamp=1132711707,
 
982
                  timezone=36000,
 
983
                  committer='Lorem Ipsum <test@example.com>',
 
984
                  authors=['John Doe <jdoe@example.com>'])
 
985
        sio = StringIO()
 
986
        formatter = log.LongLogFormatter(to_file=sio, levels=1)
 
987
        try:
 
988
            def trivial_custom_prop_handler(revision):
 
989
                return {'test_prop':'test_value'}
 
990
 
 
991
            log.properties_handler_registry.register(
 
992
                'trivial_custom_prop_handler',
 
993
                trivial_custom_prop_handler)
 
994
            log.show_log(b, formatter)
 
995
        finally:
 
996
            log.properties_handler_registry.remove(
 
997
                'trivial_custom_prop_handler')
 
998
            self.assertEqualDiff('''\
 
999
------------------------------------------------------------
 
1000
revno: 1
 
1001
test_prop: test_value
 
1002
author: John Doe <jdoe@example.com>
 
1003
committer: Lorem Ipsum <test@example.com>
 
1004
branch nick: test_properties_in_log
 
1005
timestamp: Wed 2005-11-23 12:08:27 +1000
 
1006
message:
 
1007
  add a
 
1008
''',
 
1009
                                 sio.getvalue())
 
1010
 
 
1011
 
 
1012
class TestLineLogFormatter(tests.TestCaseWithTransport):
470
1013
 
471
1014
    def test_line_log(self):
472
1015
        """Line log should show revno
473
 
        
 
1016
 
474
1017
        bug #5162
475
1018
        """
476
1019
        wt = self.make_branch_and_tree('.')
478
1021
        self.build_tree(['a'])
479
1022
        wt.add('a')
480
1023
        b.nick = 'test-line-log'
481
 
        wt.commit(message='add a', 
482
 
                  timestamp=1132711707, 
 
1024
        wt.commit(message='add a',
 
1025
                  timestamp=1132711707,
483
1026
                  timezone=36000,
484
1027
                  committer='Line-Log-Formatter Tester <test@line.log>')
485
1028
        logfile = file('out.tmp', 'w+')
486
 
        formatter = LineLogFormatter(to_file=logfile)
487
 
        show_log(b, formatter)
 
1029
        formatter = log.LineLogFormatter(to_file=logfile)
 
1030
        log.show_log(b, formatter)
488
1031
        logfile.flush()
489
1032
        logfile.seek(0)
490
1033
        log_contents = logfile.read()
491
 
        self.assertEqualDiff(log_contents, '1: Line-Log-Formatte... 2005-11-23 add a\n')
492
 
 
493
 
    def test_short_log_with_merges(self):
494
 
        wt = self.make_branch_and_memory_tree('.')
495
 
        wt.lock_write()
496
 
        try:
497
 
            wt.add('')
498
 
            wt.commit('rev-1', rev_id='rev-1',
499
 
                      timestamp=1132586655, timezone=36000,
500
 
                      committer='Joe Foo <joe@foo.com>')
501
 
            wt.commit('rev-merged', rev_id='rev-2a',
502
 
                      timestamp=1132586700, timezone=36000,
503
 
                      committer='Joe Foo <joe@foo.com>')
504
 
            wt.set_parent_ids(['rev-1', 'rev-2a'])
505
 
            wt.branch.set_last_revision_info(1, 'rev-1')
506
 
            wt.commit('rev-2', rev_id='rev-2b',
507
 
                      timestamp=1132586800, timezone=36000,
508
 
                      committer='Joe Foo <joe@foo.com>')
509
 
            logfile = self.make_utf8_encoded_stringio()
510
 
            formatter = ShortLogFormatter(to_file=logfile)
511
 
            show_log(wt.branch, formatter)
512
 
            logfile.flush()
513
 
            self.assertEqualDiff("""\
514
 
    2 Joe Foo\t2005-11-22 [merge]
515
 
      rev-2
516
 
 
517
 
    1 Joe Foo\t2005-11-22
518
 
      rev-1
519
 
 
520
 
""", logfile.getvalue())
521
 
        finally:
522
 
            wt.unlock()
 
1034
        self.assertEqualDiff('1: Line-Log-Formatte... 2005-11-23 add a\n',
 
1035
                             log_contents)
523
1036
 
524
1037
    def test_trailing_newlines(self):
525
1038
        wt = self.make_branch_and_tree('.')
526
1039
        b = make_commits_with_trailing_newlines(wt)
527
1040
        sio = self.make_utf8_encoded_stringio()
528
 
        lf = LineLogFormatter(to_file=sio)
529
 
        show_log(b, lf)
530
 
        self.assertEqualDiff(sio.getvalue(), """\
 
1041
        lf = log.LineLogFormatter(to_file=sio)
 
1042
        log.show_log(b, lf)
 
1043
        self.assertEqualDiff("""\
531
1044
3: Joe Foo 2005-11-21 single line with trailing newline
532
1045
2: Joe Bar 2005-11-21 multiline
533
1046
1: Joe Foo 2005-11-21 simple log message
534
 
""")
535
 
 
536
 
 
537
 
class TestGetViewRevisions(TestCaseWithTransport):
 
1047
""",
 
1048
                             sio.getvalue())
 
1049
 
 
1050
    def _prepare_tree_with_merges(self, with_tags=False):
 
1051
        wt = self.make_branch_and_memory_tree('.')
 
1052
        wt.lock_write()
 
1053
        self.addCleanup(wt.unlock)
 
1054
        wt.add('')
 
1055
        wt.commit('rev-1', rev_id='rev-1',
 
1056
                  timestamp=1132586655, timezone=36000,
 
1057
                  committer='Joe Foo <joe@foo.com>')
 
1058
        wt.commit('rev-merged', rev_id='rev-2a',
 
1059
                  timestamp=1132586700, timezone=36000,
 
1060
                  committer='Joe Foo <joe@foo.com>')
 
1061
        wt.set_parent_ids(['rev-1', 'rev-2a'])
 
1062
        wt.branch.set_last_revision_info(1, 'rev-1')
 
1063
        wt.commit('rev-2', rev_id='rev-2b',
 
1064
                  timestamp=1132586800, timezone=36000,
 
1065
                  committer='Joe Foo <joe@foo.com>')
 
1066
        if with_tags:
 
1067
            branch = wt.branch
 
1068
            branch.tags.set_tag('v0.2', 'rev-2b')
 
1069
            wt.commit('rev-3', rev_id='rev-3',
 
1070
                      timestamp=1132586900, timezone=36000,
 
1071
                      committer='Jane Foo <jane@foo.com>')
 
1072
            branch.tags.set_tag('v1.0rc1', 'rev-3')
 
1073
            branch.tags.set_tag('v1.0', 'rev-3')
 
1074
        return wt
 
1075
 
 
1076
    def test_line_log_single_merge_revision(self):
 
1077
        wt = self._prepare_tree_with_merges()
 
1078
        logfile = self.make_utf8_encoded_stringio()
 
1079
        formatter = log.LineLogFormatter(to_file=logfile)
 
1080
        revspec = revisionspec.RevisionSpec.from_string('1.1.1')
 
1081
        wtb = wt.branch
 
1082
        rev = revspec.in_history(wtb)
 
1083
        log.show_log(wtb, formatter, start_revision=rev, end_revision=rev)
 
1084
        self.assertEqualDiff("""\
 
1085
1.1.1: Joe Foo 2005-11-22 rev-merged
 
1086
""",
 
1087
                             logfile.getvalue())
 
1088
 
 
1089
    def test_line_log_with_tags(self):
 
1090
        wt = self._prepare_tree_with_merges(with_tags=True)
 
1091
        logfile = self.make_utf8_encoded_stringio()
 
1092
        formatter = log.LineLogFormatter(to_file=logfile)
 
1093
        log.show_log(wt.branch, formatter)
 
1094
        self.assertEqualDiff("""\
 
1095
3: Jane Foo 2005-11-22 {v1.0, v1.0rc1} rev-3
 
1096
2: Joe Foo 2005-11-22 [merge] {v0.2} rev-2
 
1097
1: Joe Foo 2005-11-22 rev-1
 
1098
""",
 
1099
                             logfile.getvalue())
 
1100
 
 
1101
class TestLineLogFormatterWithMergeRevisions(tests.TestCaseWithTransport):
 
1102
 
 
1103
    def test_line_merge_revs_log(self):
 
1104
        """Line log should show revno
 
1105
 
 
1106
        bug #5162
 
1107
        """
 
1108
        wt = self.make_branch_and_tree('.')
 
1109
        b = wt.branch
 
1110
        self.build_tree(['a'])
 
1111
        wt.add('a')
 
1112
        b.nick = 'test-line-log'
 
1113
        wt.commit(message='add a',
 
1114
                  timestamp=1132711707,
 
1115
                  timezone=36000,
 
1116
                  committer='Line-Log-Formatter Tester <test@line.log>')
 
1117
        logfile = file('out.tmp', 'w+')
 
1118
        formatter = log.LineLogFormatter(to_file=logfile, levels=0)
 
1119
        log.show_log(b, formatter)
 
1120
        logfile.flush()
 
1121
        logfile.seek(0)
 
1122
        log_contents = logfile.read()
 
1123
        self.assertEqualDiff('1: Line-Log-Formatte... 2005-11-23 add a\n',
 
1124
                             log_contents)
 
1125
 
 
1126
    def test_line_merge_revs_log_single_merge_revision(self):
 
1127
        wt = self.make_branch_and_memory_tree('.')
 
1128
        wt.lock_write()
 
1129
        self.addCleanup(wt.unlock)
 
1130
        wt.add('')
 
1131
        wt.commit('rev-1', rev_id='rev-1',
 
1132
                  timestamp=1132586655, timezone=36000,
 
1133
                  committer='Joe Foo <joe@foo.com>')
 
1134
        wt.commit('rev-merged', rev_id='rev-2a',
 
1135
                  timestamp=1132586700, timezone=36000,
 
1136
                  committer='Joe Foo <joe@foo.com>')
 
1137
        wt.set_parent_ids(['rev-1', 'rev-2a'])
 
1138
        wt.branch.set_last_revision_info(1, 'rev-1')
 
1139
        wt.commit('rev-2', rev_id='rev-2b',
 
1140
                  timestamp=1132586800, timezone=36000,
 
1141
                  committer='Joe Foo <joe@foo.com>')
 
1142
        logfile = self.make_utf8_encoded_stringio()
 
1143
        formatter = log.LineLogFormatter(to_file=logfile, levels=0)
 
1144
        revspec = revisionspec.RevisionSpec.from_string('1.1.1')
 
1145
        wtb = wt.branch
 
1146
        rev = revspec.in_history(wtb)
 
1147
        log.show_log(wtb, formatter, start_revision=rev, end_revision=rev)
 
1148
        self.assertEqualDiff("""\
 
1149
1.1.1: Joe Foo 2005-11-22 rev-merged
 
1150
""",
 
1151
                             logfile.getvalue())
 
1152
 
 
1153
    def test_line_merge_revs_log_with_merges(self):
 
1154
        wt = self.make_branch_and_memory_tree('.')
 
1155
        wt.lock_write()
 
1156
        self.addCleanup(wt.unlock)
 
1157
        wt.add('')
 
1158
        wt.commit('rev-1', rev_id='rev-1',
 
1159
                  timestamp=1132586655, timezone=36000,
 
1160
                  committer='Joe Foo <joe@foo.com>')
 
1161
        wt.commit('rev-merged', rev_id='rev-2a',
 
1162
                  timestamp=1132586700, timezone=36000,
 
1163
                  committer='Joe Foo <joe@foo.com>')
 
1164
        wt.set_parent_ids(['rev-1', 'rev-2a'])
 
1165
        wt.branch.set_last_revision_info(1, 'rev-1')
 
1166
        wt.commit('rev-2', rev_id='rev-2b',
 
1167
                  timestamp=1132586800, timezone=36000,
 
1168
                  committer='Joe Foo <joe@foo.com>')
 
1169
        logfile = self.make_utf8_encoded_stringio()
 
1170
        formatter = log.LineLogFormatter(to_file=logfile, levels=0)
 
1171
        log.show_log(wt.branch, formatter)
 
1172
        self.assertEqualDiff("""\
 
1173
2: Joe Foo 2005-11-22 [merge] rev-2
 
1174
  1.1.1: Joe Foo 2005-11-22 rev-merged
 
1175
1: Joe Foo 2005-11-22 rev-1
 
1176
""",
 
1177
                             logfile.getvalue())
 
1178
 
 
1179
class TestGetViewRevisions(tests.TestCaseWithTransport):
538
1180
 
539
1181
    def make_tree_with_commits(self):
540
1182
        """Create a tree with well-known revision ids"""
558
1200
        # 4a: 3.1.1
559
1201
        return mainline_revs, rev_nos, wt
560
1202
 
561
 
    def make_tree_with_many_merges(self):
 
1203
    def make_branch_with_many_merges(self):
562
1204
        """Create a tree with well-known revision ids"""
563
 
        wt = self.make_branch_and_tree('tree1')
564
 
        wt.commit('commit one', rev_id='1')
565
 
        wt.commit('commit two', rev_id='2')
566
 
        tree3 = wt.bzrdir.sprout('tree3').open_workingtree()
567
 
        tree3.commit('commit three a', rev_id='3a')
568
 
        tree2 = wt.bzrdir.sprout('tree2').open_workingtree()
569
 
        tree2.merge_from_branch(tree3.branch)
570
 
        tree2.commit('commit three b', rev_id='3b')
571
 
        wt.merge_from_branch(tree2.branch)
572
 
        wt.commit('commit three c', rev_id='3c')
573
 
        tree2.commit('four-a', rev_id='4a')
574
 
        wt.merge_from_branch(tree2.branch)
575
 
        wt.commit('four-b', rev_id='4b')
 
1205
        builder = self.make_branch_builder('tree1')
 
1206
        builder.start_series()
 
1207
        builder.build_snapshot('1', None, [
 
1208
            ('add', ('', 'TREE_ROOT', 'directory', '')),
 
1209
            ('add', ('f', 'f-id', 'file', '1\n'))])
 
1210
        builder.build_snapshot('2', ['1'], [])
 
1211
        builder.build_snapshot('3a', ['2'], [
 
1212
            ('modify', ('f-id', '1\n2\n3a\n'))])
 
1213
        builder.build_snapshot('3b', ['2', '3a'], [
 
1214
            ('modify', ('f-id', '1\n2\n3a\n'))])
 
1215
        builder.build_snapshot('3c', ['2', '3b'], [
 
1216
            ('modify', ('f-id', '1\n2\n3a\n'))])
 
1217
        builder.build_snapshot('4a', ['3b'], [])
 
1218
        builder.build_snapshot('4b', ['3c', '4a'], [])
 
1219
        builder.finish_series()
 
1220
 
 
1221
        # 1
 
1222
        # |
 
1223
        # 2-.
 
1224
        # |\ \
 
1225
        # | | 3a
 
1226
        # | |/
 
1227
        # | 3b
 
1228
        # |/|
 
1229
        # 3c4a
 
1230
        # |/
 
1231
        # 4b
 
1232
 
576
1233
        mainline_revs = [None, '1', '2', '3c', '4b']
577
1234
        rev_nos = {'1':1, '2':2, '3c': 3, '4b':4}
578
1235
        full_rev_nos_for_reference = {
579
1236
            '1': '1',
580
1237
            '2': '2',
581
 
            '3a': '2.2.1', #first commit tree 3
582
 
            '3b': '2.1.1', # first commit tree 2
 
1238
            '3a': '2.1.1', #first commit tree 3
 
1239
            '3b': '2.2.1', # first commit tree 2
583
1240
            '3c': '3', #merges 3b to main
584
 
            '4a': '2.1.2', # second commit tree 2
 
1241
            '4a': '2.2.2', # second commit tree 2
585
1242
            '4b': '4', # merges 4a to main
586
1243
            }
587
 
        return mainline_revs, rev_nos, wt
 
1244
        return mainline_revs, rev_nos, builder.get_branch()
588
1245
 
589
1246
    def test_get_view_revisions_forward(self):
590
1247
        """Test the get_view_revisions method"""
591
1248
        mainline_revs, rev_nos, wt = self.make_tree_with_commits()
592
 
        revisions = list(get_view_revisions(mainline_revs, rev_nos, wt.branch,
593
 
                                            'forward'))
 
1249
        wt.lock_read()
 
1250
        self.addCleanup(wt.unlock)
 
1251
        revisions = list(log.get_view_revisions(
 
1252
                mainline_revs, rev_nos, wt.branch, 'forward'))
594
1253
        self.assertEqual([('1', '1', 0), ('2', '2', 0), ('3', '3', 0)],
595
 
            revisions)
596
 
        revisions2 = list(get_view_revisions(mainline_revs, rev_nos, wt.branch,
597
 
                                             'forward', include_merges=False))
 
1254
                         revisions)
 
1255
        revisions2 = list(log.get_view_revisions(
 
1256
                mainline_revs, rev_nos, wt.branch, 'forward',
 
1257
                include_merges=False))
598
1258
        self.assertEqual(revisions, revisions2)
599
1259
 
600
1260
    def test_get_view_revisions_reverse(self):
601
1261
        """Test the get_view_revisions with reverse"""
602
1262
        mainline_revs, rev_nos, wt = self.make_tree_with_commits()
603
 
        revisions = list(get_view_revisions(mainline_revs, rev_nos, wt.branch,
604
 
                                            'reverse'))
 
1263
        wt.lock_read()
 
1264
        self.addCleanup(wt.unlock)
 
1265
        revisions = list(log.get_view_revisions(
 
1266
                mainline_revs, rev_nos, wt.branch, 'reverse'))
605
1267
        self.assertEqual([('3', '3', 0), ('2', '2', 0), ('1', '1', 0), ],
606
 
            revisions)
607
 
        revisions2 = list(get_view_revisions(mainline_revs, rev_nos, wt.branch,
608
 
                                             'reverse', include_merges=False))
 
1268
                         revisions)
 
1269
        revisions2 = list(log.get_view_revisions(
 
1270
                mainline_revs, rev_nos, wt.branch, 'reverse',
 
1271
                include_merges=False))
609
1272
        self.assertEqual(revisions, revisions2)
610
1273
 
611
1274
    def test_get_view_revisions_merge(self):
612
1275
        """Test get_view_revisions when there are merges"""
613
1276
        mainline_revs, rev_nos, wt = self.make_tree_with_merges()
614
 
        revisions = list(get_view_revisions(mainline_revs, rev_nos, wt.branch,
615
 
                                            'forward'))
616
 
        self.assertEqual([('1', '1', 0), ('2', '2', 0), ('3', '3', 0),
617
 
            ('4b', '4', 0), ('4a', '3.1.1', 1)],
618
 
            revisions)
619
 
        revisions = list(get_view_revisions(mainline_revs, rev_nos, wt.branch,
620
 
                                             'forward', include_merges=False))
621
 
        self.assertEqual([('1', '1', 0), ('2', '2', 0), ('3', '3', 0),
622
 
            ('4b', '4', 0)],
623
 
            revisions)
 
1277
        wt.lock_read()
 
1278
        self.addCleanup(wt.unlock)
 
1279
        revisions = list(log.get_view_revisions(
 
1280
                mainline_revs, rev_nos, wt.branch, 'forward'))
 
1281
        self.assertEqual([('1', '1', 0), ('2', '2', 0), ('3', '3', 0),
 
1282
                          ('4b', '4', 0), ('4a', '3.1.1', 1)],
 
1283
                         revisions)
 
1284
        revisions = list(log.get_view_revisions(
 
1285
                mainline_revs, rev_nos, wt.branch, 'forward',
 
1286
                include_merges=False))
 
1287
        self.assertEqual([('1', '1', 0), ('2', '2', 0), ('3', '3', 0),
 
1288
                          ('4b', '4', 0)],
 
1289
                         revisions)
624
1290
 
625
1291
    def test_get_view_revisions_merge_reverse(self):
626
1292
        """Test get_view_revisions in reverse when there are merges"""
627
1293
        mainline_revs, rev_nos, wt = self.make_tree_with_merges()
628
 
        revisions = list(get_view_revisions(mainline_revs, rev_nos, wt.branch,
629
 
                                            'reverse'))
 
1294
        wt.lock_read()
 
1295
        self.addCleanup(wt.unlock)
 
1296
        revisions = list(log.get_view_revisions(
 
1297
                mainline_revs, rev_nos, wt.branch, 'reverse'))
630
1298
        self.assertEqual([('4b', '4', 0), ('4a', '3.1.1', 1),
631
 
            ('3', '3', 0), ('2', '2', 0), ('1', '1', 0)],
632
 
            revisions)
633
 
        revisions = list(get_view_revisions(mainline_revs, rev_nos, wt.branch,
634
 
                                             'reverse', include_merges=False))
 
1299
                          ('3', '3', 0), ('2', '2', 0), ('1', '1', 0)],
 
1300
                         revisions)
 
1301
        revisions = list(log.get_view_revisions(
 
1302
                mainline_revs, rev_nos, wt.branch, 'reverse',
 
1303
                include_merges=False))
635
1304
        self.assertEqual([('4b', '4', 0), ('3', '3', 0), ('2', '2', 0),
636
 
            ('1', '1', 0)],
637
 
            revisions)
 
1305
                          ('1', '1', 0)],
 
1306
                         revisions)
638
1307
 
639
1308
    def test_get_view_revisions_merge2(self):
640
1309
        """Test get_view_revisions when there are merges"""
641
 
        mainline_revs, rev_nos, wt = self.make_tree_with_many_merges()
642
 
        revisions = list(get_view_revisions(mainline_revs, rev_nos, wt.branch,
643
 
                                            'forward'))
 
1310
        mainline_revs, rev_nos, b = self.make_branch_with_many_merges()
 
1311
        b.lock_read()
 
1312
        self.addCleanup(b.unlock)
 
1313
        revisions = list(log.get_view_revisions(
 
1314
                mainline_revs, rev_nos, b, 'forward'))
644
1315
        expected = [('1', '1', 0), ('2', '2', 0), ('3c', '3', 0),
645
 
            ('3a', '2.2.1', 1), ('3b', '2.1.1', 1), ('4b', '4', 0),
646
 
            ('4a', '2.1.2', 1)]
 
1316
                    ('3b', '2.2.1', 1), ('3a', '2.1.1', 2), ('4b', '4', 0),
 
1317
                    ('4a', '2.2.2', 1)]
647
1318
        self.assertEqual(expected, revisions)
648
 
        revisions = list(get_view_revisions(mainline_revs, rev_nos, wt.branch,
649
 
                                             'forward', include_merges=False))
 
1319
        revisions = list(log.get_view_revisions(
 
1320
                mainline_revs, rev_nos, b, 'forward',
 
1321
                include_merges=False))
650
1322
        self.assertEqual([('1', '1', 0), ('2', '2', 0), ('3c', '3', 0),
651
 
            ('4b', '4', 0)],
652
 
            revisions)
653
 
 
654
 
 
655
 
class TestGetRevisionsTouchingFileID(TestCaseWithTransport):
 
1323
                          ('4b', '4', 0)],
 
1324
                         revisions)
 
1325
 
 
1326
 
 
1327
    def test_file_id_for_range(self):
 
1328
        mainline_revs, rev_nos, b = self.make_branch_with_many_merges()
 
1329
        b.lock_read()
 
1330
        self.addCleanup(b.unlock)
 
1331
 
 
1332
        def rev_from_rev_id(revid, branch):
 
1333
            revspec = revisionspec.RevisionSpec.from_string('revid:%s' % revid)
 
1334
            return revspec.in_history(branch)
 
1335
 
 
1336
        def view_revs(start_rev, end_rev, file_id, direction):
 
1337
            revs = log.calculate_view_revisions(
 
1338
                b,
 
1339
                start_rev, # start_revision
 
1340
                end_rev, # end_revision
 
1341
                direction, # direction
 
1342
                file_id, # specific_fileid
 
1343
                True, # generate_merge_revisions
 
1344
                )
 
1345
            return revs
 
1346
 
 
1347
        rev_3a = rev_from_rev_id('3a', b)
 
1348
        rev_4b = rev_from_rev_id('4b', b)
 
1349
        self.assertEqual([('3c', '3', 0), ('3b', '2.2.1', 1), ('3a', '2.1.1', 2)],
 
1350
                          view_revs(rev_3a, rev_4b, 'f-id', 'reverse'))
 
1351
        # Note: 3c still appears before 3a here because of depth-based sorting
 
1352
        self.assertEqual([('3c', '3', 0), ('3b', '2.2.1', 1), ('3a', '2.1.1', 2)],
 
1353
                          view_revs(rev_3a, rev_4b, 'f-id', 'forward'))
 
1354
 
 
1355
 
 
1356
class TestGetRevisionsTouchingFileID(tests.TestCaseWithTransport):
656
1357
 
657
1358
    def create_tree_with_single_merge(self):
658
1359
        """Create a branch with a moderate layout.
708
1409
        tree.commit('D', rev_id='D')
709
1410
 
710
1411
        # Switch to a read lock for this tree.
711
 
        # We still have addCleanup(unlock)
 
1412
        # We still have an addCleanup(tree.unlock) pending
712
1413
        tree.unlock()
713
1414
        tree.lock_read()
714
1415
        return tree
715
1416
 
 
1417
    def check_delta(self, delta, **kw):
 
1418
        """Check the filenames touched by a delta are as expected.
 
1419
 
 
1420
        Caller only have to pass in the list of files for each part, all
 
1421
        unspecified parts are considered empty (and checked as such).
 
1422
        """
 
1423
        for n in 'added', 'removed', 'renamed', 'modified', 'unchanged':
 
1424
            # By default we expect an empty list
 
1425
            expected = kw.get(n, [])
 
1426
            # strip out only the path components
 
1427
            got = [x[0] for x in getattr(delta, n)]
 
1428
            self.assertEqual(expected, got)
 
1429
 
716
1430
    def test_tree_with_single_merge(self):
717
1431
        """Make sure the tree layout is correct."""
718
1432
        tree = self.create_tree_with_single_merge()
719
1433
        rev_A_tree = tree.branch.repository.revision_tree('A')
720
1434
        rev_B_tree = tree.branch.repository.revision_tree('B')
721
 
 
722
 
        f1_changed = (u'f1', 'f1-id', 'file', True, False)
723
 
        f2_changed = (u'f2', 'f2-id', 'file', True, False)
724
 
        f3_changed = (u'f3', 'f3-id', 'file', True, False)
725
 
 
726
 
        delta = rev_B_tree.changes_from(rev_A_tree)
727
 
        self.assertEqual([f1_changed, f3_changed], delta.modified)
728
 
        self.assertEqual([], delta.renamed)
729
 
        self.assertEqual([], delta.added)
730
 
        self.assertEqual([], delta.removed)
731
 
 
732
1435
        rev_C_tree = tree.branch.repository.revision_tree('C')
733
 
        delta = rev_C_tree.changes_from(rev_A_tree)
734
 
        self.assertEqual([f2_changed, f3_changed], delta.modified)
735
 
        self.assertEqual([], delta.renamed)
736
 
        self.assertEqual([], delta.added)
737
 
        self.assertEqual([], delta.removed)
738
 
 
739
1436
        rev_D_tree = tree.branch.repository.revision_tree('D')
740
 
        delta = rev_D_tree.changes_from(rev_B_tree)
741
 
        self.assertEqual([f2_changed, f3_changed], delta.modified)
742
 
        self.assertEqual([], delta.renamed)
743
 
        self.assertEqual([], delta.added)
744
 
        self.assertEqual([], delta.removed)
745
 
 
746
 
        delta = rev_D_tree.changes_from(rev_C_tree)
747
 
        self.assertEqual([f1_changed, f3_changed], delta.modified)
748
 
        self.assertEqual([], delta.renamed)
749
 
        self.assertEqual([], delta.added)
750
 
        self.assertEqual([], delta.removed)
 
1437
 
 
1438
        self.check_delta(rev_B_tree.changes_from(rev_A_tree),
 
1439
                         modified=['f1', 'f3'])
 
1440
 
 
1441
        self.check_delta(rev_C_tree.changes_from(rev_A_tree),
 
1442
                         modified=['f2', 'f3'])
 
1443
 
 
1444
        self.check_delta(rev_D_tree.changes_from(rev_B_tree),
 
1445
                         modified=['f2', 'f3'])
 
1446
 
 
1447
        self.check_delta(rev_D_tree.changes_from(rev_C_tree),
 
1448
                         modified=['f1', 'f3'])
751
1449
 
752
1450
    def assertAllRevisionsForFileID(self, tree, file_id, revisions):
753
 
        """Make sure _filter_revisions_touching_file_id returns the right values.
 
1451
        """Ensure _filter_revisions_touching_file_id returns the right values.
754
1452
 
755
1453
        Get the return value from _filter_revisions_touching_file_id and make
756
1454
        sure they are correct.
757
1455
        """
758
 
        # The api for _get_revisions_touching_file_id is a little crazy,
 
1456
        # The api for _filter_revisions_touching_file_id is a little crazy.
759
1457
        # So we do the setup here.
760
1458
        mainline = tree.branch.revision_history()
761
1459
        mainline.insert(0, None)
763
1461
        view_revs_iter = log.get_view_revisions(mainline, revnos, tree.branch,
764
1462
                                                'reverse', True)
765
1463
        actual_revs = log._filter_revisions_touching_file_id(
766
 
                            tree.branch, 
 
1464
                            tree.branch,
767
1465
                            file_id,
768
 
                            mainline,
769
1466
                            list(view_revs_iter))
770
1467
        self.assertEqual(revisions, [r for r, revno, depth in actual_revs])
771
1468
 
783
1480
    def test_file_id_f3(self):
784
1481
        tree = self.create_tree_with_single_merge()
785
1482
        # f3 should be marked as modified by revisions A, B, C, and D
 
1483
        self.assertAllRevisionsForFileID(tree, 'f3-id', ['D', 'C', 'B', 'A'])
 
1484
 
 
1485
    def test_file_id_with_ghosts(self):
 
1486
        # This is testing bug #209948, where having a ghost would cause
 
1487
        # _filter_revisions_touching_file_id() to fail.
 
1488
        tree = self.create_tree_with_single_merge()
 
1489
        # We need to add a revision, so switch back to a write-locked tree
 
1490
        # (still a single addCleanup(tree.unlock) pending).
 
1491
        tree.unlock()
 
1492
        tree.lock_write()
 
1493
        first_parent = tree.last_revision()
 
1494
        tree.set_parent_ids([first_parent, 'ghost-revision-id'])
 
1495
        self.build_tree_contents([('tree/f1', 'A\nB\nXX\n')])
 
1496
        tree.commit('commit with a ghost', rev_id='XX')
 
1497
        self.assertAllRevisionsForFileID(tree, 'f1-id', ['XX', 'B', 'A'])
786
1498
        self.assertAllRevisionsForFileID(tree, 'f2-id', ['D', 'C', 'A'])
787
1499
 
788
 
 
789
 
class TestShowChangedRevisions(TestCaseWithTransport):
 
1500
    def test_unknown_file_id(self):
 
1501
        tree = self.create_tree_with_single_merge()
 
1502
        self.assertAllRevisionsForFileID(tree, 'unknown', [])
 
1503
 
 
1504
    def test_empty_branch_unknown_file_id(self):
 
1505
        tree = self.make_branch_and_tree('tree')
 
1506
        self.assertAllRevisionsForFileID(tree, 'unknown', [])
 
1507
 
 
1508
 
 
1509
class TestShowChangedRevisions(tests.TestCaseWithTransport):
790
1510
 
791
1511
    def test_show_changed_revisions_verbose(self):
792
1512
        tree = self.make_branch_and_tree('tree_a')
799
1519
        self.assertNotContainsRe(s.getvalue(), 'foo')
800
1520
 
801
1521
 
802
 
class TestLogFormatter(TestCase):
 
1522
class TestLogFormatter(tests.TestCase):
803
1523
 
804
1524
    def test_short_committer(self):
805
 
        rev = Revision('a-id')
 
1525
        rev = revision.Revision('a-id')
806
1526
        rev.committer = 'John Doe <jdoe@example.com>'
807
 
        lf = LogFormatter(None)
 
1527
        lf = log.LogFormatter(None)
808
1528
        self.assertEqual('John Doe', lf.short_committer(rev))
 
1529
        rev.committer = 'John Smith <jsmith@example.com>'
 
1530
        self.assertEqual('John Smith', lf.short_committer(rev))
 
1531
        rev.committer = 'John Smith'
 
1532
        self.assertEqual('John Smith', lf.short_committer(rev))
 
1533
        rev.committer = 'jsmith@example.com'
 
1534
        self.assertEqual('jsmith@example.com', lf.short_committer(rev))
 
1535
        rev.committer = '<jsmith@example.com>'
 
1536
        self.assertEqual('jsmith@example.com', lf.short_committer(rev))
 
1537
        rev.committer = 'John Smith jsmith@example.com'
 
1538
        self.assertEqual('John Smith', lf.short_committer(rev))
809
1539
 
810
1540
    def test_short_author(self):
811
 
        rev = Revision('a-id')
 
1541
        rev = revision.Revision('a-id')
812
1542
        rev.committer = 'John Doe <jdoe@example.com>'
813
 
        lf = LogFormatter(None)
 
1543
        lf = log.LogFormatter(None)
814
1544
        self.assertEqual('John Doe', lf.short_author(rev))
815
1545
        rev.properties['author'] = 'John Smith <jsmith@example.com>'
816
1546
        self.assertEqual('John Smith', lf.short_author(rev))
 
1547
        rev.properties['author'] = 'John Smith'
 
1548
        self.assertEqual('John Smith', lf.short_author(rev))
 
1549
        rev.properties['author'] = 'jsmith@example.com'
 
1550
        self.assertEqual('jsmith@example.com', lf.short_author(rev))
 
1551
        rev.properties['author'] = '<jsmith@example.com>'
 
1552
        self.assertEqual('jsmith@example.com', lf.short_author(rev))
 
1553
        rev.properties['author'] = 'John Smith jsmith@example.com'
 
1554
        self.assertEqual('John Smith', lf.short_author(rev))
 
1555
        del rev.properties['author']
 
1556
        rev.properties['authors'] = ('John Smith <jsmith@example.com>\n'
 
1557
                'Jane Rey <jrey@example.com>')
 
1558
        self.assertEqual('John Smith', lf.short_author(rev))
 
1559
 
 
1560
 
 
1561
class TestReverseByDepth(tests.TestCase):
 
1562
    """Test reverse_by_depth behavior.
 
1563
 
 
1564
    This is used to present revisions in forward (oldest first) order in a nice
 
1565
    layout.
 
1566
 
 
1567
    The tests use lighter revision description to ease reading.
 
1568
    """
 
1569
 
 
1570
    def assertReversed(self, forward, backward):
 
1571
        # Transform the descriptions to suit the API: tests use (revno, depth),
 
1572
        # while the API expects (revid, revno, depth)
 
1573
        def complete_revisions(l):
 
1574
            """Transform the description to suit the API.
 
1575
 
 
1576
            Tests use (revno, depth) whil the API expects (revid, revno, depth).
 
1577
            Since the revid is arbitrary, we just duplicate revno
 
1578
            """
 
1579
            return [ (r, r, d) for r, d in l]
 
1580
        forward = complete_revisions(forward)
 
1581
        backward= complete_revisions(backward)
 
1582
        self.assertEqual(forward, log.reverse_by_depth(backward))
 
1583
 
 
1584
 
 
1585
    def test_mainline_revisions(self):
 
1586
        self.assertReversed([( '1', 0), ('2', 0)],
 
1587
                            [('2', 0), ('1', 0)])
 
1588
 
 
1589
    def test_merged_revisions(self):
 
1590
        self.assertReversed([('1', 0), ('2', 0), ('2.2', 1), ('2.1', 1),],
 
1591
                            [('2', 0), ('2.1', 1), ('2.2', 1), ('1', 0),])
 
1592
    def test_shifted_merged_revisions(self):
 
1593
        """Test irregular layout.
 
1594
 
 
1595
        Requesting revisions touching a file can produce "holes" in the depths.
 
1596
        """
 
1597
        self.assertReversed([('1', 0), ('2', 0), ('1.1', 2), ('1.2', 2),],
 
1598
                            [('2', 0), ('1.2', 2), ('1.1', 2), ('1', 0),])
 
1599
 
 
1600
    def test_merged_without_child_revisions(self):
 
1601
        """Test irregular layout.
 
1602
 
 
1603
        Revision ranges can produce "holes" in the depths.
 
1604
        """
 
1605
        # When a revision of higher depth doesn't follow one of lower depth, we
 
1606
        # assume a lower depth one is virtually there
 
1607
        self.assertReversed([('1', 2), ('2', 2), ('3', 3), ('4', 4)],
 
1608
                            [('4', 4), ('3', 3), ('2', 2), ('1', 2),])
 
1609
        # So we get the same order after reversing below even if the original
 
1610
        # revisions are not in the same order.
 
1611
        self.assertReversed([('1', 2), ('2', 2), ('3', 3), ('4', 4)],
 
1612
                            [('3', 3), ('4', 4), ('2', 2), ('1', 2),])
 
1613
 
 
1614
 
 
1615
class TestHistoryChange(tests.TestCaseWithTransport):
 
1616
 
 
1617
    def setup_a_tree(self):
 
1618
        tree = self.make_branch_and_tree('tree')
 
1619
        tree.lock_write()
 
1620
        self.addCleanup(tree.unlock)
 
1621
        tree.commit('1a', rev_id='1a')
 
1622
        tree.commit('2a', rev_id='2a')
 
1623
        tree.commit('3a', rev_id='3a')
 
1624
        return tree
 
1625
 
 
1626
    def setup_ab_tree(self):
 
1627
        tree = self.setup_a_tree()
 
1628
        tree.set_last_revision('1a')
 
1629
        tree.branch.set_last_revision_info(1, '1a')
 
1630
        tree.commit('2b', rev_id='2b')
 
1631
        tree.commit('3b', rev_id='3b')
 
1632
        return tree
 
1633
 
 
1634
    def setup_ac_tree(self):
 
1635
        tree = self.setup_a_tree()
 
1636
        tree.set_last_revision(revision.NULL_REVISION)
 
1637
        tree.branch.set_last_revision_info(0, revision.NULL_REVISION)
 
1638
        tree.commit('1c', rev_id='1c')
 
1639
        tree.commit('2c', rev_id='2c')
 
1640
        tree.commit('3c', rev_id='3c')
 
1641
        return tree
 
1642
 
 
1643
    def test_all_new(self):
 
1644
        tree = self.setup_ab_tree()
 
1645
        old, new = log.get_history_change('1a', '3a', tree.branch.repository)
 
1646
        self.assertEqual([], old)
 
1647
        self.assertEqual(['2a', '3a'], new)
 
1648
 
 
1649
    def test_all_old(self):
 
1650
        tree = self.setup_ab_tree()
 
1651
        old, new = log.get_history_change('3a', '1a', tree.branch.repository)
 
1652
        self.assertEqual([], new)
 
1653
        self.assertEqual(['2a', '3a'], old)
 
1654
 
 
1655
    def test_null_old(self):
 
1656
        tree = self.setup_ab_tree()
 
1657
        old, new = log.get_history_change(revision.NULL_REVISION,
 
1658
                                          '3a', tree.branch.repository)
 
1659
        self.assertEqual([], old)
 
1660
        self.assertEqual(['1a', '2a', '3a'], new)
 
1661
 
 
1662
    def test_null_new(self):
 
1663
        tree = self.setup_ab_tree()
 
1664
        old, new = log.get_history_change('3a', revision.NULL_REVISION,
 
1665
                                          tree.branch.repository)
 
1666
        self.assertEqual([], new)
 
1667
        self.assertEqual(['1a', '2a', '3a'], old)
 
1668
 
 
1669
    def test_diverged(self):
 
1670
        tree = self.setup_ab_tree()
 
1671
        old, new = log.get_history_change('3a', '3b', tree.branch.repository)
 
1672
        self.assertEqual(old, ['2a', '3a'])
 
1673
        self.assertEqual(new, ['2b', '3b'])
 
1674
 
 
1675
    def test_unrelated(self):
 
1676
        tree = self.setup_ac_tree()
 
1677
        old, new = log.get_history_change('3a', '3c', tree.branch.repository)
 
1678
        self.assertEqual(old, ['1a', '2a', '3a'])
 
1679
        self.assertEqual(new, ['1c', '2c', '3c'])
 
1680
 
 
1681
    def test_show_branch_change(self):
 
1682
        tree = self.setup_ab_tree()
 
1683
        s = StringIO()
 
1684
        log.show_branch_change(tree.branch, s, 3, '3a')
 
1685
        self.assertContainsRe(s.getvalue(),
 
1686
            '[*]{60}\nRemoved Revisions:\n(.|\n)*2a(.|\n)*3a(.|\n)*'
 
1687
            '[*]{60}\n\nAdded Revisions:\n(.|\n)*2b(.|\n)*3b')
 
1688
 
 
1689
    def test_show_branch_change_no_change(self):
 
1690
        tree = self.setup_ab_tree()
 
1691
        s = StringIO()
 
1692
        log.show_branch_change(tree.branch, s, 3, '3b')
 
1693
        self.assertEqual(s.getvalue(),
 
1694
            'Nothing seems to have changed\n')
 
1695
 
 
1696
    def test_show_branch_change_no_old(self):
 
1697
        tree = self.setup_ab_tree()
 
1698
        s = StringIO()
 
1699
        log.show_branch_change(tree.branch, s, 2, '2b')
 
1700
        self.assertContainsRe(s.getvalue(), 'Added Revisions:')
 
1701
        self.assertNotContainsRe(s.getvalue(), 'Removed Revisions:')
 
1702
 
 
1703
    def test_show_branch_change_no_new(self):
 
1704
        tree = self.setup_ab_tree()
 
1705
        tree.branch.set_last_revision_info(2, '2b')
 
1706
        s = StringIO()
 
1707
        log.show_branch_change(tree.branch, s, 3, '3b')
 
1708
        self.assertContainsRe(s.getvalue(), 'Removed Revisions:')
 
1709
        self.assertNotContainsRe(s.getvalue(), 'Added Revisions:')