~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/diff.py

  • Committer: Vincent Ladeuil
  • Date: 2010-02-05 10:27:33 UTC
  • mto: (5008.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 5009.
  • Revision ID: v.ladeuil+lp@free.fr-20100205102733-8wpjnqz6g4nvrbfu
All Conflict action method names start with 'action_' to avoid potential namespace collisions

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2014 Canonical Ltd.
 
1
# Copyright (C) 2004, 2005, 2006 Canonical Ltd.
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
from __future__ import absolute_import
18
 
 
19
17
import difflib
20
18
import os
21
19
import re
 
20
import shutil
22
21
import string
23
22
import sys
24
23
 
27
26
import errno
28
27
import subprocess
29
28
import tempfile
 
29
import time
30
30
 
31
31
from bzrlib import (
32
 
    cleanup,
33
 
    cmdline,
34
 
    controldir,
 
32
    branch as _mod_branch,
 
33
    bzrdir,
 
34
    commands,
35
35
    errors,
36
36
    osutils,
37
37
    patiencediff,
41
41
    )
42
42
 
43
43
from bzrlib.workingtree import WorkingTree
44
 
from bzrlib.i18n import gettext
45
44
""")
46
45
 
47
 
from bzrlib.registry import (
48
 
    Registry,
 
46
from bzrlib.symbol_versioning import (
 
47
    deprecated_function,
49
48
    )
50
49
from bzrlib.trace import mutter, note, warning
51
50
 
52
 
DEFAULT_CONTEXT_AMOUNT = 3
53
51
 
54
52
class AtTemplate(string.Template):
55
53
    """Templating class that uses @ instead of $."""
73
71
 
74
72
def internal_diff(old_filename, oldlines, new_filename, newlines, to_file,
75
73
                  allow_binary=False, sequence_matcher=None,
76
 
                  path_encoding='utf8', context_lines=DEFAULT_CONTEXT_AMOUNT):
 
74
                  path_encoding='utf8'):
77
75
    # FIXME: difflib is wrong if there is no trailing newline.
78
76
    # The syntax used by patch seems to be "\ No newline at
79
77
    # end of file" following the last diff line from that
97
95
    if sequence_matcher is None:
98
96
        sequence_matcher = patiencediff.PatienceSequenceMatcher
99
97
    ud = patiencediff.unified_diff(oldlines, newlines,
100
 
                      fromfile=old_filename.encode(path_encoding, 'replace'),
101
 
                      tofile=new_filename.encode(path_encoding, 'replace'),
102
 
                      n=context_lines, sequencematcher=sequence_matcher)
 
98
                      fromfile=old_filename.encode(path_encoding),
 
99
                      tofile=new_filename.encode(path_encoding),
 
100
                      sequencematcher=sequence_matcher)
103
101
 
104
102
    ud = list(ud)
105
103
    if len(ud) == 0: # Identical contents, nothing to do
119
117
 
120
118
 
121
119
def _spawn_external_diff(diffcmd, capture_errors=True):
122
 
    """Spawn the external diff process, and return the child handle.
 
120
    """Spawn the externall diff process, and return the child handle.
123
121
 
124
122
    :param diffcmd: The command list to spawn
125
123
    :param capture_errors: Capture stderr as well as setting LANG=C
154
152
 
155
153
    return pipe
156
154
 
157
 
# diff style options as of GNU diff v3.2
158
 
style_option_list = ['-c', '-C', '--context',
159
 
                     '-e', '--ed',
160
 
                     '-f', '--forward-ed',
161
 
                     '-q', '--brief',
162
 
                     '--normal',
163
 
                     '-n', '--rcs',
164
 
                     '-u', '-U', '--unified',
165
 
                     '-y', '--side-by-side',
166
 
                     '-D', '--ifdef']
167
 
 
168
 
def default_style_unified(diff_opts):
169
 
    """Default to unified diff style if alternative not specified in diff_opts.
170
 
 
171
 
        diff only allows one style to be specified; they don't override.
172
 
        Note that some of these take optargs, and the optargs can be
173
 
        directly appended to the options.
174
 
        This is only an approximate parser; it doesn't properly understand
175
 
        the grammar.
176
 
 
177
 
    :param diff_opts: List of options for external (GNU) diff.
178
 
    :return: List of options with default style=='unified'.
179
 
    """
180
 
    for s in style_option_list:
181
 
        for j in diff_opts:
182
 
            if j.startswith(s):
183
 
                break
184
 
        else:
185
 
            continue
186
 
        break
187
 
    else:
188
 
        diff_opts.append('-u')
189
 
    return diff_opts
190
 
 
191
155
 
192
156
def external_diff(old_filename, oldlines, new_filename, newlines, to_file,
193
157
                  diff_opts):
229
193
                   '--binary',
230
194
                  ]
231
195
 
232
 
        diff_opts = default_style_unified(diff_opts)
 
196
        # diff only allows one style to be specified; they don't override.
 
197
        # note that some of these take optargs, and the optargs can be
 
198
        # directly appended to the options.
 
199
        # this is only an approximate parser; it doesn't properly understand
 
200
        # the grammar.
 
201
        for s in ['-c', '-u', '-C', '-U',
 
202
                  '-e', '--ed',
 
203
                  '-q', '--brief',
 
204
                  '--normal',
 
205
                  '-n', '--rcs',
 
206
                  '-y', '--side-by-side',
 
207
                  '-D', '--ifdef']:
 
208
            for j in diff_opts:
 
209
                if j.startswith(s):
 
210
                    break
 
211
            else:
 
212
                continue
 
213
            break
 
214
        else:
 
215
            diffcmd.append('-u')
233
216
 
234
217
        if diff_opts:
235
218
            diffcmd.extend(diff_opts)
280
263
                msg = 'exit code %d' % rc
281
264
 
282
265
            raise errors.BzrError('external diff failed with %s; command: %r'
283
 
                                  % (msg, diffcmd))
 
266
                                  % (rc, diffcmd))
284
267
 
285
268
 
286
269
    finally:
287
270
        oldtmpf.close()                 # and delete
288
271
        newtmpf.close()
289
 
 
290
 
        def cleanup(path):
291
 
            # Warn in case the file couldn't be deleted (in case windows still
292
 
            # holds the file open, but not if the files have already been
293
 
            # deleted)
294
 
            try:
295
 
                os.remove(path)
296
 
            except OSError, e:
297
 
                if e.errno not in (errno.ENOENT,):
298
 
                    warning('Failed to delete temporary file: %s %s', path, e)
299
 
 
300
 
        cleanup(old_abspath)
301
 
        cleanup(new_abspath)
302
 
 
303
 
 
304
 
def get_trees_and_branches_to_diff_locked(
305
 
    path_list, revision_specs, old_url, new_url, add_cleanup, apply_view=True):
 
272
        # Clean up. Warn in case the files couldn't be deleted
 
273
        # (in case windows still holds the file open, but not
 
274
        # if the files have already been deleted)
 
275
        try:
 
276
            os.remove(old_abspath)
 
277
        except OSError, e:
 
278
            if e.errno not in (errno.ENOENT,):
 
279
                warning('Failed to delete temporary file: %s %s',
 
280
                        old_abspath, e)
 
281
        try:
 
282
            os.remove(new_abspath)
 
283
        except OSError:
 
284
            if e.errno not in (errno.ENOENT,):
 
285
                warning('Failed to delete temporary file: %s %s',
 
286
                        new_abspath, e)
 
287
 
 
288
 
 
289
def get_trees_and_branches_to_diff(path_list, revision_specs, old_url, new_url,
 
290
                                   apply_view=True):
306
291
    """Get the trees and specific files to diff given a list of paths.
307
292
 
308
293
    This method works out the trees to be diff'ed and the files of
319
304
    :param new_url:
320
305
        The url of the new branch or tree. If None, the tree to use is
321
306
        taken from the first path, if any, or the current working tree.
322
 
    :param add_cleanup:
323
 
        a callable like Command.add_cleanup.  get_trees_and_branches_to_diff
324
 
        will register cleanups that must be run to unlock the trees, etc.
325
307
    :param apply_view:
326
308
        if True and a view is set, apply the view or check that the paths
327
309
        are within it
328
310
    :returns:
329
311
        a tuple of (old_tree, new_tree, old_branch, new_branch,
330
312
        specific_files, extra_trees) where extra_trees is a sequence of
331
 
        additional trees to search in for file-ids.  The trees and branches
332
 
        will be read-locked until the cleanups registered via the add_cleanup
333
 
        param are run.
 
313
        additional trees to search in for file-ids.
334
314
    """
335
315
    # Get the old and new revision specs
336
316
    old_revision_spec = None
359
339
        default_location = path_list[0]
360
340
        other_paths = path_list[1:]
361
341
 
362
 
    def lock_tree_or_branch(wt, br):
363
 
        if wt is not None:
364
 
            wt.lock_read()
365
 
            add_cleanup(wt.unlock)
366
 
        elif br is not None:
367
 
            br.lock_read()
368
 
            add_cleanup(br.unlock)
369
 
 
370
342
    # Get the old location
371
343
    specific_files = []
372
344
    if old_url is None:
373
345
        old_url = default_location
374
346
    working_tree, branch, relpath = \
375
 
        controldir.ControlDir.open_containing_tree_or_branch(old_url)
376
 
    lock_tree_or_branch(working_tree, branch)
 
347
        bzrdir.BzrDir.open_containing_tree_or_branch(old_url)
377
348
    if consider_relpath and relpath != '':
378
349
        if working_tree is not None and apply_view:
379
350
            views.check_path_in_view(working_tree, relpath)
386
357
        new_url = default_location
387
358
    if new_url != old_url:
388
359
        working_tree, branch, relpath = \
389
 
            controldir.ControlDir.open_containing_tree_or_branch(new_url)
390
 
        lock_tree_or_branch(working_tree, branch)
 
360
            bzrdir.BzrDir.open_containing_tree_or_branch(new_url)
391
361
        if consider_relpath and relpath != '':
392
362
            if working_tree is not None and apply_view:
393
363
                views.check_path_in_view(working_tree, relpath)
398
368
 
399
369
    # Get the specific files (all files is None, no files is [])
400
370
    if make_paths_wt_relative and working_tree is not None:
401
 
        other_paths = working_tree.safe_relpath_files(
402
 
            other_paths,
 
371
        try:
 
372
            from bzrlib.builtins import safe_relpath_files
 
373
            other_paths = safe_relpath_files(working_tree, other_paths,
403
374
            apply_view=apply_view)
 
375
        except errors.FileInWrongBranch:
 
376
            raise errors.BzrCommandError("Files are in different branches")
404
377
    specific_files.extend(other_paths)
405
378
    if len(specific_files) == 0:
406
379
        specific_files = None
410
383
            if view_files:
411
384
                specific_files = view_files
412
385
                view_str = views.view_display_str(view_files)
413
 
                note(gettext("*** Ignoring files outside view. View is %s") % view_str)
 
386
                note("*** Ignoring files outside view. View is %s" % view_str)
414
387
 
415
388
    # Get extra trees that ought to be searched for file-ids
416
389
    extra_trees = None
417
390
    if working_tree is not None and working_tree not in (old_tree, new_tree):
418
391
        extra_trees = (working_tree,)
419
 
    return (old_tree, new_tree, old_branch, new_branch,
420
 
            specific_files, extra_trees)
 
392
    return old_tree, new_tree, old_branch, new_branch, specific_files, extra_trees
421
393
 
422
394
 
423
395
def _get_tree_to_diff(spec, tree=None, branch=None, basis_is_default=True):
439
411
                    old_label='a/', new_label='b/',
440
412
                    extra_trees=None,
441
413
                    path_encoding='utf8',
442
 
                    using=None,
443
 
                    format_cls=None,
444
 
                    context=DEFAULT_CONTEXT_AMOUNT):
 
414
                    using=None):
445
415
    """Show in text form the changes from one tree to another.
446
416
 
447
 
    :param to_file: The output stream.
448
 
    :param specific_files: Include only changes to these files - None for all
449
 
        changes.
450
 
    :param external_diff_options: If set, use an external GNU diff and pass 
451
 
        these options.
452
 
    :param extra_trees: If set, more Trees to use for looking up file ids
453
 
    :param path_encoding: If set, the path will be encoded as specified, 
454
 
        otherwise is supposed to be utf8
455
 
    :param format_cls: Formatter class (DiffTree subclass)
 
417
    to_file
 
418
        The output stream.
 
419
 
 
420
    specific_files
 
421
        Include only changes to these files - None for all changes.
 
422
 
 
423
    external_diff_options
 
424
        If set, use an external GNU diff and pass these options.
 
425
 
 
426
    extra_trees
 
427
        If set, more Trees to use for looking up file ids
 
428
 
 
429
    path_encoding
 
430
        If set, the path will be encoded as specified, otherwise is supposed
 
431
        to be utf8
456
432
    """
457
 
    if context is None:
458
 
        context = DEFAULT_CONTEXT_AMOUNT
459
 
    if format_cls is None:
460
 
        format_cls = DiffTree
461
433
    old_tree.lock_read()
462
434
    try:
463
435
        if extra_trees is not None:
465
437
                tree.lock_read()
466
438
        new_tree.lock_read()
467
439
        try:
468
 
            differ = format_cls.from_trees_options(old_tree, new_tree, to_file,
469
 
                                                   path_encoding,
470
 
                                                   external_diff_options,
471
 
                                                   old_label, new_label, using,
472
 
                                                   context_lines=context)
 
440
            differ = DiffTree.from_trees_options(old_tree, new_tree, to_file,
 
441
                                                 path_encoding,
 
442
                                                 external_diff_options,
 
443
                                                 old_label, new_label, using)
473
444
            return differ.show_diff(specific_files, extra_trees)
474
445
        finally:
475
446
            new_tree.unlock()
633
604
    # or removed in a diff.
634
605
    EPOCH_DATE = '1970-01-01 00:00:00 +0000'
635
606
 
636
 
    def __init__(self, old_tree, new_tree, to_file, path_encoding='utf-8', 
637
 
                 old_label='', new_label='', text_differ=internal_diff, 
638
 
                 context_lines=DEFAULT_CONTEXT_AMOUNT):
 
607
    def __init__(self, old_tree, new_tree, to_file, path_encoding='utf-8',
 
608
                 old_label='', new_label='', text_differ=internal_diff):
639
609
        DiffPath.__init__(self, old_tree, new_tree, to_file, path_encoding)
640
610
        self.text_differ = text_differ
641
611
        self.old_label = old_label
642
612
        self.new_label = new_label
643
613
        self.path_encoding = path_encoding
644
 
        self.context_lines = context_lines
645
614
 
646
615
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
647
616
        """Compare two files in unified diff format
688
657
        """
689
658
        def _get_text(tree, file_id, path):
690
659
            if file_id is not None:
691
 
                return tree.get_file_lines(file_id, path)
 
660
                return tree.get_file(file_id, path).readlines()
692
661
            else:
693
662
                return []
694
663
        try:
695
664
            from_text = _get_text(self.old_tree, from_file_id, from_path)
696
665
            to_text = _get_text(self.new_tree, to_file_id, to_path)
697
666
            self.text_differ(from_label, from_text, to_label, to_text,
698
 
                             self.to_file, path_encoding=self.path_encoding,
699
 
                             context_lines=self.context_lines)
 
667
                             self.to_file)
700
668
        except errors.BinaryFile:
701
669
            self.to_file.write(
702
670
                  ("Binary files %s and %s differ\n" %
703
 
                  (from_label, to_label)).encode(self.path_encoding,'replace'))
 
671
                  (from_label, to_label)).encode(self.path_encoding))
704
672
        return self.CHANGED
705
673
 
706
674
 
715
683
    @classmethod
716
684
    def from_string(klass, command_string, old_tree, new_tree, to_file,
717
685
                    path_encoding='utf-8'):
718
 
        command_template = cmdline.split(command_string)
 
686
        command_template = commands.shlex_split_unicode(command_string)
719
687
        if '@' not in command_string:
720
688
            command_template.extend(['@old_path', '@new_path'])
721
689
        return klass(command_template, old_tree, new_tree, to_file,
722
690
                     path_encoding)
723
691
 
724
692
    @classmethod
725
 
    def make_from_diff_tree(klass, command_string, external_diff_options=None):
 
693
    def make_from_diff_tree(klass, command_string):
726
694
        def from_diff_tree(diff_tree):
727
 
            full_command_string = [command_string]
728
 
            if external_diff_options is not None:
729
 
                full_command_string += ' ' + external_diff_options
730
 
            return klass.from_string(full_command_string, diff_tree.old_tree,
 
695
            return klass.from_string(command_string, diff_tree.old_tree,
731
696
                                     diff_tree.new_tree, diff_tree.to_file)
732
697
        return from_diff_tree
733
698
 
734
699
    def _get_command(self, old_path, new_path):
735
700
        my_map = {'old_path': old_path, 'new_path': new_path}
736
 
        command = [AtTemplate(t).substitute(my_map) for t in
737
 
                   self.command_template]
738
 
        if sys.platform == 'win32': # Popen doesn't accept unicode on win32
739
 
            command_encoded = []
740
 
            for c in command:
741
 
                if isinstance(c, unicode):
742
 
                    command_encoded.append(c.encode('mbcs'))
743
 
                else:
744
 
                    command_encoded.append(c)
745
 
            return command_encoded
746
 
        else:
747
 
            return command
 
701
        return [AtTemplate(t).substitute(my_map) for t in
 
702
                self.command_template]
748
703
 
749
704
    def _execute(self, old_path, new_path):
750
705
        command = self._get_command(old_path, new_path)
770
725
                raise
771
726
        return True
772
727
 
773
 
    @staticmethod
774
 
    def _fenc():
775
 
        """Returns safe encoding for passing file path to diff tool"""
776
 
        if sys.platform == 'win32':
777
 
            return 'mbcs'
778
 
        else:
779
 
            # Don't fallback to 'utf-8' because subprocess may not be able to
780
 
            # handle utf-8 correctly when locale is not utf-8.
781
 
            return sys.getfilesystemencoding() or 'ascii'
782
 
 
783
 
    def _is_safepath(self, path):
784
 
        """Return true if `path` may be able to pass to subprocess."""
785
 
        fenc = self._fenc()
786
 
        try:
787
 
            return path == path.encode(fenc).decode(fenc)
788
 
        except UnicodeError:
789
 
            return False
790
 
 
791
 
    def _safe_filename(self, prefix, relpath):
792
 
        """Replace unsafe character in `relpath` then join `self._root`,
793
 
        `prefix` and `relpath`."""
794
 
        fenc = self._fenc()
795
 
        # encoded_str.replace('?', '_') may break multibyte char.
796
 
        # So we should encode, decode, then replace(u'?', u'_')
797
 
        relpath_tmp = relpath.encode(fenc, 'replace').decode(fenc, 'replace')
798
 
        relpath_tmp = relpath_tmp.replace(u'?', u'_')
799
 
        return osutils.pathjoin(self._root, prefix, relpath_tmp)
800
 
 
801
728
    def _write_file(self, file_id, tree, prefix, relpath, force_temp=False,
802
729
                    allow_write=False):
803
730
        if not force_temp and isinstance(tree, WorkingTree):
804
 
            full_path = tree.abspath(tree.id2path(file_id))
805
 
            if self._is_safepath(full_path):
806
 
                return full_path
807
 
 
808
 
        full_path = self._safe_filename(prefix, relpath)
 
731
            return tree.abspath(tree.id2path(file_id))
 
732
        
 
733
        full_path = osutils.pathjoin(self._root, prefix, relpath)
809
734
        if not force_temp and self._try_symlink_root(tree, prefix):
810
735
            return full_path
811
736
        parent_dir = osutils.dirname(full_path)
823
748
                target.close()
824
749
        finally:
825
750
            source.close()
 
751
        if not allow_write:
 
752
            osutils.make_readonly(full_path)
826
753
        try:
827
754
            mtime = tree.get_file_mtime(file_id)
828
755
        except errors.FileTimestampUnavailable:
829
 
            pass
830
 
        else:
831
 
            os.utime(full_path, (mtime, mtime))
832
 
        if not allow_write:
833
 
            osutils.make_readonly(full_path)
 
756
            mtime = 0
 
757
        os.utime(full_path, (mtime, mtime))
834
758
        return full_path
835
759
 
836
760
    def _prepare_files(self, file_id, old_path, new_path, force_temp=False,
868
792
        """
869
793
        old_path = self.old_tree.id2path(file_id)
870
794
        new_path = self.new_tree.id2path(file_id)
871
 
        old_abs_path, new_abs_path = self._prepare_files(
872
 
                                            file_id, old_path, new_path,
873
 
                                            allow_write_new=True,
874
 
                                            force_temp=True)
875
 
        command = self._get_command(old_abs_path, new_abs_path)
 
795
        new_abs_path = self._prepare_files(file_id, old_path, new_path,
 
796
                                           allow_write_new=True,
 
797
                                           force_temp=True)[1]
 
798
        command = self._get_command(osutils.pathjoin('old', old_path),
 
799
                                    osutils.pathjoin('new', new_path))
876
800
        subprocess.call(command, cwd=self._root)
877
 
        new_file = open(new_abs_path, 'rb')
 
801
        new_file = open(new_abs_path, 'r')
878
802
        try:
879
803
            return new_file.read()
880
804
        finally:
926
850
    @classmethod
927
851
    def from_trees_options(klass, old_tree, new_tree, to_file,
928
852
                           path_encoding, external_diff_options, old_label,
929
 
                           new_label, using, context_lines):
 
853
                           new_label, using):
930
854
        """Factory for producing a DiffTree.
931
855
 
932
856
        Designed to accept options used by show_diff_trees.
933
 
 
934
857
        :param old_tree: The tree to show as old in the comparison
935
858
        :param new_tree: The tree to show as new in the comparison
936
859
        :param to_file: File to write comparisons to
942
865
        :param using: Commandline to use to invoke an external diff tool
943
866
        """
944
867
        if using is not None:
945
 
            extra_factories = [DiffFromTool.make_from_diff_tree(using, external_diff_options)]
 
868
            extra_factories = [DiffFromTool.make_from_diff_tree(using)]
946
869
        else:
947
870
            extra_factories = []
948
871
        if external_diff_options:
949
872
            opts = external_diff_options.split()
950
 
            def diff_file(olab, olines, nlab, nlines, to_file, path_encoding=None, context_lines=None):
951
 
                """:param path_encoding: not used but required
952
 
                        to match the signature of internal_diff.
953
 
                """
 
873
            def diff_file(olab, olines, nlab, nlines, to_file):
954
874
                external_diff(olab, olines, nlab, nlines, to_file, opts)
955
875
        else:
956
876
            diff_file = internal_diff
957
877
        diff_text = DiffText(old_tree, new_tree, to_file, path_encoding,
958
 
                             old_label, new_label, diff_file, context_lines=context_lines)
 
878
                             old_label, new_label, diff_file)
959
879
        return klass(old_tree, new_tree, to_file, path_encoding, diff_text,
960
880
                     extra_factories)
961
881
 
962
882
    def show_diff(self, specific_files, extra_trees=None):
963
883
        """Write tree diff to self.to_file
964
884
 
965
 
        :param specific_files: the specific files to compare (recursive)
 
885
        :param sepecific_files: the specific files to compare (recursive)
966
886
        :param extra_trees: extra trees to use for mapping paths to file_ids
967
887
        """
968
888
        try:
1058
978
            if error_path is None:
1059
979
                error_path = old_path
1060
980
            raise errors.NoDiffFound(error_path)
1061
 
 
1062
 
 
1063
 
format_registry = Registry()
1064
 
format_registry.register('default', DiffTree)